diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/service_objects/update_legacy_email_table.rb b/lib/service_objects/update_legacy_email_table.rb index abc1234..def5678 100644 --- a/lib/service_objects/update_legacy_email_table.rb +++ b/lib/service_objects/update_legacy_email_table.rb @@ -2,11 +2,11 @@ class UpdateLegacyEmailTable < Base DB = S...
Remove self to include the change hash
diff --git a/app/serializers/group_serializer.rb b/app/serializers/group_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/group_serializer.rb +++ b/app/serializers/group_serializer.rb @@ -6,7 +6,7 @@ def student_count return object.student_count if object.has_attribute?(:student_count) - re...
FIX: Check object has hasKey? in group serializer
diff --git a/lib/secret_mail/controller.rb b/lib/secret_mail/controller.rb index abc1234..def5678 100644 --- a/lib/secret_mail/controller.rb +++ b/lib/secret_mail/controller.rb @@ -8,9 +8,11 @@ module SecretMail class Controller def self.process message, &block - record = MailAction.find_valid(message.to, ...
Handle to and from correctly
diff --git a/lib/fog/aws/models/rds/log_files.rb b/lib/fog/aws/models/rds/log_files.rb index abc1234..def5678 100644 --- a/lib/fog/aws/models/rds/log_files.rb +++ b/lib/fog/aws/models/rds/log_files.rb @@ -6,21 +6,44 @@ class RDS class LogFiles < Fog::Collection + attribute :filters attribut...
Add 'each' that iterates over all log files Use 'select' to do an exact match when seeking a specific log file.
diff --git a/lib/govuk_security_audit/scanner.rb b/lib/govuk_security_audit/scanner.rb index abc1234..def5678 100644 --- a/lib/govuk_security_audit/scanner.rb +++ b/lib/govuk_security_audit/scanner.rb @@ -12,6 +12,10 @@ @root = File.dirname(path) @database = Bundler::Audit::Database.new + + # Stop B...
Allow Scanner to work outside a Bundler environment When a LockfileParser is initialised, Bundler will try to find the related Gemfile in the current directory’s hierarchy. If the tool is run from a directory that doesn't have a Gemfile in its hierarchy, Bundler will raise an exception and make the tool fail. As we d...
diff --git a/lib/saxlsx/column_name_generator.rb b/lib/saxlsx/column_name_generator.rb index abc1234..def5678 100644 --- a/lib/saxlsx/column_name_generator.rb +++ b/lib/saxlsx/column_name_generator.rb @@ -8,9 +8,9 @@ if char.nil? FIRST elsif char < LAST - previous[0..-2] + (char.ord + 1).ch...
Simplify column name generator more
diff --git a/omnibus-ansible-dk/config/software/serverspec.rb b/omnibus-ansible-dk/config/software/serverspec.rb index abc1234..def5678 100644 --- a/omnibus-ansible-dk/config/software/serverspec.rb +++ b/omnibus-ansible-dk/config/software/serverspec.rb @@ -2,7 +2,7 @@ default_version "master" relative_path "serverspec...
Fix another bad git URL
diff --git a/lib/trailblazer/rails/controller.rb b/lib/trailblazer/rails/controller.rb index abc1234..def5678 100644 --- a/lib/trailblazer/rails/controller.rb +++ b/lib/trailblazer/rails/controller.rb @@ -34,7 +34,7 @@ module Render def render(cell=nil, options={}, *, &block) - return super unless d...
Revert "Check whether Cell is defined before trying to render" This reverts commit d70a98a4fde47936d618433a66175c158c2898dd.
diff --git a/lib/catarse_stripe/engine.rb b/lib/catarse_stripe/engine.rb index abc1234..def5678 100644 --- a/lib/catarse_stripe/engine.rb +++ b/lib/catarse_stripe/engine.rb @@ -5,15 +5,15 @@ #end module ActionDispatch::Routing class Mapper - def mount_catarse_stripe_at(mount_location) - scope mount_location...
Change route to share application
diff --git a/spec/integration/aws_internet_gateway_spec.rb b/spec/integration/aws_internet_gateway_spec.rb index abc1234..def5678 100644 --- a/spec/integration/aws_internet_gateway_spec.rb +++ b/spec/integration/aws_internet_gateway_spec.rb @@ -0,0 +1,46 @@+require 'spec_helper' + +describe Chef::Resource::AwsInternetG...
Add integration tests for the aws_internet_gateway provider.
diff --git a/app/validators/date_validator.rb b/app/validators/date_validator.rb index abc1234..def5678 100644 --- a/app/validators/date_validator.rb +++ b/app/validators/date_validator.rb @@ -4,7 +4,7 @@ if parts.any?(&:present?) parsed = Date.civil *parts.map(&:to_i) rescue nil - record.errors.add a...
Remove static translation path and just let active model errors do its own thing - keeps the lookup process the same as any other error
diff --git a/app/workers/csv_export_worker.rb b/app/workers/csv_export_worker.rb index abc1234..def5678 100644 --- a/app/workers/csv_export_worker.rb +++ b/app/workers/csv_export_worker.rb @@ -5,7 +5,7 @@ csv_export = CsvExport.find(csv_export_id) return if csv_export.sent? csv_export.export! - CsvExpo...
Fix rails 4.2+ deprecated warnings for MessageDelivery.deliver() Rails 4.2+ deprecated ActionMailer::MessageDelivery.deliver() in favor of a split interface deliver_now() and deliver_later(). The old deliver() was plumbed through to deliver_now(). Let's just use that directly. empirical-core currently uses rails (4....
diff --git a/test/service_test_case.rb b/test/service_test_case.rb index abc1234..def5678 100644 --- a/test/service_test_case.rb +++ b/test/service_test_case.rb @@ -1,11 +1,11 @@ require 'test_helper' -require 'capybara/poltergeist' +# require 'capybara/poltergeist' require 'minitest/metadata' -require 'helpers/ca...
Remove unneeded packages from ServiceTestCase object.
diff --git a/lib/jiffy/outputters/json.rb b/lib/jiffy/outputters/json.rb index abc1234..def5678 100644 --- a/lib/jiffy/outputters/json.rb +++ b/lib/jiffy/outputters/json.rb @@ -12,8 +12,6 @@ rule :begin_string, :payload => "\"" rule :end_string, :payload => "\"" rule :null, :payload => "null" - ...
Remove handling of :nan and :inf tokens The parser stopped emitting these tokens a while ago.
diff --git a/lib/tasks/announcements.rake b/lib/tasks/announcements.rake index abc1234..def5678 100644 --- a/lib/tasks/announcements.rake +++ b/lib/tasks/announcements.rake @@ -4,9 +4,10 @@ desc 'Announce blocking feature' task blocking: :environment do message = <<-TXT.squish - A partir de ahora, puedes...
Clarify usage of blockings in the announcement People don't seem to have understand the feature. We'll destroy the current announcement and create another one with more explanations.
diff --git a/spec/services/external_users/create_user_spec.rb b/spec/services/external_users/create_user_spec.rb index abc1234..def5678 100644 --- a/spec/services/external_users/create_user_spec.rb +++ b/spec/services/external_users/create_user_spec.rb @@ -0,0 +1,42 @@+require 'rails_helper' + +RSpec.describe ExternalU...
Add test coverage for create user service
diff --git a/netuitive_rails_agent.gemspec b/netuitive_rails_agent.gemspec index abc1234..def5678 100644 --- a/netuitive_rails_agent.gemspec +++ b/netuitive_rails_agent.gemspec @@ -10,7 +10,7 @@ s.files = files s.homepage = 'http://rubygems.org/gems/netuitive_rails_agent' - s.license = 'Apache v2.0'...
Update Gemspec to use a valid license
diff --git a/spec/functional/fc082_spec.rb b/spec/functional/fc082_spec.rb index abc1234..def5678 100644 --- a/spec/functional/fc082_spec.rb +++ b/spec/functional/fc082_spec.rb @@ -15,4 +15,9 @@ recipe_file "node.normal['foo']['bar'] = baz" it { is_expected.to_not violate_rule } end + + context "with a coo...
Expand the test for the read scenario Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/lib/tasks/import/covid19_mhclg.rake b/lib/tasks/import/covid19_mhclg.rake index abc1234..def5678 100644 --- a/lib/tasks/import/covid19_mhclg.rake +++ b/lib/tasks/import/covid19_mhclg.rake @@ -0,0 +1,64 @@+require "csv" + +# rubocop:disable Metrics/BlockLength +namespace :import do + desc "Imports COVID-19...
Add script to import COVID urls from MHCLG MHCLG have been collecting local URLs for supporting vulnerable people from local council websites in a [Google Sheet][]. This script imports them into Local Links Manager for LGSL 1287 and LGIL 8, based on the rationale in [this PR][624]. The script fetches the CSV directly...
diff --git a/lib/tasks/migrate/migrate_iids.rake b/lib/tasks/migrate/migrate_iids.rake index abc1234..def5678 100644 --- a/lib/tasks/migrate/migrate_iids.rake +++ b/lib/tasks/migrate/migrate_iids.rake @@ -0,0 +1,31 @@+desc "GITLAB | Build internal ids for issues and merge requests" +task migrate_iids: :environment do +...
Create task to create iid for existing issues/mr
diff --git a/lib/convection/model/template/resource/aws_sqs_queue_policy.rb b/lib/convection/model/template/resource/aws_sqs_queue_policy.rb index abc1234..def5678 100644 --- a/lib/convection/model/template/resource/aws_sqs_queue_policy.rb +++ b/lib/convection/model/template/resource/aws_sqs_queue_policy.rb @@ -12,7 +1...
Use aggregation approach for building queue list.
diff --git a/boxen.gemspec b/boxen.gemspec index abc1234..def5678 100644 --- a/boxen.gemspec +++ b/boxen.gemspec @@ -21,6 +21,6 @@ gem.add_dependency "octokit", "~> 1.15" gem.add_dependency "puppet", "~> 3.0" - gem.add_development_dependency "minitest", "3.5.0" # pinned for mocha - gem.add_d...
Update minitest and mocha dependencies
diff --git a/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec b/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec index abc1234..def5678 100644 --- a/railties/lib/rails/generators/rails/plugin_new/templates/%name%.gemspec +++ b/railties/lib/rails/generators/rails/plugin_new/...
Tidy up a bit plugin new gemspec
diff --git a/script/marriage-abroad-responses-leading-to-outcome-for-country.rb b/script/marriage-abroad-responses-leading-to-outcome-for-country.rb index abc1234..def5678 100644 --- a/script/marriage-abroad-responses-leading-to-outcome-for-country.rb +++ b/script/marriage-abroad-responses-leading-to-outcome-for-countr...
Add script to list responses for country and outcome This displays the responses for the specified country that lead to the specified outcome. It's going to help me when extracting the marriage-abroad services from the templates.
diff --git a/spec/features/user_studies_spec.rb b/spec/features/user_studies_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_studies_spec.rb +++ b/spec/features/user_studies_spec.rb @@ -0,0 +1,42 @@+require "rails_helper" +require "support/user_account_feature_helper" + +RSpec.describe "User studies page...
Add feature specs for user studies page
diff --git a/test/unit/services/panopticon_registerer_test.rb b/test/unit/services/panopticon_registerer_test.rb index abc1234..def5678 100644 --- a/test/unit/services/panopticon_registerer_test.rb +++ b/test/unit/services/panopticon_registerer_test.rb @@ -12,6 +12,27 @@ assert_requested(request, times: 2) end ...
Add test for data sent to panopticon We'd like to test exactly what is being sent to panopticon. This test verifies the JSON payload sent to the API.
diff --git a/lib/facter/mac_encryption_enabled.rb b/lib/facter/mac_encryption_enabled.rb index abc1234..def5678 100644 --- a/lib/facter/mac_encryption_enabled.rb +++ b/lib/facter/mac_encryption_enabled.rb @@ -6,7 +6,7 @@ confine :kernel => "Darwin" setcode do osver = Facter.value('macosx_productversion_majo...
Support for an unreleased OS
diff --git a/lib/noir/command/new/makefile/tex.rb b/lib/noir/command/new/makefile/tex.rb index abc1234..def5678 100644 --- a/lib/noir/command/new/makefile/tex.rb +++ b/lib/noir/command/new/makefile/tex.rb @@ -19,7 +19,7 @@ .PHONY : clean all open remake clean: - rm -f *.dvi *.aux *.log *.pdf *.ps *.gz *.bbl *.blg *....
Add *.cpt to clean up targets for TeX Makefile
diff --git a/sumo_seed.gemspec b/sumo_seed.gemspec index abc1234..def5678 100644 --- a/sumo_seed.gemspec +++ b/sumo_seed.gemspec @@ -26,4 +26,5 @@ s.add_development_dependency "rspec", "~> 3.3.0" s.add_development_dependency "database_cleaner" s.add_development_dependency "carrierwave" + s.add_development_depe...
Add missing pg dependency for travis
diff --git a/lib/travis/logs/sidekiq/log_parts.rb b/lib/travis/logs/sidekiq/log_parts.rb index abc1234..def5678 100644 --- a/lib/travis/logs/sidekiq/log_parts.rb +++ b/lib/travis/logs/sidekiq/log_parts.rb @@ -12,6 +12,7 @@ sidekiq_options queue: 'log_parts', retry: 3 def perform(payload) + T...
Add more logging around receiver -> logs handoff
diff --git a/lib/hn_history/app.rb b/lib/hn_history/app.rb index abc1234..def5678 100644 --- a/lib/hn_history/app.rb +++ b/lib/hn_history/app.rb @@ -1,20 +1,25 @@ require 'hn_history' -require 'hn_history/api' -require 'hn_history/web' + +require 'grape' +require 'sinatra' if ENV['RACK_ENV'] == "production" requi...
Rearrange to get Grape support working
diff --git a/json_key_transformer_middleware.gemspec b/json_key_transformer_middleware.gemspec index abc1234..def5678 100644 --- a/json_key_transformer_middleware.gemspec +++ b/json_key_transformer_middleware.gemspec @@ -15,5 +15,5 @@ gem.add_runtime_dependency('oj', '2.14.2') gem.add_runtime_dependency('oj_mimi...
Change Rails dependency to be '>= 5.0.0.beta1'
diff --git a/lib/nutrella/cache.rb b/lib/nutrella/cache.rb index abc1234..def5678 100644 --- a/lib/nutrella/cache.rb +++ b/lib/nutrella/cache.rb @@ -39,7 +39,7 @@ end def cache_contents - @cached_cache_contents ||= YAML.load_file(path) + @cache_contents ||= YAML.load_file(path) end end end...
Use idiomatic naming of memoization.
diff --git a/lib/tfa/storage.rb b/lib/tfa/storage.rb index abc1234..def5678 100644 --- a/lib/tfa/storage.rb +++ b/lib/tfa/storage.rb @@ -2,8 +2,8 @@ class Storage include Enumerable - def initialize(filename:) - @storage = PStore.new(File.join(Dir.home, ".#{filename}.pstore")) + def initialize(optio...
Read the filename property being passed in
diff --git a/lib/twingly/url.rb b/lib/twingly/url.rb index abc1234..def5678 100644 --- a/lib/twingly/url.rb +++ b/lib/twingly/url.rb @@ -2,14 +2,14 @@ require 'public_suffix' PublicSuffix::List.private_domains = false - -SCHEMES = %w(http https) module Twingly module URL module_function UrlObject =...
Move SCHEMES from the global namespace into UrlObject
diff --git a/lib/schnitzel/text.rb b/lib/schnitzel/text.rb index abc1234..def5678 100644 --- a/lib/schnitzel/text.rb +++ b/lib/schnitzel/text.rb @@ -2,11 +2,11 @@ class Text < Node attr_accessor :color, :text - def initialize(text: "", color: 0xffffffff, size: 20, **args) + def initialize(text: "", font:...
Set the font in Text.new
diff --git a/honey_format.gemspec b/honey_format.gemspec index abc1234..def5678 100644 --- a/honey_format.gemspec +++ b/honey_format.gemspec @@ -23,4 +23,5 @@ spec.add_development_dependency 'benchmark-ips' spec.add_development_dependency 'rspec' spec.add_development_dependency 'simplecov' + spec.add_developme...
Add byebug to development dependenies for debugging
diff --git a/lib/active_admin/gallery/engine.rb b/lib/active_admin/gallery/engine.rb index abc1234..def5678 100644 --- a/lib/active_admin/gallery/engine.rb +++ b/lib/active_admin/gallery/engine.rb @@ -4,7 +4,7 @@ class Engine < ::Rails::Engine engine_name "activeadmin_gallery" - initializer "Railsyard...
Fix assets precompile with config.assets.initialize_on_precompile = true
diff --git a/lib/api.rb b/lib/api.rb index abc1234..def5678 100644 --- a/lib/api.rb +++ b/lib/api.rb @@ -7,6 +7,10 @@ configure do enable :cross_origin +end + +configure :development do + set :show_exceptions, :after_handler end configure :production do @@ -35,14 +39,14 @@ end get '/' do - jsonp(details: ...
Use error helper in development
diff --git a/lib/conductor/conductor_invalid.rb b/lib/conductor/conductor_invalid.rb index abc1234..def5678 100644 --- a/lib/conductor/conductor_invalid.rb +++ b/lib/conductor/conductor_invalid.rb @@ -1,5 +1,5 @@ module Conductor - class ConductorInvalid < Exception + class ConductorInvalid < StandardError attr_...
Make Conductor::ConductorInvalid subclass StandardError rather than Exception
diff --git a/lib/configurethis/configuration.rb b/lib/configurethis/configuration.rb index abc1234..def5678 100644 --- a/lib/configurethis/configuration.rb +++ b/lib/configurethis/configuration.rb @@ -10,7 +10,7 @@ def root=(key) @values = load_configuration.fetch(key) - rescue KeyError + rescue ::Ke...
Resolve unitialized constant error in Ruby 1.8.7
diff --git a/plugins/system/conntrack-metrics.rb b/plugins/system/conntrack-metrics.rb index abc1234..def5678 100644 --- a/plugins/system/conntrack-metrics.rb +++ b/plugins/system/conntrack-metrics.rb @@ -39,7 +39,7 @@ default: 'conntrack' def run - value = `conntrack -C #{config[:table]}`.strip + v...
Exclude errors in the conntrack shell output This keeps warning messages from being sent to graphite in addition to the metric values.
diff --git a/modules/auxiliary/scanner/http/wordpress/wp_mashshare_info_disclosure.rb b/modules/auxiliary/scanner/http/wordpress/wp_mashshare_info_disclosure.rb index abc1234..def5678 100644 --- a/modules/auxiliary/scanner/http/wordpress/wp_mashshare_info_disclosure.rb +++ b/modules/auxiliary/scanner/http/wordpress/wp_...
Add WordPress Mashshare Plugin Info Disclosure.
diff --git a/lib/map.rb b/lib/map.rb index abc1234..def5678 100644 --- a/lib/map.rb +++ b/lib/map.rb @@ -1,9 +1,13 @@ class Map - def initialize(window, mapfile) - @window = window - @tileset = Gosu::Image.load_tiles(window, 'media/32x32diagonal_lines.png', - 32, 32, false) - end ...
Create get_lines method, covert tabs to spaces
diff --git a/test/appharbor_test.rb b/test/appharbor_test.rb index abc1234..def5678 100644 --- a/test/appharbor_test.rb +++ b/test/appharbor_test.rb @@ -15,6 +15,9 @@ branches = JSON.parse(env[:body])['branches'] assert_equal 1, branches.size + + branch = branches[payload['ref'].sub(/\Arefs\/heads\/...
Verify that payload ref name is in the list of branches
diff --git a/test/wolverine_test.rb b/test/wolverine_test.rb index abc1234..def5678 100644 --- a/test/wolverine_test.rb +++ b/test/wolverine_test.rb @@ -8,10 +8,10 @@ end def test_reset! - dir = Wolverine.root_directory - assert_equal Wolverine.root_directory, dir + dir = Wolverine.send(:root_directory)...
Fix broken test stemmed from private class method
diff --git a/Casks/intellij-idea-eap.rb b/Casks/intellij-idea-eap.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-eap.rb +++ b/Casks/intellij-idea-eap.rb @@ -1,6 +1,6 @@ cask :v1 => 'intellij-idea-eap' do - version '141.104.1' - sha256 'a59b096cbf012f42dbaf108026de12fa1a3caf16a0f87cbc5f20aa44fa2f2156' + v...
Update IntelliJ IDEA EAP to version 141.588.1
diff --git a/lib/formatters/update_formatter.rb b/lib/formatters/update_formatter.rb index abc1234..def5678 100644 --- a/lib/formatters/update_formatter.rb +++ b/lib/formatters/update_formatter.rb @@ -8,18 +8,22 @@ end def example_passed(notification) - report_status notification.example.location, "passed" + ...
Include backtrace when reporting example results
diff --git a/spec/requests/large_request_spec.rb b/spec/requests/large_request_spec.rb index abc1234..def5678 100644 --- a/spec/requests/large_request_spec.rb +++ b/spec/requests/large_request_spec.rb @@ -5,7 +5,7 @@ RSpec.describe 'A very large request', type: :request do it 'should not overflow cookies' do - ...
Fix namespacing in cookies test NameError: uninitialized constant ActionDispatch::Cookies::SignedCookieJar::MAX_COOKIE_SIZE # ./spec/requests/large_request_spec.rb:8
diff --git a/spree_personalised_products.gemspec b/spree_personalised_products.gemspec index abc1234..def5678 100644 --- a/spree_personalised_products.gemspec +++ b/spree_personalised_products.gemspec @@ -18,7 +18,7 @@ s.add_dependency 'spree_core', '~> 1.2.0' - s.add_development_dependency 'capybara' + s.add_d...
Update gemspect to keep capybara on 1.1
diff --git a/lib/kosmos/packages/kw_rocketry.rb b/lib/kosmos/packages/kw_rocketry.rb index abc1234..def5678 100644 --- a/lib/kosmos/packages/kw_rocketry.rb +++ b/lib/kosmos/packages/kw_rocketry.rb @@ -0,0 +1,8 @@+class KWRocketry < Kosmos::Package + title 'KW Rocketry' + url 'http://kerbalspaceport.com/wp/wp-content/...
Add a package for KW-rocketry.
diff --git a/lib/kracken/token_authenticator.rb b/lib/kracken/token_authenticator.rb index abc1234..def5678 100644 --- a/lib/kracken/token_authenticator.rb +++ b/lib/kracken/token_authenticator.rb @@ -19,11 +19,15 @@ end def body - JSON.parse(response.body) + if response + JSON.parse(respons...
Add nil check for request before calling methods Demeter: It's the law. This will allow the token auth object to respond with nill if the response was never created or set to nil for some reason.
diff --git a/provider/lib/tasks/rcov.rake b/provider/lib/tasks/rcov.rake index abc1234..def5678 100644 --- a/provider/lib/tasks/rcov.rake +++ b/provider/lib/tasks/rcov.rake @@ -0,0 +1,43 @@+begin + require 'rcov/rcovtask' +rescue LoadError + raise 'Could not find the rcov gem, please run `gem install rcov` to get som...
Add a task to generate coverage reports.
diff --git a/Library/Homebrew/test/dev-cmd/bump_spec.rb b/Library/Homebrew/test/dev-cmd/bump_spec.rb index abc1234..def5678 100644 --- a/Library/Homebrew/test/dev-cmd/bump_spec.rb +++ b/Library/Homebrew/test/dev-cmd/bump_spec.rb @@ -8,7 +8,7 @@ it_behaves_like "parseable arguments" end - describe "formula", :...
Mark `brew bump` test with `:needs_network.
diff --git a/lib/processor/observer/null_observer.rb b/lib/processor/observer/null_observer.rb index abc1234..def5678 100644 --- a/lib/processor/observer/null_observer.rb +++ b/lib/processor/observer/null_observer.rb @@ -7,7 +7,7 @@ attr_reader :processor def initialize(options = {}) - @messenger ...
Use STDERR as default stream for messenger
diff --git a/lib/active_ldap_fabrication.rb b/lib/active_ldap_fabrication.rb index abc1234..def5678 100644 --- a/lib/active_ldap_fabrication.rb +++ b/lib/active_ldap_fabrication.rb @@ -1,4 +1,4 @@-# Copyright (C) 2011 Kouhei Sutou <kou@clear-code.com> +# Copyright (C) 2011-2013 Kouhei Sutou <kou@clear-code.com> # #...
Use " (double quote) for string literal
diff --git a/lib/front_end_builds/engine.rb b/lib/front_end_builds/engine.rb index abc1234..def5678 100644 --- a/lib/front_end_builds/engine.rb +++ b/lib/front_end_builds/engine.rb @@ -1,5 +1,3 @@-require 'active_model_serializers' - module FrontEndBuilds class Engine < ::Rails::Engine isolate_namespace FrontE...
Remove require call to ams
diff --git a/lib/ggi/definition_importer.rb b/lib/ggi/definition_importer.rb index abc1234..def5678 100644 --- a/lib/ggi/definition_importer.rb +++ b/lib/ggi/definition_importer.rb @@ -14,7 +14,7 @@ def import return @@definitions if @@definitions - json = File.read(File.join(__dir__, '..', '..', 'public', ...
Improve syntax for finding file, fixes spec
diff --git a/Formula/mplayer.rb b/Formula/mplayer.rb index abc1234..def5678 100644 --- a/Formula/mplayer.rb +++ b/Formula/mplayer.rb @@ -5,22 +5,27 @@ head 'svn://svn.mplayerhq.hu/mplayer/trunk' depends_on 'pkg-config' => :recommended + depends_on 'yasm' => :optional # http://github.com/mxcl/homebrew/issue...
Update Mplayer formula to compile on 10.5.
diff --git a/lib/juicy/build_environment.rb b/lib/juicy/build_environment.rb index abc1234..def5678 100644 --- a/lib/juicy/build_environment.rb +++ b/lib/juicy/build_environment.rb @@ -1,10 +1,11 @@ module Juicy + BUILD_SENSITIVE_VARIABLES = %w[RUBYOPT BUNDLE_GEMFILE RACK_ENV MONGOLAB_URI] class BuildEnvironment ...
Define the variables to be cleaned for testing
diff --git a/lib/rack/tracker/controller.rb b/lib/rack/tracker/controller.rb index abc1234..def5678 100644 --- a/lib/rack/tracker/controller.rb +++ b/lib/rack/tracker/controller.rb @@ -3,7 +3,7 @@ module Controller def tracker(&block) if block_given? - yield(Rack::Tracker::HandlerDelegator....
Add support for Rails 5.1 Rails controller `env` was deprecated and removed but we love backwards compatibility and keep the old behaviour
diff --git a/lib/tasks/lint_alert_docs.rake b/lib/tasks/lint_alert_docs.rake index abc1234..def5678 100644 --- a/lib/tasks/lint_alert_docs.rake +++ b/lib/tasks/lint_alert_docs.rake @@ -0,0 +1,27 @@+desc "Check if the monitoring_docs_url's in puppet definitions link to an existing page" +task :lint_alert_docs do + chec...
Add rake task to verify that docs & puppet are in sync
diff --git a/lib/tasks/update_printers.rake b/lib/tasks/update_printers.rake index abc1234..def5678 100644 --- a/lib/tasks/update_printers.rake +++ b/lib/tasks/update_printers.rake @@ -1,19 +1,32 @@+require 'csv' require 'net/http' + +def get_all_csv + uri = URI 'http://print.chalmers.se/public/pls.cgi' + res = Net:...
Make printer adding script repeatable
diff --git a/lib/twterm/tab/mentions_tab.rb b/lib/twterm/tab/mentions_tab.rb index abc1234..def5678 100644 --- a/lib/twterm/tab/mentions_tab.rb +++ b/lib/twterm/tab/mentions_tab.rb @@ -2,6 +2,18 @@ module Tab class MentionsTab include StatusesTab + + def close + fail NotClosableError + en...
Sort methods of Tab::MentionsTab in alphabetical order
diff --git a/manageiq-appliance-dependencies.rb b/manageiq-appliance-dependencies.rb index abc1234..def5678 100644 --- a/manageiq-appliance-dependencies.rb +++ b/manageiq-appliance-dependencies.rb @@ -1,2 +1,2 @@ # Add gems here, in Gemfile syntax, which are dependencies of the appliance itself rather than a part of th...
Move minimum to 7.0.2 to bring in the latest manageiq-password
diff --git a/LYCategory.podspec b/LYCategory.podspec index abc1234..def5678 100644 --- a/LYCategory.podspec +++ b/LYCategory.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = 'LYCategory' - s.version = '1.2.8' + s.version = '1.2.9' s.summary = 'The categories.' ...
Modify : pod spec version 1.2.9
diff --git a/united-workers.gemspec b/united-workers.gemspec index abc1234..def5678 100644 --- a/united-workers.gemspec +++ b/united-workers.gemspec @@ -21,4 +21,6 @@ spec.add_development_dependency "bundler", "~> 1.5" spec.add_development_dependency "rake" spec.add_development_dependency "rspec" + + spec.add_...
Add runtime gem dependency on bunny
diff --git a/PageMenuController.podspec b/PageMenuController.podspec index abc1234..def5678 100644 --- a/PageMenuController.podspec +++ b/PageMenuController.podspec @@ -20,5 +20,5 @@ 'PageMenuController' => ['PageMenuController/Resources/**/*.xib'] } - s.dependency 'SnapKit' + s.dependency 'SnapKit', '~> 0.2...
Change dependency to swift 2 version of snapkit
diff --git a/app/controllers/forem/moderation_controller.rb b/app/controllers/forem/moderation_controller.rb index abc1234..def5678 100644 --- a/app/controllers/forem/moderation_controller.rb +++ b/app/controllers/forem/moderation_controller.rb @@ -31,7 +31,7 @@ helper_method :forum def ensure_moderator_or_a...
Revert accidental breakage of moderator/admin checking in moderation controller
diff --git a/app/controllers/incline/sessions_controller.rb b/app/controllers/incline/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/incline/sessions_controller.rb +++ b/app/controllers/incline/sessions_controller.rb @@ -12,7 +12,9 @@ ## # GET /incline/login def new - + ...
Check for external auth before login.
diff --git a/app/models/neighborly/balanced/verification.rb b/app/models/neighborly/balanced/verification.rb index abc1234..def5678 100644 --- a/app/models/neighborly/balanced/verification.rb +++ b/app/models/neighborly/balanced/verification.rb @@ -0,0 +1,28 @@+module Neighborly::Balanced + class Verification + def...
Create our version of Balanced::Verification with a bank account
diff --git a/section03/lesson03/trouble.rb b/section03/lesson03/trouble.rb index abc1234..def5678 100644 --- a/section03/lesson03/trouble.rb +++ b/section03/lesson03/trouble.rb @@ -0,0 +1,31 @@+# Section 3 - Lesson 3 - New Chords Cm, Fm, Gm, Db, Eb, Ab +# Trouble - Coldplay +require "#{Dir.home}/ruby/pianoforall/sectio...
Add Trouble, and finish lesson 3
diff --git a/spec/helpers/application_helper/buttons/catalog_item_button_spec.rb b/spec/helpers/application_helper/buttons/catalog_item_button_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/application_helper/buttons/catalog_item_button_spec.rb +++ b/spec/helpers/application_helper/buttons/catalog_item_button...
Add Rspec test for the new CatalogItemButton class
diff --git a/app/controllers/spree/api/taxons_controller.rb b/app/controllers/spree/api/taxons_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/api/taxons_controller.rb +++ b/app/controllers/spree/api/taxons_controller.rb @@ -0,0 +1,77 @@+module Spree + module Api + class TaxonsController < S...
Bring spree/api/taxons controller from spree_api as it is needed in OFN admin
diff --git a/app/overrides/spree/admin/shared/_main_menu.rb b/app/overrides/spree/admin/shared/_main_menu.rb index abc1234..def5678 100644 --- a/app/overrides/spree/admin/shared/_main_menu.rb +++ b/app/overrides/spree/admin/shared/_main_menu.rb @@ -2,7 +2,7 @@ virtual_path: 'spree/admin/shared/_main_menu', name: '...
Fix main menu deface when current_user doesn't exists Context: When user visit /admin/password/recover the app throws this error `ActionView::Template::Error (undefined method `vendors' for nil:NilClass)`
diff --git a/app/calculators/service_life_calculator.rb b/app/calculators/service_life_calculator.rb index abc1234..def5678 100644 --- a/app/calculators/service_life_calculator.rb +++ b/app/calculators/service_life_calculator.rb @@ -15,10 +15,26 @@ asset.manufacture_year + @policy.get_policy_item(asset).max_service...
Fix servcie life calculator to report the first year that the replacement policy became effective for an asset
diff --git a/app/controllers/public_pages_controller.rb b/app/controllers/public_pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/public_pages_controller.rb +++ b/app/controllers/public_pages_controller.rb @@ -12,6 +12,10 @@ not_found if @profile_user.nil? @profile = @profile_user.profil...
Create @conversation if the user is signed in
diff --git a/app/controllers/scm_projects_controller.rb b/app/controllers/scm_projects_controller.rb index abc1234..def5678 100644 --- a/app/controllers/scm_projects_controller.rb +++ b/app/controllers/scm_projects_controller.rb @@ -1,3 +1,4 @@+ class ScmProjectsController < ApplicationController before_filter :che...
Set company for new scm_project.
diff --git a/db/migrate/20180831164909_add_index_for_identifier_to_prometheus_metric.rb b/db/migrate/20180831164909_add_index_for_identifier_to_prometheus_metric.rb index abc1234..def5678 100644 --- a/db/migrate/20180831164909_add_index_for_identifier_to_prometheus_metric.rb +++ b/db/migrate/20180831164909_add_index_fo...
Fix add index prometheus metric
diff --git a/db/20091021092157_add_name_class_name_index.rb b/db/20091021092157_add_name_class_name_index.rb index abc1234..def5678 100644 --- a/db/20091021092157_add_name_class_name_index.rb +++ b/db/20091021092157_add_name_class_name_index.rb @@ -0,0 +1,9 @@+class AddNameClassNameIndex < ActiveRecord::Migration + de...
Add an index for a frequent query.
diff --git a/lib/claide.rb b/lib/claide.rb index abc1234..def5678 100644 --- a/lib/claide.rb +++ b/lib/claide.rb @@ -11,7 +11,7 @@ VERSION = '0.5.0' require 'claide/ansi' - require 'claide/ansi/string_mixin_disable' + require 'claide/ansi/string_mixin' require 'claide/argv' require 'claide/command' re...
[CLAide] Load by default the enabled string mixin
diff --git a/app/controllers/repositories_controller.rb b/app/controllers/repositories_controller.rb index abc1234..def5678 100644 --- a/app/controllers/repositories_controller.rb +++ b/app/controllers/repositories_controller.rb @@ -8,8 +8,8 @@ https://github.com/datasets/house-prices-us.git git://github.c...
Add a bitbucket sample URL
diff --git a/app/controllers/tok/sessions_controller.rb b/app/controllers/tok/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/tok/sessions_controller.rb +++ b/app/controllers/tok/sessions_controller.rb @@ -5,7 +5,7 @@ @model = model_class.authenticate(model_params) if @model - ...
Return the authentication token only on login
diff --git a/app/models/cloud_model/services/mongodb.rb b/app/models/cloud_model/services/mongodb.rb index abc1234..def5678 100644 --- a/app/models/cloud_model/services/mongodb.rb +++ b/app/models/cloud_model/services/mongodb.rb @@ -15,7 +15,7 @@ return false unless has_backups timestamp = Time.now.str...
Make mongo service Backup more reliable
diff --git a/app/models/concerns/door/loggable.rb b/app/models/concerns/door/loggable.rb index abc1234..def5678 100644 --- a/app/models/concerns/door/loggable.rb +++ b/app/models/concerns/door/loggable.rb @@ -4,7 +4,7 @@ included do has_one :log_entry, as: :loggable before_create :associate_log_entry - #...
Revert "Remove IRC logging of door events" This reverts commit d80d873fb65b6a187f3cafa2c5617f60c135a77e.
diff --git a/db/migrate/20110724135047_add_route_segment_stop_area_indices.rb b/db/migrate/20110724135047_add_route_segment_stop_area_indices.rb index abc1234..def5678 100644 --- a/db/migrate/20110724135047_add_route_segment_stop_area_indices.rb +++ b/db/migrate/20110724135047_add_route_segment_stop_area_indices.rb @@ ...
Add indexes on route and stop_area columns of route_segment - used together in stop finding queries.
diff --git a/spec/mutations/devices/dump_spec.rb b/spec/mutations/devices/dump_spec.rb index abc1234..def5678 100644 --- a/spec/mutations/devices/dump_spec.rb +++ b/spec/mutations/devices/dump_spec.rb @@ -10,6 +10,12 @@ resources = MODEL_NAMES .map { |x| x.to_s.singularize.to_sym } ...
Fix issue where data_dump `status` where erroneously `inactive`
diff --git a/lib/mamiya.rb b/lib/mamiya.rb index abc1234..def5678 100644 --- a/lib/mamiya.rb +++ b/lib/mamiya.rb @@ -3,9 +3,9 @@ module Mamiya - @chdir_mutex = Thread::Mutex.new + @chdir_monitor = Monitor.new def self.chdir(dir, &block) - @chdir_mutex.synchronize do + @chdir_monitor.synchronize do ...
Use Monitor for recursive locking
diff --git a/benchmark/core/string/bench_equal.rb b/benchmark/core/string/bench_equal.rb index abc1234..def5678 100644 --- a/benchmark/core/string/bench_equal.rb +++ b/benchmark/core/string/bench_equal.rb @@ -2,7 +2,7 @@ require 'benchmark/ips' Benchmark.ips do |x| - string_a = "#{'a' * 1_000}" + string_a = "#{'a'...
Make sure the string has the same length The benchmarks tries to expose different comparison times based on starting / ending with a different character so it shouldn't trigger the shortcut we have that checks length first.
diff --git a/app/controllers/mains_controller.rb b/app/controllers/mains_controller.rb index abc1234..def5678 100644 --- a/app/controllers/mains_controller.rb +++ b/app/controllers/mains_controller.rb @@ -10,9 +10,9 @@ @contact = Contact.new @contact.request = request if @contact.deliver - flash.now[:error] =...
Refactor email code for production heroku
diff --git a/app/controllers/mains_controller.rb b/app/controllers/mains_controller.rb index abc1234..def5678 100644 --- a/app/controllers/mains_controller.rb +++ b/app/controllers/mains_controller.rb @@ -9,7 +9,7 @@ end def create - from = Email.new(email: params[:contact]["email"]) + from = Email.new(email: pa...
Add name to email header
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -5,7 +5,7 @@ def index @pages = Page.by_recent - render layout: 'admin' + switch_to_admin_layout ...
Put back the switch_to_admin_layout. It was previously misnamed.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -9,7 +9,8 @@ end def show - + @user = User.find_by(session[:user_id]) + # @user.question.id end ...
Fix user controller show route
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,7 +1,19 @@ class UsersController < ApplicationController def gather - puts params.inspect + company = param...
Make controller action to parse user agent
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -29,8 +29,6 @@ end def watching - # Can't do User.find(params[:id]). Figure out why - @user = Owner.fri...
Make things a little more concise
diff --git a/test/services/gobierto_budget_consultations/csv_exporter_test.rb b/test/services/gobierto_budget_consultations/csv_exporter_test.rb index abc1234..def5678 100644 --- a/test/services/gobierto_budget_consultations/csv_exporter_test.rb +++ b/test/services/gobierto_budget_consultations/csv_exporter_test.rb @@ ...
Revert "It's someone's birthday :cake:" This reverts commit 5f073d55f6f11465c0be5c5f16c18127b10f265a.
diff --git a/lib/custodian/api.rb b/lib/custodian/api.rb index abc1234..def5678 100644 --- a/lib/custodian/api.rb +++ b/lib/custodian/api.rb @@ -21,9 +21,11 @@ "Content-Type" => "application/json" } - body = Custodian::Samplers.compatible.collect do |sampler| + hash = Custodian::Samplers.comp...
Use Ruby 1.9.3's built-in JSON module
diff --git a/db/migrate/20211005130501_rename_option_set_name_where_duplicates.rb b/db/migrate/20211005130501_rename_option_set_name_where_duplicates.rb index abc1234..def5678 100644 --- a/db/migrate/20211005130501_rename_option_set_name_where_duplicates.rb +++ b/db/migrate/20211005130501_rename_option_set_name_where_d...
11992: Add down migration to allow redo
diff --git a/potatochop.gemspec b/potatochop.gemspec index abc1234..def5678 100644 --- a/potatochop.gemspec +++ b/potatochop.gemspec @@ -8,13 +8,17 @@ gem.version = Potatochop::VERSION gem.authors = ["John Mertens"] gem.email = ["john@versahq.com"] - gem.description = %q{TODO: Write a gem...
Add a simple summary & description
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,10 +1,11 @@ # Be sure to restart your server when you modify this file. - -# The cookie_store can be too smal...
Migrate session cookies to new setup Currently sessions set on (www.openfoodnetwork.xxx) are not usable on the bare domain (openfoonetwork.xxx). When transitioning from one to the other, the user's session is completely lost. This change means sessions on subdomains (including www) will be transferable.