diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/danger_plugins/protect_files.rb b/danger_plugins/protect_files.rb index abc1234..def5678 100644 --- a/danger_plugins/protect_files.rb +++ b/danger_plugins/protect_files.rb @@ -6,7 +6,7 @@ broken_rule = false Dir.glob(path) do |current| - broken_rule = true if self.env.scm.dsl.modified...
Use new DSL in the plugin
diff --git a/gds_zendesk.gemspec b/gds_zendesk.gemspec index abc1234..def5678 100644 --- a/gds_zendesk.gemspec +++ b/gds_zendesk.gemspec @@ -19,7 +19,7 @@ gem.add_dependency "null_logger", "~> 0" gem.add_dependency "zendesk_api", "~> 1.27" - gem.add_development_dependency "rake", "~> 13" + gem.add_development_...
Remove gem constraint on rake Rake is a very stable gem and it doesn't seem necessary to keep a constraint on it as it requires frequently updating it.
diff --git a/db/data_migration/20130530131759_fix_detailed_guides_that_talk_about_specialist_guides.rb b/db/data_migration/20130530131759_fix_detailed_guides_that_talk_about_specialist_guides.rb index abc1234..def5678 100644 --- a/db/data_migration/20130530131759_fix_detailed_guides_that_talk_about_specialist_guides.rb...
Fix /specialist-guides/ links in detailed guide body text Some detailed guides have cross links to the old admin url for detailed guides /admin/specialist-guides/ and so these don't get govspokenified on frontend to refer to the public url for the latest edition of that guide. To fix we look for all published or draf...
diff --git a/glimpse-git.gemspec b/glimpse-git.gemspec index abc1234..def5678 100644 --- a/glimpse-git.gemspec +++ b/glimpse-git.gemspec @@ -16,4 +16,6 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ...
Add dependency on glimpse now that it's on RubyGems
diff --git a/spec/mutations/releases/create_spec.rb b/spec/mutations/releases/create_spec.rb index abc1234..def5678 100644 --- a/spec/mutations/releases/create_spec.rb +++ b/spec/mutations/releases/create_spec.rb @@ -1,17 +1,35 @@ require "spec_helper" describe Releases::Create do - it "creates a release object" do...
Test updates for non-GCS releases
diff --git a/Casks/opera-beta.rb b/Casks/opera-beta.rb index abc1234..def5678 100644 --- a/Casks/opera-beta.rb +++ b/Casks/opera-beta.rb @@ -1,6 +1,6 @@ cask :v1 => 'opera-beta' do - version '29.0.1795.21' - sha256 'ffcf288fbbe993c772658ea20f5230525246e046f69a162e5eeabb6de4ecd73c' + version '29.0.1795.26' + sha256 ...
Upgrade Opera Beta.app to v29.0.1795.26
diff --git a/space_invaders.gemspec b/space_invaders.gemspec index abc1234..def5678 100644 --- a/space_invaders.gemspec +++ b/space_invaders.gemspec @@ -19,5 +19,6 @@ spec.add_development_dependency "bundler", "~> 1.5" spec.add_development_dependency "rake" + spec.add_development_dependency "pry" spec.add_de...
Add pry as a development dependency, fails otherwise
diff --git a/app/models/identity.rb b/app/models/identity.rb index abc1234..def5678 100644 --- a/app/models/identity.rb +++ b/app/models/identity.rb @@ -5,7 +5,7 @@ validates_uniqueness_of :uid, scope: :provider def self.find_or_create(auth) - where(auth.slice(:uid, :provider)).first_or_create + find_or_cr...
Replace use of deprecated Active Record method
diff --git a/examples/ping_pong.rb b/examples/ping_pong.rb index abc1234..def5678 100644 --- a/examples/ping_pong.rb +++ b/examples/ping_pong.rb @@ -0,0 +1,40 @@+#!/bin/env ruby + +require 'bundler/setup' +require 'ffi/libevent' +require 'socket' + +base = FFI::Libevent::Base.new +trapper = FFI::Libevent::Event.new(bas...
Add basic ping pong example
diff --git a/http-server.gemspec b/http-server.gemspec index abc1234..def5678 100644 --- a/http-server.gemspec +++ b/http-server.gemspec @@ -15,6 +15,7 @@ s.required_ruby_version = '>= 2.2.3' s.add_runtime_dependency 'connection' + s.add_runtime_dependency 'connection-server' s.add_runtime_dependency 'http-c...
Add connection-server as a runtime dependency
diff --git a/app/controllers/entries_controller.rb b/app/controllers/entries_controller.rb index abc1234..def5678 100644 --- a/app/controllers/entries_controller.rb +++ b/app/controllers/entries_controller.rb @@ -20,7 +20,7 @@ else flash[:danger] = 'メールの送信に失敗しました' end - redirect_to @song.live + re...
Change the redirect destination after entry creation
diff --git a/app/controllers/entries_controller.rb b/app/controllers/entries_controller.rb index abc1234..def5678 100644 --- a/app/controllers/entries_controller.rb +++ b/app/controllers/entries_controller.rb @@ -21,17 +21,12 @@ # route handlers dealing with a specific entry -before /entries\/\d+/ do - @entry = En...
Fix bug in before filter again
diff --git a/app/controllers/manuals_controller.rb b/app/controllers/manuals_controller.rb index abc1234..def5678 100644 --- a/app/controllers/manuals_controller.rb +++ b/app/controllers/manuals_controller.rb @@ -5,15 +5,13 @@ before_action :render_employment_income_manual before_action :ensure_manual_is_found +...
Move document check to before_action filter Handle a 404 for a non-existent document in a before filter to keep exceptional behaviour out of the normal logic. Also extract a `document` method to fetch the document object.
diff --git a/app/models/spree/variant_decorator.rb b/app/models/spree/variant_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/variant_decorator.rb +++ b/app/models/spree/variant_decorator.rb @@ -1,8 +1,20 @@ Spree::Variant.class_eval do + has_many :digitals, :dependent => :destroy + after_save :...
Revert "Remove delete digitals on soft delete of variant" This reverts commit d23462fadb5ef049b9ed4f667bd405e343c654b1.
diff --git a/activesupport/lib/active_support/security_utils.rb b/activesupport/lib/active_support/security_utils.rb index abc1234..def5678 100644 --- a/activesupport/lib/active_support/security_utils.rb +++ b/activesupport/lib/active_support/security_utils.rb @@ -19,12 +19,14 @@ end module_function :fixed_len...
Remove hashing from secure_compare and clarify documentation
diff --git a/app/services/create_manual_service.rb b/app/services/create_manual_service.rb index abc1234..def5678 100644 --- a/app/services/create_manual_service.rb +++ b/app/services/create_manual_service.rb @@ -1,9 +1,9 @@ class CreateManualService - def initialize(dependencies) - @manual_repository = dependencie...
Use Ruby keyword args in CreateManualService I think that using language features instead of custom code makes this easier to understand.
diff --git a/lib/asendia/client.rb b/lib/asendia/client.rb index abc1234..def5678 100644 --- a/lib/asendia/client.rb +++ b/lib/asendia/client.rb @@ -5,7 +5,7 @@ module Asendia # Handles communication with Asendia API class Client - WSDL_URL = 'https://demo0884331.mockable.io/?wsdl'.freeze + WSDL_URL = 'http...
Update WSDL URL and start setting ReturnType
diff --git a/lib/authem/session.rb b/lib/authem/session.rb index abc1234..def5678 100644 --- a/lib/authem/session.rb +++ b/lib/authem/session.rb @@ -5,14 +5,25 @@ self.table_name = :authem_sessions belongs_to :subject, polymorphic: true - scope :by_subject, ->(model){ where(subject_type: model.class.name,...
Define class methods instead of scopes Maybe CodeClimate will like it more...
diff --git a/lib/content_dumper.rb b/lib/content_dumper.rb index abc1234..def5678 100644 --- a/lib/content_dumper.rb +++ b/lib/content_dumper.rb @@ -3,6 +3,7 @@ class ContentDumper FIELDS = %w(base_path content_id locale document_type schema_name rendering_app publishing_app updated_at).freeze + HASH_FIELDS = %w(...
Include hash of details and expanded_links in dump
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -1,14 +1,16 @@ class HomeController < ApplicationController + + PER_ROW = 7 def index if current_user - ...
Optimize row counts for most common browser widths.
diff --git a/lib/same_boat/crew.rb b/lib/same_boat/crew.rb index abc1234..def5678 100644 --- a/lib/same_boat/crew.rb +++ b/lib/same_boat/crew.rb @@ -11,7 +11,7 @@ private def git_commit_hash - `git show #{@file_path} | head -n 1 | cut -d ' ' -f2` + `git log #{@file_path} | head -n 1 | cut -d ' ' -f...
Change git hash command to use log instead of show
diff --git a/lib/tasks/events.rake b/lib/tasks/events.rake index abc1234..def5678 100644 --- a/lib/tasks/events.rake +++ b/lib/tasks/events.rake @@ -6,46 +6,48 @@ datetime = DateTime.parse(timestamp) events = Event.where("created_at >= ?", datetime).order(:created_at) - json_events = events.map { |e| e.as...
Make event export/import streaming to conserve memory
diff --git a/lib/tasks/export.rake b/lib/tasks/export.rake index abc1234..def5678 100644 --- a/lib/tasks/export.rake +++ b/lib/tasks/export.rake @@ -0,0 +1,48 @@+class Record + attr_accessor :created_at, :meeting_date, :club_name, :leaders, :attendance, + :notes + + def initialize(created_at, meeting_date, club_na...
Add rake task to create CSV from check in data Fix #52
diff --git a/irc-hipchat.rb b/irc-hipchat.rb index abc1234..def5678 100644 --- a/irc-hipchat.rb +++ b/irc-hipchat.rb @@ -5,6 +5,7 @@ IRC_HOST = 'irc.freenode.net' IRC_PORT = '6667' IRC_CHANNEL = '#emacs' +HIPCHAT_ROOM = 'IRC' hipchat_client = HipChat::Client.new(ENV['HIPCHAT_AUTH_TOKEN'], :api_version => 'v2') @...
Make hipchat room name a constant
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -1,10 +1,10 @@ class SessionsController < ApplicationController - + def create user = User.fin...
Remove flash notice after successful signin
diff --git a/app/helpers/landable/traffic_helper.rb b/app/helpers/landable/traffic_helper.rb index abc1234..def5678 100644 --- a/app/helpers/landable/traffic_helper.rb +++ b/app/helpers/landable/traffic_helper.rb @@ -0,0 +1,31 @@+module Landable + module TrafficHelper + def crawl_tracker + @tracker if @tracker...
Create tracker object helper methods
diff --git a/app/models/spree/copayment_relation.rb b/app/models/spree/copayment_relation.rb index abc1234..def5678 100644 --- a/app/models/spree/copayment_relation.rb +++ b/app/models/spree/copayment_relation.rb @@ -6,5 +6,7 @@ validates :relatable, :related_to, presence: true validates :relatable_id, uniqu...
Add scope for get active copayments
diff --git a/app/models/spree/shipment_decorator.rb b/app/models/spree/shipment_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/shipment_decorator.rb +++ b/app/models/spree/shipment_decorator.rb @@ -1,5 +1,5 @@ Spree::Shipment.class_eval do - scope :exportable, joins(:order).where('spree_shipments.st...
Remove scope deprecation warning sytax
diff --git a/config/initializers/swagger_blocks.rb b/config/initializers/swagger_blocks.rb index abc1234..def5678 100644 --- a/config/initializers/swagger_blocks.rb +++ b/config/initializers/swagger_blocks.rb @@ -3,7 +3,7 @@ module ApiFlashcards include Swagger::Blocks host = if ENV['RAILS_ENV'] == "production" -...
Remove protocol prefix from hostname
diff --git a/app/controllers/domain_controller.rb b/app/controllers/domain_controller.rb index abc1234..def5678 100644 --- a/app/controllers/domain_controller.rb +++ b/app/controllers/domain_controller.rb @@ -12,7 +12,10 @@ search_classes.each do |model| if model.respond_to?(:search) arel = model.se...
Use domain_id in search query
diff --git a/lib/appsignal/integrations/sinatra.rb b/lib/appsignal/integrations/sinatra.rb index abc1234..def5678 100644 --- a/lib/appsignal/integrations/sinatra.rb +++ b/lib/appsignal/integrations/sinatra.rb @@ -5,7 +5,7 @@ app_settings = ::Sinatra::Application.settings Appsignal.config = Appsignal::Config.new( - ...
Fix AppSignal loading when using Sinatra::Base Looks like that when using `require "sinatra/base"` instead of `require "sinatra"` the root path is not set on the sinatra application. The user should do this themselves, but it's not required. https://github.com/sinatra/sinatra/blob/d51513d094d1fe01543e546d07ef48663ecc...
diff --git a/lib/chamber.rb b/lib/chamber.rb index abc1234..def5678 100644 --- a/lib/chamber.rb +++ b/lib/chamber.rb @@ -38,7 +38,10 @@ end def load_file(file_path) - settings.merge! YAML.load(File.read(file_path.to_s)) + file_contents = File.read(file_path.to_s) + yaml_contents = YAML.load(file_content...
Decompress a few lines for better readability
diff --git a/lib/messaging/message_handlers/base_message_handler.rb b/lib/messaging/message_handlers/base_message_handler.rb index abc1234..def5678 100644 --- a/lib/messaging/message_handlers/base_message_handler.rb +++ b/lib/messaging/message_handlers/base_message_handler.rb @@ -17,7 +17,7 @@ end def se...
Fix invalid encoding on generated reply_to destination during responding to requests
diff --git a/lib/clowder/client.rb b/lib/clowder/client.rb index abc1234..def5678 100644 --- a/lib/clowder/client.rb +++ b/lib/clowder/client.rb @@ -4,6 +4,7 @@ module Clowder CLOWDER_ROOT_URL = 'http://www.clowder.io' CLOWDER_API_URL = CLOWDER_ROOT_URL + '/api' + CLOWDER_DELETE_URL = CLOWDER_ROOT_URL + '/delete...
Add Ability To Delete By Service Name
diff --git a/lib/git-helper/menus/settings_menu.rb b/lib/git-helper/menus/settings_menu.rb index abc1234..def5678 100644 --- a/lib/git-helper/menus/settings_menu.rb +++ b/lib/git-helper/menus/settings_menu.rb @@ -11,8 +11,6 @@ cli.choose do |menu| menu.header = "Settings" menu.prompt = "? " - ...
Remove old settings path code from
diff --git a/capistrano-detect-migrations.gemspec b/capistrano-detect-migrations.gemspec index abc1234..def5678 100644 --- a/capistrano-detect-migrations.gemspec +++ b/capistrano-detect-migrations.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = 'capistrano-detect-migrations' - s.version = ...
Update gemspec for new release.
diff --git a/lib/ferrety_ferret.rb b/lib/ferrety_ferret.rb index abc1234..def5678 100644 --- a/lib/ferrety_ferret.rb +++ b/lib/ferrety_ferret.rb @@ -1,4 +1,3 @@-require "ferrety_ferret/version" require "httparty" module Ferrety @@ -7,7 +6,7 @@ def initialize(params) clear_alerts - params = parse...
Fix scoping issue on params
diff --git a/lib/kuroko2/engine.rb b/lib/kuroko2/engine.rb index abc1234..def5678 100644 --- a/lib/kuroko2/engine.rb +++ b/lib/kuroko2/engine.rb @@ -1,5 +1,10 @@ module Kuroko2 class Engine < ::Rails::Engine isolate_namespace Kuroko2 + + config.before_configuration do + require 'kaminari' + require...
Add requiring gems to before_configuration
diff --git a/lyricfy.gemspec b/lyricfy.gemspec index abc1234..def5678 100644 --- a/lyricfy.gemspec +++ b/lyricfy.gemspec @@ -17,9 +17,9 @@ gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.require_paths = ["lib"] - gem.add_runtime_dependency "rake" gem.add_runtime_dependency "nokogiri", [">=...
Add rake as development dependency in gemspec
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -2,4 +2,4 @@ Rails.application.config.session_store :redis_store, serv...
Increase session expiration to 6 months
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -Rails.application.config.session_sto...
Make session cookie domain :all for single sign out
diff --git a/lib/github/token.rb b/lib/github/token.rb index abc1234..def5678 100644 --- a/lib/github/token.rb +++ b/lib/github/token.rb @@ -4,12 +4,12 @@ module Token class << self EXPANSIONS = { - user: ["read:user", "user:email", "user:follow"], - repo: ["repo:...
Move scopes to tree structure
diff --git a/spec/support/save_feature_failures.rb b/spec/support/save_feature_failures.rb index abc1234..def5678 100644 --- a/spec/support/save_feature_failures.rb +++ b/spec/support/save_feature_failures.rb @@ -4,13 +4,16 @@ config.after(:each, type: :feature) do example_filename = RSpec.current_example.full_d...
Store screenshot when feature test fails This is useful when debugging a failing test. Co-authored-by: Stephan Kulow <f965a4a1b587c4e3c1892642aed563e43902502b@kulow.org>
diff --git a/lib/mutant/color.rb b/lib/mutant/color.rb index abc1234..def5678 100644 --- a/lib/mutant/color.rb +++ b/lib/mutant/color.rb @@ -3,7 +3,7 @@ module Mutant # Class to colorize strings class Color - include Adamantium::Flat, Concord.new(:color) + include Adamantium::Flat, Concord.new(:code) ...
Fix ivar naming in Mutant::Color
diff --git a/lib/nagip/loader.rb b/lib/nagip/loader.rb index abc1234..def5678 100644 --- a/lib/nagip/loader.rb +++ b/lib/nagip/loader.rb @@ -10,7 +10,34 @@ def run instance_eval File.read(File.join(File.dirname(__FILE__), 'defaults.rb')) instance_eval File.read 'Nagipfile' + load_remote_o...
Load host and service object from remote status.dat on boot
diff --git a/lib/qmetrics/api.rb b/lib/qmetrics/api.rb index abc1234..def5678 100644 --- a/lib/qmetrics/api.rb +++ b/lib/qmetrics/api.rb @@ -14,7 +14,7 @@ options.merge(@auth))) end - def stats(args) + def stats(**args) if args.empty? @stats else @@ -2...
Set default value for args in caller instantiation on API.
diff --git a/netfox.podspec b/netfox.podspec index abc1234..def5678 100644 --- a/netfox.podspec +++ b/netfox.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "netfox" - s.version = "1.18.0" + s.version = "1.19.0" s.summary = "A lightweight, one line setup, iOS/OSX net...
Update pod version to 1.19.0
diff --git a/lib/troy/helpers.rb b/lib/troy/helpers.rb index abc1234..def5678 100644 --- a/lib/troy/helpers.rb +++ b/lib/troy/helpers.rb @@ -9,7 +9,15 @@ end def partial(name, locals = {}) - path = site.root.join("partials/_#{name}.erb") + basename = File.basename(name) + dirname = File.dirnam...
Support directories inside partials directory.
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -35,5 +35,5 @@ end end - after 'deploy:updated', 'config_files:upload' + before 'deploy:updated', 'config_files:upload' end
Copy secrets to server before db:migrate
diff --git a/app/models/post/vote_methods.rb b/app/models/post/vote_methods.rb index abc1234..def5678 100644 --- a/app/models/post/vote_methods.rb +++ b/app/models/post/vote_methods.rb @@ -37,8 +37,12 @@ if user.is_anonymous? return false end - vote = post_votes.find_or_initialize_by_user_id user.id ...
Delete vote when it's set to less than or equal to 0. And why is it even configurable.
diff --git a/app/reports/basic_report_row.rb b/app/reports/basic_report_row.rb index abc1234..def5678 100644 --- a/app/reports/basic_report_row.rb +++ b/app/reports/basic_report_row.rb @@ -11,7 +11,7 @@ def add(asset) self.count += 1 - self.replacement_cost += asset.replacement_cost + self.replacement_...
Fix NPR for assets that are not initialized
diff --git a/test/collector_test.rb b/test/collector_test.rb index abc1234..def5678 100644 --- a/test/collector_test.rb +++ b/test/collector_test.rb @@ -0,0 +1,45 @@+require 'test_helper' + +module Schemacop + class CollectorTest < Minitest::Test + def test_no_root_node + s = Schema.new do + req :a, :st...
Add tests for Collector paths
diff --git a/lib/foreigner/connection_adapters/sql_2003.rb b/lib/foreigner/connection_adapters/sql_2003.rb index abc1234..def5678 100644 --- a/lib/foreigner/connection_adapters/sql_2003.rb +++ b/lib/foreigner/connection_adapters/sql_2003.rb @@ -8,23 +8,18 @@ def add_foreign_key(from_table, to_table, options = {})...
Add support for active_record.table_name_prefix and active_record.table_name_suffix. Thanks accy.
diff --git a/app/validators/url_validator.rb b/app/validators/url_validator.rb index abc1234..def5678 100644 --- a/app/validators/url_validator.rb +++ b/app/validators/url_validator.rb @@ -1,5 +1,3 @@-# frozen_string_literal: true - class UrlValidator < ActiveModel::EachValidator # The URL validation rules are some...
Remove redundant freeze (required by CircleCI) Signed-off-by: David A. Wheeler <9ae72d22d8b894b865a7a496af4fab6320e6abb2@dwheeler.com>
diff --git a/XcodeEditor.podspec b/XcodeEditor.podspec index abc1234..def5678 100644 --- a/XcodeEditor.podspec +++ b/XcodeEditor.podspec @@ -9,4 +9,6 @@ s.platform = :osx s.source_files = 'Source/*.{h,m}', 'Source/Utils/*.{h,m}' s.requires_arc = true + spec.ios.deployment_target = '5.0' + spec.osx.deployment_...
Add deployment targets to podspec.
diff --git a/spec/dynamodb_mutex_spec.rb b/spec/dynamodb_mutex_spec.rb index abc1234..def5678 100644 --- a/spec/dynamodb_mutex_spec.rb +++ b/spec/dynamodb_mutex_spec.rb @@ -7,7 +7,7 @@ describe '#with_lock' do - def run(id, seconds) + def run_for(seconds) locker.with_lock(lockname) do sleep(...
Fix running specs multiple times.
diff --git a/lib/active_presenter/version.rb b/lib/active_presenter/version.rb index abc1234..def5678 100644 --- a/lib/active_presenter/version.rb +++ b/lib/active_presenter/version.rb @@ -1,8 +1,8 @@ module ActivePresenter module VERSION - MAJOR = 0 + MAJOR = 1 MINOR = 0 - TINY = 5 + T...
Make it v1.0.0, since it's production ready
diff --git a/lib/activerecord_requirement.rb b/lib/activerecord_requirement.rb index abc1234..def5678 100644 --- a/lib/activerecord_requirement.rb +++ b/lib/activerecord_requirement.rb @@ -3,7 +3,7 @@ class ActiveRecordRequirement attr_reader :requirements, :klass - IGNORE_COLUMNS = %w( created_at updated_a...
Include all columns by default, not just content_columns. This is because we definitely want to include foreign keys in the parameters to watch as well. git-svn-id: 36d0598828eae866924735253b485a592756576c@7743 da5c320b-a5ec-0310-b7f9-e4d854caa1e2
diff --git a/lib/command_objects/sync_bot.rb b/lib/command_objects/sync_bot.rb index abc1234..def5678 100644 --- a/lib/command_objects/sync_bot.rb +++ b/lib/command_objects/sync_bot.rb @@ -10,10 +10,15 @@ [Schedule, Sequence, Step].map(&:destroy_all) {sequences: api.sequences.fetch.map { |s| CreateSequen...
Print sync completion to logs
diff --git a/lib/helpers/string_formatter.rb b/lib/helpers/string_formatter.rb index abc1234..def5678 100644 --- a/lib/helpers/string_formatter.rb +++ b/lib/helpers/string_formatter.rb @@ -22,6 +22,14 @@ new_string << "..." if truncated new_string end + + def pluralize(count, plural) + if (count == 1) +...
Add pluralize method to StringFormatter module
diff --git a/config/environments/development.rb b/config/environments/development.rb index abc1234..def5678 100644 --- a/config/environments/development.rb +++ b/config/environments/development.rb @@ -38,4 +38,6 @@ # Raises error for missing translations # config.action_view.raise_on_missing_translations = true ...
Support web console on vagrant
diff --git a/config/initializers/delayed_job.rb b/config/initializers/delayed_job.rb index abc1234..def5678 100644 --- a/config/initializers/delayed_job.rb +++ b/config/initializers/delayed_job.rb @@ -1 +1,2 @@ Delayed::Worker.destroy_failed_jobs = false +Delayed::Worker.logger = Logger.new(File.join(Rails.root, 'log',...
Add log file for delayed job
diff --git a/lib/vagrant-proxyconf/action.rb b/lib/vagrant-proxyconf/action.rb index abc1234..def5678 100644 --- a/lib/vagrant-proxyconf/action.rb +++ b/lib/vagrant-proxyconf/action.rb @@ -1,17 +1,29 @@ require_relative 'action/configure_apt_proxy' require_relative 'action/configure_chef_proxy' require_relative 'acti...
Use OnlyOnce to build the middleware stack
diff --git a/propono.gemspec b/propono.gemspec index abc1234..def5678 100644 --- a/propono.gemspec +++ b/propono.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_dependency "fog", "~> 1.15.0" + spec.add_dependency "fog", "~> 1.15...
Allow dot releases to fog
diff --git a/app/controllers/accounts_controller.rb b/app/controllers/accounts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/accounts_controller.rb +++ b/app/controllers/accounts_controller.rb @@ -2,17 +2,25 @@ def new @account = Account.new @new_account_user = User.new + @person = Pe...
Add logic to create a new person along with the account and user (and sync emails between user and person).
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -10,14 +10,12 @@ if user && user.authenticate(params[:password]) session[:user_id] = us...
Put the notice back and removed TODO
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -8,21 +8,26 @@ else user = User.find_by(handle: params[:session][:login]) end - if us...
Fix sessions controller bug for nonexistent users.
diff --git a/app/controllers/snippets_controller.rb b/app/controllers/snippets_controller.rb index abc1234..def5678 100644 --- a/app/controllers/snippets_controller.rb +++ b/app/controllers/snippets_controller.rb @@ -21,6 +21,7 @@ def show set_snippet + @stories = @snippet.stories end private
Add stories instance variable to show controller
diff --git a/user_with_email/app/forms/user_form.rb b/user_with_email/app/forms/user_form.rb index abc1234..def5678 100644 --- a/user_with_email/app/forms/user_form.rb +++ b/user_with_email/app/forms/user_form.rb @@ -1,5 +1,3 @@-require "form_object" - class UserForm < FormObject::Base attributes :name, :age, :gend...
Remove redundant user of require in UserForm. The FormObject is autoloaded.
diff --git a/spec/integrations/fetch_image_spec.rb b/spec/integrations/fetch_image_spec.rb index abc1234..def5678 100644 --- a/spec/integrations/fetch_image_spec.rb +++ b/spec/integrations/fetch_image_spec.rb @@ -0,0 +1,35 @@+require 'spec_helper' + +describe "Getting an image" do + describe "Search by target" do + ...
Add integration test for image fetching
diff --git a/spec/unit/need_state_listener_spec.rb b/spec/unit/need_state_listener_spec.rb index abc1234..def5678 100644 --- a/spec/unit/need_state_listener_spec.rb +++ b/spec/unit/need_state_listener_spec.rb @@ -9,12 +9,16 @@ it 'marks a need as done and records the public url when a message received' do need...
Add extra logging to try and work out why test fails on jenkins but not locally
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -8,7 +8,7 @@ if user && user.authenticate(params[:password]) respond_to do |format| - ...
Add return json object to login on request .json
diff --git a/app/importers/iep_import/iep_storer.rb b/app/importers/iep_import/iep_storer.rb index abc1234..def5678 100644 --- a/app/importers/iep_import/iep_storer.rb +++ b/app/importers/iep_import/iep_storer.rb @@ -14,9 +14,9 @@ end def store - student = Student.find_by_local_id(@local_id) + @student = S...
Fix instance var/ local var mistake
diff --git a/app/models/hbx_enrollment_exemption.rb b/app/models/hbx_enrollment_exemption.rb index abc1234..def5678 100644 --- a/app/models/hbx_enrollment_exemption.rb +++ b/app/models/hbx_enrollment_exemption.rb @@ -1,19 +1,16 @@-class EnrollmentExemption +class HbxEnrollmentExemption include Mongoid::Document i...
Rename class name and fields to comply with system conventions
diff --git a/app/models/spree/shipment_decorator.rb b/app/models/spree/shipment_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/shipment_decorator.rb +++ b/app/models/spree/shipment_decorator.rb @@ -19,17 +19,10 @@ inventory_units.group_by(&:variant).map do |variant, units| states = {} ...
Move variant scoping from alias method into manifest method
diff --git a/partoo.gemspec b/partoo.gemspec index abc1234..def5678 100644 --- a/partoo.gemspec +++ b/partoo.gemspec @@ -10,7 +10,7 @@ s.email = ["werekraken@gmail.com"] s.summary = "Do cool things with par2 files." - s.description = "Partoo parses data from par2 files allowing programatic acces...
Fix typo in gemspec description.
diff --git a/app/views/workflows/show.json.jbuilder b/app/views/workflows/show.json.jbuilder index abc1234..def5678 100644 --- a/app/views/workflows/show.json.jbuilder +++ b/app/views/workflows/show.json.jbuilder @@ -1,7 +1,9 @@ json.extract! @workflow, :name, :batch_host, :script_path, :staged_script_name, :staged_dir...
Add a check in case cluster id is not valid
diff --git a/db/migrate/20190524142939_add_taggings_counter_cache_to_tags.acts_as_taggable_on_engine.rb b/db/migrate/20190524142939_add_taggings_counter_cache_to_tags.acts_as_taggable_on_engine.rb index abc1234..def5678 100644 --- a/db/migrate/20190524142939_add_taggings_counter_cache_to_tags.acts_as_taggable_on_engine...
Fix missing tagging_counts attribute bringing migration from gem
diff --git a/rainbow.gemspec b/rainbow.gemspec index abc1234..def5678 100644 --- a/rainbow.gemspec +++ b/rainbow.gemspec @@ -7,7 +7,7 @@ Gem::Specification.new do |spec| spec.name = "rainbow" spec.version = Rainbow::VERSION - spec.authors = ["Marcin Kulik"] + spec.au...
Add Olle Jonsson as author to gemspec
diff --git a/app/models/houston/itsm/issue.rb b/app/models/houston/itsm/issue.rb index abc1234..def5678 100644 --- a/app/models/houston/itsm/issue.rb +++ b/app/models/houston/itsm/issue.rb @@ -2,7 +2,7 @@ module Houston module Itsm - class Issue < Struct.new(:summary, :url, :assigned_to_email, :assigned_to_user...
[refactor] Add `key` to Issue (2m)
diff --git a/db/migrate/20161201160452_migrate_project_statistics.rb b/db/migrate/20161201160452_migrate_project_statistics.rb index abc1234..def5678 100644 --- a/db/migrate/20161201160452_migrate_project_statistics.rb +++ b/db/migrate/20161201160452_migrate_project_statistics.rb @@ -16,6 +16,7 @@ remove_column :pr...
Disable rubocop for down method
diff --git a/lib/generators/rspec/controller/controller_generator.rb b/lib/generators/rspec/controller/controller_generator.rb index abc1234..def5678 100644 --- a/lib/generators/rspec/controller/controller_generator.rb +++ b/lib/generators/rspec/controller/controller_generator.rb @@ -8,8 +8,6 @@ class_option :tem...
Revert "Tell rails' generator to generate rspec request specs when generating a" This reverts commit 12f0afaa0410504170fad7e5f99c75cffa0cd40d. - Rails controller generator does not generate the routes needed for the generated request spec. Backing this out.
diff --git a/Casks/android-studio.rb b/Casks/android-studio.rb index abc1234..def5678 100644 --- a/Casks/android-studio.rb +++ b/Casks/android-studio.rb @@ -1,9 +1,9 @@ cask :v1 => 'android-studio' do - version '1.4.0.10' - sha256 '1168faf59ffbe485bfe0e95e80bd9672a3ae5599efd2b720cf4b825bd859ffa0' + version '1.4.1.0'...
Update Android Studio to version 1.4.1.0 Hi all, I use static url to replaced original url with `#{version}` variable in this change, because no only version number, but also build number are in the download url. Maybe we can add a variable for build number to generate download url dynamically next time?
diff --git a/Casks/font-ahuramzda.rb b/Casks/font-ahuramzda.rb index abc1234..def5678 100644 --- a/Casks/font-ahuramzda.rb +++ b/Casks/font-ahuramzda.rb @@ -2,6 +2,6 @@ url 'http://openfontlibrary.org/assets/downloads/ahuramazda/b2c0eeb9186f389749746f075b5a1abf/ahuramazda.zip' homepage 'http://openfontlibrary.org/...
Update Ahuramzda to sha256 checksums
diff --git a/lib/ljax_rails/action_view_monkey.rb b/lib/ljax_rails/action_view_monkey.rb index abc1234..def5678 100644 --- a/lib/ljax_rails/action_view_monkey.rb +++ b/lib/ljax_rails/action_view_monkey.rb @@ -10,7 +10,7 @@ context.flash[id] = partial loading = block.call if block - %Q!<div id=...
Append url attribute only when explicitly given
diff --git a/lib/redmine_git_hosting/utils/ssh.rb b/lib/redmine_git_hosting/utils/ssh.rb index abc1234..def5678 100644 --- a/lib/redmine_git_hosting/utils/ssh.rb +++ b/lib/redmine_git_hosting/utils/ssh.rb @@ -9,7 +9,7 @@ file.close begin - output = capture('ssh-keygen', ['-l', '-f', file.pat...
Fix wrong number of arguments (2 for 1)
diff --git a/session.gemspec b/session.gemspec index abc1234..def5678 100644 --- a/session.gemspec +++ b/session.gemspec @@ -20,7 +20,7 @@ s.add_dependency('backports') s.add_dependency('immutable', '~> 0.0.1') - s.add_development_dependency('mapper', '~> 0.0.2') + #s.add_development_dependency('mapper'...
Disable gemspec dep on mapper
diff --git a/spec/dummy/config/initializers/02_omniauth.rb b/spec/dummy/config/initializers/02_omniauth.rb index abc1234..def5678 100644 --- a/spec/dummy/config/initializers/02_omniauth.rb +++ b/spec/dummy/config/initializers/02_omniauth.rb @@ -6,8 +6,9 @@ # OpenID # add 'omniauth-openid' to Gemfile and uncomment ...
Enable openid in the dummy app, for use in specs
diff --git a/app/controllers/pet/steps_controller.rb b/app/controllers/pet/steps_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pet/steps_controller.rb +++ b/app/controllers/pet/steps_controller.rb @@ -3,8 +3,30 @@ steps *Pet.form_steps def show + @pet = Pet.find(params[:pet_id]) + rende...
Implement shown and update actions for steps controller
diff --git a/spec/flipper/instrumentation/metriks_subscriber_spec.rb b/spec/flipper/instrumentation/metriks_subscriber_spec.rb index abc1234..def5678 100644 --- a/spec/flipper/instrumentation/metriks_subscriber_spec.rb +++ b/spec/flipper/instrumentation/metriks_subscriber_spec.rb @@ -17,9 +17,9 @@ context "for enable...
Move metriks around to directly after calls.
diff --git a/spec/generators/clearance/views/views_generator_spec.rb b/spec/generators/clearance/views/views_generator_spec.rb index abc1234..def5678 100644 --- a/spec/generators/clearance/views/views_generator_spec.rb +++ b/spec/generators/clearance/views/views_generator_spec.rb @@ -22,7 +22,6 @@ view_files.each...
Remove broken ammeter helper method
diff --git a/config/initializers/gov_uk_delivery.rb b/config/initializers/gov_uk_delivery.rb index abc1234..def5678 100644 --- a/config/initializers/gov_uk_delivery.rb +++ b/config/initializers/gov_uk_delivery.rb @@ -1,8 +1,12 @@ require 'gds_api/gov_uk_delivery' require 'plek' -unless ENV['USE_GOVUK_DELIVERY'] - W...
Change initialiser to log in development Does nothing, logs requests.
diff --git a/config/initializers/wrap_parameters.rb b/config/initializers/wrap_parameters.rb index abc1234..def5678 100644 --- a/config/initializers/wrap_parameters.rb +++ b/config/initializers/wrap_parameters.rb @@ -5,10 +5,10 @@ # Enable parameter wrapping for JSON. You can disable this by setting :format to an emp...
Disable root element in JSON
diff --git a/test/models/address_test.rb b/test/models/address_test.rb index abc1234..def5678 100644 --- a/test/models/address_test.rb +++ b/test/models/address_test.rb @@ -1,7 +1,10 @@ require 'test_helper' class AddressTest < ActiveSupport::TestCase - # test "the truth" do - # assert true - # end + test "Sho...
Add test for Address country_name method
diff --git a/roles/rails.rb b/roles/rails.rb index abc1234..def5678 100644 --- a/roles/rails.rb +++ b/roles/rails.rb @@ -1,3 +1,3 @@ name 'rails' description 'This role configures a Rails stack using Unicorn' -run_list "recipe[apt]", "recipe[build-essential]", "recipe[mysql::server]", "recipe[packages]", "recipe[bundl...
Drop rbenv::user and use new rbenv cookbook
diff --git a/example.rb b/example.rb index abc1234..def5678 100644 --- a/example.rb +++ b/example.rb @@ -1,4 +1,8 @@ require_relative "lib/mozart" + +# this generates a wrapper which will delegate +# methods to a target object, but prevents +# public calls to anything not in the whitelist Stack = Mozart.context(:pus...
Add a bit more documentation
diff --git a/lib/aquatone/collectors/wayback.rb b/lib/aquatone/collectors/wayback.rb index abc1234..def5678 100644 --- a/lib/aquatone/collectors/wayback.rb +++ b/lib/aquatone/collectors/wayback.rb @@ -0,0 +1,22 @@+require 'uri' + +module Aquatone + module Collectors + class Crtsh < Aquatone::Collector + self.m...
Add Wayback Machine as a collector
diff --git a/lib/bitballoon/collection_proxy.rb b/lib/bitballoon/collection_proxy.rb index abc1234..def5678 100644 --- a/lib/bitballoon/collection_proxy.rb +++ b/lib/bitballoon/collection_proxy.rb @@ -19,7 +19,7 @@ end def all(options = {}) - response = client.request(:get, [prefix, path].compact.join("...
Make sure custom parameters gets passed to query for collection.all
diff --git a/lib/cask/artifact/caskroom_only.rb b/lib/cask/artifact/caskroom_only.rb index abc1234..def5678 100644 --- a/lib/cask/artifact/caskroom_only.rb +++ b/lib/cask/artifact/caskroom_only.rb @@ -6,4 +6,8 @@ def install_phase # do nothing end + + def uninstall_phase + # do nothing + end end
Add uninstall_phase method to CaskroomOnly artifact
diff --git a/test/dummy/app/controllers/exception_test_controller.rb b/test/dummy/app/controllers/exception_test_controller.rb index abc1234..def5678 100644 --- a/test/dummy/app/controllers/exception_test_controller.rb +++ b/test/dummy/app/controllers/exception_test_controller.rb @@ -10,6 +10,6 @@ def test_method ...
Raise inside a library code for the test controller That way, we can see whether the evaluated binding is inside the StrongParameters code, which it shouldn't be, as we display the first application code on the error pages.