diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/grid_pattern_editor/command.rb b/lib/grid_pattern_editor/command.rb index abc1234..def5678 100644 --- a/lib/grid_pattern_editor/command.rb +++ b/lib/grid_pattern_editor/command.rb @@ -23,23 +23,23 @@ parser = OptionParser.new parser.on("-w", "--width=WIDTH", - Intege...
Fix block local variable names
diff --git a/lib/underglow/rails/environment.rb b/lib/underglow/rails/environment.rb index abc1234..def5678 100644 --- a/lib/underglow/rails/environment.rb +++ b/lib/underglow/rails/environment.rb @@ -1,3 +1,5 @@+require 'pathname' + # Require this file for quick access to Rails environment properties unless defined?...
Return root as a Pathname object
diff --git a/spec/core_ext_spec.rb b/spec/core_ext_spec.rb index abc1234..def5678 100644 --- a/spec/core_ext_spec.rb +++ b/spec/core_ext_spec.rb @@ -19,7 +19,6 @@ end it "should define Kernel.hexdump" do - expect(Kernel).to include(Hexdump::ModuleMethods) - expect(Kernel).to respond_to(:hexdump) + expec...
Simplify the Kernel core_ext spec.
diff --git a/jekyll-opal.gemspec b/jekyll-opal.gemspec index abc1234..def5678 100644 --- a/jekyll-opal.gemspec +++ b/jekyll-opal.gemspec @@ -17,7 +17,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_runtime_dependency "opal", "~> 0.8.0" + spec.add_ru...
Allow using versions of Opal beyond 0.8.x (aka 0.9.x)
diff --git a/lib/github_api/user.rb b/lib/github_api/user.rb index abc1234..def5678 100644 --- a/lib/github_api/user.rb +++ b/lib/github_api/user.rb @@ -9,12 +9,15 @@ return GitHub::Browser.get "/user/show/#{login}" end + def auth_info + {:login => self.login, :token => self.token} + end + ...
Add auth_info hash for User.
diff --git a/lib/hiredis/em/base.rb b/lib/hiredis/em/base.rb index abc1234..def5678 100644 --- a/lib/hiredis/em/base.rb +++ b/lib/hiredis/em/base.rb @@ -15,7 +15,7 @@ def receive_data(data) @reader.feed(data) - while reply = @reader.gets + until (reply = @reader.gets) == false ...
Fix issue with nil replies to eventmachine client
diff --git a/lib/kindle/org_mode.rb b/lib/kindle/org_mode.rb index abc1234..def5678 100644 --- a/lib/kindle/org_mode.rb +++ b/lib/kindle/org_mode.rb @@ -10,7 +10,7 @@ file.puts("\n** Notes \n") book.notes.each do |note| - file.puts(note.content.to_s + "\n") + file.puts(note.content....
Use two newlines after each note
diff --git a/lib/nominatim/place.rb b/lib/nominatim/place.rb index abc1234..def5678 100644 --- a/lib/nominatim/place.rb +++ b/lib/nominatim/place.rb @@ -7,27 +7,45 @@ @attrs = attrs end + # Returns display name + # + # @return [String] def display_name @display_name ||= @attrs[:display...
Add docs to the Place class.
diff --git a/lib/ohm/transaction.rb b/lib/ohm/transaction.rb index abc1234..def5678 100644 --- a/lib/ohm/transaction.rb +++ b/lib/ohm/transaction.rb @@ -2,22 +2,14 @@ module Ohm class Transaction - attr_accessor :observed_keys - attr_accessor :reading_procs - attr_accessor :writing_procs - attr_accesso...
Remove the repetition in Ohm::Transaction - use a #blocks Hash to store all Sets
diff --git a/spec/models/data_import_regression.rb b/spec/models/data_import_regression.rb index abc1234..def5678 100644 --- a/spec/models/data_import_regression.rb +++ b/spec/models/data_import_regression.rb @@ -0,0 +1,24 @@+# encoding: utf-8 +require_relative '../spec_helper' +require 'ruby-debug' + +describe DataImp...
[importer] Add DataImport model regression test
diff --git a/spec/resources/storage_schema_spec.rb b/spec/resources/storage_schema_spec.rb index abc1234..def5678 100644 --- a/spec/resources/storage_schema_spec.rb +++ b/spec/resources/storage_schema_spec.rb @@ -0,0 +1,29 @@+require "spec_helper" +load_resource("graphite", "storage_schema") + +describe Chef::Resource:...
Add spec coverage for the graphite_storage_schema resource.
diff --git a/app/overrides/add_product_relation_admin_sub_menu_tab.rb b/app/overrides/add_product_relation_admin_sub_menu_tab.rb index abc1234..def5678 100644 --- a/app/overrides/add_product_relation_admin_sub_menu_tab.rb +++ b/app/overrides/add_product_relation_admin_sub_menu_tab.rb @@ -2,5 +2,5 @@ virtual_path: 'sp...
Fix pluralization of Spree::RelationType model in menu See https://github.com/spree/spree/issues/5842
diff --git a/lib/ahoy/stores/active_record_store.rb b/lib/ahoy/stores/active_record_store.rb index abc1234..def5678 100644 --- a/lib/ahoy/stores/active_record_store.rb +++ b/lib/ahoy/stores/active_record_store.rb @@ -27,7 +27,7 @@ event_model.new do |e| e.id = options[:id] e.visit_id...
Check if event_model responds to :user=
diff --git a/lib/engineyard-cloud-client/version.rb b/lib/engineyard-cloud-client/version.rb index abc1234..def5678 100644 --- a/lib/engineyard-cloud-client/version.rb +++ b/lib/engineyard-cloud-client/version.rb @@ -1,7 +1,7 @@ # This file is maintained by a herd of rabid monkeys with Rakes. module EY class CloudC...
Add .pre for next release
diff --git a/lib/event_store/client/http/request.rb b/lib/event_store/client/http/request.rb index abc1234..def5678 100644 --- a/lib/event_store/client/http/request.rb +++ b/lib/event_store/client/http/request.rb @@ -23,11 +23,8 @@ module Configure def configure(receiver, attr_name=nil, session: nil)...
Configure methods don't write log messages
diff --git a/lib/go-cda-tools/import/go-importer.rb b/lib/go-cda-tools/import/go-importer.rb index abc1234..def5678 100644 --- a/lib/go-cda-tools/import/go-importer.rb +++ b/lib/go-cda-tools/import/go-importer.rb @@ -18,7 +18,7 @@ def parse_with_ffi(file) data = file.kind_of?(String) ? file : file.to...
Change error check to new message prefix
diff --git a/lib/json_schema/artesano/tools/null.rb b/lib/json_schema/artesano/tools/null.rb index abc1234..def5678 100644 --- a/lib/json_schema/artesano/tools/null.rb +++ b/lib/json_schema/artesano/tools/null.rb @@ -0,0 +1,31 @@+# +# This tool (strategy) doesn't provide any value. +# Assigns 'nil' to any primitive or ...
Add Tools::Null (prof of concept) A strategy that doesn't provide any real value / transformation. Assigns 'nil' to any primitive or enum property for a given schema.
diff --git a/lib/postgresql_tools/schema_creator.rb b/lib/postgresql_tools/schema_creator.rb index abc1234..def5678 100644 --- a/lib/postgresql_tools/schema_creator.rb +++ b/lib/postgresql_tools/schema_creator.rb @@ -7,7 +7,7 @@ def from_sql(file) original_path = @connection.schema_search_path - @conn...
Create schema only if it not exists
diff --git a/backend/app/controllers/spree/admin/prices_controller.rb b/backend/app/controllers/spree/admin/prices_controller.rb index abc1234..def5678 100644 --- a/backend/app/controllers/spree/admin/prices_controller.rb +++ b/backend/app/controllers/spree/admin/prices_controller.rb @@ -29,7 +29,7 @@ def support...
Add safeguard for scenarios where supported_currencies is nil
diff --git a/lib/spree_komoju/controller_helpers.rb b/lib/spree_komoju/controller_helpers.rb index abc1234..def5678 100644 --- a/lib/spree_komoju/controller_helpers.rb +++ b/lib/spree_komoju/controller_helpers.rb @@ -1,5 +1,11 @@ module SpreeKomoju module ControllerHelpers + extend ActiveSupport::Concern + + i...
Include request headers in payments
diff --git a/ginger_scenarios.rb b/ginger_scenarios.rb index abc1234..def5678 100644 --- a/ginger_scenarios.rb +++ b/ginger_scenarios.rb @@ -15,13 +15,9 @@ # Rails 3 only works on Ruby 1.8.7 and 1.9.2 if %w[1.8.7 1.9.2].include?(RUBY_VERSION) - if ENV['TEST_RAILS_3_1'] - versions << '3.1.0.rc4' - else...
Add Rails 3.1.* and 2.3.14 to test suite all pass without nulldb modification
diff --git a/git_tracker.gemspec b/git_tracker.gemspec index abc1234..def5678 100644 --- a/git_tracker.gemspec +++ b/git_tracker.gemspec @@ -14,7 +14,7 @@ EOF gem.add_development_dependency 'rspec', '~> 2.14' - gem.add_development_dependency 'activesupport', '~> 4.0' + gem.add_development_dependency 'activesup...
Revert newer ActiveSupport - requires Ruby 1.9.3+
diff --git a/lib/xcodeproj/project/xcproj_helper.rb b/lib/xcodeproj/project/xcproj_helper.rb index abc1234..def5678 100644 --- a/lib/xcodeproj/project/xcproj_helper.rb +++ b/lib/xcodeproj/project/xcproj_helper.rb @@ -41,7 +41,7 @@ # def execute(command) output = `#{command} 2>&1` - ...
Use $? instead of $CHILD_STATUS
diff --git a/lib/arf/listener.rb b/lib/arf/listener.rb index abc1234..def5678 100644 --- a/lib/arf/listener.rb +++ b/lib/arf/listener.rb @@ -19,12 +19,13 @@ def listen_for_build_completions! Travis::Pro.listen(*repos) do |stream| stream.on 'build:finished' do |event| + puts "Build finished:...
Print some logs, and actually call the correct method
diff --git a/spec/github/api_factory_spec.rb b/spec/github/api_factory_spec.rb index abc1234..def5678 100644 --- a/spec/github/api_factory_spec.rb +++ b/spec/github/api_factory_spec.rb @@ -2,7 +2,7 @@ require 'spec_helper' -describe Github::ApiFactory do +describe Github::API::Factory do subject(:factory) { de...
Fix spec for api factory.
diff --git a/spec/haml_lint/reporter_spec.rb b/spec/haml_lint/reporter_spec.rb index abc1234..def5678 100644 --- a/spec/haml_lint/reporter_spec.rb +++ b/spec/haml_lint/reporter_spec.rb @@ -0,0 +1,13 @@+require 'spec_helper' + +describe HamlLint::Reporter do + let(:reporter) { HamlLint::Reporter.new(double) } + + desc...
Add spec for Reporter base class
diff --git a/lib/bounding_box.rb b/lib/bounding_box.rb index abc1234..def5678 100644 --- a/lib/bounding_box.rb +++ b/lib/bounding_box.rb @@ -1,7 +1 @@-class BoundingBox - attr_reader :x, :y, :width, :height - - def initialize(x, y, width, height) - @x, @y, @width, @height = [x, y, width, height] - end -end +Bound...
Use a Struct for BoundingBox
diff --git a/spec/provision/dns/ddns_spec.rb b/spec/provision/dns/ddns_spec.rb index abc1234..def5678 100644 --- a/spec/provision/dns/ddns_spec.rb +++ b/spec/provision/dns/ddns_spec.rb @@ -4,7 +4,7 @@ require 'provision/core/machine_spec' class Provision::DNS::DDNS - attr_reader :network, :broadcast, :min_allocatio...
Check we calculate max_allocation correctly
diff --git a/lib/facter/vagrant_jiocloud_network.rb b/lib/facter/vagrant_jiocloud_network.rb index abc1234..def5678 100644 --- a/lib/facter/vagrant_jiocloud_network.rb +++ b/lib/facter/vagrant_jiocloud_network.rb @@ -0,0 +1,32 @@+## +# Custom fact for ipaddress and interface based on network and netmask +# This will he...
Replace jiocloud_network.rb with this file for vagrant set up
diff --git a/lib/cloudapp_api.rb b/lib/cloudapp_api.rb index abc1234..def5678 100644 --- a/lib/cloudapp_api.rb +++ b/lib/cloudapp_api.rb @@ -1,6 +1,6 @@ require "httparty" require "yaml" unless defined?(YAML) -YAML::ENGINE.yamler = "syck" if defined?(YAML::ENGINE) +YAML::ENGINE.yamler = "syck" if defined?(YAML::ENGINE...
Use syck only on Ruby < 2.0 Inspired by https://github.com/tamc/Slogger/commit/916e3e35598c09991327386256113c9340243a9a
diff --git a/gulp_assets.gemspec b/gulp_assets.gemspec index abc1234..def5678 100644 --- a/gulp_assets.gemspec +++ b/gulp_assets.gemspec @@ -25,7 +25,7 @@ EOF s.license = "MIT" - s.files = Dir["{lib,template}/**/{.,}*", "MIT-LICENSE", "README.md"] + s.files = Dir["{lib,template}/**/{.,}*", "MIT-LICENSE", "...
Fix gemspec not to include node_modules
diff --git a/lib/stack_master/parameter_resolver.rb b/lib/stack_master/parameter_resolver.rb index abc1234..def5678 100644 --- a/lib/stack_master/parameter_resolver.rb +++ b/lib/stack_master/parameter_resolver.rb @@ -37,7 +37,7 @@ begin @resolvers[class_name] = Kernel.const_get("StackMaster::Paramete...
Add an easier to understand error message... ...when the parameter resolver can not be found.
diff --git a/lib/versionator/detector/phpmyadmin.rb b/lib/versionator/detector/phpmyadmin.rb index abc1234..def5678 100644 --- a/lib/versionator/detector/phpmyadmin.rb +++ b/lib/versionator/detector/phpmyadmin.rb @@ -17,7 +17,9 @@ set :newest_version_regexp, /^Download (.+)$/ def project_url_for_version(...
Fix release links for phpMyAdmin.
diff --git a/mongo_mapper_acts_as_versioned.gemspec b/mongo_mapper_acts_as_versioned.gemspec index abc1234..def5678 100644 --- a/mongo_mapper_acts_as_versioned.gemspec +++ b/mongo_mapper_acts_as_versioned.gemspec @@ -17,7 +17,6 @@ gem.files = Dir['{lib,spec}/**/*', 'LICENSE', 'README.md'] & `git ls-files -z`.spl...
Remove MM dependency from gemspec
diff --git a/simple-conf.gemspec b/simple-conf.gemspec index abc1234..def5678 100644 --- a/simple-conf.gemspec +++ b/simple-conf.gemspec @@ -4,9 +4,9 @@ Gem::Specification.new do |gem| gem.authors = ["Alexander Korsak"] gem.email = ["alex.korsak@gmail.com"] - gem.description = %q{TODO: Write a ge...
Add description to the gemspec for the gem
diff --git a/lib/saves/config.rb b/lib/saves/config.rb index abc1234..def5678 100644 --- a/lib/saves/config.rb +++ b/lib/saves/config.rb @@ -0,0 +1,23 @@+module Saves + class Config + class << self + def games_list + return @games_list if @games_list + + games_list = config_file('games.yml') + ...
Add the Configuration code layer
diff --git a/config/unicorn_local.rb b/config/unicorn_local.rb index abc1234..def5678 100644 --- a/config/unicorn_local.rb +++ b/config/unicorn_local.rb @@ -0,0 +1,29 @@+# see https://raw.github.com/defunkt/unicorn/master/examples/unicorn.conf.rb + +APP_PATH = File.expand_path File.join(File.dirname(__FILE__), '..') +d...
Add configuration for local Unicorn/Nginx setip
diff --git a/csv_class_maker.gemspec b/csv_class_maker.gemspec index abc1234..def5678 100644 --- a/csv_class_maker.gemspec +++ b/csv_class_maker.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = %q{csv_class_maker} - s.version = '0.2.0' + s.version = '0.2.1' s.date = %q{2014-03-06} s.authors = [...
Update gemspec file This is why you do features and changes in branches.
diff --git a/motion-rest.gemspec b/motion-rest.gemspec index abc1234..def5678 100644 --- a/motion-rest.gemspec +++ b/motion-rest.gemspec @@ -7,20 +7,12 @@ spec.name = "motion-rest" spec.version = Motion::Rest::VERSION spec.authors = ["Andrew Havens"] - spec.email = ["andrewh@copiou...
Update summary and other metadata
diff --git a/src/make_new_entry.rb b/src/make_new_entry.rb index abc1234..def5678 100644 --- a/src/make_new_entry.rb +++ b/src/make_new_entry.rb @@ -0,0 +1,44 @@+################################################################################ +#This program will connect to a world model at a user-provided address and p...
Add a new entry into the world model, for example with the gtk demo. new file: make_new_entry.rb
diff --git a/app/controllers/api/docs_controller.rb b/app/controllers/api/docs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/docs_controller.rb +++ b/app/controllers/api/docs_controller.rb @@ -14,6 +14,9 @@ def get_url_query_parameters_for(section) case section when :Agendas + { + ...
Add URL Query Help Text For Agendas In API Docs
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -2,7 +2,7 @@ USER_KEY = :user TEXT_KEY = :text TIMESTAMP_KEY = :timestamp - MAX_COMMENTS_TO_LOA...
Fix comments not appearing properly when you have more than the max comments amount
diff --git a/app/controllers/services_controller.rb b/app/controllers/services_controller.rb index abc1234..def5678 100644 --- a/app/controllers/services_controller.rb +++ b/app/controllers/services_controller.rb @@ -16,7 +16,7 @@ end def create - @service = Service.new(params.require(:service).permit(:servic...
Allow saving of port and hosted bool
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -11,7 +11,9 @@ else flash[:error] = "You need a codescool.com or envylabs.com account to sign...
Fix OAuth callback triggering of return_to.
diff --git a/tasks/local.rake b/tasks/local.rake index abc1234..def5678 100644 --- a/tasks/local.rake +++ b/tasks/local.rake @@ -10,7 +10,7 @@ argv = ARGV[1..-1] # If it's a rails command, or we're using Rails 5, auto add the rails script - rails_commands = %w(generate console server dbconsole g c s runner) + ...
Add db to rails_commands list
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -4,8 +4,8 @@ require 'simplecov' SimpleCov.start unless ENV['skip_coverage'] - # require "codeclimate-test-reporter" - # CodeClimate::TestReporter.start if ENV['CODECLIMAT...
Revert "Temporarily disable CodeClimate test reporting to see if thats " This reverts commit 05df6ebadbcb51e959f5fad3f015667a3b189524.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -23,8 +23,6 @@ options = Net::SSH::Config.for(host) -options[:user] ||= Etc.getlogin - set :host, options[:host_name] || host # Get HostName and User value from Env ...
Fix ssh user issue with helper script
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -10,11 +10,6 @@ def run_erl(code) cmd = %Q{erl -noshell -eval "A = #{code.split.join(' ')}, io:put_chars(binary_to_list(A))." -s erlang halt} `#{cmd}` - end - - def e...
Remove dead test helper method.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -6,6 +6,7 @@ require 'timecop' ENV['ES_URL'] = nil +ENV['TZ'] = 'Europe/Amsterdam' # Test in a specific timezone. RSpec.configure do |config| config.order = 'random'
Fix the timezone for the specs. We test in a specific timezone.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -8,3 +8,4 @@ require "lita-wikipedia" require "lita/rspec" +Lita.version_3_compatibility_mode = false
Disable Lita v3 compatibility mode
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -13,6 +13,10 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'libraries')) # Require all our libraries -Dir["#{File.join(File.dirname(__FILE__), '..', 'libraries')...
Load libraries in specific order for Travis CI
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -17,8 +17,3 @@ config.before { Rapporteur.clear_checks } end - - -# This is a shim to allow for Ruby 1.9.3, Rails 3.2 testing to pass. -# See https://github.com/rspec/rspec-ra...
Remove Ruby 1.9.3, Rails 3.2 Test::Unit shim.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -5,14 +5,17 @@ require 'rspec' require 'openreqs' -set :environment, :test +configure do + set :mongo, Mongo::Connection.new.db("openreqs-test") +end + Capybara.app = Sinatr...
Use a different db for the tests
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -6,11 +6,11 @@ ENV['RAILS_ENV'] = 'test' ENV['BUNDLE_GEMFILE'] ||= TESTAPP_ROOT + '/Gemfile' +require "#{TESTAPP_ROOT}/config/environment" require 'rspec' require 'bourne' re...
Rearrange requires such that tests pass.
diff --git a/lib/pact_broker/api/decorators/version_decorator.rb b/lib/pact_broker/api/decorators/version_decorator.rb index abc1234..def5678 100644 --- a/lib/pact_broker/api/decorators/version_decorator.rb +++ b/lib/pact_broker/api/decorators/version_decorator.rb @@ -9,14 +9,6 @@ property :number co...
Remove duplicate :self block in VersionDecorator.
diff --git a/syntax.gemspec b/syntax.gemspec index abc1234..def5678 100644 --- a/syntax.gemspec +++ b/syntax.gemspec @@ -9,7 +9,7 @@ s.homepage = "https://github.com/dblock/syntax" s.license = "BSD" - s.add_development_dependency "rake" + s.add_development_dependency "rake", "< 11.0.0" s.add_development_dep...
Use an old rake release for 1.9.2 and 1.8.7
diff --git a/omnibus-ctl.gemspec b/omnibus-ctl.gemspec index abc1234..def5678 100644 --- a/omnibus-ctl.gemspec +++ b/omnibus-ctl.gemspec @@ -13,6 +13,7 @@ s.required_ruby_version = ">= 2.6" + s.add_development_dependency "chefstyle", "2.0.9" s.add_development_dependency "rake" s.add_development_dependency ...
Add chefstyle as a dep Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/test/db/mssql.rb b/test/db/mssql.rb index abc1234..def5678 100644 --- a/test/db/mssql.rb +++ b/test/db/mssql.rb @@ -1,9 +1,9 @@-host = ENV['SQLHOST'] || 'localhost' config = { :username => 'blog', :password => '', :adapter => 'mssql', :database => 'weblog_development' } +config[:host] = ENV[...
Allow override of host where sqlserver is running through ENV['SQLHOST']
diff --git a/app/controllers/api/docs_controller.rb b/app/controllers/api/docs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/docs_controller.rb +++ b/app/controllers/api/docs_controller.rb @@ -10,8 +10,8 @@ key :description, 'Prometheus 2.0 API documentation.' end key :sche...
Change api url to production
diff --git a/app/controllers/api/tags_controller.rb b/app/controllers/api/tags_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/tags_controller.rb +++ b/app/controllers/api/tags_controller.rb @@ -1,4 +1,3 @@-require 'byebug' class Api::TagsController < ApplicationController before_action :ens...
Remove byebug from tags controller
diff --git a/test/template.rb b/test/template.rb index abc1234..def5678 100644 --- a/test/template.rb +++ b/test/template.rb @@ -12,6 +12,9 @@ gem 'mysql2' gem 'nokogiri' gem 'sassc' +gem 'google-protobuf' +gem 'ox' +gem 'oj' # Ensure that git works gem 'currencies', git: 'https://github.com/hexorx/currencies.git...
Add ox, oj and google-protobuf to tested gems
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -1,7 +1,11 @@ class SessionsController < ApplicationController def show - user = User.find(session...
Refactor session controller to not use session if it doesn't exist
diff --git a/tabulo.gemspec b/tabulo.gemspec index abc1234..def5678 100644 --- a/tabulo.gemspec +++ b/tabulo.gemspec @@ -29,5 +29,4 @@ spec.add_development_dependency "simplecov" spec.add_development_dependency "coveralls" spec.add_development_dependency "yard" - spec.add_development_dependency "yard-tomdoc" ...
Remove unused development dependency (yard-tomdoc).
diff --git a/app/helpers/defence_requests_helper.rb b/app/helpers/defence_requests_helper.rb index abc1234..def5678 100644 --- a/app/helpers/defence_requests_helper.rb +++ b/app/helpers/defence_requests_helper.rb @@ -14,7 +14,7 @@ "tomorrow" elsif initial_date < today ...
Fix date chooser helper - broken `if` statement.
diff --git a/lib/bouncer/preemptive_rules.rb b/lib/bouncer/preemptive_rules.rb index abc1234..def5678 100644 --- a/lib/bouncer/preemptive_rules.rb +++ b/lib/bouncer/preemptive_rules.rb @@ -10,9 +10,9 @@ def self.try(context, renderer) request = context.request if request.host == 'www.environment-agenc...
Make EA rules case insensitive
diff --git a/temple.gemspec b/temple.gemspec index abc1234..def5678 100644 --- a/temple.gemspec +++ b/temple.gemspec @@ -21,4 +21,5 @@ # can be used without it. s.add_development_dependency('tilt') s.add_development_dependency('bacon') + s.add_development_dependency('rake') end
Add rake as development dependency
diff --git a/lib/ardes/rc_responses_module.rb b/lib/ardes/rc_responses_module.rb index abc1234..def5678 100644 --- a/lib/ardes/rc_responses_module.rb +++ b/lib/ardes/rc_responses_module.rb @@ -1,14 +1,24 @@ module Ardes - # Just like ResponsesModule, but also handles the :except, :only stuff + # Just like ResponsesMo...
Make sure we dup our action_responses when the module is dup'd
diff --git a/lib/pod/command/dependencies.rb b/lib/pod/command/dependencies.rb index abc1234..def5678 100644 --- a/lib/pod/command/dependencies.rb +++ b/lib/pod/command/dependencies.rb @@ -32,7 +32,7 @@ config.podfile, @ignore_lockfile ? nil : config.lockfile ) - specs = ana...
Allow analyzer to fetch external specs
diff --git a/lib/rails_admin/config/proxy.rb b/lib/rails_admin/config/proxy.rb index abc1234..def5678 100644 --- a/lib/rails_admin/config/proxy.rb +++ b/lib/rails_admin/config/proxy.rb @@ -2,7 +2,7 @@ module Config class Proxy - instance_methods.each { |m| undef_method m unless m =~ /^__/ || m == "object_...
Fix warning about undefining object_id in the Proxy class
diff --git a/lib/range_sentence_validator.rb b/lib/range_sentence_validator.rb index abc1234..def5678 100644 --- a/lib/range_sentence_validator.rb +++ b/lib/range_sentence_validator.rb @@ -9,6 +9,6 @@ # validates :year_sentence, :range_sentence => true # end def validate_each(record, attribute, value) - ...
Use RangeSentenceParser.invalid? instead of instance method
diff --git a/lib/devise/models/validatable.rb b/lib/devise/models/validatable.rb index abc1234..def5678 100644 --- a/lib/devise/models/validatable.rb +++ b/lib/devise/models/validatable.rb @@ -12,14 +12,18 @@ def self.included(base) base.class_eval do + attribute = authentication_keys.first ...
Make validations based on authentication keys.
diff --git a/lib/siebel_donations/address.rb b/lib/siebel_donations/address.rb index abc1234..def5678 100644 --- a/lib/siebel_donations/address.rb +++ b/lib/siebel_donations/address.rb @@ -7,7 +7,7 @@ def type case @type - when 'Mailing Address' + when 'Mailing Address', 'Ship To', 'Ma', 'Mailng'...
Add more data corrections for bad Siebel data
diff --git a/lib/smart_api/params_handler.rb b/lib/smart_api/params_handler.rb index abc1234..def5678 100644 --- a/lib/smart_api/params_handler.rb +++ b/lib/smart_api/params_handler.rb @@ -36,7 +36,7 @@ end class Parameters < Struct.new(:values, :errors) - delegate :has_key?, :==, :[], :to_hash, :to => ...
Add slice/except to parameters class
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -6,22 +6,34 @@ require 'json' def test_site - @site ||= UsesThis::Site.new(Dimples::Configuration.new( + @test_site ||= UsesThis::Site.new(test_configuration) +end + +def test_configuration + @t...
Add a test_configuration, temp_site_path and test_interview method, switch to JSON.parse.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -7,7 +7,6 @@ rescue LoadError end -require "rubygems" require "cutest" def silence_warnings
Remove rubygems require. Ohm supports Ruby >=1.9.
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -12,8 +12,8 @@ if RUBY_VERSION =~ /^1.9/ begin require 'turn/autorun' - f = ENV['format'] - Turn.config.format = f.to_sym + # f = ENV['format'] || 'progress' + # Turn.config.forma...
Remove automatic progress so 'turn' command line util will work
diff --git a/lib/tasks/errbit/bootstrap.rake b/lib/tasks/errbit/bootstrap.rake index abc1234..def5678 100644 --- a/lib/tasks/errbit/bootstrap.rake +++ b/lib/tasks/errbit/bootstrap.rake @@ -7,7 +7,7 @@ configs = { 'config.example.yml' => 'config.yml', 'deploy.example.rb' => 'deploy.rb', - 'mong...
Copy mongohq example conf on heroku
diff --git a/lib/rubocop/cop/favor_sprintf.rb b/lib/rubocop/cop/favor_sprintf.rb index abc1234..def5678 100644 --- a/lib/rubocop/cop/favor_sprintf.rb +++ b/lib/rubocop/cop/favor_sprintf.rb @@ -15,10 +15,12 @@ next unless matching?(operator, op1, op2) # FIXME implement reliable lineno extraction +...
Add a bit of explanation to FavorSprintf
diff --git a/lib/tassadar/server/whitelist.rb b/lib/tassadar/server/whitelist.rb index abc1234..def5678 100644 --- a/lib/tassadar/server/whitelist.rb +++ b/lib/tassadar/server/whitelist.rb @@ -11,8 +11,8 @@ @app.call(env) else [ 403, - {'Content-Type' => 'text/plain; charset=utf...
Fix the same issue rack-throttle had
diff --git a/lib/yahoo_quote/configuration.rb b/lib/yahoo_quote/configuration.rb index abc1234..def5678 100644 --- a/lib/yahoo_quote/configuration.rb +++ b/lib/yahoo_quote/configuration.rb @@ -2,9 +2,13 @@ class Configuration def self.cache_dir=(path) - dir = path.to_s - Dir.mkdir(dir) unless dir.emp...
Fix case path = nil
diff --git a/parallel_rspec.gemspec b/parallel_rspec.gemspec index abc1234..def5678 100644 --- a/parallel_rspec.gemspec +++ b/parallel_rspec.gemspec @@ -21,5 +21,4 @@ spec.add_dependency "rake", "> 10.0" spec.add_dependency "rspec" - spec.add_development_dependency "bundler", "~> 1.10" end
Remove an unnecessary dev dependency to pacify dependabot
diff --git a/lib/did_you_mean/core_ext/name_error.rb b/lib/did_you_mean/core_ext/name_error.rb index abc1234..def5678 100644 --- a/lib/did_you_mean/core_ext/name_error.rb +++ b/lib/did_you_mean/core_ext/name_error.rb @@ -12,7 +12,9 @@ def to_s msg = original_message - msg << did_you_mean?.to_s if IGNORED_CA...
Reduce memory allocation by about 40% https://gist.github.com/yuki24/5025a7b8603c25dcdd89/d3c11b614c06aa0fc1193f252960ecfb8a0c368a
diff --git a/core/app/models/calculator/per_item.rb b/core/app/models/calculator/per_item.rb index abc1234..def5678 100644 --- a/core/app/models/calculator/per_item.rb +++ b/core/app/models/calculator/per_item.rb @@ -10,7 +10,7 @@ ShippingMethod.register_calculator(self) end - def compute(line_items=nil) - ...
Revert "Fix error in PerItem calculator" This reverts commit 5f270b7ad263859c2da75f72ff0405e4ab1e770b.
diff --git a/lib/github-pages.rb b/lib/github-pages.rb index abc1234..def5678 100644 --- a/lib/github-pages.rb +++ b/lib/github-pages.rb @@ -13,8 +13,8 @@ "rdiscount" => "2.1.7", "redcarpet" => "2.3.0", "RedCloth" => "4.2.9", - "jemoji" => "0.0.10...
Update jemoji and jekyll-mentions dependencies to allow for Jekyll 1.5.0
diff --git a/lib/jiraSOAP/url.rb b/lib/jiraSOAP/url.rb index abc1234..def5678 100644 --- a/lib/jiraSOAP/url.rb +++ b/lib/jiraSOAP/url.rb @@ -5,6 +5,7 @@ # URI object if you are running on CRuby, but it will be an NSURL if you # are running on MacRuby. class URL + # @return [NSURL, URI::HTTP] the type depends on your...
Document the type for the URL class' only attribute
diff --git a/app/helpers/assets_helper.rb b/app/helpers/assets_helper.rb index abc1234..def5678 100644 --- a/app/helpers/assets_helper.rb +++ b/app/helpers/assets_helper.rb @@ -1,9 +1,9 @@ module AssetsHelper - def render_asset(asset,custom_class) + def render_asset(asset, custom_class=nil) case(asset.mime.spl...
Make custom_class optional in render_asset helper
diff --git a/lib/rspec/sidekiq/matchers/be_unique.rb b/lib/rspec/sidekiq/matchers/be_unique.rb index abc1234..def5678 100644 --- a/lib/rspec/sidekiq/matchers/be_unique.rb +++ b/lib/rspec/sidekiq/matchers/be_unique.rb @@ -17,7 +17,15 @@ def matches?(job) @klass = job.is_a?(Class) ? job : job.class ...
Verify the value based on which uniquing type is available
diff --git a/lib/salesforce_bulk/salesforce_error.rb b/lib/salesforce_bulk/salesforce_error.rb index abc1234..def5678 100644 --- a/lib/salesforce_bulk/salesforce_error.rb +++ b/lib/salesforce_bulk/salesforce_error.rb @@ -9,10 +9,18 @@ def initialize(response) self.response = response - data = Xm...
Update SalesforceError to parse XML response for CSV requests (plain XML format is used over SOAP in those cases).
diff --git a/lib/snowplow_ruby_duid/domain_userid.rb b/lib/snowplow_ruby_duid/domain_userid.rb index abc1234..def5678 100644 --- a/lib/snowplow_ruby_duid/domain_userid.rb +++ b/lib/snowplow_ruby_duid/domain_userid.rb @@ -1,3 +1,5 @@+require 'securerandom' + module SnowplowRubyDuid # Generates a pseudo-unique ID to ...
Fix failing specs due to missing secure random require
diff --git a/lib/templates/rspec/model/model_spec.rb b/lib/templates/rspec/model/model_spec.rb index abc1234..def5678 100644 --- a/lib/templates/rspec/model/model_spec.rb +++ b/lib/templates/rspec/model/model_spec.rb @@ -2,15 +2,15 @@ <% module_namespacing do -%> RSpec.describe <%= class_name %>, :type => :model do ...
Adjust rspec model template to comment out boilerplate
diff --git a/app/models/condition_type.rb b/app/models/condition_type.rb index abc1234..def5678 100644 --- a/app/models/condition_type.rb +++ b/app/models/condition_type.rb @@ -12,11 +12,17 @@ order("rating DESC").first.rating end def self.min_rating - order("rating ASC").first.rating + where('name <> ...
Fix determination of rating value
diff --git a/api.rb b/api.rb index abc1234..def5678 100644 --- a/api.rb +++ b/api.rb @@ -18,12 +18,20 @@ route_param :id do desc 'Returns all messages for an inbox.' + params do + optional :from, type: String + end get 'messages' do inbox = Models::Inbox[param...
Add from parameter on inbox messages
diff --git a/test_examples/fast/spec_test.rb b/test_examples/fast/spec_test.rb index abc1234..def5678 100644 --- a/test_examples/fast/spec_test.rb +++ b/test_examples/fast/spec_test.rb @@ -0,0 +1,25 @@+require 'minitest/autorun' + +class FakeCalculator + def add(x, y) + x + y + end + + def mal(x, y) + x * y + ...
Add example minitest with rspec syntax
diff --git a/lib/roots/engine.rb b/lib/roots/engine.rb index abc1234..def5678 100644 --- a/lib/roots/engine.rb +++ b/lib/roots/engine.rb @@ -1,5 +1,11 @@ module Roots class Engine < ::Rails::Engine isolate_namespace Roots + + initializer 'roots', before: :load_config_initializers do |app| + Rails.appl...
Allow Roots to mount itself
diff --git a/lib/specter/spec.rb b/lib/specter/spec.rb index abc1234..def5678 100644 --- a/lib/specter/spec.rb +++ b/lib/specter/spec.rb @@ -8,23 +8,14 @@ @_block end - def scopes - Specter.now.scopes - end - - def prepares - scopes.map(&:prepares).flatten - end - def initialize(...
Simplify calling of prepare blocks.
diff --git a/tzinfo.gemspec b/tzinfo.gemspec index abc1234..def5678 100644 --- a/tzinfo.gemspec +++ b/tzinfo.gemspec @@ -16,6 +16,6 @@ s.rdoc_options << '--title' << 'TZInfo' << '--main' << 'README.md' s.extra_rdoc_files = ['README.md', 'CHANGES.md', 'LICENSE'] - s.required_ruby_version = '>...
Raise minimum Ruby version to 1.8.7. minitest v5 is not compatible with Ruby 1.8.6.
diff --git a/config/initializers/wrap_parameters.rb b/config/initializers/wrap_parameters.rb index abc1234..def5678 100644 --- a/config/initializers/wrap_parameters.rb +++ b/config/initializers/wrap_parameters.rb @@ -1,13 +1,13 @@ # Be sure to restart your server when you modify this file. -# + # This file contains se...
Include wrap paramters for User controller
diff --git a/video_embed.rb b/video_embed.rb index abc1234..def5678 100644 --- a/video_embed.rb +++ b/video_embed.rb @@ -6,9 +6,9 @@ Hosts = { "ted" => ->(id) { "https://embed-ssl.ted.com/talks/#{id}.html" }, - "ustream" => ->(id) { "http://ustream.tv/embed/#{id}" }, + "ustream" => ->(id) { "...
Add https support for youtube and ustream
diff --git a/wait_up.gemspec b/wait_up.gemspec index abc1234..def5678 100644 --- a/wait_up.gemspec +++ b/wait_up.gemspec @@ -20,7 +20,7 @@ s.add_dependency('gir_ffi-gtk', ['~> 0.8.0']) s.add_dependency('gir_ffi-gst', ['~> 0.0.1']) - s.add_dependency('gir_ffi', ['~> 0.8.3.pre1']) + s.add_dependency('gir_ffi', [...
Use released gir_ffi gem version
diff --git a/lib/bwoken/build.rb b/lib/bwoken/build.rb index abc1234..def5678 100644 --- a/lib/bwoken/build.rb +++ b/lib/bwoken/build.rb @@ -12,7 +12,7 @@ end def sdk - 'iphonesimulator5.1' + 'iphoneos' end def env_variables
Use most recent sdk by default