diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/dimples/post.rb b/lib/dimples/post.rb index abc1234..def5678 100644 --- a/lib/dimples/post.rb +++ b/lib/dimples/post.rb @@ -24,7 +24,7 @@ @slug = parts[4] @layout = @site.config[:layouts][:post] - self.date = Time.mktime(parts[1], parts[2], parts[3]) + self.date = DateTime.new(...
Switch to DateTime instead of Time
diff --git a/lib/ansible/transmit.rb b/lib/ansible/transmit.rb index abc1234..def5678 100644 --- a/lib/ansible/transmit.rb +++ b/lib/ansible/transmit.rb @@ -2,6 +2,8 @@ module Transmit def self.extended(base) base.class_eval do + include ActionController::Live + def self._beacons ...
Add in ActionController::Live in class_eval
diff --git a/lib/axiom/types/hash.rb b/lib/axiom/types/hash.rb index abc1234..def5678 100644 --- a/lib/axiom/types/hash.rb +++ b/lib/axiom/types/hash.rb @@ -9,16 +9,23 @@ coercion_method :to_hash accept_options :key_type, :value_type - key_type ::Object - value_type ::Object + key_type ...
Add constraints for Hash type
diff --git a/lib/flickr/error.rb b/lib/flickr/error.rb index abc1234..def5678 100644 --- a/lib/flickr/error.rb +++ b/lib/flickr/error.rb @@ -38,7 +38,7 @@ ## # @private # - def initialize(message, code = nil) + def initialize(message = nil, code = nil) super(message) @code = code.to_i ...
Make the ApiError message optional Fixes #9
diff --git a/lib/contentful_rails.rb b/lib/contentful_rails.rb index abc1234..def5678 100644 --- a/lib/contentful_rails.rb +++ b/lib/contentful_rails.rb @@ -1,6 +1,5 @@ require "contentful_rails/engine" require "contentful_rails/development_constraint" -require 'contentful_rails/caching/objects' require 'contentful_r...
Remove reference to object cachign
diff --git a/lib/gemrat/arguments.rb b/lib/gemrat/arguments.rb index abc1234..def5678 100644 --- a/lib/gemrat/arguments.rb +++ b/lib/gemrat/arguments.rb @@ -2,13 +2,12 @@ class Arguments class UnableToParse < StandardError; end - ATTRIBUTES = [:gems, :gemfile, :replace_gem] + ATTRIBUTES = [:gems, :gemfil...
Remove all instances of :replace_gem, they're no longer needed
diff --git a/lib/knuckles/fetcher.rb b/lib/knuckles/fetcher.rb index abc1234..def5678 100644 --- a/lib/knuckles/fetcher.rb +++ b/lib/knuckles/fetcher.rb @@ -6,17 +6,24 @@ "fetcher".freeze end - def call(objects, options) - view = options.fetch(:view) + def call(prepared, options) + results ...
Use read_multi for the fetching stage
diff --git a/lib/looksee/core_ext.rb b/lib/looksee/core_ext.rb index abc1234..def5678 100644 --- a/lib/looksee/core_ext.rb +++ b/lib/looksee/core_ext.rb @@ -1,21 +1,21 @@ module Looksee module ObjectMixin # - # Shortcut for Looksee[self, *args]. + # Define #ls as a shortcut for Looksee[self, *args]. + ...
Clean up ObjectMixin, update docs, don't print, define respond_to?.
diff --git a/lib/pew_pew/resource.rb b/lib/pew_pew/resource.rb index abc1234..def5678 100644 --- a/lib/pew_pew/resource.rb +++ b/lib/pew_pew/resource.rb @@ -20,6 +20,16 @@ end private :post + def put(*) + super.body + end + private :put + + def delete(*) + super.body + end + priva...
Return response body for PUT and DELETE requests.
diff --git a/lib/serf/command.rb b/lib/serf/command.rb index abc1234..def5678 100644 --- a/lib/serf/command.rb +++ b/lib/serf/command.rb @@ -20,6 +20,7 @@ include Serf::Util::WithOptionsExtraction attr_reader :request + attr_reader :args def initialize(request, *args) extract_options! args
Add attr_reader for args in Command. Details: * We have the reader for the set request, but we also want it for the remaining args.
diff --git a/lib/tasks/pull.rake b/lib/tasks/pull.rake index abc1234..def5678 100644 --- a/lib/tasks/pull.rake +++ b/lib/tasks/pull.rake @@ -21,25 +21,22 @@ # TODO: Limit batch size after Feed#stale? is fixed # .limit(Defaults::MAX_FEEDS_PER_BATCH) - feeds_count = feeds.count - if feeds_count.zero? -...
Remove redundant checks; add data point reference to processing errors
diff --git a/librato-metrics.gemspec b/librato-metrics.gemspec index abc1234..def5678 100644 --- a/librato-metrics.gemspec +++ b/librato-metrics.gemspec @@ -16,7 +16,7 @@ s.authors = ["Matt Sanders"] s.email = 'matt@librato.com' - s.homepage = 'http://metrics.librato.com' + s.homepage = 'https://github.com...
Switch gem website to github repo.
diff --git a/scripts/remove-gems.rb b/scripts/remove-gems.rb index abc1234..def5678 100644 --- a/scripts/remove-gems.rb +++ b/scripts/remove-gems.rb @@ -0,0 +1,7 @@+#!/usr/bin/env ruby +`gem list --no-versions`.split("\n").each do |gem| + `gem list -d #{gem}`.gsub(/Installed at(.*):.*/).each do |dir| + dir = dir.gs...
Add a script to remove all ruby gems.
diff --git a/spec/views/events/edit.html.erb_spec.rb b/spec/views/events/edit.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/events/edit.html.erb_spec.rb +++ b/spec/views/events/edit.html.erb_spec.rb @@ -13,6 +13,8 @@ assert_select "input#event_description[name=?]", "event[description]" as...
Add additional edit view test not required in specification
diff --git a/Casks/tg-pro.rb b/Casks/tg-pro.rb index abc1234..def5678 100644 --- a/Casks/tg-pro.rb +++ b/Casks/tg-pro.rb @@ -1,11 +1,11 @@ cask :v1 => 'tg-pro' do - version '2.8.5' - sha256 'ddffad55f0c8998323d270649f22f3e7a63ed45f867ba141a4b6df2b76bca6fc' + version '2.8.7' + sha256 '32b622cec40f4cfe0cd5455dd110696...
Update TG Pro to 2.8.7
diff --git a/Casks/tower1.rb b/Casks/tower1.rb index abc1234..def5678 100644 --- a/Casks/tower1.rb +++ b/Casks/tower1.rb @@ -5,8 +5,9 @@ url 'http://www.git-tower.com/download-v1' appcast 'https://macapps.fournova.com/tower1-1060/updates.xml', :sha256 => '0a053ca1cf31f5dd6512a4528a4d793a4993c2e180002c49...
Tower1: Add name and update license stanza
diff --git a/etc/mitamae/cookbooks/rbenv/default.rb b/etc/mitamae/cookbooks/rbenv/default.rb index abc1234..def5678 100644 --- a/etc/mitamae/cookbooks/rbenv/default.rb +++ b/etc/mitamae/cookbooks/rbenv/default.rb @@ -16,6 +16,7 @@ end file "#{node[:home]}/.anyenv/envs/rbenv/default-gems" do + content "rails\n" c...
Install `rails` on executing `rbenv install`
diff --git a/resources/notify.rb b/resources/notify.rb index abc1234..def5678 100644 --- a/resources/notify.rb +++ b/resources/notify.rb @@ -1,6 +1,6 @@ provides :slack_notify -property :message, String, name_attribute: true +property :message, String, name_property: true property :channels, Array, default: [] prop...
Resolve the new FC118 foodcritic warning Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/lib/clock_indicator/calendar_window.rb b/lib/clock_indicator/calendar_window.rb index abc1234..def5678 100644 --- a/lib/clock_indicator/calendar_window.rb +++ b/lib/clock_indicator/calendar_window.rb @@ -11,7 +11,7 @@ CAL_WIDTH = 350 def cals_in_window - (Gdk::Screen.width / CAL_WIDTH...
Put a maximum of 7 calendars
diff --git a/lib/opsicle/commands/ssh_clean_keys.rb b/lib/opsicle/commands/ssh_clean_keys.rb index abc1234..def5678 100644 --- a/lib/opsicle/commands/ssh_clean_keys.rb +++ b/lib/opsicle/commands/ssh_clean_keys.rb @@ -8,8 +8,7 @@ def execute(options={}) instances.each do |instance| - # As a side note...
Update comment (WITH NEW KNOWLEDGE)
diff --git a/test/integration/users_login_test.rb b/test/integration/users_login_test.rb index abc1234..def5678 100644 --- a/test/integration/users_login_test.rb +++ b/test/integration/users_login_test.rb @@ -10,7 +10,7 @@ test "login with invalid information" do get @login_path assert_template 'login_page/...
Fix DEPRECATION: Use new keyword style for POST in Integration Test
diff --git a/Formula/exult.rb b/Formula/exult.rb index abc1234..def5678 100644 --- a/Formula/exult.rb +++ b/Formula/exult.rb @@ -1,4 +1,6 @@ require 'formula' + +# TODO we shouldn't be installing .apps if there is an option class Exult <Formula # Use a specific revision that is known to compile (on Snow Leopard t...
Install single files to prefix It's a single .app file, our convention here is typically to just put it at the formula's prefix root.
diff --git a/lib/spree_shared/apartment_elevator.rb b/lib/spree_shared/apartment_elevator.rb index abc1234..def5678 100644 --- a/lib/spree_shared/apartment_elevator.rb +++ b/lib/spree_shared/apartment_elevator.rb @@ -34,17 +34,19 @@ #Spraycan::Engine.initialize_themes rescue Exception => e ...
Fix handling of missing db / subdomain
diff --git a/MOAspects.podspec b/MOAspects.podspec index abc1234..def5678 100644 --- a/MOAspects.podspec +++ b/MOAspects.podspec @@ -6,7 +6,7 @@ s.license = 'MIT' s.author = { "Hiromi Motodera" => "moai.motodera@gmail.com" } s.source = { :git => "https://github.com/MO-AI/MOAspects.git", :tag...
Update pod spec for source files
diff --git a/spec/guideline/checker_factory_spec.rb b/spec/guideline/checker_factory_spec.rb index abc1234..def5678 100644 --- a/spec/guideline/checker_factory_spec.rb +++ b/spec/guideline/checker_factory_spec.rb @@ -19,10 +19,10 @@ end it "creates instances of given classes with given config" do - ...
Refactor not to use should receive and check option value
diff --git a/app/controllers/spree/admin/review_settings_controller.rb b/app/controllers/spree/admin/review_settings_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/admin/review_settings_controller.rb +++ b/app/controllers/spree/admin/review_settings_controller.rb @@ -8,9 +8,9 @@ Spree::Revi...
Use multi-lined do and end in ReviewSettingsController
diff --git a/sprout-osx-base/attributes/versions.rb b/sprout-osx-base/attributes/versions.rb index abc1234..def5678 100644 --- a/sprout-osx-base/attributes/versions.rb +++ b/sprout-osx-base/attributes/versions.rb @@ -1 +1 @@-node.default['versions']['bash_it'] = '8bf641baec4316cebf1bc1fd2757991f902506dc' +node.default[...
Update bash-it sha to latest Includes * chruby(-auto) plugin rename [306f7b1587](https://github.com/revans/bash-it/commit/306f7b1587486cd4ed20726f64ecc2bf96334d47) * system-ruby display in prompt [5ef3f817fe](https://github.com/revans/bash-it/commit/5ef3f817fef1aff10f34881f856a60f4066ac1ea)
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -20,3 +20,12 @@ $:.unshift 'lib' require 'groff_parser/document' require 'groff_parser/engine' + +# Allow usage of 'context' like 'describe' +module MiniTest + class Spec + c...
Test Suite: enables the usage of context like describe
diff --git a/tumblr_client.gemspec b/tumblr_client.gemspec index abc1234..def5678 100644 --- a/tumblr_client.gemspec +++ b/tumblr_client.gemspec @@ -5,7 +5,7 @@ gem.add_dependency 'faraday', '~> 0.9.0' gem.add_dependency 'faraday_middleware', '~> 0.9.0' gem.add_dependency 'json' - gem.add_dependency 'simple_oa...
Revert "Enforced simple_oauth ~> 0.2.0 as a dependency" This reverts commit 0f9a4b160540edf2397631ce956067f035cfe4b2.
diff --git a/test/integration/compute/core_compute/test_disks.rb b/test/integration/compute/core_compute/test_disks.rb index abc1234..def5678 100644 --- a/test/integration/compute/core_compute/test_disks.rb +++ b/test/integration/compute/core_compute/test_disks.rb @@ -29,4 +29,25 @@ :type => ...
Add an integration test for snapshots
diff --git a/TorchORM.podspec b/TorchORM.podspec index abc1234..def5678 100644 --- a/TorchORM.podspec +++ b/TorchORM.podspec @@ -20,7 +20,10 @@ s.tvos.deployment_target = '9.0' s.source_files = ['Source/**/*.swift'] s.preserve_paths = ['Generator/**/*', 'run'] - s.prepare_comma...
Add git submodule init to prepare_command.
diff --git a/test/redis/store/redis_version_test.rb b/test/redis/store/redis_version_test.rb index abc1234..def5678 100644 --- a/test/redis/store/redis_version_test.rb +++ b/test/redis/store/redis_version_test.rb @@ -11,15 +11,16 @@ describe '#redis_version' do it 'returns redis version' do - @store.redis...
Handle minor and patch version correctly as they may be multiple digits
diff --git a/controller_validator.gemspec b/controller_validator.gemspec index abc1234..def5678 100644 --- a/controller_validator.gemspec +++ b/controller_validator.gemspec @@ -19,7 +19,7 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.7" - spec.add_development_dependency "rake"...
Upgrade rake to version 12.3.0
diff --git a/lib/fooda-bot/slack_event_formatter.rb b/lib/fooda-bot/slack_event_formatter.rb index abc1234..def5678 100644 --- a/lib/fooda-bot/slack_event_formatter.rb +++ b/lib/fooda-bot/slack_event_formatter.rb @@ -21,8 +21,12 @@ end def formatted_reactions - reactions.reactions.map do |reaction| - "#{...
Fix for when nobody reacts
diff --git a/lib/podio/models/app_store_category.rb b/lib/podio/models/app_store_category.rb index abc1234..def5678 100644 --- a/lib/podio/models/app_store_category.rb +++ b/lib/podio/models/app_store_category.rb @@ -14,8 +14,8 @@ end # @see https://developers.podio.com/doc/app-market/get-categories-37009 - ...
Add options to get the categories
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -32,11 +32,9 @@ end end -# Set FOG_MOCK=true to enable Fog Mock mode. -# NB: Your test data will need to reflect the 'initial data structure' in -# https://github.com/fog...
Clarify explanation of how to set up fog mock mode We are adding the test data to [our shared setup](https://github.gds/gds/vcloud-tools-testing-config/blob/master/vcloud_tools_testing_config.yaml) so this detail is for external users.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,13 +1,15 @@ require "simplecov" SimpleCov.start +require "webmock/rspec" + if ENV["CI"] + WebMock.disable_net_connect!(allow: "codeclimate.com") require "codeclimate-tes...
Allow net connect to codeclimate
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -21,4 +21,5 @@ config.treat_symbols_as_metadata_keys_with_true_values = true config.run_all_when_everything_filtered = true config.filter_run :focus + config.include Eleme...
Include element helpers in spec helper.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -9,4 +9,11 @@ config.expect_with :rspec do |c| c.syntax = :expect end + + # These two settings work together to allow you to limit a spec run + # to individual examples...
Allow focus: true to work
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,7 +1,6 @@ require File.expand_path('../../lib/urban_dictionary', __FILE__) RSpec.configure do |config| - config.treat_symbols_as_metadata_keys_with_true_values = true con...
Fix RSpec 3.4 deprecation warning > Deprecation Warnings: > > RSpec::Core::Configuration#treat_symbols_as_metadata_keys_with_true_values = > is deprecated, it is now set to true as default and setting it to false has > no effect.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,4 +1,4 @@-if ENV["CODECLIMATE_REPO_TOKEN"] +if ENV["CC_TEST_REPORTER_ID"] require "simplecov" SimpleCov.start end
Send coverage to CodeClimate. Maybe?
diff --git a/spec/stream_spec.rb b/spec/stream_spec.rb index abc1234..def5678 100644 --- a/spec/stream_spec.rb +++ b/spec/stream_spec.rb @@ -7,7 +7,7 @@ before { mock_amqp } - it 'should open a streaming connection' do + it 'should open a event-stream streaming connection' do @event_machine.run do g...
Test Event Stream Format compliance
diff --git a/tty-command.gemspec b/tty-command.gemspec index abc1234..def5678 100644 --- a/tty-command.gemspec +++ b/tty-command.gemspec @@ -14,7 +14,7 @@ spec.homepage = "https://piotrmurach.github.io/tty" spec.license = "MIT" - spec.files = `git ls-files -z`.split("\x0").reject { |f| f.matc...
Change to only load necessary files
diff --git a/voight_kampff.gemspec b/voight_kampff.gemspec index abc1234..def5678 100644 --- a/voight_kampff.gemspec +++ b/voight_kampff.gemspec @@ -12,6 +12,6 @@ s.require_path = 'lib' s.author = "Adam Crownoble" s.email = "adam@obledesign.com" - s.homepage = "https://github.com/adamcrown/Voight-Kampff" + s....
Update gemspec to point to new repository location
diff --git a/0_code_wars/complete_the_pattern_3.rb b/0_code_wars/complete_the_pattern_3.rb index abc1234..def5678 100644 --- a/0_code_wars/complete_the_pattern_3.rb +++ b/0_code_wars/complete_the_pattern_3.rb @@ -0,0 +1,12 @@+# http://www.codewars.com/kata/557341907fbf439911000022 +# --- iteration 1 --- +def pattern(n)...
Add code wars (7) - complete the pattern 3
diff --git a/spec/customer_management_spec.rb b/spec/customer_management_spec.rb index abc1234..def5678 100644 --- a/spec/customer_management_spec.rb +++ b/spec/customer_management_spec.rb @@ -4,30 +4,25 @@ # Author:: jlopezn@neonline.cl describe BingAdsApi::CustomerManagement do - before :all do - @config = BingAd...
Clean up customer management spec
diff --git a/spec/jira/resource/issue_spec.rb b/spec/jira/resource/issue_spec.rb index abc1234..def5678 100644 --- a/spec/jira/resource/issue_spec.rb +++ b/spec/jira/resource/issue_spec.rb @@ -0,0 +1,22 @@+require 'spec_helper' + +describe Jira::Resource::Issue do + + let(:client) { mock() } + + it "should find an is...
Add test for finding issue by key or id
diff --git a/spec/routing/api_routing_spec.rb b/spec/routing/api_routing_spec.rb index abc1234..def5678 100644 --- a/spec/routing/api_routing_spec.rb +++ b/spec/routing/api_routing_spec.rb @@ -7,25 +7,17 @@ end it 'does not route to the GraphqlController' do - expect(get('/api/graphql')).not_to route_to...
Fix spec for routes to the GraphqlController
diff --git a/spec/support/selector_helpers.rb b/spec/support/selector_helpers.rb index abc1234..def5678 100644 --- a/spec/support/selector_helpers.rb +++ b/spec/support/selector_helpers.rb @@ -0,0 +1,7 @@+def dom_id_selector(model) + "#" + ActionController::RecordIdentifier.dom_id(model) +end + +def dom_class_selector...
Add dom_id and dom_class selector helpers for constraining to areas of a page.
diff --git a/test/customer_saved_search_test.rb b/test/customer_saved_search_test.rb index abc1234..def5678 100644 --- a/test/customer_saved_search_test.rb +++ b/test/customer_saved_search_test.rb @@ -7,13 +7,13 @@ end def test_get_customers_from_customer_saved_search - fake 'customers.json?customer_saved_sea...
Update tests to use search endpoint
diff --git a/vagrant_files/basic/change_hostname.rb b/vagrant_files/basic/change_hostname.rb index abc1234..def5678 100644 --- a/vagrant_files/basic/change_hostname.rb +++ b/vagrant_files/basic/change_hostname.rb @@ -1,4 +1,4 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config| config.vm.provision "shell", inli...
Fix setting hostname on none cloud-init based providers
diff --git a/spec/functional/new_app_spec.rb b/spec/functional/new_app_spec.rb index abc1234..def5678 100644 --- a/spec/functional/new_app_spec.rb +++ b/spec/functional/new_app_spec.rb @@ -0,0 +1,58 @@+require 'functional_spec_helper' + +describe 'New app loading' do + TIMEOUT = 10 + + let(:app) { create_app } + let...
Add functional spec for new apps.
diff --git a/spec/support/coverage_loader.rb b/spec/support/coverage_loader.rb index abc1234..def5678 100644 --- a/spec/support/coverage_loader.rb +++ b/spec/support/coverage_loader.rb @@ -1,4 +1,4 @@-MINIMUM_COVERAGE = 76.3 +MINIMUM_COVERAGE = 76.1 unless ENV['COVERAGE'] == 'off' require 'simplecov'
Reduce coverage to travis level
diff --git a/spec/data_table_spec.rb b/spec/data_table_spec.rb index abc1234..def5678 100644 --- a/spec/data_table_spec.rb +++ b/spec/data_table_spec.rb @@ -1,14 +1,34 @@ require 'spec_helper' describe DataTable::DataTable do - let(:row) { ['col1', 2] } + let(:row) { ['col1', 2, Money.new(3)] } + let(:money_class...
Add spec to document existing money behaviour
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -1,7 +1,7 @@ class SessionsController < ApplicationController def callback user = User.omniauth(...
Update must not fail silently
diff --git a/app/jobs/fetch_developers_job.rb b/app/jobs/fetch_developers_job.rb index abc1234..def5678 100644 --- a/app/jobs/fetch_developers_job.rb +++ b/app/jobs/fetch_developers_job.rb @@ -4,10 +4,10 @@ rescue_from ActiveRecord::RecordNotFound, &:message def perform(cache_key) - logins = Rails.cache.read(...
Add check to make sure logins aren't empty
diff --git a/app/models/concerns/sluggable.rb b/app/models/concerns/sluggable.rb index abc1234..def5678 100644 --- a/app/models/concerns/sluggable.rb +++ b/app/models/concerns/sluggable.rb @@ -3,6 +3,10 @@ included do before_validation :generate_slug, if: :generate_slug? + + def self.find_by_slug_or_id(slug...
Add method find_by_slug_or_id to Sluggable module Make it easier to find by slug or id for sluggable models. Will return nil if resource is not found.
diff --git a/spec/travis/app_spec.rb b/spec/travis/app_spec.rb index abc1234..def5678 100644 --- a/spec/travis/app_spec.rb +++ b/spec/travis/app_spec.rb @@ -15,4 +15,16 @@ expect(response.status).to be == 204 end end + + describe 'GET /cache' do + let(:token) { + # payload with no time stamps + ...
Add spec for GET /cache
diff --git a/spree_robokassa.gemspec b/spree_robokassa.gemspec index abc1234..def5678 100644 --- a/spree_robokassa.gemspec +++ b/spree_robokassa.gemspec @@ -7,9 +7,9 @@ s.description = 'TODO: Add (optional) gem description here' s.required_ruby_version = '>= 1.9.3' - # s.author = 'You' - # s.email = 'yo...
Update author to prevent bundler warning
diff --git a/Library/Homebrew/test/formula_test.rb b/Library/Homebrew/test/formula_test.rb index abc1234..def5678 100644 --- a/Library/Homebrew/test/formula_test.rb +++ b/Library/Homebrew/test/formula_test.rb @@ -39,4 +39,12 @@ assert_equal('', result, "--prefix is incorrectly single-quoted in #{f}") end ...
Add formula check for crufy SourceForge URLs.
diff --git a/1_codility/0_training/8_2_equileader.rb b/1_codility/0_training/8_2_equileader.rb index abc1234..def5678 100644 --- a/1_codility/0_training/8_2_equileader.rb +++ b/1_codility/0_training/8_2_equileader.rb @@ -0,0 +1,52 @@+# 100/100 +def solution(arr) + # find the leader for the overall array + stack = [] ...
Add codility training 8-2 equileader
diff --git a/rest-client.gemspec b/rest-client.gemspec index abc1234..def5678 100644 --- a/rest-client.gemspec +++ b/rest-client.gemspec @@ -18,5 +18,6 @@ s.add_development_dependency(%q<webmock>, ["~> 1.4"]) s.add_development_dependency(%q<rspec>, ["~> 2.4"]) s.add_dependency(%q<netrc>, ["~> 0.7.7"]) + s.add_...
Add rdoc to gem dependencies for the sake of Ruby 1.9.2 Without this, attempting to run rake in 1.9.2 will raise a confusing error message about changing 'rake/rdoctask' to 'rdoc/task' in Rakefile, even though this is already done in the Rakefile.
diff --git a/app/controllers/session_controller.rb b/app/controllers/session_controller.rb index abc1234..def5678 100644 --- a/app/controllers/session_controller.rb +++ b/app/controllers/session_controller.rb @@ -6,9 +6,7 @@ email = params[:email] password = params[:password] @user = User.find_by email: ...
Edit session controller so that feature tests pass
diff --git a/app/models/visualization/presenter.rb b/app/models/visualization/presenter.rb index abc1234..def5678 100644 --- a/app/models/visualization/presenter.rb +++ b/app/models/visualization/presenter.rb @@ -18,7 +18,8 @@ description: visualization.description, privacy: visualiza...
Return stats when rendering a visualization to JSON
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -7,6 +7,7 @@ class Star < Sinatra::Base configure do + set :haml, { :format => :html5 } @@config = YAML.load_file('config.yml') Twitter.configure do |config|
Use html5 format for haml.
diff --git a/features/support/capybara.rb b/features/support/capybara.rb index abc1234..def5678 100644 --- a/features/support/capybara.rb +++ b/features/support/capybara.rb @@ -2,3 +2,11 @@ # We think this may be due to timeouts (the default is 2 secs), # so we've increased the default timeout. Capybara.default_wait_...
Add screenshot helper for cucumber @javascript scenarios Call `screenshot` within a Cucumber step and Poltergeist (the capybara driver) will create a tmp/capybara.png file containing a screenshot of the current page. Pass an argument to give the screenshot a different name. Useful when debugging failing steps.
diff --git a/fluent-plugin-loggly.gemspec b/fluent-plugin-loggly.gemspec index abc1234..def5678 100644 --- a/fluent-plugin-loggly.gemspec +++ b/fluent-plugin-loggly.gemspec @@ -9,6 +9,7 @@ s.homepage = "https://github.com/patant/fluent-plugin-loggly" s.summary = %q{Fluentd plugin for output to loggly} s....
Add missing license entry in gemspec Display license information on rubygems.org when release new version.
diff --git a/spec/features/components_guide_spec.rb b/spec/features/components_guide_spec.rb index abc1234..def5678 100644 --- a/spec/features/components_guide_spec.rb +++ b/spec/features/components_guide_spec.rb @@ -0,0 +1,16 @@+require "rails_helper" + +RSpec.feature "Visit Component Guide" do + scenario "User views...
Add test to check component guide loads correctly
diff --git a/spec/lib/angellist_api/request_spec.rb b/spec/lib/angellist_api/request_spec.rb index abc1234..def5678 100644 --- a/spec/lib/angellist_api/request_spec.rb +++ b/spec/lib/angellist_api/request_spec.rb @@ -0,0 +1,53 @@+require 'spec_helper' + +describe AngellistApi::Request do + class DummyRequest; include ...
Add spec tests for request
diff --git a/ext/trie/extconf.rb b/ext/trie/extconf.rb index abc1234..def5678 100644 --- a/ext/trie/extconf.rb +++ b/ext/trie/extconf.rb @@ -1,4 +1,4 @@-system('cd ext/libdatrie && ./configure && make') +system("cd #{File.dirname(__FILE__)}/../libdatrie && ./configure && make") require 'mkmf' dir_config 'trie'
Make the libdatrie compile command use a relative path.
diff --git a/spec/views/home/index.html.erb_spec.rb b/spec/views/home/index.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/home/index.html.erb_spec.rb +++ b/spec/views/home/index.html.erb_spec.rb @@ -12,15 +12,15 @@ visit '/' end - it "displays a sign-up header button" do + i...
Update Home Spec for Learn More Buttons Update the Home page spec to ensure it corresponds to the new Learn More buttons.
diff --git a/spec/support/pages/admin_users_page.rb b/spec/support/pages/admin_users_page.rb index abc1234..def5678 100644 --- a/spec/support/pages/admin_users_page.rb +++ b/spec/support/pages/admin_users_page.rb @@ -11,11 +11,11 @@ end def admin? - !!@element.all('td')[2].find('input[type="checkbox"]')...
Update AdminUsersPage::UserFragment for table changes
diff --git a/spec/views/home/index.html.erb_spec.rb b/spec/views/home/index.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/home/index.html.erb_spec.rb +++ b/spec/views/home/index.html.erb_spec.rb @@ -0,0 +1,53 @@+require 'spec_helper' + +describe "home/index.html.erb" do + include Warden::Test::Helper...
Add Capybara Spec for Home Index View Add a view spec test for the home view to ensure that user logged in/logged out functions as expected.
diff --git a/config/deploy.rb b/config/deploy.rb index abc1234..def5678 100644 --- a/config/deploy.rb +++ b/config/deploy.rb @@ -14,18 +14,6 @@ set :scm_auth_cache, true set :mongrel_conf, "/usr/local/etc/mongrel_cluster/#{application}.yml" -desc "Show source control status of files on server, in case anyone has edi...
Remove old SVN-based Cap tasks
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,10 +1,10 @@ ActionController::Routing::Routes.draw do |map| map.resources :db_instances - map.resources :apps do |apps| - apps.resources :activities do |activities| - activiti...
Remove destroy action from all resources
diff --git a/fech-search.gemspec b/fech-search.gemspec index abc1234..def5678 100644 --- a/fech-search.gemspec +++ b/fech-search.gemspec @@ -15,7 +15,7 @@ gem.require_paths = ["lib"] gem.version = Fech::Search::VERSION - gem.add_dependency "fech", "1.4.1" + gem.add_dependency "fech", "~> 1.4.1" gem....
Use ~> for Fech version dependency
diff --git a/app/models/concerns/hyrax/with_events.rb b/app/models/concerns/hyrax/with_events.rb index abc1234..def5678 100644 --- a/app/models/concerns/hyrax/with_events.rb +++ b/app/models/concerns/hyrax/with_events.rb @@ -10,7 +10,7 @@ # @return [String] def event_class - self.class.name + model...
Use `model_name.name` for event class namespacing Pin the namespacing for events to the model name, not the Ruby class name. In most cases (excepting adopters who have specificially overridden ActiveModel naming behavior) this should have no impact, but loosens the dependency on specific Ruby class names.
diff --git a/app/serializers/assessment_serializer.rb b/app/serializers/assessment_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/assessment_serializer.rb +++ b/app/serializers/assessment_serializer.rb @@ -1,6 +1,6 @@ class AssessmentSerializer < ActiveModel::Serializer embed :ids, include: true -...
Add published flag to assessment serializer.
diff --git a/pandoc-ruby.gemspec b/pandoc-ruby.gemspec index abc1234..def5678 100644 --- a/pandoc-ruby.gemspec +++ b/pandoc-ruby.gemspec @@ -14,7 +14,7 @@ 'LICENSE', 'README.md' ] - s.files = %w( + s.files = %w[ .document Gemfile Gemfile.lock @@ -29,7 +29,7 @@ test/helper.rb test/t...
Use square brackets with `%w` to appease rubocop.
diff --git a/app/views/nodes/article_list.rss.builder b/app/views/nodes/article_list.rss.builder index abc1234..def5678 100644 --- a/app/views/nodes/article_list.rss.builder +++ b/app/views/nodes/article_list.rss.builder @@ -9,7 +9,7 @@ xml.item do xml.title(article.title) xml.category(art...
Use description in RSS as description Body has too much html that could be invalid (ie Images JS etc)
diff --git a/panda_doc.gemspec b/panda_doc.gemspec index abc1234..def5678 100644 --- a/panda_doc.gemspec +++ b/panda_doc.gemspec @@ -16,7 +16,8 @@ spec.license = "MIT" spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } - spec.bindir = "bin" + spe...
Change path to own executables
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -14,6 +14,9 @@ require 'rdf/spec' require 'rdf/isomorphic' +require 'i18n' +I18n.enforce_available_locales = false + RSpec.configure do |config| config.filter_run :focus => ...
Set I18n.enforce_available_locales = false when running specs.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -3,7 +3,7 @@ SimpleCov.formatter = Coveralls::SimpleCov::Formatter SimpleCov.start do - add_filter 'lib' + add_filter 'spec' end require 'pry'
Add proper filter for coveralls, use spec not lib
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -14,6 +14,7 @@ source.filename =~ /lib\/agharta\/notifies/ || source.filename =~ /lib\/agharta\/stores/ end + add_group 'Extension', 'lib/agharta/core_ext'...
Add extension group at simplecov.
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,17 +2,15 @@ require 'rubygems' gem 'dm-core', '0.10.0' -gem 'randexp', '~>0.1.4' - require 'dm-core' -ROOT = Pathname(__FILE__).dirname.parent.expand_path +ROOT = Pathname...
[dm-more] Remove rubygems usage from libraries * No longer require dm-core inside the plugins. Expected usage is to require dm-core prior to requiring the plugin. * Updated pathname creation to using Pathname#/ where possible
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -4,8 +4,9 @@ # loaded once. # # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration + RSpec.configure do |config| - config.treat_symbols_as_metadata_keys_with_true...
Update spec helper to get angry if you aren't using rspec 3 syntax
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,6 +2,7 @@ require 'chefspec/berkshelf' RSpec.configure do |config| - config.color = true - config.log_level = :error + config.color = true # Use color in STD...
Use doc output in our specs Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/spec/support/vcr.rb b/spec/support/vcr.rb index abc1234..def5678 100644 --- a/spec/support/vcr.rb +++ b/spec/support/vcr.rb @@ -0,0 +1,13 @@+# VCR config +require 'vcr' + +VCR.configure do |c| + c.configure_rspec_metadata! + c.hook_into :faraday + c.default_cassette_options = { + record: ENV['TRAVI...
Move VCR to spec support
diff --git a/config/initializers/rabl_init.rb b/config/initializers/rabl_init.rb index abc1234..def5678 100644 --- a/config/initializers/rabl_init.rb +++ b/config/initializers/rabl_init.rb @@ -1,4 +1,5 @@ Rabl.configure do |config| + config.json_engine = Oj config.cache_all_output = false config.cache_sou...
Make sure Rabl is using Oj
diff --git a/devtools.gemspec b/devtools.gemspec index abc1234..def5678 100644 --- a/devtools.gemspec +++ b/devtools.gemspec @@ -14,6 +14,6 @@ gem.test_files = `git ls-files -- spec`.split("\n") gem.extra_rdoc_files = %w[TODO] - gem.add_dependency('rake', '~> 10.0') - gem.add_dependency('adamantium...
Update gem dependencies in gemspec
diff --git a/ci_environment/php/recipes/extensions.rb b/ci_environment/php/recipes/extensions.rb index abc1234..def5678 100644 --- a/ci_environment/php/recipes/extensions.rb +++ b/ci_environment/php/recipes/extensions.rb @@ -18,7 +18,7 @@ node['php']['multi']['versions'].each do |php_version| bash "disable preinst...
Replace `owner` with `user` in bash resource
diff --git a/jekyll-redirect-from.gemspec b/jekyll-redirect-from.gemspec index abc1234..def5678 100644 --- a/jekyll-redirect-from.gemspec +++ b/jekyll-redirect-from.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_runtime_dependen...
Add support for Jekyll 3.
diff --git a/Casks/picturelife.rb b/Casks/picturelife.rb index abc1234..def5678 100644 --- a/Casks/picturelife.rb +++ b/Casks/picturelife.rb @@ -4,7 +4,7 @@ url 'https://www.streamnation.com/uploader/osx/picturelife/Picturelife.dmg' name 'Picturelife Smartloader' - homepage 'http://picturelife.com' + homepage ...
Fix homepage to use SSL in Picturelife Smartloader Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/Casks/vlc-nightly.rb b/Casks/vlc-nightly.rb index abc1234..def5678 100644 --- a/Casks/vlc-nightly.rb +++ b/Casks/vlc-nightly.rb @@ -0,0 +1,9 @@+class VlcNightly < Cask + version 'latest' + sha256 :no_check + + url 'http://nightlies.videolan.org/build/macosx-intel/last' + homepage 'http://www.videolan.o...
Add VLC.app 3.0.0-git (nightly build)
diff --git a/iOS-FakeWeb.podspec b/iOS-FakeWeb.podspec index abc1234..def5678 100644 --- a/iOS-FakeWeb.podspec +++ b/iOS-FakeWeb.podspec @@ -0,0 +1,24 @@+Pod::Spec.new do |s| + s.name = "iOS-FakeWeb" + s.version = "0.1.1" + s.summary = "Simple HTTP request mocking/interception for testing module." ...
Add podspec for development version
diff --git a/app/controllers/resources_controller.rb b/app/controllers/resources_controller.rb index abc1234..def5678 100644 --- a/app/controllers/resources_controller.rb +++ b/app/controllers/resources_controller.rb @@ -52,8 +52,7 @@ def resource_params params.require(:resource).permit(:title, :url, :desc...
Remove course params from resource controller.
diff --git a/app/formatters/description_formatter.rb b/app/formatters/description_formatter.rb index abc1234..def5678 100644 --- a/app/formatters/description_formatter.rb +++ b/app/formatters/description_formatter.rb @@ -11,7 +11,7 @@ str.gsub!("!O!", "&deg;") str.gsub!("!>=!", "&ge;") str.gsub!("!<=!", "...
Convert to ampersand only if it is before whitespace.
diff --git a/config/initializers/browse_everything.rb b/config/initializers/browse_everything.rb index abc1234..def5678 100644 --- a/config/initializers/browse_everything.rb +++ b/config/initializers/browse_everything.rb @@ -1,14 +1,15 @@ Rails.application.config.to_prepare do - settings = if Settings.dropbox.google_d...
Allow google drive to be enabled along with either s3 or filesystem
diff --git a/app/services/releases/create_service.rb b/app/services/releases/create_service.rb index abc1234..def5678 100644 --- a/app/services/releases/create_service.rb +++ b/app/services/releases/create_service.rb @@ -8,24 +8,30 @@ return error('Access Denied', 403) unless allowed? return error('Release...
Resolve a Cognitive Complexity of 12
diff --git a/templates/refinery/installer.rb b/templates/refinery/installer.rb index abc1234..def5678 100644 --- a/templates/refinery/installer.rb +++ b/templates/refinery/installer.rb @@ -1,5 +1,5 @@ require 'rbconfig' -VERSION_BAND = '2.0.2' +VERSION_BAND = '2.0.0' # We want to ensure that you have an ExecJS runti...
Set VERSION_BAND back to 2.0.0 otherwise install fails because e.g. refinerycms-i18n has no version 2.0.2 available.