diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/bamboo-client.rb b/lib/bamboo-client.rb index abc1234..def5678 100644 --- a/lib/bamboo-client.rb +++ b/lib/bamboo-client.rb @@ -1,5 +1,6 @@ require "uri" require "restclient" +require "time" require "bamboo-client/version" require "bamboo-client/http"
Make sure 'time' is required.
diff --git a/lib/magnum/client.rb b/lib/magnum/client.rb index abc1234..def5678 100644 --- a/lib/magnum/client.rb +++ b/lib/magnum/client.rb @@ -20,5 +20,20 @@ @api_key = api_key @debug = false end + + # Send commit payload data to magnum + # + # @param [String] project API token + # @para...
Add method to send payload to api
diff --git a/lib/metadata_sync.rb b/lib/metadata_sync.rb index abc1234..def5678 100644 --- a/lib/metadata_sync.rb +++ b/lib/metadata_sync.rb @@ -19,7 +19,7 @@ logger.debug "Denormalised metadata, saving publication" success = publication.save if success - logger.into "Updated metadata...
Fix another of craig's typos ;-)
diff --git a/config/initializers/rollbar.rb b/config/initializers/rollbar.rb index abc1234..def5678 100644 --- a/config/initializers/rollbar.rb +++ b/config/initializers/rollbar.rb @@ -4,13 +4,4 @@ config.access_token = ENV['ROLLBAR_ACCESS_TOKEN'] config.enabled = false unless Rails.env.production? config.envir...
Disable Rollbaar JavaScript catch feature
diff --git a/config/initializers/sidekiq.rb b/config/initializers/sidekiq.rb index abc1234..def5678 100644 --- a/config/initializers/sidekiq.rb +++ b/config/initializers/sidekiq.rb @@ -1,9 +1,14 @@ require "sidekiq/throttled" Sidekiq::Throttled.setup! -if ENV["REDISCLOUD_URL"] +# The app could be provisioned with Re...
Allow Heroku Redis resource as well
diff --git a/lib/sprig/helpers.rb b/lib/sprig/helpers.rb index abc1234..def5678 100644 --- a/lib/sprig/helpers.rb +++ b/lib/sprig/helpers.rb @@ -2,10 +2,6 @@ module Helpers def seed_directory Sprig.configuration.directory - end - - def sprig_environment - Rails.env #TODO: make customizable ...
Remove unused helper method and todo Will add todo as an issue in the repo
diff --git a/lib/tasks/specs.rake b/lib/tasks/specs.rake index abc1234..def5678 100644 --- a/lib/tasks/specs.rake +++ b/lib/tasks/specs.rake @@ -19,6 +19,7 @@ engine_name = engine_name_for_engine(engine_path) namespace engine_name do + desc "Run RSpec tests for engine \"#{engine_name}\"" ...
Add description for Rake tasks
diff --git a/recipes/client.rb b/recipes/client.rb index abc1234..def5678 100644 --- a/recipes/client.rb +++ b/recipes/client.rb @@ -18,13 +18,6 @@ # limitations under the License. # -if node['platform_version'].to_f == 6.1 - windows_feature 'NetFx3' do - action :install - install_method :windows_feature_powe...
Remove .NET 3 installation on win2k8 No need for this anymore Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/Casks/unity.rb b/Casks/unity.rb index abc1234..def5678 100644 --- a/Casks/unity.rb +++ b/Casks/unity.rb @@ -1,6 +1,6 @@ cask :v1 => 'unity' do - version '4.6.0' - sha256 'ceeff727f8e66ebe00bd805468da27aa996bfcd5b3a455fe65516d9a2075a395' + version '4.6.1' + sha256 '3db6871de79794e272f64ae22c99ada0d481b5...
Upgrade Unity to version 4.6.1
diff --git a/lib/generators/styleguide/install/install_generator.rb b/lib/generators/styleguide/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/styleguide/install/install_generator.rb +++ b/lib/generators/styleguide/install/install_generator.rb @@ -10,7 +10,7 @@ end def cr...
Use get instead of match to be compatible with Rails 4
diff --git a/ruby_life.gemspec b/ruby_life.gemspec index abc1234..def5678 100644 --- a/ruby_life.gemspec +++ b/ruby_life.gemspec @@ -3,22 +3,22 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) require 'ruby_life/version' -Gem::Specification.new do |spec| - spec.name = "ruby_life" - spec.version ...
Change block variable name in gemspec
diff --git a/app/helpers/component_helper.rb b/app/helpers/component_helper.rb index abc1234..def5678 100644 --- a/app/helpers/component_helper.rb +++ b/app/helpers/component_helper.rb @@ -11,15 +11,15 @@ end if policy(ApiUser).index? - items << { text: 'APIs', href: api_users_path, active: is_cur...
Fix bug in highlighting the active menu item
diff --git a/lita-excuses.gemspec b/lita-excuses.gemspec index abc1234..def5678 100644 --- a/lita-excuses.gemspec +++ b/lita-excuses.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |spec| spec.name = "lita-excuses" - spec.version = "0.0.5" + spec.version = "0.0.6" spec.authors = ["M...
Update gemspec for Lita 3.0 compatibility.
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -1,6 +1,6 @@ case node['platform'] when 'debian', 'ubuntu' - default['augeas']['packages'] = %w(libaugeas-dev ruby1.9.1-dev libxml2-dev pkg-config) + default['augeas']['...
Remove packages not needed with omnibus chef
diff --git a/app/models/etsource/scenario.rb b/app/models/etsource/scenario.rb index abc1234..def5678 100644 --- a/app/models/etsource/scenario.rb +++ b/app/models/etsource/scenario.rb @@ -8,7 +8,7 @@ base_dir = "#{@etsource.export_dir}/presets" presets = [] - Dir.glob("#{base_dir}/*.yml").each do |...
Load presets recursively from subfolders Adjusted loading of presets such that presets can be organized in subfolders
diff --git a/app/models/project/pull_repo.rb b/app/models/project/pull_repo.rb index abc1234..def5678 100644 --- a/app/models/project/pull_repo.rb +++ b/app/models/project/pull_repo.rb @@ -18,7 +18,8 @@ end def self.perform_async project_id - update_column :pull_in_progress, true + project = Projec...
Fix bug with pull in progress
diff --git a/docker/base/dockerfile_spec.rb b/docker/base/dockerfile_spec.rb index abc1234..def5678 100644 --- a/docker/base/dockerfile_spec.rb +++ b/docker/base/dockerfile_spec.rb @@ -18,6 +18,7 @@ expect(package("python")).to be_installed end + def os_version command("lsb_release -a").stdout end
Make change to test trigger
diff --git a/spec/eval_spec.rb b/spec/eval_spec.rb index abc1234..def5678 100644 --- a/spec/eval_spec.rb +++ b/spec/eval_spec.rb @@ -10,35 +10,33 @@ expect(Lasp::execute("(+ 1 (+ 2 2))")).to eq 5 end - describe "special forms" do - it "def defines values in the environment" do - Lasp::execut...
Remove extra describe block in test
diff --git a/spec/find_spec.rb b/spec/find_spec.rb index abc1234..def5678 100644 --- a/spec/find_spec.rb +++ b/spec/find_spec.rb @@ -8,7 +8,8 @@ sims = simctl.usable_simulators os_names = sims.map(&:os_name).uniq.sort - expect(sims.count).to eq 15 + # This check is silly, but I am too lazy to c...
Add Travis sim count as alternative
diff --git a/spec/team_spec.rb b/spec/team_spec.rb index abc1234..def5678 100644 --- a/spec/team_spec.rb +++ b/spec/team_spec.rb @@ -29,4 +29,13 @@ expect(t.player_count).to eql 2 end end + describe 'Team#add_player' do + it "Should throw an error if player is already added." do + t = Team.new 'Devils' + + ...
Add should throw an error if player is already added.
diff --git a/split-api.gemspec b/split-api.gemspec index abc1234..def5678 100644 --- a/split-api.gemspec +++ b/split-api.gemspec @@ -21,6 +21,6 @@ gem.add_development_dependency 'bundler', '~> 1.0' gem.add_development_dependency 'rspec', '~> 2.6.0' - gem.add_development_dependency 'rack-test', '~> 0...
Update rack-test requirement from ~> 0.6 to ~> 1.1 Updates the requirements on [rack-test](https://github.com/rack-test/rack-test) to permit the latest version. - [Release notes](https://github.com/rack-test/rack-test/releases) - [Changelog](https://github.com/rack-test/rack-test/blob/master/History.md) - [Commits](ht...
diff --git a/lib/abyss-navigation-rails.rb b/lib/abyss-navigation-rails.rb index abc1234..def5678 100644 --- a/lib/abyss-navigation-rails.rb +++ b/lib/abyss-navigation-rails.rb @@ -1 +1,3 @@+$:.unshift(File.expand_path('..', __FILE__)) unless $:.include? File.expand_path('..', __FILE__) + require "abyss/navigation"
Add the lib directory to the load path
diff --git a/lib/app/helpers/esi_helper.rb b/lib/app/helpers/esi_helper.rb index abc1234..def5678 100644 --- a/lib/app/helpers/esi_helper.rb +++ b/lib/app/helpers/esi_helper.rb @@ -11,7 +11,7 @@ env = ENV['RAILS_ENV'] # If we were passed a url... - if resource =~ /^(http:\/\/)?[a-zA-Z0-9\-\.]+\.(com...
Fix a bug where url is not recognized.
diff --git a/cama_meta_tag.gemspec b/cama_meta_tag.gemspec index abc1234..def5678 100644 --- a/cama_meta_tag.gemspec +++ b/cama_meta_tag.gemspec @@ -9,7 +9,7 @@ s.version = CamaMetaTag::VERSION s.authors = ["Owen Peredo"] s.email = ["owenperedo@gmail.com"] - s.homepage = "" + s.homepage = ...
Add repo url to gemspec
diff --git a/lib/compath/yaml_formatter.rb b/lib/compath/yaml_formatter.rb index abc1234..def5678 100644 --- a/lib/compath/yaml_formatter.rb +++ b/lib/compath/yaml_formatter.rb @@ -31,7 +31,7 @@ lambda do |yaml| lines = yaml.lines.map do |line| if m = QUOTED_KEY_REGEXP.match(line) - ...
Remove trailing space from a filter generated line
diff --git a/lib/hn_history/jobs/photos.rb b/lib/hn_history/jobs/photos.rb index abc1234..def5678 100644 --- a/lib/hn_history/jobs/photos.rb +++ b/lib/hn_history/jobs/photos.rb @@ -1,27 +1,35 @@ module HnHistory - Clockwork.every(5.minutes, 'photos.new') do - current_time = Time.now.utc + module Jobs + class <<...
Call method for job, easier to debug
diff --git a/lib/loga/revision_strategy.rb b/lib/loga/revision_strategy.rb index abc1234..def5678 100644 --- a/lib/loga/revision_strategy.rb +++ b/lib/loga/revision_strategy.rb @@ -1,4 +1,6 @@ # rubocop:disable Style/SpecialGlobalVars +require 'active_support/core_ext/object/blank' + module Loga class RevisionStrat...
Use .blank? instead of .empty?
diff --git a/lib/spinning_cursor/parser.rb b/lib/spinning_cursor/parser.rb index abc1234..def5678 100644 --- a/lib/spinning_cursor/parser.rb +++ b/lib/spinning_cursor/parser.rb @@ -24,7 +24,7 @@ # Getter and setter for the action block # def action(&block) - @action = block unless block.nil? + @...
Remove unecessary 'nil?' test on 'block'
diff --git a/lita-send_with_option.gemspec b/lita-send_with_option.gemspec index abc1234..def5678 100644 --- a/lita-send_with_option.gemspec +++ b/lita-send_with_option.gemspec @@ -3,9 +3,9 @@ spec.version = "0.0.1" spec.authors = ["Shu Sugimoto"] spec.email = ["shu@su.gimo.to"] - spec.desc...
Resolve bundler warnings in gemspec file
diff --git a/graphql-client.gemspec b/graphql-client.gemspec index abc1234..def5678 100644 --- a/graphql-client.gemspec +++ b/graphql-client.gemspec @@ -13,6 +13,8 @@ s.add_dependency "graphql", "~> 1.2" s.add_development_dependency "actionpack", ">= 3.2.22", "< 6.0" + s.add_development_dependency "erubi", "~> ...
Add erubi as development dependency
diff --git a/graphql-client.gemspec b/graphql-client.gemspec index abc1234..def5678 100644 --- a/graphql-client.gemspec +++ b/graphql-client.gemspec @@ -8,11 +8,10 @@ s.files = Dir["README.md", "LICENSE", "lib/**/*.rb"] - # TODO: Make Rails dependencies optional - s.add_dependency "actionpack", ">= 3.0", "< 6.0...
Make action pack dependency optional
diff --git a/rom-http.gemspec b/rom-http.gemspec index abc1234..def5678 100644 --- a/rom-http.gemspec +++ b/rom-http.gemspec @@ -18,7 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ['lib'] - spec.add_runtime_dependency 'rom', '~> 0.8', '>= 0.8.0' + spec.add_runti...
Update rom dependency to 0.9.0.beta1
diff --git a/spec/nark/plugin_spec.rb b/spec/nark/plugin_spec.rb index abc1234..def5678 100644 --- a/spec/nark/plugin_spec.rb +++ b/spec/nark/plugin_spec.rb @@ -15,8 +15,6 @@ it "should not include instance_methods" do Nark.available_plugins.should_not include 'instance_methods' end - - it "provides ...
Remove pending spec, we'll deal with that later
diff --git a/spec/unit/errors_spec.rb b/spec/unit/errors_spec.rb index abc1234..def5678 100644 --- a/spec/unit/errors_spec.rb +++ b/spec/unit/errors_spec.rb @@ -0,0 +1,49 @@+ +# +# specifying flor +# +# Sun Feb 5 19:48:17 JST 2017 +# + +require 'spec_helper' + + +describe 'Flor unit' do + + before :each do + + @un...
Add unit vs error spec (prep put_execution rework)
diff --git a/sanguine.gemspec b/sanguine.gemspec index abc1234..def5678 100644 --- a/sanguine.gemspec +++ b/sanguine.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |spec| spec.name = "sanguine" - spec.version = "1.1.2" + spec.version = "1.1.3" spec.authors = ["Austen Madden"] ...
Update minor version again because shennanigans
diff --git a/spec/app_spec.rb b/spec/app_spec.rb index abc1234..def5678 100644 --- a/spec/app_spec.rb +++ b/spec/app_spec.rb @@ -27,7 +27,11 @@ context "good args" do it "spits out a buzzfeedish title vaguely related to the PR" do post '/command', text: good_url - ap JSON.parse(last_r...
Fix bad parse output in a spec
diff --git a/lib/fog/hp/requests/cdn/head_container.rb b/lib/fog/hp/requests/cdn/head_container.rb index abc1234..def5678 100644 --- a/lib/fog/hp/requests/cdn/head_container.rb +++ b/lib/fog/hp/requests/cdn/head_container.rb @@ -11,12 +11,10 @@ # ==== Returns # * response<~Excon::Response>: # ...
Update inline docs as per real responses.
diff --git a/guard-test.gemspec b/guard-test.gemspec index abc1234..def5678 100644 --- a/guard-test.gemspec +++ b/guard-test.gemspec @@ -15,7 +15,7 @@ s.required_ruby_version = '>= 1.9.2' - s.add_runtime_dependency 'guard', '>= 2.0.0.pre.3' + s.add_runtime_dependency 'guard', '~> 2.0' s.add_runtime_d...
Update Guard dependency to ~> 2.0
diff --git a/worker/lib/Job/job.rb b/worker/lib/Job/job.rb index abc1234..def5678 100644 --- a/worker/lib/Job/job.rb +++ b/worker/lib/Job/job.rb @@ -2,11 +2,9 @@ # Licence:: See Licence.rdoc module Job - class Job - @project_name - @povray_arguments - @povray_scene_file_name - @partial_image_file_name +...
Use Attr_accessor for attributes in Job class
diff --git a/jquery-cdn.gemspec b/jquery-cdn.gemspec index abc1234..def5678 100644 --- a/jquery-cdn.gemspec +++ b/jquery-cdn.gemspec @@ -1,4 +1,4 @@-require_relative 'lib/jquery-cdn/version' +require File.expand_path('../lib/jquery-cdn/version', __FILE__) Gem::Specification.new do |s| s.platform = Gem::Platfor...
Fix require for old Ruby
diff --git a/lib/api/routes/core.rb b/lib/api/routes/core.rb index abc1234..def5678 100644 --- a/lib/api/routes/core.rb +++ b/lib/api/routes/core.rb @@ -5,6 +5,20 @@ configure do set :root, ExercismAPI::ROOT + enable :raise_errors + end + + configure :production do + disable :sh...
Add bugsnag to API side of things
diff --git a/lib/deep_cover/node.rb b/lib/deep_cover/node.rb index abc1234..def5678 100644 --- a/lib/deep_cover/node.rb +++ b/lib/deep_cover/node.rb @@ -1,6 +1,11 @@ module DeepCover - class Node + class Node # Reopened in base + CLASSES = [] + def self.inherited(parent) + CLASSES << parent + su...
Build list of all Node subclasses
diff --git a/kittenizer.gemspec b/kittenizer.gemspec index abc1234..def5678 100644 --- a/kittenizer.gemspec +++ b/kittenizer.gemspec @@ -19,6 +19,6 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", ">= 1.8" - spec.add_development_dependency "rake", "~> 12.3" + spec.add_development_depe...
Update rake requirement from ~> 12.3 to ~> 13.0 Updates the requirements on [rake](https://github.com/ruby/rake) to permit the latest version. - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](https://github.com/ruby/rake/compare/v...
diff --git a/lib/simctl/executor.rb b/lib/simctl/executor.rb index abc1234..def5678 100644 --- a/lib/simctl/executor.rb +++ b/lib/simctl/executor.rb @@ -9,7 +9,10 @@ $stderr.puts command if ENV['SIMCTL_DEBUG'] Open3.popen3(command) do |stdin, stdout, stderr, result| output = stdout.read - ...
Read stderr if stdout was empty and exit_code != 0
diff --git a/lib/sub_diff/differ.rb b/lib/sub_diff/differ.rb index abc1234..def5678 100644 --- a/lib/sub_diff/differ.rb +++ b/lib/sub_diff/differ.rb @@ -1,6 +1,6 @@ module SubDiff class Differ < Struct.new(:diff_collection, :diff_method) - Match = Struct.new(:match, :prefix, :suffix, :replacement) do + class M...
Make Match a class instead of a Struct
diff --git a/lib/tubesock/hijack.rb b/lib/tubesock/hijack.rb index abc1234..def5678 100644 --- a/lib/tubesock/hijack.rb +++ b/lib/tubesock/hijack.rb @@ -27,7 +27,7 @@ included do def hijack - sock = Tubesock.hijack(env) + sock = Tubesock.hijack(request.env) yield sock sock.onclose do ...
Fix `env` deprecated in Rails 5.0 `env` is deprecated in Ralis 5.0 and removed in 5.1, this updates the code to use `request.env` instead: https://github.com/rails/rails/issues/23294
diff --git a/lib/gitlab/util.rb b/lib/gitlab/util.rb index abc1234..def5678 100644 --- a/lib/gitlab/util.rb +++ b/lib/gitlab/util.rb @@ -12,6 +12,27 @@ def set_env_if_missing(key, value) ENV[key] ||= value&.strip end + + def section(name, description = name, &block) + section_start(nam...
Add section, section_start and section_end helpers
diff --git a/lib/gitlab/util.rb b/lib/gitlab/util.rb index abc1234..def5678 100644 --- a/lib/gitlab/util.rb +++ b/lib/gitlab/util.rb @@ -0,0 +1,17 @@+module Gitlab + class Util + class << self + def get_env(key) + ENV[key]&.strip + end + + def set_env(key, value) + ENV[key] = value&.str...
Add helper method for stripping whitespace off env variables
diff --git a/lib/padrino-rpm.rb b/lib/padrino-rpm.rb index abc1234..def5678 100644 --- a/lib/padrino-rpm.rb +++ b/lib/padrino-rpm.rb @@ -32,8 +32,9 @@ end Padrino.before_load do + require 'new_relic/rack_app' + if Padrino.env == :development - require 'new_relic/rack_app' Padrino.use NewRelic::Rack::Deve...
Load newrelic/rack_app in all environments
diff --git a/rs-api-tools.gemspec b/rs-api-tools.gemspec index abc1234..def5678 100644 --- a/rs-api-tools.gemspec +++ b/rs-api-tools.gemspec @@ -10,8 +10,8 @@ s.files = Dir['lib/*.rb'] s.bindir = 'bin' s.executables = Dir.entries(s.bindir) - [".", "..", '.gitignore'] - s.homepage = - 'https:/...
Add activesupport to gemspec as a dep.
diff --git a/ruby/arrays_drill.rb b/ruby/arrays_drill.rb index abc1234..def5678 100644 --- a/ruby/arrays_drill.rb +++ b/ruby/arrays_drill.rb @@ -0,0 +1,22 @@+def inventory(arr) + return arr +end + + +store = [] + +store << "candy" << "gum" << "chips" << "soda" << "ice" + +store.delete_at(2) + +store.insert(2, "burrito...
Create method to return array
diff --git a/lxc-server.gemspec b/lxc-server.gemspec index abc1234..def5678 100644 --- a/lxc-server.gemspec +++ b/lxc-server.gemspec @@ -12,6 +12,7 @@ s.add_development_dependency 'rake' s.add_development_dependency 'rspec', '~> 2.11' s.add_development_dependency 'simplecov', '~> 0.4' + s.add_development_d...
Add rack-test dependency for tests
diff --git a/DSAWSOperations.podspec b/DSAWSOperations.podspec index abc1234..def5678 100644 --- a/DSAWSOperations.podspec +++ b/DSAWSOperations.podspec @@ -0,0 +1,17 @@+Pod::Spec.new do |s| + s.name = "DSAWSOperations" + s.version = "0.5" + s.summary = "Small framework to make the AWS IOS SDK less...
Add first cut of pod spec.
diff --git a/spec/services/ci/send_pipeline_notification_service_spec.rb b/spec/services/ci/send_pipeline_notification_service_spec.rb index abc1234..def5678 100644 --- a/spec/services/ci/send_pipeline_notification_service_spec.rb +++ b/spec/services/ci/send_pipeline_notification_service_spec.rb @@ -1,8 +1,12 @@ requir...
Fix the other missing commit
diff --git a/lib/sparkle_motion/hue/ssdp.rb b/lib/sparkle_motion/hue/ssdp.rb index abc1234..def5678 100644 --- a/lib/sparkle_motion/hue/ssdp.rb +++ b/lib/sparkle_motion/hue/ssdp.rb @@ -7,7 +7,7 @@ class SSDP def scan raw = Frisky::SSDP - .search("IpBridge") + .search("IpBri...
Add a longer TTL to facilitate bridges being slow during discovery.
diff --git a/test/html_test.rb b/test/html_test.rb index abc1234..def5678 100644 --- a/test/html_test.rb +++ b/test/html_test.rb @@ -1,8 +1,9 @@ require 'test_helper' -DocTest.examples_path = ['test/examples/html', 'test/examples/asciidoc-html'] +DocTest.examples_path.unshift 'test/examples/html', 'test/examples/asci...
Enable using default tests for html conversion This includes a fix to the default xpath used to select the generated inline output. Because asciidoctor-doctest development in branch dev is mostly incompatible with the latex branch now, I'm not submitting this upstream. We should rebase asap.
diff --git a/test/note_test.rb b/test/note_test.rb index abc1234..def5678 100644 --- a/test/note_test.rb +++ b/test/note_test.rb @@ -8,7 +8,9 @@ @total_frames = (@duration * @sample_rate).to_i @cycles_per_frame = @frequency / @sample_rate @sine_wave_cycle = 2 * Math::PI * @cycles_per_frame + @samples =...
Add test for distort! and private helper methods
diff --git a/pakyow-core/lib/core/middleware/static.rb b/pakyow-core/lib/core/middleware/static.rb index abc1234..def5678 100644 --- a/pakyow-core/lib/core/middleware/static.rb +++ b/pakyow-core/lib/core/middleware/static.rb @@ -10,7 +10,7 @@ response = Rack::Response.new catch(:halt) d...
Change `send_file!` reference to `send` in Static middleware
diff --git a/config/initializers/csp.rb b/config/initializers/csp.rb index abc1234..def5678 100644 --- a/config/initializers/csp.rb +++ b/config/initializers/csp.rb @@ -3,11 +3,10 @@ report_only: Rails.env.production?, # default: false preserve_schemes: true, # default: false. - default_src: %...
Add 'data:' and other missing domains to SecureHeaders
diff --git a/recipes/database_mysql.rb b/recipes/database_mysql.rb index abc1234..def5678 100644 --- a/recipes/database_mysql.rb +++ b/recipes/database_mysql.rb @@ -26,6 +26,8 @@ ## Create the GitLab database & grant all privileges on database gitlab['environments'].each do |environment| mysql_database "gitlabhq_#{...
Add encoding and collation to the db creation.
diff --git a/app/controllers/active_storage/representations_controller.rb b/app/controllers/active_storage/representations_controller.rb index abc1234..def5678 100644 --- a/app/controllers/active_storage/representations_controller.rb +++ b/app/controllers/active_storage/representations_controller.rb @@ -8,11 +8,23 @@ ...
Return webp if browser supports it
diff --git a/refinerycms-forms.gemspec b/refinerycms-forms.gemspec index abc1234..def5678 100644 --- a/refinerycms-forms.gemspec +++ b/refinerycms-forms.gemspec @@ -1,7 +1,7 @@ Gem::Specification.new do |s| s.platform = Gem::Platform::RUBY s.name = "refinerycms-forms" - s.version = "2.0.1"...
Revert version change (2.0.0 not released yet)
diff --git a/spec/lib/vault/rails/json_serializer_spec.rb b/spec/lib/vault/rails/json_serializer_spec.rb index abc1234..def5678 100644 --- a/spec/lib/vault/rails/json_serializer_spec.rb +++ b/spec/lib/vault/rails/json_serializer_spec.rb @@ -34,7 +34,7 @@ it { is_expected.to eq(nil) } end - context "with...
Clarify test for deserializing an empty string
diff --git a/tests/run_ruby.rb b/tests/run_ruby.rb index abc1234..def5678 100644 --- a/tests/run_ruby.rb +++ b/tests/run_ruby.rb @@ -1,3 +1,4 @@+# NOTE: Requires `gem install http` require 'http' r = HTTP.post("http://localhost:8000/tag", :body => "Fördomen har alltid sin rot i vardagslivet - Olof Palme") puts r.to_...
Add note on how to install test dependency.
diff --git a/db/migrate/20170330080918_associate_datasets_with_commits.rb b/db/migrate/20170330080918_associate_datasets_with_commits.rb index abc1234..def5678 100644 --- a/db/migrate/20170330080918_associate_datasets_with_commits.rb +++ b/db/migrate/20170330080918_associate_datasets_with_commits.rb @@ -3,9 +3,10 @@ ...
Fix migration for dataset commmits
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index abc1234..def5678 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -13,7 +13,7 @@ RSpec.configure do |config| config.infer_spec_type_from_file_location! - config.include Devise::TestHelpers, type: :controller + config.include Devise::Te...
Remove deprication warning around Devise::TestHelpers
diff --git a/omf_common/test/logger_spec.rb b/omf_common/test/logger_spec.rb index abc1234..def5678 100644 --- a/omf_common/test/logger_spec.rb +++ b/omf_common/test/logger_spec.rb @@ -5,9 +5,10 @@ describe OmfCommon::Logger do describe "when used to log message" do it "must print a proper log message" do - ...
Use capture_io instead of must_output in minitest
diff --git a/rack-syntax-highlighter.gemspec b/rack-syntax-highlighter.gemspec index abc1234..def5678 100644 --- a/rack-syntax-highlighter.gemspec +++ b/rack-syntax-highlighter.gemspec @@ -4,7 +4,7 @@ Gem::Specification.new do |gem| gem.authors = ["Glenn Gillen"] gem.email = ["me@glenngillen.com"] -...
Add albino and pygmentize dependencies.
diff --git a/services/importer/lib/importer/ogrinfo.rb b/services/importer/lib/importer/ogrinfo.rb index abc1234..def5678 100644 --- a/services/importer/lib/importer/ogrinfo.rb +++ b/services/importer/lib/importer/ogrinfo.rb @@ -35,7 +35,7 @@ def run if !@executed stdout, stderr, status = Open...
Make it resilient to encoding issues
diff --git a/docs/config/deploy.rb b/docs/config/deploy.rb index abc1234..def5678 100644 --- a/docs/config/deploy.rb +++ b/docs/config/deploy.rb @@ -13,7 +13,10 @@ set :scm, :git -server '166.78.3.108', :web +foundation1_ip = '166.78.3.108' +foundation2_ip = '166.78.18.29' + +role :web, foundation1_ip, foundation2_...
Deploy to both foundation servers
diff --git a/test/unit/connection_test.rb b/test/unit/connection_test.rb index abc1234..def5678 100644 --- a/test/unit/connection_test.rb +++ b/test/unit/connection_test.rb @@ -0,0 +1,21 @@+require File.expand_path("../../test_helper", __FILE__) + +include RedmineS3 + +class ConfigurationTest < ActiveSupport::TestCase ...
Add rudimentary AWS client test It current mysteriously fails sometimes v_v
diff --git a/react-native-lookback.podspec b/react-native-lookback.podspec index abc1234..def5678 100644 --- a/react-native-lookback.podspec +++ b/react-native-lookback.podspec @@ -13,6 +13,7 @@ s.source = { git: package.dig(:repository, :url) } s.source_files = "ios/*" s.platform = :ios, "8.0" + s.frameworks ...
Add Lookback framework to the podspec
diff --git a/jasmine-selenium-runner.gemspec b/jasmine-selenium-runner.gemspec index abc1234..def5678 100644 --- a/jasmine-selenium-runner.gemspec +++ b/jasmine-selenium-runner.gemspec @@ -9,7 +9,7 @@ spec.authors = ["Rajan Agaskar", "Gregg Van Hove" ] spec.email = ["rajan@pivotallabs.com", 'gvanhove...
Make bundler happy by providing a summary - Silences warning
diff --git a/test/test_gem_install.rb b/test/test_gem_install.rb index abc1234..def5678 100644 --- a/test/test_gem_install.rb +++ b/test/test_gem_install.rb @@ -17,4 +17,11 @@ end assert_match(/GNU ed/, out) end + + def test_gem_install_nokogiri + RubyInstaller::Runtime.msys2_installation.with_msys_apps...
Add a test to gem install nokogiri
diff --git a/test/fixtures/cookbooks/test/recipes/repo.rb b/test/fixtures/cookbooks/test/recipes/repo.rb index abc1234..def5678 100644 --- a/test/fixtures/cookbooks/test/recipes/repo.rb +++ b/test/fixtures/cookbooks/test/recipes/repo.rb @@ -26,6 +26,7 @@ support_email_address "#{node['chef_admin']}" EOS action :ins...
Fix failing tests due to lack of accept_license Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/zero_auth.gemspec b/zero_auth.gemspec index abc1234..def5678 100644 --- a/zero_auth.gemspec +++ b/zero_auth.gemspec @@ -17,7 +17,7 @@ spec.test_files = spec.files.grep(%r{^spec/}) spec.require_paths = ["lib"] - spec.add_development_dependency 'bcrypt', '~> 3.1.7' + spec.add_dependency 'bcrypt',...
Make BCrypt a real dependency [ci-skip]
diff --git a/lib/learn_web/client/user/me.rb b/lib/learn_web/client/user/me.rb index abc1234..def5678 100644 --- a/lib/learn_web/client/user/me.rb +++ b/lib/learn_web/client/user/me.rb @@ -24,13 +24,13 @@ case response.status when 401 puts "It seems your OAuth token is incorrect....
Add exit code so we can break out of the execution flow more easily
diff --git a/lib/rom/support/class_macros.rb b/lib/rom/support/class_macros.rb index abc1234..def5678 100644 --- a/lib/rom/support/class_macros.rb +++ b/lib/rom/support/class_macros.rb @@ -1,5 +1,31 @@ module ROM + # Internal support module for class-level settings + # + # @private module ClassMacros + # Speci...
Add YARD for ClassMacros support module
diff --git a/quickbooks_endpoint.rb b/quickbooks_endpoint.rb index abc1234..def5678 100644 --- a/quickbooks_endpoint.rb +++ b/quickbooks_endpoint.rb @@ -1,10 +1,11 @@ require "sinatra" require "endpoint_base" -# require "pry" require File.expand_path(File.dirname(__FILE__) + '/lib/qb_integration') class Quickboo...
Set endpoint_key on sinatra class
diff --git a/db/migrate/20170405133031_add_missing_indexes.rb b/db/migrate/20170405133031_add_missing_indexes.rb index abc1234..def5678 100644 --- a/db/migrate/20170405133031_add_missing_indexes.rb +++ b/db/migrate/20170405133031_add_missing_indexes.rb @@ -1,4 +1,10 @@-class AddMissingIndexes < ActiveRecord::Migration ...
Fix Directly inheriting from ActiveRecord::Migration is not supported
diff --git a/fernet.gemspec b/fernet.gemspec index abc1234..def5678 100644 --- a/fernet.gemspec +++ b/fernet.gemspec @@ -15,4 +15,5 @@ gem.add_runtime_dependency "valcro", "0.1" gem.add_development_dependency "rspec", "~> 3.4" + gem.add_development_dependency "rake", "~> 10.4" end
Add rake to dev dependencies
diff --git a/themes_for_rails.gemspec b/themes_for_rails.gemspec index abc1234..def5678 100644 --- a/themes_for_rails.gemspec +++ b/themes_for_rails.gemspec @@ -21,5 +21,4 @@ gem.add_development_dependency "test-unit" gem.add_development_dependency "contest" gem.add_development_dependency "mocha" - gem.add_dev...
Remove duplicate dependency on Rails to prevent RubyGems error. See https://github.com/rubygems/rubygems/blob/master/lib/rubygems/specification.rb#L2795
diff --git a/Casks/ridibooks.rb b/Casks/ridibooks.rb index abc1234..def5678 100644 --- a/Casks/ridibooks.rb +++ b/Casks/ridibooks.rb @@ -1,8 +1,9 @@ cask :v1 => 'ridibooks' do - version :latest - sha256 :no_check + version '1.5.9b' + sha256 '27e06ef0625f8958a909c7801bfd0108d975164fec9b241d1a12ab083edea2e0' - url...
Update Ridibooks to versioned url
diff --git a/lib/autoparts/packages/googleappenginego.rb b/lib/autoparts/packages/googleappenginego.rb index abc1234..def5678 100644 --- a/lib/autoparts/packages/googleappenginego.rb +++ b/lib/autoparts/packages/googleappenginego.rb @@ -2,12 +2,12 @@ module Packages class GoogleAppEngineGo < Package name ...
Update App Engine Go to 1.9.13
diff --git a/lib/awestruct/deploy/github_pages_deploy.rb b/lib/awestruct/deploy/github_pages_deploy.rb index abc1234..def5678 100644 --- a/lib/awestruct/deploy/github_pages_deploy.rb +++ b/lib/awestruct/deploy/github_pages_deploy.rb @@ -1,4 +1,5 @@ require 'awestruct/deployers' +require 'git' module Awestruct mod...
Fix uninitialized constant issue with git deploy
diff --git a/lib/designernews/helpers/story_formatter.rb b/lib/designernews/helpers/story_formatter.rb index abc1234..def5678 100644 --- a/lib/designernews/helpers/story_formatter.rb +++ b/lib/designernews/helpers/story_formatter.rb @@ -5,7 +5,19 @@ MAX_TWEET_LENGTH = 140 - SHORT_URL_LENGTH_HTTPS - WHITESPACE ...
Add badge hashtags to tweets
diff --git a/lib/fit_commit/validators/summary_period.rb b/lib/fit_commit/validators/summary_period.rb index abc1234..def5678 100644 --- a/lib/fit_commit/validators/summary_period.rb +++ b/lib/fit_commit/validators/summary_period.rb @@ -3,7 +3,7 @@ module FitCommit module Validators class SummaryPeriod < Base -...
Mark param as unused in SummaryPeriod validator
diff --git a/lib/rabbitmq/http/client/response_helper.rb b/lib/rabbitmq/http/client/response_helper.rb index abc1234..def5678 100644 --- a/lib/rabbitmq/http/client/response_helper.rb +++ b/lib/rabbitmq/http/client/response_helper.rb @@ -13,7 +13,7 @@ end def decode_resource(response) - if response...
Handle 204 responses with HTTP keepalive If the HTTP API is behind a proxy which has HTTP keepalive enabled, Faraday will assign a nil body on 204 responses.
diff --git a/lib/vagrant-notify/action/check_provider.rb b/lib/vagrant-notify/action/check_provider.rb index abc1234..def5678 100644 --- a/lib/vagrant-notify/action/check_provider.rb +++ b/lib/vagrant-notify/action/check_provider.rb @@ -0,0 +1,17 @@+module Vagrant + module Notify + module Action + class CheckP...
Add a placeholder action to check if machine provider is compatible with the plugin
diff --git a/lib/web_blocks/facade/registration_scope.rb b/lib/web_blocks/facade/registration_scope.rb index abc1234..def5678 100644 --- a/lib/web_blocks/facade/registration_scope.rb +++ b/lib/web_blocks/facade/registration_scope.rb @@ -6,17 +6,17 @@ def initialize context super context - @@comp...
Fix an issue with naming
diff --git a/app/models/spree/order_decorator.rb b/app/models/spree/order_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/order_decorator.rb +++ b/app/models/spree/order_decorator.rb @@ -18,7 +18,7 @@ Subscription.create( user: user, subscription_product: sp, ...
Use line item ship address to create the subscriptions
diff --git a/app/services/contributor_service.rb b/app/services/contributor_service.rb index abc1234..def5678 100644 --- a/app/services/contributor_service.rb +++ b/app/services/contributor_service.rb @@ -29,7 +29,7 @@ ) end - def self.send_contributor_notice_to email + def self.send_contributor_notice_to in...
Include proper params on contrib notice
diff --git a/ruby/luhn/luhn.rb b/ruby/luhn/luhn.rb index abc1234..def5678 100644 --- a/ruby/luhn/luhn.rb +++ b/ruby/luhn/luhn.rb @@ -1,18 +1,19 @@+# Luhn class Luhn - + attr_reader :num def initialize(num) @num = num end def addends - @num.to_s.chars.map(&:to_i) # digits - .reverse - ...
Refactor to use .odd? also style fixes
diff --git a/app/views/forums/index.atom.builder b/app/views/forums/index.atom.builder index abc1234..def5678 100644 --- a/app/views/forums/index.atom.builder +++ b/app/views/forums/index.atom.builder @@ -15,6 +15,7 @@ entry.author do |author| author.name(post.user.name) end + entry.category(...
Add category in forum feed. Signed-off-by: François de Metz <5187da0b934cc25eb2201a3ec9206c24b13cb23b@2metz.fr>
diff --git a/test/performance/raise_comparison_test.rb b/test/performance/raise_comparison_test.rb index abc1234..def5678 100644 --- a/test/performance/raise_comparison_test.rb +++ b/test/performance/raise_comparison_test.rb @@ -0,0 +1,103 @@+require "test_helper" +require "benchmark" + +class RaiseComparisonTest < Rem...
Add ugly performance comparison test
diff --git a/test/unit/edition/gov_uk_delivery_test.rb b/test/unit/edition/gov_uk_delivery_test.rb index abc1234..def5678 100644 --- a/test/unit/edition/gov_uk_delivery_test.rb +++ b/test/unit/edition/gov_uk_delivery_test.rb @@ -10,10 +10,8 @@ policy.first_published_at = Time.zone.now policy.major_change_publi...
Change unit test to just check for invocation
diff --git a/gibber.gemspec b/gibber.gemspec index abc1234..def5678 100644 --- a/gibber.gemspec +++ b/gibber.gemspec @@ -21,4 +21,5 @@ spec.add_development_dependency "bundler", "~> 1.7" spec.add_development_dependency "rake", "~> 10.0" spec.add_development_dependency "pry" + spec.add_development_dependency "m...
Add minitest to dev dependencies
diff --git a/gimlet.gemspec b/gimlet.gemspec index abc1234..def5678 100644 --- a/gimlet.gemspec +++ b/gimlet.gemspec @@ -20,6 +20,7 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_development_dependency "rspec" spec.add_dependency "thor" end
Add rspec as development dependency
diff --git a/ci_scripts/check_resource_bundle.rb b/ci_scripts/check_resource_bundle.rb index abc1234..def5678 100644 --- a/ci_scripts/check_resource_bundle.rb +++ b/ci_scripts/check_resource_bundle.rb @@ -10,6 +10,7 @@ require 'xcodeproj' contents_of_resources_dir = Dir.glob("Stripe/Resources/Images/*.png").map { |h...
Fix resource bundle test to allow Stripe3DS2.bundle
diff --git a/snmp.gemspec b/snmp.gemspec index abc1234..def5678 100644 --- a/snmp.gemspec +++ b/snmp.gemspec @@ -28,6 +28,7 @@ s.license = 'MIT' s.required_ruby_version = '>= 1.9.0' + s.add_development_dependency("rake") s.add_development_dependency("bundler") s.add_development_dependency("minit...
Add rake as dev depedency