diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/sauce-connect.rb b/sauce-connect.rb index abc1234..def5678 100644 --- a/sauce-connect.rb +++ b/sauce-connect.rb @@ -0,0 +1,17 @@+require "formula" + + +class SauceConnect < Formula + homepage "https://docs.saucelabs.com/reference/sauce-connect/" + url "https://saucelabs.com/downloads/sc-4.3.10-osx.zip" +...
Upgrade to Sauce Connect 4.3
diff --git a/spec/poole_spec.rb b/spec/poole_spec.rb index abc1234..def5678 100644 --- a/spec/poole_spec.rb +++ b/spec/poole_spec.rb @@ -10,11 +10,13 @@ context 'no jekyll directory' do before :all do # make a directory to work in + @olddir = Dir.pwd() @dir = Dir.mktmpdir('nojekyll')...
Fix to stupid bug in spec. I wasn't changing out of the directory in the old context before I removed it, so pwd was failing in the new context.
diff --git a/set_attributes.gemspec b/set_attributes.gemspec index abc1234..def5678 100644 --- a/set_attributes.gemspec +++ b/set_attributes.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'set_attributes' - s.version = '0.1.4' + s.version = '0.1.5' s.summary = "Set an ...
Package version is increased from 0.1.4 to 0.1.5
diff --git a/spec/math_spec.rb b/spec/math_spec.rb index abc1234..def5678 100644 --- a/spec/math_spec.rb +++ b/spec/math_spec.rb @@ -0,0 +1,13 @@+require File.expand_path(File.dirname(__FILE__) + '/spec_helper') + +describe Math do + + it 'should solve a quadratic formula' + it 'should get the number of permutations wi...
Add Math spec with a few pending tests
diff --git a/spec/support/models.rb b/spec/support/models.rb index abc1234..def5678 100644 --- a/spec/support/models.rb +++ b/spec/support/models.rb @@ -1,16 +1,13 @@ class Artist < ActiveRecord::Base - attr_accessible :name, :deceased has_many :albums has_many :songs, through: :albums end class Album < Acti...
Remove attr_accessible calls in test schema.
diff --git a/ignote.gemspec b/ignote.gemspec index abc1234..def5678 100644 --- a/ignote.gemspec +++ b/ignote.gemspec @@ -10,7 +10,7 @@ spec.email = ["tjstankus@gmail.com"] spec.summary = %q{Do stuff with kindle notes. } spec.description = %q{Do more descriptive stuff with kindle notes.} - spec....
Update gemspec to appease gem build
diff --git a/config/software/bogs.rb b/config/software/bogs.rb index abc1234..def5678 100644 --- a/config/software/bogs.rb +++ b/config/software/bogs.rb @@ -22,7 +22,7 @@ dependency 'setuptools' source git: 'https://github.com/bninja/bogs.git' -version 'master' +version 'v0.1.0' relative_path 'bogs'
Switch to the new version tag.
diff --git a/spec/factories/transactions.rb b/spec/factories/transactions.rb index abc1234..def5678 100644 --- a/spec/factories/transactions.rb +++ b/spec/factories/transactions.rb @@ -1,7 +1,7 @@ FactoryGirl.define do factory :transaction do amount Faker::Number.number(3) - user - project + associatio...
Fix polymorphic association in transaction factory
diff --git a/spec/rails_integration_spec.rb b/spec/rails_integration_spec.rb index abc1234..def5678 100644 --- a/spec/rails_integration_spec.rb +++ b/spec/rails_integration_spec.rb @@ -0,0 +1,14 @@+# encoding: utf-8 + +require 'spec_helper' + +describe "Rails integration", Tytus do + + include Integration + + let(:co...
Add integration specs working off rails engine.
diff --git a/lib/deadly_serious/engine/simple_json_process.rb b/lib/deadly_serious/engine/simple_json_process.rb index abc1234..def5678 100644 --- a/lib/deadly_serious/engine/simple_json_process.rb +++ b/lib/deadly_serious/engine/simple_json_process.rb @@ -0,0 +1,32 @@+require 'deadly_serious/engine/json_io' + +module ...
Add a mix of JsonProcess and BaseProcess
diff --git a/lib/em-midori/em_midori.rb b/lib/em-midori/em_midori.rb index abc1234..def5678 100644 --- a/lib/em-midori/em_midori.rb +++ b/lib/em-midori/em_midori.rb @@ -1,26 +1,26 @@ require 'logger' module Midori - @@logger = ::Logger.new(StringIO.new) + @logger = ::Logger.new(StringIO.new) def self.run(api ...
Store logger on instance variable
diff --git a/spec/rubocop/cops/style/end_of_line_spec.rb b/spec/rubocop/cops/style/end_of_line_spec.rb index abc1234..def5678 100644 --- a/spec/rubocop/cops/style/end_of_line_spec.rb +++ b/spec/rubocop/cops/style/end_of_line_spec.rb @@ -9,6 +9,7 @@ let(:eol) { EndOfLine.new } it 'registers an offence...
Mark the failing EndOfLine CR+LF spec as pending I'm marking it as pending to restore the build status until we figure out what to do with it.
diff --git a/spec/support/upload_server/upload_server.rb b/spec/support/upload_server/upload_server.rb index abc1234..def5678 100644 --- a/spec/support/upload_server/upload_server.rb +++ b/spec/support/upload_server/upload_server.rb @@ -0,0 +1,41 @@+require 'sinatra/base' + +class UploadServer < Sinatra::Base + config...
Save fake s3 server for future use.
diff --git a/spec/unit/mutant/matcher/chain/each_spec.rb b/spec/unit/mutant/matcher/chain/each_spec.rb index abc1234..def5678 100644 --- a/spec/unit/mutant/matcher/chain/each_spec.rb +++ b/spec/unit/mutant/matcher/chain/each_spec.rb @@ -24,8 +24,12 @@ it { should be_instance_of(to_enum.class) } - it 'yields ...
Mark rspec2 or rbx spec bug as pending under rbx
diff --git a/lib/writer/file_creator.rb b/lib/writer/file_creator.rb index abc1234..def5678 100644 --- a/lib/writer/file_creator.rb +++ b/lib/writer/file_creator.rb @@ -3,15 +3,18 @@ module Writer class FileCreator class << self + attr_accessor :name, :content + def create!(name, content) - f...
Add accessors to simplify function calls
diff --git a/spec/colorname_spec.rb b/spec/colorname_spec.rb index abc1234..def5678 100644 --- a/spec/colorname_spec.rb +++ b/spec/colorname_spec.rb @@ -5,7 +5,12 @@ expect(Colorname::VERSION).not_to be nil end + it 'can find Dominant color' do + white = Color::RGB.new(255,255,255) + expect(Colorname::F...
Add Dominant color find test
diff --git a/spec/redis_rpc_spec.rb b/spec/redis_rpc_spec.rb index abc1234..def5678 100644 --- a/spec/redis_rpc_spec.rb +++ b/spec/redis_rpc_spec.rb @@ -4,6 +4,33 @@ it "should have a logger" do RedisRpc.logger.wont_equal nil + end + + it "should support random_id" do + RedisRpc.random_id.wont_equal nil +...
Add tests around RedisRpc.random_id and random_source
diff --git a/spec/github/mime_type_spec.rb b/spec/github/mime_type_spec.rb index abc1234..def5678 100644 --- a/spec/github/mime_type_spec.rb +++ b/spec/github/mime_type_spec.rb @@ -0,0 +1,70 @@+require 'spec_helper' + +describe Github::MimeType do + + let(:github) { Github.new } + + it "should lookup mime type for :f...
Add specs for mime types module.
diff --git a/spec/unit/system/page_spec.rb b/spec/unit/system/page_spec.rb index abc1234..def5678 100644 --- a/spec/unit/system/page_spec.rb +++ b/spec/unit/system/page_spec.rb @@ -9,6 +9,12 @@ pager = described_class.new(output: output, input: input) read_io = spy write_io = spy + + if !pager.resp...
Change to mock out fork.
diff --git a/topic_api/app.rb b/topic_api/app.rb index abc1234..def5678 100644 --- a/topic_api/app.rb +++ b/topic_api/app.rb @@ -19,7 +19,7 @@ end end -blacklist = ["-", "http", "https"] +blacklist = ["-", "http", "https", "feel", "make", "right", "wrong"] get "/" do "Post to this route with a JSON payload. ...
Include additional blacklisted topic words Motivation: -these words are causing many poor point constructs to surface Change Explanation: -might need to extract these to a file if they get much longer
diff --git a/lib/ec2ssh/builder.rb b/lib/ec2ssh/builder.rb index abc1234..def5678 100644 --- a/lib/ec2ssh/builder.rb +++ b/lib/ec2ssh/builder.rb @@ -6,9 +6,7 @@ class Builder def initialize(container) @container = container - safe_level = nil - erb_trim_mode = '%-' - @host_lines_erb = ERB.n...
Fix arguments warnings of `ERB.new` on ruby 3.1
diff --git a/app/controllers/user/omniauth_callbacks_controller.rb b/app/controllers/user/omniauth_callbacks_controller.rb index abc1234..def5678 100644 --- a/app/controllers/user/omniauth_callbacks_controller.rb +++ b/app/controllers/user/omniauth_callbacks_controller.rb @@ -1,10 +1,8 @@ class User::OmniauthCallbacksC...
Add google_oauth2 to omniauth callbacks controller
diff --git a/api/spec/models/user_spec.rb b/api/spec/models/user_spec.rb index abc1234..def5678 100644 --- a/api/spec/models/user_spec.rb +++ b/api/spec/models/user_spec.rb @@ -1,8 +1,8 @@ require 'spec_helper' -describe User do +describe Spree::User do - let(:user) { User.new } + let(:user) { Spree::User.new } ...
Fix references in api user spec
diff --git a/config/initializers/session_store.rb b/config/initializers/session_store.rb index abc1234..def5678 100644 --- a/config/initializers/session_store.rb +++ b/config/initializers/session_store.rb @@ -1,3 +1,3 @@ # Be sure to restart your server when you modify this file. -Rails.application.config.session_sto...
Use SameSite None instead of Strict
diff --git a/test/gir_ffi/info_ext/i_signal_info_test.rb b/test/gir_ffi/info_ext/i_signal_info_test.rb index abc1234..def5678 100644 --- a/test/gir_ffi/info_ext/i_signal_info_test.rb +++ b/test/gir_ffi/info_ext/i_signal_info_test.rb @@ -1,4 +1,6 @@ require 'gir_ffi_test_helper' + +GirFFI.setup :Regress describe GirF...
Make ISignalInfo test run stand-alone
diff --git a/test_site/db/sequel_migrate/007_meetings.rb b/test_site/db/sequel_migrate/007_meetings.rb index abc1234..def5678 100644 --- a/test_site/db/sequel_migrate/007_meetings.rb +++ b/test_site/db/sequel_migrate/007_meetings.rb @@ -7,6 +7,6 @@ end def down - drop_table :officers + drop_table :meetings...
Fix downward sequel migration for test_site
diff --git a/refinerycms-auto_tweets.gemspec b/refinerycms-auto_tweets.gemspec index abc1234..def5678 100644 --- a/refinerycms-auto_tweets.gemspec +++ b/refinerycms-auto_tweets.gemspec @@ -1,7 +1,7 @@ Gem::Specification.new do |s| s.platform = Gem::Platform::RUBY s.name = 'refinerycms-auto_t...
Downgrade version number until it is more tested
diff --git a/app/models/challenge_post.rb b/app/models/challenge_post.rb index abc1234..def5678 100644 --- a/app/models/challenge_post.rb +++ b/app/models/challenge_post.rb @@ -32,11 +32,11 @@ end def click_count - clicks.count + clicks.size end def comment_count - comments.count + comments.s...
Use size instead of count
diff --git a/app/models/direct_message.rb b/app/models/direct_message.rb index abc1234..def5678 100644 --- a/app/models/direct_message.rb +++ b/app/models/direct_message.rb @@ -8,7 +8,7 @@ validates :receiver, presence: true validate :max_per_day - scope :today, lambda { where('DATE(created_at) = ?', Date.curr...
Use Time.current converted to Date by the database DirectMessage today scope Why: * Database stores created_at as timestamp with the timezone, so when comparing DATE(created_at) to something we have to convert it to DATE as well with the postresql native function, but using Time.current instead of Date.current to tak...
diff --git a/app/models/workflow_event.rb b/app/models/workflow_event.rb index abc1234..def5678 100644 --- a/app/models/workflow_event.rb +++ b/app/models/workflow_event.rb @@ -2,7 +2,7 @@ # # WorkflowEvent # -# A WorkflowEvent that has been associated with another class such as a Workorder, Asset etc. This is a +# ...
Make workflow events be sorted with newest first by default
diff --git a/lib/process_photos.rb b/lib/process_photos.rb index abc1234..def5678 100644 --- a/lib/process_photos.rb +++ b/lib/process_photos.rb @@ -19,7 +19,7 @@ album_photos.download_original(filename, tmp_dir) processor.process(filename) thumbs_uploader.upload(filename, :thumbs) - thumbs_upl...
Use correct path for web version
diff --git a/cookbooks/toolkit/recipes/default.rb b/cookbooks/toolkit/recipes/default.rb index abc1234..def5678 100644 --- a/cookbooks/toolkit/recipes/default.rb +++ b/cookbooks/toolkit/recipes/default.rb @@ -6,6 +6,19 @@ include_recipe 'passenger' include_recipe 'postgres' +include_recipe 'ruby19' + +# We can insta...
Use gem1.9.1 to install bundle
diff --git a/lib/xcode-versions.rb b/lib/xcode-versions.rb index abc1234..def5678 100644 --- a/lib/xcode-versions.rb +++ b/lib/xcode-versions.rb @@ -1,3 +1,7 @@ module XcodeDownload + GUI = { + '4.6.2' => 'https://developer.apple.com/downloads/download.action?path=Developer_Tools/xcode_4.6.2/xcode4620419895a.dmg'...
Add download URL for 4.6.2
diff --git a/libraries/matchers.rb b/libraries/matchers.rb index abc1234..def5678 100644 --- a/libraries/matchers.rb +++ b/libraries/matchers.rb @@ -1,10 +1,5 @@ if defined?(ChefSpec) - chefspec_version = Gem.loaded_specs['chefspec'].version - if chefspec_version < Gem::Version.new('4.1.0') - ChefSpec::Runner.defi...
Remove support for ancient chefspec Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/modules/govuk/spec/classes/govuk_node_s_cache_spec.rb b/modules/govuk/spec/classes/govuk_node_s_cache_spec.rb index abc1234..def5678 100644 --- a/modules/govuk/spec/classes/govuk_node_s_cache_spec.rb +++ b/modules/govuk/spec/classes/govuk_node_s_cache_spec.rb @@ -0,0 +1,34 @@+require_relative '../../../../...
Add test coverage for enabling authenticating-proxy
diff --git a/mPulse.podspec b/mPulse.podspec index abc1234..def5678 100644 --- a/mPulse.podspec +++ b/mPulse.podspec @@ -5,7 +5,7 @@ s.license = { :type => 'Apache License, Version 2.0', :file => 'LICENSE'} s.summary = "iOS library for mPulse Analytics" s.homepage = "https://github.com/SOAST...
Change to soastainc Twitter account
diff --git a/spec/freebsd/interfaces_spec.rb b/spec/freebsd/interfaces_spec.rb index abc1234..def5678 100644 --- a/spec/freebsd/interfaces_spec.rb +++ b/spec/freebsd/interfaces_spec.rb @@ -0,0 +1,24 @@+require 'spec_helper' + +# This test requires a VM to be provision with two IPs, preferably one public +# and one priv...
Test to ensure the VM has two interfaces, eth0 and eth1 This test requires a VM to be provision with two IPs, preferably one public and one private.
diff --git a/spec/system/users/login_spec.rb b/spec/system/users/login_spec.rb index abc1234..def5678 100644 --- a/spec/system/users/login_spec.rb +++ b/spec/system/users/login_spec.rb @@ -0,0 +1,19 @@+describe 'Login' do + it 'redirects to previous page' do + password = 'Secret123!' + user = User.create!(email:...
Cover redirect to previous url with spec
diff --git a/spec/factories/line_items.rb b/spec/factories/line_items.rb index abc1234..def5678 100644 --- a/spec/factories/line_items.rb +++ b/spec/factories/line_items.rb @@ -5,8 +5,5 @@ code "MyString" title "MyString" description "MyString" - item nil - type "" - invoice nil end end
Drop item, type, and invoice value in default LineItem factory.
diff --git a/spec/lib/application_spec.rb b/spec/lib/application_spec.rb index abc1234..def5678 100644 --- a/spec/lib/application_spec.rb +++ b/spec/lib/application_spec.rb @@ -11,6 +11,10 @@ application.client_shell = shell application.silent = true allow(shell).to receive(:os).and_return(:debian) + end...
Reset Recipe after each test
diff --git a/timeliness.gemspec b/timeliness.gemspec index abc1234..def5678 100644 --- a/timeliness.gemspec +++ b/timeliness.gemspec @@ -13,8 +13,6 @@ s.description = %q{Fast date/time parser with customisable formats, timezone and I18n support.} s.license = "MIT" - s.rubyforge_project = %q{timeliness} - ...
Remove rubyforge_project from gem spec.
diff --git a/spec/production/memo_spec.rb b/spec/production/memo_spec.rb index abc1234..def5678 100644 --- a/spec/production/memo_spec.rb +++ b/spec/production/memo_spec.rb @@ -0,0 +1,8 @@+describe Calyx::Production::Memo do + it 'uses the registry to memoize expansions' do + registry = double('registry') + allo...
Add test of memoized production rules
diff --git a/tasks/yardoc.rake b/tasks/yardoc.rake index abc1234..def5678 100644 --- a/tasks/yardoc.rake +++ b/tasks/yardoc.rake @@ -3,7 +3,7 @@ YARD::Rake::YardocTask.new do |t| t.files = ['lib/**/*.rb'] - t.options = ['--private', '--protected', '--readme', 'README.rdoc'] + t.options = ['--private',...
Load correct README in Yard
diff --git a/test-using-gir.rb b/test-using-gir.rb index abc1234..def5678 100644 --- a/test-using-gir.rb +++ b/test-using-gir.rb @@ -0,0 +1,53 @@+# +# Exploratory program to see what kind of method_missing we would need in a +# module. In the end, this code would have to be generated by the Builder, +# or be provided b...
Add exploratory test program: Uses repository, generates methods dynamically.
diff --git a/app/controllers/auth/passwords_controller.rb b/app/controllers/auth/passwords_controller.rb index abc1234..def5678 100644 --- a/app/controllers/auth/passwords_controller.rb +++ b/app/controllers/auth/passwords_controller.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true class Auth::PasswordsController < ...
Fix to allow password reset even if signed in
diff --git a/app/controllers/group_requests_controller.rb b/app/controllers/group_requests_controller.rb index abc1234..def5678 100644 --- a/app/controllers/group_requests_controller.rb +++ b/app/controllers/group_requests_controller.rb @@ -22,7 +22,7 @@ private def using_commercial_page? - ENV['SHOW_PAYMENT_...
Change name of ENV variable to SHOW_COMMERCIAL_PAGE
diff --git a/app/controllers/latest_changes_controller.rb b/app/controllers/latest_changes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/latest_changes_controller.rb +++ b/app/controllers/latest_changes_controller.rb @@ -28,7 +28,7 @@ end def subtopic - Topic.find(subtopic_base_path, pagin...
Reduce requests for latest changes This reduces the number of content store requests required to render a page in latest changes from 8(!) to 1. Example URL: https://www.gov.uk/topic/business-tax/pension-scheme-administration/latest
diff --git a/app/controllers/unread_entries_controller.rb b/app/controllers/unread_entries_controller.rb index abc1234..def5678 100644 --- a/app/controllers/unread_entries_controller.rb +++ b/app/controllers/unread_entries_controller.rb @@ -10,7 +10,7 @@ unread_entry.destroy_all elsif params[:read] == 'false...
Check if blank? instead of nil?.
diff --git a/app/workers/upload_files_to_server_worker.rb b/app/workers/upload_files_to_server_worker.rb index abc1234..def5678 100644 --- a/app/workers/upload_files_to_server_worker.rb +++ b/app/workers/upload_files_to_server_worker.rb @@ -12,7 +12,6 @@ files_with_path.each do |destination, files| s.copy_to...
Revert "Add a little sleep around the mass uploader, to try and fix the file upload result page showing an outdated status for a server upload" This reverts commit 7d33cc41a5aaf2b15d48b38b01c31f5299bba2ec.
diff --git a/lib/kosapi_client/entity/semester.rb b/lib/kosapi_client/entity/semester.rb index abc1234..def5678 100644 --- a/lib/kosapi_client/entity/semester.rb +++ b/lib/kosapi_client/entity/semester.rb @@ -2,6 +2,7 @@ module Entity class Semester < BaseEntity + map_data :code map_data :end_date,...
Add attribute "code" to Semester
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -23,6 +23,10 @@ field :current_sign_in_ip, type: String field :last_sign_in_ip, type: String + belongs_to :sequence + belongs_to :alignment + belongs_to :collection + #...
Add relations to User model
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -2,7 +2,8 @@ # Include default devise modules. Others available are: # :confirmable, :lockable, :timeoutable and :omniauthable devise :database_authenticatable, :registerable, ...
Add confirmable module to User model Add devise's confirmable module to the User model. This will allow confirmation of accounts by email after creation.
diff --git a/21_scrambled_passwords.rb b/21_scrambled_passwords.rb index abc1234..def5678 100644 --- a/21_scrambled_passwords.rb +++ b/21_scrambled_passwords.rb @@ -0,0 +1,62 @@+def apply(instructions, input, undo: false) + instructions.reduce(input.dup) { |pw, (cmd, *args)| + case cmd + when :swap_letter + ...
Add day 21: Scrambled Passwords
diff --git a/lib/tasks/active_elastic_schema.rake b/lib/tasks/active_elastic_schema.rake index abc1234..def5678 100644 --- a/lib/tasks/active_elastic_schema.rake +++ b/lib/tasks/active_elastic_schema.rake @@ -25,4 +25,9 @@ args[:model_klass].to_s.constantize.import_async end + desc "Imports data from a given ...
Add an `import_now` task. To import a model without using background jobs.
diff --git a/app/models/photo_request.rb b/app/models/photo_request.rb index abc1234..def5678 100644 --- a/app/models/photo_request.rb +++ b/app/models/photo_request.rb @@ -35,7 +35,7 @@ AWS::S3::PresignedPost.new( bucket, :key => key, - :secure => false, + :secure => Rails.production?, ...
Enable HTTPS requests for S3 uploads
diff --git a/spec/acceptance/openldap__server__access_spec.rb b/spec/acceptance/openldap__server__access_spec.rb index abc1234..def5678 100644 --- a/spec/acceptance/openldap__server__access_spec.rb +++ b/spec/acceptance/openldap__server__access_spec.rb @@ -0,0 +1,22 @@+require 'spec_helper_acceptance' + +describe 'open...
Add acceptance test for openldap_access
diff --git a/spec/vcloud/tools/tester/test_parameters_spec.rb b/spec/vcloud/tools/tester/test_parameters_spec.rb index abc1234..def5678 100644 --- a/spec/vcloud/tools/tester/test_parameters_spec.rb +++ b/spec/vcloud/tools/tester/test_parameters_spec.rb @@ -1,13 +1,14 @@ require 'vcloud/tools/tester' module Vcloud::T...
Move set-up and tear-down outside specific context As same set-up and tear-down will be required for other testing contexts.
diff --git a/Casks/eclipse-platform.rb b/Casks/eclipse-platform.rb index abc1234..def5678 100644 --- a/Casks/eclipse-platform.rb +++ b/Casks/eclipse-platform.rb @@ -1,7 +1,12 @@ class EclipsePlatform < Cask - url 'http://download.eclipse.org/eclipse/downloads/drops4/R-4.3.2-201402211700/eclipse-SDK-4.3.2-macosx-cocoa-...
Add 32bit support to Eclipse Platform
diff --git a/XPCSwift.podspec b/XPCSwift.podspec index abc1234..def5678 100644 --- a/XPCSwift.podspec +++ b/XPCSwift.podspec @@ -15,7 +15,7 @@ s.platform = :osx, "10.9" s.source = { :git => "https://github.com/IngmarStein/XPCSwift.git", :tag => "0.0.2" } - s.source_files = "XPCSwift/**/*.{m,h,swift}"...
Remove .m file from Podspec
diff --git a/constants/ooe_randomizer_constants.rb b/constants/ooe_randomizer_constants.rb index abc1234..def5678 100644 --- a/constants/ooe_randomizer_constants.rb +++ b/constants/ooe_randomizer_constants.rb @@ -7,7 +7,7 @@ (0x7F..0x81).to_a + # max ups (placed separately by the randomizer logic) (0xD7..0xE4).to_...
Add necromancer to list of spawners
diff --git a/spec/features/merge_requests/toggle_whitespace_changes.rb b/spec/features/merge_requests/toggle_whitespace_changes.rb index abc1234..def5678 100644 --- a/spec/features/merge_requests/toggle_whitespace_changes.rb +++ b/spec/features/merge_requests/toggle_whitespace_changes.rb @@ -1,11 +1,10 @@ require 'spec...
Use variables instead of let
diff --git a/spec/integration/form_spec.rb b/spec/integration/form_spec.rb index abc1234..def5678 100644 --- a/spec/integration/form_spec.rb +++ b/spec/integration/form_spec.rb @@ -8,8 +8,8 @@ it "outputs an AST" do expect(form.(title: "Aurora", rating: 10)).to eq [ - [:field, [:title, "string", "Aurora"...
Update basic AST spec to include error arrays
diff --git a/spec/listen/turnstile_spec.rb b/spec/listen/turnstile_spec.rb index abc1234..def5678 100644 --- a/spec/listen/turnstile_spec.rb +++ b/spec/listen/turnstile_spec.rb @@ -11,31 +11,31 @@ end describe Listen::Turnstile do + before { @called = false } + describe '#wait' do context 'without a signal'...
Fix turnstile specs on 1.8.7 and ree
diff --git a/spec/github/events_spec.rb b/spec/github/events_spec.rb index abc1234..def5678 100644 --- a/spec/github/events_spec.rb +++ b/spec/github/events_spec.rb @@ -0,0 +1,54 @@+require 'spec_helper' + +describe Github::Events do + + let(:github) { Github.new } + + describe "public_events" do + context "resour...
Add spec stub for new events api.
diff --git a/pusher-client.gemspec b/pusher-client.gemspec index abc1234..def5678 100644 --- a/pusher-client.gemspec +++ b/pusher-client.gemspec @@ -21,7 +21,7 @@ s.require_paths = ['lib'] s.licenses = ['MIT'] - s.add_runtime_dependency 'websocket', '~> 1.1.2' + s.add_runtime_dependency 'websocket',...
Allow websocket to be any 1.x version
diff --git a/gc-disable-gifs.rb b/gc-disable-gifs.rb index abc1234..def5678 100644 --- a/gc-disable-gifs.rb +++ b/gc-disable-gifs.rb @@ -37,7 +37,7 @@ doc = Nokogiri::XML(content) doc.xpath(img_xpath).each do |e| # skip avatars - if !e['src'].include? "avatars" + unless e['src'].include? "avatars" ...
Make ruby implementation more idiomatic
diff --git a/lib/poke/window.rb b/lib/poke/window.rb index abc1234..def5678 100644 --- a/lib/poke/window.rb +++ b/lib/poke/window.rb @@ -7,8 +7,8 @@ attr_accessor :paused def initialize - @width = Poke::Dimensions::WIDTH - @height = Poke::Dimensions::HEIGHT + @width = WIDTH * GRID + @height = HEIGH...
Use new Dimensions in Window setup
diff --git a/lib/last_hit.rb b/lib/last_hit.rb index abc1234..def5678 100644 --- a/lib/last_hit.rb +++ b/lib/last_hit.rb @@ -6,23 +6,21 @@ require 'last_hit/test_handler' -module LastHit - class << self - def run_modified_tests - files = RcAdapter::GitAdapter.get_modified_files - process(files) - e...
Use instance method instead of class method
diff --git a/lib/kitty_events.rb b/lib/kitty_events.rb index abc1234..def5678 100644 --- a/lib/kitty_events.rb +++ b/lib/kitty_events.rb @@ -24,14 +24,12 @@ end def self.subscribe(event, handler) - ensure_registered_event(event) - - handlers[event.to_sym] ||= [] - handlers[event.to_sym] << handler + ...
Simplify handling of missing event names
diff --git a/lib/pairwise.rb b/lib/pairwise.rb index abc1234..def5678 100644 --- a/lib/pairwise.rb +++ b/lib/pairwise.rb @@ -10,7 +10,9 @@ require 'pairwise/cli' require 'yaml' -YAML::ENGINE.yamler = 'syck' +if RUBY_VERSION != '1.8.7' + YAML::ENGINE.yamler = 'syck' +end module Pairwise class InvalidInputData...
Exclude 1.8.7 from using the nicer yaml parser. Its breaks the build as it does not know what the parser is
diff --git a/lib/services.rb b/lib/services.rb index abc1234..def5678 100644 --- a/lib/services.rb +++ b/lib/services.rb @@ -15,6 +15,7 @@ @asset_manager ||= GdsApi::AssetManager.new( Plek.find("asset-manager"), bearer_token: ENV.fetch("ASSET_MANAGER_BEARER_TOKEN", "12345678"), + timeout: 60, ...
Increase Asset Manager timeout to 60s We are finding that large attachments are not being uploaded to asset manager due to a timeout during the upload. Therefore increasing this from the default 15s to 60s.
diff --git a/lib/sonicapi.rb b/lib/sonicapi.rb index abc1234..def5678 100644 --- a/lib/sonicapi.rb +++ b/lib/sonicapi.rb @@ -1,5 +1,42 @@ require "sonicapi/version" -module Sonicapi - # Your code goes here... +module SonicApi + class << self + def authenticate(access_key) + @access_key = access_key + @...
Add skeleton for basic API
diff --git a/lib/base62.rb b/lib/base62.rb index abc1234..def5678 100644 --- a/lib/base62.rb +++ b/lib/base62.rb @@ -22,7 +22,7 @@ rem = int result = '' while rem != 0 - result = PRIMITIVES[rem % PRIMITIVES.size].to_s + result + result.prepend PRIMITIVES[rem % PRIMITIVES.size] ...
Use `prepend` to avoid creating new string objects
diff --git a/config/deploy/production.rb b/config/deploy/production.rb index abc1234..def5678 100644 --- a/config/deploy/production.rb +++ b/config/deploy/production.rb @@ -2,8 +2,8 @@ # please put general deployment config in config/deploy/settings.rb set :user, "#{application}" -set :is_root_domain, true -set :roo...
Add config.yml to deploy process
diff --git a/callcredit.gemspec b/callcredit.gemspec index abc1234..def5678 100644 --- a/callcredit.gemspec +++ b/callcredit.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |gem| gem.add_runtime_dependency 'faraday_middleware', '>= 0.8.2', '< 0.13' - gem.add_runtime_dependency 'multi_xml', '~> 0.5.1'...
Update requirements to permit multi_xml 0.6.0 Updates requirements to permit [multi_xml 0.6.0](https://github.com/sferik/multi_xml). - [Changelog](https://github.com/sferik/multi_xml/blob/master/CHANGELOG.md)
diff --git a/lib/whiteout.rb b/lib/whiteout.rb index abc1234..def5678 100644 --- a/lib/whiteout.rb +++ b/lib/whiteout.rb @@ -5,12 +5,18 @@ module Whiteout def self.execute(*args) + recurse = false + opts = OptionParser.new do |opts| opts.banner = "Usage: whiteout file1 [...]" - opts.on('-h', ...
Add support for recursing into directories
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -20,7 +20,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "gc_ruboconfig", "~> 2.29.0" + spec.add_...
Update gc_ruboconfig requirement from ~> 2.29.0 to ~> 2.30.0 Updates the requirements on [gc_ruboconfig](https://github.com/gocardless/ruboconfig) to permit the latest version. - [Release notes](https://github.com/gocardless/ruboconfig/releases) - [Changelog](https://github.com/gocardless/gc_ruboconfig/blob/master/CHA...
diff --git a/business.gemspec b/business.gemspec index abc1234..def5678 100644 --- a/business.gemspec +++ b/business.gemspec @@ -23,5 +23,5 @@ spec.add_development_dependency "gc_ruboconfig", "~> 2.25.0" spec.add_development_dependency "rspec", "~> 3.1" spec.add_development_dependency "rspec_junit_formatter", "...
Update rubocop requirement from ~> 1.15.0 to ~> 1.18.0 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://gi...
diff --git a/cassette.gemspec b/cassette.gemspec index abc1234..def5678 100644 --- a/cassette.gemspec +++ b/cassette.gemspec @@ -3,7 +3,7 @@ Gem::Specification.new do |spec| spec.name = 'cassette' - spec.version = '0.1' + spec.version = '0.1.0' spec.date = '2015-06-06' spec.summary ...
Update gemspec with 3 digit version code.
diff --git a/lib/bitmap.rb b/lib/bitmap.rb index abc1234..def5678 100644 --- a/lib/bitmap.rb +++ b/lib/bitmap.rb @@ -3,11 +3,12 @@ # The bitmap object. # A 2D array with rgb values as entries. class Bitmap - attr_reader :data + attr_reader :data, :width, :height def initialize(width, height) - @data = Array...
Make width and height class attributes.
diff --git a/lib/import.rb b/lib/import.rb index abc1234..def5678 100644 --- a/lib/import.rb +++ b/lib/import.rb @@ -5,7 +5,7 @@ def self.perform(pages = nil) response = HTTParty.get(ENV['ERNEST_ADDRESS_ENDPOINT']).parsed_response - pages = pages || response["pages"].to_i + pages = (pages || response["pa...
Make sure we're casting as an integer
diff --git a/plugin/init.rb b/plugin/init.rb index abc1234..def5678 100644 --- a/plugin/init.rb +++ b/plugin/init.rb @@ -0,0 +1,23 @@+require 'zippy' + +Mime::Type.register 'application/zip', :zip + +module ::ActionView + module TemplateHandlers + class Zipper < TemplateHandler + include Compilable + + d...
Add Rails plugin which adds foo.zip.zipper template handler
diff --git a/lib/values.rb b/lib/values.rb index abc1234..def5678 100644 --- a/lib/values.rb +++ b/lib/values.rb @@ -25,7 +25,7 @@ missing_keys = self::VALUE_ATTRS - hash.keys if missing_keys.any? - raise ArgumentError.new("Missing hash keys: #{missing_keys}") + raise ArgumentError....
Include given keys in missing keys error message
diff --git a/load_paths.rb b/load_paths.rb index abc1234..def5678 100644 --- a/load_paths.rb +++ b/load_paths.rb @@ -1,32 +1,9 @@-begin - require File.expand_path('../.bundle/environment', __FILE__) -rescue LoadError - begin - # bust gem prelude - if defined? Gem - Gem.source_index - gem 'bundler' - ...
Remove rescue as it was clobbering the real error.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -21,8 +21,12 @@ # user signups and registration devise_for :users, controllers: { + confirmations: 'users/confirmations', + # omniauth_callbacks: 'users/omniauth_callbacks', + ...
Use scoped controllers for devise users
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -27,8 +27,6 @@ resources :transfers, only: [:create] - resource :sessions, only: [:create, :destroy] - resources :documents resource "report" do
Remove remains of previous sessions controller
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -18,5 +18,5 @@ end # Catch All - match '*path' => 'high_voltage/pages#show', id: 'index' + match '*path' => 'high_voltage/pages#show', id: 'index', constraints: lambda { |request| !(r...
Add condition to catch all route for asset requests.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,3 +1,5 @@+Kernel.load Rails.root.join('lib', 'reviewit', 'lib', 'reviewit', 'version.rb') unless defined? Reviewit::VERSION + Rails.application.routes.draw do devise_for :users, skip: :...
Fix load of Reviewit::VERSION constant when no API calls were made yet.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -21,7 +21,4 @@ root 'layout#show' get :about, controller: :layout, action: :show - - # Handle 404 - get '*path', to: 'layout#show' end
Remove catch-all from routing configuration
diff --git a/Casks/java.rb b/Casks/java.rb index abc1234..def5678 100644 --- a/Casks/java.rb +++ b/Casks/java.rb @@ -1,8 +1,12 @@ class Java < Cask - url 'http://support.apple.com/downloads/DL1572/en_US/JavaForOSX2013-05.dmg' - homepage 'http://support.apple.com/downloads/DL1572' - version '1.6.0_65' - sha1 'ce78f9...
Update from Java6 to Java7 Fixes #2189
diff --git a/spec/functional/cli_consumer_spec.rb b/spec/functional/cli_consumer_spec.rb index abc1234..def5678 100644 --- a/spec/functional/cli_consumer_spec.rb +++ b/spec/functional/cli_consumer_spec.rb @@ -4,22 +4,19 @@ describe 'The pact-init-consumer command line interface' do before do - FileUtils.mkdir_p...
Set up expected state before test rather than cleaning after test. Do chdir with a block so that it does not rely on the after hook.
diff --git a/spec/integration/new_license_spec.rb b/spec/integration/new_license_spec.rb index abc1234..def5678 100644 --- a/spec/integration/new_license_spec.rb +++ b/spec/integration/new_license_spec.rb @@ -1,16 +1,21 @@ # encoding: utf-8 RSpec.describe 'rtty new --license', type: :cli do - it "generates a licens...
Add test for new license generation.
diff --git a/spec/support/features/new_project.rb b/spec/support/features/new_project.rb index abc1234..def5678 100644 --- a/spec/support/features/new_project.rb +++ b/spec/support/features/new_project.rb @@ -1,6 +1,10 @@ module Features APP_NAME = "arkenstone_test" + def app_name + APP_NAME + end + def ...
Add quick way to get at APP_NAME
diff --git a/nestive.gemspec b/nestive.gemspec index abc1234..def5678 100644 --- a/nestive.gemspec +++ b/nestive.gemspec @@ -16,5 +16,7 @@ s.required_ruby_version = ">= 1.9.3" - s.add_dependency "rails", ">= 3.0.0" + s.add_dependency "actionview", ">= 3.0.0" + s.add_dependency "activesupport", ">= 3.0.0" + s....
Trim down the dependency list
diff --git a/Pluck.podspec b/Pluck.podspec index abc1234..def5678 100644 --- a/Pluck.podspec +++ b/Pluck.podspec @@ -1,12 +1,13 @@ Pod::Spec.new do |s| s.name = 'Pluck' - s.version = '0.1' + s.version = '0.1.1' s.summary = 'Library for grabbing data from OEmbed (and OEmbed-ish) sites' ...
Update podspec so hpple files are included
diff --git a/test/cookbooks/user_test/recipes/lwrp.rb b/test/cookbooks/user_test/recipes/lwrp.rb index abc1234..def5678 100644 --- a/test/cookbooks/user_test/recipes/lwrp.rb +++ b/test/cookbooks/user_test/recipes/lwrp.rb @@ -13,3 +13,13 @@ user_account 'obiwan' do action :remove end + +user_account 'darth.vader' d...
Add example to verify behavior of non_unique attr for user_account. References #30
diff --git a/tests/spec/features/editor_types_spec.rb b/tests/spec/features/editor_types_spec.rb index abc1234..def5678 100644 --- a/tests/spec/features/editor_types_spec.rb +++ b/tests/spec/features/editor_types_spec.rb @@ -25,4 +25,29 @@ } EOF end + + scenario "using the Monaco editor" do + in_config_...
Add basic test that Monaco is hooked up
diff --git a/plugins/jobs.rb b/plugins/jobs.rb index abc1234..def5678 100644 --- a/plugins/jobs.rb +++ b/plugins/jobs.rb @@ -21,8 +21,4 @@ end end end - - def on_connect(rp, opts) - d = Twke::JobManager.spawn("/bin/sleep 300") - end end
Remove test job on startup.
diff --git a/config/initializers/messenger.rb b/config/initializers/messenger.rb index abc1234..def5678 100644 --- a/config/initializers/messenger.rb +++ b/config/initializers/messenger.rb @@ -1,6 +1,6 @@ require 'messenger' -unless File.basename($0) == 'rake' || Rails.env.test? +unless Rails.env.test? host = Rail...
Connect Stomp client when running rake tasks
diff --git a/db/migrate/20120609094747_add_indices_for_user.rb b/db/migrate/20120609094747_add_indices_for_user.rb index abc1234..def5678 100644 --- a/db/migrate/20120609094747_add_indices_for_user.rb +++ b/db/migrate/20120609094747_add_indices_for_user.rb @@ -1,7 +1,15 @@ class AddIndicesForUser < ActiveRecord::Migrat...
Allow all migrations to run in sequence An earlier migration does actually create these indexes. However the schema.rb at some point had got out of sync with the schema generated by running migrations in order. I suspect that this migration was created to fix a db schema created by loading a schema, rather than by run...