Datasets:
seniruk
/
git-diff_to_commit_msg_large

Dataset card Data Studio Files
xet
 Community
diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/users/private_message_threads_controller.rb b/app/controllers/users/private_message_threads_controller.rb index abc1234..def5678 100644 --- a/app/controllers/users/private_message_threads_controller.rb +++ b/app/controllers/users/private_message_threads_controller.rb @@ -18,7 +18,7 @@ end...
Order private messages by last activity Fixes #648
diff --git a/lib/rubocop/ast_node/builder.rb b/lib/rubocop/ast_node/builder.rb index abc1234..def5678 100644 --- a/lib/rubocop/ast_node/builder.rb +++ b/lib/rubocop/ast_node/builder.rb @@ -20,6 +20,12 @@ def n(type, children, source_map) Node.new(type, children, location: source_map) end + + ...
Fix the breakage introduced by parser 2.3.0.7 See https://github.com/whitequark/parser/issues/283 for details. Probably the proper long-term solution would be to adjust our specs.
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -1,6 +1,6 @@ default['selenium']['server_version'] = '2.45.0' default['selenium']['iedriver_version'] = '2.45.0' -default['selenium']['chromedriver_version'] = '2.14' +def...
Update ChromeDriver from 2.14 to 2.15
diff --git a/lib/smartsheet/api/file_spec.rb b/lib/smartsheet/api/file_spec.rb index abc1234..def5678 100644 --- a/lib/smartsheet/api/file_spec.rb +++ b/lib/smartsheet/api/file_spec.rb @@ -27,5 +27,29 @@ @content_type = content_type end end + + # Specification for file sheet import by path and MI...
Add new file specifications for sheet importing.
diff --git a/lib/sub_diff/core_ext/string.rb b/lib/sub_diff/core_ext/string.rb index abc1234..def5678 100644 --- a/lib/sub_diff/core_ext/string.rb +++ b/lib/sub_diff/core_ext/string.rb @@ -1,10 +1,18 @@ module SubDiff module CoreExt module String + # Behaves just like {String#sub} but wraps the returned re...
Add inline documentation for sub_diff and gsub_diff
diff --git a/lib/tanuki/extensions/module.rb b/lib/tanuki/extensions/module.rb index abc1234..def5678 100644 --- a/lib/tanuki/extensions/module.rb +++ b/lib/tanuki/extensions/module.rb @@ -1,13 +1,17 @@ class Module # Runs Tanuki::Loader for every missing constant in any namespace. - def const_missing_with_tanuki...
Create empty classes for missing constants
diff --git a/lab.gemspec b/lab.gemspec index abc1234..def5678 100644 --- a/lab.gemspec +++ b/lab.gemspec @@ -23,5 +23,6 @@ spec.add_development_dependency "bundler", "~> 1.3" spec.add_development_dependency "rake" + spec.add_development_dependency "rspec" spec.add_development_dependency "mocha" end
Add rspec to development dependencies
diff --git a/log.gemspec b/log.gemspec index abc1234..def5678 100644 --- a/log.gemspec +++ b/log.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'evt-log' - s.version = '0.6.0.1' + s.version = '1.0.0.0' s.summary = 'Logging to STD IO with levels, tagging, and coloring' ...
Package version is increased from 0.6.0.1 to 1.0.0.0
diff --git a/lib/geocoder/ip_address.rb b/lib/geocoder/ip_address.rb index abc1234..def5678 100644 --- a/lib/geocoder/ip_address.rb +++ b/lib/geocoder/ip_address.rb @@ -3,7 +3,7 @@ class IpAddress < String def loopback? - valid? and (self == "0.0.0.0" or self.match(/\A127\./) or self == "::1") + vali...
Return strict boolean, for clarity.
diff --git a/core/kernel/at_exit_spec.rb b/core/kernel/at_exit_spec.rb index abc1234..def5678 100644 --- a/core/kernel/at_exit_spec.rb +++ b/core/kernel/at_exit_spec.rb @@ -14,6 +14,12 @@ code = "at_exit {print 4};at_exit {print 5}; print 6; at_exit {print 7}" ruby_exe(code).should == "6754" end + + it "al...
Add spec for calling exit inside at_exit handler
diff --git a/lib/cogwheels.rb b/lib/cogwheels.rb index abc1234..def5678 100644 --- a/lib/cogwheels.rb +++ b/lib/cogwheels.rb @@ -30,4 +30,10 @@ module Cogwheels autoload :Configuration, 'cogwheels/configuration' autoload :Loader, 'cogwheels/loader' + + module_function + + def load(src, mutable = true) + Cogw...
Add wrapper method to module
diff --git a/lib/scanny/checks/check.rb b/lib/scanny/checks/check.rb index abc1234..def5678 100644 --- a/lib/scanny/checks/check.rb +++ b/lib/scanny/checks/check.rb @@ -11,6 +11,12 @@ @issues end + # @return [String] pattern used to find relevant nodes. It must respect Machete's syntax. + def...
Define pattern method inside of Check Make easier to understand how to write custom checks.
diff --git a/lib/stream_service/item.rb b/lib/stream_service/item.rb index abc1234..def5678 100644 --- a/lib/stream_service/item.rb +++ b/lib/stream_service/item.rb @@ -3,7 +3,7 @@ require 'active_support/core_ext/hash' module StreamService - TIME_STAMP_FORMAT = '%Y-%m-%dT%H:%M:%S.%N%:z' + TIME_STAMP_FORMAT = '%Y-...
Reduce precision sent to roshi to match db. This ensures that roshi only cares about microseconds and nanoseconds are discarded. This is important because postgres only stores microsecond precision. In cases where we write to the stream from an object recently created in ruby memory we have nanosecond precision. Due ...
diff --git a/lib/githubber.rb b/lib/githubber.rb index abc1234..def5678 100644 --- a/lib/githubber.rb +++ b/lib/githubber.rb @@ -5,8 +5,38 @@ require "githubber/pull_requests" require "githubber/issues" require "githubber/search" +require "githubber/teams" module Githubber # Your code goes here... - binding.pr...
Initialize classes and create assign_hw method
diff --git a/lib/approvals/reporters/filelauncher_reporter.rb b/lib/approvals/reporters/filelauncher_reporter.rb index abc1234..def5678 100644 --- a/lib/approvals/reporters/filelauncher_reporter.rb +++ b/lib/approvals/reporters/filelauncher_reporter.rb @@ -4,7 +4,7 @@ include Singleton class << self - ...
Make the ignored argument optional in file launcher
diff --git a/lib/overcommit/plugins/pre_commit/haml_syntax.rb b/lib/overcommit/plugins/pre_commit/haml_syntax.rb index abc1234..def5678 100644 --- a/lib/overcommit/plugins/pre_commit/haml_syntax.rb +++ b/lib/overcommit/plugins/pre_commit/haml_syntax.rb @@ -1,21 +1,15 @@-begin - require 'haml' -rescue LoadError => e - ...
Make Haml syntax checker lazy-load haml gem Similar to scss-lint, only load the gem if the repo contains modified '.haml' files. This makes it so that people can leave this hook installed but dormant unless they're actually working on Haml files. Prior to this commit, they'd get a warning about the gem not being insta...
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -3,10 +3,10 @@ maintainer_email "steffen.gebert@typo3.org" license "Apache 2.0" description "Installs/configures something" -version "0.1.22" +version "0.1.23" depends "ssh", ...
Update upstream t3-gerrit to 0.4.20
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -11,4 +11,4 @@ supports "debian" depends "build-essential" -depends "git", "1.0.0" +depends "git"
Remove version constraint from git cookbook
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -20,4 +20,4 @@ depends 'zookeeper', '~> 8.0' depends 'magic', '~> 1.5' depends 'et_gradle', '~> 2.0' -depends 'maven', '~> 4.0' +depends 'maven', '~> 5.0'
Upgrade maven dependency to 5.x https://supermarket.chef.io/cookbooks/maven#changelog
diff --git a/moa.podspec b/moa.podspec index abc1234..def5678 100644 --- a/moa.podspec +++ b/moa.podspec @@ -20,5 +20,5 @@ s.screenshots = "https://raw.githubusercontent.com/evgenyneu/moa/master/Graphics/Hunting_Moa.jpg" s.source_files = "Moa/**/*.swift" s.ios.deployment_target = "8.0" - s.osx.deployment_targ...
Decrease osx version in podpsec
diff --git a/ring_sig.gemspec b/ring_sig.gemspec index abc1234..def5678 100644 --- a/ring_sig.gemspec +++ b/ring_sig.gemspec @@ -6,6 +6,7 @@ s.authors = ['Stephen McCarthy'] s.email = 'sjmccarthy@gmail.com' s.summary = 'This gem implements ring signatures, built on top of ECDSA, as specified by Cr...
Remove warnings generated from gemspec
diff --git a/spec/data_set_spec.rb b/spec/data_set_spec.rb index abc1234..def5678 100644 --- a/spec/data_set_spec.rb +++ b/spec/data_set_spec.rb @@ -7,17 +7,29 @@ context 'when all required sheets and headers are present' do context 'when columns match data format correctly' do + + well_formatted_ex...
Add paths to sample data for testing
diff --git a/goldfinger.gemspec b/goldfinger.gemspec index abc1234..def5678 100644 --- a/goldfinger.gemspec +++ b/goldfinger.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = 'goldfinger' - s.version = '1.2.0' + s.version = '1.2.1' s.platform ...
Update dependencies and bump to 1.2.1
diff --git a/activesupport/activesupport.gemspec b/activesupport/activesupport.gemspec index abc1234..def5678 100644 --- a/activesupport/activesupport.gemspec +++ b/activesupport/activesupport.gemspec @@ -22,5 +22,5 @@ s.add_dependency('i18n', '~> 0.6') s.add_dependency('multi_json', '~> 1.3') s.add_depen...
Update minitest dependency to ~> 4.0
diff --git a/spec/controllers/sessions_controller_spec.rb b/spec/controllers/sessions_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/sessions_controller_spec.rb +++ b/spec/controllers/sessions_controller_spec.rb @@ -17,7 +17,7 @@ end it 'loads or creates the user from the OAuth hash'...
Fix failing session controller spec
diff --git a/spec/models/album_spec.rb b/spec/models/album_spec.rb index abc1234..def5678 100644 --- a/spec/models/album_spec.rb +++ b/spec/models/album_spec.rb @@ -1,9 +1,7 @@ require 'spec_helper' describe Album do - it 'must belong to a user' do - pending 'test user association' - end + it { should validate...
Test the validation of user_id on Album model
diff --git a/spec/models/email_spec.rb b/spec/models/email_spec.rb index abc1234..def5678 100644 --- a/spec/models/email_spec.rb +++ b/spec/models/email_spec.rb @@ -15,7 +15,9 @@ describe ".to" do it "should return an array for all the email addresses" do - email = Email.create!(:to => "mlandauer@foo.org,...
Make test a little more specific about how the to addresses are stored
diff --git a/mishmesh.podspec b/mishmesh.podspec index abc1234..def5678 100644 --- a/mishmesh.podspec +++ b/mishmesh.podspec @@ -8,7 +8,7 @@ s.homepage = "https://github.com/vovagalchenko/mishmesh" s.license = { :type => "MIT", :file => "LICENSE" } s.author = "Vova Galchenko"...
Update podspec after pod spec lint
diff --git a/casino-ldap_authenticator.gemspec b/casino-ldap_authenticator.gemspec index abc1234..def5678 100644 --- a/casino-ldap_authenticator.gemspec +++ b/casino-ldap_authenticator.gemspec @@ -23,5 +23,5 @@ s.add_development_dependency 'coveralls' s.add_runtime_dependency 'net-ldap', '~> 0.3' - s.add_runtim...
Update for final version of CASino 3.0
diff --git a/nap.gemspec b/nap.gemspec index abc1234..def5678 100644 --- a/nap.gemspec +++ b/nap.gemspec @@ -1,15 +1,16 @@ Gem::Specification.new do |spec| spec.name = 'nap' spec.version = '0.4' - + spec.author = "Manfred Stienstra" spec.email = "manfred@fngtps.com" spec.description = <<-EOF - Nap...
Fix the gem description in the gemspec. Add development dependencies.
diff --git a/webadmin/start.rb b/webadmin/start.rb index abc1234..def5678 100644 --- a/webadmin/start.rb +++ b/webadmin/start.rb @@ -20,12 +20,12 @@ revision = params[:revision].ergo.to_s[/(\w+)/, 1] @command = nil - common_restart = %{rake RAILS_ENV=production clear && touch #{RESTART_TXT}} + common_restart =...
Update webadmin to use bundler.
diff --git a/lib/dragonfly/config/r_magick_images.rb b/lib/dragonfly/config/r_magick_images.rb index abc1234..def5678 100644 --- a/lib/dragonfly/config/r_magick_images.rb +++ b/lib/dragonfly/config/r_magick_images.rb @@ -20,6 +20,15 @@ process :thumb, geometry encode format if format ...
Add some cool shortcuts for encoding
diff --git a/app/controllers/games_controller.rb b/app/controllers/games_controller.rb index abc1234..def5678 100644 --- a/app/controllers/games_controller.rb +++ b/app/controllers/games_controller.rb @@ -1,5 +1,9 @@ class GamesController < ApplicationController before_filter :lookup_user + + def new + redirect_...
Refactor ordering of GameController methods to be lifecycle order
diff --git a/app/controllers/rates_controller.rb b/app/controllers/rates_controller.rb index abc1234..def5678 100644 --- a/app/controllers/rates_controller.rb +++ b/app/controllers/rates_controller.rb @@ -8,8 +8,9 @@ rate_creator.call if !rate_creator.success? flash[:error] = rate_creator.errors + ...
Add notice that rate was succesfully created
diff --git a/descendants_tracker.gemspec b/descendants_tracker.gemspec index abc1234..def5678 100644 --- a/descendants_tracker.gemspec +++ b/descendants_tracker.gemspec @@ -13,7 +13,7 @@ gem.require_paths = %w[lib] gem.files = `git ls-files`.split($/) - gem.test_files = `git ls-files -- {spe...
Change test_files specification to be more precise
diff --git a/app/controllers/votes_controller.rb b/app/controllers/votes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/votes_controller.rb +++ b/app/controllers/votes_controller.rb @@ -1,9 +1,20 @@ class VotesController < ApplicationController def create + if logged_in + @vote = Vote.wh...
Reconfigure Vote controller to be DRY and accept JSON Requests from Vote Backbone model -Rewrite vote_params method to exclude is_upvote (allows for searching if incoming vote already exists without id) -Add upvote_param method that allows for setting of solely the is_upvote attribute -Create a private save_vote method...
diff --git a/app/controllers/channels/adm/projects_controller.rb b/app/controllers/channels/adm/projects_controller.rb index abc1234..def5678 100644 --- a/app/controllers/channels/adm/projects_controller.rb +++ b/app/controllers/channels/adm/projects_controller.rb @@ -11,8 +11,8 @@ before_filter do - @channel ...
Remove current_user trustee constraint from channels administration.
diff --git a/app/models/effective/style_guide.rb b/app/models/effective/style_guide.rb index abc1234..def5678 100644 --- a/app/models/effective/style_guide.rb +++ b/app/models/effective/style_guide.rb @@ -1,38 +1,34 @@ module Effective - class StyleGuide < ActiveRecord::Base - acts_as_asset_box :files => 1..6 if de...
Rework model to use ActiveModel::Model instead of hacks
diff --git a/lib/sepa_clearer/deutsche_bundesbank.rb b/lib/sepa_clearer/deutsche_bundesbank.rb index abc1234..def5678 100644 --- a/lib/sepa_clearer/deutsche_bundesbank.rb +++ b/lib/sepa_clearer/deutsche_bundesbank.rb @@ -9,10 +9,10 @@ service_b2b: :b2b } - def data(fi...
Use relative path to determine location of data file
diff --git a/iban-tools.gemspec b/iban-tools.gemspec index abc1234..def5678 100644 --- a/iban-tools.gemspec +++ b/iban-tools.gemspec @@ -3,9 +3,10 @@ s.summary = "IBAN validator" s.name = 'iban-tools' s.version = '0.0.1.1' + s.authors = ["Iulian Dogariu"] + s.email = ["code@iuliandogariu.com"] s.requirem...
Fix some gem build warnings: add author and email, rm autorequire
diff --git a/server/app/controllers/application_controller.rb b/server/app/controllers/application_controller.rb index abc1234..def5678 100644 --- a/server/app/controllers/application_controller.rb +++ b/server/app/controllers/application_controller.rb @@ -3,7 +3,6 @@ class ApplicationController < ActionController::B...
Remove protect_from_forgery setting since our POSTs generally won't come from web forms.
diff --git a/examples/active_record/server.rb b/examples/active_record/server.rb index abc1234..def5678 100644 --- a/examples/active_record/server.rb +++ b/examples/active_record/server.rb @@ -20,7 +20,7 @@ end post '/shouts' do - Shout.create :body => params['body'] + Shout.create :body => params[:body] ...
Change the activerecord example to use indifferent feature
diff --git a/plugins/chef/chef_client.rb b/plugins/chef/chef_client.rb index abc1234..def5678 100644 --- a/plugins/chef/chef_client.rb +++ b/plugins/chef/chef_client.rb @@ -10,21 +10,29 @@ # Released under the same terms as Sensu (the MIT license); see LICENSE # for details. -`which tasklist` -case -when $? == 0 - ...
Use CLI framework in the chef-client check
diff --git a/app/controllers/life_highlights_controller.rb b/app/controllers/life_highlights_controller.rb index abc1234..def5678 100644 --- a/app/controllers/life_highlights_controller.rb +++ b/app/controllers/life_highlights_controller.rb @@ -1,11 +1,19 @@ class LifeHighlightsController < MyplaceonlineController + d...
Sort life highlights by time and show time in bubble
diff --git a/test/exception_test.rb b/test/exception_test.rb index abc1234..def5678 100644 --- a/test/exception_test.rb +++ b/test/exception_test.rb @@ -13,13 +13,13 @@ assert_equal 5, exc.bindings.first.source_location.last end - test 'bindings goes down the_stack' do + test 'bindings goes down the stack' d...
Fix a few test names in ExceptionTest
diff --git a/lib/artery/config.rb b/lib/artery/config.rb index abc1234..def5678 100644 --- a/lib/artery/config.rb +++ b/lib/artery/config.rb @@ -8,11 +8,11 @@ # Ability to redefine message class (for example, for non-activerecord applications) def message_class - @message_class || Message + ...
Fix strange problems with class discovering
diff --git a/lib/bandicoot/dsl.rb b/lib/bandicoot/dsl.rb index abc1234..def5678 100644 --- a/lib/bandicoot/dsl.rb +++ b/lib/bandicoot/dsl.rb @@ -11,7 +11,7 @@ end def paginate_url(url, next_page_css_path:) - self.next_page_path = next_page_path + self.next_page_css_path = next_page_css_path ...
Rename next page css path
diff --git a/coderwall_api.gemspec b/coderwall_api.gemspec index abc1234..def5678 100644 --- a/coderwall_api.gemspec +++ b/coderwall_api.gemspec @@ -6,6 +6,7 @@ gem.name = 'coderwall_api' gem.version = Coderwall::VERSION.dup gem.authors = ['Kenichi Kamiya'] + gem.licenses = ['MIT'] ...
Add licenses into gemspec. For new UI of rubygems.org
diff --git a/lib/core_ext/file.rb b/lib/core_ext/file.rb index abc1234..def5678 100644 --- a/lib/core_ext/file.rb +++ b/lib/core_ext/file.rb @@ -0,0 +1,17 @@+# encoding: utf-8 + +class File + # determine whether a String path is absolute. + # @example + # File.absolute_path?('foo') #=> false + # File.absolute_p...
Add File::absolute_path? as a core_ext
diff --git a/lib/cxml/item_out.rb b/lib/cxml/item_out.rb index abc1234..def5678 100644 --- a/lib/cxml/item_out.rb +++ b/lib/cxml/item_out.rb @@ -11,7 +11,7 @@ @unit_price = @item_detail['UnitPrice'] @unit_of_measure = @item_detail['UnitOfMeasure'] - @shipping = data['Shipping'] + @shipp...
Make Shipping optional in ItemOut
diff --git a/railseventstore.org/config.rb b/railseventstore.org/config.rb index abc1234..def5678 100644 --- a/railseventstore.org/config.rb +++ b/railseventstore.org/config.rb @@ -8,5 +8,21 @@ set :markdown_engine, :redcarpet set :res_version, File.read('../RES_VERSION') +helpers do + def version_above(version_str...
Set of documentation helpers regarding applicable version. Use as follows: - rename page from page.html.md to page.html.md.erb - enclose paragraph in <% in_version_above('0.28.0') do %> ... <% end %> block Also possible to use <% in_version_at_most('0.28.0') do %> or conditional in <% if version_above('0.28.0') %> ...
diff --git a/spec/features/bootstrap_in_azure_feature_spec.rb b/spec/features/bootstrap_in_azure_feature_spec.rb index abc1234..def5678 100644 --- a/spec/features/bootstrap_in_azure_feature_spec.rb +++ b/spec/features/bootstrap_in_azure_feature_spec.rb @@ -0,0 +1,32 @@+require "rails_helper" +require "velum/instance_ty...
Add a feature spec for building cluster in Azure Most of the content is covered in the cloud_cluster model, but there are a few differentiators that should be checked.
diff --git a/spec/lib/bidu/house/report/report_config_spec.rb b/spec/lib/bidu/house/report/report_config_spec.rb index abc1234..def5678 100644 --- a/spec/lib/bidu/house/report/report_config_spec.rb +++ b/spec/lib/bidu/house/report/report_config_spec.rb @@ -9,5 +9,13 @@ expect(subject.build(parameters)).to be_a(...
Add spec over new report type
diff --git a/spec/views/layouts/application.html.haml_spec.rb b/spec/views/layouts/application.html.haml_spec.rb index abc1234..def5678 100644 --- a/spec/views/layouts/application.html.haml_spec.rb +++ b/spec/views/layouts/application.html.haml_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' describe "layouts/applicatio...
Reduce number of pending specs
diff --git a/bosh-dev/lib/bosh/dev/bat_helper.rb b/bosh-dev/lib/bosh/dev/bat_helper.rb index abc1234..def5678 100644 --- a/bosh-dev/lib/bosh/dev/bat_helper.rb +++ b/bosh-dev/lib/bosh/dev/bat_helper.rb @@ -37,10 +37,6 @@ prepare_directories - sanitize_directories - - prepare_directories - pipe...
Remove duplicate method calls, probably from a bad merge
diff --git a/lib/gitlab/logger.rb b/lib/gitlab/logger.rb index abc1234..def5678 100644 --- a/lib/gitlab/logger.rb +++ b/lib/gitlab/logger.rb @@ -14,13 +14,9 @@ def self.read_latest path = Rails.root.join("log", file_name) - self.build unless File.exist?(path) - tail_output, _ = Gitlab::Popen.pope...
Fix a potential timeout in `Gitlab::Logger.read_latest` If this method was called for a file that didn't exist, we attempted to first `build` it. But if the file wasn't writeable, such as a symlink pointing to an unmounted filesystem, the method would just hang and eventually timeout. Further, this was entirely point...
diff --git a/lib/imminence_api.rb b/lib/imminence_api.rb index abc1234..def5678 100644 --- a/lib/imminence_api.rb +++ b/lib/imminence_api.rb @@ -1,13 +1,6 @@-require 'json_utils' +require 'gds_api' -class ImminenceApi - - include JsonUtils - - def initialize(endpoint) - @endpoint = endpoint - end - +class Immin...
Update imminence API to use GdsApi
diff --git a/lib/ls_stash/rest.rb b/lib/ls_stash/rest.rb index abc1234..def5678 100644 --- a/lib/ls_stash/rest.rb +++ b/lib/ls_stash/rest.rb @@ -11,8 +11,8 @@ request = Net::HTTP::Get.new(uri.request_uri) request.basic_auth(options[:user], options[:password]) if options[:prettify] + JSON.pretty_generate(JSON...
Fix conditions in if statement for prettify option.
diff --git a/lib/apple-news/article.rb b/lib/apple-news/article.rb index abc1234..def5678 100644 --- a/lib/apple-news/article.rb +++ b/lib/apple-news/article.rb @@ -13,7 +13,7 @@ optional_properties :is_sponsored, :is_preview, :accessory_text, :revision optional_property :links, {} - attr_reader :id + ...
Set state and share URL
diff --git a/lib/attr_cleaner/model.rb b/lib/attr_cleaner/model.rb index abc1234..def5678 100644 --- a/lib/attr_cleaner/model.rb +++ b/lib/attr_cleaner/model.rb @@ -1,24 +1,23 @@ module AttrCleaner module Model extend ActiveSupport::Concern - - included do - alias_method_chain :write_attribute, :cleaner...
Change implementation to avoid alias_method_chain
diff --git a/lib/ruby_cue_lang.rb b/lib/ruby_cue_lang.rb index abc1234..def5678 100644 --- a/lib/ruby_cue_lang.rb +++ b/lib/ruby_cue_lang.rb @@ -7,15 +7,8 @@ module Cue - # This lets us reference cue classes as cue.lang.SentenceIterator, - # rather than Java::CueLang::SentenceIterator. - def cue - Java::Cue...
Use explicit Java modules, to simplify accessing cue packages from both Module-level and instance-level methods; added TODOs
diff --git a/lib/cookie_monster/jar.rb b/lib/cookie_monster/jar.rb index abc1234..def5678 100644 --- a/lib/cookie_monster/jar.rb +++ b/lib/cookie_monster/jar.rb @@ -9,6 +9,8 @@ end def [](key) + key = key.to_s + if @response.cookies[key] cookie = @response.cookies[key] elsif @requ...
Call `to_s` on key before looking for it in cookies hashes.
diff --git a/lib/tabnav/navbar.rb b/lib/tabnav/navbar.rb index abc1234..def5678 100644 --- a/lib/tabnav/navbar.rb +++ b/lib/tabnav/navbar.rb @@ -29,7 +29,7 @@ @tabs.each do |tab| contents += tab.render end - contents + contents.html_safe end end end
Use html_safe to make tabnav work with Rails3.
diff --git a/lib/gnip-stream/stream.rb b/lib/gnip-stream/stream.rb index abc1234..def5678 100644 --- a/lib/gnip-stream/stream.rb +++ b/lib/gnip-stream/stream.rb @@ -26,7 +26,6 @@ def connect EM.run do - EM.threadpool_size = 5 http = EM::HttpRequest.new(@url, :inactivity_timeout => 0).get(:h...
Revert "limit the size of the EM threadpool." This reverts commit 85adceda36f8a68b3fc9a9aa0efb419a8a595812.
diff --git a/Library/Formula/weechat.rb b/Library/Formula/weechat.rb index abc1234..def5678 100644 --- a/Library/Formula/weechat.rb +++ b/Library/Formula/weechat.rb @@ -11,7 +11,10 @@ def install #FIXME: Compiling perl module doesn't work #FIXME: GnuTLS support isn't detected - system "cmake", "-DDISABLE...
Fix Weechat always installing to /usr/local The WeeChat devs don't know about CMAKE_INSTALL_PREFIX apparently, someone should tell them. I won't. I plan on just sitting back and shacking my head side-to-side instead.
diff --git a/lib/liquid/tags/assign.rb b/lib/liquid/tags/assign.rb index abc1234..def5678 100644 --- a/lib/liquid/tags/assign.rb +++ b/lib/liquid/tags/assign.rb @@ -12,10 +12,6 @@ class Assign < Tag Syntax = /(#{VariableSignature}+)\s*=\s*(.*)\s*/om - def self.syntax_error_translation_key - "errors.syn...
Use String literal instead of using a class method The class method string definition is not needed here, so it can be removed.
diff --git a/lib/spontaneous/sequel.rb b/lib/spontaneous/sequel.rb index abc1234..def5678 100644 --- a/lib/spontaneous/sequel.rb +++ b/lib/spontaneous/sequel.rb @@ -1,6 +1,17 @@ require "sequel" Sequel.extension :inflector + +# See http://sequel.jeremyevans.net/rdoc/classes/Sequel/Timezones.html +# UTC is more perfo...
Set Sequel's timezones to UTC
diff --git a/lib/spork/run_strategy.rb b/lib/spork/run_strategy.rb index abc1234..def5678 100644 --- a/lib/spork/run_strategy.rb +++ b/lib/spork/run_strategy.rb @@ -28,7 +28,11 @@ protected def self.factory(test_framework) - Spork::RunStrategy::Forking.new(test_framework) + if Spork::RunStrategy::For...
Use magazine strategy if forking not available. TODO: add check for JRuby. It will NOT work with magazine.
diff --git a/test/integration/api_operations/list_test.rb b/test/integration/api_operations/list_test.rb index abc1234..def5678 100644 --- a/test/integration/api_operations/list_test.rb +++ b/test/integration/api_operations/list_test.rb @@ -7,19 +7,19 @@ should "retrieve districts" do VCR.use_cassette("distric...
Make the list test idiomatic ruby Use .each instead of for...in; don't use parentheses at the end of method calls that don't have arguments
diff --git a/app/models/commit.rb b/app/models/commit.rb index abc1234..def5678 100644 --- a/app/models/commit.rb +++ b/app/models/commit.rb @@ -9,7 +9,7 @@ end def repository_dir - "/home/todd/arb/arb" + "/files/git/repos/review/arb" end def in_repo
Change repos dir to arb review dir on filer
diff --git a/lib/clio_client/models/activity.rb b/lib/clio_client/models/activity.rb index abc1234..def5678 100644 --- a/lib/clio_client/models/activity.rb +++ b/lib/clio_client/models/activity.rb @@ -17,6 +17,7 @@ has_association :user, ClioClient::User + has_association :bill, ...
Add bill association to activities
diff --git a/app/models/toilet.rb b/app/models/toilet.rb index abc1234..def5678 100644 --- a/app/models/toilet.rb +++ b/app/models/toilet.rb @@ -11,6 +11,7 @@ validates :building, presence: true validates :floor, presence: true + validate :floor_belongs_to_building belongs_to :building belongs_to :floor...
Validate that the restroom's floor and building match up.
diff --git a/FileKit.podspec b/FileKit.podspec index abc1234..def5678 100644 --- a/FileKit.podspec +++ b/FileKit.podspec @@ -1,12 +1,13 @@ Pod::Spec.new do |s| - s.name = "FileKit" - s.version = "1.5.0" - s.summary = "Simple and expressive file management in Swift."...
Set watchOS deployment target in podspec
diff --git a/lib/stripmem/websocket.rb b/lib/stripmem/websocket.rb index abc1234..def5678 100644 --- a/lib/stripmem/websocket.rb +++ b/lib/stripmem/websocket.rb @@ -5,11 +5,14 @@ class WebSocket def initialize(channel) @channel = channel + @data = [] + @channel.subscribe { |msg| @data << msg } ...
Send all data on client connection.
diff --git a/config/application.rb b/config/application.rb index abc1234..def5678 100644 --- a/config/application.rb +++ b/config/application.rb @@ -2,13 +2,13 @@ require 'rails/all' +require 'figs' +# Don't run this initializer on travis. +Figs.load(stage: Rails.env) unless ENV['TRAVIS'] + # Require the gems list...
Load env vars before bundle
diff --git a/lib/tasks/assignment.rake b/lib/tasks/assignment.rake index abc1234..def5678 100644 --- a/lib/tasks/assignment.rake +++ b/lib/tasks/assignment.rake @@ -0,0 +1,30 @@+# frozen_string_literal: true + +def generate_generic_sandbox_url(assignment) + # If there's already a sandbox_url, do nothing + return fals...
Add rake task to backfill sandbox_urls
diff --git a/lib/image_optim/worker/gifsicle.rb b/lib/image_optim/worker/gifsicle.rb index abc1234..def5678 100644 --- a/lib/image_optim/worker/gifsicle.rb +++ b/lib/image_optim/worker/gifsicle.rb @@ -32,7 +32,7 @@ args.unshift('--interlace') if interlace args.unshift('--careful') if careful - ...
Use interpolation with the --optimize argument
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -18,6 +18,8 @@ end def markdown(text) + return text if text.blank? + # See https://github.com/vmg/redcarpet f...
Make markdown helper safer to use Avoid exception if text is nil
diff --git a/lib/veritas/support/optimizable.rb b/lib/veritas/support/optimizable.rb index abc1234..def5678 100644 --- a/lib/veritas/support/optimizable.rb +++ b/lib/veritas/support/optimizable.rb @@ -4,6 +4,14 @@ module Optimizable include Immutable + # Hook called when module is included + # + # @pa...
Make sure that Optimizable.included is documented
diff --git a/app/models/appendable/reaction.rb b/app/models/appendable/reaction.rb index abc1234..def5678 100644 --- a/app/models/appendable/reaction.rb +++ b/app/models/appendable/reaction.rb @@ -16,7 +16,8 @@ # rubocop:enable Rails/SkipsModelValidations def notification_type(*_args) - Notification::CommentS...
Fix `CommentSmile` notification type not being returned
diff --git a/test/unit/stamp_file_test.rb b/test/unit/stamp_file_test.rb index abc1234..def5678 100644 --- a/test/unit/stamp_file_test.rb +++ b/test/unit/stamp_file_test.rb @@ -0,0 +1,42 @@+require 'support/test_case' +require 'support/fixture_config' +require 'jekyll/minibundle/stamp_file' + +module Jekyll::Minibundle...
Add test for StampFile's behavior in markup and write phases
diff --git a/guides/lib/filters/info_boxes.rb b/guides/lib/filters/info_boxes.rb index abc1234..def5678 100644 --- a/guides/lib/filters/info_boxes.rb +++ b/guides/lib/filters/info_boxes.rb @@ -13,7 +13,11 @@ content = content.gsub(/^\$\$\$\n(.*?)\$\$\$/m) do "<p>**************** TODO ****************</p>" ...
Add --- filter for adding filenames to code examples
diff --git a/lib/blog/engine.rb b/lib/blog/engine.rb index abc1234..def5678 100644 --- a/lib/blog/engine.rb +++ b/lib/blog/engine.rb @@ -1,5 +1,12 @@ module Blog class Engine < ::Rails::Engine isolate_namespace Blog + + require 'rubygems' + require 'kaminari' + + if !Rails.env.production? + requir...
Add some libs: pry, kaminari, sass-rails Adds sass-rails since it was needed to run tests, and pry for development/debugging purposes.
diff --git a/spec/defines/splunk_conf_spec.rb b/spec/defines/splunk_conf_spec.rb index abc1234..def5678 100644 --- a/spec/defines/splunk_conf_spec.rb +++ b/spec/defines/splunk_conf_spec.rb @@ -1,47 +1,49 @@ require 'spec_helper' describe 'splunk_conf' do + stanza = 'monitor:///foo/bar/baz.log' - context 'basic t...
Refactor specs to make better spec output
diff --git a/spec/integration/metrics_spec.rb b/spec/integration/metrics_spec.rb index abc1234..def5678 100644 --- a/spec/integration/metrics_spec.rb +++ b/spec/integration/metrics_spec.rb @@ -0,0 +1,35 @@+require 'spec_helper' + +module Librato + describe Metrics do + before(:all) { prep_integration_tests } + + ...
Add integration tests for metric listing.
diff --git a/spec/pontifex/key_stream_spec.rb b/spec/pontifex/key_stream_spec.rb index abc1234..def5678 100644 --- a/spec/pontifex/key_stream_spec.rb +++ b/spec/pontifex/key_stream_spec.rb @@ -0,0 +1,21 @@+require 'spec_helper' + +module Pontifex + describe KeyStream do + describe "#new" do + let(:key_stream) ...
Add some failing tests for the KeyStream class
diff --git a/recipes/zookeeper_status.rb b/recipes/zookeeper_status.rb index abc1234..def5678 100644 --- a/recipes/zookeeper_status.rb +++ b/recipes/zookeeper_status.rb @@ -2,9 +2,19 @@ # Cookbook Name:: cerner_kafka # Recipe:: zookeeper_status - +<<-comment execute 'check zookeeper' do action :run command " ...
Change way to check Zookeeper service
diff --git a/lib/hashie/hash.rb b/lib/hashie/hash.rb index abc1234..def5678 100644 --- a/lib/hashie/hash.rb +++ b/lib/hashie/hash.rb @@ -4,7 +4,7 @@ # A Hashie Hash is simply a Hash that has convenience # functions baked in such as stringify_keys that may # not be available in all libraries. - class Hash < Has...
Make explicit the reference to standard Hash
diff --git a/Formula/akonadi.rb b/Formula/akonadi.rb index abc1234..def5678 100644 --- a/Formula/akonadi.rb +++ b/Formula/akonadi.rb @@ -1,9 +1,9 @@ require 'formula' class Akonadi <Formula - url 'http://download.akonadi-project.org/akonadi-1.2.1.tar.bz2' + url 'http://download.akonadi-project.org/akonadi-1.3.0.ta...
Update Akonadi formula to 1.3.0.
diff --git a/lib/playa/track.rb b/lib/playa/track.rb index abc1234..def5678 100644 --- a/lib/playa/track.rb +++ b/lib/playa/track.rb @@ -23,7 +23,7 @@ end def title - id_tags.tag.title || '' + id_tags.tag.title || filename end def artist
Return the filename if the ID3 tags have no title.
diff --git a/app/uploaders/outcome_uploader.rb b/app/uploaders/outcome_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/outcome_uploader.rb +++ b/app/uploaders/outcome_uploader.rb @@ -1,5 +1,6 @@ class OutcomeUploader < Shrine plugin :delete_promoted + plugin :determine_mime_type plugin :validation_...
:wrench: Determine MIME type from file content by determine_mime_type Fix for shrine gem warning
diff --git a/lib/generators/redactor/templates/mongoid/carrierwave/redactor/document.rb b/lib/generators/redactor/templates/mongoid/carrierwave/redactor/document.rb index abc1234..def5678 100644 --- a/lib/generators/redactor/templates/mongoid/carrierwave/redactor/document.rb +++ b/lib/generators/redactor/templates/mong...
Address a bug where as_json triggered thumb, url(:thumb) on Document
diff --git a/test/unit/services/service_listeners/attachment_replacement_id_updater_test.rb b/test/unit/services/service_listeners/attachment_replacement_id_updater_test.rb index abc1234..def5678 100644 --- a/test/unit/services/service_listeners/attachment_replacement_id_updater_test.rb +++ b/test/unit/services/service...
Update AttachmentReplacementIdUpdaterTest to stub worker We've extracted the logic of this service listener into the AssetManagerAttachmentReplacementIdUpdateWorker. Update the tests so that we simply assert that the worker has been called if the conditions are met.
diff --git a/app/controllers/api/internal/activities_controller.rb b/app/controllers/api/internal/activities_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/internal/activities_controller.rb +++ b/app/controllers/api/internal/activities_controller.rb @@ -9,7 +9,7 @@ activities = if usernam...
Return Activity.none when user is not found
diff --git a/mgit.gemspec b/mgit.gemspec index abc1234..def5678 100644 --- a/mgit.gemspec +++ b/mgit.gemspec @@ -18,9 +18,9 @@ s.required_ruby_version = '>= 1.9.3' - s.add_dependency 'colorize', '~> 0.7.1' - s.add_dependency 'highline', '~> 1.6.21' - s.add_dependency 'xdg', '~> 2.2.3' + s.add_dependency 'colo...
Fix warnings about overly strict dependencies now.
diff --git a/test/controllers/static_pages_controller_test.rb b/test/controllers/static_pages_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/static_pages_controller_test.rb +++ b/test/controllers/static_pages_controller_test.rb @@ -3,6 +3,11 @@ class StaticPagesControllerTest < ActionDispatch::...
Add the routing test for root path
diff --git a/lib/rubygems/tasks/build/gem.rb b/lib/rubygems/tasks/build/gem.rb index abc1234..def5678 100644 --- a/lib/rubygems/tasks/build/gem.rb +++ b/lib/rubygems/tasks/build/gem.rb @@ -51,7 +51,7 @@ def build(path,gemspec) builder = ::Gem::Builder.new(gemspec) - FileUtils.mv builder.bu...
Use the Rake FileUtils methods, now that we're hooking the verbose output.
diff --git a/middleman-core/lib/middleman-core/extensions/relative_assets.rb b/middleman-core/lib/middleman-core/extensions/relative_assets.rb index abc1234..def5678 100644 --- a/middleman-core/lib/middleman-core/extensions/relative_assets.rb +++ b/middleman-core/lib/middleman-core/extensions/relative_assets.rb @@ -1,6...
Add Woff2 to relative assets extension
diff --git a/lib/travis/services/find_log.rb b/lib/travis/services/find_log.rb index abc1234..def5678 100644 --- a/lib/travis/services/find_log.rb +++ b/lib/travis/services/find_log.rb @@ -31,7 +31,7 @@ private def logs_api @logs_api ||= Travis::LogsApi.new( url: Travis.config.logs_api.url, - ...
Rename straggling logs API config key
diff --git a/lib/patches/controller/projects_controller_patch.rb b/lib/patches/controller/projects_controller_patch.rb index abc1234..def5678 100644 --- a/lib/patches/controller/projects_controller_patch.rb +++ b/lib/patches/controller/projects_controller_patch.rb @@ -3,7 +3,7 @@ included do before_render :loa...
Remove unnecessary only condition of ProjectsControllerPatch