diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/models/team_invitation.rb b/app/models/team_invitation.rb index abc1234..def5678 100644 --- a/app/models/team_invitation.rb +++ b/app/models/team_invitation.rb @@ -10,7 +10,7 @@ scope :requests_to_join, -> { where(type: INVITATION_REQUEST) } scope :invitations, -> { where(type: INVITED_BY_TEAM) } ...
Fix uniqueness of team invitations
diff --git a/app/models/search_crossref.rb b/app/models/search_crossref.rb index abc1234..def5678 100644 --- a/app/models/search_crossref.rb +++ b/app/models/search_crossref.rb @@ -1,11 +1,15 @@ class SearchCrossref def initialize(query, opts = {}) @query = query[:everything] + @page = query[:current_page] |...
Add pagination support to CrossRef's API wrapper.
diff --git a/spec/support/custom_matchers.rb b/spec/support/custom_matchers.rb index abc1234..def5678 100644 --- a/spec/support/custom_matchers.rb +++ b/spec/support/custom_matchers.rb @@ -5,12 +5,12 @@ failure_message_for_should do |actual| actual = 'nil' unless actual - "expected that #{actual} would be n...
Improve failure messages for be_now and be_at
diff --git a/lib/adhearsion/xmpp/connection.rb b/lib/adhearsion/xmpp/connection.rb index abc1234..def5678 100644 --- a/lib/adhearsion/xmpp/connection.rb +++ b/lib/adhearsion/xmpp/connection.rb @@ -1,4 +1,5 @@-require 'blather/client' +require 'blather/client/client' +require 'blather/client/dsl' module Adhearsion ...
[BUGFIX] Fix require of blather/client stuff, blather/client.rb is an executable script now?
diff --git a/spec/models/round_spec.rb b/spec/models/round_spec.rb index abc1234..def5678 100644 --- a/spec/models/round_spec.rb +++ b/spec/models/round_spec.rb @@ -14,4 +14,10 @@ round.turns << old_turn expect(round.last_turn).to eq new_turn end + + it 'marks itself as finished' do + expect(round.is_ov...
Add round model specs for finish and is_over method
diff --git a/spec/outbox/rails_spec.rb b/spec/outbox/rails_spec.rb index abc1234..def5678 100644 --- a/spec/outbox/rails_spec.rb +++ b/spec/outbox/rails_spec.rb @@ -2,6 +2,6 @@ describe Outbox::Rails do it 'has a version number' do - Outbox::Rails::VERSION.should_not be_nil + expect(Outbox::Rails::VERSION).t...
Use newer version of rspec syntax
diff --git a/lib/discourse_api/client.rb b/lib/discourse_api/client.rb index abc1234..def5678 100644 --- a/lib/discourse_api/client.rb +++ b/lib/discourse_api/client.rb @@ -12,4 +12,5 @@ get :topics_hot => "/hot.json" get :categories => "/categories.json" + get :topic => "/t/:topic_id.json" end
Add the "get a single topic" endpoint to the API
diff --git a/lib/editor_configuration.rb b/lib/editor_configuration.rb index abc1234..def5678 100644 --- a/lib/editor_configuration.rb +++ b/lib/editor_configuration.rb @@ -1,5 +1,5 @@ class EditorConfiguration < Configuration preference :enabled, :boolean, :default => true - preference :current_editor, :string, :d...
Switch default editor ofr WYMEditor
diff --git a/app/models/node.rb b/app/models/node.rb index abc1234..def5678 100644 --- a/app/models/node.rb +++ b/app/models/node.rb @@ -1,6 +1,6 @@ class Node < ActiveRecord::Base - has_many :documents - has_many :settings, :class_name => 'NodeSetting' + has_many :documents, :dependent => :destroy + has_many :sett...
Destroy dependent document and settings
diff --git a/app/models/rule.rb b/app/models/rule.rb index abc1234..def5678 100644 --- a/app/models/rule.rb +++ b/app/models/rule.rb @@ -1,5 +1,2 @@ class Rule < ActiveRecord::Base - # strange naming b/c :transaction is a reserved method in AR::B - belongs_to :transact, class_name: 'Transaction', foreign_key: 'transa...
Remove junk from Rule model
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -12,4 +12,6 @@ # class User < ActiveRecord::Base + def self.find_or_create_from_auth_hash(auth_hash) + end end
Add Method in User Model
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,4 +1,6 @@ class User < ActiveRecord::Base include ActiveModel::Validations validates :name, :city, :email, presence: true + validates :email, uniqueness: { case_sensitive: false ...
Add uniqueness validation for email on create & update
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,5 +1,13 @@ class User < ApplicationRecord has_many :documents + before_save :set_civic_json + validates :address, :first_name, :last_name, :zip_code, :city, :state, presence: t...
Add set_civic_json method to User
diff --git a/Casks/zero-xed.rb b/Casks/zero-xed.rb index abc1234..def5678 100644 --- a/Casks/zero-xed.rb +++ b/Casks/zero-xed.rb @@ -0,0 +1,7 @@+class ZeroXed < Cask + url 'http://www.suavetech.com/cgi-bin/download.cgi?0xED.tar.bz2' + homepage 'http://www.suavetech.com/0xed/' + version '1.1.3' + sha1 'b3dac8ac99386...
Add 0xed to homebrew cask. 0xED is a native OS X hex editor based on the Cocoa framework.
diff --git a/backend/app/controllers/comable/admin/user_sessions_controller.rb b/backend/app/controllers/comable/admin/user_sessions_controller.rb index abc1234..def5678 100644 --- a/backend/app/controllers/comable/admin/user_sessions_controller.rb +++ b/backend/app/controllers/comable/admin/user_sessions_controller.rb...
Fix the problem that cannot call `page_name` method
diff --git a/lib/middleman-disqus/extension.rb b/lib/middleman-disqus/extension.rb index abc1234..def5678 100644 --- a/lib/middleman-disqus/extension.rb +++ b/lib/middleman-disqus/extension.rb @@ -11,7 +11,7 @@ end def self.options(options = {}) - options = options.to_h.map do |k,obj| + options = o...
Fix issues with Ruby 1.9.3. `#to_h` does exist on `Middleman::Configuration::ConfigurationManager`. `#to_h` is known as `#to_hash` on Hash.
diff --git a/lib/timetable/downloader.rb b/lib/timetable/downloader.rb index abc1234..def5678 100644 --- a/lib/timetable/downloader.rb +++ b/lib/timetable/downloader.rb @@ -2,7 +2,7 @@ module Timetable REMOTE_HOST = "www.doc.ic.ac.uk" - REMOTE_PATH = "internal/timetables/timetable/:season/class" + REMOTE_PATH = ...
Change the source URL for the HTML timetables to no longer use drafts
diff --git a/phil.gemspec b/phil.gemspec index abc1234..def5678 100644 --- a/phil.gemspec +++ b/phil.gemspec @@ -11,11 +11,11 @@ s.authors = ["Cameron Daigle"] s.email = ["cameron@hashrocket.com"] - s.description = "Phil makes it easy to generate content for your UI mockups." + s.description = "Phil is a colle...
Update gemspec description and summary
diff --git a/app/workers/gamedev_worker.rb b/app/workers/gamedev_worker.rb index abc1234..def5678 100644 --- a/app/workers/gamedev_worker.rb +++ b/app/workers/gamedev_worker.rb @@ -21,7 +21,8 @@ user_display_name: question.owner[:display_name], body_html: question.body, source_url: question.link, - ...
Tag GameDev external posts with a tag of "question"
diff --git a/graphql-batch.gemspec b/graphql-batch.gemspec index abc1234..def5678 100644 --- a/graphql-batch.gemspec +++ b/graphql-batch.gemspec @@ -18,6 +18,8 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] + spec.metadata['allowed_push_host'] = "https:/...
Add allowed_push_host to gemspec to fix release script
diff --git a/app/validators/renalware/patients/blood_pressure_validator.rb b/app/validators/renalware/patients/blood_pressure_validator.rb index abc1234..def5678 100644 --- a/app/validators/renalware/patients/blood_pressure_validator.rb +++ b/app/validators/renalware/patients/blood_pressure_validator.rb @@ -22,7 +22,7 ...
Fix BP diastolic < systolic comparison where one is a string Previously if diastolic was “100 “ and systolic “80” the former was interpretted as a string and the comparison raised `comparison of Integer with String failed`
diff --git a/engines/standard_tasks/spec/features/assign_reviewer_task_spec.rb b/engines/standard_tasks/spec/features/assign_reviewer_task_spec.rb index abc1234..def5678 100644 --- a/engines/standard_tasks/spec/features/assign_reviewer_task_spec.rb +++ b/engines/standard_tasks/spec/features/assign_reviewer_task_spec.rb...
Add another check around assigning reviewers just in case.
diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb index abc1234..def5678 100644 --- a/app/controllers/home_controller.rb +++ b/app/controllers/home_controller.rb @@ -26,8 +26,6 @@ :conditions => ['(created_at > ? OR updated_at > ?) and article_category_id = ?', cutoff, cutoff, @...
Remove commented code from home controller.
diff --git a/app/controllers/pets_controller.rb b/app/controllers/pets_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pets_controller.rb +++ b/app/controllers/pets_controller.rb @@ -20,20 +20,6 @@ # POST /pets # POST /pets.json def create - @pet = Pet.new(pet_params) - - respond_to do |...
Implement create action for PetsController
diff --git a/app/mailers/notification_mailer.rb b/app/mailers/notification_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/notification_mailer.rb +++ b/app/mailers/notification_mailer.rb @@ -1,17 +1,4 @@ class NotificationMailer < ApplicationMailer - - def validation_result(user, aru, validation_report, vali...
Remove obsolete method in mailer
diff --git a/app/serializers/root_serializer.rb b/app/serializers/root_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/root_serializer.rb +++ b/app/serializers/root_serializer.rb @@ -2,14 +2,17 @@ adapter Oat::Adapters::HAL schema do - link :accounts, + link :account, href: "/accou...
Update root links, notably rename `accounts` to `account`
diff --git a/spec/helpers/application_helper/buttons/iso_datastore_new_spec.rb b/spec/helpers/application_helper/buttons/iso_datastore_new_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/application_helper/buttons/iso_datastore_new_spec.rb +++ b/spec/helpers/application_helper/buttons/iso_datastore_new_spec.rb...
Remove unnecessary before(:all) call from a button spec
diff --git a/core/db/migrate/20130213191427_create_default_stock.rb b/core/db/migrate/20130213191427_create_default_stock.rb index abc1234..def5678 100644 --- a/core/db/migrate/20130213191427_create_default_stock.rb +++ b/core/db/migrate/20130213191427_create_default_stock.rb @@ -5,17 +5,12 @@ location = Spree::Sto...
Use `unscoped` when create stock items in migration By the time the migration runs the default scope with deleted_at was already defined so mocking acts_as_paranoid doesn't make any difference related to #3805
diff --git a/app/controllers/ajo_register/passwords_controller.rb b/app/controllers/ajo_register/passwords_controller.rb index abc1234..def5678 100644 --- a/app/controllers/ajo_register/passwords_controller.rb +++ b/app/controllers/ajo_register/passwords_controller.rb @@ -6,7 +6,13 @@ end def create - super +...
Add after sign up path
diff --git a/test/integration/search_test.rb b/test/integration/search_test.rb index abc1234..def5678 100644 --- a/test/integration/search_test.rb +++ b/test/integration/search_test.rb @@ -30,4 +30,13 @@ assert_selector '.ad_excerpt_list', count: 0 assert_text 'No hay anuncios que coincidan con la búsqueda esp...
Add a test for searching in the wrong section
diff --git a/spec/lib/oauth/invalid_token_response_spec.rb b/spec/lib/oauth/invalid_token_response_spec.rb index abc1234..def5678 100644 --- a/spec/lib/oauth/invalid_token_response_spec.rb +++ b/spec/lib/oauth/invalid_token_response_spec.rb @@ -5,49 +5,49 @@ module Doorkeeper::OAuth describe InvalidTokenResponse d...
Fix hound ci style violation. :cop:
diff --git a/lib/cars_api/in_memory/car_store.rb b/lib/cars_api/in_memory/car_store.rb index abc1234..def5678 100644 --- a/lib/cars_api/in_memory/car_store.rb +++ b/lib/cars_api/in_memory/car_store.rb @@ -39,7 +39,7 @@ def car_markers data.map do |car| - CarMarker.from(location, car, uni...
Fix typo: CarMarker -> CarMarkerFactory
diff --git a/lib/generators/spree_i18n/install/install_generator.rb b/lib/generators/spree_i18n/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/spree_i18n/install/install_generator.rb +++ b/lib/generators/spree_i18n/install/install_generator.rb @@ -4,8 +4,8 @@ class_option :auto_ru...
Add newline for append_file arguments in add_javascripts (install) Using append_file without a new line in add_javascripts() causes the file `all.js' to be saved without a new line at the end and making the next (different) plugin install fail to write valid data to this file. For example after installing spree_review...
diff --git a/lib/devise_password_filter/model.rb b/lib/devise_password_filter/model.rb index abc1234..def5678 100644 --- a/lib/devise_password_filter/model.rb +++ b/lib/devise_password_filter/model.rb @@ -7,7 +7,7 @@ def password_not_common if Rails.application.config.filter_passwords.include?(...
Fix use of add_to_base when adding error
diff --git a/lib/nehm/commands/search_command.rb b/lib/nehm/commands/search_command.rb index abc1234..def5678 100644 --- a/lib/nehm/commands/search_command.rb +++ b/lib/nehm/commands/search_command.rb @@ -14,7 +14,7 @@ 'Add track(s) to iTunes playlist with PLAYLIST name') add_option(:"-lim", '...
Edit help in 'search' command
diff --git a/config/initializers/rakwik.rb b/config/initializers/rakwik.rb index abc1234..def5678 100644 --- a/config/initializers/rakwik.rb +++ b/config/initializers/rakwik.rb @@ -1,4 +1,4 @@-if Rails.env.production? +if Rails.env.production? or ENV['RAKWIK'] Rails.application.config.middleware.use Rakwik::Tracker,...
Allow to start Rakwik in dev mode by enabling RAKWIK evn var.
diff --git a/SwiftSafe.podspec b/SwiftSafe.podspec index abc1234..def5678 100644 --- a/SwiftSafe.podspec +++ b/SwiftSafe.podspec @@ -2,10 +2,10 @@ Pod::Spec.new do |s| s.name = "SwiftSafe" - s.version = "0.1" + s.version = "2.0.0" s.summary = "Thread synchronization made easy." - s.h...
Fix error in .podspec file
diff --git a/test/integration/rails/nip_test.rb b/test/integration/rails/nip_test.rb index abc1234..def5678 100644 --- a/test/integration/rails/nip_test.rb +++ b/test/integration/rails/nip_test.rb @@ -2,22 +2,31 @@ require 'supermodel' require "nip_pesel_regon/integration/rails" -class Company < SuperModel::Base - ...
Add namespace for nip tests
diff --git a/ajw2.gemspec b/ajw2.gemspec index abc1234..def5678 100644 --- a/ajw2.gemspec +++ b/ajw2.gemspec @@ -6,8 +6,8 @@ Gem::Specification.new do |spec| spec.name = "ajw2" spec.version = Ajw2::VERSION - spec.authors = ["dtan4"] - spec.email = ["dtanshi45@gmail.com"] + spec.aut...
Fix author information to use ttlab account
diff --git a/dm-cassanda-adapter.gemspec b/dm-cassanda-adapter.gemspec index abc1234..def5678 100644 --- a/dm-cassanda-adapter.gemspec +++ b/dm-cassanda-adapter.gemspec @@ -15,6 +15,8 @@ gem.test_files = `git ls-files -- spec/{unit,integration}`.split($/) gem.extra_rdoc_files = %w[LICENSE README.md CONTRIBUT...
Add minimum required ruby version as 1.9.3 * This is mostly to trigger the build on travis, but the code has not been tested with anything below 1.9.3.
diff --git a/app/controllers/site_posts_controller.rb b/app/controllers/site_posts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/site_posts_controller.rb +++ b/app/controllers/site_posts_controller.rb @@ -16,6 +16,12 @@ end def site_id + # NOTE: env['SERVER_NAME'] よりも、 request.domain や + ...
Add a note for request.domain and request.subdomain
diff --git a/DeclarativeLayout.podspec b/DeclarativeLayout.podspec index abc1234..def5678 100644 --- a/DeclarativeLayout.podspec +++ b/DeclarativeLayout.podspec @@ -1,10 +1,14 @@ Pod::Spec.new do |s| s.name = 'DeclarativeLayout' s.version = '0.2.0' - s.summary = 'This library is a w...
Update Podspec with new descriptions
diff --git a/app/presenters/edition_diff_presenter.rb b/app/presenters/edition_diff_presenter.rb index abc1234..def5678 100644 --- a/app/presenters/edition_diff_presenter.rb +++ b/app/presenters/edition_diff_presenter.rb @@ -5,17 +5,18 @@ return attributes unless edition.present? Edition::TOP_LEVEL_FIELD...
Use symbols rather than strings for edition diff This is more consistent with the contents of the editions - eg routes and details have symbol keys within them.
diff --git a/app/services/firebase_cloud_messaging.rb b/app/services/firebase_cloud_messaging.rb index abc1234..def5678 100644 --- a/app/services/firebase_cloud_messaging.rb +++ b/app/services/firebase_cloud_messaging.rb @@ -11,7 +11,8 @@ event: 'report_created', report: report.id, title: repo...
Add author name to notifications.
diff --git a/spec/bsf/scraper/command_spec.rb b/spec/bsf/scraper/command_spec.rb index abc1234..def5678 100644 --- a/spec/bsf/scraper/command_spec.rb +++ b/spec/bsf/scraper/command_spec.rb @@ -3,10 +3,73 @@ describe Bsf::Scraper::Command do describe '.initialize' do + it { expect { described_class.new }. ...
Add tests for command-line argument validation Add tests for the command-line validation done using the Trollop library.
diff --git a/spec/factories/prover_factory.rb b/spec/factories/prover_factory.rb index abc1234..def5678 100644 --- a/spec/factories/prover_factory.rb +++ b/spec/factories/prover_factory.rb @@ -7,6 +7,10 @@ name { 'SPASS' } display_name { 'SPASS Prover' } + initialize_with do + Prover.find_by_name(nam...
Fix prover factory trying to create duplicate.
diff --git a/spec/python-requirements_spec.rb b/spec/python-requirements_spec.rb index abc1234..def5678 100644 --- a/spec/python-requirements_spec.rb +++ b/spec/python-requirements_spec.rb @@ -11,3 +11,7 @@ describe package('build-essential'), :if => os[:family] == 'debian' do it { should be_installed } end + +desc...
Add spec to confirm Python command exist on PATH.
diff --git a/spec/read_time_estimator_spec.rb b/spec/read_time_estimator_spec.rb index abc1234..def5678 100644 --- a/spec/read_time_estimator_spec.rb +++ b/spec/read_time_estimator_spec.rb @@ -9,15 +9,15 @@ end end - describe "read_time" do + describe "read_time_words" do it "returns the reading time in...
Change read_time method name to read_time_words. Add missing space to spec. PA-2182
diff --git a/lib/has_timestamps.rb b/lib/has_timestamps.rb index abc1234..def5678 100644 --- a/lib/has_timestamps.rb +++ b/lib/has_timestamps.rb @@ -20,6 +20,7 @@ after_save :save_or_destroy_timestamps def timestamp!(key) + #timestamps[key.to_s] = Time.zone.nil? ? Tim...
Use any time zone instead of just :utc.
diff --git a/lib/hotdog/sources.rb b/lib/hotdog/sources.rb index abc1234..def5678 100644 --- a/lib/hotdog/sources.rb +++ b/lib/hotdog/sources.rb @@ -61,6 +61,7 @@ end def update_tags(*args) + raise(NotImplementedError) end end end
Raise error if `update_tags` is not overridden
diff --git a/plugins/wordpress/check-wpscan.rb b/plugins/wordpress/check-wpscan.rb index abc1234..def5678 100644 --- a/plugins/wordpress/check-wpscan.rb +++ b/plugins/wordpress/check-wpscan.rb @@ -0,0 +1,94 @@+#! /usr/bin/env ruby +# +# wpscan check +# +# DESCRIPTION: +# Runs wpscan against a Wordpress site +# +# OUTP...
Add check that runs wpscan against a Wordpress site and alerts when vulnerabilities are found
diff --git a/lib/type_validator.rb b/lib/type_validator.rb index abc1234..def5678 100644 --- a/lib/type_validator.rb +++ b/lib/type_validator.rb @@ -6,8 +6,9 @@ end def validate_each(record, attribute, value) - unless value.is_a?(options[:with]) - record.errors.add(attribute, "must be a #{options[:with]}...
Support multi types in TypeValidator
diff --git a/lib/udp2sqs_client.rb b/lib/udp2sqs_client.rb index abc1234..def5678 100644 --- a/lib/udp2sqs_client.rb +++ b/lib/udp2sqs_client.rb @@ -1,6 +1,2 @@ require_relative "udp2sqs_client/version" require_relative "udp2sqs_client/client" - -module Udp2sqsClient - # Your code goes here... -end
Delete the generated place-holder code.
diff --git a/lib/wordpress/dump.rb b/lib/wordpress/dump.rb index abc1234..def5678 100644 --- a/lib/wordpress/dump.rb +++ b/lib/wordpress/dump.rb @@ -4,7 +4,7 @@ attr_reader :doc def initialize(file_name) - file_name = File.absolute_path(file_name) + file_name = File.expand_path(file_name) ...
Use File.expand_path instead of File.absolute_path to work with Ruby 1.8.7
diff --git a/lib/wright/dry_run.rb b/lib/wright/dry_run.rb index abc1234..def5678 100644 --- a/lib/wright/dry_run.rb +++ b/lib/wright/dry_run.rb @@ -1,10 +1,28 @@ module Wright @dry_run = false + # Public: Checks if dry-run mode is currently active. + # + # Examples + # + # puts 'Just a dry-run...' if Wrigh...
Add documentation for dry-run mode
diff --git a/libraries/resolver.rb b/libraries/resolver.rb index abc1234..def5678 100644 --- a/libraries/resolver.rb +++ b/libraries/resolver.rb @@ -1,4 +1,4 @@-require 'Resolv' +require 'resolv' class Chef::Recipe::Resolver # We can call this with ISP.vhosts
Fix typo: 'Resolv' => 'resolv'
diff --git a/sms_broker.gemspec b/sms_broker.gemspec index abc1234..def5678 100644 --- a/sms_broker.gemspec +++ b/sms_broker.gemspec @@ -7,6 +7,7 @@ Gem::Specification.new do |s| s.name = "sms_broker" s.version = SmsBroker::VERSION + s.required_ruby_version = '>= 2.2.5' s.authors = ["Roger Kind...
Add required ruby version to gemspec
diff --git a/config/authorization_rules.rb b/config/authorization_rules.rb index abc1234..def5678 100644 --- a/config/authorization_rules.rb +++ b/config/authorization_rules.rb @@ -23,7 +23,7 @@ role :guest do has_permission_on :devise_sessions, :devise_registrations, :devise_confirmations, - ...
Add devise passwords controller to auth rules. For "forgotten password" action, and others?
diff --git a/test/lib/typus/i18n_test.rb b/test/lib/typus/i18n_test.rb index abc1234..def5678 100644 --- a/test/lib/typus/i18n_test.rb +++ b/test/lib/typus/i18n_test.rb @@ -10,4 +10,8 @@ assert_equal :en, Typus::I18n.default_locale end + test "available_locales" do + assert Typus::I18n.available_locales.is...
Make sure Typus::I18n.available_locales returns a Hash
diff --git a/test/test_lknovel_series.rb b/test/test_lknovel_series.rb index abc1234..def5678 100644 --- a/test/test_lknovel_series.rb +++ b/test/test_lknovel_series.rb @@ -7,8 +7,8 @@ series = Lknovel::Series.new('http://lknovel.lightnovel.cn/main/vollist/615.html') series.parse - it 'volume[0]' do - volume...
Fix lknovel series test case
diff --git a/builder/test-integration/spec/hypriotos-image/hypriot-list_spec.rb b/builder/test-integration/spec/hypriotos-image/hypriot-list_spec.rb index abc1234..def5678 100644 --- a/builder/test-integration/spec/hypriotos-image/hypriot-list_spec.rb +++ b/builder/test-integration/spec/hypriotos-image/hypriot-list_spe...
Fix integrations tests for hypriot apt repo Signed-off-by: Dieter Reuter <554783fc552b5b2a46dd3d7d7b9b2cce9a82c122@me.com>
diff --git a/spec/color_spec.rb b/spec/color_spec.rb index abc1234..def5678 100644 --- a/spec/color_spec.rb +++ b/spec/color_spec.rb @@ -0,0 +1,10 @@+require 'color' + +RSpec.describe RandomColor, "#init" do + it "initializes a rgb color with values between 0 and 255" do + color = RandomColor.new + expect(color....
Add tests for color, which will be factored out from bitmap.
diff --git a/spec/parse_spec.rb b/spec/parse_spec.rb index abc1234..def5678 100644 --- a/spec/parse_spec.rb +++ b/spec/parse_spec.rb @@ -29,5 +29,9 @@ it "should raise an exception for non-data URLs" do expect { DataURL.parse('http://google.com/some,thing') }.to raise_error DataURL::InvalidURLError end ...
Test that we ignore gibberish in base64 strings
diff --git a/db/migrate/20170328110106_fix_expression_in_tenant_quota_report.rb b/db/migrate/20170328110106_fix_expression_in_tenant_quota_report.rb index abc1234..def5678 100644 --- a/db/migrate/20170328110106_fix_expression_in_tenant_quota_report.rb +++ b/db/migrate/20170328110106_fix_expression_in_tenant_quota_repor...
Fix field tenants.tenant_quotas of MiqExpression only for: - existing reports - custom reports(created by of 'Tenant Quota Report')
diff --git a/lib/interlatch/rails/extensions/action_controller.rb b/lib/interlatch/rails/extensions/action_controller.rb index abc1234..def5678 100644 --- a/lib/interlatch/rails/extensions/action_controller.rb +++ b/lib/interlatch/rails/extensions/action_controller.rb @@ -1,35 +1,42 @@-module ActionController - class ...
Use a module for ActionController extensions
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -3,7 +3,7 @@ # Devise will add extra flash messages. # We only want to display alerts, notices and errors def flash ...
Fix flash messages being selected into an array
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -23,7 +23,7 @@ end def last_updated(entity) - if entity.to_s.include? "by" + if entity.respond_to? 'user' ...
Refactor if statement to rely on better ruby methods
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,2 +1,14 @@ module ApplicationHelper + def nav_link(text, link) + recognized = Rails.application.routes.recognize_path...
Create a helper to manage header links In the cases where we have a recognised path and are currently on it, show it as active.
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,3 +1,4 @@+# Courseware helpers module ApplicationHelper # Helper to set page title #
Add application helper doc header.
diff --git a/app/mailers/application_mailer.rb b/app/mailers/application_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/application_mailer.rb +++ b/app/mailers/application_mailer.rb @@ -1,7 +1,7 @@ class ApplicationMailer < ActionMailer::Base # TODO: Remove hard code domain default(from: Rails.applicat...
Switch to lambda to avoid same mesage id
diff --git a/app/models/converters/xml_json.rb b/app/models/converters/xml_json.rb index abc1234..def5678 100644 --- a/app/models/converters/xml_json.rb +++ b/app/models/converters/xml_json.rb @@ -23,9 +23,8 @@ end def json_to_xml(json) - hash = JSON.parse(json) - root = hash.keys.first - ...
Fix xml to json converting (root tag)
diff --git a/dimples.gemspec b/dimples.gemspec index abc1234..def5678 100644 --- a/dimples.gemspec +++ b/dimples.gemspec @@ -25,5 +25,6 @@ s.add_development_dependency 'minitest', '~> 5.8' s.add_development_dependency 'redcarpet', '~> 3.3' s.add_development_dependency 'erubis', '~> 2.7' - s.add_development_dep...
Add simplecov and update codeclimate-test-reporter.
diff --git a/toystore.gemspec b/toystore.gemspec index abc1234..def5678 100644 --- a/toystore.gemspec +++ b/toystore.gemspec @@ -18,7 +18,7 @@ s.require_paths = ["lib"] s.add_dependency 'adapter', '~> 0.5.1' - s.add_dependency 'activemodel', '~> 3.0', '< 3.2' - s.add_dependency 'activesupport', '~> 3.0...
Switch to a more liberal active support dependency.
diff --git a/connection.gemspec b/connection.gemspec index abc1234..def5678 100644 --- a/connection.gemspec +++ b/connection.gemspec @@ -20,5 +20,6 @@ s.add_development_dependency 'minitest' s.add_development_dependency 'minitest-spec-context' s.add_development_dependency 'pry' + s.add_development_dependency '...
Add process host as development dependency
diff --git a/auto_html.gemspec b/auto_html.gemspec index abc1234..def5678 100644 --- a/auto_html.gemspec +++ b/auto_html.gemspec @@ -1,7 +1,6 @@ Gem::Specification.new do |gem| gem.name = 'auto_html' gem.version = '1.6.0' - gem.date = Date.today.to_s gem.summary = "Transform URIs to appropriate markup" g...
Remove gem.date from the gemspec. This was causing errors when deploying to engine yard and heroku. I've seen many other repos have this same issue. Another solution could be adding require 'date' to the gemspec, but I find setting gem.date to today's date somewhat useless.
diff --git a/RNFS.podspec b/RNFS.podspec index abc1234..def5678 100644 --- a/RNFS.podspec +++ b/RNFS.podspec @@ -11,6 +11,7 @@ s.author = { "Johannes Lumpe" => "johannes@lum.pe" } s.ios.deployment_target = '7.0' + s.tvos.deployment_target = '9.2' s.source = { :git => "https://github.com...
Add tvOS deployment target to podspec
diff --git a/activesupport/test/cache/behaviors/connection_pool_behavior.rb b/activesupport/test/cache/behaviors/connection_pool_behavior.rb index abc1234..def5678 100644 --- a/activesupport/test/cache/behaviors/connection_pool_behavior.rb +++ b/activesupport/test/cache/behaviors/connection_pool_behavior.rb @@ -4,12 +4...
Fix test: threads being nil in ensure when connection_pool is not installed.
diff --git a/stomp_parser.gemspec b/stomp_parser.gemspec index abc1234..def5678 100644 --- a/stomp_parser.gemspec +++ b/stomp_parser.gemspec @@ -6,10 +6,10 @@ Gem::Specification.new do |spec| spec.name = "stomp_parser" spec.version = StompParser::VERSION - spec.authors = ["Kim Burgestrand"] ...
Add authors and correct homepage in gemspec
diff --git a/app/decorators/controllers/action_controller_base_decorator.rb b/app/decorators/controllers/action_controller_base_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/controllers/action_controller_base_decorator.rb +++ b/app/decorators/controllers/action_controller_base_decorator.rb @@ -2,6 +2,...
Add refinery_user? method in action_controller_base
diff --git a/rack-canonical-host.gemspec b/rack-canonical-host.gemspec index abc1234..def5678 100644 --- a/rack-canonical-host.gemspec +++ b/rack-canonical-host.gemspec @@ -7,7 +7,7 @@ gem.homepage = 'http://github.com/tylerhunt/rack-canonical-host' gem.author = 'Tyler Hunt' - gem.add_dependency 'rack', '>= 1.0...
Use pessimistic version requirement for Rack.
diff --git a/Casks/intellij-idea-community.rb b/Casks/intellij-idea-community.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-community.rb +++ b/Casks/intellij-idea-community.rb @@ -2,6 +2,6 @@ url 'http://download-ln.jetbrains.com/idea/ideaIC-13.0.1.dmg' homepage 'https://www.jetbrains.com/idea/index.h...
Correct Intellij IDEA 13.0.1 SHA
diff --git a/Casks/xamarin-studio.rb b/Casks/xamarin-studio.rb index abc1234..def5678 100644 --- a/Casks/xamarin-studio.rb +++ b/Casks/xamarin-studio.rb @@ -1,6 +1,6 @@ class XamarinStudio < Cask - version '5.0.1.3-0' - sha256 '51e840a8b5e8679363290aee88af2cdadd9d99706ae346f787d07ecc27bdabe8' + version '5.4.0.240-0'...
Bump Xamarin Studio to v5.4.0.240-0
diff --git a/recipes/nodejs_from_chocolatey.rb b/recipes/nodejs_from_chocolatey.rb index abc1234..def5678 100644 --- a/recipes/nodejs_from_chocolatey.rb +++ b/recipes/nodejs_from_chocolatey.rb @@ -18,11 +18,11 @@ chocolatey_package 'nodejs-lts' do version node['nodejs']['version'] - action :install + action :upg...
Change the action for nodejs chocolatey from install to upgrade This way it will upgrade to the active LTS version even if the version is maintenance LTS
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -36,6 +36,14 @@ ActionController::Base.view_paths = File.join(File.dirname(__FILE__), 'views') -ActionController::Routing::Routes.draw do |map| +InheritedResources::Router = Ac...
Make tests run on master.
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -10,6 +10,7 @@ require 'helpers/test_cards' require 'pp' +require 'time' module Adyen::Test module Flaky
Fix tests by making sure Time.parse is available
diff --git a/test_runner.gemspec b/test_runner.gemspec index abc1234..def5678 100644 --- a/test_runner.gemspec +++ b/test_runner.gemspec @@ -25,6 +25,7 @@ s.add_runtime_dependency 'appium_lib', '= 0.15.2' s.add_runtime_dependency 'spec', '= 5.0.19' + s.add_runtime_dependency 'flaky', '= 0.0.22' s.files = `...
Add flaky for video recording
diff --git a/sinatra-formhelpers-ng.gemspec b/sinatra-formhelpers-ng.gemspec index abc1234..def5678 100644 --- a/sinatra-formhelpers-ng.gemspec +++ b/sinatra-formhelpers-ng.gemspec @@ -21,7 +21,7 @@ gem.require_paths = ["lib"] gem.rubygems_version = "2.4.5" - gem.add_development_dependency "bundler", "~> 1.8" +...
Fix Bundler version for Travis-CI
diff --git a/shaq_overflow/app/controllers/votes_controller.rb b/shaq_overflow/app/controllers/votes_controller.rb index abc1234..def5678 100644 --- a/shaq_overflow/app/controllers/votes_controller.rb +++ b/shaq_overflow/app/controllers/votes_controller.rb @@ -3,6 +3,8 @@ def create if params[:votableType] == "A...
Add logic for up/down vote for questions
diff --git a/Library/Formula/cfitsio.rb b/Library/Formula/cfitsio.rb index abc1234..def5678 100644 --- a/Library/Formula/cfitsio.rb +++ b/Library/Formula/cfitsio.rb @@ -1,4 +1,10 @@ require 'formula' + +class CfitsioExamples < Formula + url 'http://heasarc.gsfc.nasa.gov/docs/software/fitsio/cexamples/cexamples.zip' + ...
CFitsIO: Add option to install example programs Added the option --with-examples to the cfitsio formula, that downloads, compiles and installs some useful programs, like listhead, modhead, etc. Signed-off-by: Charlie Sharpsteen <828d338a9b04221c9cbe286f50cd389f68de4ecf@sharpsteen.net>
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -25,8 +25,8 @@ # Configure all nodes in nodeset c.before :suite do # Install module and dependencies - puppet_module_instal...
Fix issue with puppet_module_install, removed and using updated method from beaker core copy_module_to
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -13,6 +13,6 @@ c.formatter = :documentation c.before :suite do - logger.info("Using Puppet version #{(on default, 'puppet --ve...
Print just the Puppet version, no other warning etc Facter complains about missing environment variables which is a bit noisy. Using stdout filters them out.
diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index abc1234..def5678 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -14,7 +14,7 @@ # Install module and dependencies puppet_module_install(:source => proj_root, :module_name => 'tomcat') hos...
Use puppet-archive in acceptance tests
diff --git a/test/pachube_test.rb b/test/pachube_test.rb index abc1234..def5678 100644 --- a/test/pachube_test.rb +++ b/test/pachube_test.rb @@ -13,7 +13,14 @@ end def test_require_feed_id - svc = service({'api_key' => 'abcd1234'}, payload) + svc = service({'api_key' => 'abcd1234', 'track_branch' => 'xyz'}...
Update the tests for Pachube
diff --git a/tasks/constructor-cms_tasks.rake b/tasks/constructor-cms_tasks.rake index abc1234..def5678 100644 --- a/tasks/constructor-cms_tasks.rake +++ b/tasks/constructor-cms_tasks.rake @@ -4,9 +4,7 @@ sh 'rake build' %w{core pages}.each do |engine| - sh "cd #{engine}" - sh "gem build constructo...
Fix rakefile for building gems
diff --git a/acfs.gemspec b/acfs.gemspec index abc1234..def5678 100644 --- a/acfs.gemspec +++ b/acfs.gemspec @@ -18,8 +18,8 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = %w(lib) - spec.add_dependency 'activesupport' - spec.add_dependency 'activemodel' + spec.add_runt...
Switch to runtime dependencies. (Do not use alias.)
diff --git a/examples/creature.rb b/examples/creature.rb index abc1234..def5678 100644 --- a/examples/creature.rb +++ b/examples/creature.rb @@ -0,0 +1,38 @@+# Run this example: ruby examples/creature.rb +$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__) +require 'slothify' + +class Creature +using Slothify + ...
Add examples folder and file
diff --git a/test/helpers__livereload_test.rb b/test/helpers__livereload_test.rb index abc1234..def5678 100644 --- a/test/helpers__livereload_test.rb +++ b/test/helpers__livereload_test.rb @@ -0,0 +1,18 @@+require "test_helper" + +class LivereloadTest < TestCase + test "#livereload_script has correct output" do + o...
Add test for view helper Livereload script output
diff --git a/bake.gemspec b/bake.gemspec index abc1234..def5678 100644 --- a/bake.gemspec +++ b/bake.gemspec @@ -18,6 +18,5 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.5" - spec.add_development_dependency "rake" - spec.add_runtime_dependency "thor" + spec.add_runtime_depen...
Use pessimistic version operator for thor
diff --git a/watchman.rb b/watchman.rb index abc1234..def5678 100644 --- a/watchman.rb +++ b/watchman.rb @@ -1,7 +1,7 @@ require 'yaml' require 'action_mailer' require 'utf8-cleaner' -use UTF8Cleaner::Middleware +# use UTF8Cleaner::Middleware require "#{File.expand_path(File.dirname(__FILE__))}/file_mailer" @@ -...
Remove use that is for middleware
diff --git a/OGCSensorThings.podspec b/OGCSensorThings.podspec index abc1234..def5678 100644 --- a/OGCSensorThings.podspec +++ b/OGCSensorThings.podspec @@ -1,7 +1,7 @@ Pod::Spec.new do |s| s.name = "OGCSensorThings" - s.version = "2.1.2" + s.version = "2.1.4" s.summary = "Easily consum...
Update using new swagger-codegen from source