diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/test/integration/n_plus_1_test.rb b/test/integration/n_plus_1_test.rb index abc1234..def5678 100644 --- a/test/integration/n_plus_1_test.rb +++ b/test/integration/n_plus_1_test.rb @@ -0,0 +1,41 @@+# frozen_string_literal: true + +require("test_helper") + +# Discover potential n+1 issues by running some req...
Add integration test to find some potential n+1 queries
diff --git a/db/migrate/20110620084032_add_authorised_to_person.rb b/db/migrate/20110620084032_add_authorised_to_person.rb index abc1234..def5678 100644 --- a/db/migrate/20110620084032_add_authorised_to_person.rb +++ b/db/migrate/20110620084032_add_authorised_to_person.rb @@ -0,0 +1,14 @@+class AddAuthorisedToPerson < ...
Add authorised field to person and update current persons to authorised
diff --git a/bibliography.gemspec b/bibliography.gemspec index abc1234..def5678 100644 --- a/bibliography.gemspec +++ b/bibliography.gemspec @@ -9,7 +9,7 @@ spec.authors = ["Mike Robinson"] spec.email = ["mike@studiolift.com"] spec.description = %q{A library of useful tools for books and related...
Correct ambiguous notion of "BIC codes" to "BIC subjects"
diff --git a/0_code_wars/always_perfect.rb b/0_code_wars/always_perfect.rb index abc1234..def5678 100644 --- a/0_code_wars/always_perfect.rb +++ b/0_code_wars/always_perfect.rb @@ -0,0 +1,9 @@+# http://www.codewars.com/kata/always-perfect/ +# --- iteration 1 --- +def check_root(str) + return "incorrect input" unless /...
Add code wars (7) - always perfect
diff --git a/lib/bitbucket/representation/repo.rb b/lib/bitbucket/representation/repo.rb index abc1234..def5678 100644 --- a/lib/bitbucket/representation/repo.rb +++ b/lib/bitbucket/representation/repo.rb @@ -5,10 +5,18 @@ def initialize(raw) super(raw) + end - if full_name && full_name.s...
Clean up owner and slug representation
diff --git a/lib/cache_comment/fragment_helper.rb b/lib/cache_comment/fragment_helper.rb index abc1234..def5678 100644 --- a/lib/cache_comment/fragment_helper.rb +++ b/lib/cache_comment/fragment_helper.rb @@ -10,7 +10,8 @@ def read_fragment(key, options) unless params[:cache_comments] comment = Comm...
Refactor fragment to call super only once As suggested by @kirel
diff --git a/lib/discordrb/webhooks/embeds.rb b/lib/discordrb/webhooks/embeds.rb index abc1234..def5678 100644 --- a/lib/discordrb/webhooks/embeds.rb +++ b/lib/discordrb/webhooks/embeds.rb @@ -29,5 +29,9 @@ # The URL the title should point to. # @return [String] attr_accessor :url + + # The timestamp f...
:anchor: Add an accessor for the timestamp
diff --git a/lib/knife/changelog/git_submodule.rb b/lib/knife/changelog/git_submodule.rb index abc1234..def5678 100644 --- a/lib/knife/changelog/git_submodule.rb +++ b/lib/knife/changelog/git_submodule.rb @@ -6,7 +6,7 @@ class GitSubmodule < Changelog def run(submodules) - raise ::ArgumentError "Submodule...
Fix missing coma in argumentError raising for gitsubmodule changelog
diff --git a/spec/workers/link_phenotype_snp_spec.rb b/spec/workers/link_phenotype_snp_spec.rb index abc1234..def5678 100644 --- a/spec/workers/link_phenotype_snp_spec.rb +++ b/spec/workers/link_phenotype_snp_spec.rb @@ -1,28 +1,51 @@ RSpec.describe LinkSnpPhenotype do - subject do + setup do + # might use 'build'...
Expand tests for LinkSnpPhenotype worker Signed-off-by: Vivek Rai <4b8b65dd320e6035df8e26fe45ee3876d9e0f96b@gmail.com>
diff --git a/lib/tasks/rake_helpers/rake_utils.rb b/lib/tasks/rake_helpers/rake_utils.rb index abc1234..def5678 100644 --- a/lib/tasks/rake_helpers/rake_utils.rb +++ b/lib/tasks/rake_helpers/rake_utils.rb @@ -22,7 +22,7 @@ def decompress_file(filename) shell_working "decompressing file #{filename}" do - s...
Use decompression options available on hosted env Was getting this error trying to restore on a hosted env (alpine image): ``` gunzip: unrecognized option: -3 BusyBox v1.30.1 (2019-10-26 11:23:07 UTC) multi-call binary. Usage: gunzip [-cfkt] [FILE]... Decompress FILEs (or stdin) -c Write to stdout -f Force ...
diff --git a/lib/toy_robot_simulator/simulator.rb b/lib/toy_robot_simulator/simulator.rb index abc1234..def5678 100644 --- a/lib/toy_robot_simulator/simulator.rb +++ b/lib/toy_robot_simulator/simulator.rb @@ -1,4 +1,25 @@ module ToyRobotSimulator class Simulator + attr_accessor :controller + + def initialize +...
Create Simulator with a finite loop that receives commands
diff --git a/know-your-values/app/controllers/values_controller.rb b/know-your-values/app/controllers/values_controller.rb index abc1234..def5678 100644 --- a/know-your-values/app/controllers/values_controller.rb +++ b/know-your-values/app/controllers/values_controller.rb @@ -2,7 +2,8 @@ include IndexHelper def sh...
Send friend data to view.
diff --git a/spec/factories/sales_pages.rb b/spec/factories/sales_pages.rb index abc1234..def5678 100644 --- a/spec/factories/sales_pages.rb +++ b/spec/factories/sales_pages.rb @@ -11,5 +11,6 @@ heading { Faker::Lorem.words(rand(3) + 3).join " " } sub_heading { Faker::Lorem.words(rand(5) + 3).join "...
Update SalesPage Factor for about_owner Add the about_owner attribute to the SalesPage factory.
diff --git a/spec/features/comment_spec.rb b/spec/features/comment_spec.rb index abc1234..def5678 100644 --- a/spec/features/comment_spec.rb +++ b/spec/features/comment_spec.rb @@ -1,23 +1,30 @@ require 'rails_helper' -describe 'Comments Panel' do - it "user can see comments on queried translation" do - pending +des...
Add beginning of test for view of new comment page
diff --git a/lib/finite_machine/async_call.rb b/lib/finite_machine/async_call.rb index abc1234..def5678 100644 --- a/lib/finite_machine/async_call.rb +++ b/lib/finite_machine/async_call.rb @@ -0,0 +1,47 @@+# encoding: utf-8 + +module FiniteMachine + # An asynchronouse call representation + class AsyncCall + includ...
Add async call for event dispatch.
diff --git a/lib/frecon/models/competition.rb b/lib/frecon/models/competition.rb index abc1234..def5678 100644 --- a/lib/frecon/models/competition.rb +++ b/lib/frecon/models/competition.rb @@ -14,9 +14,6 @@ field :location, type: String field :name, type: String - has_many :matches, dependent: :destroy - has_m...
Competition: Remove old associations with matches and participations.
diff --git a/cookbooks/ondemand_base/metadata.rb b/cookbooks/ondemand_base/metadata.rb index abc1234..def5678 100644 --- a/cookbooks/ondemand_base/metadata.rb +++ b/cookbooks/ondemand_base/metadata.rb @@ -4,21 +4,21 @@ description "Installs/Configures ondemand_base" long_description IO.read(File.join(File.dirname...
Sort the world's largest decency list Former-commit-id: 621e939f456552867f7cd8495a5bfe213e601e3e [formerly 680a1090acf5d9055a7dad3b355f0ece318eed46] [formerly 2634e22baf3c2391edd2a20b8ca2d399ef72c485 [formerly 730a14160af3b916bf94cdfb66d290091832424d [formerly 3221e989820087a090268a9485f48eb959441ea8]]] Former-commit...
diff --git a/db/migrate/20160308212903_add_default_group_visibility_to_application_settings.rb b/db/migrate/20160308212903_add_default_group_visibility_to_application_settings.rb index abc1234..def5678 100644 --- a/db/migrate/20160308212903_add_default_group_visibility_to_application_settings.rb +++ b/db/migrate/201603...
Fix group visibility level migration in case all visibility levels are restricted
diff --git a/engines/order_management/spec/services/order_management/stock/coordinator_spec.rb b/engines/order_management/spec/services/order_management/stock/coordinator_spec.rb index abc1234..def5678 100644 --- a/engines/order_management/spec/services/order_management/stock/coordinator_spec.rb +++ b/engines/order_man...
Replace `create` with `build_stubbed` in coordinator model specs
diff --git a/test/test_read_map.rb b/test/test_read_map.rb index abc1234..def5678 100644 --- a/test/test_read_map.rb +++ b/test/test_read_map.rb @@ -1,3 +1,30 @@ require_relative "test_helper" +class TestReadMap < Poke::Test + def setup + @object = Object.new + @object.extend(ReadMap) + @mf = "media/grid_...
Add TestReadMap and several test methods
diff --git a/lib/queryable_array/shorthand.rb b/lib/queryable_array/shorthand.rb index abc1234..def5678 100644 --- a/lib/queryable_array/shorthand.rb +++ b/lib/queryable_array/shorthand.rb @@ -1,8 +1,8 @@ class QueryableArray < Array module Shorthand - # If +key+ is a +Hash+ or an +Array+ containing one + # If...
Add more documentation for Shorthand [ci skip]
diff --git a/lib/rspec/default_http_header.rb b/lib/rspec/default_http_header.rb index abc1234..def5678 100644 --- a/lib/rspec/default_http_header.rb +++ b/lib/rspec/default_http_header.rb @@ -1,7 +1,19 @@ require "rspec/default_http_header/version" -module Rspec +module RSpec module DefaultHttpHeader - # Your ...
Set default http header via overriding http methods
diff --git a/lib/rubycritic/source_locator.rb b/lib/rubycritic/source_locator.rb index abc1234..def5678 100644 --- a/lib/rubycritic/source_locator.rb +++ b/lib/rubycritic/source_locator.rb @@ -21,13 +21,13 @@ private def expand_paths - @initial_paths.map do |path| + @initial_paths.flat_map do |path...
Use flat_map instead of map followed by flatten Not only is this more idiomatic, [it's also better performance wise!][1] [1]: http://gistflow.com/posts/578-use-flat_map-instead-of-map-flatten
diff --git a/lib/travis/build/script/perl6.rb b/lib/travis/build/script/perl6.rb index abc1234..def5678 100644 --- a/lib/travis/build/script/perl6.rb +++ b/lib/travis/build/script/perl6.rb @@ -9,6 +9,11 @@ perl6: 'latest' } + def export + super + sh.export 'TRAVIS_PERL6_VER...
Move `export` sub to beginning This makes the global nature of the sub more apparent
diff --git a/0_code_wars/parsing_prices.rb b/0_code_wars/parsing_prices.rb index abc1234..def5678 100644 --- a/0_code_wars/parsing_prices.rb +++ b/0_code_wars/parsing_prices.rb @@ -0,0 +1,14 @@+# http://www.codewars.com/kata/56833b76371e86f8b6000015/ +# --- iteration 1 --- +class String + def to_cents + /\A\$(?<dol...
Add code wars (7) - parsing prices
diff --git a/spec/features/teams/cud_spec.rb b/spec/features/teams/cud_spec.rb index abc1234..def5678 100644 --- a/spec/features/teams/cud_spec.rb +++ b/spec/features/teams/cud_spec.rb @@ -0,0 +1,48 @@+require 'spec_helper.rb' + +feature 'Creating editing and deleting a team', js: true do + let(:tournament1){ FactoryG...
Add Teams UD feature spec
diff --git a/spec/models/groups_user_spec.rb b/spec/models/groups_user_spec.rb index abc1234..def5678 100644 --- a/spec/models/groups_user_spec.rb +++ b/spec/models/groups_user_spec.rb @@ -1,5 +1,5 @@ require 'spec_helper' -describe GroupsUser do +describe GroupUser do pending "add some examples to (or delete) #{_...
Fix incorrect model name on GroupUser to get test to run
diff --git a/Casks/handbrakecli-nightly.rb b/Casks/handbrakecli-nightly.rb index abc1234..def5678 100644 --- a/Casks/handbrakecli-nightly.rb +++ b/Casks/handbrakecli-nightly.rb @@ -1,10 +1,12 @@ cask :v1 => 'handbrakecli-nightly' do - version '6782svn' - sha256 'a661254da12a5fcaaab80b822bed78e8e000800042380bf3ccdfacf...
Update HandbrakeCLI Nightly to v6822svn HandBrakeCLI Nightly v6822svn built 2015-01-28.
diff --git a/Casks/webstorm-bundled-jdk.rb b/Casks/webstorm-bundled-jdk.rb index abc1234..def5678 100644 --- a/Casks/webstorm-bundled-jdk.rb +++ b/Casks/webstorm-bundled-jdk.rb @@ -0,0 +1,21 @@+cask :v1 => 'webstorm-bundled-jdk' do + version '10.0.1' + sha256 '8b05be91e5c688908d6bcaab4d1f5ead86912d5b33b332a7dd5964dc9...
Add formula for WebStorm with bundled JDK See #879
diff --git a/config/environments/production.rb b/config/environments/production.rb index abc1234..def5678 100644 --- a/config/environments/production.rb +++ b/config/environments/production.rb @@ -13,6 +13,5 @@ config.log_level = :info config.i18n.fallbacks = true config.active_support.deprecation = :notify - ...
Remove last vestiges of logstasher config It's now handled by govuk_app_config and we should have removed it when we upgraded to 1.0.0, but the documentation was unclear.
diff --git a/config/environments/production.rb b/config/environments/production.rb index abc1234..def5678 100644 --- a/config/environments/production.rb +++ b/config/environments/production.rb @@ -19,4 +19,8 @@ config.action_mailer.delivery_method = :sendmail # so is queued, rather than giving immediate errors requi...
Add comment about middleware change for rails 3
diff --git a/config/software/datadog-verity.rb b/config/software/datadog-verity.rb index abc1234..def5678 100644 --- a/config/software/datadog-verity.rb +++ b/config/software/datadog-verity.rb @@ -1,8 +1,13 @@ name "datadog-verity" default_version "last-stable" +env = { + "GOROOT" => "/usr/local/go/", + "GOPATH" =...
Update go env in verity config
diff --git a/Casks/mindjet-mindmanager9.rb b/Casks/mindjet-mindmanager9.rb index abc1234..def5678 100644 --- a/Casks/mindjet-mindmanager9.rb +++ b/Casks/mindjet-mindmanager9.rb @@ -2,7 +2,7 @@ version '9.6.510' sha256 '23e2e2e3f712bc9d58b4a826abc3fb50ffac0134e93c4db9e055fa4874fe12d1' - url 'http://download.mind...
Change single to double quotes in mindjet-mindmanager url
diff --git a/Disk.podspec b/Disk.podspec index abc1234..def5678 100644 --- a/Disk.podspec +++ b/Disk.podspec @@ -9,7 +9,7 @@ s.license = { :type => "MIT", :file => "LICENSE" } s.author = { "Saoud Rizwan" => "hello@saoudmr.com" } s.social_media_url = "https://twitter.com/sdrzn" - s.swift_vers...
Update podspec to Swift 5
diff --git a/extconf.rb b/extconf.rb index abc1234..def5678 100644 --- a/extconf.rb +++ b/extconf.rb @@ -1,3 +1,3 @@ require "mkmf" have_header("stdint.h") -create_makefile("bytestream") +create_makefile("crypt/bytestream")
Put bytestream.? in the right place
diff --git a/lib/api.rb b/lib/api.rb index abc1234..def5678 100644 --- a/lib/api.rb +++ b/lib/api.rb @@ -39,6 +39,11 @@ Survey.all.to_json end + get '/surveys/:id' do + content_type :json + Survey.first(_id: params[:id].to_i).to_json + end + post '/surveys' do data = JSON.parse(request.body.rea...
Add route for single survey
diff --git a/telemetry-logger.gemspec b/telemetry-logger.gemspec index abc1234..def5678 100644 --- a/telemetry-logger.gemspec +++ b/telemetry-logger.gemspec @@ -1,7 +1,7 @@ # -*- encoding: utf-8 -*- Gem::Specification.new do |s| s.name = 'telemetry-logger' - s.version = '0.1.6' + s.version = '0.1.7' s.summary ...
Package version patch number is incremented from 0.1.6 to 0.1.7
diff --git a/recipes/server_upgrade.rb b/recipes/server_upgrade.rb index abc1234..def5678 100644 --- a/recipes/server_upgrade.rb +++ b/recipes/server_upgrade.rb @@ -1,4 +1,10 @@ include_recipe "gluster::upgrade_common" + +bash "kill glusterfsd and glusterd" do + code <<-CMD + killall glusterfsd glusterd + CMD +end ...
Kill GFS processes when upgrading
diff --git a/test/inheritance_test.rb b/test/inheritance_test.rb index abc1234..def5678 100644 --- a/test/inheritance_test.rb +++ b/test/inheritance_test.rb @@ -32,8 +32,8 @@ end end - assert_equal [:born, :conceived] , Animal.workflow_spec.states.keys.sort - assert_equal [:hiding, :upset], Cat.workf...
Fix test for Ruby 1.8.7
diff --git a/tests/helpers/fake_ui.rb b/tests/helpers/fake_ui.rb index abc1234..def5678 100644 --- a/tests/helpers/fake_ui.rb +++ b/tests/helpers/fake_ui.rb @@ -19,8 +19,8 @@ @test.assert_equal expected_score, actual_score end - def display_winners(players) - @output << "#{players.map(&:name).join(' & ')} ...
Remove duplication by using method defined in parent and fix test
diff --git a/spec/language/alias_spec.rb b/spec/language/alias_spec.rb index abc1234..def5678 100644 --- a/spec/language/alias_spec.rb +++ b/spec/language/alias_spec.rb @@ -1 +1,40 @@ require File.dirname(__FILE__) + '/../spec_helper' + +class AliasObject + def value; 5; end + def false_value; 6; end +end + +describe...
Add some 'alias' specs that fail on rbx and pass on MRI
diff --git a/lib/cannon/route_action.rb b/lib/cannon/route_action.rb index abc1234..def5678 100644 --- a/lib/cannon/route_action.rb +++ b/lib/cannon/route_action.rb @@ -21,6 +21,7 @@ @action.call(request, response) elsif @action.include? '#' controller, action = @action.split('#') + Cannon.logger...
Add logger debug line for controller based action requests
diff --git a/lib/copian/collector/hp.rb b/lib/copian/collector/hp.rb index abc1234..def5678 100644 --- a/lib/copian/collector/hp.rb +++ b/lib/copian/collector/hp.rb @@ -1,8 +1,18 @@ require File.expand_path(File.dirname(__FILE__) + '/hp/ports') +require File.expand_path(File.dirname(__FILE__) + '/hp/vlans') module C...
Add VLAN support to HP collector. We work around the lack of VLAN ID information from the VLAN collector by obtaining the VLAN ID from the ifName.
diff --git a/lib/duby/ast/intrinsics.rb b/lib/duby/ast/intrinsics.rb index abc1234..def5678 100644 --- a/lib/duby/ast/intrinsics.rb +++ b/lib/duby/ast/intrinsics.rb @@ -1,47 +1,45 @@ module Duby::AST - class Print < Node - attr_accessor :println - - def initialize(parent, line_number, println, &block) - sup...
Remove Print node and just transform puts/print into calls against System.out.
diff --git a/vagrant_cloud.gemspec b/vagrant_cloud.gemspec index abc1234..def5678 100644 --- a/vagrant_cloud.gemspec +++ b/vagrant_cloud.gemspec @@ -9,7 +9,7 @@ s.homepage = 'https://github.com/cargomedia/vagrant_cloud' s.license = 'MIT' - s.add_runtime_dependency 'rest_client' + s.add_runtime_dependenc...
Update gem dependencies, add version constraints
diff --git a/scrolls/mysql.rb b/scrolls/mysql.rb index abc1234..def5678 100644 --- a/scrolls/mysql.rb +++ b/scrolls/mysql.rb @@ -13,17 +13,16 @@ after_bundler do rake "db:create:all" if config['auto_create'] - if config['populate_rake_task'] - sample_rake = <<-RUBY -require './config/environment' + rakefile...
Use the rakefile helper to create sample.rake
diff --git a/lib/playlistified_entry.rb b/lib/playlistified_entry.rb index abc1234..def5678 100644 --- a/lib/playlistified_entry.rb +++ b/lib/playlistified_entry.rb @@ -6,8 +6,10 @@ :visual_url, :locale, :tracks, + :playlists, + :albums, ...
Add albums attribute to PlaylistifiedEntry
diff --git a/lib/rack/handler/mizuno.rb b/lib/rack/handler/mizuno.rb index abc1234..def5678 100644 --- a/lib/rack/handler/mizuno.rb +++ b/lib/rack/handler/mizuno.rb @@ -0,0 +1,20 @@+require 'mizuno' + +begin + require 'rjack-logback' + RJack::Logback.config_console( :stderr => true, :thread => true ) +rescue LoadErro...
Add Rack::Handler::Mizuno for rackup -s support
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -4,8 +4,6 @@ require 'rspec' require 'tinder' require 'fakeweb' - -require 'faraday/adapter/test' FakeWeb.allow_net_connect = false
Remove direct require of Faraday test adapter
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,8 +2,7 @@ require 'chefspec/berkshelf' RSpec.configure do |config| - config.color = true - config.log_level = :error + config.color = true # Use color in STD...
Use the doc formatter for specs Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,9 +1,9 @@+ENV['RACK_ENV'] ||= "test" + require 'juici' require 'mocha' require 'fileutils' - -ENV['RACK_ENV'] ||= "test" Dir["#{File.expand_path(File.dirname(__FILE__))}...
Set RACK_ENV before juici has a chance to
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,6 +2,9 @@ $LOAD_PATH.unshift(File.dirname(__FILE__)) require 'rspec' require 'putkitin' + +require 'fakefs/safe' +require 'fakefs/spec_helpers' # Requires supporting files ...
Include fakefs in spec helper
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -19,7 +19,19 @@ if attributes.empty? Class.new else - Struct.new(*attributes).new(*values) + mapped_values = values.map { |v| map_value(v) } + Struct...
Implement nesting feature for HashObject
diff --git a/slides/layout.rb b/slides/layout.rb index abc1234..def5678 100644 --- a/slides/layout.rb +++ b/slides/layout.rb @@ -10,8 +10,8 @@ class Flows < Slide def content - head = headline 'Flows' - @image = fully_shown_image 'images/flow.png', head.height + OFFSET_FOR_EMPTY_LINE + headline 'Flows' + ...
Fix another problem with height/width for text blocks not set
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,4 +1,4 @@-require 'rspec-expectations' +require 'rspec/expectations' require 'chefspec' require 'chefspec/berkshelf' require 'chefspec/server'
Resolve deprecation warning in spec
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,6 @@+require 'rubygems' +require 'spork' + # This file is copied to spec/ when you run 'rails generate rspec:install' ENV["RAILS_ENV"] ||= 'test' require File.expand_pat...
Set up "spork" for rspec. Signed-off-by: Daniel Hackney <2591e5f46f28d303f9dc027d475a5c60d8dea17a@haxney.org>
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,7 +11,7 @@ Coveralls::SimpleCov::Formatter ] SimpleCov.start do - add_filter '/spec/support/custom_matcher' + add_filter '/spec/' end require 'sepa_king'
Coverage: Check the main code only, not the test code
diff --git a/spectabular.gemspec b/spectabular.gemspec index abc1234..def5678 100644 --- a/spectabular.gemspec +++ b/spectabular.gemspec @@ -18,7 +18,7 @@ s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] s.test_files = Dir["test/**/*"] - s.add_dependency "rails", '~> 3.0' + ...
Add Compatibility with Rails 4
diff --git a/lib/yard/server/adapter.rb b/lib/yard/server/adapter.rb index abc1234..def5678 100644 --- a/lib/yard/server/adapter.rb +++ b/lib/yard/server/adapter.rb @@ -31,7 +31,7 @@ self.options = opts self.server_options = server_opts self.document_root = server_options[:DocumentRoot] - ...
Allow alternate Router class to be specified with Adapter
diff --git a/app_template.rb b/app_template.rb index abc1234..def5678 100644 --- a/app_template.rb +++ b/app_template.rb @@ -1,4 +1,4 @@-gem "rglossa", git: "git://github.com/textlab/rglossa.git" +gem "rglossa", github: "textlab/rglossa" run "bundle install"
Use github reference in application template
diff --git a/unsorted/excel_columns.rb b/unsorted/excel_columns.rb index abc1234..def5678 100644 --- a/unsorted/excel_columns.rb +++ b/unsorted/excel_columns.rb @@ -0,0 +1,47 @@+# encoding: UTF-8 +require 'minitest/autorun' + +# Given a positive integer, return its corresponding column title as appear in an Excel sheet...
Add Excel column problem from Leetcode
diff --git a/spec/tww_spec.rb b/spec/tww_spec.rb index abc1234..def5678 100644 --- a/spec/tww_spec.rb +++ b/spec/tww_spec.rb @@ -4,12 +4,22 @@ let(:config) { TWW.config } let(:client) { TWW.client } - it { expect(config).to_not be_nil } - it { expect(config.from).to eq('ACME Inc.') } - it { expect(config.user...
Improve tests for rest impl
diff --git a/my_hash.rb b/my_hash.rb index abc1234..def5678 100644 --- a/my_hash.rb +++ b/my_hash.rb @@ -3,7 +3,7 @@ class MyHash attr_reader :array def initialize - @array = ArrayList.new(5) + @array = ArrayList.new(100) end def set(key, value)
Increase the initial size of MyHash This is necessary because the initial size is not large enough to prevent scenarios where someone is attempting to access the value of a certain key that doesn't actually exist yet. Without this fix, MyHash would raise an exception.
diff --git a/app/controllers/teachers/progress_reports/standards/classroom_topics_controller.rb b/app/controllers/teachers/progress_reports/standards/classroom_topics_controller.rb index abc1234..def5678 100644 --- a/app/controllers/teachers/progress_reports/standards/classroom_topics_controller.rb +++ b/app/controller...
Return 401 unless this teacher has access to this classroom
diff --git a/NSURL+QueryDictionary.podspec b/NSURL+QueryDictionary.podspec index abc1234..def5678 100644 --- a/NSURL+QueryDictionary.podspec +++ b/NSURL+QueryDictionary.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "NSURL+QueryDictionary" - s.version = "1.1.0" + s.version = "1.2.0" ...
Add tvOS to the Podspec
diff --git a/app/helpers/posts_helper.rb b/app/helpers/posts_helper.rb index abc1234..def5678 100644 --- a/app/helpers/posts_helper.rb +++ b/app/helpers/posts_helper.rb @@ -3,7 +3,7 @@ module PostsHelper def render_links(text) raw(text.split(%r{((?:https?:)?\/{2}[^\)\s]*)}).map.with_index do |s, i| - i.eve...
Use html_escape instead of sanitize to avoid stripping HTML completely
diff --git a/app/jobs/fhir_upload_job.rb b/app/jobs/fhir_upload_job.rb index abc1234..def5678 100644 --- a/app/jobs/fhir_upload_job.rb +++ b/app/jobs/fhir_upload_job.rb @@ -21,7 +21,7 @@ fhir_server_url = "http://" + ENV["IE_PORT_3001_TCP_ADDR"] + ":" + ENV["IE_PORT_3001_TCP_PORT"] end - `#{upload_execu...
Use conditional uploading to FHIR endpoint to avoid record duplication
diff --git a/lib/bond/readlines/jruby.rb b/lib/bond/readlines/jruby.rb index abc1234..def5678 100644 --- a/lib/bond/readlines/jruby.rb +++ b/lib/bond/readlines/jruby.rb @@ -4,7 +4,7 @@ require 'readline' require 'jruby' class << Readline - ReadlineExt = org.jruby.ext.Readline + ReadlineExt ||= o...
Enable plural Readline invocations sans warnings.
diff --git a/lib/byebug/commands/kill.rb b/lib/byebug/commands/kill.rb index abc1234..def5678 100644 --- a/lib/byebug/commands/kill.rb +++ b/lib/byebug/commands/kill.rb @@ -13,7 +13,6 @@ end def execute - puts @match[1] if @match[1] signame = @match[1] unless Signal.list.member?...
Remove annoying debug print that has been around for a while.
diff --git a/lib/conceptql/query_modifiers/gdm/provider_query_modifier.rb b/lib/conceptql/query_modifiers/gdm/provider_query_modifier.rb index abc1234..def5678 100644 --- a/lib/conceptql/query_modifiers/gdm/provider_query_modifier.rb +++ b/lib/conceptql/query_modifiers/gdm/provider_query_modifier.rb @@ -25,7 +25,7 @@ ...
Fix issue with Union and CTEs
diff --git a/lib/flying_sphinx/binary.rb b/lib/flying_sphinx/binary.rb index abc1234..def5678 100644 --- a/lib/flying_sphinx/binary.rb +++ b/lib/flying_sphinx/binary.rb @@ -1,9 +1,6 @@ module FlyingSphinx::Binary def self.load require 'flying_sphinx/binary/translator' - require 'flying_sphinx/binary/delayed_...
Remove old delayed job files from Binary interface.
diff --git a/lib/frontend_server/rack.rb b/lib/frontend_server/rack.rb index abc1234..def5678 100644 --- a/lib/frontend_server/rack.rb +++ b/lib/frontend_server/rack.rb @@ -8,8 +8,6 @@ self.class.configurations.each do |configuration| configuration.call builder, config end - - # builder.use :...
Remove reference to Rack::Deflate. Seems to blow up aganist production
diff --git a/lib/health_inspector/cli.rb b/lib/health_inspector/cli.rb index abc1234..def5678 100644 --- a/lib/health_inspector/cli.rb +++ b/lib/health_inspector/cli.rb @@ -17,7 +17,7 @@ [ cookbooks, databags, environments, roles ] EOS - def inspect(component=nil) + def inspect(component="") checkli...
Fix bug when passing no component
diff --git a/rgversion.gemspec b/rgversion.gemspec index abc1234..def5678 100644 --- a/rgversion.gemspec +++ b/rgversion.gemspec @@ -24,7 +24,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.15" + spec....
Update bundler version for development.
diff --git a/lib/rack/instrumentation.rb b/lib/rack/instrumentation.rb index abc1234..def5678 100644 --- a/lib/rack/instrumentation.rb +++ b/lib/rack/instrumentation.rb @@ -20,7 +20,7 @@ response rescue Exception => raised - instrument 'exception', 1, source: 'rack', type: 'count' + instr...
Use rack.exception as metric name.
diff --git a/lib/ropian/meter/raritan.rb b/lib/ropian/meter/raritan.rb index abc1234..def5678 100644 --- a/lib/ropian/meter/raritan.rb +++ b/lib/ropian/meter/raritan.rb @@ -1,6 +1,9 @@ module Ropian module Meter class Raritan + UnitCurrent = SNMP::ObjectId.new("1.3.6.1.4.1.13742.4.1.4.2.1.3.1") + Outl...
Add collection method for gathering all outlet details at once
diff --git a/lib/shex/extensions/test.rb b/lib/shex/extensions/test.rb index abc1234..def5678 100644 --- a/lib/shex/extensions/test.rb +++ b/lib/shex/extensions/test.rb @@ -6,21 +6,23 @@ # @see http://shex.io/extensions/Test/ require 'shex' -class ShEx::Test < ShEx::Extension("http://shex.io/extensions/Test/") - # ...
Update Test class definition to fix yardoc issue.
diff --git a/ruby/lib/bson/registry.rb b/ruby/lib/bson/registry.rb index abc1234..def5678 100644 --- a/ruby/lib/bson/registry.rb +++ b/ruby/lib/bson/registry.rb @@ -43,8 +43,15 @@ # @since 2.0.0 def register(byte, type) MAPPINGS.store(byte, type) - type.define_method(:bson_type) { byte } + def...
Use module_eval to define the type reader. This is so we follow normal method binding.
diff --git a/lib/tasks/mingle_tasks.rake b/lib/tasks/mingle_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/mingle_tasks.rake +++ b/lib/tasks/mingle_tasks.rake @@ -2,12 +2,18 @@ desc "Fetch everything" task fetch: ['twitter:fetch', 'facebook:fetch', 'instagram:fetch'] + task clear: ['twitter:clear', 'f...
Implement rake tasks for clearing photos, tweets and posts
diff --git a/lib/uniq_martin/brew_cli.rb b/lib/uniq_martin/brew_cli.rb index abc1234..def5678 100644 --- a/lib/uniq_martin/brew_cli.rb +++ b/lib/uniq_martin/brew_cli.rb @@ -5,7 +5,7 @@ # Only accept invocation via `brew`. unless defined?(HOMEBREW_LIBRARY_PATH) - brew_command = File.basename($PROGRAM_NAME, ".rb").tr...
lib: Fix error message for direct invocation For commands that contain dashes our error message suggested to run via `brew random command`, but that should have been `brew random-command`.
diff --git a/ember-handlebars-template.gemspec b/ember-handlebars-template.gemspec index abc1234..def5678 100644 --- a/ember-handlebars-template.gemspec +++ b/ember-handlebars-template.gemspec @@ -18,7 +18,7 @@ spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ['lib'] ...
Allow older version of sprockets for Rails 3
diff --git a/providers/node.rb b/providers/node.rb index abc1234..def5678 100644 --- a/providers/node.rb +++ b/providers/node.rb @@ -1,10 +1,6 @@-begin - require 'zookeeper' -rescue LoadError - Chef::Log.warn("Missing gem 'zookeeper'") -end def get_zk() + require 'zookeeper' # todo: memoize return Zookeeper...
Revert "put require in try/catch" This reverts commit 5ce207567b81245d50ac903bea75f9630ca9f733. since this gets loaded a compile time, we cannot install the gem from a recipe.
diff --git a/spec/features/user_sign_up_spec.rb b/spec/features/user_sign_up_spec.rb index abc1234..def5678 100644 --- a/spec/features/user_sign_up_spec.rb +++ b/spec/features/user_sign_up_spec.rb @@ -2,7 +2,11 @@ describe "the signin process", :type => :feature do scenario 'with valid email and password' do - ...
Add Integration Spec for user sign up feature.
diff --git a/spec/features/slug_spec.rb b/spec/features/slug_spec.rb index abc1234..def5678 100644 --- a/spec/features/slug_spec.rb +++ b/spec/features/slug_spec.rb @@ -12,14 +12,14 @@ expect(page.status_code).to be(200) end - describe 'changing the firstname slug' do + describe 'changing the firstna...
Change the name from ada to adam in the slug test
diff --git a/spec/fixtures/factories.rb b/spec/fixtures/factories.rb index abc1234..def5678 100644 --- a/spec/fixtures/factories.rb +++ b/spec/fixtures/factories.rb @@ -0,0 +1,20 @@+FactoryGirl.define do + factory :user do + sequence(:uid) { |n| "uid-#{n}"} + sequence(:name) { |n| "Joe Bloggs #{n}" } + sequence(...
Add factory for CMA user
diff --git a/spec/support/generators.rb b/spec/support/generators.rb index abc1234..def5678 100644 --- a/spec/support/generators.rb +++ b/spec/support/generators.rb @@ -24,6 +24,7 @@ FileUtils.cp_r dummy_app_template_path, dummy_app_path, remove_destination: true ...
Raise proper error if creating the dummy app fails
diff --git a/lib/behavior_tree/branch_nodes.rb b/lib/behavior_tree/branch_nodes.rb index abc1234..def5678 100644 --- a/lib/behavior_tree/branch_nodes.rb +++ b/lib/behavior_tree/branch_nodes.rb @@ -32,6 +32,11 @@ end end + # A Sequence is a branch node that evaluates its children in order until one + # of the...
Add some RDoc to branch node classes.
diff --git a/Casks/appfresh.rb b/Casks/appfresh.rb index abc1234..def5678 100644 --- a/Casks/appfresh.rb +++ b/Casks/appfresh.rb @@ -9,6 +9,8 @@ license :commercial tags :vendor => 'metaquark' + uninstall :launchctl => 'de.metaquark.appfresh' + zap :delete => [ '~/Library/Application Support/AppFresh', ...
Add uninstall :launchctl for AppFresh.app
diff --git a/spec/active_record/turntable/active_record_ext/migration_spec.rb b/spec/active_record/turntable/active_record_ext/migration_spec.rb index abc1234..def5678 100644 --- a/spec/active_record/turntable/active_record_ext/migration_spec.rb +++ b/spec/active_record/turntable/active_record_ext/migration_spec.rb @@ ...
Add migration versioning numbers when creating `Migration` instances
diff --git a/lib/ditty/policies/user_policy.rb b/lib/ditty/policies/user_policy.rb index abc1234..def5678 100644 --- a/lib/ditty/policies/user_policy.rb +++ b/lib/ditty/policies/user_policy.rb @@ -26,7 +26,7 @@ end def delete? - create? && user.super_admin? == false + create? && record&.super_admin...
fix: Allow user deletion, but can't delete super users
diff --git a/lib/i18n/tasks/locale_pathname.rb b/lib/i18n/tasks/locale_pathname.rb index abc1234..def5678 100644 --- a/lib/i18n/tasks/locale_pathname.rb +++ b/lib/i18n/tasks/locale_pathname.rb @@ -10,7 +10,7 @@ private def path_locale_re(locale) - (@path_locale_res ||= {})[locale] ||= %r{(?<=^|[/....
Allow dash in locale filenames when merging data
diff --git a/lib/vagrant-digitalocean/actions/shut_down.rb b/lib/vagrant-digitalocean/actions/shut_down.rb index abc1234..def5678 100644 --- a/lib/vagrant-digitalocean/actions/shut_down.rb +++ b/lib/vagrant-digitalocean/actions/shut_down.rb @@ -15,11 +15,13 @@ def call(env) # submit shutdown drople...
Update shutdown request to API v2 Resolves #215
diff --git a/lib/tasks/resynch_activities.rake b/lib/tasks/resynch_activities.rake index abc1234..def5678 100644 --- a/lib/tasks/resynch_activities.rake +++ b/lib/tasks/resynch_activities.rake @@ -0,0 +1,14 @@+namespace :activities do + desc "update names of activity states" + task resync: :environment do + projec...
Allow resync of activity states based on data element name
diff --git a/sinatra-assetpack.gemspec b/sinatra-assetpack.gemspec index abc1234..def5678 100644 --- a/sinatra-assetpack.gemspec +++ b/sinatra-assetpack.gemspec @@ -23,4 +23,5 @@ s.add_development_dependency "mocha" s.add_development_dependency "stylus" s.add_development_dependency "uglifier" + s.add_developme...
Add missing depedency for development unit test
diff --git a/lib/vidibus/user/warden/helper.rb b/lib/vidibus/user/warden/helper.rb index abc1234..def5678 100644 --- a/lib/vidibus/user/warden/helper.rb +++ b/lib/vidibus/user/warden/helper.rb @@ -43,7 +43,7 @@ # Returns protocol depending on SERVER_PORT. def protocol - env['SERVER_PORT'] ==...
Fix check of SERVER_PORT env variable
diff --git a/spec/models/booking_template_spec.rb b/spec/models/booking_template_spec.rb index abc1234..def5678 100644 --- a/spec/models/booking_template_spec.rb +++ b/spec/models/booking_template_spec.rb @@ -8,10 +8,11 @@ end it 'should call build_booking on the matching template' do - expect {Bo...
Fix unfinished spec for BookingTemplate.build_booking.
diff --git a/spec/unit/plugins/aix/memory_spec.rb b/spec/unit/plugins/aix/memory_spec.rb index abc1234..def5678 100644 --- a/spec/unit/plugins/aix/memory_spec.rb +++ b/spec/unit/plugins/aix/memory_spec.rb @@ -0,0 +1,35 @@+# +# License:: Apache License, Version 2.0 +# +# Licensed under the Apache License, Version 2.0 (t...
Add unit test for aix memory plugin
diff --git a/OneTimePassword.podspec b/OneTimePassword.podspec index abc1234..def5678 100644 --- a/OneTimePassword.podspec +++ b/OneTimePassword.podspec @@ -10,4 +10,14 @@ s.source_files = "OneTimePassword/**/*.{swift}" s.requires_arc = true s.dependency "Base32", "~> 1.0.2" + s.pod_target_xcconfig = { + "S...
Use CommonCrypto modulemaps with the pod This blog post provided helpful instructions: https://ind.ie/labs/blog/using-system-headers-in-swift/
diff --git a/JSONModel.podspec b/JSONModel.podspec index abc1234..def5678 100644 --- a/JSONModel.podspec +++ b/JSONModel.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "JSONModel" - s.version = "1.2.3" + s.version = "1.2.4" s.summary = "Magical Data Modelling Framework for JSON. Cr...
Update to 1.2.4, change Cocoalumberjack dependency to 3.0
diff --git a/rack-logs.gemspec b/rack-logs.gemspec index abc1234..def5678 100644 --- a/rack-logs.gemspec +++ b/rack-logs.gemspec @@ -20,8 +20,17 @@ spec.add_runtime_dependency "rack", "~> 1.5.2" + if RUBY_VERSION.to_f < 1.9 || RUBY_VERSION == '1.9.2' + spec.add_development_dependency "rake", "~> 10.0.0" + el...
Update rake to avoid CVE-2020-8130