diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/controllers/guest_users_controller.rb b/app/controllers/guest_users_controller.rb index abc1234..def5678 100644 --- a/app/controllers/guest_users_controller.rb +++ b/app/controllers/guest_users_controller.rb @@ -8,6 +8,16 @@ end def create + @guest_user = GuestUser.new(guest_user_params) + + ...
Update guest users create action
diff --git a/app/controllers/import/base_controller.rb b/app/controllers/import/base_controller.rb index abc1234..def5678 100644 --- a/app/controllers/import/base_controller.rb +++ b/app/controllers/import/base_controller.rb @@ -8,7 +8,7 @@ namespace.add_owner(current_user) rescue ActiveRecord::RecordNotUniq...
Allow projects to be imported into namespaces user is master of.
diff --git a/lib/a2ws.rb b/lib/a2ws.rb index abc1234..def5678 100644 --- a/lib/a2ws.rb +++ b/lib/a2ws.rb @@ -5,6 +5,7 @@ $:.unshift File.join(File.dirname(__FILE__),'..','lib') require 'a2ws/base' +require 'a2ws/methodize' require 'a2ws/item' require 'a2ws/image' require 'a2ws/item_search'
Include the methodize file in the gem now.
diff --git a/app/service/neighborhood_services/vacancy_data/filters/tax_delinquent.rb b/app/service/neighborhood_services/vacancy_data/filters/tax_delinquent.rb index abc1234..def5678 100644 --- a/app/service/neighborhood_services/vacancy_data/filters/tax_delinquent.rb +++ b/app/service/neighborhood_services/vacancy_da...
Fix Broken Tax Deinquent Link
diff --git a/feidee_utils.gemspec b/feidee_utils.gemspec index abc1234..def5678 100644 --- a/feidee_utils.gemspec +++ b/feidee_utils.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = 'feidee_utils' - s.version = '0.0.0' + s.version = '0.0.1' s.date = '2015-05-01' s.summary ...
Bump version up to 0.0.1.
diff --git a/test/partial_finder_test.rb b/test/partial_finder_test.rb index abc1234..def5678 100644 --- a/test/partial_finder_test.rb +++ b/test/partial_finder_test.rb @@ -1,11 +1,16 @@ require 'test_helper' describe Lotus::View::Rendering::PartialFinder do - it 'finds the correct partial' do + it 'finds the corr...
Add a new test for PartialFinder and shared partials
diff --git a/lib/flop.rb b/lib/flop.rb index abc1234..def5678 100644 --- a/lib/flop.rb +++ b/lib/flop.rb @@ -6,7 +6,11 @@ module Flop class << self - attr_accessor :repo + attr_writer :repo + + def repo + @repo ||= Flop::Repository::Memory.new + end def [](feature) Flop::Feature.new(...
Use a memory repository by default
diff --git a/spec/features/backend/flexible_content/duplicate_spec.rb b/spec/features/backend/flexible_content/duplicate_spec.rb index abc1234..def5678 100644 --- a/spec/features/backend/flexible_content/duplicate_spec.rb +++ b/spec/features/backend/flexible_content/duplicate_spec.rb @@ -0,0 +1,54 @@+require 'rails_hel...
Add feature spec for the flexible content duplication.
diff --git a/similarweb.gemspec b/similarweb.gemspec index abc1234..def5678 100644 --- a/similarweb.gemspec +++ b/similarweb.gemspec @@ -22,6 +22,7 @@ spec.add_development_dependency "rake" spec.add_development_dependency "rspec" spec.add_development_dependency "pry" + spec.add_development_dependency "pry-byeb...
Add pry to debug code
diff --git a/app/controllers/auth_controller.rb b/app/controllers/auth_controller.rb index abc1234..def5678 100644 --- a/app/controllers/auth_controller.rb +++ b/app/controllers/auth_controller.rb @@ -7,7 +7,7 @@ def sign_in_action return error! "Missing parameters", 400 unless [:email, :password].none? { |x| pa...
Fix error when logging in by username
diff --git a/app/helpers/forem/topics_helper.rb b/app/helpers/forem/topics_helper.rb index abc1234..def5678 100644 --- a/app/helpers/forem/topics_helper.rb +++ b/app/helpers/forem/topics_helper.rb @@ -2,7 +2,7 @@ module TopicsHelper def link_to_latest_post(post) text = "#{time_ago_in_words(post.created_at...
Remove forem prefix from forum_topic_path call in link_to_latest_post
diff --git a/app/mailers/organization_mailer.rb b/app/mailers/organization_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/organization_mailer.rb +++ b/app/mailers/organization_mailer.rb @@ -1,6 +1,6 @@ class OrganizationMailer < ActionMailer::Base - default :from => %{"#{ORG::NAME}" <noreply@#{ORG::...
Allow for emails to be verified
diff --git a/app/serializers/post_serializer.rb b/app/serializers/post_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/post_serializer.rb +++ b/app/serializers/post_serializer.rb @@ -1,5 +1,5 @@ class PostSerializer < BaseSerializer - attributes :id, :title, :text, :published_at + attributes :id, :t...
Add author name to the serializer
diff --git a/lib/brightbox-cli/server_groups.rb b/lib/brightbox-cli/server_groups.rb index abc1234..def5678 100644 --- a/lib/brightbox-cli/server_groups.rb +++ b/lib/brightbox-cli/server_groups.rb @@ -34,7 +34,7 @@ end def self.get(id) - conn.server_groups.get id + conn.get_server_group id end...
Use a request to fetch a server group
diff --git a/lib/openstax/rescue_from/logger.rb b/lib/openstax/rescue_from/logger.rb index abc1234..def5678 100644 --- a/lib/openstax/rescue_from/logger.rb +++ b/lib/openstax/rescue_from/logger.rb @@ -23,10 +23,6 @@ record_system_error!("Exception cause") end end - - def config - R...
Remove unused config method in Logger
diff --git a/gravatar-api.gemspec b/gravatar-api.gemspec index abc1234..def5678 100644 --- a/gravatar-api.gemspec +++ b/gravatar-api.gemspec @@ -7,18 +7,15 @@ spec.version = VERSION spec.authors = ["Jesse Herrick"] spec.email = ["jessegrantherrick@gmail.com"] - spec.description = %q{Easy,...
Add some things to the gemspec.
diff --git a/lib/ab_admin/menu/builder.rb b/lib/ab_admin/menu/builder.rb index abc1234..def5678 100644 --- a/lib/ab_admin/menu/builder.rb +++ b/lib/ab_admin/menu/builder.rb @@ -4,8 +4,9 @@ include ::Singleton def self.draw(&block) - I18n.locale = AbAdmin.locale if AbAdmin.locale - instance....
Use with_locale for menu draw
diff --git a/jekyll-typographic-apostrophe.rb b/jekyll-typographic-apostrophe.rb index abc1234..def5678 100644 --- a/jekyll-typographic-apostrophe.rb +++ b/jekyll-typographic-apostrophe.rb @@ -7,7 +7,7 @@ private def convert(page_or_post) - page_or_post.content.gsub!(/(\w)('|&#39|&apos;)/,...
Make it harder to accidently convert ' inside code blocks
diff --git a/lib/core/repositories/api.rb b/lib/core/repositories/api.rb index abc1234..def5678 100644 --- a/lib/core/repositories/api.rb +++ b/lib/core/repositories/api.rb @@ -18,6 +18,7 @@ self.connection = Faraday.new(options) do |faraday| faraday.request :json faraday.request :request_...
Add retry middleware to API repository
diff --git a/lib/eye/patch/capistrano3.rb b/lib/eye/patch/capistrano3.rb index abc1234..def5678 100644 --- a/lib/eye/patch/capistrano3.rb +++ b/lib/eye/patch/capistrano3.rb @@ -0,0 +1,46 @@+namespace :load do + + task :defaults do + set :eye_config, -> { "config/eye.yml" } + set :eye_bin, -> { "bundle exec eye-p...
Add capistrano extension file for Capistrano v3
diff --git a/lib/hash_builder/template.rb b/lib/hash_builder/template.rb index abc1234..def5678 100644 --- a/lib/hash_builder/template.rb +++ b/lib/hash_builder/template.rb @@ -11,12 +11,18 @@ def self.call (template) render_code = <<-RUBY -(HashBuilder.build_with_env(scope: self, locals: local_assigns) do...
Work around an ActiveModel bug
diff --git a/lib/cccb/modules/choice.rb b/lib/cccb/modules/choice.rb index abc1234..def5678 100644 --- a/lib/cccb/modules/choice.rb +++ b/lib/cccb/modules/choice.rb @@ -8,11 +8,16 @@ def module_load add_command :choice, "choose" do |message, args| choices = args.join(' ').split( /(?:\s+(?:\s*(?:x?or(?=\W)...
Make user frequency option work
diff --git a/week-4/calculate-grade/my_solution.rb b/week-4/calculate-grade/my_solution.rb index abc1234..def5678 100644 --- a/week-4/calculate-grade/my_solution.rb +++ b/week-4/calculate-grade/my_solution.rb @@ -1,6 +1,6 @@ # Calculate a Grade -# I worked on this challenge [by myself]. +# I worked on this challenge ...
Add credit fro Clinton on Challenge
diff --git a/lib/gakubuchi/fileutils.rb b/lib/gakubuchi/fileutils.rb index abc1234..def5678 100644 --- a/lib/gakubuchi/fileutils.rb +++ b/lib/gakubuchi/fileutils.rb @@ -17,7 +17,7 @@ private def logging(message) - ::Logger.new(STDOUT).info(message) + ::Logger.new(::STDOUT).info(message) ...
Add prefix "::" to STDOUT for consistency
diff --git a/lib/rusic/uploaders/asset.rb b/lib/rusic/uploaders/asset.rb index abc1234..def5678 100644 --- a/lib/rusic/uploaders/asset.rb +++ b/lib/rusic/uploaders/asset.rb @@ -8,10 +8,10 @@ private def params - { asset: { file: file } } + { asset: { file: asset } } end - def ...
Use method name that doesn't clash with file
diff --git a/lib/simctl/command/create.rb b/lib/simctl/command/create.rb index abc1234..def5678 100644 --- a/lib/simctl/command/create.rb +++ b/lib/simctl/command/create.rb @@ -25,6 +25,7 @@ def reset_device(name, device_type, runtime) begin list_devices.where(name: name, os: runtime.name).eac...
Make reset_device also kill the device
diff --git a/lib/travis/logs/existence.rb b/lib/travis/logs/existence.rb index abc1234..def5678 100644 --- a/lib/travis/logs/existence.rb +++ b/lib/travis/logs/existence.rb @@ -21,7 +21,9 @@ end def occupied!(channel_name) - redis.set(key(channel_name), true) + key = self.key(channel_name) ...
Expire occupation keys after 6 hours
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -1,14 +1,16 @@ class PagesController < ApplicationController append_view_path "pages" layout :layout_by_path +...
Define index action for homepage - To remove the confusion of where the home page is defined, making it easier to understand what is happening - Also removing one branch in the layout conditional
diff --git a/app/controllers/posts_controller.rb b/app/controllers/posts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/posts_controller.rb +++ b/app/controllers/posts_controller.rb @@ -1,31 +1,43 @@ class PostsController < ApplicationController - def index - @posts = Post.all + def index + ...
Add index, show, and create/new actions to PostsController
diff --git a/app/controllers/stats_controller.rb b/app/controllers/stats_controller.rb index abc1234..def5678 100644 --- a/app/controllers/stats_controller.rb +++ b/app/controllers/stats_controller.rb @@ -1,8 +1,9 @@ class StatsController < ApplicationController def index - procedures = Procedure.where(created_...
Fix the where clause in Stats Now properly show the last 90 days of data instead of strict quarters. With the previous code, on the 1st of january, april, july and october, only one day of data would be shown.
diff --git a/lib/bud/errors.rb b/lib/bud/errors.rb index abc1234..def5678 100644 --- a/lib/bud/errors.rb +++ b/lib/bud/errors.rb @@ -1,6 +1,6 @@ module Bud # Root Bud exception type. - class BudError < Exception; end + class BudError < StandardError; end # Raised (at runtime) when a type mismatch occurs (e.g....
Make BudError subclass StandardError, not Exception. This is apparently what you're supposed to do when defining custom Ruby exceptions.
diff --git a/app/queries/project_filter_query.rb b/app/queries/project_filter_query.rb index abc1234..def5678 100644 --- a/app/queries/project_filter_query.rb +++ b/app/queries/project_filter_query.rb @@ -27,7 +27,9 @@ case current_filter when FILTER_TODO - items = items.todo + items = items + ...
Order the project items the same way as the spreadsheet Order by the id field, as this will reflect the order in which the items were imported from the spreadsheet.
diff --git a/lib/synchro/synchronize.rb b/lib/synchro/synchronize.rb index abc1234..def5678 100644 --- a/lib/synchro/synchronize.rb +++ b/lib/synchro/synchronize.rb @@ -7,7 +7,7 @@ module ClassMethods def synchronize - after_create :synchronize + after_create :synchro_synchronize end ...
Fix method name; use logger instead of puts
diff --git a/lib/tasks/experiments.rake b/lib/tasks/experiments.rake index abc1234..def5678 100644 --- a/lib/tasks/experiments.rake +++ b/lib/tasks/experiments.rake @@ -1,6 +1,7 @@ # frozen_string_literal: true require "#{Rails.root}/lib/experiments/fall2017_cmu_experiment" +require "#{Rails.root}/lib/experiments/sp...
Fix require statement for new experiment
diff --git a/lib/tasks/multi_spork.rake b/lib/tasks/multi_spork.rake index abc1234..def5678 100644 --- a/lib/tasks/multi_spork.rake +++ b/lib/tasks/multi_spork.rake @@ -1,12 +1,10 @@ require 'active_record' require 'multi_spork' -require 'ruby-debug' namespace :multi_spork do namespace :testdbs do desc "Clo...
Correct rake task used to clone test dbs
diff --git a/lib/flipper/ui.rb b/lib/flipper/ui.rb index abc1234..def5678 100644 --- a/lib/flipper/ui.rb +++ b/lib/flipper/ui.rb @@ -12,6 +12,9 @@ module Flipper module UI class << self + # Public: If you set this, the UI will always have a first breadcrumb that + # says "App" which points to this hre...
Add docs for app crumb href option
diff --git a/test_changes.gemspec b/test_changes.gemspec index abc1234..def5678 100644 --- a/test_changes.gemspec +++ b/test_changes.gemspec @@ -28,7 +28,7 @@ spec.add_dependency "slop", '~> 4.2.0' - spec.add_development_dependency "rake", "~> 10.0" + spec.add_development_dependency 'rake', '~> 13.0.1', '>= 12....
Fix CVE-2020-8130 issue with rake
diff --git a/raven/spec/raven/raven_spec.rb b/raven/spec/raven/raven_spec.rb index abc1234..def5678 100644 --- a/raven/spec/raven/raven_spec.rb +++ b/raven/spec/raven/raven_spec.rb @@ -5,41 +5,41 @@ shared_examples 'a configured client' do it 'should have a server' do - @client.server.should == 'http://se...
Use the rspec concept of a subject.
diff --git a/lib/expando/project_template.rb b/lib/expando/project_template.rb index abc1234..def5678 100644 --- a/lib/expando/project_template.rb +++ b/lib/expando/project_template.rb @@ -5,6 +5,25 @@ def init! mkdir 'intents' mkdir 'entities' + + config_file_contents = <<-CONFIG_FILE +#...
Enable creating config files when initializing project
diff --git a/features/steps/file_steps.rb b/features/steps/file_steps.rb index abc1234..def5678 100644 --- a/features/steps/file_steps.rb +++ b/features/steps/file_steps.rb @@ -21,6 +21,7 @@ FileUtils.chdir(directory) end After do + FileUtils.chdir(OriginalWorkingDirectory) cleanup.each { |dir| FileUtils.rm_rf(...
Move back to original dir before removing CWD
diff --git a/lib/ffi-gobject/ruby_closure.rb b/lib/ffi-gobject/ruby_closure.rb index abc1234..def5678 100644 --- a/lib/ffi-gobject/ruby_closure.rb +++ b/lib/ffi-gobject/ruby_closure.rb @@ -6,21 +6,21 @@ class RubyClosure < Closure BLOCK_STORE = {} - # Extend the standard GClosure layout with a field blockha...
Improve variable naming in RubyClosure.
diff --git a/lib/lanes/api/helper_methods.rb b/lib/lanes/api/helper_methods.rb index abc1234..def5678 100644 --- a/lib/lanes/api/helper_methods.rb +++ b/lib/lanes/api/helper_methods.rb @@ -4,7 +4,7 @@ module HelperMethods def bootstrap_data - Oj.dump Extension.bootstrap_data(self) ...
Use compat mode for hashes with symbol keys
diff --git a/lib/origen/errata/hw_erratum.rb b/lib/origen/errata/hw_erratum.rb index abc1234..def5678 100644 --- a/lib/origen/errata/hw_erratum.rb +++ b/lib/origen/errata/hw_erratum.rb @@ -32,7 +32,7 @@ # Software workaround object associated with erratum attr_accessor :sw_workaround - def initializ...
Make affected_items an arrary instead of hash
diff --git a/lib/peddler/flat_file_parser.rb b/lib/peddler/flat_file_parser.rb index abc1234..def5678 100644 --- a/lib/peddler/flat_file_parser.rb +++ b/lib/peddler/flat_file_parser.rb @@ -41,7 +41,7 @@ def scrub_content content .force_encoding(encoding) - .encode('UTF-8', undef: :replace, re...
Replace invalid chars when massaging encoding
diff --git a/cri.gemspec b/cri.gemspec index abc1234..def5678 100644 --- a/cri.gemspec +++ b/cri.gemspec @@ -15,7 +15,7 @@ s.files = Dir['[A-Z]*'] + Dir['{lib,test}/**/*'] + - [ 'cri.gemspec', '.gemtest' ] + [ 'cri.gemspec' ] ...
Remove removed files from gemspec
diff --git a/lib/pubsubstub/redis_pub_sub.rb b/lib/pubsubstub/redis_pub_sub.rb index abc1234..def5678 100644 --- a/lib/pubsubstub/redis_pub_sub.rb +++ b/lib/pubsubstub/redis_pub_sub.rb @@ -13,8 +13,7 @@ end def publish(event) - RedisPubSub.pub.publish(key('pubsub'), event.to_json) - RedisPubSub.red...
Make it easier to publish from elsewhere
diff --git a/lib/rom/support/class_macros.rb b/lib/rom/support/class_macros.rb index abc1234..def5678 100644 --- a/lib/rom/support/class_macros.rb +++ b/lib/rom/support/class_macros.rb @@ -7,8 +7,6 @@ args.each do |name| mod.module_eval <<-RUBY, __FILE__, __LINE__ + 1 - @@macros = [#{args.map(...
Fix code generation of ClassMacros Before this commit ClassMacros defined one `inherited` hook once per macro. This commit separates the definition of accessors and other definitions.
diff --git a/config/initializers/inflections.rb b/config/initializers/inflections.rb index abc1234..def5678 100644 --- a/config/initializers/inflections.rb +++ b/config/initializers/inflections.rb @@ -16,7 +16,7 @@ # end ActiveSupport::Inflector.inflections do |inflect| - inflect.plural /Secretary of State for (.*)...
Generalize the plural for secretary of state
diff --git a/lib/sensu-plugins-kubernetes.rb b/lib/sensu-plugins-kubernetes.rb index abc1234..def5678 100644 --- a/lib/sensu-plugins-kubernetes.rb +++ b/lib/sensu-plugins-kubernetes.rb @@ -20,12 +20,40 @@ long: '--api-version', default: 'v1' + option :ca_f...
Add additional parameters for Kubernetes
diff --git a/lib/rails_uploads/types/image.rb b/lib/rails_uploads/types/image.rb index abc1234..def5678 100644 --- a/lib/rails_uploads/types/image.rb +++ b/lib/rails_uploads/types/image.rb @@ -53,7 +53,7 @@ end def store_path(*args) - ::File.join('images', (args[0] ? args[0].to_s : 'original')) + ...
Use dash in presets name
diff --git a/lib/rubycritic/analysers/reek.rb b/lib/rubycritic/analysers/reek.rb index abc1234..def5678 100644 --- a/lib/rubycritic/analysers/reek.rb +++ b/lib/rubycritic/analysers/reek.rb @@ -4,7 +4,7 @@ module Analyser class Reek < ::Reek::Examiner - DEFAULT_CONFIG_FILES = ["lib/rubycritic/analysers/con...
Make path to a config file relative to the current file
diff --git a/lib/friendly_id/slug_generator.rb b/lib/friendly_id/slug_generator.rb index abc1234..def5678 100644 --- a/lib/friendly_id/slug_generator.rb +++ b/lib/friendly_id/slug_generator.rb @@ -2,7 +2,6 @@ # The default slug generator offers functionality to check slug strings for # uniqueness and, if necessary...
Remove unused model_class attribute from SlugGenerator
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -17,7 +17,8 @@ "R" => "Non-resident (Canada only)" } -res = ask 'Would you like to seed use codes? [Y/n]' +res = defined?(ask) ? ask('Would you like to seed use codes? [Y/n]') : '' + if res == '' || res.dow...
Fix undefined method `ask' ERROR
diff --git a/lib/lita/handlers/digitalocean.rb b/lib/lita/handlers/digitalocean.rb index abc1234..def5678 100644 --- a/lib/lita/handlers/digitalocean.rb +++ b/lib/lita/handlers/digitalocean.rb @@ -21,12 +21,12 @@ def dispatch(response) submodule_name, subcommand_name, *_args = response.args - su...
Convert incoming commands to strings in case they are nil.
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -4,6 +4,7 @@ User.destroy_all List.destroy_all Item.destroy_all +Recipe.destroy_all all_lists = [ "Jewel Osco - Sunday", @@ -36,6 +37,18 @@ "Eggs" ].map { |name| Item.create!(name: name) } + +all_rec...
Update seed file to include recipes
diff --git a/app/controllers/carto/builder/public/embeds_controller.rb b/app/controllers/carto/builder/public/embeds_controller.rb index abc1234..def5678 100644 --- a/app/controllers/carto/builder/public/embeds_controller.rb +++ b/app/controllers/carto/builder/public/embeds_controller.rb @@ -14,10 +14,10 @@ s...
Fix layout of protected embed
diff --git a/spec/policies/neighborly/admin/admin_policy_spec.rb b/spec/policies/neighborly/admin/admin_policy_spec.rb index abc1234..def5678 100644 --- a/spec/policies/neighborly/admin/admin_policy_spec.rb +++ b/spec/policies/neighborly/admin/admin_policy_spec.rb @@ -4,18 +4,18 @@ subject { described_class } pe...
Refactor admin policy to use expect
diff --git a/send_url_list_through_proxy.rb b/send_url_list_through_proxy.rb index abc1234..def5678 100644 --- a/send_url_list_through_proxy.rb +++ b/send_url_list_through_proxy.rb @@ -0,0 +1,16 @@+#!/usr/bin/env ruby + +# +# Requests a list of URLs through a proxy. +# + +require 'typhoeus' + +urls = File.open(ARGV.jo...
Add send urls through proxy script
diff --git a/backend/spec/routing/comable/admin/themes_routing_spec.rb b/backend/spec/routing/comable/admin/themes_routing_spec.rb index abc1234..def5678 100644 --- a/backend/spec/routing/comable/admin/themes_routing_spec.rb +++ b/backend/spec/routing/comable/admin/themes_routing_spec.rb @@ -0,0 +1,48 @@+describe Comab...
Add tests for the routing
diff --git a/lib/basil/skype_message.rb b/lib/basil/skype_message.rb index abc1234..def5678 100644 --- a/lib/basil/skype_message.rb +++ b/lib/basil/skype_message.rb @@ -8,7 +8,7 @@ (?<to>\w+)[,;:]\s+ # using punctuation )? (?<text>.*)$ # rest of message - /x + /m...
Return all lines of the BODY in SkypeMessage
diff --git a/spec/defines_spec_suite_tasks.rb b/spec/defines_spec_suite_tasks.rb index abc1234..def5678 100644 --- a/spec/defines_spec_suite_tasks.rb +++ b/spec/defines_spec_suite_tasks.rb @@ -33,6 +33,20 @@ end end end + + unless ruby_18? + require 'rspec/core/rake_task' + + ...
Add rake tasks for running unit and functional tests
diff --git a/spec/factories/reading_groups.rb b/spec/factories/reading_groups.rb index abc1234..def5678 100644 --- a/spec/factories/reading_groups.rb +++ b/spec/factories/reading_groups.rb @@ -11,10 +11,5 @@ name "My Reading Group" description "The best one" end - - factory :public_reading_group do...
Remove unused factory for ReadingGroup
diff --git a/lib/forecast/collection.rb b/lib/forecast/collection.rb index abc1234..def5678 100644 --- a/lib/forecast/collection.rb +++ b/lib/forecast/collection.rb @@ -1,15 +1,15 @@ class Forecast class Collection < Array - def select_date(date) + def select_time(time) result = nil date_forecast...
Select time instead of select date
diff --git a/spec/view_models/section_spec.rb b/spec/view_models/section_spec.rb index abc1234..def5678 100644 --- a/spec/view_models/section_spec.rb +++ b/spec/view_models/section_spec.rb @@ -0,0 +1,64 @@+describe Section do + + let(:title) { 'title' } + let(:paras) { %w{a b c} } + + it 'should initialize title' do...
Add unit test for section
diff --git a/calculators/bsa/bsa.rb b/calculators/bsa/bsa.rb index abc1234..def5678 100644 --- a/calculators/bsa/bsa.rb +++ b/calculators/bsa/bsa.rb @@ -5,8 +5,8 @@ weight = get_field_as_float :weight_in_kg height = get_field_as_float :height_in_m - raise FieldError.new('weight', 'must be greater than zero') if...
Use fail instead of raise to throw exceptions
diff --git a/activerecord/lib/active_record/associations/has_one_through_association.rb b/activerecord/lib/active_record/associations/has_one_through_association.rb index abc1234..def5678 100644 --- a/activerecord/lib/active_record/associations/has_one_through_association.rb +++ b/activerecord/lib/active_record/associa...
Use self.target= in HasOneThroughAssociation too
diff --git a/lib/mortgage_calculator.rb b/lib/mortgage_calculator.rb index abc1234..def5678 100644 --- a/lib/mortgage_calculator.rb +++ b/lib/mortgage_calculator.rb @@ -9,6 +9,10 @@ mattr_accessor :stamp_duty_welsh_fix mattr_accessor :affordability_enabled + def self.stamp_duty_welsh_fix + @@stamp_duty_welsh...
Revert "Revert "Default stamp duty welsh fix to a blank lambda"" This reverts commit 406b44dde3f2bec8431bd38babd783c2e6a85148.
diff --git a/lib/wlang/compiler/autospacing.rb b/lib/wlang/compiler/autospacing.rb index abc1234..def5678 100644 --- a/lib/wlang/compiler/autospacing.rb +++ b/lib/wlang/compiler/autospacing.rb @@ -28,9 +28,9 @@ when :static who.last =~ /\n/ when :wlang, :modulo - who[2..-1].any?{|s|...
Fix a bug in AutoScoping.
diff --git a/lita-talk.gemspec b/lita-talk.gemspec index abc1234..def5678 100644 --- a/lita-talk.gemspec +++ b/lita-talk.gemspec @@ -15,7 +15,7 @@ spec.require_paths = ["lib"] spec.add_runtime_dependency "lita", "~> 4.3" - spec.add_runtime_dependency "docomoru", "~> 0.1.3 " + spec.add_runtime_dependency "farad...
Use faraday instead of docomoru
diff --git a/spec/docstrings_spec.rb b/spec/docstrings_spec.rb index abc1234..def5678 100644 --- a/spec/docstrings_spec.rb +++ b/spec/docstrings_spec.rb @@ -1,11 +1,24 @@ require 'spec_helper' describe Docstrings do - it 'should have a version number' do - Docstrings::VERSION.should_not be_nil + class TestClass...
Add basic spec for docstrings
diff --git a/lib/tasks/pixelfinder.rake b/lib/tasks/pixelfinder.rake index abc1234..def5678 100644 --- a/lib/tasks/pixelfinder.rake +++ b/lib/tasks/pixelfinder.rake @@ -0,0 +1,23 @@+require 'pixelfinder/image_client/image_crawler' + +namespace :pixelfinder do + namespace :save_images do + + desc "Save images from F...
Add rake task for image crawler
diff --git a/spec/support/helpers.rb b/spec/support/helpers.rb index abc1234..def5678 100644 --- a/spec/support/helpers.rb +++ b/spec/support/helpers.rb @@ -2,3 +2,7 @@ def branch(*args, &block) args.map { |sym| ActiveSupport::StringInquirer.new sym.to_s }.each(&block) end + +def mingo_id + last_response.headers['...
Add 'mingo_id' as a proper spec helper.
diff --git a/spec/bin/churn_spec.rb b/spec/bin/churn_spec.rb index abc1234..def5678 100644 --- a/spec/bin/churn_spec.rb +++ b/spec/bin/churn_spec.rb @@ -2,7 +2,7 @@ describe "Churn command" do it "prints churn metrics as text by default" do - output = %x[ cd spec/samplerepo & churn ] + output = %x[ churn ] ...
Change directory when testing default `churn` command
diff --git a/spec/factories/user.rb b/spec/factories/user.rb index abc1234..def5678 100644 --- a/spec/factories/user.rb +++ b/spec/factories/user.rb @@ -1,6 +1,6 @@ FactoryGirl.define do factory :user do |user| - sequence(:email) {|n| "barry#{n}@factory.com" } + sequence(:email) {|n| "bar...
Stop using non-example emails in factories Noticed this when setting up ds-auth app, which had copy-pasta setup.
diff --git a/spec/nod/asset_spec.rb b/spec/nod/asset_spec.rb index abc1234..def5678 100644 --- a/spec/nod/asset_spec.rb +++ b/spec/nod/asset_spec.rb @@ -0,0 +1,22 @@+ +require 'spec_helper' + +RSpec.describe Nod::Asset, fakefs: true do + let(:asset) { Nod::Asset } + let(:project_name) { 'test-project' } + + describe...
Add spec for '::create_new_project' Nod::Asset class method
diff --git a/spec/02_create_request_spec.rb b/spec/02_create_request_spec.rb index abc1234..def5678 100644 --- a/spec/02_create_request_spec.rb +++ b/spec/02_create_request_spec.rb @@ -0,0 +1,48 @@+require 'spec_helper' + +RSpec.describe "Creating Defence Request" do + specify "CSO creates a new Defence Request" do + ...
Add first draft of the 'create request' test
diff --git a/spec/integration/smoke_test.rb b/spec/integration/smoke_test.rb index abc1234..def5678 100644 --- a/spec/integration/smoke_test.rb +++ b/spec/integration/smoke_test.rb @@ -1,77 +1,16 @@+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') require File.dirname(__FILE__) + '/../../lib/mouset...
Remove spike code, will be proper RSpec soon
diff --git a/spec/multiple_instance_spec.rb b/spec/multiple_instance_spec.rb index abc1234..def5678 100644 --- a/spec/multiple_instance_spec.rb +++ b/spec/multiple_instance_spec.rb @@ -0,0 +1,32 @@+require 'spec_helper' + +describe Fabrication do + + context 'multiple instance' do + + let(:person1) { Fabricate(:per...
Add spec for using multiple simultaneous instances
diff --git a/lib/one_one/resources/firewall_policy_resource.rb b/lib/one_one/resources/firewall_policy_resource.rb index abc1234..def5678 100644 --- a/lib/one_one/resources/firewall_policy_resource.rb +++ b/lib/one_one/resources/firewall_policy_resource.rb @@ -18,7 +18,19 @@ end action :create, 'POST /v1...
Add ability to associate vms with ip addresses
diff --git a/lib/smartdown_adapter/money_question_presenter.rb b/lib/smartdown_adapter/money_question_presenter.rb index abc1234..def5678 100644 --- a/lib/smartdown_adapter/money_question_presenter.rb +++ b/lib/smartdown_adapter/money_question_presenter.rb @@ -1,7 +1,7 @@ module SmartdownAdapter class MoneyQuestionP...
Change MoneyQuestionPresenter.to_response() to not return hash. Fixes display issue.
diff --git a/lib/tasks/gobierto_budgets/custom_categories.rake b/lib/tasks/gobierto_budgets/custom_categories.rake index abc1234..def5678 100644 --- a/lib/tasks/gobierto_budgets/custom_categories.rake +++ b/lib/tasks/gobierto_budgets/custom_categories.rake @@ -2,8 +2,8 @@ namespace :gobierto_budgets do namespace :...
Support custom categories upload in a given locale
diff --git a/judoscale-resque/test/latency_extension_test.rb b/judoscale-resque/test/latency_extension_test.rb index abc1234..def5678 100644 --- a/judoscale-resque/test/latency_extension_test.rb +++ b/judoscale-resque/test/latency_extension_test.rb @@ -0,0 +1,102 @@+# frozen_string_literal: true + +require "test_helper...
Add specific tests for the resque latency extension We stub the lower layer Redis to avoid needing to have it running for the tests, but it should help ensure the behavior of Resque that we expect to extend is working correctly for storing the timestamp and calculating latency on top of it.
diff --git a/name_resolution/name_resolver.rb b/name_resolution/name_resolver.rb index abc1234..def5678 100644 --- a/name_resolution/name_resolver.rb +++ b/name_resolution/name_resolver.rb @@ -1,6 +1,5 @@-require 'resolv' - class NameResolver < Scout::Plugin + needs 'resolv' OPTIONS=<<-EOS nameserver: ...
Use report instead of alert, as suggested by @ejaubaud
diff --git a/second_pass/test_second_fizzbuzz.rb b/second_pass/test_second_fizzbuzz.rb index abc1234..def5678 100644 --- a/second_pass/test_second_fizzbuzz.rb +++ b/second_pass/test_second_fizzbuzz.rb @@ -2,7 +2,7 @@ def assert(condition, failure_message) unless condition - raise failure_message + puts failu...
Use assert_equality to DRY up tests
diff --git a/griddler-cloudmailin.gemspec b/griddler-cloudmailin.gemspec index abc1234..def5678 100644 --- a/griddler-cloudmailin.gemspec +++ b/griddler-cloudmailin.gemspec @@ -6,7 +6,7 @@ Gem::Specification.new do |spec| spec.name = 'griddler-cloudmailin' spec.version = Griddler::Cloudmailin::VERS...
Fix rendering of authors string
diff --git a/akamai_api.gemspec b/akamai_api.gemspec index abc1234..def5678 100644 --- a/akamai_api.gemspec +++ b/akamai_api.gemspec @@ -18,7 +18,7 @@ gem.require_paths = ["lib"] gem.add_dependency 'active_support', '>= 2' - gem.add_dependency 'thor', '~> 0.14.0' + gem.add_dependency 'thor', ...
Allow Thor > 0.14 until 1.X since Thor uses schemantic versioning. See https://github.com/rails/rails/commit/7dc83f78232a6dfcdd70292e831403933f57347b for more info.
diff --git a/app/controllers/matrices_controller.rb b/app/controllers/matrices_controller.rb index abc1234..def5678 100644 --- a/app/controllers/matrices_controller.rb +++ b/app/controllers/matrices_controller.rb @@ -50,7 +50,7 @@ redirect_to :index else flash[:notice] = "Please satisfy the reCaptcha....
Use redirect instead of render
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -7,18 +7,16 @@ user = User.find_by(name: session_params[:name]) if user && user.authenticate(se...
Refactor routes with rails helper url methods Use root_path in #create and #destroy actions in sessions controller
diff --git a/app/mailers/islay_shop/order_mailer.rb b/app/mailers/islay_shop/order_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/islay_shop/order_mailer.rb +++ b/app/mailers/islay_shop/order_mailer.rb @@ -3,6 +3,8 @@ default :from => Settings.for(:shop, :email), :charset => 'UTF-8' + + layou...
Use a layout for mailing
diff --git a/app/controllers/api_flashcards/api_controller.rb b/app/controllers/api_flashcards/api_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api_flashcards/api_controller.rb +++ b/app/controllers/api_flashcards/api_controller.rb @@ -12,7 +12,7 @@ if auth @current_user = auth ...
Fix responce status for failed auth.
diff --git a/app/serializers/district_serializer.rb b/app/serializers/district_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/district_serializer.rb +++ b/app/serializers/district_serializer.rb @@ -2,7 +2,8 @@ attributes :name, :vpc_id, :public_elb_security_group, :private_elb_security_group, ...
Add some attributes to district serializer
diff --git a/app.rb b/app.rb index abc1234..def5678 100644 --- a/app.rb +++ b/app.rb @@ -36,7 +36,7 @@ "markdown": { "title": @subject, "text": "### #{@subject}\n" + - "> #{@message}\n\n" + + "> #{@message.to_json.gsub(',', ",\n")}\n\n" + "> ###...
Add a formatter for message, to make it pretty
diff --git a/lib/vapebot/bot.rb b/lib/vapebot/bot.rb index abc1234..def5678 100644 --- a/lib/vapebot/bot.rb +++ b/lib/vapebot/bot.rb @@ -15,15 +15,14 @@ Signal.trap("INT") do connection.close File.delete('bin/vapebot.pid') - abort "losing bot..." + abort "\nClosing bot..." e...
Fix interrupts to display keypress on newline.
diff --git a/spec/services/search_orders_spec.rb b/spec/services/search_orders_spec.rb index abc1234..def5678 100644 --- a/spec/services/search_orders_spec.rb +++ b/spec/services/search_orders_spec.rb @@ -0,0 +1,37 @@+require 'spec_helper' + +describe SearchOrders do + let!(:distributor) { create(:distributor_enterpri...
Add basic SearchOrders service spec
diff --git a/spec/www.fofrslevy.cz/nginx_spec.rb b/spec/www.fofrslevy.cz/nginx_spec.rb index abc1234..def5678 100644 --- a/spec/www.fofrslevy.cz/nginx_spec.rb +++ b/spec/www.fofrslevy.cz/nginx_spec.rb @@ -13,7 +13,7 @@ xit 'responds to request with response from rails app' do #think about adding domains to hos...
Change serverspec to check for application title - rubygems
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -16,8 +16,8 @@ VALID_EMAIL_REGEX = /\A[\w+\-.]+@[a-z\d\-]+(?:\.[a-z\d\-]+)*\.[a-z]+\z/i validates :email, presence: true, format: { with: VALID_EMAIL_REGEX }, uniqueness: { case_s...
Add additional validations for User model - Allow Owner to update user information from console without need of password.
diff --git a/test/react_test.rb b/test/react_test.rb index abc1234..def5678 100644 --- a/test/react_test.rb +++ b/test/react_test.rb @@ -18,8 +18,13 @@ end test 'precompiling assets works' do - Dummy::Application.load_tasks - Rake::Task['assets:precompile'].invoke - FileUtils.rm_r(File.expand_path("../d...
Fix precompile test for Rails 3.2
diff --git a/lib/express_templates/components/capabilities/building.rb b/lib/express_templates/components/capabilities/building.rb index abc1234..def5678 100644 --- a/lib/express_templates/components/capabilities/building.rb +++ b/lib/express_templates/components/capabilities/building.rb @@ -2,9 +2,12 @@ module Compo...
Undo 101a650a7 as this is intercepting rails helpers
diff --git a/lib/generators/spree_conekta/install/install_generator.rb b/lib/generators/spree_conekta/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/spree_conekta/install/install_generator.rb +++ b/lib/generators/spree_conekta/install/install_generator.rb @@ -5,13 +5,13 @@ class_o...
Fix spree_conekta generator to use the real extension assets
diff --git a/spec/models/csv_exporter/activity_session_spec.rb b/spec/models/csv_exporter/activity_session_spec.rb index abc1234..def5678 100644 --- a/spec/models/csv_exporter/activity_session_spec.rb +++ b/spec/models/csv_exporter/activity_session_spec.rb @@ -3,6 +3,27 @@ describe CsvExporter::ActivitySession do in...
Add more specs for activity session exporter