diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/spec/unit/active_node/node_list_formatter_spec.rb b/spec/unit/active_node/node_list_formatter_spec.rb index abc1234..def5678 100644 --- a/spec/unit/active_node/node_list_formatter_spec.rb +++ b/spec/unit/active_node/node_list_formatter_spec.rb @@ -5,13 +5,13 @@ subject { described_class.new(list, max_e...
Fix minor code style issue.
diff --git a/chef-api.gemspec b/chef-api.gemspec index abc1234..def5678 100644 --- a/chef-api.gemspec +++ b/chef-api.gemspec @@ -11,7 +11,7 @@ spec.description = 'A tiny Chef API client with minimal dependencies' spec.summary = 'A Chef API client in Ruby' spec.homepage = 'https://github.com/sethvar...
Use a SPDX compliant license string Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/lib/job_board/app.rb b/lib/job_board/app.rb index abc1234..def5678 100644 --- a/lib/job_board/app.rb +++ b/lib/job_board/app.rb @@ -21,7 +21,8 @@ JSON.dump( greeting: 'hello, human 👋!', pong: JobBoard.redis.ping.to_s, - now: pg_now + now: pg_now, + ...
Include version in `GET /` metadata
diff --git a/lib/tasks/tmp_migrate_hmrc_manuals_from_live_to_beta.rake b/lib/tasks/tmp_migrate_hmrc_manuals_from_live_to_beta.rake index abc1234..def5678 100644 --- a/lib/tasks/tmp_migrate_hmrc_manuals_from_live_to_beta.rake +++ b/lib/tasks/tmp_migrate_hmrc_manuals_from_live_to_beta.rake @@ -0,0 +1,15 @@+desc "Migrate ...
Migrate HMRC manuals from 'live' to 'beta' HMRC manuals are rendered with a 'beta' banner due to custom logic in Manuals Frontend, as we're migrating to Government Frontend we need to set the phase value to persist the beta status. There are questions around whether these pages should still be in 'beta' but for now w...
diff --git a/features/step_definitions/emails.rb b/features/step_definitions/emails.rb index abc1234..def5678 100644 --- a/features/step_definitions/emails.rb +++ b/features/step_definitions/emails.rb @@ -34,4 +34,4 @@ randomString = SecureRandom.hex @email_address = randomString + '@example.com' puts "Email ad...
Add line terminator at end of file
diff --git a/spec/parsley/curb_downloader_spec.rb b/spec/parsley/curb_downloader_spec.rb index abc1234..def5678 100644 --- a/spec/parsley/curb_downloader_spec.rb +++ b/spec/parsley/curb_downloader_spec.rb @@ -5,7 +5,7 @@ headers = double(:headers) headers.should_receive(:[]=).with('User-Agent', :something) -...
Fix tests broken by ipv4 resolve mode
diff --git a/lib/rspec/junklet.rb b/lib/rspec/junklet.rb index abc1234..def5678 100644 --- a/lib/rspec/junklet.rb +++ b/lib/rspec/junklet.rb @@ -2,8 +2,9 @@ require_relative "./junklet/junk" require_relative "./junklet/junklet" +# Automatically hook into RSpec when you `include "rspec-junklet"` RSpec.configure do |...
Add comments to better document RSpec includes and extends
diff --git a/lib/skr/extension.rb b/lib/skr/extension.rb index abc1234..def5678 100644 --- a/lib/skr/extension.rb +++ b/lib/skr/extension.rb @@ -1,5 +1,4 @@ require 'lanes/access/extension' - module Skr class Extension < Lanes::Extensions::Definition @@ -8,7 +7,10 @@ title "Stockor" root_path P...
Set SC alias to Skr.Components
diff --git a/app/controllers/list_controller.rb b/app/controllers/list_controller.rb index abc1234..def5678 100644 --- a/app/controllers/list_controller.rb +++ b/app/controllers/list_controller.rb @@ -1,5 +1,6 @@ class ListController < ApplicationController def index + @lists = List.all end def new
Make @lists available to index.html.erb
diff --git a/app/controllers/main_controller.rb b/app/controllers/main_controller.rb index abc1234..def5678 100644 --- a/app/controllers/main_controller.rb +++ b/app/controllers/main_controller.rb @@ -1,5 +1,8 @@ class MainController < ApplicationController def home + if params[:debug] + render :json => requ...
Add debug flag for debugging https
diff --git a/app/importers/behavior_importer.rb b/app/importers/behavior_importer.rb index abc1234..def5678 100644 --- a/app/importers/behavior_importer.rb +++ b/app/importers/behavior_importer.rb @@ -8,15 +8,18 @@ def import_row(row) student = Student.where(local_id: row[:local_id]).first_or_create! - even...
Update behavior importer to handle dates/times that are already parsed by CsvTransformer
diff --git a/application.rb b/application.rb index abc1234..def5678 100644 --- a/application.rb +++ b/application.rb @@ -7,4 +7,7 @@ get '/' do erb :index end + get '/about' do + erb :about + end end
Add about page in Sinatra actions
diff --git a/spec/pragma/operation/base_spec.rb b/spec/pragma/operation/base_spec.rb index abc1234..def5678 100644 --- a/spec/pragma/operation/base_spec.rb +++ b/spec/pragma/operation/base_spec.rb @@ -21,8 +21,4 @@ it 'runs correctly' do expect(result).to be_success end - - it 'sets up a default response' do...
Remove old default response test
diff --git a/lib/gimei.rb b/lib/gimei.rb index abc1234..def5678 100644 --- a/lib/gimei.rb +++ b/lib/gimei.rb @@ -13,6 +13,8 @@ def_delegators :@name, :kanji, :hiragana, :katakana, :first, :last, :male?, :female? alias_method :to_s, :kanji + + attr_reader :name, :address class << self extend Forwardabl...
Enable access to Name and Address from Gimei object
diff --git a/lib/guide.rb b/lib/guide.rb index abc1234..def5678 100644 --- a/lib/guide.rb +++ b/lib/guide.rb @@ -1,6 +1,10 @@ require 'restaurant' class Guide + class Config + @@actions = ['list', 'find', 'add', 'quit'] + def self.actions; @@actions; end + end def initialize(path = nil) # locate th...
Refactor launch! method to separate part of code to get_action method
diff --git a/db/migrate/20130615214912_add_name_to_apn_app.rb b/db/migrate/20130615214912_add_name_to_apn_app.rb index abc1234..def5678 100644 --- a/db/migrate/20130615214912_add_name_to_apn_app.rb +++ b/db/migrate/20130615214912_add_name_to_apn_app.rb @@ -0,0 +1,6 @@+class AddNameToApnApp < ActiveRecord::Migration + ...
Add column in apn app table to identify an application
diff --git a/lib/apiary/command/runner.rb b/lib/apiary/command/runner.rb index abc1234..def5678 100644 --- a/lib/apiary/command/runner.rb +++ b/lib/apiary/command/runner.rb @@ -5,7 +5,7 @@ class Runner def self.run(cmd, options) - Apiary::Command.const_get(cmd.capitalize).send(:execute, options) + ...
Fix -v/--version option in Ruby 1.8.7
diff --git a/lib/openlogi/base_object.rb b/lib/openlogi/base_object.rb index abc1234..def5678 100644 --- a/lib/openlogi/base_object.rb +++ b/lib/openlogi/base_object.rb @@ -19,11 +19,11 @@ end property :error, coerce: String - property :errors, coerce: Openlogi::Errors + property :errors, coerce: Openl...
Set default value for errors so that it is never nil
diff --git a/lib/minty.rb b/lib/minty.rb index abc1234..def5678 100644 --- a/lib/minty.rb +++ b/lib/minty.rb @@ -6,15 +6,18 @@ class DataCite - def initialize(endpoint = 'http://test.datacite.com') - @endpoint = endpoint + def initialize(endpoint = 'http://test.datacite.com', user = nil, pass = nil) + ...
Add a method to mint a new DOI.
diff --git a/lib/backup/storage/object.rb b/lib/backup/storage/object.rb index abc1234..def5678 100644 --- a/lib/backup/storage/object.rb +++ b/lib/backup/storage/object.rb @@ -24,7 +24,7 @@ # descending. The newest backup storage object comes in Backup::Storage::Object.load[0] # and the oldest in Backup::...
Check if config file is empty before attempting to read it.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -4,5 +4,6 @@ post '/items', to: 'items#create' get '/items/:id', to: 'items#show', as: 'item' get '/items/:id/edit', to: 'items#edit' + patch '/items/:id', to: 'items#update' # For...
Create patch /items/:id to have ability to update item information
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -28,8 +28,6 @@ match "terms" => "text_blocks#terms" match "about" => "text_blocks#about" - match "imprint" => "text_blocks#imprint" - match "faq" => "faqs#index" # Jasmine test...
Remove unused imprint route (imprint is on the contact page).
diff --git a/lib/cloudflair/connection.rb b/lib/cloudflair/connection.rb index abc1234..def5678 100644 --- a/lib/cloudflair/connection.rb +++ b/lib/cloudflair/connection.rb @@ -12,22 +12,29 @@ new_faraday_from config end - def self.headers - {}.tap do |request_headers| - cloudflare_auth_conf...
Address PR comments and use more guard-clause-like structure.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -26,6 +26,6 @@ resources :audiences resources :guides, :only => [:show] - - match '/:path(/:part)', :to => GuidesFrontEnd::App + + match '/:path(/:part)', :to => GuidesFrontEnd::A...
Fix login bug that was introduced when we added the public front end
diff --git a/scs.rb b/scs.rb index abc1234..def5678 100644 --- a/scs.rb +++ b/scs.rb @@ -10,6 +10,9 @@ bottle do root_url 'https://juliabottles.s3.amazonaws.com' cellar :any + sha1 "f91d0d48c370f38bc98cf3e0943ec31aba898ee5" => :yosemite + sha1 "7d6dc861d422fae60b152e11ec6182083e4aeec2" => :mavericks +...
Add new 32 and 64-bit SCS dylibs to SCS formula
diff --git a/lib/comp_player.rb b/lib/comp_player.rb index abc1234..def5678 100644 --- a/lib/comp_player.rb +++ b/lib/comp_player.rb @@ -1,4 +1,4 @@-require 'pry' +$: << File.dirname(__FILE__) class CompPlayer
Add file to load path
diff --git a/auth/app/models/order_decorator.rb b/auth/app/models/order_decorator.rb index abc1234..def5678 100644 --- a/auth/app/models/order_decorator.rb +++ b/auth/app/models/order_decorator.rb @@ -1,4 +1,4 @@-Order.class_eval do +Spree::Order.class_eval do token_resource # Associates the specified user with...
Fix Order reference in OrderDecorator
diff --git a/lib/friendly_id/migration.rb b/lib/friendly_id/migration.rb index abc1234..def5678 100644 --- a/lib/friendly_id/migration.rb +++ b/lib/friendly_id/migration.rb @@ -14,9 +14,8 @@ t.string :scope t.datetime :created_at end - add_index :friendly_id_slugs, :sluggable_id + add_index :f...
Use composite index for queries by sluggable A sluggable_id index alone isn't much use since the id only makes since in the context of a sluggable_type. This allows for much faster look ups (and better query planning) when searching by a sluggable.
diff --git a/lib/instagram_integration.rb b/lib/instagram_integration.rb index abc1234..def5678 100644 --- a/lib/instagram_integration.rb +++ b/lib/instagram_integration.rb @@ -1,10 +1,10 @@ require 'net/http' require 'uri' +require 'nokogiri' class InstagramIntegration def media - edges_array = response_obje...
Fix getting JSON data from Instagram again
diff --git a/lib/lysergide/application.rb b/lib/lysergide/application.rb index abc1234..def5678 100644 --- a/lib/lysergide/application.rb +++ b/lib/lysergide/application.rb @@ -5,7 +5,7 @@ class Lysergide::Application < Sinatra::Base set :server, :webrick - set :views, settings.root + '/../../views' - set :public_f...
Set sinatra root to correct value
diff --git a/lib/microspec/expectation.rb b/lib/microspec/expectation.rb index abc1234..def5678 100644 --- a/lib/microspec/expectation.rb +++ b/lib/microspec/expectation.rb @@ -24,7 +24,7 @@ end def method_missing(method, *expected, &block) - unless !!@_boolean == !!@_actual.send(method, *expected...
Remove double bang from a guaranteed boolean
diff --git a/lib/onesignal/http_client.rb b/lib/onesignal/http_client.rb index abc1234..def5678 100644 --- a/lib/onesignal/http_client.rb +++ b/lib/onesignal/http_client.rb @@ -9,6 +9,7 @@ @app_id = app_id @connection = Faraday.new(url: URL) do |connection| connection.request :json + connec...
Add retry middleware to Faraday connection Closes #33 By default, it retries 2 times and handles only timeout exceptions https://github.com/lostisland/faraday/blob/master/lib/faraday/request/retry.rb
diff --git a/publify_amazon_sidebar/spec/models/amazon_sidebar_spec.rb b/publify_amazon_sidebar/spec/models/amazon_sidebar_spec.rb index abc1234..def5678 100644 --- a/publify_amazon_sidebar/spec/models/amazon_sidebar_spec.rb +++ b/publify_amazon_sidebar/spec/models/amazon_sidebar_spec.rb @@ -1,8 +1,8 @@ require 'rails_...
Make specs pass with publify_core 9.0.0.pre5
diff --git a/lib/omnic/ext/integer_ext.rb b/lib/omnic/ext/integer_ext.rb index abc1234..def5678 100644 --- a/lib/omnic/ext/integer_ext.rb +++ b/lib/omnic/ext/integer_ext.rb @@ -4,6 +4,7 @@ module IntegerExt def format_currency - '$' + to_s.reverse.scan(/(\d*\.\d{1,3}|\d{1,3})/).join(',').reverse + neg = nega...
Support for displaying negative numbers when formatting currency
diff --git a/spec/features/projects/project_settings_spec.rb b/spec/features/projects/project_settings_spec.rb index abc1234..def5678 100644 --- a/spec/features/projects/project_settings_spec.rb +++ b/spec/features/projects/project_settings_spec.rb @@ -0,0 +1,41 @@+require 'spec_helper' + +describe 'Edit Project Settin...
Add feature specs for edit project settings
diff --git a/spec/integration/commands/account/setup_spec.rb b/spec/integration/commands/account/setup_spec.rb index abc1234..def5678 100644 --- a/spec/integration/commands/account/setup_spec.rb +++ b/spec/integration/commands/account/setup_spec.rb @@ -1,29 +1,51 @@ require File.expand_path(File.dirname(__FILE__) + '/....
Add specs for account credential creation.
diff --git a/lib/goblin/book.rb b/lib/goblin/book.rb index abc1234..def5678 100644 --- a/lib/goblin/book.rb +++ b/lib/goblin/book.rb @@ -6,8 +6,7 @@ attr_reader :sheets def initialize(file, &block) - @file = file - @files = Zip::ZipFile.open(@file) + @files = Zip::ZipFile.open(file) @co...
Use local variable(file) instead of instance variable(@file)
diff --git a/lib/hets/caller.rb b/lib/hets/caller.rb index abc1234..def5678 100644 --- a/lib/hets/caller.rb +++ b/lib/hets/caller.rb @@ -26,25 +26,35 @@ end def perform(api_uri, method = :get) - raise NotImplementedError, 'No HTTP-Verb other than GET supported' unless method == :get - get_caller = ...
Select PostCaller on `:post` method.
diff --git a/spec/rubocop/cop/internal_affairs/useless_message_assertion_spec.rb b/spec/rubocop/cop/internal_affairs/useless_message_assertion_spec.rb index abc1234..def5678 100644 --- a/spec/rubocop/cop/internal_affairs/useless_message_assertion_spec.rb +++ b/spec/rubocop/cop/internal_affairs/useless_message_assertion...
Add internal spec case for expect_offense with described_class::MSG Detect specs using the new expect_offense syntax with described_class::MSG. NOTE: Using strip_indent for the inner heredoc to prevent its annotation being recognised at the outer level.
diff --git a/lib/whatsapp/request/code.rb b/lib/whatsapp/request/code.rb index abc1234..def5678 100644 --- a/lib/whatsapp/request/code.rb +++ b/lib/whatsapp/request/code.rb @@ -6,7 +6,7 @@ class Code < WhatsApp::Request::Base IDENTITY = 'abcdef0123456789' - def initialize(country_code, number, method ...
Change named parameters to options hash
diff --git a/lib/powerschool.rb b/lib/powerschool.rb index abc1234..def5678 100644 --- a/lib/powerschool.rb +++ b/lib/powerschool.rb @@ -23,9 +23,15 @@ end end - get :districts, '/district' - get :schools, '/school' + # client is set up per district so it returns only one district + # for urls with paramet...
Add a few more routes
diff --git a/lib/rack/livejs.rb b/lib/rack/livejs.rb index abc1234..def5678 100644 --- a/lib/rack/livejs.rb +++ b/lib/rack/livejs.rb @@ -31,7 +31,7 @@ end def inject_livejs(html) - html.sub(%r{(<head( [^>]*)?>)}i) { $1 + %{<script src="#{bundled_livejs_path}"/>} } + html.sub(%r{(<head( [^>]*)?>)}i)...
Make sure script tag is valid syntax This was breaking layout for me in chrome and safari
diff --git a/net-ntp-next.gemspec b/net-ntp-next.gemspec index abc1234..def5678 100644 --- a/net-ntp-next.gemspec +++ b/net-ntp-next.gemspec @@ -17,5 +17,9 @@ gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) } gem.test_files = gem.files.grep(%r{^(test|spec|features)/}) gem.requir...
Add development dependencies to gemspec
diff --git a/lib/tango/fetch.rb b/lib/tango/fetch.rb index abc1234..def5678 100644 --- a/lib/tango/fetch.rb +++ b/lib/tango/fetch.rb @@ -2,7 +2,7 @@ module Fetch def fetch(url) - shell("wget", "--progress=bar:force", "--continue", url) + shell("curl", "-O", "-C", "-", "--progress-bar", url) end ...
Use curl rather than wget. It's on both OS X and Ubuntu boxes by default.
diff --git a/lib/tasks/eve.rake b/lib/tasks/eve.rake index abc1234..def5678 100644 --- a/lib/tasks/eve.rake +++ b/lib/tasks/eve.rake @@ -18,4 +18,13 @@ BloodlinesImporter.new.import end end + + desc 'Import EveOnline Factions' + task factions: :environment do + ActiveRecord::Base.transaction do + ...
Add rake task for import factions
diff --git a/lib/timer/timer.rb b/lib/timer/timer.rb index abc1234..def5678 100644 --- a/lib/timer/timer.rb +++ b/lib/timer/timer.rb @@ -13,11 +13,11 @@ end def count_down - @minutes.downto 1 do |i| + @minutes.downto 1 do |minute| sleep 60 - puts i - if @messages && @messages[i] - `...
Make iteration variable express intent
diff --git a/app/helpers/quotes_helper.rb b/app/helpers/quotes_helper.rb index abc1234..def5678 100644 --- a/app/helpers/quotes_helper.rb +++ b/app/helpers/quotes_helper.rb @@ -1,7 +1,11 @@ module QuotesHelper def cache_key_for_quotes - count = Quote.count - max_updated_at = Quote.maximum(:updated_at).utc.to_s...
Fix cache key for person pages
diff --git a/engine_cart.gemspec b/engine_cart.gemspec index abc1234..def5678 100644 --- a/engine_cart.gemspec +++ b/engine_cart.gemspec @@ -19,7 +19,6 @@ spec.require_paths = ["lib"] spec.add_dependency "rails" - spec.add_dependency "bundler", "~> 1.5" spec.add_development_dependency "rake" spec.add_deve...
Remove a hard dependency on the bundler gem, since it is baked into ruby 2.6
diff --git a/app/services/build_runner.rb b/app/services/build_runner.rb index abc1234..def5678 100644 --- a/app/services/build_runner.rb +++ b/app/services/build_runner.rb @@ -2,7 +2,7 @@ pattr_initialize :payload def run - if repo && opened_merge_request? && !runned_merge_request? + if repo && opened_mer...
Remove useless check. We have commenting policy!
diff --git a/config/initializers/gds-sso.rb b/config/initializers/gds-sso.rb index abc1234..def5678 100644 --- a/config/initializers/gds-sso.rb +++ b/config/initializers/gds-sso.rb @@ -1,6 +1,6 @@ GDS::SSO.config do |config| config.user_model = 'User' - config.oauth_id = ENV['SIGNON_OAUTH_ID'] - config.oauth...
Fix name of Signon environment variable This isn't prefixed with `SIGNON`.
diff --git a/config/initializers/bower_rails.rb b/config/initializers/bower_rails.rb index abc1234..def5678 100644 --- a/config/initializers/bower_rails.rb +++ b/config/initializers/bower_rails.rb @@ -8,9 +8,6 @@ # Invokes rake bower:resolve before precompilation. Defaults to false bower_rails.resolve_before_preco...
Remove bower clean command due to bug
diff --git a/config/initializers/inflections.rb b/config/initializers/inflections.rb index abc1234..def5678 100644 --- a/config/initializers/inflections.rb +++ b/config/initializers/inflections.rb @@ -11,6 +11,8 @@ # end # These inflection rules are supported but not enabled by default: -# ActiveSupport::Inflector.i...
Add inflection to ensure Avalon::RDFVocab works with zeitwerk
diff --git a/spec/stack_overflow_spec.rb b/spec/stack_overflow_spec.rb index abc1234..def5678 100644 --- a/spec/stack_overflow_spec.rb +++ b/spec/stack_overflow_spec.rb @@ -4,15 +4,42 @@ include Service describe StackOverflow, '.fetch' do + BASE_URL = "http://api.stackexchange.com/2.1" + PARAMS = "site=stackoverfl...
Add some tests for StackOverflow request URL patterns
diff --git a/spec/client/api/none_spec.rb b/spec/client/api/none_spec.rb index abc1234..def5678 100644 --- a/spec/client/api/none_spec.rb +++ b/spec/client/api/none_spec.rb @@ -0,0 +1,27 @@+require 'client_helper' + +describe Cyclid::Client::Api::Basic do + context 'passing through requests' do + let :config do + ...
Add a simple test for the None authenticator
diff --git a/scripts/bm_latency_lb_vs_mget.rb b/scripts/bm_latency_lb_vs_mget.rb index abc1234..def5678 100644 --- a/scripts/bm_latency_lb_vs_mget.rb +++ b/scripts/bm_latency_lb_vs_mget.rb @@ -0,0 +1,61 @@+# Runs a mild benchmark and prints out the average time a call to 'throttle!' takes. + +require 'prorate' +require...
Add script to measure longest redis block times
diff --git a/spec/request/base/request_destroy_spec.rb b/spec/request/base/request_destroy_spec.rb index abc1234..def5678 100644 --- a/spec/request/base/request_destroy_spec.rb +++ b/spec/request/base/request_destroy_spec.rb @@ -0,0 +1,14 @@+# frozen_string_literal: true + +require 'spec_helper' + +describe 'RubyRabbit...
Add test for destroy request
diff --git a/Casks/qlmarkdown.rb b/Casks/qlmarkdown.rb index abc1234..def5678 100644 --- a/Casks/qlmarkdown.rb +++ b/Casks/qlmarkdown.rb @@ -16,5 +16,5 @@ system '/usr/bin/ditto', '-xk', '--', "#{staged_path}/QLMarkdown.qlgenerator.zip", "#{staged_path}/QLMarkdown.qlgenerator" end - qlplugin 'QLMarkdown.qlgen...
Fix missing subfolder in QLMarkdown Cask
diff --git a/app/models/physical_server_provision_task/state_machine.rb b/app/models/physical_server_provision_task/state_machine.rb index abc1234..def5678 100644 --- a/app/models/physical_server_provision_task/state_machine.rb +++ b/app/models/physical_server_provision_task/state_machine.rb @@ -16,7 +16,7 @@ end ...
Set task's state to "finished" eventually We were setting task's state to "provisioned" but that is not a final state so it doesn't get recognized by the Request which always assumes that task's final state be "finished". Signed-off-by: Miha Pleško <e42a14dbca5c0965023849a10306da025a317640@xlab.si>
diff --git a/test/hyperclient/entry_point_test.rb b/test/hyperclient/entry_point_test.rb index abc1234..def5678 100644 --- a/test/hyperclient/entry_point_test.rb +++ b/test/hyperclient/entry_point_test.rb @@ -18,9 +18,8 @@ it 'creates a Faraday connection with the default block' end - describe 'entry' d...
Fix entry point test definition
diff --git a/spec/lib/jwt_utils_spec.rb b/spec/lib/jwt_utils_spec.rb index abc1234..def5678 100644 --- a/spec/lib/jwt_utils_spec.rb +++ b/spec/lib/jwt_utils_spec.rb @@ -20,7 +20,7 @@ describe ".decode" do it "decodes the payload" do expect(described_class.decode(jwt: jwt)).to match(payload: { some: "pa...
Use be_a assertion for Integer
diff --git a/spec/models/animal_spec.rb b/spec/models/animal_spec.rb index abc1234..def5678 100644 --- a/spec/models/animal_spec.rb +++ b/spec/models/animal_spec.rb @@ -0,0 +1,23 @@+require "rails_helper" + +RSpec.describe Animal, :type => :model do + before(:all) do + dog = Animal.create(breed_id: 1, name: "doge",...
Add tests for animal model
diff --git a/rack_hoptoad.gemspec b/rack_hoptoad.gemspec index abc1234..def5678 100644 --- a/rack_hoptoad.gemspec +++ b/rack_hoptoad.gemspec @@ -0,0 +1,33 @@+# -*- encoding: utf-8 -*- + +Gem::Specification.new do |s| + s.name = %q{rack_hoptoad} + s.version = "0.1.7" + + s.required_rubygems_version = Gem::Requirement...
Add the gemspec to hoptoad.
diff --git a/spec/archloot/drop_spec.rb b/spec/archloot/drop_spec.rb index abc1234..def5678 100644 --- a/spec/archloot/drop_spec.rb +++ b/spec/archloot/drop_spec.rb @@ -3,8 +3,8 @@ module Archloot describe Drop do let(:basic_drop) { FactoryGirl.build :drop } - it "carries information about the drop" do - ...
Update the spec to reflect Drop class changes
diff --git a/spec/script/mailin-spec.rb b/spec/script/mailin-spec.rb index abc1234..def5678 100644 --- a/spec/script/mailin-spec.rb +++ b/spec/script/mailin-spec.rb @@ -0,0 +1,21 @@+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper') +require "external_command" + +def mailin_test(email_filename) + D...
Add a spec to test that mailin does not produce any output. This is important as under some MTA configurations, any output will result in a bounce message being sent to the original mail sender.
diff --git a/spec/localhost/zfirefox_spec.rb b/spec/localhost/zfirefox_spec.rb index abc1234..def5678 100644 --- a/spec/localhost/zfirefox_spec.rb +++ b/spec/localhost/zfirefox_spec.rb @@ -9,7 +9,7 @@ @selenium.quit end - res = '1024 x 768' + res = '1024 x 7688' it "should return display resolution of #...
Validate that rspec test of firefox fails
diff --git a/spec/support/dummy_view.rb b/spec/support/dummy_view.rb index abc1234..def5678 100644 --- a/spec/support/dummy_view.rb +++ b/spec/support/dummy_view.rb @@ -1,7 +1,40 @@+require 'action_view' + class DummyView < ActionView::Base + module FakeRequest + class Request + attr_accessor :path + def...
Change to implement bare action view to drive test urls expansion
diff --git a/spec/support/setup_dirs.rb b/spec/support/setup_dirs.rb index abc1234..def5678 100644 --- a/spec/support/setup_dirs.rb +++ b/spec/support/setup_dirs.rb @@ -1,5 +1,5 @@ dirs = [] dirs << Rails.root.join('public', 'uploads', 'failed_imports') -dirs.each{|dir| Fileutils.mkdir_p dir unless Dir.exist? dir} +...
Fix stupid typo in specs support file
diff --git a/spec/unit/query_builder_spec.rb b/spec/unit/query_builder_spec.rb index abc1234..def5678 100644 --- a/spec/unit/query_builder_spec.rb +++ b/spec/unit/query_builder_spec.rb @@ -11,15 +11,15 @@ end it "should return empty conditions if the search query is nil" do - ScopedSearch::QueryBuilder.build_...
Revert "Fix query builder specs by including :order => nil" This reverts commit 3fafe3986911848ebceb606aba6f498d85eb423b.
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -15,6 +15,6 @@ only_if "ls #{ENV['HOME']}/.composer/vendor/drush/drush/drush" end link "/usr/local/bin/drush" do - to "#{ENV['HOME']}/.composer/vendor/drush/drush/drush" + to "#{...
Handle multiple drush installation paths
diff --git a/recipes/firefox.rb b/recipes/firefox.rb index abc1234..def5678 100644 --- a/recipes/firefox.rb +++ b/recipes/firefox.rb @@ -1,6 +1,6 @@ dmg_package "Firefox" do - source "http://download.mozilla.org/?product=firefox-17.0&os=osx&lang=en-US" - checksum "abd7e8a4da8faf815d0bd96a6b1a6492e630c73433522c0c3dfd6...
Update Firefox URL to latest version.
diff --git a/lib/travis.rb b/lib/travis.rb index abc1234..def5678 100644 --- a/lib/travis.rb +++ b/lib/travis.rb @@ -2,7 +2,6 @@ autoload :Buildable, 'travis/buildable' autoload :Builder, 'travis/builder' autoload :Config, 'travis/config' - autoload :WebSocketServer, 'travis/web_socket_server' class ...
Remove that WebSocketServer autoload since we don't use it anymore.
diff --git a/lib/virtus.rb b/lib/virtus.rb index abc1234..def5678 100644 --- a/lib/virtus.rb +++ b/lib/virtus.rb @@ -13,7 +13,7 @@ # # @param [Class] descendant # - # @return [Class] + # @return [undefined] # # @api private def self.included(descendant)
Make sure the hook method is properly commented
diff --git a/core/basicobject/not_equal_spec.rb b/core/basicobject/not_equal_spec.rb index abc1234..def5678 100644 --- a/core/basicobject/not_equal_spec.rb +++ b/core/basicobject/not_equal_spec.rb @@ -22,5 +22,13 @@ a = BasicObject.new (a != a).should be_false end + + it "dispatches to #==" do + ...
Add spec for 1.9 != dispatching to ==.
diff --git a/test/spec/auth_timeout_spec.rb b/test/spec/auth_timeout_spec.rb index abc1234..def5678 100644 --- a/test/spec/auth_timeout_spec.rb +++ b/test/spec/auth_timeout_spec.rb @@ -0,0 +1,17 @@+# This test may only be meaningful with kerberos auth +# Against server 2012, a kerberos connection will require reauth (g...
Add rspec test to make sure kerberos reauth with 18 second sleep works
diff --git a/db/data_migration/20140110142811_add_oil_and_gas_detailed_guide_categories.rb b/db/data_migration/20140110142811_add_oil_and_gas_detailed_guide_categories.rb index abc1234..def5678 100644 --- a/db/data_migration/20140110142811_add_oil_and_gas_detailed_guide_categories.rb +++ b/db/data_migration/20140110142...
Create new detailed guide categories for oil & gas This migration creates eight new detailed guide categories for the Oil and Gas sector, which will be used to push the correct industry_sector tags into Panopticon.
diff --git a/script/test/stream_editor_test.rb b/script/test/stream_editor_test.rb index abc1234..def5678 100644 --- a/script/test/stream_editor_test.rb +++ b/script/test/stream_editor_test.rb @@ -3,7 +3,7 @@ require 'test/unit' require 'tempfile' -require File.dirname(__FILE__) + '/../stream_editor' +require File.d...
Correct 'overriding_check.rb' to output message only if not blank version=0.7.2.5 script/test/stream_editor_test.rb - 'stream_editor.rb' was moved to directory script/base.
diff --git a/lib/feedcellar/groonga_searcher.rb b/lib/feedcellar/groonga_searcher.rb index abc1234..def5678 100644 --- a/lib/feedcellar/groonga_searcher.rb +++ b/lib/feedcellar/groonga_searcher.rb @@ -47,9 +47,8 @@ latest_feeds = [] feeds = database.feeds - # TODO: I want to use the groonga me...
Use rroonga method for latest grouping rroonga 3.0.4 has been released!!!
diff --git a/vendor/stripe-json/lib/json/pure.rb b/vendor/stripe-json/lib/json/pure.rb index abc1234..def5678 100644 --- a/vendor/stripe-json/lib/json/pure.rb +++ b/vendor/stripe-json/lib/json/pure.rb @@ -13,3 +13,16 @@ JSON_LOADED = true unless defined?(::JSON::JSON_LOADED) end + +## Hacks needed to make to_json ...
Add hacks to make to_json work
diff --git a/spec/helpers/pages_helper_spec.rb b/spec/helpers/pages_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/pages_helper_spec.rb +++ b/spec/helpers/pages_helper_spec.rb @@ -22,11 +22,15 @@ end context 'url preview' do + before do + allow(helper).to receive(:preview_domain).and_ret...
Make sure preview domain is the consistant
diff --git a/spec/jortt/client/invoice_spec.rb b/spec/jortt/client/invoice_spec.rb index abc1234..def5678 100644 --- a/spec/jortt/client/invoice_spec.rb +++ b/spec/jortt/client/invoice_spec.rb @@ -19,4 +19,18 @@ end it { should eq('invoice_number' => '2016-001') } end + + describe '#credit_invoice' do + ...
Write a dummy spec for credit invoices
diff --git a/spec/mini_transformer/cli_spec.rb b/spec/mini_transformer/cli_spec.rb index abc1234..def5678 100644 --- a/spec/mini_transformer/cli_spec.rb +++ b/spec/mini_transformer/cli_spec.rb @@ -0,0 +1,34 @@+require 'spec_helper' +require 'mini_transformer' +require 'mini_transformer/cli' + +describe "CLI" do + it "...
Add basic RSpec for testing the CLI class Handle the command line calls to the CLI class with RSpec
diff --git a/spec/unit/recipes/default_spec.rb b/spec/unit/recipes/default_spec.rb index abc1234..def5678 100644 --- a/spec/unit/recipes/default_spec.rb +++ b/spec/unit/recipes/default_spec.rb @@ -10,9 +10,6 @@ end shared_examples_for 'default recipe' do - it 'starts the service' do - expect(chef_run).to...
Remove spec test to verify nginx start (which we no longer do)
diff --git a/db/migrate/20121124105420_add_promise_connections.rb b/db/migrate/20121124105420_add_promise_connections.rb index abc1234..def5678 100644 --- a/db/migrate/20121124105420_add_promise_connections.rb +++ b/db/migrate/20121124105420_add_promise_connections.rb @@ -9,6 +9,10 @@ end add_index :promise_...
Delete invalid join records before migrating to promise_connections.
diff --git a/mdv.gemspec b/mdv.gemspec index abc1234..def5678 100644 --- a/mdv.gemspec +++ b/mdv.gemspec @@ -13,7 +13,7 @@ s.executables = ['mdv'] s.files = - Dir['bin/*', '*.md', 'LICENSE', 'Rakefile', 'Gemfile'] & + Dir['bin/*', '*.md', 'LICENSE', 'Rakefile', 'Gemfile', 'lib/**/*.rb'] & `git ls-fi...
Make sure library files are included in the gem
diff --git a/examples/sse/server.ru b/examples/sse/server.ru index abc1234..def5678 100644 --- a/examples/sse/server.ru +++ b/examples/sse/server.ru @@ -24,5 +24,5 @@ file_server = Rack::File.new(File.join(File.dirname(__FILE__), 'public')) -# bundle exec thin -R examples/sse/server.ru start +# bundle exec thin -V ...
Use -V for thin in example comments
diff --git a/IQKeyboardManagerSwift.podspec b/IQKeyboardManagerSwift.podspec index abc1234..def5678 100644 --- a/IQKeyboardManagerSwift.podspec +++ b/IQKeyboardManagerSwift.podspec @@ -1,13 +1,13 @@ Pod::Spec.new do |s| s.name = "IQKeyboardManagerSwift" - s.version = "3.3.2" + s.version = "3.3.3" s.summary = "Codel...
Update Podspec for swift to prepare v3.3.3
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -1,6 +1,6 @@ name 'logrotate' -maintainer 'Steven Danna' -maintainer_email 'steve@chef.io' +maintainer 'Chef Software, Inc.' +maintainer_email 'cookbooks@chef.io' license '...
Switch the maintainer over to Chef Software Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -6,3 +6,4 @@ long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) version '0.1.0' depends "apt" +depends "git"
Add git cookbook to the dependencies.
diff --git a/lib/travis/api/app/responders/badge.rb b/lib/travis/api/app/responders/badge.rb index abc1234..def5678 100644 --- a/lib/travis/api/app/responders/badge.rb +++ b/lib/travis/api/app/responders/badge.rb @@ -10,7 +10,7 @@ end def content_type - "image/svg" + "image/svg+xml" end ...
Return right mime type for SVG.
diff --git a/recipes/default.rb b/recipes/default.rb index abc1234..def5678 100644 --- a/recipes/default.rb +++ b/recipes/default.rb @@ -15,7 +15,7 @@ remote_file target do source url - mode 0775 + mode '0775' not_if { ::File.exist?(target) } end
Fix rubocop offense: Use 0o for octal literals
diff --git a/recipes/install.rb b/recipes/install.rb index abc1234..def5678 100644 --- a/recipes/install.rb +++ b/recipes/install.rb @@ -4,6 +4,7 @@ install['old_bins'].each do |old_bin_file| file "#{install['bin_path']}/#{old_bin_file}" do action :delete + notifies :stop, 'service[remote_syslog2]', :immedia...
Stop service as soon as an old version is found (updating has started)
diff --git a/spec/games_spec.rb b/spec/games_spec.rb index abc1234..def5678 100644 --- a/spec/games_spec.rb +++ b/spec/games_spec.rb @@ -0,0 +1,67 @@+require 'discordrb/games' + +describe Discordrb::Games do + describe Discordrb::Games::Game do + it 'should initialize without errors' do + hash = { + id:...
Add tests for the games list
diff --git a/trunk/Tools/fakeserver.rb b/trunk/Tools/fakeserver.rb index abc1234..def5678 100644 --- a/trunk/Tools/fakeserver.rb +++ b/trunk/Tools/fakeserver.rb @@ -11,9 +11,9 @@ body = '<Projects> <Project name="connectfour" activity="Sleeping" lastBuildStatus="Success" lastBuildLabel="build.1" - la...
Correct reporting of responses from server without project status; usually well-formed XHTML. git-svn-id: 6356d16c5fcd314faaf1b00f846dba9475d041eb@85 fc4f70da-8335-0410-99e3-8b437148c6d8
diff --git a/lib/lecture_list.rb b/lib/lecture_list.rb index abc1234..def5678 100644 --- a/lib/lecture_list.rb +++ b/lib/lecture_list.rb @@ -4,22 +4,25 @@ class LectureList - def self.update + def self.update(status) json = Net::HTTP.get URI.parse("http://theodi.org/lectures.json") + lecture...
Tweak lecture list code to return different stuff depending on input
diff --git a/rack-canonical-host.gemspec b/rack-canonical-host.gemspec index abc1234..def5678 100644 --- a/rack-canonical-host.gemspec +++ b/rack-canonical-host.gemspec @@ -9,6 +9,7 @@ gem.add_dependency 'addressable', '> 0', '< 3' gem.add_dependency 'rack', '~> 1.0' + gem.add_development_dependency 'rake' g...
Add development dependency on Rake.
diff --git a/lib/specjour/cpu.rb b/lib/specjour/cpu.rb index abc1234..def5678 100644 --- a/lib/specjour/cpu.rb +++ b/lib/specjour/cpu.rb @@ -6,7 +6,7 @@ when /darwin/ `hwprefs cpu_count`.to_i when /linux/ - `cat /proc/cpuinfo | grep processor | wc -l`.to_i + `cat /proc/cpuinfo | grep...
Use grep's --count option instead of piping to wc
diff --git a/lib/tasks/dump.rake b/lib/tasks/dump.rake index abc1234..def5678 100644 --- a/lib/tasks/dump.rake +++ b/lib/tasks/dump.rake @@ -1,6 +1,7 @@-desc "Converts a browscap file to another format" + +desc "Converts a browscap file to the Marshal format" task "browscapper:dump" do - require File.join(File.dirnam...
Add the `browscapper:convert` Rake task.
diff --git a/lib/vehicle_data.rb b/lib/vehicle_data.rb index abc1234..def5678 100644 --- a/lib/vehicle_data.rb +++ b/lib/vehicle_data.rb @@ -8,13 +8,22 @@ module VehicleData + class << self + attr_accessor :configuration + end + + def self.configure + self.configuration ||= Configuration.new + yield(con...
Add configuration block for VehicleData app_key & secret.
diff --git a/lib/zanders/base.rb b/lib/zanders/base.rb index abc1234..def5678 100644 --- a/lib/zanders/base.rb +++ b/lib/zanders/base.rb @@ -40,5 +40,19 @@ end end + def content_for(xml_doc, field) + node = xml_doc.css(field).first + + if node.nil? + nil + else + if node.css...
Handle zanders' weird format edgecases
diff --git a/spec/integration/replica_set_connections_spec.rb b/spec/integration/replica_set_connections_spec.rb index abc1234..def5678 100644 --- a/spec/integration/replica_set_connections_spec.rb +++ b/spec/integration/replica_set_connections_spec.rb @@ -2,13 +2,15 @@ describe 'replica set connections' do with_r...
Fix for repo name in repl set connection