diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/test/test_maker_ocf.rb b/test/test_maker_ocf.rb index abc1234..def5678 100644 --- a/test/test_maker_ocf.rb +++ b/test/test_maker_ocf.rb @@ -14,7 +14,7 @@ def test_container expected = Nokogiri.XML(<<EOC) -<?xml version="1.0"?> +<?xml version="1.0" encoding="UTF-8"?> <container version="1.0" xmlns...
Modify a test following implementation
diff --git a/models/sanitizer.rb b/models/sanitizer.rb index abc1234..def5678 100644 --- a/models/sanitizer.rb +++ b/models/sanitizer.rb @@ -14,7 +14,12 @@ def clean strip_spaces_off return false if has_quit? + no_letters_please send_to_file + end + + def no_letters_please + end def has_qu...
Make a method that gets rid warns against letters
diff --git a/tests/serverspec/spec/spec_init.rb b/tests/serverspec/spec/spec_init.rb index abc1234..def5678 100644 --- a/tests/serverspec/spec/spec_init.rb +++ b/tests/serverspec/spec/spec_init.rb @@ -10,5 +10,4 @@ print " DOCKER_IMAGE: " + ENV['DOCKER_IMAGE'] + "\n" print " OS_FAMILY: " + ENV['OS_FAMILY'] + "\n" pri...
Remove duplicate log message for OS_VERSION
diff --git a/app/controllers/api/v1/frontend/questions_controller.rb b/app/controllers/api/v1/frontend/questions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/frontend/questions_controller.rb +++ b/app/controllers/api/v1/frontend/questions_controller.rb @@ -7,7 +7,7 @@ def index ...
Remove collect due to policy error
diff --git a/test/apps/rails3.1/lib/somelib.rb b/test/apps/rails3.1/lib/somelib.rb index abc1234..def5678 100644 --- a/test/apps/rails3.1/lib/somelib.rb +++ b/test/apps/rails3.1/lib/somelib.rb @@ -2,5 +2,6 @@ def test_negative_array_index #This should not cause an error, but it used to [][-1] + [-1][-1] ...
Add another test for negative array index
diff --git a/core/app/models/concerns/spree/calculated_adjustments.rb b/core/app/models/concerns/spree/calculated_adjustments.rb index abc1234..def5678 100644 --- a/core/app/models/concerns/spree/calculated_adjustments.rb +++ b/core/app/models/concerns/spree/calculated_adjustments.rb @@ -4,7 +4,7 @@ included do ...
Add update_only on calculator attribute assignment This allows us to change the type and assign attributes to the calculator at the same time. Otherwise it would attempt to build a calculator (with base class Spree::Calculator) when an id wasn't specified.
diff --git a/lib/did_you_mean/word_collection.rb b/lib/did_you_mean/word_collection.rb index abc1234..def5678 100644 --- a/lib/did_you_mean/word_collection.rb +++ b/lib/did_you_mean/word_collection.rb @@ -14,8 +14,10 @@ def similar_to(target_word) target_word = target_word.to_s threshold = threshold...
Order word suggestions are recommended based on Levenshtein.distance.
diff --git a/plugins/custom_forms/lib/custom_forms_plugin/alternative.rb b/plugins/custom_forms/lib/custom_forms_plugin/alternative.rb index abc1234..def5678 100644 --- a/plugins/custom_forms/lib/custom_forms_plugin/alternative.rb +++ b/plugins/custom_forms/lib/custom_forms_plugin/alternative.rb @@ -5,6 +5,6 @@ bel...
Add attr_accessible to Alternative's selected_by_default attribute (ActionItem3262)
diff --git a/lib/public_activity/view_helpers.rb b/lib/public_activity/view_helpers.rb index abc1234..def5678 100644 --- a/lib/public_activity/view_helpers.rb +++ b/lib/public_activity/view_helpers.rb @@ -6,6 +6,12 @@ def render_activity activity, options = {} activity.render self, options end + # He...
Add single_content_for helper for use in activity partials
diff --git a/lib/texas/build/task/publish_pdf.rb b/lib/texas/build/task/publish_pdf.rb index abc1234..def5678 100644 --- a/lib/texas/build/task/publish_pdf.rb +++ b/lib/texas/build/task/publish_pdf.rb @@ -29,7 +29,7 @@ output = `grep "Output written on" #{file}` numbers = output.scan(/\((\d+?) ...
Use build.root instead of root in verbose output of Task::PublishPDF
diff --git a/0_code_wars/a_rule_of_divisibility_by_7.rb b/0_code_wars/a_rule_of_divisibility_by_7.rb index abc1234..def5678 100644 --- a/0_code_wars/a_rule_of_divisibility_by_7.rb +++ b/0_code_wars/a_rule_of_divisibility_by_7.rb @@ -0,0 +1,41 @@+# http://www.codewars.com/kata/55e6f5e58f7817808e00002e +# --- iteration 1...
Add code wars (7) - divisibility by 7
diff --git a/slack-post.gemspec b/slack-post.gemspec index abc1234..def5678 100644 --- a/slack-post.gemspec +++ b/slack-post.gemspec @@ -8,8 +8,8 @@ spec.version = Slack::Post::VERSION spec.authors = ["John Bragg"] spec.email = ["remotezygote@gmail.com"] - spec.description = %q{Pretty simple ...
Use standard quotes not %q{}
diff --git a/spec/command_publish_spec.rb b/spec/command_publish_spec.rb index abc1234..def5678 100644 --- a/spec/command_publish_spec.rb +++ b/spec/command_publish_spec.rb @@ -6,9 +6,10 @@ pub = double("publisher") pub.should_receive(:publish) { [] } Ploy::Publisher.should_receive(:new).with("test....
Make tests work in Travis during a PR build :/
diff --git a/spec/commands/record_spec.rb b/spec/commands/record_spec.rb index abc1234..def5678 100644 --- a/spec/commands/record_spec.rb +++ b/spec/commands/record_spec.rb @@ -8,10 +8,7 @@ it { should respond_to(:args) } it { should respond_to(:parse) } - describe "with only known options" do - - let(:c...
Refactor to use shared examples
diff --git a/existing_datatypes_to_dot.rb b/existing_datatypes_to_dot.rb index abc1234..def5678 100644 --- a/existing_datatypes_to_dot.rb +++ b/existing_datatypes_to_dot.rb @@ -0,0 +1,43 @@+#!/usr/bin/env ruby + +require 'libxml' +require 'graphviz' + +include LibXML + +doc = XML::Parser.file("#{ARGV[0]}").parse + +g =...
Add script to make graph from datatypes_conf.xml
diff --git a/utils/hyperloglog/hll-err.rb b/utils/hyperloglog/hll-err.rb index abc1234..def5678 100644 --- a/utils/hyperloglog/hll-err.rb +++ b/utils/hyperloglog/hll-err.rb @@ -18,7 +18,7 @@ elements << ele i += 1 } - r.pfadd('hll',*elements) + r.pfadd('hll',elements) ...
Fix HyperLogLog test script for new redis-rb API.
diff --git a/lib/has_local_cache.rb b/lib/has_local_cache.rb index abc1234..def5678 100644 --- a/lib/has_local_cache.rb +++ b/lib/has_local_cache.rb @@ -25,9 +25,11 @@ end module ClassMethods - def get_cache_with_local_cache(key, &block) + # XXX: The actual cache_fu signature is (*args) and will special ca...
Allow options on the get_cache class method.
diff --git a/lib/irrc/connecting.rb b/lib/irrc/connecting.rb index abc1234..def5678 100644 --- a/lib/irrc/connecting.rb +++ b/lib/irrc/connecting.rb @@ -28,12 +28,5 @@ def established? @connection && !@connection.sock.closed? end - - def execute(command) - return if command.nil? || command == ''...
Remove unused method, even it was confusing
diff --git a/app/mailers/producer_mailer.rb b/app/mailers/producer_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/producer_mailer.rb +++ b/app/mailers/producer_mailer.rb @@ -6,13 +6,7 @@ @coordinator = order_cycle.coordinator @order_cycle = order_cycle - subject = "[#{Spree::Config[:site_name]}...
Remove commented code, use neater syntax for accessing Spree config var
diff --git a/app/models/tenon/item_asset.rb b/app/models/tenon/item_asset.rb index abc1234..def5678 100644 --- a/app/models/tenon/item_asset.rb +++ b/app/models/tenon/item_asset.rb @@ -2,7 +2,6 @@ class ItemAsset < ActiveRecord::Base # Validations validates_presence_of :asset - validates_presence_of :ite...
Remove the requirement of an item on ItemAssets to allow them to be saved before the item is saved
diff --git a/app/policies/booking_policy.rb b/app/policies/booking_policy.rb index abc1234..def5678 100644 --- a/app/policies/booking_policy.rb +++ b/app/policies/booking_policy.rb @@ -8,7 +8,7 @@ end def permitted_attributes - base_attributes = [:name, :phone_number, :number_of_persons, :starts_at, :restaura...
Add email and message to permitted parameters
diff --git a/app/services/import_stories.rb b/app/services/import_stories.rb index abc1234..def5678 100644 --- a/app/services/import_stories.rb +++ b/app/services/import_stories.rb @@ -23,14 +23,15 @@ url = 'http://www.wri.org/blog/rss2.xml' rss = open(url) feed = RSS::Parser.parse(rss, false) + link_s...
Add title sanitizer and link split.
diff --git a/app/controllers/admin/events_controller.rb b/app/controllers/admin/events_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/events_controller.rb +++ b/app/controllers/admin/events_controller.rb @@ -41,6 +41,6 @@ def event_params params.require(:event) .permit(:title,...
Fix - Fix admin/event meta image display
diff --git a/app/helpers/spree/base_helper_decorator.rb b/app/helpers/spree/base_helper_decorator.rb index abc1234..def5678 100644 --- a/app/helpers/spree/base_helper_decorator.rb +++ b/app/helpers/spree/base_helper_decorator.rb @@ -1,6 +1,5 @@ module Spree module BaseHelper - def item_shipping_address(item) ...
Create helper to hide gift fields if it's not a gift
diff --git a/app/models/extensions/gremlin_indexable.rb b/app/models/extensions/gremlin_indexable.rb index abc1234..def5678 100644 --- a/app/models/extensions/gremlin_indexable.rb +++ b/app/models/extensions/gremlin_indexable.rb @@ -9,7 +9,7 @@ after_commit :notify_indexer_update, on: %i[create update] def n...
Fix envelope deletion detection in indexer notification callback
diff --git a/app/models/spree/variant_decorator.rb b/app/models/spree/variant_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/variant_decorator.rb +++ b/app/models/spree/variant_decorator.rb @@ -1,12 +1,14 @@ Spree::Variant.class_eval do - + include Spree::CurrencyHelpers include ActionView::Helpe...
Fix old price not getting formatted proper
diff --git a/app/resources/api/v1/post_resource.rb b/app/resources/api/v1/post_resource.rb index abc1234..def5678 100644 --- a/app/resources/api/v1/post_resource.rb +++ b/app/resources/api/v1/post_resource.rb @@ -1,6 +1,6 @@ class Api::V1::PostResource < JSONAPI::Resource - before_create :set_author_as_current_user - ...
Move attribute changes to after_replace_fields For some reason, before_create was not keeping the attribute changes.
diff --git a/app/controllers/people_controller.rb b/app/controllers/people_controller.rb index abc1234..def5678 100644 --- a/app/controllers/people_controller.rb +++ b/app/controllers/people_controller.rb @@ -4,7 +4,8 @@ def index @page_title = t('people') @people = Person.paginate(params) - + @rever...
Set some class level variables to help with column sorts on people page
diff --git a/app/controllers/status_controller.rb b/app/controllers/status_controller.rb index abc1234..def5678 100644 --- a/app/controllers/status_controller.rb +++ b/app/controllers/status_controller.rb @@ -4,7 +4,7 @@ def get_status # API checks test_location = Ohanakapa.location("downtown-palo-alto-food...
Update test search to make status check pass The status controller used to look for an organization called "InnVision", but that organization's name has been updated. I changed the search to look for keyword "maceo", which returns one of our dummy test locations.
diff --git a/spec/bable_spec.rb b/spec/bable_spec.rb index abc1234..def5678 100644 --- a/spec/bable_spec.rb +++ b/spec/bable_spec.rb @@ -6,12 +6,12 @@ end describe ".index" do - it "instantiate the default index if no args" do + it "instantiates the default index if no args" do index = described_cla...
Fix typo in the tests
diff --git a/Casks/command-line-tools-lion.rb b/Casks/command-line-tools-lion.rb index abc1234..def5678 100644 --- a/Casks/command-line-tools-lion.rb +++ b/Casks/command-line-tools-lion.rb @@ -1,7 +1,9 @@ class CommandLineToolsLion < Cask + version 'lion_april_2013' + sha256 '20a3e1965c685c6c079ffe89b168c3975c9a106c4...
Format Command Line Tools Lion
diff --git a/Casks/firefoxdeveloperedition.rb b/Casks/firefoxdeveloperedition.rb index abc1234..def5678 100644 --- a/Casks/firefoxdeveloperedition.rb +++ b/Casks/firefoxdeveloperedition.rb @@ -5,6 +5,7 @@ url "https://download.mozilla.org/?product=firefox-aurora-latest-ssl&os=osx&lang=en-US" homepage 'https://www....
Add tag stanza to Firefox Developer Edition
diff --git a/ahn_hoptoad.gemspec b/ahn_hoptoad.gemspec index abc1234..def5678 100644 --- a/ahn_hoptoad.gemspec +++ b/ahn_hoptoad.gemspec @@ -17,7 +17,6 @@ s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) } s.re...
Remove deprecated has_rdoc= from gemspec
diff --git a/Invoker.rb b/Invoker.rb index abc1234..def5678 100644 --- a/Invoker.rb +++ b/Invoker.rb @@ -1,5 +1,6 @@ require_relative 'Trick' require_relative 'ruby-util' +require_relative 'InputManager' class Invoker attr_accessor :input_manager, :current_trick, :menu_state
Fix invoker needing input manager
diff --git a/lib/tobacco/exhaler.rb b/lib/tobacco/exhaler.rb index abc1234..def5678 100644 --- a/lib/tobacco/exhaler.rb +++ b/lib/tobacco/exhaler.rb @@ -17,7 +17,7 @@ end def write_content_to_file - File.open(filepath, 'w') do |f| + File.open(filepath, 'wb') do |f| f.write content e...
Add 'b' options to File.open
diff --git a/pkg/brew/git-req.rb b/pkg/brew/git-req.rb index abc1234..def5678 100644 --- a/pkg/brew/git-req.rb +++ b/pkg/brew/git-req.rb @@ -4,7 +4,6 @@ url "https://github.com/arusahni/git-req/archive/v2.1.0.tar.gz" sha256 "a7bc8f90230762e93d348dcb22dee93b7c47d07678012976a229950a752a72ff" - depends_on "git" =>...
Remove git dependency from Homebrew Formula
diff --git a/tests/test_unit_analyze.rb b/tests/test_unit_analyze.rb index abc1234..def5678 100644 --- a/tests/test_unit_analyze.rb +++ b/tests/test_unit_analyze.rb @@ -17,7 +17,8 @@ it "should detect duplicates in digit uniqueness check" do output = capture_stdout { - load "././sudokuru.rb" + load "...
Load only necessary files for the analyze unit tests Please, sir. May I have some more files?
diff --git a/test/queue_test.rb b/test/queue_test.rb index abc1234..def5678 100644 --- a/test/queue_test.rb +++ b/test/queue_test.rb @@ -2,7 +2,8 @@ context "Queue" do - setup do + test "playlist name" do + assert_equal 'Play', Play.name end end
Add test to Queue to stay green
diff --git a/ruby/command-t/progress_reporter.rb b/ruby/command-t/progress_reporter.rb index abc1234..def5678 100644 --- a/ruby/command-t/progress_reporter.rb +++ b/ruby/command-t/progress_reporter.rb @@ -2,6 +2,12 @@ # Licensed under the terms of the BSD 2-clause license. module CommandT + # Simple class for displ...
Add a doc comment to ProgressReporter
diff --git a/spec/features/items_spec.rb b/spec/features/items_spec.rb index abc1234..def5678 100644 --- a/spec/features/items_spec.rb +++ b/spec/features/items_spec.rb @@ -15,5 +15,12 @@ expect(page).to have_field("item_model", :with => @item.model) end + it "a new item form with proper departments filled in...
Add test that checks that the only two options in the item form department select are the one that has manage_items as true and the empty option present (:options is an exact match)
diff --git a/spec/features/login_spec.rb b/spec/features/login_spec.rb index abc1234..def5678 100644 --- a/spec/features/login_spec.rb +++ b/spec/features/login_spec.rb @@ -0,0 +1,11 @@+require 'rails_helper' + +feature 'login' do + it "should have a login button on the front page" do + visit '/' + expect(page)....
Add test that looks for login button
diff --git a/spec/statsd/version_spec.rb b/spec/statsd/version_spec.rb index abc1234..def5678 100644 --- a/spec/statsd/version_spec.rb +++ b/spec/statsd/version_spec.rb @@ -3,7 +3,7 @@ describe Datadog::Statsd do describe 'VERSION' do it 'has a version' do - expect(Datadog::Statsd::VERSION).to eq '5.3.1' +...
Update the version test to just check format It's good to have a test to make sure VERSION is set, but asserting that it is equal to a specific version just means we have to change the version in two places. This updates the test to just check that it's a X.Y.Z version.
diff --git a/account.rb b/account.rb index abc1234..def5678 100644 --- a/account.rb +++ b/account.rb @@ -15,8 +15,12 @@ def start loop do - @stream.user do |obj| - extract_obj(obj) + begin + @stream.user do |obj| + extract_obj(obj) + end + rescue E...
Fix error handling for EOFError
diff --git a/app/lib/telemetry_service.rb b/app/lib/telemetry_service.rb index abc1234..def5678 100644 --- a/app/lib/telemetry_service.rb +++ b/app/lib/telemetry_service.rb @@ -4,6 +4,11 @@ class TelemetryService < AbstractServiceRunner MESSAGE = "TELEMETRY MESSAGE FROM %s" FAILURE = "FAILED TELEMETRY MESSAGE FRO...
Add throttle policy to Telemetry channel
diff --git a/app/models/display_format.rb b/app/models/display_format.rb index abc1234..def5678 100644 --- a/app/models/display_format.rb +++ b/app/models/display_format.rb @@ -1,7 +1,7 @@ class DisplayFormat < ActiveRecord::Base attr_accessible :name - has_many :categorical_traits - has_many :continuous_traits + ...
Add dependent => nullify to display_fomat
diff --git a/lib/active_record/olap/category.rb b/lib/active_record/olap/category.rb index abc1234..def5678 100644 --- a/lib/active_record/olap/category.rb +++ b/lib/active_record/olap/category.rb @@ -14,7 +14,7 @@ if definition.kind_of?(Hash) && definition.has_key?(:expression) @conditions = def...
Fix of hash that does not retain expression value in production mode.
diff --git a/spec/api_classes/tag_spec.rb b/spec/api_classes/tag_spec.rb index abc1234..def5678 100644 --- a/spec/api_classes/tag_spec.rb +++ b/spec/api_classes/tag_spec.rb @@ -2,6 +2,6 @@ describe LastFM::Tag do it "should define unrestricted methods" do - LastFM::Tag.unrestricted_methods.should == [:get_simil...
Check method definitions for Tag
diff --git a/spec/joystick_events_spec.rb b/spec/joystick_events_spec.rb index abc1234..def5678 100644 --- a/spec/joystick_events_spec.rb +++ b/spec/joystick_events_spec.rb @@ -9,10 +9,14 @@ describe JoystickAxisMoved do + + before :each do + @event = JoystickAxisMoved.new + end it "should have a joys...
Refactor JoystickAxisMoved specs a bit.
diff --git a/spec/models/location_spec.rb b/spec/models/location_spec.rb index abc1234..def5678 100644 --- a/spec/models/location_spec.rb +++ b/spec/models/location_spec.rb @@ -2,11 +2,47 @@ RSpec.describe Location do describe "validations" do + subject { FactoryGirl.build(:location) } + + it "is valid for t...
Improve test coverage for Location model
diff --git a/spec/regression/test_0003.rb b/spec/regression/test_0003.rb index abc1234..def5678 100644 --- a/spec/regression/test_0003.rb +++ b/spec/regression/test_0003.rb @@ -0,0 +1,20 @@+require 'test_helpers' +describe Alf do + + it 'should meet union/intersect priorities' do + db.connect do |conn| + rel =...
Add regression test about intersect(minus)
diff --git a/lib/ews/soap/parsers/ews_parser.rb b/lib/ews/soap/parsers/ews_parser.rb index abc1234..def5678 100644 --- a/lib/ews/soap/parsers/ews_parser.rb +++ b/lib/ews/soap/parsers/ews_parser.rb @@ -28,8 +28,9 @@ def parse(opts = {}) opts[:response_class] ||= EwsSoapResponse - @soap_resp.gsub!('vers...
Revert "Replace XML version of SOAP response from 1.0 to 1.1" This reverts commit 506d87c076293fae1ae85d2545fc7c7e84f52a5f.
diff --git a/app/services/mute_service.rb b/app/services/mute_service.rb index abc1234..def5678 100644 --- a/app/services/mute_service.rb +++ b/app/services/mute_service.rb @@ -1,9 +1,13 @@ # frozen_string_literal: true class MuteService < BaseService - def call(account, target_account) + def call(account, target_...
Add support for muting notifications in MuteService
diff --git a/lib/llt/core/api/version_routes.rb b/lib/llt/core/api/version_routes.rb index abc1234..def5678 100644 --- a/lib/llt/core/api/version_routes.rb +++ b/lib/llt/core/api/version_routes.rb @@ -5,7 +5,7 @@ get("#{route}/version") do dependencies.map do |dep_class| - versioner = LLT.cons...
Fix Dynamic Routes after recent name change Version class is called VersionInfo now
diff --git a/lib/switch_user/provider/devise.rb b/lib/switch_user/provider/devise.rb index abc1234..def5678 100644 --- a/lib/switch_user/provider/devise.rb +++ b/lib/switch_user/provider/devise.rb @@ -7,7 +7,7 @@ end def login(user, scope = :user) - @warden.session_serializer.store(user, scope) + ...
Revert "Devise provider- don't store sign_in details" This reverts commit e6147fb8e51e4293a5b00aa6862aec4ca711b7ec.
diff --git a/lib/tasks/fix_missing_mr_refs.rake b/lib/tasks/fix_missing_mr_refs.rake index abc1234..def5678 100644 --- a/lib/tasks/fix_missing_mr_refs.rake +++ b/lib/tasks/fix_missing_mr_refs.rake @@ -0,0 +1,48 @@+#-- +# Copyright (C) 2014 Gitorious AS +# +# This program is free software: you can redistribute it an...
Add rake task for creating missing MR refs Run it like this: bundle exec rake fix_missing_mr_refs PROJECT_SLUG=foo REPO_NAME=bar MR_NUMBER=123
diff --git a/lib/transproc/contrib/hash_keys.rb b/lib/transproc/contrib/hash_keys.rb index abc1234..def5678 100644 --- a/lib/transproc/contrib/hash_keys.rb +++ b/lib/transproc/contrib/hash_keys.rb @@ -0,0 +1,33 @@+module Transproc + SEPARATOR = ' '.freeze + + # Join keys together using a default separator token (sin...
Add hash join and split transforms
diff --git a/library/stringscanner/scan_spec.rb b/library/stringscanner/scan_spec.rb index abc1234..def5678 100644 --- a/library/stringscanner/scan_spec.rb +++ b/library/stringscanner/scan_spec.rb @@ -28,6 +28,12 @@ @s.scan(/\w+/).should be_nil end + it "returns an empty string when the pattern matches empty"...
Add spec for matching an empty string
diff --git a/NSURL+QueryDictionary.podspec b/NSURL+QueryDictionary.podspec index abc1234..def5678 100644 --- a/NSURL+QueryDictionary.podspec +++ b/NSURL+QueryDictionary.podspec @@ -1,6 +1,6 @@ Pod::Spec.new do |s| s.name = "NSURL+QueryDictionary" - s.version = "1.1.0" + s.version = "1.2.0" ...
Add tvOS to the Podspec
diff --git a/spec/helpers/concept_helper_spec.rb b/spec/helpers/concept_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/concept_helper_spec.rb +++ b/spec/helpers/concept_helper_spec.rb @@ -21,22 +21,17 @@ ) end - it 'displays nothing because weve turned it off since the query is killing ...
Revert "remove concept results from student profile until we can make a less expensive query" This reverts commit 36d11739c8e24c9c7f0e3335e3a2bc7ff8ecb132.
diff --git a/spec/mailers/contact_mailer_spec.rb b/spec/mailers/contact_mailer_spec.rb index abc1234..def5678 100644 --- a/spec/mailers/contact_mailer_spec.rb +++ b/spec/mailers/contact_mailer_spec.rb @@ -3,6 +3,15 @@ RSpec.describe ContactMailer, type: :mailer do describe "#send_contact_message" do let(:email)...
Fix spec that depends on environment variable
diff --git a/spec/models/broggle/broggle_spec.rb b/spec/models/broggle/broggle_spec.rb index abc1234..def5678 100644 --- a/spec/models/broggle/broggle_spec.rb +++ b/spec/models/broggle/broggle_spec.rb @@ -1,7 +1,7 @@ describe Broggle do let(:broggle) { build(:broggle) } - it 'points to master' do - expect(brog...
Change basic spec for broggle model
diff --git a/spec/tic_tac_toe/ai/minimax_spec.rb b/spec/tic_tac_toe/ai/minimax_spec.rb index abc1234..def5678 100644 --- a/spec/tic_tac_toe/ai/minimax_spec.rb +++ b/spec/tic_tac_toe/ai/minimax_spec.rb @@ -1,9 +1,29 @@ require 'spec_helper' describe TicTacToe::AI::Minimax do - it 'wins when it has two in a row' do -...
Add some basic move tests
diff --git a/config/initializers/state_machine_patch.rb b/config/initializers/state_machine_patch.rb index abc1234..def5678 100644 --- a/config/initializers/state_machine_patch.rb +++ b/config/initializers/state_machine_patch.rb @@ -0,0 +1,9 @@+# This is a patch to address the issue in https://github.com/pluginaweek/st...
Add a state_machine patch for rails 4.1.
diff --git a/vault.gemspec b/vault.gemspec index abc1234..def5678 100644 --- a/vault.gemspec +++ b/vault.gemspec @@ -8,7 +8,7 @@ spec.version = Vault::VERSION spec.authors = ["Seth Vargo"] spec.email = ["sethvargo@gmail.com"] - spec.licenses = ["MPLv2"] + spec.licenses = ["MPL-2....
Use official SPDX ID for license https://spdx.org/licenses/
diff --git a/app/controllers/spree/user_sessions_controller.rb b/app/controllers/spree/user_sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/user_sessions_controller.rb +++ b/app/controllers/spree/user_sessions_controller.rb @@ -9,11 +9,6 @@ ssl_required :new, :create, :destroy, :upd...
Remove useless new action definition inside UserSessionsController
diff --git a/lib/concord.rb b/lib/concord.rb index abc1234..def5678 100644 --- a/lib/concord.rb +++ b/lib/concord.rb @@ -11,7 +11,7 @@ end def self.publish(topic_name, object, options = {}) - Publisher.new(topic_name, object, options).publish + Publisher.new(options).publish(topic_name, object) end ...
Fix argument passing on subscribe
diff --git a/recipes/sandbox/20-extend-irb.rake b/recipes/sandbox/20-extend-irb.rake index abc1234..def5678 100644 --- a/recipes/sandbox/20-extend-irb.rake +++ b/recipes/sandbox/20-extend-irb.rake @@ -5,6 +5,9 @@ file File.join(sandboxdir, "bin/irb.cmd") => File.join(unpackdirmgw, "bin/irb.cmd") do |t| puts "generat...
Fix irb hook for ruby-2.6+ Fixes #158 Also make sure, that future changes on irb.cmd will raise a build failure.
diff --git a/lib/esprima.rb b/lib/esprima.rb index abc1234..def5678 100644 --- a/lib/esprima.rb +++ b/lib/esprima.rb @@ -3,10 +3,10 @@ require 'v8' require 'commonjs' -require './lib/esprima/parser' +require 'esprima/parser' module Esprima def self.load_path @load_path ||= File.expand_path(File.join(File....
Fix path to parser for gem
diff --git a/app/serializers/sprangular/taxonomy_serializer.rb b/app/serializers/sprangular/taxonomy_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/sprangular/taxonomy_serializer.rb +++ b/app/serializers/sprangular/taxonomy_serializer.rb @@ -1,6 +1,6 @@ module Sprangular class TaxonomySerializer <...
Allow the taxonomy attributes to be overridden in host app
diff --git a/Library/Formula/tokyo-dystopia.rb b/Library/Formula/tokyo-dystopia.rb index abc1234..def5678 100644 --- a/Library/Formula/tokyo-dystopia.rb +++ b/Library/Formula/tokyo-dystopia.rb @@ -1,14 +1,14 @@ require 'formula' class TokyoDystopia <Formula - url 'http://1978th.net/tokyodystopia/tokyodystopia-0.9.1...
Update Tokyo Dystopia to 0.9.14
diff --git a/Casks/electrum-ltc.rb b/Casks/electrum-ltc.rb index abc1234..def5678 100644 --- a/Casks/electrum-ltc.rb +++ b/Casks/electrum-ltc.rb @@ -6,7 +6,7 @@ gpg "#{url}.asc", :key_id => '9914864dfc33499c6ca2beea22453004695506fd' name 'Electrum-LTC' - homepage 'http://electrum-ltc.org' + homepage 'http...
Fix homepage to use SSL in Electrum-LTC Cask The HTTP URL is already getting redirected to HTTPS. Using the HTTPS URL directly makes it more secure and saves a HTTP round-trip.
diff --git a/config/initializers/app-overrides.rb b/config/initializers/app-overrides.rb index abc1234..def5678 100644 --- a/config/initializers/app-overrides.rb +++ b/config/initializers/app-overrides.rb @@ -1,5 +1,6 @@ if Rails.env.development? - Rails.logger = Logger.new(STDOUT) # Get logs to spit out when using fo...
Use rails_12factor in development instead of setting Rails.logger.
diff --git a/sandwich.rb b/sandwich.rb index abc1234..def5678 100644 --- a/sandwich.rb +++ b/sandwich.rb @@ -19,10 +19,10 @@ Chef::Log.level = :debug run_context = Chef::RunContext.new($client.node, {}) # @recipe = Chef::Recipe.new(nil, nil, run_context) + Chef::Log.level = :debug + add_package_to_run_context(...
Install package via run context resource collection
diff --git a/core/spec/models/tax_category_spec.rb b/core/spec/models/tax_category_spec.rb index abc1234..def5678 100644 --- a/core/spec/models/tax_category_spec.rb +++ b/core/spec/models/tax_category_spec.rb @@ -19,7 +19,7 @@ end it "should undefault the previous default tax category" do - new_tax_cate...
Use update_attributes inside "should undefeault the previous default tax category" spec ,as we *do* care about callbacks in this instance
diff --git a/benchmarks/speed.rb b/benchmarks/speed.rb index abc1234..def5678 100644 --- a/benchmarks/speed.rb +++ b/benchmarks/speed.rb @@ -39,8 +39,11 @@ tpl.to_html end +content = File.read(ComplexView.template_file) + bench '{ w/o caching' do tpl = ComplexView.new + tpl.template = content tpl[:item] = ...
Fix the benchmark of Mustache without caching
diff --git a/spec/features/system/admin/course_management_spec.rb b/spec/features/system/admin/course_management_spec.rb index abc1234..def5678 100644 --- a/spec/features/system/admin/course_management_spec.rb +++ b/spec/features/system/admin/course_management_spec.rb @@ -4,11 +4,12 @@ let(:instance) { create(:instan...
Test courses index in the last page
diff --git a/spec/fixtures/test_project/lib/combined_text_test.rb b/spec/fixtures/test_project/lib/combined_text_test.rb index abc1234..def5678 100644 --- a/spec/fixtures/test_project/lib/combined_text_test.rb +++ b/spec/fixtures/test_project/lib/combined_text_test.rb @@ -17,7 +17,7 @@ output :text, :text re...
Order of reducer input values is not deterministic.
diff --git a/cookbooks/chef/attributes/default.rb b/cookbooks/chef/attributes/default.rb index abc1234..def5678 100644 --- a/cookbooks/chef/attributes/default.rb +++ b/cookbooks/chef/attributes/default.rb @@ -5,7 +5,7 @@ default[:chef][:server][:version] = "11.1.3-1" # Set the default client version -default[:chef][...
Update chef client to 11.16.2-1
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb index abc1234..def5678 100644 --- a/app/controllers/pages_controller.rb +++ b/app/controllers/pages_controller.rb @@ -1,5 +1,5 @@ class PagesController < ApplicationController - before_action :authenticate_user!, except: [:index, :h...
Allow non-logged in to view leaderboard
diff --git a/lib/bnr/webhooks/notifier.rb b/lib/bnr/webhooks/notifier.rb index abc1234..def5678 100644 --- a/lib/bnr/webhooks/notifier.rb +++ b/lib/bnr/webhooks/notifier.rb @@ -20,11 +20,11 @@ end def notify + response = send_to(subscriber.url) send_to(debug_endpoint) do |request| ...
Send to subscriber first in case debug is sluggish.
diff --git a/app/helpers/load_profiles_helper.rb b/app/helpers/load_profiles_helper.rb index abc1234..def5678 100644 --- a/app/helpers/load_profiles_helper.rb +++ b/app/helpers/load_profiles_helper.rb @@ -9,11 +9,11 @@ options_for_select(load_profiles, { selected: profile.load_profile_category_id }) end - def...
Fix "edit load profile" page technologies_select_options should take an argument specifying the selected technology, if applicable.
diff --git a/lib/em-kannel/test_helper.rb b/lib/em-kannel/test_helper.rb index abc1234..def5678 100644 --- a/lib/em-kannel/test_helper.rb +++ b/lib/em-kannel/test_helper.rb @@ -1,3 +1,5 @@+require "ostruct" + module EventMachine class Kannel def self.deliveries @@ -5,8 +7,16 @@ end Client.class_eval...
Make test helper work more like a real Client Client#deliver receives a block that allows the caller to know the status of the HTTP call after the callback fires. By default we return a successful response using an OpenStruct.
diff --git a/lib/middleware/start_trim.rb b/lib/middleware/start_trim.rb index abc1234..def5678 100644 --- a/lib/middleware/start_trim.rb +++ b/lib/middleware/start_trim.rb @@ -1,7 +1,6 @@ # -*- encoding : utf-8 -*- # This middleware removes all keyframes before frame 0, and skips trackers entirely if they are all bef...
Remove this enable as well
diff --git a/app/mailers/user_mailer.rb b/app/mailers/user_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/user_mailer.rb +++ b/app/mailers/user_mailer.rb @@ -3,7 +3,7 @@ def event_notification(event) @event = event - mail(to: 'anders.e.howerton@gmail.com', subject: "New Event Submitted") + mai...
Change mail address to andrew's address
diff --git a/week-6/gps.rb b/week-6/gps.rb index abc1234..def5678 100644 --- a/week-6/gps.rb +++ b/week-6/gps.rb @@ -1,33 +1,24 @@ # Your Names # 1) Stephanie Major -# 2) +# 2)Kenton Lin -# We spent [#] hours on this challenge. +# We spent 1 hours on this challenge. # Bakery Serving Size portion calculator. -de...
Add GPS 2.3 solution to the file
diff --git a/test/unit/case_study_test.rb b/test/unit/case_study_test.rb index abc1234..def5678 100644 --- a/test/unit/case_study_test.rb +++ b/test/unit/case_study_test.rb @@ -9,24 +9,4 @@ assert article.can_be_related_to_policies? end - # test "#topics includes topics associated with related published polic...
Remove useless commented out tests
diff --git a/lib/make_flaggable/flagging.rb b/lib/make_flaggable/flagging.rb index abc1234..def5678 100644 --- a/lib/make_flaggable/flagging.rb +++ b/lib/make_flaggable/flagging.rb @@ -1,9 +1,9 @@ module MakeFlaggable class Flagging < ActiveRecord::Base - belongs_to :flaggable, :polymorphic => true - belongs_t...
Add counter cache to flaggable
diff --git a/lib/ruby-handlebars/context.rb b/lib/ruby-handlebars/context.rb index abc1234..def5678 100644 --- a/lib/ruby-handlebars/context.rb +++ b/lib/ruby-handlebars/context.rb @@ -29,10 +29,6 @@ end end - if item.instance_variables.include?("@#{attribute}") - return item.instance_varia...
Remove ability to dig into instance variables The data object should provide access via its methods instead.
diff --git a/lib/runoff/commands/command.rb b/lib/runoff/commands/command.rb index abc1234..def5678 100644 --- a/lib/runoff/commands/command.rb +++ b/lib/runoff/commands/command.rb @@ -3,9 +3,20 @@ module Commands # The base class for every runoff command. class Command + # Public: Provides a FileWrite...
Use instead of and add a documentation comment
diff --git a/lib/sshkit/runners/parallel.rb b/lib/sshkit/runners/parallel.rb index abc1234..def5678 100644 --- a/lib/sshkit/runners/parallel.rb +++ b/lib/sshkit/runners/parallel.rb @@ -9,7 +9,7 @@ threads = [] hosts.each do |host| threads << Thread.new(host) do |h| - backend(host,...
Use the local copy of host on each thread
diff --git a/Casks/adium-nightly16.rb b/Casks/adium-nightly16.rb index abc1234..def5678 100644 --- a/Casks/adium-nightly16.rb +++ b/Casks/adium-nightly16.rb @@ -2,9 +2,16 @@ version '1.6hgr5915' sha256 '70619777433df646a7251a10eb74baecdc5a47be085cd83d35f3750fcfea9e1b' - url "http://nightly.adium.im/adium-adium-...
Add missing stanzas to Adium Nightly16
diff --git a/lib/vagrant/util/platform.rb b/lib/vagrant/util/platform.rb index abc1234..def5678 100644 --- a/lib/vagrant/util/platform.rb +++ b/lib/vagrant/util/platform.rb @@ -33,7 +33,7 @@ # # @return [Boolean] def bit64? - ["x86_64", "amd64"].include?(::Config::CONFIG["host_cpu"]) ...
Use RbConfig instead of Config, latter is deprecated
diff --git a/Casks/tv-show-tracker.rb b/Casks/tv-show-tracker.rb index abc1234..def5678 100644 --- a/Casks/tv-show-tracker.rb +++ b/Casks/tv-show-tracker.rb @@ -0,0 +1,7 @@+class TvShowTracker < Cask + url 'http://www.pixelperfectwidgets.com/tvshowtracker/download/tvshowtracker_1.3.3.zip' + homepage 'http://www.pixel...
Add TV Show Tracker Widget 1.3.3
diff --git a/Casks/vagrant-manager.rb b/Casks/vagrant-manager.rb index abc1234..def5678 100644 --- a/Casks/vagrant-manager.rb +++ b/Casks/vagrant-manager.rb @@ -1,11 +1,11 @@ cask 'vagrant-manager' do - version '2.5.3' - sha256 'c2780c3560f7f27a0a87fa01983ec329ed13b7cb139515cf70415ae959b99562' + version '2.5.4' + s...
Upgrade Vagrant Manager.app to v2.5.4
diff --git a/Casks/zerobranestudio.rb b/Casks/zerobranestudio.rb index abc1234..def5678 100644 --- a/Casks/zerobranestudio.rb +++ b/Casks/zerobranestudio.rb @@ -1,6 +1,6 @@ cask 'zerobranestudio' do - version '1.20' - sha256 '1ad9bc8b4c636f4a2c8bf6adb55ba0b4327c134ced0058744496ac6accc8265e' + version '1.30' + sha25...
Update ZeroBrane Studio to 1.30
diff --git a/yabfi.gemspec b/yabfi.gemspec index abc1234..def5678 100644 --- a/yabfi.gemspec +++ b/yabfi.gemspec @@ -8,7 +8,7 @@ spec.version = YABFI::VERSION spec.authors = ['Tom Hulihan'] spec.email = ['hulihan.tom159@gmail.com'] - spec.summary = 'Yet...
Fix rubocop error in gemspec
diff --git a/my-backend/db/seeds.rb b/my-backend/db/seeds.rb index abc1234..def5678 100644 --- a/my-backend/db/seeds.rb +++ b/my-backend/db/seeds.rb @@ -5,3 +5,10 @@ {email: 'pink@mail.com', password: '12345678', password_confirmation: '12345678'} ]) + +Post.create( + {title: "A Sample Post", + body: "Thi...
Add seed data for Posts.
diff --git a/models/team.rb b/models/team.rb index abc1234..def5678 100644 --- a/models/team.rb +++ b/models/team.rb @@ -1,10 +1,14 @@ class Team include Mongoid::Document include Mongoid::Timestamps + + field :_id, type: Integer field :name, type: String field :location, type: String has_many :participat...
Switch to Team number schema
diff --git a/config/software/loom-server.rb b/config/software/loom-server.rb index abc1234..def5678 100644 --- a/config/software/loom-server.rb +++ b/config/software/loom-server.rb @@ -15,5 +15,5 @@ command "chmod +x #{install_dir}/server/bin/*" command "mkdir -p #{install_dir}/server/lib" command "cd server &&...
Add server prefix to directory for pulling JAR
diff --git a/FDChessboardView.podspec b/FDChessboardView.podspec index abc1234..def5678 100644 --- a/FDChessboardView.podspec +++ b/FDChessboardView.podspec @@ -11,4 +11,5 @@ s.resource_bundles = { 'FDChessboardView' => ['Resources/**/*.{png}'] } + s.swift_version = '4.0' end
Use swift version 4.0 for podspec