diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/guidestar.rb b/lib/guidestar.rb index abc1234..def5678 100644 --- a/lib/guidestar.rb +++ b/lib/guidestar.rb @@ -23,6 +23,5 @@ end end - Faraday::Response.register_middleware :response, - :raise_guidestar_error => lambda { Faraday::Response::RaiseGuidestarError } + Faraday::Response.regist...
Use new syntax for registering middleware
diff --git a/lib/munge/extras/livereload/server.rb b/lib/munge/extras/livereload/server.rb index abc1234..def5678 100644 --- a/lib/munge/extras/livereload/server.rb +++ b/lib/munge/extras/livereload/server.rb @@ -16,6 +16,7 @@ socket << @messaging.reload(file) end rescue Reel...
Handle Reel::SocketError instead of ignoring
diff --git a/lib/rubocop/rspec/config_formatter.rb b/lib/rubocop/rspec/config_formatter.rb index abc1234..def5678 100644 --- a/lib/rubocop/rspec/config_formatter.rb +++ b/lib/rubocop/rspec/config_formatter.rb @@ -15,7 +15,9 @@ end def dump - YAML.dump(unified_config).gsub(EXTENSION_ROOT_DEPARTMENT...
Fix indentation in generated YAML
diff --git a/app/uploaders/francis_cms/author_avatar_uploader.rb b/app/uploaders/francis_cms/author_avatar_uploader.rb index abc1234..def5678 100644 --- a/app/uploaders/francis_cms/author_avatar_uploader.rb +++ b/app/uploaders/francis_cms/author_avatar_uploader.rb @@ -20,11 +20,14 @@ def manipulate_author_avatar(...
Rework image manipulation so that JPGs are actually progressive.
diff --git a/lib/wicket-sdk/resource_collection.rb b/lib/wicket-sdk/resource_collection.rb index abc1234..def5678 100644 --- a/lib/wicket-sdk/resource_collection.rb +++ b/lib/wicket-sdk/resource_collection.rb @@ -8,7 +8,7 @@ ].freeze def initialize(data = []) - data = [data].compact! unless data.is_a?(A...
Check for ResourceIdentifier + fix bug on initialize when not an array.
diff --git a/spec/models_spec.rb b/spec/models_spec.rb index abc1234..def5678 100644 --- a/spec/models_spec.rb +++ b/spec/models_spec.rb @@ -9,12 +9,12 @@ end end -Reso::DataDictionary.specification.resources.each do |resource| - RSpec.describe "#{resource} attributes" do - Reso::DataDictionary.specification.f...
Comment out field test specs for now
diff --git a/spec/runner_spec.rb b/spec/runner_spec.rb index abc1234..def5678 100644 --- a/spec/runner_spec.rb +++ b/spec/runner_spec.rb @@ -28,7 +28,7 @@ end it 'no documentation is nil' do - subject[0].no_documentation.should be_nil + subject[0].no_documentation.should be_false end it 'documented...
Update spec for no_documenation parameter Changed from defaulting to nil to defaulting to false
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -12,6 +12,7 @@ RSpec.configure do |config| config.around do |example| + next example.run unless example.metadata.fetch(:rollback, true) ActiveRecord::Base.transaction ...
Allow rollback to be skipped using RSpec metadata
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -22,4 +22,9 @@ def appboy_test_segment ::ENV.fetch('APPBOY_TEST_SEGMENT', 'fake-test-segment') end + + def appboy_schedule_id + @appboy_schedule_id ||= 'fake-schedule...
Add RSpec appboy_schedule_id global test method
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,5 +1,7 @@-require 'coveralls' -Coveralls.wear! +if ENV['CI'] + require 'coveralls' + Coveralls.wear! +end spec_path = File.dirname(__FILE__) $LOAD_PATH.unshift(spec_path)
Use coveralls only on CI
diff --git a/main.rb b/main.rb index abc1234..def5678 100644 --- a/main.rb +++ b/main.rb @@ -6,14 +6,26 @@ class Terminal def initialize(variable_terminals) - if rand > 0.5 + if is_variable? @terminal = variable_terminals.sample else @terminal = (10 * rand).round(1) - if rand > 0.5 + ...
Add predicates to Terminal class
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -7,11 +7,11 @@ require 'rspec' if defined? require_relative - require_relative 'support/localhost_server.rb' - require_relative 'support/server.rb' + require_relative 'suppor...
Remove unneeded .rb from some requires
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -2,10 +2,7 @@ require 'pathname' DIR = Pathname.new(__FILE__ + '../..').expand_path.dirname -LOAD_PATH = DIR.join('lib').to_s -$LOAD_PATH.unshift(LOAD_PATH) unless - $LOAD_PATH...
Remove more unnecessary LOAD_PATH fiddling
diff --git a/main.rb b/main.rb index abc1234..def5678 100644 --- a/main.rb +++ b/main.rb @@ -7,19 +7,31 @@ end def add_up(level) + @up_requests |= (1 << (level - 1)) if level > 0 # set corresponding bit starting from right most position + end + + def add_down(level) + @down_requests |= (1 << (level - 1))...
Add methods to set and serve requests
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index abc1234..def5678 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -8,5 +8,3 @@ config.version = '18.04' config.log_level = :fatal end - -at_exit { ChefSpec::Coverage.report! }
Drop obsolete ChefSpec coverage from unit tests No longer available; it causes an error in testing
diff --git a/lib/hotspots/repository/driver/git.rb b/lib/hotspots/repository/driver/git.rb index abc1234..def5678 100644 --- a/lib/hotspots/repository/driver/git.rb +++ b/lib/hotspots/repository/driver/git.rb @@ -19,8 +19,8 @@ def execute_with_log(command) command.run.tap do |output| - @...
Include new-line between message and actual input/output
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/users_controller_spec.rb +++ b/spec/controllers/users_controller_spec.rb @@ -26,7 +26,7 @@ phone: '1234567890', image: 'http://media3.s-nbcnews.com/i/newscms/...
Refactor User controller spec to use expect instead of should
diff --git a/lib/pg-quilter.rb b/lib/pg-quilter.rb index abc1234..def5678 100644 --- a/lib/pg-quilter.rb +++ b/lib/pg-quilter.rb @@ -12,3 +12,4 @@ require 'pg-quilter/build' require 'pg-quilter/build_runner' require 'pg-quilter/task_master' +require 'pg-quilter/worker'
Include worker; still required for specs
diff --git a/lib/randomtext.rb b/lib/randomtext.rb index abc1234..def5678 100644 --- a/lib/randomtext.rb +++ b/lib/randomtext.rb @@ -0,0 +1,9 @@+%w{randomtext/markov_chain randomtext/text_generator randomtext/weighted_directed_graph}.each do |file| + require File.expand_path file, File.dirname(__FILE__) +end + +module...
Add top level module that can be require'd. Probably should have let Bundler gem this up for me instead of fumbling my way through creating a gem from scratch, but I'll consider that a lesson learned.
diff --git a/lib/tasks/chat.rb b/lib/tasks/chat.rb index abc1234..def5678 100644 --- a/lib/tasks/chat.rb +++ b/lib/tasks/chat.rb @@ -0,0 +1,16 @@+# Due to a bug ChatChannelsUsers and ChatMessages without a channel_id were created. +# This tasks deletes them. +namespace :cg do + namespace :chat do + desc "Deletes Ch...
Add task to delete ChatChannelsUsers and ChatMessages without a channel_id.
diff --git a/ajax-nested-fields.gemspec b/ajax-nested-fields.gemspec index abc1234..def5678 100644 --- a/ajax-nested-fields.gemspec +++ b/ajax-nested-fields.gemspec @@ -21,5 +21,8 @@ s.files = `git ls-files`.split("\n") s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n") s.executables...
Remove example from build file
diff --git a/features/support/env.rb b/features/support/env.rb index abc1234..def5678 100644 --- a/features/support/env.rb +++ b/features/support/env.rb @@ -16,3 +16,10 @@ World(SinatraTestIntegration) World(SchemaHelpers) + +Around do |_, block| + delete_command = "curl -XDELETE 'http://localhost:9200/finder-api'"...
Delete the finder-api index before & after cukes.
diff --git a/core/app/models/spree/unit_cancel.rb b/core/app/models/spree/unit_cancel.rb index abc1234..def5678 100644 --- a/core/app/models/spree/unit_cancel.rb +++ b/core/app/models/spree/unit_cancel.rb @@ -6,18 +6,18 @@ DEFAULT_REASON = 'Cancel' belongs_to :inventory_unit - has_one :adjustment, as: :source, ...
Change UnitCancel adjustments association to has_many This makes it the same as all the other `adjustments` relationships which makes the repair code in Adjustment simpler, and it makes it easier to query for duplicates. Also, use `line_item.adjustments.create` instead of `unit_cancel.adjustments.create`. The latter ...
diff --git a/spec/ClassBrowser_spec.rb b/spec/ClassBrowser_spec.rb index abc1234..def5678 100644 --- a/spec/ClassBrowser_spec.rb +++ b/spec/ClassBrowser_spec.rb @@ -1,3 +1,6 @@+require "codeclimate-test-reporter" +CodeClimate::TestReporter.start + require_relative '../lib/ClassBrowser' describe "Test that the Objec...
Add code climate to spec
diff --git a/spec/bsf/database_spec.rb b/spec/bsf/database_spec.rb index abc1234..def5678 100644 --- a/spec/bsf/database_spec.rb +++ b/spec/bsf/database_spec.rb @@ -9,8 +9,13 @@ describe '.initialize' do - it 'connects to the database' do + it 'connects to the database via socket' do described_class....
Add database TCP/IP connection test. Add a test to make sure that our Database class will connect via TCP/IP if the option is included in the hash. While in the background the database is still an in memory database that doesn't care about the hash passed to it we should still test to see that the line adding that ha...
diff --git a/spec/send_message_spec.rb b/spec/send_message_spec.rb index abc1234..def5678 100644 --- a/spec/send_message_spec.rb +++ b/spec/send_message_spec.rb @@ -13,4 +13,18 @@ KannelRails.send_message("09101111111", "Hello World!") end + context "with extra params" do + it "should pass params to kannel...
Add test for passing extra parameters to kannel
diff --git a/spec/support/oboe_spec.rb b/spec/support/oboe_spec.rb index abc1234..def5678 100644 --- a/spec/support/oboe_spec.rb +++ b/spec/support/oboe_spec.rb @@ -1,7 +1,4 @@ require 'spec_helper' describe Oboe do - it 'should return correct version string' do - Oboe::Version::STRING.should =~ /2.0.0/ - end ...
Remove the version check test. It adds no value.
diff --git a/config/initializers/omniauth.rb b/config/initializers/omniauth.rb index abc1234..def5678 100644 --- a/config/initializers/omniauth.rb +++ b/config/initializers/omniauth.rb @@ -6,6 +6,6 @@ end provider :google_oauth2, config["providers"]["google_oauth2"]["key"], config["providers"]["google_oauth2...
Add parameter to send through an email
diff --git a/geos-extensions.gemspec b/geos-extensions.gemspec index abc1234..def5678 100644 --- a/geos-extensions.gemspec +++ b/geos-extensions.gemspec @@ -21,6 +21,6 @@ s.homepage = "http://github.com/zoocasa/geos-extensions" s.require_paths = ["lib"] - s.add_dependency("ffi-geos", ["~> 0.1"]) + s.add_depend...
Set ffi-geos dependency to >= 0.1.
diff --git a/spec/functions/split_spec.rb b/spec/functions/split_spec.rb index abc1234..def5678 100644 --- a/spec/functions/split_spec.rb +++ b/spec/functions/split_spec.rb @@ -4,7 +4,7 @@ it { should run.with_params('aoeu', 'o').and_return(['a', 'eu']) } it { should_not run.with_params('foo').and_raise_error(Pupp...
Fix version comparison in function specs
diff --git a/spec/models/entry_spec.rb b/spec/models/entry_spec.rb index abc1234..def5678 100644 --- a/spec/models/entry_spec.rb +++ b/spec/models/entry_spec.rb @@ -6,6 +6,13 @@ it { should validate_length_of(:script) } let(:c) do + User.create( + name: "Bill Nye", + nickname: "The Science Guy", + ...
Create user for Entry model spec
diff --git a/spec/matching/repeat_spec.rb b/spec/matching/repeat_spec.rb index abc1234..def5678 100644 --- a/spec/matching/repeat_spec.rb +++ b/spec/matching/repeat_spec.rb @@ -15,4 +15,18 @@ matches[1].token.should eq 'aaa' matches[1].repeated_char.should eq 'a' end + + context 'integration' do + def j...
Add passing repeat integration spec
diff --git a/spec/opal/source_map_spec.rb b/spec/opal/source_map_spec.rb index abc1234..def5678 100644 --- a/spec/opal/source_map_spec.rb +++ b/spec/opal/source_map_spec.rb @@ -0,0 +1,18 @@+require 'spec_helper' +require 'opal/source_map' + +describe Opal::SourceMap do + let(:assets) { Opal::Environment.new } + let(:...
Add a basic spec for source-maps
diff --git a/spec/optional_logger_spec.rb b/spec/optional_logger_spec.rb index abc1234..def5678 100644 --- a/spec/optional_logger_spec.rb +++ b/spec/optional_logger_spec.rb @@ -4,8 +4,4 @@ it "has a version number" do expect(OptionalLogger::VERSION).not_to be nil end - - it "does something useful" do - ex...
Remove the purposefully failing spec Why you made the change: I did this because now we have seen travis-ci successfully run and fail. Now we want to remove this and see travis-ci successfully run and succeed.
diff --git a/spec/unit/autoescape_spec.rb b/spec/unit/autoescape_spec.rb index abc1234..def5678 100644 --- a/spec/unit/autoescape_spec.rb +++ b/spec/unit/autoescape_spec.rb @@ -0,0 +1,49 @@+require "liquid/autoescape" +require "liquid/autoescape/configuration" + +module Liquid + describe Autoescape do + + after(:ea...
Add forgotten specs for the top-level Autoescape module
diff --git a/modules/mjr_convert/spec/init/spec.rb b/modules/mjr_convert/spec/init/spec.rb index abc1234..def5678 100644 --- a/modules/mjr_convert/spec/init/spec.rb +++ b/modules/mjr_convert/spec/init/spec.rb @@ -2,11 +2,11 @@ describe 'mjr_convert::init' do - describe command('mjr2webm') do + describe command('w...
Check commands exist rather then run them
diff --git a/homebrew.rb b/homebrew.rb index abc1234..def5678 100644 --- a/homebrew.rb +++ b/homebrew.rb @@ -2,8 +2,8 @@ class Ah < Formula homepage "https://github.com/9seconds/ah" - url "https://github.com/9seconds/ah.git", :tag => "0.13.1" - version "0.13.1" + url "https://github.com/9seconds/ah.git", :tag =...
Update HomeBrew formula to the version 0.14
diff --git a/app/mailers/user_mailer.rb b/app/mailers/user_mailer.rb index abc1234..def5678 100644 --- a/app/mailers/user_mailer.rb +++ b/app/mailers/user_mailer.rb @@ -19,7 +19,7 @@ @user = User.find(user_id) @user.touch(:personal_email_sent_on) - mail from: "matt@assemblymade.com", + mail from: "aust...
Change the from address of follow up to Austin.
diff --git a/HorizontalPickerControl.podspec b/HorizontalPickerControl.podspec index abc1234..def5678 100644 --- a/HorizontalPickerControl.podspec +++ b/HorizontalPickerControl.podspec @@ -21,7 +21,7 @@ s.platform = :ios, "8.0" - s.source = { :git => "https://github.com/acrookston/HorizontalPicker.git"...
Update tag reference in podspec
diff --git a/pronto-poper.gemspec b/pronto-poper.gemspec index abc1234..def5678 100644 --- a/pronto-poper.gemspec +++ b/pronto-poper.gemspec @@ -21,6 +21,6 @@ s.add_dependency 'pronto', '~> 0.2.0' s.add_dependency 'poper', '~> 0.0.1' - s.add_development_dependency 'rake', '~> 10.1.0' - s.add_development_depend...
Update rake and rspec versions
diff --git a/metadater.rb b/metadater.rb index abc1234..def5678 100644 --- a/metadater.rb +++ b/metadater.rb @@ -9,7 +9,6 @@ # Internal functions and classes require File.dirname(__FILE__) + '/lib/mediainfo.rb' -require File.dirname(__FILE__) + '/lib/exif.rb' require File.dirname(__FILE__) + '/lib/client.rb' # T...
Remove reference to deleted lib
diff --git a/lib/emcee/railtie.rb b/lib/emcee/railtie.rb index abc1234..def5678 100644 --- a/lib/emcee/railtie.rb +++ b/lib/emcee/railtie.rb @@ -4,6 +4,7 @@ require "emcee/post_processors/stylesheet_processor" require "emcee/compressors/html_compressor" require "emcee/documents/html_document" +require "emcee/resolver...
Integrate Resolver class into rail tie
diff --git a/db/migrate/20170130153424_send_correct_public_updated_at_for_cbt_manual.rb b/db/migrate/20170130153424_send_correct_public_updated_at_for_cbt_manual.rb index abc1234..def5678 100644 --- a/db/migrate/20170130153424_send_correct_public_updated_at_for_cbt_manual.rb +++ b/db/migrate/20170130153424_send_correct...
Send the correct public_updated_at to publishing-api for cbt manual This manual somehow has a first_published_at that is after it's current public_updated_at in the publishing-api/content-store. We don't know how it happened, but we can fix it with a republish event that sets the public_updated_at correctly.
diff --git a/lib/grn_mini/util.rb b/lib/grn_mini/util.rb index abc1234..def5678 100644 --- a/lib/grn_mini/util.rb +++ b/lib/grn_mini/util.rb @@ -9,11 +9,11 @@ end def text_snippet_from_selection_results(table, open_tag = '<<', close_tag = ">>") - table.expression.snippet([[open_tag, close_tag]]) + ...
Add normalize option to text_snippet_from_selection_results, html_snippet_from_selection_results
diff --git a/db/seeds.rb b/db/seeds.rb index abc1234..def5678 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -6,4 +6,11 @@ # cities = City.create([{ name: 'Chicago' }, { name: 'Copenhagen' }]) # Mayor.create(name: 'Emanuel', city: cities.first) -Group.create(number: "48", street: "Wall Street", city: "New York", ...
Create a single group in our migration.
diff --git a/mjml-ruby.gemspec b/mjml-ruby.gemspec index abc1234..def5678 100644 --- a/mjml-ruby.gemspec +++ b/mjml-ruby.gemspec @@ -18,7 +18,7 @@ s.platform = Gem::Platform::RUBY s.require_paths = ['lib'] - s.add_runtime_dependency 'dry-configurable', '~> 0.3', '~> 0.4' + s.add_runtime_depe...
Update dry-configurable dependency to match dry-validation
diff --git a/lib/poke/controls.rb b/lib/poke/controls.rb index abc1234..def5678 100644 --- a/lib/poke/controls.rb +++ b/lib/poke/controls.rb @@ -9,7 +9,7 @@ def initialize(params) Params.check_params(params, PARAMS_REQUIRED) - + @window = params[:window] end end
Add window ivar to Controls
diff --git a/db/migrate/20120511233557_change_hadoop_instance_state_to_online.rb b/db/migrate/20120511233557_change_hadoop_instance_state_to_online.rb index abc1234..def5678 100644 --- a/db/migrate/20120511233557_change_hadoop_instance_state_to_online.rb +++ b/db/migrate/20120511233557_change_hadoop_instance_state_to_o...
Migrate without the usage of models
diff --git a/guides/voice/conference-calls-guide/moderated-conference/example.rb b/guides/voice/conference-calls-guide/moderated-conference/example.rb index abc1234..def5678 100644 --- a/guides/voice/conference-calls-guide/moderated-conference/example.rb +++ b/guides/voice/conference-calls-guide/moderated-conference/ex...
Create Conference Calls in Ruby
diff --git a/lib/tasks/users.rake b/lib/tasks/users.rake index abc1234..def5678 100644 --- a/lib/tasks/users.rake +++ b/lib/tasks/users.rake @@ -1,38 +1,6 @@ # frozen_string_literal: true namespace :users do - desc 'Renames users with email-like usernames' - task remove_email_like_usernames: :environment do - t...
Remove some tasks that won't be run again
diff --git a/modules/django.rb b/modules/django.rb index abc1234..def5678 100644 --- a/modules/django.rb +++ b/modules/django.rb @@ -8,8 +8,7 @@ depend :remote, :command, "#{python}" def django_manage(cmd, options={}) - puts options - path = options.delete(:path) or "#{latest_release}" + path = options.delete(:pa...
Use correct form of "or" operator.
diff --git a/better_open_struct.gemspec b/better_open_struct.gemspec index abc1234..def5678 100644 --- a/better_open_struct.gemspec +++ b/better_open_struct.gemspec @@ -1,5 +1,4 @@ # -*- encoding: utf-8 -*- -require File.expand_path('../lib/better_open_struct/version', __FILE__) Gem::Specification.new do |gem| ge...
Remove line referencing deleted file
diff --git a/db/migrate/20160616102642_remove_duplicated_keys.rb b/db/migrate/20160616102642_remove_duplicated_keys.rb index abc1234..def5678 100644 --- a/db/migrate/20160616102642_remove_duplicated_keys.rb +++ b/db/migrate/20160616102642_remove_duplicated_keys.rb @@ -9,7 +9,7 @@ AND id != ( SELECT i...
Fix broken migration in MySQL Closes #19344
diff --git a/db/migrate/20170313104058_adjust_sent_validation.rb b/db/migrate/20170313104058_adjust_sent_validation.rb index abc1234..def5678 100644 --- a/db/migrate/20170313104058_adjust_sent_validation.rb +++ b/db/migrate/20170313104058_adjust_sent_validation.rb @@ -0,0 +1,41 @@+class AdjustSentValidation < ActiveRec...
Validate user.name on sent state
diff --git a/config/initializers/hydrant_config.rb b/config/initializers/hydrant_config.rb index abc1234..def5678 100644 --- a/config/initializers/hydrant_config.rb +++ b/config/initializers/hydrant_config.rb @@ -10,4 +10,4 @@ content_preview = IngestStep.new('preview', 'Preview and publish', 'Release the it...
Put file_upload back at beginning of workflow until we figure out a better workflow and fix assumptions in tests
diff --git a/config/initializers/show_constants.rb b/config/initializers/show_constants.rb index abc1234..def5678 100644 --- a/config/initializers/show_constants.rb +++ b/config/initializers/show_constants.rb @@ -1,10 +1,10 @@ CURRENT_TOP_ROW_VALUES = [200, 400].freeze PLAY_TYPES = { + "college" => "College Ch...
Move College Championship to top of play-type list
diff --git a/config/initializers/show_constants.rb b/config/initializers/show_constants.rb index abc1234..def5678 100644 --- a/config/initializers/show_constants.rb +++ b/config/initializers/show_constants.rb @@ -1,11 +1,11 @@ CURRENT_TOP_ROW_VALUES = [200, 400].freeze PLAY_TYPES = { + "teachers" => "Teac...
Move Teachers Tournament to top of play-type list
diff --git a/lib/generators/devise_materialize/install_generator.rb b/lib/generators/devise_materialize/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/devise_materialize/install_generator.rb +++ b/lib/generators/devise_materialize/install_generator.rb @@ -6,16 +6,16 @@ source_root File.expa...
Update default namespace to Devise instead of User
diff --git a/ovaltine.gemspec b/ovaltine.gemspec index abc1234..def5678 100644 --- a/ovaltine.gemspec +++ b/ovaltine.gemspec @@ -23,6 +23,6 @@ spec.require_paths = ["lib"] spec.add_development_dependency "bundler", "~> 1.3" - spec.add_development_dependency "rake" - spec.add_development_dependency "bacon" + s...
Make development dependencies more specific
diff --git a/noir.gemspec b/noir.gemspec index abc1234..def5678 100644 --- a/noir.gemspec +++ b/noir.gemspec @@ -20,7 +20,7 @@ spec.required_ruby_version = '>= 1.9.2' - spec.add_development_dependency 'bundler', '~> 1.7' + spec.add_development_dependency 'bundler', '~> 1.6' spec.add_development_dependency 'r...
Downgrade bundler version for compatible to 2.1.2
diff --git a/lita-weather.gemspec b/lita-weather.gemspec index abc1234..def5678 100644 --- a/lita-weather.gemspec +++ b/lita-weather.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |spec| spec.name = "lita-weather" - spec.version = "0.0.2" + spec.version = "0.0.3" spec.authors = ["M...
Update gemspec for Lita 3.0 compatibility.
diff --git a/spec/requests/styleguide_spec.rb b/spec/requests/styleguide_spec.rb index abc1234..def5678 100644 --- a/spec/requests/styleguide_spec.rb +++ b/spec/requests/styleguide_spec.rb @@ -0,0 +1,30 @@+RSpec.describe 'Styleguide', type: :request do + describe 'styleguide pages' do + routes = Rails.application.r...
Check that each styleguide page gives a 200
diff --git a/test/beantool_test.rb b/test/beantool_test.rb index abc1234..def5678 100644 --- a/test/beantool_test.rb +++ b/test/beantool_test.rb @@ -1,7 +1,7 @@-require 'test/unit' +require 'minitest/autorun' require File.join(File.dirname(__FILE__), '..', 'lib', 'beantool') -class BeantoolTest < Test::Unit::TestCas...
Update tests to use MiniTest
diff --git a/jekyll-theme-feeling-responsive.gemspec b/jekyll-theme-feeling-responsive.gemspec index abc1234..def5678 100644 --- a/jekyll-theme-feeling-responsive.gemspec +++ b/jekyll-theme-feeling-responsive.gemspec @@ -0,0 +1,23 @@+Gem::Specification.new do |s| + s.name = 'jekyll-theme-feeling-responsive' + s.versi...
Add gemspec for version 1.0.0
diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb index abc1234..def5678 100644 --- a/spec/helpers/application_helper_spec.rb +++ b/spec/helpers/application_helper_spec.rb @@ -11,4 +11,30 @@ expect(helper.login_strategy).to be :developer end end + + describe '...
Add test for title_for method in application helper
diff --git a/spec/views/images/show.html.erb_spec.rb b/spec/views/images/show.html.erb_spec.rb index abc1234..def5678 100644 --- a/spec/views/images/show.html.erb_spec.rb +++ b/spec/views/images/show.html.erb_spec.rb @@ -1,6 +1,6 @@ require 'spec_helper' -describe "images/show" do +describe "images/show", :type => :f...
Test image has correct source
diff --git a/lib/arel.rb b/lib/arel.rb index abc1234..def5678 100644 --- a/lib/arel.rb +++ b/lib/arel.rb @@ -1,13 +1,7 @@-$LOAD_PATH.unshift(File.dirname(__FILE__)) - -require 'rubygems' -require 'active_support' -require 'active_support/dependencies' -require 'active_support/core_ext/class/attribute_accessors' -requir...
Remove explicit rubygems require. Use Active Support provided by Active Record. Add self to load path after requiring Active Record.
diff --git a/config/initializers/figaro.rb b/config/initializers/figaro.rb index abc1234..def5678 100644 --- a/config/initializers/figaro.rb +++ b/config/initializers/figaro.rb @@ -0,0 +1,6 @@+# Define the environment variables that should be set in config/application.yml. +# See config/application.example.yml if you d...
Raise error when required config vars are not set. Closes #180.
diff --git a/config/software/sequel-gem.rb b/config/software/sequel-gem.rb index abc1234..def5678 100644 --- a/config/software/sequel-gem.rb +++ b/config/software/sequel-gem.rb @@ -0,0 +1,30 @@+# +# Copyright 2012-2014 Chef Software, Inc. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may ...
Add definition for sequel gem
diff --git a/argumentative.rb b/argumentative.rb index abc1234..def5678 100644 --- a/argumentative.rb +++ b/argumentative.rb @@ -41,7 +41,7 @@ private def match?(types) - @args.zip(types).all? { |arg, type| arg.is_a?(type) } + types.count == @args.count && @args.zip(types).all? { |arg, type| arg.is...
Check count before matching argument types
diff --git a/lib/acts_as_content_node/publishable.rb b/lib/acts_as_content_node/publishable.rb index abc1234..def5678 100644 --- a/lib/acts_as_content_node/publishable.rb +++ b/lib/acts_as_content_node/publishable.rb @@ -5,7 +5,7 @@ def acts_as_publishable send :include, InstanceMethods - ...
Tweak to published name scope
diff --git a/lib/chef_fs/file_system/data_bag_dir.rb b/lib/chef_fs/file_system/data_bag_dir.rb index abc1234..def5678 100644 --- a/lib/chef_fs/file_system/data_bag_dir.rb +++ b/lib/chef_fs/file_system/data_bag_dir.rb @@ -11,6 +11,15 @@ @exists = nil end + def dir? + exists? + end + + ...
Make data_bags/README.md diff instead of show "is a directory"
diff --git a/app/helpers/followers_helper.rb b/app/helpers/followers_helper.rb index abc1234..def5678 100644 --- a/app/helpers/followers_helper.rb +++ b/app/helpers/followers_helper.rb @@ -16,6 +16,6 @@ end def build_invite_mailto(section, user) - "mailto:?subject=#{Rack::Utils.escape(t('welcome_email.subject...
Use escape_path rather than escape when encoding mailto: line Utils.escape will encode space to +. Utils.escape_path encodes space to %20. While Gmail seems to handle pluses just fine, Outlook does not, and message will have spaces through subject and body. Using escape_path should fix this for Outlook. Tested on W...
diff --git a/core/range/initialize_spec.rb b/core/range/initialize_spec.rb index abc1234..def5678 100644 --- a/core/range/initialize_spec.rb +++ b/core/range/initialize_spec.rb @@ -25,4 +25,12 @@ lambda { (1..3).__send__(:initialize, 1, 3, 5, 7, 9) }. should raise_error(ArgumentError) end + + it "raises ...
Add spec for comparable with Range and no <=> method defined
diff --git a/lib/mrb/scripts/expression_rewriters.rb b/lib/mrb/scripts/expression_rewriters.rb index abc1234..def5678 100644 --- a/lib/mrb/scripts/expression_rewriters.rb +++ b/lib/mrb/scripts/expression_rewriters.rb @@ -8,7 +8,8 @@ end def classes - rewriters_table = Context.instance["rewriters"]...
Make expression rewriters table name customizable
diff --git a/lib/square/connect/connections/items.rb b/lib/square/connect/connections/items.rb index abc1234..def5678 100644 --- a/lib/square/connect/connections/items.rb +++ b/lib/square/connect/connections/items.rb @@ -32,6 +32,7 @@ end def apply_fee_to_item(item_id, fee_id) + access_token...
Make sure to set access token
diff --git a/lib/feed.rb b/lib/feed.rb index abc1234..def5678 100644 --- a/lib/feed.rb +++ b/lib/feed.rb @@ -1,10 +1,17 @@ class Feed + include Enumerable attr_accessor :feed def initialize(raw_feed) @feed = [] add(raw_feed) end + + def each(&block) + @feed.each do |tweet| + block.call(tweet) + ...
Make Feed class include Enumerable
diff --git a/lib/three_little_pigs/objects/building_materials.rb b/lib/three_little_pigs/objects/building_materials.rb index abc1234..def5678 100644 --- a/lib/three_little_pigs/objects/building_materials.rb +++ b/lib/three_little_pigs/objects/building_materials.rb @@ -14,7 +14,9 @@ end def combined_strength(...
Remove un-needed assignment from inside reduce
diff --git a/scio.rb b/scio.rb index abc1234..def5678 100644 --- a/scio.rb +++ b/scio.rb @@ -20,7 +20,7 @@ fi done - CLASSPATH=#{libexec}/"scio-repl-#{version}.jar":$CLASSPATH exec java ${java_opts[*]} ${scio_opts[*]} java com.spotify.scio.repl.ScioShell + CLASSPATH=#{libexec}/"scio-repl-#{...
Fix previous commit - remove extra
diff --git a/lib/rory.rb b/lib/rory.rb index abc1234..def5678 100644 --- a/lib/rory.rb +++ b/lib/rory.rb @@ -11,14 +11,19 @@ extend self attr_accessor :root + attr_accessor :autoload_paths + + def add_autoload_paths(paths) + @autoload_paths ||= [] + @autoload_paths += paths + end def autoload_all_f...
Add ability to autoload arbitrary paths
diff --git a/lib/seam.rb b/lib/seam.rb index abc1234..def5678 100644 --- a/lib/seam.rb +++ b/lib/seam.rb @@ -6,4 +6,11 @@ Dir[File.dirname(__FILE__) + '/seam/*.rb'].each {|file| require file } module Seam + + def self.steps_to_run + Seam::Persistence.find_something_to_do + .group_by { |x| x...
Add method that returns steps that need to be executed.
diff --git a/Library/Homebrew/formula_specialties.rb b/Library/Homebrew/formula_specialties.rb index abc1234..def5678 100644 --- a/Library/Homebrew/formula_specialties.rb +++ b/Library/Homebrew/formula_specialties.rb @@ -9,10 +9,9 @@ # See browser for an example class GithubGistFormula < ScriptFileFormula - def ini...
Implement GithubGistFormula in a more natural way
diff --git a/kramdown_monkeypatch.rb b/kramdown_monkeypatch.rb index abc1234..def5678 100644 --- a/kramdown_monkeypatch.rb +++ b/kramdown_monkeypatch.rb @@ -10,11 +10,11 @@ @base_url_as_uri ||= URI.parse(@options[:base_url]) end - def add_link(el, href, title, alt_text = nil) + def add_link(el, href, title...
Update Kramdown monkeypatch for compatibility. A recent Kramdown update has added another parameter to the add_link function that is being hijacked in the monkeypatch, so this needs to be added to the function signature and passed through.
diff --git a/spec/playlist/content_details_spec.rb b/spec/playlist/content_details_spec.rb index abc1234..def5678 100644 --- a/spec/playlist/content_details_spec.rb +++ b/spec/playlist/content_details_spec.rb @@ -9,7 +9,7 @@ specify 'return all content details data with one HTTP call' do expect(Net::HTTP).to...
Fix tests: items in test playlist have changed
diff --git a/lib/absorb/amazon_s3.rb b/lib/absorb/amazon_s3.rb index abc1234..def5678 100644 --- a/lib/absorb/amazon_s3.rb +++ b/lib/absorb/amazon_s3.rb @@ -6,6 +6,7 @@ def initialize options @options = options @bucket_name = options[:bucket_name] + setup end def setup @@ -16,14 +17,1...
Move the setup to the s3 constructor.
diff --git a/app/controllers/admin/themes_controller.rb b/app/controllers/admin/themes_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/themes_controller.rb +++ b/app/controllers/admin/themes_controller.rb @@ -11,7 +11,8 @@ def switchto - setting = Setting.find_by_name('theme') ...
Create new setting in ThemesController if a 'theme' setting doesn't already exist git-svn-id: 70ab0960c3db1cbf656efd6df54a8f3de72dc710@427 820eb932-12ee-0310-9ca8-eeb645f39767
diff --git a/app/controllers/delayed_jobs_controller.rb b/app/controllers/delayed_jobs_controller.rb index abc1234..def5678 100644 --- a/app/controllers/delayed_jobs_controller.rb +++ b/app/controllers/delayed_jobs_controller.rb @@ -8,39 +8,54 @@ @job = Delayed::Job.find(params[:id]) render :layout =>nil ...
Tweak the queries for the different classifications.
diff --git a/app/helpers/feeder/authorization_helper.rb b/app/helpers/feeder/authorization_helper.rb index abc1234..def5678 100644 --- a/app/helpers/feeder/authorization_helper.rb +++ b/app/helpers/feeder/authorization_helper.rb @@ -1,11 +1,15 @@ module Feeder module AuthorizationHelper + def can_contribute? + ...
Check whether current_user_method is even configured before doing anything else
diff --git a/lib/delayed_cron_job.rb b/lib/delayed_cron_job.rb index abc1234..def5678 100644 --- a/lib/delayed_cron_job.rb +++ b/lib/delayed_cron_job.rb @@ -10,10 +10,10 @@ if defined?(Delayed::Backend::Mongoid) Delayed::Backend::Mongoid::Job.field :cron, :type => String - Delayed::Backend::Mongoid::Job.attr_acce...
Check if class responds to method before calling it
diff --git a/lib/rbuv.rb b/lib/rbuv.rb index abc1234..def5678 100644 --- a/lib/rbuv.rb +++ b/lib/rbuv.rb @@ -7,22 +7,33 @@ module Rbuv class << self - def run_loop - Loop.default.run - end - + # Stop the default loop. + # @see Rbuv::Loop#stop + # @return [Rbuv::Loop] the {Rbuv::Loop.default} ...
Add documentation for module Rbuv
diff --git a/lib/snmp.rb b/lib/snmp.rb index abc1234..def5678 100644 --- a/lib/snmp.rb +++ b/lib/snmp.rb @@ -8,3 +8,4 @@ # require 'snmp/manager' +require 'snmp/version'
Load version module by default
diff --git a/lib/acts_as_interval/acts_as_interval.rb b/lib/acts_as_interval/acts_as_interval.rb index abc1234..def5678 100644 --- a/lib/acts_as_interval/acts_as_interval.rb +++ b/lib/acts_as_interval/acts_as_interval.rb @@ -27,8 +27,6 @@ define_method "overlapping_#{klass_name}" do self.class.where(...
Drop the alias methods, no longer needed
diff --git a/lib/ooxml_parser/common_parser/parser.rb b/lib/ooxml_parser/common_parser/parser.rb index abc1234..def5678 100644 --- a/lib/ooxml_parser/common_parser/parser.rb +++ b/lib/ooxml_parser/common_parser/parser.rb @@ -6,8 +6,8 @@ def self.parse(path_to_file) return nil if OOXMLDocumentObject.encrypted...
Remove duplicate calls of path_to_folder
diff --git a/oled-control.gemspec b/oled-control.gemspec index abc1234..def5678 100644 --- a/oled-control.gemspec +++ b/oled-control.gemspec @@ -1,10 +1,13 @@ Gem::Specification.new do |s| s.name = 'oled-control' - s.version = '0.1.0' + s.version = '0.1.1' s.date = '2016-03-10' s.summary = 'Control OLED i2c ...
Update gemspec for RubyGems release, set version to 0.1.1
diff --git a/app/models/manual_with_publish_tasks.rb b/app/models/manual_with_publish_tasks.rb index abc1234..def5678 100644 --- a/app/models/manual_with_publish_tasks.rb +++ b/app/models/manual_with_publish_tasks.rb @@ -2,9 +2,9 @@ class ManualWithPublishTasks < SimpleDelegator - def initialize(manual, attrs) + ...
Use Ruby keyword args in ManualWithPublishTasks I think that using language features instead of custom code makes this easier to understand.
diff --git a/app/serializers/api/image_serializer.rb b/app/serializers/api/image_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/api/image_serializer.rb +++ b/app/serializers/api/image_serializer.rb @@ -1,8 +1,16 @@ class Api::ImageSerializer < ActiveModel::Serializer - attributes :id, :alt, :small_u...
Update ImageSerializer with missing image size urls: mini/thumb_url, product/image_url that is used in the product image modal
diff --git a/omnibus_overrides.rb b/omnibus_overrides.rb index abc1234..def5678 100644 --- a/omnibus_overrides.rb +++ b/omnibus_overrides.rb @@ -19,4 +19,4 @@ override "xproto", version: "7.0.28" override "zlib", version: "1.2.11" override "libzmq", version: "4.0.5" -override "openssl", version: "1.0.2j" +override "o...
Use OpenSSL 1.1.0f for new crypto functionality There's a nice list of new functionality in the 1.1 release. https://www.openssl.org/news/openssl-1.1.0-notes.html Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/spec/beso/job_spec.rb b/spec/beso/job_spec.rb index abc1234..def5678 100644 --- a/spec/beso/job_spec.rb +++ b/spec/beso/job_spec.rb @@ -12,11 +12,13 @@ describe 'to_csv' do subject { Beso::Job.new :message_sent, :table => :users } - let!( :user ){ User.create :name => 'Foo Bar' } + let!( :fo...
Add another record to the csv example
diff --git a/spec/whiteout_spec.rb b/spec/whiteout_spec.rb index abc1234..def5678 100644 --- a/spec/whiteout_spec.rb +++ b/spec/whiteout_spec.rb @@ -9,8 +9,13 @@ Whiteout.clean("bar\t\t\n").should eql("bar\n") end - it "leaves non-trailing whitespace in tact" do + it "leaves non-trailing whitespace intact" d...
Add key test we're failing
diff --git a/spec/requests/pages/servicedown_spec.rb b/spec/requests/pages/servicedown_spec.rb index abc1234..def5678 100644 --- a/spec/requests/pages/servicedown_spec.rb +++ b/spec/requests/pages/servicedown_spec.rb @@ -0,0 +1,85 @@+require 'rails_helper' + +RSpec.describe 'Servicedown mode', type: :request do + befo...
Add request spec for servicedown note: must reset/reload routes in non-maintenance mode after each/all specs