diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/app/overrides/add_recipient_list_to_products_show.rb b/app/overrides/add_recipient_list_to_products_show.rb index abc1234..def5678 100644 --- a/app/overrides/add_recipient_list_to_products_show.rb +++ b/app/overrides/add_recipient_list_to_products_show.rb @@ -0,0 +1,37 @@+Deface::Override.new(:virtual_path...
Add recipients to product view
diff --git a/app/serializers/gobierto_people/person_serializer.rb b/app/serializers/gobierto_people/person_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/gobierto_people/person_serializer.rb +++ b/app/serializers/gobierto_people/person_serializer.rb @@ -8,9 +8,10 @@ :name, :email, ...
Change person serializer to provide position data with filtered charges
diff --git a/rspec_testing.rb b/rspec_testing.rb index abc1234..def5678 100644 --- a/rspec_testing.rb +++ b/rspec_testing.rb @@ -13,7 +13,7 @@ status = 1 end conn = TCPSocket.new '127.0.0.1', 3030 - conn.puts %({"handlers": ["default"], "name": "#{test_name}", "output": "#{output}", "status": #{status} }) + ...
Convert output string to JSON
diff --git a/db/migrate/20171010145123_remove_business_support_editions_and_support_objects.rb b/db/migrate/20171010145123_remove_business_support_editions_and_support_objects.rb index abc1234..def5678 100644 --- a/db/migrate/20171010145123_remove_business_support_editions_and_support_objects.rb +++ b/db/migrate/201710...
Remove all business support editions and supporting objects We leave their artefacts as we'll use these later to make sure they're properly turned into publishing-api redirects, but we don't need the editions or other things to do this.
diff --git a/Typhoon.podspec b/Typhoon.podspec index abc1234..def5678 100644 --- a/Typhoon.podspec +++ b/Typhoon.podspec @@ -6,11 +6,16 @@ spec.homepage = 'http://www.typhoonframework.org' spec.author = { 'Jasper Blues, Robert Gilliam & Contributors' => 'jasper@appsquick.ly' } spec.source ...
Add deployment targets to podspec.
diff --git a/lib/generators/authkit/templates/app/controllers/email_confirmation_controller.rb b/lib/generators/authkit/templates/app/controllers/email_confirmation_controller.rb index abc1234..def5678 100644 --- a/lib/generators/authkit/templates/app/controllers/email_confirmation_controller.rb +++ b/lib/generators/au...
Make sure there is an expected confirmation
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -1,7 +1,7 @@ name 'iis' maintainer 'Chef Software, Inc.' maintainer_email 'cookbooks@chef.io' -license 'Apache 2.0' +license 'Apache-2.0' description 'Installs/Configures Microsoft Internet Information Service...
Fix compatibility with older Chef 12 clients Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -10,7 +10,7 @@ supports 'centos', '>= 6.0' supports 'redhat', '>= 6.0' supports 'debian', '~> 7.0' -supports 'ubuntu', '>= 12.04' +supports 'ubuntu', '>= 14.04' supports 'windows' source_url 'https://github...
Drop support for Ubuntu 12.04
diff --git a/spec/models/appendable/reaction_spec.rb b/spec/models/appendable/reaction_spec.rb index abc1234..def5678 100644 --- a/spec/models/appendable/reaction_spec.rb +++ b/spec/models/appendable/reaction_spec.rb @@ -0,0 +1,61 @@+# frozen_string_literal: true + +require "rails_helper" + +describe Appendable::Reacti...
Add model tests for `Appendable::Reaction`
diff --git a/rspec_hue.gemspec b/rspec_hue.gemspec index abc1234..def5678 100644 --- a/rspec_hue.gemspec +++ b/rspec_hue.gemspec @@ -3,7 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) Gem::Specification.new do |spec| - spec.name = "rspec_hue" + spec.name = "rspec-hue" spec.ver...
Rename to rspec-hue, RSpec likes this better for some reason.
diff --git a/brakeman.gemspec b/brakeman.gemspec index abc1234..def5678 100644 --- a/brakeman.gemspec +++ b/brakeman.gemspec @@ -9,7 +9,7 @@ s.homepage = "http://brakemanscanner.org" s.files = ["bin/brakeman", "WARNING_TYPES", "FEATURES", "README.md"] + Dir["lib/**/*.rb"] + Dir["lib/brakeman/format/*.css"] s.ex...
Remove veresion restriction on activesupport
diff --git a/spec/controllers/grades_controller_spec.rb b/spec/controllers/grades_controller_spec.rb index abc1234..def5678 100644 --- a/spec/controllers/grades_controller_spec.rb +++ b/spec/controllers/grades_controller_spec.rb @@ -1,6 +1,11 @@ require 'rails_helper' describe GradesController do + let(:teacher) { ...
Update grades controller test to account for timezone.
diff --git a/brochure.gemspec b/brochure.gemspec index abc1234..def5678 100644 --- a/brochure.gemspec +++ b/brochure.gemspec @@ -14,7 +14,7 @@ s.add_dependency "rack", "~> 1.0" s.add_dependency "tilt", "~> 1.1" + s.add_development_dependency "rake" s.add_development_dependency "rack-test" s.add_developmen...
Add rake as a dev dep
diff --git a/spec/models/forum_add_forum_wizard_spec.rb b/spec/models/forum_add_forum_wizard_spec.rb index abc1234..def5678 100644 --- a/spec/models/forum_add_forum_wizard_spec.rb +++ b/spec/models/forum_add_forum_wizard_spec.rb @@ -0,0 +1,30 @@+require File.expand_path(File.dirname(__FILE__)) + "/../../../../../spec/...
Add tests for forum wizard
diff --git a/spec/presenters/document_presenter_spec.rb b/spec/presenters/document_presenter_spec.rb index abc1234..def5678 100644 --- a/spec/presenters/document_presenter_spec.rb +++ b/spec/presenters/document_presenter_spec.rb @@ -0,0 +1,94 @@+require 'ostruct' +require 'spec_helper' + +describe DocumentPresenter do ...
Add spec for document presenter Only testing the #metadata and #document_metadata methods here because everything else is boring.
diff --git a/spec/sitemap_generator/interpreter_spec.rb b/spec/sitemap_generator/interpreter_spec.rb index abc1234..def5678 100644 --- a/spec/sitemap_generator/interpreter_spec.rb +++ b/spec/sitemap_generator/interpreter_spec.rb @@ -5,7 +5,7 @@ # The interpreter doesn't have the URL helpers included for some reason, ...
Use the reset! method in the interpreter spec
diff --git a/spec/views/catalog/_form.html.haml_spec.rb b/spec/views/catalog/_form.html.haml_spec.rb index abc1234..def5678 100644 --- a/spec/views/catalog/_form.html.haml_spec.rb +++ b/spec/views/catalog/_form.html.haml_spec.rb @@ -1,9 +1,16 @@+include Spec::Support::AutomationHelper + describe "catalog/_form.html.ha...
Correct specs that PR broke
diff --git a/or-tools.rb b/or-tools.rb index abc1234..def5678 100644 --- a/or-tools.rb +++ b/or-tools.rb @@ -6,8 +6,9 @@ homepage "https://developers.google.com/optimization/" head 'https://github.com/google/or-tools.git' - url "https://github.com/google/or-tools/archive/v6.7.1.tar.gz" - sha256 "c82c63a6c2b091...
Use git tag/revision instead of tarball
diff --git a/Casks/realm-browser.rb b/Casks/realm-browser.rb index abc1234..def5678 100644 --- a/Casks/realm-browser.rb +++ b/Casks/realm-browser.rb @@ -1,10 +1,10 @@ cask 'realm-browser' do - version '0.98.6' - sha256 'a2d7be0985433239640416cb098db0f0812766bbeec3b6113e9a8557f1fc66f7' + version '0.101.0' + sha256 '...
Update Realm Browser to 0.101.0
diff --git a/ost.gemspec b/ost.gemspec index abc1234..def5678 100644 --- a/ost.gemspec +++ b/ost.gemspec @@ -8,14 +8,7 @@ s.homepage = "http://github.com/soveran/ost" s.license = "MIT" - s.files = Dir[ - "LICENSE", - "README.md", - "Rakefile", - "lib/**/*.rb", - "*.gemspec", - ...
Use git to list required files.
diff --git a/shared_mustache.gemspec b/shared_mustache.gemspec index abc1234..def5678 100644 --- a/shared_mustache.gemspec +++ b/shared_mustache.gemspec @@ -13,7 +13,7 @@ gem.homepage = "" gem.add_dependency 'mustache', '~> 0.99.4' - gem.add_dependency 'execjs', '~> 1.2.4' + gem.add_dependency 'execjs', '...
Allow newer versions of execjs
diff --git a/lib/jekyll/minibundle/mini_bundle_block.rb b/lib/jekyll/minibundle/mini_bundle_block.rb index abc1234..def5678 100644 --- a/lib/jekyll/minibundle/mini_bundle_block.rb +++ b/lib/jekyll/minibundle/mini_bundle_block.rb @@ -24,7 +24,7 @@ file.markup end - def default_config + def self.defaul...
Define default config as a class instance method
diff --git a/examples/intersect-line.rb b/examples/intersect-line.rb index abc1234..def5678 100644 --- a/examples/intersect-line.rb +++ b/examples/intersect-line.rb @@ -4,16 +4,17 @@ # 交線 発生サンプル # -tor = Prim::torus [], Vec::zdir, 30, 10, Math::PI * 2 -pln = Build::infplane [], [0.5, 0.3, 0.8].to_v.normal -int_...
Fix the name of variable.
diff --git a/sorting/merge.rb b/sorting/merge.rb index abc1234..def5678 100644 --- a/sorting/merge.rb +++ b/sorting/merge.rb @@ -0,0 +1,60 @@+require './merging/binary' +module Sorting + # @abstract a Service that executes a MergeSort on any given list. Each item + # in the list must be comparable, ie. It must resp...
Change module / class naming and add documentation
diff --git a/sr71.gemspec b/sr71.gemspec index abc1234..def5678 100644 --- a/sr71.gemspec +++ b/sr71.gemspec @@ -22,4 +22,5 @@ s.add_dependency "em-http-request", "~> 1.0" s.add_development_dependency "rspec", "~> 2.11.0" + s.add_development_dependency "rake", "~> 10.3" end
Add missing dev dependency on Rake
diff --git a/spec/models/spree/order_spec.rb b/spec/models/spree/order_spec.rb index abc1234..def5678 100644 --- a/spec/models/spree/order_spec.rb +++ b/spec/models/spree/order_spec.rb @@ -3,16 +3,35 @@ describe Spree::Order do describe '#update' do context 'when a order is completed products are relates as alg...
Modify and add test to avoid duplicate also bought data
diff --git a/spec/squarespace/client_spec.rb b/spec/squarespace/client_spec.rb index abc1234..def5678 100644 --- a/spec/squarespace/client_spec.rb +++ b/spec/squarespace/client_spec.rb @@ -2,4 +2,13 @@ describe Squarespace::Client do + test_configuration + + let(:client) { Squarespace::Client.new } + + context '...
Test for commerce api url
diff --git a/src/block.rb b/src/block.rb index abc1234..def5678 100644 --- a/src/block.rb +++ b/src/block.rb @@ -22,6 +22,9 @@ when 'right' @x += 20; end + + @x %= 640 + @y %= 480 end def draw
Add window bounders and behavior.
diff --git a/db/migrate/20170106122600_set_document_id_on_content_items.rb b/db/migrate/20170106122600_set_document_id_on_content_items.rb index abc1234..def5678 100644 --- a/db/migrate/20170106122600_set_document_id_on_content_items.rb +++ b/db/migrate/20170106122600_set_document_id_on_content_items.rb @@ -1,4 +1,6 @@...
Set document ids outside of a transaction Since these can be safely re-attempted if this migration fails we'll run this outside of a transaction and lesser the risk of deadlocks.
diff --git a/solid_assert.gemspec b/solid_assert.gemspec index abc1234..def5678 100644 --- a/solid_assert.gemspec +++ b/solid_assert.gemspec @@ -15,7 +15,7 @@ spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } spec.require_paths = ["lib"] - spec.required_ruby_...
Change required Ruby version to >= 2.3
diff --git a/Casks/font-menlo-powerline.rb b/Casks/font-menlo-powerline.rb index abc1234..def5678 100644 --- a/Casks/font-menlo-powerline.rb +++ b/Casks/font-menlo-powerline.rb @@ -0,0 +1,7 @@+class FontMenloPowerline < Cask + url 'https://gist.github.com/raw/1627888/c4e92f81f7956d4ceaee11b5a7b4c445f786dd90/Menlo-ForP...
Add deps to install Powerline patched Menlo font
diff --git a/spec/kenny_g_spec.rb b/spec/kenny_g_spec.rb index abc1234..def5678 100644 --- a/spec/kenny_g_spec.rb +++ b/spec/kenny_g_spec.rb @@ -1,33 +1,14 @@ require 'spec_helper' require 'kenny_g' -require 'kenny_g/errors' require 'kenny_g/game_setup' -require 'kenny_g/player' describe KennyG do let(:params) ...
Modify spec to test only what the method does, and not reach through service object
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index abc1234..def5678 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -2,7 +2,7 @@ ENV['RAILS_ENV'] ||= 'test' -require File.expand_path('../../config/environment', __FILE__) +require File.expand_path('../dummy/config/environment.rb', __FILE_...
Fix rspec dummy app config path
diff --git a/spree_slider.gemspec b/spree_slider.gemspec index abc1234..def5678 100644 --- a/spree_slider.gemspec +++ b/spree_slider.gemspec @@ -2,7 +2,7 @@ Gem::Specification.new do |s| s.platform = Gem::Platform::RUBY s.name = 'spree_slider' - s.version = '1.2.0' + s.version = '3.1.0' s.s...
Bump version and spree dependencies
diff --git a/textalyze.rb b/textalyze.rb index abc1234..def5678 100644 --- a/textalyze.rb +++ b/textalyze.rb @@ -8,6 +8,12 @@ counts end +def format_counts(counts) + counts.map do |item, count| + "#{item} - #{count}" + end.join("\n") +end + if ARGV[0] == "test" p item_counts([1,2,1,2,1]) == {1 => 3, 2 => ...
Print item counts with nice formatting; completes v0.1 format_counts() takes a hash of item/count pairs and returns a pleasantly-formatted string for printing.
diff --git a/Casks/yed.rb b/Casks/yed.rb index abc1234..def5678 100644 --- a/Casks/yed.rb +++ b/Casks/yed.rb @@ -1,6 +1,6 @@ cask :v1 => 'yed' do - version '3.14.1' - sha256 '1db07a4e108c13ed4e28ebec30d6acf4fe7b593a78ceeeed3e5a1c9d1132c512' + version '3.14.2' + sha256 '8d15d7bcc04ec5ab15f11934158ce97179642ba45a87b0...
Update cask yEd to latest version 3.14.2
diff --git a/railties/test/application/load_test.rb b/railties/test/application/load_test.rb index abc1234..def5678 100644 --- a/railties/test/application/load_test.rb +++ b/railties/test/application/load_test.rb @@ -43,6 +43,13 @@ assert Rails.application.new.is_a?(Rails::Application) end + # Passenger...
Put test in place for deprecated dispatcher
diff --git a/recipes/desktop_backgrounds_in_dropbox.rb b/recipes/desktop_backgrounds_in_dropbox.rb index abc1234..def5678 100644 --- a/recipes/desktop_backgrounds_in_dropbox.rb +++ b/recipes/desktop_backgrounds_in_dropbox.rb @@ -0,0 +1,53 @@+ruby_block "Dropbox Backgrounds" do + block do + require 'plist' + + de...
Move over Dropbox for rotated desktop images
diff --git a/Casks/intellij-idea-ce-eap.rb b/Casks/intellij-idea-ce-eap.rb index abc1234..def5678 100644 --- a/Casks/intellij-idea-ce-eap.rb +++ b/Casks/intellij-idea-ce-eap.rb @@ -1,10 +1,19 @@ cask :v1 => 'intellij-idea-ce-eap' do - version '141.1192.2' - sha256 '18f8ecfa66e2e687cab6ddd844bde8996ecb54eb93279a8e8ce5...
Update IntelliJ IDEA CE to EAP 15; version 142.2491.4.
diff --git a/lib/activeadmin_addons/support/input_helpers/input_methods.rb b/lib/activeadmin_addons/support/input_helpers/input_methods.rb index abc1234..def5678 100644 --- a/lib/activeadmin_addons/support/input_helpers/input_methods.rb +++ b/lib/activeadmin_addons/support/input_helpers/input_methods.rb @@ -10,7 +10,6 ...
FIX for models without associations.
diff --git a/spec/oga/oga_spec.rb b/spec/oga/oga_spec.rb index abc1234..def5678 100644 --- a/spec/oga/oga_spec.rb +++ b/spec/oga/oga_spec.rb @@ -33,7 +33,7 @@ end it 'parses an HTML document using the SAX parser' do - Oga.sax_parse_xml(@handler, '<link>') + Oga.sax_parse_html(@handler, '<link>') ...
Use sax_parse_html for HTML documents. I suspect the only reason this test ever passed due to Racc's error handling. Either way this was using the wrong method.
diff --git a/spec/url_for_spec.rb b/spec/url_for_spec.rb index abc1234..def5678 100644 --- a/spec/url_for_spec.rb +++ b/spec/url_for_spec.rb @@ -1,7 +1,7 @@ require 'spec_helper' require 'sinatra' -require 'sinatra/test' require 'sinatra/url_for' +require 'rack/test' get "/" do content_type "text/plain" @@ -13,...
Fix spec so it runs in today's Sinatra
diff --git a/attributes/default.rb b/attributes/default.rb index abc1234..def5678 100644 --- a/attributes/default.rb +++ b/attributes/default.rb @@ -6,6 +6,7 @@ default['rvm']['default_ruby'] = 'ruby-1.9.3' default['rvm']['user_installs'] = [ { 'user' => 'jenkins', + 'home' => '/var/lib/jenkins', ...
Add explicit definition of homedir for jenkins
diff --git a/spec/cache/gems_spec.rb b/spec/cache/gems_spec.rb index abc1234..def5678 100644 --- a/spec/cache/gems_spec.rb +++ b/spec/cache/gems_spec.rb @@ -18,6 +18,21 @@ it "uses the cache as a source when installing gems" do system_gems [] bundle :install + + should_be_installed("rack 1.0.0") ...
Make sure that gems are not reinstalled if they are packed and already on the system.
diff --git a/spec/factories/users.rb b/spec/factories/users.rb index abc1234..def5678 100644 --- a/spec/factories/users.rb +++ b/spec/factories/users.rb @@ -7,7 +7,7 @@ last_name "My Last Name" username 'user' password 'my password' - email 'email@email.eml' + email 'email@domain.eml' practice_...
Change for testing TeamCity auto build after check-in
diff --git a/spec/support/profile.rb b/spec/support/profile.rb index abc1234..def5678 100644 --- a/spec/support/profile.rb +++ b/spec/support/profile.rb @@ -0,0 +1,7 @@+# Frozen-string-literal: true +# Copyright: 2015 Jordon Bedwell - MIT License +# Encoding: utf-8 + +RSpec.configure do |c| + c.profile_examples = true...
Add some profiling so we can spot slow code and specs.
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -5,9 +5,11 @@ # Search match 'search', to: 'pages#search', via: [:get], defaults: { format: :json }, constraints: { format: :json } + match 'search', to: 'annotations#options', via: [:...
Create options responses for other endpoints
diff --git a/venn.gemspec b/venn.gemspec index abc1234..def5678 100644 --- a/venn.gemspec +++ b/venn.gemspec @@ -8,8 +8,8 @@ spec.version = Venn::VERSION spec.authors = ["Darren Cauthon"] spec.email = ["darren@cauthon.com"] - spec.description = %q{TODO: Write a gem description} - spec.su...
Add a description to the gemspec.
diff --git a/spec/adapter_spec.rb b/spec/adapter_spec.rb index abc1234..def5678 100644 --- a/spec/adapter_spec.rb +++ b/spec/adapter_spec.rb @@ -37,7 +37,7 @@ end context 'when response non standard' do - let(:url) { 'http://www.google.com' } + let(:url) { 'https://httpstat.us/418' } let(:adapter_re...
Update spec to not rely on google giving a specific response
diff --git a/spec/api/api_spec.rb b/spec/api/api_spec.rb index abc1234..def5678 100644 --- a/spec/api/api_spec.rb +++ b/spec/api/api_spec.rb @@ -10,14 +10,9 @@ Sinatra::Application end -RSpec.configure do |config| - config.treat_symbols_as_metadata_keys_with_true_values = true - config.run_all_when_everything_...
Include rack test methods in describe block instead of reconfiguring rspec.
diff --git a/spec/payload_spec.rb b/spec/payload_spec.rb index abc1234..def5678 100644 --- a/spec/payload_spec.rb +++ b/spec/payload_spec.rb @@ -4,27 +4,27 @@ describe '.parse' do it 'returns payload instance for github' do payload = Magnum::Payload.parse('github', fixture('github.json')) - payload.s...
Refactor payload class specs to use new matchers
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index abc1234..def5678 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -21,6 +21,13 @@ PaperTrail.whodunnit = 'Test User' end + config.around(:each, type: :feature) do |example| + original_adapter = ActiveJob::Base.queue_adapter + ...
Use inline adapter for feature specs
diff --git a/test/fixtures/policies/default.rb b/test/fixtures/policies/default.rb index abc1234..def5678 100644 --- a/test/fixtures/policies/default.rb +++ b/test/fixtures/policies/default.rb @@ -1,9 +1,12 @@ name 'default' -default_source :community +default_source :supermarket default_source :chef_repo, '..' cookb...
Enable passwordless sudo for test user on RHEL/CentOS
diff --git a/config/initializers/initialize_viking.rb b/config/initializers/initialize_viking.rb index abc1234..def5678 100644 --- a/config/initializers/initialize_viking.rb +++ b/config/initializers/initialize_viking.rb @@ -1,3 +1,8 @@+# Sometimes Viking isn't loaded at this point, so we make sure it is here +unless O...
Fix a problem where Viking wasn't always loaded when the initializer was running
diff --git a/spec/workers/mark_vector_from_text_spec.rb b/spec/workers/mark_vector_from_text_spec.rb index abc1234..def5678 100644 --- a/spec/workers/mark_vector_from_text_spec.rb +++ b/spec/workers/mark_vector_from_text_spec.rb @@ -5,11 +5,6 @@ let(:product) { Product.make! } describe '#perform' do - it 'tes...
Fix failing test for good No idea why Travis barfed on this
diff --git a/bin/dependencytree.rb b/bin/dependencytree.rb index abc1234..def5678 100644 --- a/bin/dependencytree.rb +++ b/bin/dependencytree.rb @@ -0,0 +1,42 @@+require 'pp' +require_relative 'docparser' + +$classes = parse_any_path 'src' + +def prefix lines + if lines.empty? + '' + else + lines.gsub(/^/, '- ') + en...
Add a script to print the dependency tree of everything The usefullness of this is limited, since it only takes into account the documented inheritance and mixins, but not currently undocumented composition (e.g. DropdownInputWidget using DropdownWidget). Change-Id: I1f002ba37cb6abd388622638eeccc5aaf9a782a4
diff --git a/lib/treetop/compiler/node_classes/character_class.rb b/lib/treetop/compiler/node_classes/character_class.rb index abc1234..def5678 100644 --- a/lib/treetop/compiler/node_classes/character_class.rb +++ b/lib/treetop/compiler/node_classes/character_class.rb @@ -4,7 +4,7 @@ def compile(address, builder,...
Use \G to force Regexps to match only at the first position
diff --git a/spec/features/cdx/admin/login_spec.rb b/spec/features/cdx/admin/login_spec.rb index abc1234..def5678 100644 --- a/spec/features/cdx/admin/login_spec.rb +++ b/spec/features/cdx/admin/login_spec.rb @@ -0,0 +1,26 @@+require 'rails_helper' + +RSpec.feature 'Login to admin dashboard', type: :feature do + + let...
Add first feature spec as demo
diff --git a/spec/features/emo_states_list_spec.rb b/spec/features/emo_states_list_spec.rb index abc1234..def5678 100644 --- a/spec/features/emo_states_list_spec.rb +++ b/spec/features/emo_states_list_spec.rb @@ -19,4 +19,14 @@ expect(current_path).to eq(emo_states_path) end + it "user can see his emoti...
Add test for user being able to see submitted emotion in the index page
diff --git a/spec/lib/course_alert_manager_spec.rb b/spec/lib/course_alert_manager_spec.rb index abc1234..def5678 100644 --- a/spec/lib/course_alert_manager_spec.rb +++ b/spec/lib/course_alert_manager_spec.rb @@ -7,7 +7,7 @@ describe CourseAlertManager do describe '#create_no_students_alerts' do - let(:course) ...
Tweak spec that failed on travis
diff --git a/spec/services/map_marker_json_spec.rb b/spec/services/map_marker_json_spec.rb index abc1234..def5678 100644 --- a/spec/services/map_marker_json_spec.rb +++ b/spec/services/map_marker_json_spec.rb @@ -1,10 +1,11 @@ require 'rails_helper' describe MapMarkerJson do - let(:organisation) { double(:organisat...
Change map_marker_json spec to use a relation of organisations
diff --git a/spec/nz_mps_popolo/extractor_spec.rb b/spec/nz_mps_popolo/extractor_spec.rb index abc1234..def5678 100644 --- a/spec/nz_mps_popolo/extractor_spec.rb +++ b/spec/nz_mps_popolo/extractor_spec.rb @@ -1,7 +1,37 @@ require 'spec_helper' +require 'support/mps' +require 'support/null_logger' describe NZMPsPopol...
Test Extractor parses without Capybara element not found exceptions
diff --git a/spec/retryable/configuration_spec.rb b/spec/retryable/configuration_spec.rb index abc1234..def5678 100644 --- a/spec/retryable/configuration_spec.rb +++ b/spec/retryable/configuration_spec.rb @@ -21,6 +21,22 @@ end end + context 'when configured locally' do + it 'does not affect the original g...
Add regression spec for configuration
diff --git a/app/controllers/contacts_controller.rb b/app/controllers/contacts_controller.rb index abc1234..def5678 100644 --- a/app/controllers/contacts_controller.rb +++ b/app/controllers/contacts_controller.rb @@ -1,4 +1,5 @@ class ContactsController < ApplicationController + before_filter :authenticate_user! ...
Add devise method to restrict Contact form to authenticated users
diff --git a/test/cookbooks/setup/recipes/default.rb b/test/cookbooks/setup/recipes/default.rb index abc1234..def5678 100644 --- a/test/cookbooks/setup/recipes/default.rb +++ b/test/cookbooks/setup/recipes/default.rb @@ -2,7 +2,7 @@ # Cookbook Name:: setup # Recipe:: default # -# Copyright 2014-2019, Threat Stack +# ...
Update copyright year and added 'rhel' to the conditional to not run `apt update`
diff --git a/spec/features/admin/newsletters_spec.rb b/spec/features/admin/newsletters_spec.rb index abc1234..def5678 100644 --- a/spec/features/admin/newsletters_spec.rb +++ b/spec/features/admin/newsletters_spec.rb @@ -6,6 +6,8 @@ background do @admin = create(:administrator) + @newsletter_user = create(:...
Add expectations for newsletter users and non-newsletter users on email zip download scenario
diff --git a/spec/features/open_welcome_page_spec.rb b/spec/features/open_welcome_page_spec.rb index abc1234..def5678 100644 --- a/spec/features/open_welcome_page_spec.rb +++ b/spec/features/open_welcome_page_spec.rb @@ -0,0 +1,17 @@+require 'rails_helper' + +describe 'Open the welcome page' do + + it 'should open the...
Test with Capybara created to test welcome page
diff --git a/spec/support/matchers/table_matchers.rb b/spec/support/matchers/table_matchers.rb index abc1234..def5678 100644 --- a/spec/support/matchers/table_matchers.rb +++ b/spec/support/matchers/table_matchers.rb @@ -19,6 +19,15 @@ end end + failure_message_for_should do |text| + "expected to find tabl...
Reorder helper method at bottom
diff --git a/spec/sessions/sessions_controller_spec.rb b/spec/sessions/sessions_controller_spec.rb index abc1234..def5678 100644 --- a/spec/sessions/sessions_controller_spec.rb +++ b/spec/sessions/sessions_controller_spec.rb @@ -0,0 +1,11 @@+require 'rails_helper' + +RSpec.describe SessionsController, :type => :control...
Write basic test for sessions controller Basic 'true == true' test in spec/sessions/sessions_controller_spec.rb just proving that all gems and required files are set up correctly.
diff --git a/app/helpers/admin/activities_helper.rb b/app/helpers/admin/activities_helper.rb index abc1234..def5678 100644 --- a/app/helpers/admin/activities_helper.rb +++ b/app/helpers/admin/activities_helper.rb @@ -1,6 +1,6 @@ module Admin::ActivitiesHelper def admin_review_paper_link(activity) - label = "Revie...
Fix navigation bar broken when no activity
diff --git a/app/helpers/admin/activities_helper.rb b/app/helpers/admin/activities_helper.rb index abc1234..def5678 100644 --- a/app/helpers/admin/activities_helper.rb +++ b/app/helpers/admin/activities_helper.rb @@ -1,5 +1,6 @@ module Admin::ActivitiesHelper def admin_review_paper_link(activity) + return 0 if ac...
Fix nil activity case unreviewed count broken
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index abc1234..def5678 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -8,9 +8,9 @@ def create @comment = Comment.new(comment_params) - @comment.user_id = current_...
Include id on redirect after comment is posted
diff --git a/app/jobs/promo/email_breakdowns_job.rb b/app/jobs/promo/email_breakdowns_job.rb index abc1234..def5678 100644 --- a/app/jobs/promo/email_breakdowns_job.rb +++ b/app/jobs/promo/email_breakdowns_job.rb @@ -14,6 +14,7 @@ ).perform) new_csv = [] csv.each do |row| + row.delete_at(5) # delete ...
Disable confirmation column in the CSV. We'll re-add once we get the proper data and if it clears security
diff --git a/lib/super_settings/calculate.rb b/lib/super_settings/calculate.rb index abc1234..def5678 100644 --- a/lib/super_settings/calculate.rb +++ b/lib/super_settings/calculate.rb @@ -1,4 +1,7 @@ module SuperSettings + # The Calculate class allows a user to define operators. + # These registrators are registered...
Add description to the Calculate class
diff --git a/app/controllers/sessions_controller.rb b/app/controllers/sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/sessions_controller.rb +++ b/app/controllers/sessions_controller.rb @@ -40,6 +40,7 @@ # If we use some DB in the future, change this to store token with expire limit...
Fix can't login if password changed
diff --git a/app/controllers/students_controller.rb b/app/controllers/students_controller.rb index abc1234..def5678 100644 --- a/app/controllers/students_controller.rb +++ b/app/controllers/students_controller.rb @@ -1,7 +1,13 @@ class StudentsController < ApplicationController before_filter :authenticate_user! + #...
Add action to show user profile page
diff --git a/rakefile.rb b/rakefile.rb index abc1234..def5678 100644 --- a/rakefile.rb +++ b/rakefile.rb @@ -13,7 +13,7 @@ desc 'Test the validates_email_format_of plugin.' Rake::TestTask.new(:test) do |t| t.libs << 'lib' - t.pattern = 'test/**/*_test.rb' + t.pattern = FileList['test/**/*_test.rb'] t.verbose =...
Use FileList in TestTask for Ruby 1.9.3
diff --git a/randname.rb b/randname.rb index abc1234..def5678 100644 --- a/randname.rb +++ b/randname.rb @@ -25,4 +25,4 @@ # combine with random number number = SecureRandom.random_number(1000) # return name -puts "#{adjectives[a]}-#{nouns[n]}-#{number}" +puts "#{adjectives[a]}#{nouns[n]}#{number}"
Remove - in random names as cloudControl does not allow it
diff --git a/app/helpers/umlaut/html_head_helper.rb b/app/helpers/umlaut/html_head_helper.rb index abc1234..def5678 100644 --- a/app/helpers/umlaut/html_head_helper.rb +++ b/app/helpers/umlaut/html_head_helper.rb @@ -14,8 +14,8 @@ # if requested by presence of @meta_refresh_self ivar. # this method usually called ...
Clean up whitespace in helpers.
diff --git a/app/models/hackbot/interactions/stats.rb b/app/models/hackbot/interactions/stats.rb index abc1234..def5678 100644 --- a/app/models/hackbot/interactions/stats.rb +++ b/app/models/hackbot/interactions/stats.rb @@ -1,10 +1,7 @@ module Hackbot module Interactions - class Stats < Hackbot::Interactions::Ch...
Convert Hackbot::Interactions::Stats to a Command
diff --git a/app/serializers/district_serializer.rb b/app/serializers/district_serializer.rb index abc1234..def5678 100644 --- a/app/serializers/district_serializer.rb +++ b/app/serializers/district_serializer.rb @@ -1,7 +1,5 @@ class DistrictSerializer < ActiveModel::Serializer - attributes :name, :region, :vpc_id, :...
Remove unused district serializer params
diff --git a/app/concepts/payload/operation.rb b/app/concepts/payload/operation.rb index abc1234..def5678 100644 --- a/app/concepts/payload/operation.rb +++ b/app/concepts/payload/operation.rb @@ -10,6 +10,7 @@ def update_status status = success? ? 'success' : 'failure' + Rails.logger.info("repo=#{rep...
Add some logging to help debug issues
diff --git a/db/migrate/20190212154510_change_legal_document_variable_id_to_bigint.rb b/db/migrate/20190212154510_change_legal_document_variable_id_to_bigint.rb index abc1234..def5678 100644 --- a/db/migrate/20190212154510_change_legal_document_variable_id_to_bigint.rb +++ b/db/migrate/20190212154510_change_legal_docum...
Update legal_document_variable_id foreign key to bigint
diff --git a/Library/Formula/percona-toolkit.rb b/Library/Formula/percona-toolkit.rb index abc1234..def5678 100644 --- a/Library/Formula/percona-toolkit.rb +++ b/Library/Formula/percona-toolkit.rb @@ -3,7 +3,7 @@ class PerconaToolkit < Formula homepage 'http://www.percona.com/software/percona-toolkit/' url 'http:...
percona: Use SHA1 instead of MD5 Signed-off-by: Adam Vandenberg <34c2b6407fd5a10249a15d699d40f9ed1782e98c@gmail.com>
diff --git a/Library/Homebrew/tap_migrations.rb b/Library/Homebrew/tap_migrations.rb index abc1234..def5678 100644 --- a/Library/Homebrew/tap_migrations.rb +++ b/Library/Homebrew/tap_migrations.rb @@ -4,4 +4,5 @@ 'denyhosts' => 'homebrew/boneyard', 'ipopt' => 'homebrew/science', 'qfits' => 'homebrew/boneyard', ...
Move blackbox to the boneyard Closes Homebrew/homebrew#24370.
diff --git a/app/helpers/restaurants_helper.rb b/app/helpers/restaurants_helper.rb index abc1234..def5678 100644 --- a/app/helpers/restaurants_helper.rb +++ b/app/helpers/restaurants_helper.rb @@ -33,16 +33,16 @@ def parse_restaurant_info(restaurants_json) restaurants = restaurants_json['businesses'].map do | re...
Change hash symbols to strings in parsed json
diff --git a/SwiftyUserDefaults.podspec b/SwiftyUserDefaults.podspec index abc1234..def5678 100644 --- a/SwiftyUserDefaults.podspec +++ b/SwiftyUserDefaults.podspec @@ -1,8 +1,8 @@ Pod::Spec.new do |s| s.name = 'SwiftyUserDefaults' - s.version = '5.0.0-beta.5' + s.version = '5.0.0' s.license = 'MIT' - s.summar...
Update Podspec for version 5.0.0
diff --git a/app/views/courses/_block.json.jbuilder b/app/views/courses/_block.json.jbuilder index abc1234..def5678 100644 --- a/app/views/courses/_block.json.jbuilder +++ b/app/views/courses/_block.json.jbuilder @@ -16,7 +16,7 @@ ) json.call(tm, :slug, :id, :name, :kind) json.module_progress due_date_man...
Fix another date format warning from moment.js
diff --git a/app/validators/email_validator.rb b/app/validators/email_validator.rb index abc1234..def5678 100644 --- a/app/validators/email_validator.rb +++ b/app/validators/email_validator.rb @@ -0,0 +1,21 @@+require 'mail' +class EmailValidator < ActiveModel::EachValidator + def validate_each(record,attribute,value)...
Add email validation class withouth regex
diff --git a/app/helpers/sub_nav_helper.rb b/app/helpers/sub_nav_helper.rb index abc1234..def5678 100644 --- a/app/helpers/sub_nav_helper.rb +++ b/app/helpers/sub_nav_helper.rb @@ -1,11 +1,13 @@ module SubNavHelper def show_teachers_dashboard_button? + return false unless current_user return false if current...
Add other check for logged in users
diff --git a/app/models/progress_update.rb b/app/models/progress_update.rb index abc1234..def5678 100644 --- a/app/models/progress_update.rb +++ b/app/models/progress_update.rb @@ -3,6 +3,8 @@ belongs_to :project belongs_to :user has_many :comments, dependent: :destroy + + validates :content, presence: true ...
Add full_errors_string method. Validate presence of content
diff --git a/lib/autobots.rb b/lib/autobots.rb index abc1234..def5678 100644 --- a/lib/autobots.rb +++ b/lib/autobots.rb @@ -1,4 +1,5 @@ require 'autobots/version' +require 'active_support/all' require 'active_model_serializers' require 'bulk_cache_fetcher'
Revert "remove a require for active support" This reverts commit 74990ac51ceec77145b64359920aa5b05488169c.
diff --git a/lib/junit5_adapter.rb b/lib/junit5_adapter.rb index abc1234..def5678 100644 --- a/lib/junit5_adapter.rb +++ b/lib/junit5_adapter.rb @@ -3,7 +3,7 @@ class Junit5Adapter < TestingFrameworkAdapter COUNT_REGEXP = /(\d+) tests found/.freeze FAILURES_REGEXP = /(\d+) tests failed/.freeze - ASSERTION_ERROR_...
Fix JUnit 5 for ArrayComparisonFailure
diff --git a/ServiceDeployer/src/main/resources/tomcat-service-deploy-template/attributes/default.rb b/ServiceDeployer/src/main/resources/tomcat-service-deploy-template/attributes/default.rb index abc1234..def5678 100644 --- a/ServiceDeployer/src/main/resources/tomcat-service-deploy-template/attributes/default.rb +++ b...
Set static variables in attributes file
diff --git a/birth_number.gemspec b/birth_number.gemspec index abc1234..def5678 100644 --- a/birth_number.gemspec +++ b/birth_number.gemspec @@ -21,6 +21,8 @@ spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(spec)/}) } spec.require_paths = ['lib'] + spec.required_ruby_version = '>= ...
Add minimum ruby version to gemspec
diff --git a/month.gemspec b/month.gemspec index abc1234..def5678 100644 --- a/month.gemspec +++ b/month.gemspec @@ -15,6 +15,6 @@ 'homepage' => 'https://github.com/readysteady/month', 'source_code_uri' => 'https://github.com/readysteady/month', 'bug_tracker_uri' => 'https://github.com/readysteady/month/i...
Update branch name in changelog_uri
diff --git a/app/services/manage_action.rb b/app/services/manage_action.rb index abc1234..def5678 100644 --- a/app/services/manage_action.rb +++ b/app/services/manage_action.rb @@ -5,6 +5,8 @@ def create Action.find_or_create_by( action_user: action_user, page: page ) do |action| + queue_message = {type: ...
Add queue post to action creation.
diff --git a/rdw.gemspec b/rdw.gemspec index abc1234..def5678 100644 --- a/rdw.gemspec +++ b/rdw.gemspec @@ -21,7 +21,7 @@ spec.add_development_dependency "bundler", "~> 1.5" spec.add_development_dependency "rake" - spec.add_development_dependency "rspec", "~> 3.0.0.beta2" + spec.add_development_dependency "rs...
Update rspec requirement to ~> 3.7.0 Updates the requirements on [rspec](https://github.com/rspec/rspec) to permit the latest version. - [Commits](https://github.com/rspec/rspec/commits/v3.7.0)
diff --git a/gitback.rb b/gitback.rb index abc1234..def5678 100644 --- a/gitback.rb +++ b/gitback.rb @@ -13,7 +13,7 @@ #repositories = # .map{|r| %Q[#{r[:name]}] } #FileUtils.mkdir_p #{backupDirectory} -YAML.load(open("http://github.com/api/v2/yaml/repos/show/#{username}"))['repositories'].map{|repository| +YAML.load...
Use HTTPS to connect to GitHub It is mandatory, without this change code will error: /usr/lib/ruby/2.1.0/open-uri.rb:223:in `open_loop': redirection forbidden: http://github.com/api/v2/yaml/repos/show/irnc -> https://github.com/api/v2/yaml/repos/show/irnc (RuntimeError)
diff --git a/lib/bus_tracker/service.rb b/lib/bus_tracker/service.rb index abc1234..def5678 100644 --- a/lib/bus_tracker/service.rb +++ b/lib/bus_tracker/service.rb @@ -13,18 +13,12 @@ document = Nokogiri::HTML(open("#{BASE_URI}getServicePoints.php?serviceMnemo=#{self.number}")) bus_stops = document.xpath...
Tidy up the creation of new bus stops, don't be overeager with local variables.