diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/checks/check_nested_attributes.rb b/lib/checks/check_nested_attributes.rb index abc1234..def5678 100644 --- a/lib/checks/check_nested_attributes.rb +++ b/lib/checks/check_nested_attributes.rb @@ -0,0 +1,32 @@+require 'checks/base_check' +require 'processors/lib/find_call' + +class CheckNestedAttributes...
Add check for vulnerability in nested attributes http://groups.google.com/group/rubyonrails-security/browse_thread/thread/f9f913d328dafe0c
diff --git a/spec/product/reports_spec.rb b/spec/product/reports_spec.rb index abc1234..def5678 100644 --- a/spec/product/reports_spec.rb +++ b/spec/product/reports_spec.rb @@ -0,0 +1,27 @@+describe 'YAML reports' do + let(:report_dirs) { [REPORTS_FOLDER, "#{TIMELINES_FOLDER}/miq_reports"] } + let(:report_yamls) { re...
Test all report recipes from product/ directory.
diff --git a/spec/pvoutput/client_spec.rb b/spec/pvoutput/client_spec.rb index abc1234..def5678 100644 --- a/spec/pvoutput/client_spec.rb +++ b/spec/pvoutput/client_spec.rb @@ -21,7 +21,7 @@ end it 'adds a status' do - body = 'd=20150101&t=00%3A00&v1=100&v2=50&v6=200' + body = 'd=20150101&t=00%3A00...
Fix addstatus test for temperature
diff --git a/lib/fabrication/schematic/attribute.rb b/lib/fabrication/schematic/attribute.rb index abc1234..def5678 100644 --- a/lib/fabrication/schematic/attribute.rb +++ b/lib/fabrication/schematic/attribute.rb @@ -1,6 +1,7 @@ class Fabrication::Schematic::Attribute - attr_accessor :klass, :name, :params, :value +...
Define only writer because reader is defined below
diff --git a/spec/unit/recipes/cacher-client_spec.rb b/spec/unit/recipes/cacher-client_spec.rb index abc1234..def5678 100644 --- a/spec/unit/recipes/cacher-client_spec.rb +++ b/spec/unit/recipes/cacher-client_spec.rb @@ -2,24 +2,34 @@ describe 'apt::cacher-client' do context 'no server' do - let(:chef_run) { Ch...
Fix the cacher client specs Signed-off-by: Tim Smith <764ef62106582a09ed09dfa0b6bff7c05fd7d1e4@chef.io>
diff --git a/lib/gap_intelligence/models/record.rb b/lib/gap_intelligence/models/record.rb index abc1234..def5678 100644 --- a/lib/gap_intelligence/models/record.rb +++ b/lib/gap_intelligence/models/record.rb @@ -33,7 +33,7 @@ private def convert_value_to(klass, value) - return value if klass.nil? || va...
Fix converting attribute value if value is nil
diff --git a/lib/active_mocker/mock/collection.rb b/lib/active_mocker/mock/collection.rb index abc1234..def5678 100644 --- a/lib/active_mocker/mock/collection.rb +++ b/lib/active_mocker/mock/collection.rb @@ -16,8 +16,8 @@ end extend ::Forwardable - def_delegators :@collection, :take, :push, :clear, :firs...
Fix Ruby warning where distinct was being redefined.
diff --git a/spec/models/answer_connection_spec.rb b/spec/models/answer_connection_spec.rb index abc1234..def5678 100644 --- a/spec/models/answer_connection_spec.rb +++ b/spec/models/answer_connection_spec.rb @@ -20,4 +20,16 @@ expect(relationship_type(AnswerConnection, :answer_2)).to eq(:belongs_to) end ...
Add a test to 'similarity' method
diff --git a/spec/requests/api/v1/question_spec.rb b/spec/requests/api/v1/question_spec.rb index abc1234..def5678 100644 --- a/spec/requests/api/v1/question_spec.rb +++ b/spec/requests/api/v1/question_spec.rb @@ -28,4 +28,24 @@ @json.first.should have_key('question_identifier') @json.first['question_identifier...
Add test for translations api
diff --git a/lib/porthos/mongo_mapper/extensions.rb b/lib/porthos/mongo_mapper/extensions.rb index abc1234..def5678 100644 --- a/lib/porthos/mongo_mapper/extensions.rb +++ b/lib/porthos/mongo_mapper/extensions.rb @@ -34,17 +34,15 @@ elsif value.nil? || value.to_s == '' nil else -...
Save SymbolOperator as a simple string
diff --git a/lib/scss_lint/reporter/xml_reporter.rb b/lib/scss_lint/reporter/xml_reporter.rb index abc1234..def5678 100644 --- a/lib/scss_lint/reporter/xml_reporter.rb +++ b/lib/scss_lint/reporter/xml_reporter.rb @@ -6,12 +6,13 @@ output << '<lint>' lints.group_by(&:filename).each do |filename, file_lint...
Update XmlReporter to XML encode attribute strings Avoids problem where filename or description contains illegal XML characters (like an ampersand) by escaping the output. Change-Id: I161de23cd8d52d5b8bab540457fd5fcb4d44add9 Reviewed-on: http://gerrit.causes.com/37215 Tested-by: jenkins <d95b56ce41a2e1ac4cecdd398defd...
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index abc1234..def5678 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -0,0 +1,50 @@+# This file is copied to spec/ when you run 'rails generate rspec:install' +ENV['RAILS_ENV'] ||= 'test' +require 'spec_helper' +require File.expand_path('../../co...
Fix configuration for travis and coveralls
diff --git a/spec/version_spec.rb b/spec/version_spec.rb index abc1234..def5678 100644 --- a/spec/version_spec.rb +++ b/spec/version_spec.rb @@ -0,0 +1,23 @@+#!/usr/bin/env ruby +# Copyright 2009 Wincent Colaiuta +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU Ge...
Add specs for version module Signed-off-by: Wincent Colaiuta <c76ac2e9cd86441713c7dfae92c451f3e6d17fdc@wincent.com>
diff --git a/config/initializers/websocket_server.rb b/config/initializers/websocket_server.rb index abc1234..def5678 100644 --- a/config/initializers/websocket_server.rb +++ b/config/initializers/websocket_server.rb @@ -2,7 +2,6 @@ require 'rubyception/subscriber' require 'rubyception/catcher' -::Rails.logger.auto_...
Remove auto flushing of the log file
diff --git a/lib/esortcode/errors.rb b/lib/esortcode/errors.rb index abc1234..def5678 100644 --- a/lib/esortcode/errors.rb +++ b/lib/esortcode/errors.rb @@ -3,7 +3,7 @@ # request returns an error value. class ResponseError < RuntimeError attr_reader :response - def initialize(msg, response) + def initia...
Make exception initialise params optional
diff --git a/lib/furnace/type/top.rb b/lib/furnace/type/top.rb index abc1234..def5678 100644 --- a/lib/furnace/type/top.rb +++ b/lib/furnace/type/top.rb @@ -1,7 +1,7 @@ module Furnace class Type::Top class << self - def normalize(params) + def normalize(*params) params end
Fix a bug in Type::Top.normalize.
diff --git a/knife-server.gemspec b/knife-server.gemspec index abc1234..def5678 100644 --- a/knife-server.gemspec +++ b/knife-server.gemspec @@ -16,6 +16,7 @@ gem.version = Knife::Server::VERSION gem.add_dependency "fog", "~> 1.3" + gem.add_dependency "net-ssh" gem.add_dependency "chef", ">=...
Add net-ssh as a gem dependency.
diff --git a/lib/girlscout/config.rb b/lib/girlscout/config.rb index abc1234..def5678 100644 --- a/lib/girlscout/config.rb +++ b/lib/girlscout/config.rb @@ -1,11 +1,11 @@ # frozen_string_literal: true module GirlScout - DEFAULT_API_PREFIX = 'https://api.helpscout.net/v1' + DEFAULT_API_PREFIX = 'https://api.helpsco...
Update api prefix from v1 to v2
diff --git a/lib/haskii/bar_chart.rb b/lib/haskii/bar_chart.rb index abc1234..def5678 100644 --- a/lib/haskii/bar_chart.rb +++ b/lib/haskii/bar_chart.rb @@ -16,6 +16,8 @@ .map { |line| line.join("") } end + private + def generate_matrix row_sequence = @frequences.map { |number| generate_row(...
Read about attributs and methods
diff --git a/lib/magic_grid/order.rb b/lib/magic_grid/order.rb index abc1234..def5678 100644 --- a/lib/magic_grid/order.rb +++ b/lib/magic_grid/order.rb @@ -1,6 +1,6 @@ module MagicGrid module Order - class Unordered < BasicObject + class Unordered def self.css_class 'sort-none' end
Remove reference to BasicObject, it wasn't introduced until 1.9
diff --git a/lib/web_console/repl.rb b/lib/web_console/repl.rb index abc1234..def5678 100644 --- a/lib/web_console/repl.rb +++ b/lib/web_console/repl.rb @@ -30,8 +30,8 @@ end private - def derive_adaptee_constant_from(adapter_class, suffix = 'REPL') - "::#{adapter_class.name.split('::').l...
Use a saner names in derive_adaptee_constant_from
diff --git a/cookbooks/apple_osx_updates/recipes/mac.rb b/cookbooks/apple_osx_updates/recipes/mac.rb index abc1234..def5678 100644 --- a/cookbooks/apple_osx_updates/recipes/mac.rb +++ b/cookbooks/apple_osx_updates/recipes/mac.rb @@ -12,7 +12,7 @@ app "OSXUpd10.8.4" volumes_dir "OS X 10.8.4 Update" dmg_name "OSX...
Fix source path for apple_osx_updates
diff --git a/lib/authenticator.rb b/lib/authenticator.rb index abc1234..def5678 100644 --- a/lib/authenticator.rb +++ b/lib/authenticator.rb @@ -1,8 +1,8 @@ module HonestRenter class Authenticator class << self - def from_secret_key_member_id(*_) - raise 'secret key auth is not supported at this tim...
Revert "Remove secret key auth" This reverts commit 8b12940bad4cb336e6151539c93e65a40e7dd623.
diff --git a/lib/bummr/updater.rb b/lib/bummr/updater.rb index abc1234..def5678 100644 --- a/lib/bummr/updater.rb +++ b/lib/bummr/updater.rb @@ -19,7 +19,12 @@ system("bundle update #{gem[:name]}") updated_version = updated_version_for(gem) - message = "Update #{gem[:name]} from #{gem[:installed]} t...
Deal with updating gem dependencies only
diff --git a/lib/clog/transmit.rb b/lib/clog/transmit.rb index abc1234..def5678 100644 --- a/lib/clog/transmit.rb +++ b/lib/clog/transmit.rb @@ -2,13 +2,12 @@ require 'uri' class Transmit - attr_accessor :uri, :port, :api_token, :data + attr_accessor :api_token, :data, :uri def initialize(url, api_token, data...
Remove unused variable from Transmit class. The port variable is not used can be removed in favor of using the port number from URI.
diff --git a/lib/deterministic.rb b/lib/deterministic.rb index abc1234..def5678 100644 --- a/lib/deterministic.rb +++ b/lib/deterministic.rb @@ -1,4 +1,6 @@ require "deterministic/version" + +warn "WARN: Deterministic is meant to run on Ruby 2+" if RUBY_VERSION.to_f < 2 module Deterministic; end
Add warning for Ruby < 2
diff --git a/lib/popular_items.rb b/lib/popular_items.rb index abc1234..def5678 100644 --- a/lib/popular_items.rb +++ b/lib/popular_items.rb @@ -6,7 +6,11 @@ def initialize(panopticon_api_credentials, logger = nil) publisher = GdsApi::Panopticon.new(Plek.current_env, panopticon_api_credentials) - @items = p...
Fix display of popular items with filthy hackery. Again, since this is being replaced very soon with frontend browse pages, it's not worth the time it would take to fix it properly.
diff --git a/Casks/gifloopcoder.rb b/Casks/gifloopcoder.rb index abc1234..def5678 100644 --- a/Casks/gifloopcoder.rb +++ b/Casks/gifloopcoder.rb @@ -2,6 +2,7 @@ version '1.3.5' sha256 '0b6f7d85d5e7dc95967f93cd645302da7aac4c9d8fbf0029d6886bd99931e849' + # github.com/bit101/gifloopcoder was verified as official w...
Fix `url` stanza comment for GIFLoopCoder.
diff --git a/Casks/micro-snitch.rb b/Casks/micro-snitch.rb index abc1234..def5678 100644 --- a/Casks/micro-snitch.rb +++ b/Casks/micro-snitch.rb @@ -1,6 +1,6 @@ cask :v1 => 'micro-snitch' do - version '1.1.1' - sha256 '494eedf1a8f87cb846eb37279bca7aecd851157bdd31347ab8e1d8f219613680' + version '1.1.2' + sha256 'a1d...
Upgrade Micro Snitch.app to v1.1.2
diff --git a/Casks/neteasemusic.rb b/Casks/neteasemusic.rb index abc1234..def5678 100644 --- a/Casks/neteasemusic.rb +++ b/Casks/neteasemusic.rb @@ -1,9 +1,9 @@ cask :v1 => 'neteasemusic' do - version '1.4.0' - sha256 'e617ccc626c2275638ee731af0dcfd955b327bb581b5b8b1caa91f69c055e3e1' + version '1.4.0_418' + sha256 ...
Upgrade Netease Music to v1.4.0.418
diff --git a/cookbooks/ondemand_base/recipes/centos.rb b/cookbooks/ondemand_base/recipes/centos.rb index abc1234..def5678 100644 --- a/cookbooks/ondemand_base/recipes/centos.rb +++ b/cookbooks/ondemand_base/recipes/centos.rb @@ -1,6 +1,9 @@-#Make sure that this recipe only runs on CentOS/RHEL systems -if platform?("red...
Update CentOS recipe to the latest rev to include setting up the bobo account and sudo
diff --git a/sample/spec/spec_helper.rb b/sample/spec/spec_helper.rb index abc1234..def5678 100644 --- a/sample/spec/spec_helper.rb +++ b/sample/spec/spec_helper.rb @@ -4,6 +4,7 @@ require File.expand_path("../dummy/config/environment", __FILE__) require 'rspec/rails' require 'ffaker' +require 'spree_sample' RSpec...
Add require spree_sample to spec helper to prevent failure when running build.sh.
diff --git a/test/models/optional_modules/guest_books/guest_book_test.rb b/test/models/optional_modules/guest_books/guest_book_test.rb index abc1234..def5678 100644 --- a/test/models/optional_modules/guest_books/guest_book_test.rb +++ b/test/models/optional_modules/guest_books/guest_book_test.rb @@ -1,7 +1,58 @@ requir...
Add tests for GuestBook model
diff --git a/core/app/helpers/spree/taxons_helper.rb b/core/app/helpers/spree/taxons_helper.rb index abc1234..def5678 100644 --- a/core/app/helpers/spree/taxons_helper.rb +++ b/core/app/helpers/spree/taxons_helper.rb @@ -7,12 +7,12 @@ # to show the most popular products for a particular taxon (that is an exercise l...
Remove redundant select for `id` attr on `Spree::TaxonsHelper` The SQL queries specified on said helper on lines 10 and 15 were redundantly selecting the `id` attribute for `spree_products` table, which caused MySQL to raise an exception about a duplicate column name since said attribute is already being selected thro...
diff --git a/llt-assessor.gemspec b/llt-assessor.gemspec index abc1234..def5678 100644 --- a/llt-assessor.gemspec +++ b/llt-assessor.gemspec @@ -9,7 +9,7 @@ spec.authors = ["LFDM"] spec.email = ["1986gh@gmail.com"] spec.summary = %q{Provides various grading/assessment mechanisma on top off l...
Add summary and dependencies in gemspec
diff --git a/lib/metasploit_data_models/engine.rb b/lib/metasploit_data_models/engine.rb index abc1234..def5678 100644 --- a/lib/metasploit_data_models/engine.rb +++ b/lib/metasploit_data_models/engine.rb @@ -11,7 +11,7 @@ # Remove ActiveSupport::Dependencies loading paths to save time during constant resolution an...
Fix problem with autoload path resetting
diff --git a/config/initializers/backport_pg_10_support_to_rails_4.rb b/config/initializers/backport_pg_10_support_to_rails_4.rb index abc1234..def5678 100644 --- a/config/initializers/backport_pg_10_support_to_rails_4.rb +++ b/config/initializers/backport_pg_10_support_to_rails_4.rb @@ -0,0 +1,46 @@+require 'active_re...
Support pg 10 for Rails 4.2
diff --git a/config/initializers/backport_pg_10_support_to_rails_4.rb b/config/initializers/backport_pg_10_support_to_rails_4.rb index abc1234..def5678 100644 --- a/config/initializers/backport_pg_10_support_to_rails_4.rb +++ b/config/initializers/backport_pg_10_support_to_rails_4.rb @@ -0,0 +1,44 @@+# +# Monkey-patch ...
Repair PK Reset. Fixes 719 See https://github.com/rails/rails/issues/28780 for details
diff --git a/lib/organic-sitemap/redis_manager.rb b/lib/organic-sitemap/redis_manager.rb index abc1234..def5678 100644 --- a/lib/organic-sitemap/redis_manager.rb +++ b/lib/organic-sitemap/redis_manager.rb @@ -2,29 +2,41 @@ class RedisManager def self.add(key) return unless key - OrganicSitemap.config...
Add remove_key and remove_keys functions on redis manager
diff --git a/lib/overriaktion/mocked_responses.rb b/lib/overriaktion/mocked_responses.rb index abc1234..def5678 100644 --- a/lib/overriaktion/mocked_responses.rb +++ b/lib/overriaktion/mocked_responses.rb @@ -0,0 +1,5 @@+module Overriaktion + module MockedResponses + RIAK_CLUSTERS = '[{"created_at":"2011-10-10T03:3...
Add mocked response for riak clusters.
diff --git a/lib/stackprofiler/filters/js_tree.rb b/lib/stackprofiler/filters/js_tree.rb index abc1234..def5678 100644 --- a/lib/stackprofiler/filters/js_tree.rb +++ b/lib/stackprofiler/filters/js_tree.rb @@ -17,7 +17,13 @@ end text = escaped.join("<br> ↳ ") - children = root.children.map { |n...
Sort tree branches by sample count
diff --git a/lib/walmart_open/commerce_request.rb b/lib/walmart_open/commerce_request.rb index abc1234..def5678 100644 --- a/lib/walmart_open/commerce_request.rb +++ b/lib/walmart_open/commerce_request.rb @@ -11,6 +11,7 @@ def build_url(client) url = "https://#{client.config.commerce_domain}" url << "...
Add "qa" to url in debug mode
diff --git a/lib/generators/invitational/install/install_generator.rb b/lib/generators/invitational/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/invitational/install/install_generator.rb +++ b/lib/generators/invitational/install/install_generator.rb @@ -15,6 +15,10 @@ end ...
Put the code back in to add the gem to the gemfile until we figure out the issue around this
diff --git a/lib/axiom/types/date_time.rb b/lib/axiom/types/date_time.rb index abc1234..def5678 100644 --- a/lib/axiom/types/date_time.rb +++ b/lib/axiom/types/date_time.rb @@ -7,13 +7,13 @@ class DateTime < Object extend ValueComparable - NSEC_IN_SECONDS = 1 - Rational(1, 10**9) + MAXIMUM_NSEC_I...
Rename constant to be more clear
diff --git a/lib/catarse_stripe/engine.rb b/lib/catarse_stripe/engine.rb index abc1234..def5678 100644 --- a/lib/catarse_stripe/engine.rb +++ b/lib/catarse_stripe/engine.rb @@ -5,8 +5,8 @@ #end module ActionDispatch::Routing class Mapper - def mount_catarse_stripe_at(payment) - scope payment do + def mou...
Change route to share application
diff --git a/spec/install/force_spec.rb b/spec/install/force_spec.rb index abc1234..def5678 100644 --- a/spec/install/force_spec.rb +++ b/spec/install/force_spec.rb @@ -33,5 +33,14 @@ expect(out).to include "Using bundler 1.10.4" end + it "works on first bundle install" do + bundle "install --force...
Add test to ensure that bundle install --force works even when bundle is not yet created
diff --git a/lib/docker/release/runner.rb b/lib/docker/release/runner.rb index abc1234..def5678 100644 --- a/lib/docker/release/runner.rb +++ b/lib/docker/release/runner.rb @@ -14,6 +14,7 @@ def precheck! check_for_unstaged_changes! + check_for_changelog! end def perform!
Add back the changelog check
diff --git a/spree_mercado_pago.gemspec b/spree_mercado_pago.gemspec index abc1234..def5678 100644 --- a/spree_mercado_pago.gemspec +++ b/spree_mercado_pago.gemspec @@ -10,13 +10,13 @@ s.license = 'MIT' s.add_dependency 'spree_core', '~> 3.2.0.rc1' - s.add_dependency 'rest-client', '~> 1.7' + s.add_depend...
Update rest-client & coffee-rails dependencies
diff --git a/sprockets-redirect.gemspec b/sprockets-redirect.gemspec index abc1234..def5678 100644 --- a/sprockets-redirect.gemspec +++ b/sprockets-redirect.gemspec @@ -1,7 +1,8 @@ Gem::Specification.new do |s| - s.name = 'sprockets-redirect' - s.version = '0.3.0' - s.date = '2014-12-30' + s.name ...
Update style in gemspec file
diff --git a/spec/active_set/paginate/enumerable_adapter_spec.rb b/spec/active_set/paginate/enumerable_adapter_spec.rb index abc1234..def5678 100644 --- a/spec/active_set/paginate/enumerable_adapter_spec.rb +++ b/spec/active_set/paginate/enumerable_adapter_spec.rb @@ -0,0 +1,66 @@+# frozen_string_literal: true + +requi...
Add tests for the updated EnumerableAdapter for the PaginateProcessor
diff --git a/spec/models/course/condition/survey_ability_spec.rb b/spec/models/course/condition/survey_ability_spec.rb index abc1234..def5678 100644 --- a/spec/models/course/condition/survey_ability_spec.rb +++ b/spec/models/course/condition/survey_ability_spec.rb @@ -0,0 +1,17 @@+# frozen_string_literal: true +require...
Add permission test for survey condition
diff --git a/lib/rubygems/tasks/build/tar.rb b/lib/rubygems/tasks/build/tar.rb index abc1234..def5678 100644 --- a/lib/rubygems/tasks/build/tar.rb +++ b/lib/rubygems/tasks/build/tar.rb @@ -8,7 +8,8 @@ FLAGS = { :bz2 => 'j', :gz => 'x', - :xz => 'J' + :xz => 'J', + ...
Handle when :format is nil.
diff --git a/test/fake_app/sinatra_app.rb b/test/fake_app/sinatra_app.rb index abc1234..def5678 100644 --- a/test/fake_app/sinatra_app.rb +++ b/test/fake_app/sinatra_app.rb @@ -11,6 +11,8 @@ @users = User.page params[:page] erb <<-ERB.dup <%= @users.map(&:name).join("\n") %> +<%= link_to_previous_page @users,...
Make sure that link_to_{previous,next}_page is working
diff --git a/nutshell-crm.gemspec b/nutshell-crm.gemspec index abc1234..def5678 100644 --- a/nutshell-crm.gemspec +++ b/nutshell-crm.gemspec @@ -11,6 +11,7 @@ s.summary = "A Ruby wrapper for Nutshell CRM's API" s.description = "Description" + s.add_development_dependency 'rake' s.add_development_dependen...
Add rake as dev dependency.
diff --git a/plugins/kernel_v2/config/vm_provider.rb b/plugins/kernel_v2/config/vm_provider.rb index abc1234..def5678 100644 --- a/plugins/kernel_v2/config/vm_provider.rb +++ b/plugins/kernel_v2/config/vm_provider.rb @@ -30,6 +30,7 @@ @logger.info("Configuring provider #{@name} with #{config_class}") @...
Call `finalize!` properly on provider configurations
diff --git a/spec/factories/course_assessment_question_programming.rb b/spec/factories/course_assessment_question_programming.rb index abc1234..def5678 100644 --- a/spec/factories/course_assessment_question_programming.rb +++ b/spec/factories/course_assessment_question_programming.rb @@ -3,7 +3,8 @@ class: Co...
Implement creating a question package as part of the programming question factory.
diff --git a/lib/mrdrive_notification_api/easy_setup.rb b/lib/mrdrive_notification_api/easy_setup.rb index abc1234..def5678 100644 --- a/lib/mrdrive_notification_api/easy_setup.rb +++ b/lib/mrdrive_notification_api/easy_setup.rb @@ -21,11 +21,19 @@ WrongConfigException.missing_config(:publish_key) end - puts "...
Add stdout logger and callback for error in Pubsub initiation
diff --git a/lib/mymoip/requests/transparent_request.rb b/lib/mymoip/requests/transparent_request.rb index abc1234..def5678 100644 --- a/lib/mymoip/requests/transparent_request.rb +++ b/lib/mymoip/requests/transparent_request.rb @@ -17,21 +17,19 @@ end def success? - @response && @response["EnviarInstru...
Remove unused variable in rescue statements
diff --git a/firmata.gemspec b/firmata.gemspec index abc1234..def5678 100644 --- a/firmata.gemspec +++ b/firmata.gemspec @@ -17,6 +17,6 @@ gem.add_development_dependency("pry") - gem.add_runtime_dependency("serialport", ["~> 1.1.0"]) + gem.add_runtime_dependency("hybridgroup-serialport") gem.add_runtime_depe...
Update gemspec to use hybridgroup-serialport
diff --git a/test/countries/uy_test.rb b/test/countries/uy_test.rb index abc1234..def5678 100644 --- a/test/countries/uy_test.rb +++ b/test/countries/uy_test.rb @@ -0,0 +1,22 @@+require File.expand_path(File.dirname(__FILE__) + '/../test_helper') + +## Uruguay +# source: http://en.wikipedia.org/wiki/Telephone_numbers_i...
Add tests for Uruguay area code change
diff --git a/test/restful-api/src/spec/ruby/user_actions_spec.rb b/test/restful-api/src/spec/ruby/user_actions_spec.rb index abc1234..def5678 100644 --- a/test/restful-api/src/spec/ruby/user_actions_spec.rb +++ b/test/restful-api/src/spec/ruby/user_actions_spec.rb @@ -2,12 +2,7 @@ describe "POST" do def user_a...
Update integration spec helper to use variables passed to it.
diff --git a/lib/eye/patch/capistrano3.rb b/lib/eye/patch/capistrano3.rb index abc1234..def5678 100644 --- a/lib/eye/patch/capistrano3.rb +++ b/lib/eye/patch/capistrano3.rb @@ -4,6 +4,9 @@ set :eye_config, -> { "config/eye.yml" } set :eye_bin, -> { "eye-patch" } set :eye_roles, -> { :app } + + set :rvm...
Add rvm and rbenv prefix hooks
diff --git a/lib/niman/cli/application.rb b/lib/niman/cli/application.rb index abc1234..def5678 100644 --- a/lib/niman/cli/application.rb +++ b/lib/niman/cli/application.rb @@ -7,6 +7,8 @@ desc "apply", "Applies a Nimanfile" def apply Niman::Recipe.from_file + rescue LoadError => e + e...
Print nice error message when Nimanfile was not found
diff --git a/lib/redis/store/interface.rb b/lib/redis/store/interface.rb index abc1234..def5678 100644 --- a/lib/redis/store/interface.rb +++ b/lib/redis/store/interface.rb @@ -5,8 +5,16 @@ super(key) end + REDIS_SET_OPTIONS = %i(ex px nx xx keepttl).freeze + private_constant :REDIS_SET_OPTIO...
Fix compatibility with redis-rb 4.2
diff --git a/lib/dpl/provider/heroku/git_deploy_key.rb b/lib/dpl/provider/heroku/git_deploy_key.rb index abc1234..def5678 100644 --- a/lib/dpl/provider/heroku/git_deploy_key.rb +++ b/lib/dpl/provider/heroku/git_deploy_key.rb @@ -7,6 +7,7 @@ end def check_auth + super setup_git_ssh...
Revert "Remove explicit need for Heroku authentication." This reverts commit 5e7c3d84fb62e41bf209782a890cdebf3901c669.
diff --git a/lib/tasks/specification.rake b/lib/tasks/specification.rake index abc1234..def5678 100644 --- a/lib/tasks/specification.rake +++ b/lib/tasks/specification.rake @@ -7,9 +7,20 @@ rulesets = Ruleset.subclasses + base_variables = { + "Applicant Number" => { + :name => "Applicant Number",...
Add Applicant Number and State
diff --git a/lib/yard/code_objects/namespace_object.rb b/lib/yard/code_objects/namespace_object.rb index abc1234..def5678 100644 --- a/lib/yard/code_objects/namespace_object.rb +++ b/lib/yard/code_objects/namespace_object.rb @@ -3,8 +3,8 @@ attr_reader :children, :cvars, :meths, :constants, :mixins def i...
Use CodeObjectList again for @children and @mixins (specs work again)
diff --git a/activerecord/test/cases/adapters/mysql2/quoting_test.rb b/activerecord/test/cases/adapters/mysql2/quoting_test.rb index abc1234..def5678 100644 --- a/activerecord/test/cases/adapters/mysql2/quoting_test.rb +++ b/activerecord/test/cases/adapters/mysql2/quoting_test.rb @@ -7,14 +7,14 @@ test 'quoted date...
Remove @connection instance variable only when defined
diff --git a/app/decorators/vm_or_template_decorator.rb b/app/decorators/vm_or_template_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/vm_or_template_decorator.rb +++ b/app/decorators/vm_or_template_decorator.rb @@ -12,4 +12,8 @@ def supports_console? console_supported?('spice') || console_suppo...
Add "supports_cockpit?" to decorators so that it is accessible through the API.
diff --git a/app/controllers/islay/admin/asset_library_controller.rb b/app/controllers/islay/admin/asset_library_controller.rb index abc1234..def5678 100644 --- a/app/controllers/islay/admin/asset_library_controller.rb +++ b/app/controllers/islay/admin/asset_library_controller.rb @@ -1,26 +1,22 @@-module Islay - modul...
Tweak the namespacing of the asset library controller
diff --git a/app/controllers/spree/admin/user_sessions_controller.rb b/app/controllers/spree/admin/user_sessions_controller.rb index abc1234..def5678 100644 --- a/app/controllers/spree/admin/user_sessions_controller.rb +++ b/app/controllers/spree/admin/user_sessions_controller.rb @@ -11,7 +11,7 @@ def create if ...
Allow to customize the path redirect to after admin logged in In main application, override the after_admin_logged_in_path method to customize.
diff --git a/app/jobs/nexudus/billing/tariffs/import.rb b/app/jobs/nexudus/billing/tariffs/import.rb index abc1234..def5678 100644 --- a/app/jobs/nexudus/billing/tariffs/import.rb +++ b/app/jobs/nexudus/billing/tariffs/import.rb @@ -0,0 +1,11 @@+module Nexudus::Jobs::Billing + class Tariff + include Sidekiq::Worker...
Add Sidekiq job for retrieving tariffs.
diff --git a/app/serializer/favourite_object/favourite_serializer.rb b/app/serializer/favourite_object/favourite_serializer.rb index abc1234..def5678 100644 --- a/app/serializer/favourite_object/favourite_serializer.rb +++ b/app/serializer/favourite_object/favourite_serializer.rb @@ -2,6 +2,12 @@ root :favourites ...
Include associated target objects in serialized JSON
diff --git a/app/models/solidus_affirm/configuration.rb b/app/models/solidus_affirm/configuration.rb index abc1234..def5678 100644 --- a/app/models/solidus_affirm/configuration.rb +++ b/app/models/solidus_affirm/configuration.rb @@ -21,5 +21,15 @@ def callback_controller_name @callback_controller_name ||= "a...
Make the affirm payload serializer configurable To be able to easily override the serializer that is parsing the CheckoutPayload object to generate the correct JSON payload we introduce and configuration for that. Users can now set the `SolidusAffirm::Config.checkout_payload_serializer` to their own implementation.
diff --git a/gyapbox.gemspec b/gyapbox.gemspec index abc1234..def5678 100644 --- a/gyapbox.gemspec +++ b/gyapbox.gemspec @@ -18,6 +18,7 @@ spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) spec.require_paths = ["lib"] - spec.add_development_dependency "bundler", "~> 1.6" + spec.add_development_d...
Add RSpec to development dependencies
diff --git a/app/models/manageiq/providers/amazon/network_manager/security_group.rb b/app/models/manageiq/providers/amazon/network_manager/security_group.rb index abc1234..def5678 100644 --- a/app/models/manageiq/providers/amazon/network_manager/security_group.rb +++ b/app/models/manageiq/providers/amazon/network_manag...
Move SecurityGroup relations to base class Move SecurityGroup relations to base class
diff --git a/test/helper.rb b/test/helper.rb index abc1234..def5678 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -1,4 +1,5 @@ require 'tempfile' +require 'minitest/test' require 'simplecov' require 'coveralls'
Make running tests via Rubinius (but not via Travis) pass.
diff --git a/lib/active_record/connection_adapters/oracle_enhanced/column_dumper.rb b/lib/active_record/connection_adapters/oracle_enhanced/column_dumper.rb index abc1234..def5678 100644 --- a/lib/active_record/connection_adapters/oracle_enhanced/column_dumper.rb +++ b/lib/active_record/connection_adapters/oracle_enhan...
Remove incorrect prepend to `ActiveRecord::ColumnDumper` * `ActiveRecord::ColumnDumper` does not exist, it is harmless but should not exist. * This module is included here: https://github.com/rsim/oracle-enhanced/blob/master/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb#L166 ```ruby include ...
diff --git a/spec/features/groups/user_browse_projects_group_page_spec.rb b/spec/features/groups/user_browse_projects_group_page_spec.rb index abc1234..def5678 100644 --- a/spec/features/groups/user_browse_projects_group_page_spec.rb +++ b/spec/features/groups/user_browse_projects_group_page_spec.rb @@ -21,7 +21,7 @@ ...
Fix user browse projects group page spec
diff --git a/lib/fssm.rb b/lib/fssm.rb index abc1234..def5678 100644 --- a/lib/fssm.rb +++ b/lib/fssm.rb @@ -12,6 +12,7 @@ end end +$:.unshift(File.dirname(__FILE__)) require 'pathname' require 'fssm/ext' require 'fssm/support' @@ -21,3 +22,5 @@ require "fssm/backends/#{FSSM::Support.backend.downcase}" FSSM:...
Handle load path in case FSSM isn't on the load path when required.
diff --git a/diorama.gemspec b/diorama.gemspec index abc1234..def5678 100644 --- a/diorama.gemspec +++ b/diorama.gemspec @@ -15,13 +15,12 @@ s.files = Dir["{app,config,db,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.md"] - s.add_dependency "rails", "~> 3.2.21" + s.add_dependency "rails", "~> 3.2" - s.ad...
Add version info for gems so that we don't get warnings.
diff --git a/test/test_docopt.rb b/test/test_docopt.rb index abc1234..def5678 100644 --- a/test/test_docopt.rb +++ b/test/test_docopt.rb @@ -1,49 +1,12 @@ require 'test/unit' +require 'pathname' class DocoptTest < Test::Unit::TestCase - def setup - $LOAD_PATH << File.dirname(__FILE__) - load 'example.rb' + + ...
Fix `rake test` to run reference testcases
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,6 +1,3 @@-require 'rubygems' -require 'bundler/setup' - $:.unshift(File.dirname(__FILE__) + '/../lib') $:.unshift(File.dirname(__FILE__)) @@ -10,18 +7,14 @@ require 'shoulda...
Clean up our test helper
diff --git a/test/test_helper.rb b/test/test_helper.rb index abc1234..def5678 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,7 +1,7 @@ if defined?(Rake) && (RUBY_ENGINE != 'jruby' || org.jruby.RubyInstanceConfig.FULL_TRACE_ENABLED) require 'simplecov' SimpleCov.start - SimpleCov.minimum_coverag...
Decrease required coverage percentage since it is difficult to test platform specific code and VCS related code
diff --git a/lib/dest.rb b/lib/dest.rb index abc1234..def5678 100644 --- a/lib/dest.rb +++ b/lib/dest.rb @@ -1,5 +1,13 @@-require "dest/version" +require_relative "dest/version" module Dest - # Your code goes here... + + def self.test_file(file_path) + parsed_output = Parser.parse(file_path) + result = Evalu...
Add core method that tests a single file ( parses, evaluates and formats )
diff --git a/lib/selected.rb b/lib/selected.rb index abc1234..def5678 100644 --- a/lib/selected.rb +++ b/lib/selected.rb @@ -19,9 +19,9 @@ def controller_matches(controller_name) if controller_name.respond_to?(:=~) - params[:controller] =~ controller_name.to_s + controller_name =~ params[:controller]...
Fix order in regex matching
diff --git a/liftoff.gemspec b/liftoff.gemspec index abc1234..def5678 100644 --- a/liftoff.gemspec +++ b/liftoff.gemspec @@ -13,6 +13,7 @@ gem.homepage = "" gem.add_dependency "commander", "~> 4.1.2" + gem.add_dependency "xcodeproj", "~> 0.3.4" gem.files = `git ls-files`.split($/) gem.exe...
Add xcodeproj as a dependency
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -1,7 +1,7 @@ name 'unifi' maintainer 'Greg Albrecht' maintainer_email 'gba@onbeep.com' -license 'Apache License, Version 2.0' +license 'Apache 2.0' description 'Install...
Use the standard license text This lets scanners detect it correctly
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -10,4 +10,4 @@ if respond_to?(:issues_url) issues_url 'https://github.com/GSI-HPC/sys-chef-cookbook/issues' end -version '1.43.1' +version '1.44.0'
Implement handling of multiple recipients in sys_mail_alias
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -9,4 +9,4 @@ long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) version '0.1.0' -depends 'nginx' +depends 'nginx', '~> 2.7'
Use pessimistic operator for depends
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -6,4 +6,4 @@ replaces 'vagrant_rbenv' -depends 'rbenv', '1.6.5' +depends 'rbenv', '1.7.1'
Update dependency on rbenv cookbook
diff --git a/recipes/_nginx.rb b/recipes/_nginx.rb index abc1234..def5678 100644 --- a/recipes/_nginx.rb +++ b/recipes/_nginx.rb @@ -6,8 +6,9 @@ # # Override default Nginx attributes -node.set["nginx"]["worker_processes"] = 4 -node.set["nginx"]["worker_connections"] = 768 +node.set["nginx"]["worker_processes"] ...
Disable Nginx's default site via node attribute
diff --git a/SHSegueBlocks.podspec b/SHSegueBlocks.podspec index abc1234..def5678 100644 --- a/SHSegueBlocks.podspec +++ b/SHSegueBlocks.podspec @@ -30,5 +30,5 @@ s.source_files = "#{name}/**/*.{h,m}" s.requires_arc = true - spec.dependency 'SHObjectUserInfo', '~> 1.0' + s.dependency 'SHObjectUserInfo', '~> 1....
Switch to s from spec
diff --git a/unparser-cli_wrapper.gemspec b/unparser-cli_wrapper.gemspec index abc1234..def5678 100644 --- a/unparser-cli_wrapper.gemspec +++ b/unparser-cli_wrapper.gemspec @@ -19,6 +19,7 @@ spec.require_paths = ['lib'] spec.add_dependency 'unparser' + spec.add_dependency 'diff-lcs'# until unparser v0.1.17 s...
Add diff-lcs dependency until unparser v0.1.17
diff --git a/nib.gemspec b/nib.gemspec index abc1234..def5678 100644 --- a/nib.gemspec +++ b/nib.gemspec @@ -29,5 +29,5 @@ s.add_development_dependency('guard-rspec') s.add_development_dependency('guard-rubocop') s.add_development_dependency('simplecov') - s.add_development_dependency('codeclimate-test-reporte...
Use latest version of code-climate-test-reporter A recent release will (hopefully) fix issues with reporting test coverage from Codeship. https://github.com/codeclimate/ruby-test-reporter/pull/172
diff --git a/test/cleaning_test.rb b/test/cleaning_test.rb index abc1234..def5678 100644 --- a/test/cleaning_test.rb +++ b/test/cleaning_test.rb @@ -0,0 +1,21 @@+require 'test_helper' + +describe 'Redis::Breadcrumb' do + before do + Redis::Breadcrumb.redis = MockRedis.new + end + + it 'will clean up currently def...
Add 'will clean up currently defined keys' test
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -5,6 +5,7 @@ description "Installs and configures Rundeck 2.0" long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) version "2.0.4" +depends "runit" depends ...
Revert "remove the runit dependency" This reverts commit c970574c6323d61ba71ea27e770b5b5188217344 [formerly 22f0fef602c93cdf7224d09a1d3ffbccd53ae458]. Former-commit-id: 6213ab53718192e50121eff248f7cb2ad2c59444
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -14,6 +14,6 @@ depends "t3-chef-vault", "~> 1.0.0" depends "t3-mysql", "~> 0.1.3" -depends "php", "= 1.1.2" +depends "php", "= 1.5.0" depends "ssh", "= 0...
[TASK] Raise dependency for php cookbook to 1.5.0
diff --git a/metadata.rb b/metadata.rb index abc1234..def5678 100644 --- a/metadata.rb +++ b/metadata.rb @@ -2,11 +2,15 @@ maintainer 'Chef Software, Inc.' maintainer_email 'cookbooks@chef.io' license 'Apache 2.0' -description 'Installs/Configures yum-elrepo' +description 'Installs and configures the elrepo yum repos...
Improve description, bump requirement to yum 3.2
diff --git a/db/migrate/101_add_hash_to_info_request.rb b/db/migrate/101_add_hash_to_info_request.rb index abc1234..def5678 100644 --- a/db/migrate/101_add_hash_to_info_request.rb +++ b/db/migrate/101_add_hash_to_info_request.rb @@ -6,7 +6,7 @@ # Create the missing events for requests already sent In...
Update reference to Configuration to reflect name change to AlaveteliConfiguration