doc-reference check

scripts/test_doc_references.py

@@ -53,16 +53,30 @@ def main() -> int:
           + (f"; MISSING {missing[:4]}" if missing else ""))
 
     # ...and the published scripts must not point at one person's disk
+    # react_paths.py is the ONE place a default may live, and only as the
+    # fallback of an environment lookup. Exempting it wholesale would let a
+    # literal creep back in beside the documented ones, so the exemption is
+    # narrowed: every absolute path in that file must sit on a line that reads
+    # the environment.
     scripts = sorted(f for f in files if f.startswith("scripts/") and f.endswith(".py"))
-    hard = []
-    for s in scripts:
-        text = Path(hf_hub_download(REPO, s, repo_type="dataset",
+    hard, loose = [], []
+    for s_ in scripts:
+        text = Path(hf_hub_download(REPO, s_, repo_type="dataset",
                                     local_dir=d)).read_text(errors="ignore")
+        if s_ == "scripts/react_paths.py":
+            for line in text.splitlines():
+                if ABS_RE.search(line) and "os.environ" not in line \
+                        and not line.lstrip().startswith(("#", "_DEF_")):
+                    loose.append(line.strip()[:70])
+            continue
         for m in ABS_RE.findall(text):
-            hard.append(f"{s}: {m}")
-    check(not hard, "no published script hard-codes an absolute local path",
-          f"{len(scripts)} scripts checked, none point at a specific mount"
-          + (f"; {hard[:3]}" if hard else ""))
+            hard.append(f"{s_}: {m}")
+    check(not hard and not loose,
+          "only react_paths.py holds a default path, behind the environment",
+          f"{len(scripts)} scripts: {len(scripts)-1} with no absolute path, and "
+          f"react_paths.py's defaults all sit behind os.environ.get"
+          + (f"; hard-coded {hard[:3]}" if hard else "")
+          + (f"; loose in react_paths {loose[:2]}" if loose else ""))
 
     # ...and the path module they share is published, since they import it
     imports_paths = []