url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/18942 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18942/labels{/name} | https://api.github.com/repos/facebook/react/issues/18942/comments | https://api.github.com/repos/facebook/react/issues/18942/events | https://github.com/facebook/react/pull/18942 | 619,831,049 | MDExOlB1bGxSZXF1ZXN0NDE5MTk4MzM5 | 18,942 | Proof-of-concept: Express render phase in terms of generator functions | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18942/builds/27218) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-18 00:18:51 | 2022-10-20 20:41:19 | 2022-10-20 20:41:19 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18942', 'html_url': 'https://github.com/facebook/react/pull/18942', 'diff_url': 'https://github.com/facebook/react/pull/18942.diff', 'patch_url': 'https://github.com/facebook/react/pull/18942.patch', 'merged_at': None} | Combines all the sub-phases of the render phase — begin, complete, and unwind — into a single generator function.
It works by pushing/popping generator objects onto a stack. This replaces the stack in ReactFiberStack.
The cursor objects used by ReactFiberStack are replaced by module level variables that are refer... | {'url': 'https://api.github.com/repos/facebook/react/issues/18942/reactions', 'total_count': 4, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 4} | https://api.github.com/repos/facebook/react/issues/18942/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18941 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18941/labels{/name} | https://api.github.com/repos/facebook/react/issues/18941/comments | https://api.github.com/repos/facebook/react/issues/18941/events | https://github.com/facebook/react/issues/18941 | 619,689,796 | MDU6SXNzdWU2MTk2ODk3OTY= | 18,941 | Bug: SyntaxError when trying to import named exports from "react" | {'login': 'wereHamster', 'id': 34538, 'node_id': 'MDQ6VXNlcjM0NTM4', 'avatar_url': 'https://avatars.githubusercontent.com/u/34538?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/wereHamster', 'html_url': 'https://github.com/wereHamster', 'followers_url': 'https://api.github.com/users/wereHamster/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I am not sure about `.mjs` file but I don't think that's how you run a react app. ",
"It seems ES modules are expected.\r\n\r\nReact is officially not shipped as ES modules yet.\r\nhttps://github.com/facebook/react/issues/11503\r\n\r\nYou could try this.\r\n\r\n```\r\nimport React from \"react\";\r\nconst { useS... | 2020-05-17 12:26:00 | 2020-08-23 11:46:55 | 2020-08-23 11:46:55 | NONE | null | null | null | React version: 16.13.1
## Steps To Reproduce
```
import React, { useState } from "react";
console.log(React, useState)
```
The import declaration is taken straight from the hooks documentation (https://reactjs.org/docs/hooks-intro.html), hence why I expected it to work.
Save as bug.mjs, run with `node bu... | {'url': 'https://api.github.com/repos/facebook/react/issues/18941/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18941/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18940 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18940/labels{/name} | https://api.github.com/repos/facebook/react/issues/18940/comments | https://api.github.com/repos/facebook/react/issues/18940/events | https://github.com/facebook/react/issues/18940 | 619,680,574 | MDU6SXNzdWU2MTk2ODA1NzQ= | 18,940 | Feature Request: <input type="textarea" .../> | {'login': 'JasonWoof', 'id': 31515, 'node_id': 'MDQ6VXNlcjMxNTE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/31515?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JasonWoof', 'html_url': 'https://github.com/JasonWoof', 'followers_url': 'https://api.github.com/users/JasonWoof/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I think React follow the HTML spec. regarding the input types.\r\nhttps://html.spec.whatwg.org/multipage/input.html#attr-input-type\r\n\r\nThere is no such thing as `<input type=\"textarea\"`",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** ... | 2020-05-17 11:41:47 | 2024-04-10 17:03:47 | 2024-04-10 17:03:46 | NONE | null | null | null | I'm delighted that you made it so `<textarea>` can take `value=` and `defaultValue=...` but what I really want is `<input type="textarea">`.
That would make this use case more fun:
<input type={field.type} ...
No explanation necessary if you decide not to implement this. I've already made a wrapper class t... | {'url': 'https://api.github.com/repos/facebook/react/issues/18940/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18940/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/18939 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18939/labels{/name} | https://api.github.com/repos/facebook/react/issues/18939/comments | https://api.github.com/repos/facebook/react/issues/18939/events | https://github.com/facebook/react/pull/18939 | 619,626,684 | MDExOlB1bGxSZXF1ZXN0NDE5MDcwNTI4 | 18,939 | Enable Context Menu on Chrome to inspect React Component | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Hi @asheshvidyut7! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing o... | 2020-05-17 06:52:55 | 2022-01-09 08:42:00 | 2022-01-09 08:42:00 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18939', 'html_url': 'https://github.com/facebook/react/pull/18939', 'diff_url': 'https://github.com/facebook/react/pull/18939.diff', 'patch_url': 'https://github.com/facebook/react/pull/18939.patch', 'merged_at': None} | Towards https://github.com/facebook/react/issues/18822
This PR adds a context menu on chrome. Clicking on the menu, react component is selected on Components tab.
It is my first PR, will need guidance.
![TrimmedVideo](https://user-images.githubusercontent.com/19382572/82529980-cfdd4180-9b59-11ea-93fa-acd98... | {'url': 'https://api.github.com/repos/facebook/react/issues/18939/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18939/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18938 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18938/labels{/name} | https://api.github.com/repos/facebook/react/issues/18938/comments | https://api.github.com/repos/facebook/react/issues/18938/events | https://github.com/facebook/react/issues/18938 | 619,461,755 | MDU6SXNzdWU2MTk0NjE3NTU= | 18,938 | Feature proposal: let class component setState second param callback always give the latest state | {'login': 'fantasticsoul', 'id': 7334950, 'node_id': 'MDQ6VXNlcjczMzQ5NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7334950?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fantasticsoul', 'html_url': 'https://github.com/fantasticsoul', 'followers_url': 'https://api.github.com/users/fantast... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"React tends to not add more than one way to do something if the existing way is already clear and works well. I would say that this.state is quite straightforward and mirrors how you would always access state in a class component (so it’s one less thing to learn). One other minor issue I see with your proposal is ... | 2020-05-16 12:25:52 | 2020-05-21 10:15:54 | 2020-05-17 05:18:56 | NONE | null | null | null | ## Context
I know setState first param can be a updater
```
(state, props)=> stateChanged;
```
but why not the second callback param can not supply the latest state in its param list.
```
this.setState({msg:'new msg'}, (newState)=>{
console.log(newState);// let user no need to write this.state here
})
```... | {'url': 'https://api.github.com/repos/facebook/react/issues/18938/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18938/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18937 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18937/labels{/name} | https://api.github.com/repos/facebook/react/issues/18937/comments | https://api.github.com/repos/facebook/react/issues/18937/events | https://github.com/facebook/react/issues/18937 | 619,403,642 | MDU6SXNzdWU2MTk0MDM2NDI= | 18,937 | Bug: eslint exhaustive-deps doesn't recognize JSXIdentifier as used | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Duplicate', 'name': 'Resolution: Duplicate', 'color': 'cccccc', 'default': False, 'description': None}
{'id': 1249821345, 'node_id': 'MDU6TGFiZWwxMjQ5ODIxMzQ1', 'url': 'https://api.github.c... | closed | false | null | [] | null | [
"Can I pick this up? ",
"@sophiebits would what you're doing not be better solved by `React.memo()` instead?\r\n\r\n```jsx\r\nconst Child = React.memo(() => <Report />)\r\n```\r\n\r\nhttps://reactjs.org/docs/react-api.html#reactmemo",
"@yanneves Not quite. See the second code example in https://reactjs.org/docs... | 2020-05-16 07:29:03 | 2020-08-29 15:03:11 | 2020-08-29 15:03:04 | COLLABORATOR | null | null | null | ```
function Component({reportType}) {
let Report = Reports[reportType];
let child = useMemo(() => {
return <Report />;
}, [Report]);
```
says that `Report` is an unnecessary dependency. It's not.
This is because eslint scope `.references` does not include JSX. I _suspect_ if you pull in
https:... | {'url': 'https://api.github.com/repos/facebook/react/issues/18937/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18937/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18936 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18936/labels{/name} | https://api.github.com/repos/facebook/react/issues/18936/comments | https://api.github.com/repos/facebook/react/issues/18936/events | https://github.com/facebook/react/issues/18936 | 619,398,670 | MDU6SXNzdWU2MTkzOTg2NzA= | 18,936 | Make mandatory to pass initial state in React.useState | {'login': 'acagastya', 'id': 5466083, 'node_id': 'MDQ6VXNlcjU0NjYwODM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5466083?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acagastya', 'html_url': 'https://github.com/acagastya', 'followers_url': 'https://api.github.com/users/acagastya/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I don't think mandatory would be proper. Warning feels like okay though.",
"@TodorTotev if it is not explicitly stated, it is taken as `undefined`. Developers can manually set `undefined`. But it would be a breaking change. Other than that, I don't see a reason why that should be a problem -- But I welcome th... | 2020-05-16 07:02:03 | 2020-09-05 20:10:12 | 2020-09-05 20:10:12 | NONE | null | null | null | Right now, it is possible to use hooks in order to set state for functional components as follows:
```js
function Foo() {
const [state, setState] = React.useState();
}
```
There is no parameter passed to `useState` above. If it is blank, React assumes it is `undefined`. I think it would be an improvement to m... | {'url': 'https://api.github.com/repos/facebook/react/issues/18936/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18936/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18935 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18935/labels{/name} | https://api.github.com/repos/facebook/react/issues/18935/comments | https://api.github.com/repos/facebook/react/issues/18935/events | https://github.com/facebook/react/issues/18935 | 619,396,684 | MDU6SXNzdWU2MTkzOTY2ODQ= | 18,935 | DevTools: Uncaught error doesn't go away on page refresh | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"DevTools persists profiling data between page reloads, because it can be annoying for it to disappear if e.g. HMR causes the page to reload while you were looking at a trace. In the case of, #18934, it sounds like something about your profiling data is corrupt. (Don't know what since I don't know how to repro the ... | 2020-05-16 06:51:01 | 2020-05-21 18:21:23 | 2020-05-21 18:21:23 | COLLABORATOR | null | null | null | 1. Wait for devtools to hit an error (eg: #18934).
2. Reload the page.
Expected: Devtools reinitializes cleanly.
Actual: Error is still there. Need to hide devtools, reload _again_, then show devtools to get it to behave.
DevTools version: 4.6.0-6cceaeb67
| {'url': 'https://api.github.com/repos/facebook/react/issues/18935/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18935/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18934 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18934/labels{/name} | https://api.github.com/repos/facebook/react/issues/18934/comments | https://api.github.com/repos/facebook/react/issues/18934/events | https://github.com/facebook/react/issues/18934 | 619,394,091 | MDU6SXNzdWU2MTkzOTQwOTE= | 18,934 | DevTools profiler: Error: "Cannot read property 'concat' of undefined" | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"I have tried to reproduce several times but no profiler crashing so far on my side",
"4.6.0-6cceaeb67 was built back in March. I've added a few Profiler bug fixes recently that might potentially address this. If you can repro the issue (#18934) would you be willing to try it with an updated build (from master)?\... | 2020-05-16 06:33:24 | 2020-05-19 21:17:21 | 2020-05-19 21:17:21 | COLLABORATOR | null | null | null | Describe what you were doing when the bug occurred:
1. Loaded page.
2. Fast Refreshed.
3. Started profiler.
4. Stopped profiler. Crash.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.6.0-6cceaeb67
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18934/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18934/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18933 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18933/labels{/name} | https://api.github.com/repos/facebook/react/issues/18933/comments | https://api.github.com/repos/facebook/react/issues/18933/events | https://github.com/facebook/react/pull/18933 | 619,216,990 | MDExOlB1bGxSZXF1ZXN0NDE4Nzg2Njcw | 18,933 | Warn if MutableSource snapshot is a function | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18933/builds/27000) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-15 20:13:37 | 2020-05-21 23:14:33 | 2020-05-21 23:14:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18933', 'html_url': 'https://github.com/facebook/react/pull/18933', 'diff_url': 'https://github.com/facebook/react/pull/18933.diff', 'patch_url': 'https://github.com/facebook/react/pull/18933.patch', 'merged_at': datetime.datetime(2020, 5, 21, 23, 14, 30)} | Resolves #18823; potential alternative of #18921.
`useMutableSource` does not properly support snapshots that are functions. In part this is because of how it is implemented internally (the function gets mistaken for a state updater function). To "fix" this we could just wrap another function around the returned sna... | {'url': 'https://api.github.com/repos/facebook/react/issues/18933/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18933/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18932 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18932/labels{/name} | https://api.github.com/repos/facebook/react/issues/18932/comments | https://api.github.com/repos/facebook/react/issues/18932/events | https://github.com/facebook/react/issues/18932 | 619,115,001 | MDU6SXNzdWU2MTkxMTUwMDE= | 18,932 | Bug: Event Capture may not work | {'login': 'JenniferFuBook', 'id': 54613999, 'node_id': 'MDQ6VXNlcjU0NjEzOTk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/54613999?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JenniferFuBook', 'html_url': 'https://github.com/JenniferFuBook', 'followers_url': 'https://api.github.com/users/Je... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This sounds like a consequence of how events currently work in React. The capture phase is emulated, and in practice they're registered in the bubble phase. We're switching it over to actually using the capture phase for captured events — so this should resolve itself in React 17. Thank you for reporting."
] | 2020-05-15 17:00:22 | 2020-07-24 19:26:42 | 2020-07-24 19:26:18 | NONE | null | null | null | In React document, it is stated that to register an event handler for the capture phase, append Capture to the event name. It works in normal case. But if the event's bubbling is stopped inside an iframe, the parent component will not be able to capture the event.
React version: 16.13.1
## Steps To Reproduce
1... | {'url': 'https://api.github.com/repos/facebook/react/issues/18932/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18932/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18931 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18931/labels{/name} | https://api.github.com/repos/facebook/react/issues/18931/comments | https://api.github.com/repos/facebook/react/issues/18931/events | https://github.com/facebook/react/pull/18931 | 619,108,585 | MDExOlB1bGxSZXF1ZXN0NDE4Njk2NzAw | 18,931 | Update inaccurate mapChildren comment | {'login': 'rickyvetter', 'id': 4370652, 'node_id': 'MDQ6VXNlcjQzNzA2NTI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4370652?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rickyvetter', 'html_url': 'https://github.com/rickyvetter', 'followers_url': 'https://api.github.com/users/rickyvetter/f... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against bbda3d9c9eb... | 2020-05-15 16:49:15 | 2022-11-29 22:21:50 | 2020-05-15 17:05:09 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18931', 'html_url': 'https://github.com/facebook/react/pull/18931', 'diff_url': 'https://github.com/facebook/react/pull/18931.diff', 'patch_url': 'https://github.com/facebook/react/pull/18931.patch', 'merged_at': datetime.datetime(2020, 5, 15, 17, 5, 9)} | The function you provide will only be passed a child and an index. It will not be passed a key. This is confirmed in the source, the Flow types, and the jsdoc comments.
## Summary
I was actually looking for a child map api that would expose keys and noticed this comment. It gave me the wrong impression and took a... | {'url': 'https://api.github.com/repos/facebook/react/issues/18931/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18931/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18930 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18930/labels{/name} | https://api.github.com/repos/facebook/react/issues/18930/comments | https://api.github.com/repos/facebook/react/issues/18930/events | https://github.com/facebook/react/issues/18930 | 618,889,053 | MDU6SXNzdWU2MTg4ODkwNTM= | 18,930 | Bug: eslint-react-hooks asking (exhaustive-deps) asking for the full object instead of the property that is being used on useEffect | {'login': 'cbdeveloper', 'id': 43407798, 'node_id': 'MDQ6VXNlcjQzNDA3Nzk4', 'avatar_url': 'https://avatars.githubusercontent.com/u/43407798?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cbdeveloper', 'html_url': 'https://github.com/cbdeveloper', 'followers_url': 'https://api.github.com/users/cbdeveloper... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I also have this behavior since upgrading to \"eslint-plugin-react-hooks\": \"4.0.2\", from version 4.0.0.\r\n\r\nIn my case:\r\n```js \r\nuseEffect(() => {\r\n const newSelectedVersion = globalPackage?.version || globalPackage?.versions[0].version;\r\n setSelectedVersion(newSelectedVersion);\r\n }, [global... | 2020-05-15 11:10:25 | 2022-11-17 14:13:03 | 2020-07-27 16:01:14 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
```
"react": "^16.13.1",
"react-dom": "^16.13.1",
devDepe... | {'url': 'https://api.github.com/repos/facebook/react/issues/18930/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18930/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18929 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18929/labels{/name} | https://api.github.com/repos/facebook/react/issues/18929/comments | https://api.github.com/repos/facebook/react/issues/18929/events | https://github.com/facebook/react/issues/18929 | 618,875,906 | MDU6SXNzdWU2MTg4NzU5MDY= | 18,929 | Bug: State of hooks not refreshing automatically in React DevTools | {'login': 'mysticaltech', 'id': 518555, 'node_id': 'MDQ6VXNlcjUxODU1NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/518555?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mysticaltech', 'html_url': 'https://github.com/mysticaltech', 'followers_url': 'https://api.github.com/users/mysticaltech... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'mysticaltech', 'id': 518555.0, 'node_id': 'MDQ6VXNlcjUxODU1NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/518555?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mysticaltech', 'html_url': 'https://github.com/mysticaltech', 'followers_url': 'https://api.github.com/users/mysticalte... | [{'login': 'mysticaltech', 'id': 518555, 'node_id': 'MDQ6VXNlcjUxODU1NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/518555?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mysticaltech', 'html_url': 'https://github.com/mysticaltech', 'followers_url': 'https://api.github.com/users/mysticaltec... | null | [
"Turns out it was the useReducer hook causing this, working with useState instead solved the issue. This hook does not seem very stable to me! So for complex projects, redux remains is a must.",
"> Turns out it was the useReducer hook causing this, working with useState instead solved the issue. This hook does no... | 2020-05-15 10:46:23 | 2020-05-27 19:40:06 | 2020-05-27 19:40:06 | NONE | null | null | null | I am using useContext and useReducer. When I inspect the ContextProvider in DevTools I see the state correctly. But when it changes via a reducer, it is not automatically refreshed in the DevTools, I must select another node and come back to the ContextProvider for it to show the correctly updated value.
So the stat... | {'url': 'https://api.github.com/repos/facebook/react/issues/18929/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18929/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18928 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18928/labels{/name} | https://api.github.com/repos/facebook/react/issues/18928/comments | https://api.github.com/repos/facebook/react/issues/18928/events | https://github.com/facebook/react/pull/18928 | 618,822,172 | MDExOlB1bGxSZXF1ZXN0NDE4NDczNDk1 | 18,928 | Fix lazy not to throw undefined objects | {'login': 'b4h0-c4t', 'id': 22951237, 'node_id': 'MDQ6VXNlcjIyOTUxMjM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/22951237?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/b4h0-c4t', 'html_url': 'https://github.com/b4h0-c4t', 'followers_url': 'https://api.github.com/users/b4h0-c4t/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18928/builds/26887) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-15 09:15:49 | 2021-06-07 22:24:06 | 2021-06-07 22:24:05 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18928', 'html_url': 'https://github.com/facebook/react/pull/18928', 'diff_url': 'https://github.com/facebook/react/pull/18928.diff', 'patch_url': 'https://github.com/facebook/react/pull/18928.patch', 'merged_at': None} | ## Summary
fixed #18768
This issue has two problems.
### First problem
`React.lazy` did not perform an undefined check for `moduleObject`.
input
```js
const Async = lazy(async () => {});
```
current
```
Uncaught undefined
```
fixed
```
Warning: lazy: Expected the result of a dynamic import() call... | {'url': 'https://api.github.com/repos/facebook/react/issues/18928/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18928/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18927 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18927/labels{/name} | https://api.github.com/repos/facebook/react/issues/18927/comments | https://api.github.com/repos/facebook/react/issues/18927/events | https://github.com/facebook/react/pull/18927 | 618,737,261 | MDExOlB1bGxSZXF1ZXN0NDE4NDA2Njcx | 18,927 | Add MIT license to use-subscription package | {'login': 'GabrielePrestifilippo', 'id': 2738850, 'node_id': 'MDQ6VXNlcjI3Mzg4NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2738850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/GabrielePrestifilippo', 'html_url': 'https://github.com/GabrielePrestifilippo', 'followers_url': 'https://api.... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @GabrielePrestifilippo! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contri... | 2020-05-15 06:41:53 | 2020-05-15 22:36:49 | 2020-05-15 22:36:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18927', 'html_url': 'https://github.com/facebook/react/pull/18927', 'diff_url': 'https://github.com/facebook/react/pull/18927.diff', 'patch_url': 'https://github.com/facebook/react/pull/18927.patch', 'merged_at': datetime.datetime(2020, 5, 15, 22, 36, 49)} | ## Summary
This package is missing the license attribute (or a license file).
Being a sub-package of React, it should get the same license, however, none was specified.
A scan with `license_checker` would recognize this as `UNKNOWN`.
## Test Plan
_none_ | {'url': 'https://api.github.com/repos/facebook/react/issues/18927/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18927/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18926 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18926/labels{/name} | https://api.github.com/repos/facebook/react/issues/18926/comments | https://api.github.com/repos/facebook/react/issues/18926/events | https://github.com/facebook/react/issues/18926 | 618,483,576 | MDU6SXNzdWU2MTg0ODM1NzY= | 18,926 | Bug: eslint(react-hooks/exhaustive-deps) wrong deps with optional chained function calls | {'login': 'AviVahl', 'id': 8952081, 'node_id': 'MDQ6VXNlcjg5NTIwODE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8952081?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AviVahl', 'html_url': 'https://github.com/AviVahl', 'followers_url': 'https://api.github.com/users/AviVahl/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | true | null | [] | null | [
"I also have this behavior since upgrading to \"eslint-plugin-react-hooks\": \"4.0.2\", from version 4.0.0.\r\n\r\nIn my case:\r\n```js \r\nuseEffect(() => {\r\n const newSelectedVersion = globalPackage?.version || globalPackage?.versions[0].version;\r\n setSelectedVersion(newSelectedVersion);\r\n }, [global... | 2020-05-14 19:31:54 | 2020-07-07 21:43:42 | 2020-06-30 21:59:17 | NONE | resolved | null | null | React version: 16.13.1
## Steps To Reproduce
Every time optional chaining is used with a function call, the function itself is detected by the rule.
```js
// users is optional...
const someContext = {
users: Math.random() > 0.5 ? [{name: 'test'}] : undefined,
};
const filteredUsers = useMemo(() => {
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18926/reactions', 'total_count': 16, '+1': 16, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18926/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18925 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18925/labels{/name} | https://api.github.com/repos/facebook/react/issues/18925/comments | https://api.github.com/repos/facebook/react/issues/18925/events | https://github.com/facebook/react/pull/18925 | 618,449,337 | MDExOlB1bGxSZXF1ZXN0NDE4MTc1NjA5 | 18,925 | Add test for displayName on React.memo components | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18925/builds/27016) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-14 18:32:13 | 2020-05-25 04:30:43 | 2020-05-15 22:56:51 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18925', 'html_url': 'https://github.com/facebook/react/pull/18925', 'diff_url': 'https://github.com/facebook/react/pull/18925.diff', 'patch_url': 'https://github.com/facebook/react/pull/18925.patch', 'merged_at': datetime.datetime(2020, 5, 15, 22, 56, 51)} | ## Summary
Adds a test for display name behavior of
```js
const MemoComponent = React.memo(() => {});
MemoComponent.displayName = "SomeName";
```
The behavior was implemented in https://github.com/facebook/react/pull/18495/files#diff-ad60306adf3e53077dba1bbeabd57b19R30-R45<sup>1</sup> but untested. Commenting... | {'url': 'https://api.github.com/repos/facebook/react/issues/18925/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18925/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18924 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18924/labels{/name} | https://api.github.com/repos/facebook/react/issues/18924/comments | https://api.github.com/repos/facebook/react/issues/18924/events | https://github.com/facebook/react/issues/18924 | 618,218,428 | MDU6SXNzdWU2MTgyMTg0Mjg= | 18,924 | Error: "Could not find node with id "4557" in commit tree" | {'login': 'kalyan-k', 'id': 13449323, 'node_id': 'MDQ6VXNlcjEzNDQ5MzIz', 'avatar_url': 'https://avatars.githubusercontent.com/u/13449323?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kalyan-k', 'html_url': 'https://github.com/kalyan-k', 'followers_url': 'https://api.github.com/users/kalyan-k/followers',... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Can you share any sort of repro case with us?"
] | 2020-05-14 13:10:10 | 2020-10-15 18:45:24 | 2020-10-15 18:45:24 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Started profiling the application
2. Tried to stop it after couple of navigation and actions on spa, but failed to stop.
3. Finally clicking multiple times on Stop has stopped profiling, and got his issue in graph option
--------------------------------------... | {'url': 'https://api.github.com/repos/facebook/react/issues/18924/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18924/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18923 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18923/labels{/name} | https://api.github.com/repos/facebook/react/issues/18923/comments | https://api.github.com/repos/facebook/react/issues/18923/events | https://github.com/facebook/react/issues/18923 | 618,034,999 | MDU6SXNzdWU2MTgwMzQ5OTk= | 18,923 | Error: "Commit tree does not contain fiber 3661. This is a bug in React DevTools." | {'login': 'JoshWhite', 'id': 1931725, 'node_id': 'MDQ6VXNlcjE5MzE3MjU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1931725?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoshWhite', 'html_url': 'https://github.com/JoshWhite', 'followers_url': 'https://api.github.com/users/JoshWhite/followers... | [] | closed | false | null | [] | null | [
"If it's relevant, this console error is also present before using the profiler:\r\n```\r\nreact-dom.development.js:88 Warning: React instrumentation encountered an error: TypeError: Cannot read property 'memoizedState' of null\r\n```",
"@JoshWhite Can you reproduce this behavior? If so, would you be willing to t... | 2020-05-14 08:33:48 | 2020-07-13 17:17:28 | 2020-05-18 20:51:49 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Using Profiler tab
2. Clicked on a commit
3. It threw this error
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.6.0-6cceaeb67
Call stack: at... | {'url': 'https://api.github.com/repos/facebook/react/issues/18923/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18923/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18922 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18922/labels{/name} | https://api.github.com/repos/facebook/react/issues/18922/comments | https://api.github.com/repos/facebook/react/issues/18922/events | https://github.com/facebook/react/issues/18922 | 617,994,971 | MDU6SXNzdWU2MTc5OTQ5NzE= | 18,922 | Bug: eslint(react-hooks/exhaustive-deps) detection error | {'login': 'andyyxw', 'id': 41931722, 'node_id': 'MDQ6VXNlcjQxOTMxNzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/41931722?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/andyyxw', 'html_url': 'https://github.com/andyyxw', 'followers_url': 'https://api.github.com/users/andyyxw/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710722093, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"Hi there! There is no way for React to tell whether something is a `ref` or not. We use `.current` as a convention. The benefit of the convention outweighs the occasional false positives, like in this example. In this case we advise you rename the `current` property to something more descriptive, like `currentPage... | 2020-05-14 07:32:50 | 2020-07-27 16:08:27 | 2020-07-27 16:08:27 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.8.6
## Steps To Reproduce
1. I used a `current` prop of ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18922/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18922/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18921 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18921/labels{/name} | https://api.github.com/repos/facebook/react/issues/18921/comments | https://api.github.com/repos/facebook/react/issues/18921/events | https://github.com/facebook/react/pull/18921 | 617,988,181 | MDExOlB1bGxSZXF1ZXN0NDE3ODAxMzUx | 18,921 | useMutableSource: Allow returning function from getSnapshot | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18921/builds/26666) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-14 07:21:22 | 2020-08-16 13:40:01 | 2020-08-16 13:40:01 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18921', 'html_url': 'https://github.com/facebook/react/pull/18921', 'diff_url': 'https://github.com/facebook/react/pull/18921.diff', 'patch_url': 'https://github.com/facebook/react/pull/18921.patch', 'merged_at': None} | basicStateReducer strikes again. | {'url': 'https://api.github.com/repos/facebook/react/issues/18921/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18921/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18920 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18920/labels{/name} | https://api.github.com/repos/facebook/react/issues/18920/comments | https://api.github.com/repos/facebook/react/issues/18920/events | https://github.com/facebook/react/pull/18920 | 617,983,962 | MDExOlB1bGxSZXF1ZXN0NDE3Nzk4MDQx | 18,920 | Simplify logic for mutable workInProgressSources | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18920/builds/26665) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-14 07:13:59 | 2020-05-14 21:30:45 | 2020-05-14 21:30:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18920', 'html_url': 'https://github.com/facebook/react/pull/18920', 'diff_url': 'https://github.com/facebook/react/pull/18920.diff', 'patch_url': 'https://github.com/facebook/react/pull/18920.patch', 'merged_at': datetime.datetime(2020, 5, 14, 21, 30, 45)} | isPrimaryRenderer is always constant for a given React build, so these two arrays do nothing.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18920/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18920/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18919 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18919/labels{/name} | https://api.github.com/repos/facebook/react/issues/18919/comments | https://api.github.com/repos/facebook/react/issues/18919/events | https://github.com/facebook/react/pull/18919 | 617,937,413 | MDExOlB1bGxSZXF1ZXN0NDE3NzYxNDY0 | 18,919 | Add LegacyHidden to server renderer | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18919/builds/26661) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-14 05:33:28 | 2020-05-14 18:28:12 | 2020-05-14 18:28:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18919', 'html_url': 'https://github.com/facebook/react/pull/18919', 'diff_url': 'https://github.com/facebook/react/pull/18919.diff', 'patch_url': 'https://github.com/facebook/react/pull/18919.patch', 'merged_at': datetime.datetime(2020, 5, 14, 18, 28, 11)} | I think this makes sense, but not entirely sure.
When the tree is hidden, the server renderer renders nothing. The contents will be completely client rendered.
When the tree is visible it acts like a fragment.
The future streaming server renderer may want to pre-render these trees and send them down in chunks,... | {'url': 'https://api.github.com/repos/facebook/react/issues/18919/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18919/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18918 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18918/labels{/name} | https://api.github.com/repos/facebook/react/issues/18918/comments | https://api.github.com/repos/facebook/react/issues/18918/events | https://github.com/facebook/react/pull/18918 | 617,867,433 | MDExOlB1bGxSZXF1ZXN0NDE3NzA1MjMw | 18,918 | fix: issue #18908 | {'login': 'guluarte', 'id': 197089, 'node_id': 'MDQ6VXNlcjE5NzA4OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/197089?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/guluarte', 'html_url': 'https://github.com/guluarte', 'followers_url': 'https://api.github.com/users/guluarte/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @guluarte! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beh... | 2020-05-14 02:01:59 | 2020-08-23 07:46:53 | 2020-08-23 07:46:53 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18918', 'html_url': 'https://github.com/facebook/react/pull/18918', 'diff_url': 'https://github.com/facebook/react/pull/18918.diff', 'patch_url': 'https://github.com/facebook/react/pull/18918.patch', 'merged_at': None} | Changes REACT_FRAGMENT_TYPE to React.Fragment
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, plea... | {'url': 'https://api.github.com/repos/facebook/react/issues/18918/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18918/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18917 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18917/labels{/name} | https://api.github.com/repos/facebook/react/issues/18917/comments | https://api.github.com/repos/facebook/react/issues/18917/events | https://github.com/facebook/react/pull/18917 | 617,866,757 | MDExOlB1bGxSZXF1ZXN0NDE3NzA0NzQ4 | 18,917 | Disable <div hidden /> API in old fork, too | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18917/builds/26643) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-14 02:00:06 | 2020-05-14 03:01:11 | 2020-05-14 03:01:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18917', 'html_url': 'https://github.com/facebook/react/pull/18917', 'diff_url': 'https://github.com/facebook/react/pull/18917.diff', 'patch_url': 'https://github.com/facebook/react/pull/18917.patch', 'merged_at': datetime.datetime(2020, 5, 14, 3, 1, 11)} | The motivation for doing this is to make it impossible for additional uses of pre-rendering to sneak into www without going through the LegacyHidden abstraction. Since this feature was already disabled in the new fork, this brings the two closer to parity.
The LegacyHidden abstraction itself still needs to opt into ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18917/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/18917/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18916 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18916/labels{/name} | https://api.github.com/repos/facebook/react/issues/18916/comments | https://api.github.com/repos/facebook/react/issues/18916/events | https://github.com/facebook/react/issues/18916 | 617,865,861 | MDU6SXNzdWU2MTc4NjU4NjE= | 18,916 | Multiple ReactDOM.render() calls - Site Mirroring. | {'login': 'Cryptonex7', 'id': 34197902, 'node_id': 'MDQ6VXNlcjM0MTk3OTAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/34197902?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Cryptonex7', 'html_url': 'https://github.com/Cryptonex7', 'followers_url': 'https://api.github.com/users/Cryptonex7/fol... | [{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Stale', 'name': 'Resolution: Stale', 'color': 'e6e6e6', 'default': False, 'description': 'Automatically closed due to inactivity'}] | closed | false | null | [] | null | [
"I can give some answers. From my point of view :)\r\n\r\n<br/>\r\n\r\n> A way to link independent ReactDOM instances.\r\n\r\nMy approach would be store the state externally. Instead of using `useState` we could use a store. All DOM updates must be driven from update in the store.\r\n`UI interaction -> update store... | 2020-05-14 01:57:25 | 2020-08-29 19:48:24 | 2020-08-29 19:48:24 | NONE | null | null | null | ## I am trying to twin my app on the same screen as follows:
## I want to achieve this using a separate ReactDOM like so:
![image](https://user-images.githubusercontent.com/34197902/81883631-5c648e80-95b3... | {'url': 'https://api.github.com/repos/facebook/react/issues/18916/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18916/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18915 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18915/labels{/name} | https://api.github.com/repos/facebook/react/issues/18915/comments | https://api.github.com/repos/facebook/react/issues/18915/events | https://github.com/facebook/react/issues/18915 | 617,856,368 | MDU6SXNzdWU2MTc4NTYzNjg= | 18,915 | Bug: using useCallback and useEffect at the same time messed my ref | {'login': 'robertwt7', 'id': 15647967, 'node_id': 'MDQ6VXNlcjE1NjQ3OTY3', 'avatar_url': 'https://avatars.githubusercontent.com/u/15647967?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/robertwt7', 'html_url': 'https://github.com/robertwt7', 'followers_url': 'https://api.github.com/users/robertwt7/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You may want to review the useRef docs again. To store data in a ref across renders, you should assign to the .current property (i.e. `sigPad.current = ...` not `sigPad = ...`). You likely want just `ref={sigPad}` on SignatureCanvas which does essentially the same thing. Then read from sigPad.current to get the ac... | 2020-05-14 01:25:46 | 2020-05-14 01:50:29 | 2020-05-14 01:38:03 | NONE | null | null | null | Hey Guys,
I created a [SignaturePad](https://github.com/agilgur5/react-signature-canvas) for my application that will pass the value later on to Formik. What I'm trying to do is to get the data from canvas and save it to my state using ref. `toData()` function returns array of points from the signature canvas.
`ha... | {'url': 'https://api.github.com/repos/facebook/react/issues/18915/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18915/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18914 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18914/labels{/name} | https://api.github.com/repos/facebook/react/issues/18914/comments | https://api.github.com/repos/facebook/react/issues/18914/events | https://github.com/facebook/react/pull/18914 | 617,810,185 | MDExOlB1bGxSZXF1ZXN0NDE3NjU4Njky | 18,914 | Add expando prop to disabledLog function | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18914/builds/26625) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-13 23:08:20 | 2020-05-14 00:03:54 | 2020-05-14 00:03:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18914', 'html_url': 'https://github.com/facebook/react/pull/18914', 'diff_url': 'https://github.com/facebook/react/pull/18914.diff', 'patch_url': 'https://github.com/facebook/react/pull/18914.patch', 'merged_at': datetime.datetime(2020, 5, 14, 0, 3, 51)} | This will enable it to be identified by Facebook infra even if the function name is mangled during DevTools build process. | {'url': 'https://api.github.com/repos/facebook/react/issues/18914/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18914/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18913 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18913/labels{/name} | https://api.github.com/repos/facebook/react/issues/18913/comments | https://api.github.com/repos/facebook/react/issues/18913/events | https://github.com/facebook/react/pull/18913 | 617,686,076 | MDExOlB1bGxSZXF1ZXN0NDE3NTU1NTE0 | 18,913 | Profiler: Skip reading element for imported data | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18913/builds/26974) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-13 19:07:46 | 2020-05-15 17:38:02 | 2020-05-15 17:38:02 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18913', 'html_url': 'https://github.com/facebook/react/pull/18913', 'diff_url': 'https://github.com/facebook/react/pull/18913.diff', 'patch_url': 'https://github.com/facebook/react/pull/18913.patch', 'merged_at': datetime.datetime(2020, 5, 15, 17, 38, 1)} | I've also replaced `export` to `import` in some places where the data is _imported_ actually (was the word `export` in those places used intentionally?) | {'url': 'https://api.github.com/repos/facebook/react/issues/18913/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18913/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18912 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18912/labels{/name} | https://api.github.com/repos/facebook/react/issues/18912/comments | https://api.github.com/repos/facebook/react/issues/18912/events | https://github.com/facebook/react/pull/18912 | 617,682,374 | MDExOlB1bGxSZXF1ZXN0NDE3NTUyNjQ4 | 18,912 | Fix useMutableSource tearing bug | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18912/builds/26597) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-13 19:01:55 | 2020-05-13 21:28:18 | 2020-05-13 21:28:18 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18912', 'html_url': 'https://github.com/facebook/react/pull/18912', 'diff_url': 'https://github.com/facebook/react/pull/18912.diff', 'patch_url': 'https://github.com/facebook/react/pull/18912.patch', 'merged_at': datetime.datetime(2020, 5, 13, 21, 28, 18)} | If a source is mutated after initial read but before subscription is set up, it should still entangle all pending mutations even if snapshot of new subscription happens to match.
Test case illustrates how not doing this can lead to tearing.
The fix is to move the entanglement call outside of the block that checks... | {'url': 'https://api.github.com/repos/facebook/react/issues/18912/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18912/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18911 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18911/labels{/name} | https://api.github.com/repos/facebook/react/issues/18911/comments | https://api.github.com/repos/facebook/react/issues/18911/events | https://github.com/facebook/react/issues/18911 | 617,660,548 | MDU6SXNzdWU2MTc2NjA1NDg= | 18,911 | React Dev tools Not Working For My project | {'login': 'Moizasif', 'id': 42133954, 'node_id': 'MDQ6VXNlcjQyMTMzOTU0', 'avatar_url': 'https://avatars.githubusercontent.com/u/42133954?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Moizasif', 'html_url': 'https://github.com/Moizasif', 'followers_url': 'https://api.github.com/users/Moizasif/followers',... | [] | closed | false | null | [] | null | [] | 2020-05-13 18:25:01 | 2020-05-18 20:46:09 | 2020-05-18 20:46:09 | NONE | null | null | null | 👉 Please follow one of these issue templates:
- https://github.com/facebook/react/issues/new/choose
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18911/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18911/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18910 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18910/labels{/name} | https://api.github.com/repos/facebook/react/issues/18910/comments | https://api.github.com/repos/facebook/react/issues/18910/events | https://github.com/facebook/react/issues/18910 | 617,607,774 | MDU6SXNzdWU2MTc2MDc3NzQ= | 18,910 | React developer tool doesn't show in Chromium based Edge in Windows | {'login': 'ulagapandi2upms', 'id': 42641574, 'node_id': 'MDQ6VXNlcjQyNjQxNTc0', 'avatar_url': 'https://avatars.githubusercontent.com/u/42641574?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ulagapandi2upms', 'html_url': 'https://github.com/ulagapandi2upms', 'followers_url': 'https://api.github.com/users... | [] | closed | false | null | [] | null | [
"I can find it here. I used Edge version 81.\r\n\r\n\r\n\r\n\r\n",
"First, make sure you've installed the Edge build of the extension:\r\nhttps://microsoftedge.microsoft.com/addons/detail/gpphkfbcpidddadnk... | 2020-05-13 16:58:25 | 2020-05-18 20:47:49 | 2020-05-18 20:47:49 | NONE | null | null | null | I've using chromium-based Microsoft edge. This react developer tool doesn't show in profiler page.
I can't find react developer tool in my browser
| {'url': 'https://api.github.com/repos/facebook/react/issues/18910/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18910/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18909 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18909/labels{/name} | https://api.github.com/repos/facebook/react/issues/18909/comments | https://api.github.com/repos/facebook/react/issues/18909/events | https://github.com/facebook/react/pull/18909 | 617,569,981 | MDExOlB1bGxSZXF1ZXN0NDE3NDYwOTkz | 18,909 | Update README | {'login': 'kenshin1215', 'id': 15134707, 'node_id': 'MDQ6VXNlcjE1MTM0NzA3', 'avatar_url': 'https://avatars.githubusercontent.com/u/15134707?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kenshin1215', 'html_url': 'https://github.com/kenshin1215', 'followers_url': 'https://api.github.com/users/kenshin1215... | [] | closed | false | null | [] | null | [
"Hi @kenshin1215! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on ... | 2020-05-13 16:02:16 | 2020-05-15 22:44:21 | 2020-05-15 22:44:20 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18909', 'html_url': 'https://github.com/facebook/react/pull/18909', 'diff_url': 'https://github.com/facebook/react/pull/18909.diff', 'patch_url': 'https://github.com/facebook/react/pull/18909.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18909/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18909/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18908 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18908/labels{/name} | https://api.github.com/repos/facebook/react/issues/18908/comments | https://api.github.com/repos/facebook/react/issues/18908/events | https://github.com/facebook/react/issues/18908 | 617,522,365 | MDU6SXNzdWU2MTc1MjIzNjU= | 18,908 | Show better warning when <React.Fragment> is missing a key | {'login': 'jtrost', 'id': 1156272, 'node_id': 'MDQ6VXNlcjExNTYyNzI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1156272?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jtrost', 'html_url': 'https://github.com/jtrost', 'followers_url': 'https://api.github.com/users/jtrost/followers', 'followin... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-05-13 14:59:21 | 2024-04-10 17:03:48 | 2024-04-10 17:03:47 | NONE | null | null | null | React version: 16.9.0
## Steps To Reproduce
1. Take an array of data, and render each item inside of `<React.Fragment></React.Fragment>`
2. Load the page to and see the topmost line in the backtrace: `in Fragment (at App.js:6)`
Link to code example: https://codesandbox.io/s/icy-rgb-wyuyk?file=/src/App.js
#... | {'url': 'https://api.github.com/repos/facebook/react/issues/18908/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18908/timeline | null | not_planned | false |
https://api.github.com/repos/facebook/react/issues/18907 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18907/labels{/name} | https://api.github.com/repos/facebook/react/issues/18907/comments | https://api.github.com/repos/facebook/react/issues/18907/events | https://github.com/facebook/react/pull/18907 | 617,503,675 | MDExOlB1bGxSZXF1ZXN0NDE3NDA3MjM4 | 18,907 | [eslint-plugin-react-hooks] useWithoutEffectSuffix fix (#18902) | {'login': 'surgeboris', 'id': 21183294, 'node_id': 'MDQ6VXNlcjIxMTgzMjk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/21183294?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/surgeboris', 'html_url': 'https://github.com/surgeboris', 'followers_url': 'https://api.github.com/users/surgeboris/fol... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18907/builds/26554) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-13 14:36:54 | 2020-05-14 13:42:06 | 2020-05-13 15:44:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18907', 'html_url': 'https://github.com/facebook/react/pull/18907', 'diff_url': 'https://github.com/facebook/react/pull/18907.diff', 'patch_url': 'https://github.com/facebook/react/pull/18907.patch', 'merged_at': datetime.datetime(2020, 5, 13, 15, 44, 6)} | ## Summary
Due to [a bug](https://github.com/facebook/react/issues/18902) `react-hooks/exhaustive-deps` currently warns whenever name contains `-Effect-` (even if it does NOT contain it as a suffix).
Since we only reserve `-Effect` suffix, react-hooks/exhaustive-deps is
expected to succeed without warning on a ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18907/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18907/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18906 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18906/labels{/name} | https://api.github.com/repos/facebook/react/issues/18906/comments | https://api.github.com/repos/facebook/react/issues/18906/events | https://github.com/facebook/react/issues/18906 | 617,492,031 | MDU6SXNzdWU2MTc0OTIwMzE= | 18,906 | Bug: IE11 with Suspense doesn't support direct child with inline display: flex style | {'login': 'AdrianoRuberto', 'id': 17402643, 'node_id': 'MDQ6VXNlcjE3NDAyNjQz', 'avatar_url': 'https://avatars.githubusercontent.com/u/17402643?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AdrianoRuberto', 'html_url': 'https://github.com/AdrianoRuberto', 'followers_url': 'https://api.github.com/users/Ad... | [{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Needs%20Investigation', 'name': 'Type: Needs Investigation', 'color': '65AA9C', 'default': False, 'description': ''}
{'id': 1109407645, 'node_id': 'MDU6TGFiZWwxMTA5NDA3NjQ1', 'url': 'https://api... | closed | false | null | [] | null | [
"Any hunch as to why IE behavior is different?\r\n",
"No, but with an older version (I tried with version 11.0.9600), it work like a charm.\r\n\r\nIt's not the first time that IE11 make me frown.\r\n\r\nMaybe the inline style doesn't work the same with IE11 than the others browsers ?",
"I'm experiencing this ex... | 2020-05-13 14:22:39 | 2022-03-30 00:42:51 | 2022-03-30 00:42:51 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
If the direct children of `<React.Suspense />` have an inline `display: flex` st... | {'url': 'https://api.github.com/repos/facebook/react/issues/18906/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18906/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18905 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18905/labels{/name} | https://api.github.com/repos/facebook/react/issues/18905/comments | https://api.github.com/repos/facebook/react/issues/18905/events | https://github.com/facebook/react/issues/18905 | 617,396,154 | MDU6SXNzdWU2MTczOTYxNTQ= | 18,905 | Bug: onSubmit doesn't contains an event param | {'login': 'EnetoJara', 'id': 24560394, 'node_id': 'MDQ6VXNlcjI0NTYwMzk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/24560394?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/EnetoJara', 'html_url': 'https://github.com/EnetoJara', 'followers_url': 'https://api.github.com/users/EnetoJara/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"What browser do you use? I can't reproduce it with browser, and your `codepen` works fine; @EnetoJara ",
"chrome: \r\n\r\n\r\nfirefox: \r\n {
super(props);
this.state = {value: 'coconut'};
this.handleChange = this.handleChange.bind(this);
thi... | {'url': 'https://api.github.com/repos/facebook/react/issues/18905/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18905/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18904 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18904/labels{/name} | https://api.github.com/repos/facebook/react/issues/18904/comments | https://api.github.com/repos/facebook/react/issues/18904/events | https://github.com/facebook/react/pull/18904 | 617,362,583 | MDExOlB1bGxSZXF1ZXN0NDE3MjkzMTg4 | 18,904 | React Flare: fix PressLegacy preventDefault issue | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18904/builds/26513) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-13 11:16:52 | 2020-05-31 04:10:01 | 2020-05-13 12:59:33 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18904', 'html_url': 'https://github.com/facebook/react/pull/18904', 'diff_url': 'https://github.com/facebook/react/pull/18904.diff', 'patch_url': 'https://github.com/facebook/react/pull/18904.patch', 'merged_at': datetime.datetime(2020, 5, 13, 12, 59, 33)} | We recently uncovered a bug in the PressLegacy responder in React Flare. @necolas found a bug that occurs because we call `preventDefault` for `Enter` key presses. We should have only been doing this for `Space` key presses, otherwise it means we never get a corresponding `click` fire, because calling `preventDefault` ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18904/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18904/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18903 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18903/labels{/name} | https://api.github.com/repos/facebook/react/issues/18903/comments | https://api.github.com/repos/facebook/react/issues/18903/events | https://github.com/facebook/react/issues/18903 | 617,339,929 | MDU6SXNzdWU2MTczMzk5Mjk= | 18,903 | Error: "Commit tree does not contain fiber 97. This is a bug in React DevTools." | {'login': 'tarto-dev', 'id': 1745200, 'node_id': 'MDQ6VXNlcjE3NDUyMDA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1745200?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tarto-dev', 'html_url': 'https://github.com/tarto-dev', 'followers_url': 'https://api.github.com/users/tarto-dev/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | null | [] | null | [
"Possible duplicate of https://github.com/facebook/react/issues/18859",
"Yep, seems duplicate",
"Going to close this as a duplicate of #18831",
"@benftwc This error remains the highest reported DevTools bug but we still don't have a repro case so that I can fix it. Do you remember how to repro the error you ... | 2020-05-13 10:39:40 | 2021-04-28 20:30:44 | 2020-05-18 20:49:53 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Open the Profiler after playing a while with some React Application
2. Try to reach some snap with the player
3. This happens
---------------------------------------------
Please do not remove the text below this line
---------------------------------------... | {'url': 'https://api.github.com/repos/facebook/react/issues/18903/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18903/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18902 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18902/labels{/name} | https://api.github.com/repos/facebook/react/issues/18902/comments | https://api.github.com/repos/facebook/react/issues/18902/events | https://github.com/facebook/react/issues/18902 | 617,195,520 | MDU6SXNzdWU2MTcxOTU1MjA= | 18,902 | [eslint-plugin-react-hooks] Bug: warning on `useWithoutEffectSuffix` | {'login': 'surgeboris', 'id': 21183294, 'node_id': 'MDQ6VXNlcjIxMTgzMjk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/21183294?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/surgeboris', 'html_url': 'https://github.com/surgeboris', 'followers_url': 'https://api.github.com/users/surgeboris/fol... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 1249821345, 'node_id': 'MDU6TGFiZWwxMjQ5ODIxMzQ1', 'url': 'https://api.github.com/repos/facebook/react/... | closed | false | null | [] | null | [
"Would you like to submit a failing test case and/or a fix? You can search for `ExhaustiveDeps-test.js` in the codebase. That would be very helpful!",
"Appreciate you did the work! I was feeling a bit tired today and this was really nice."
] | 2020-05-13 07:00:10 | 2020-05-13 15:58:26 | 2020-05-13 15:57:14 | CONTRIBUTOR | null | null | null | With `eslint-plugin-react-hooks@4.0.1` I observe an unexpected warning
on `useWithoutEffectSuffix` hook call.
## Steps To Reproduce
1. yarn create react-app hooks-bug
2. cd hooks-bug
3. npm run eject
4. npm i eslint-plugin-react-hooks@4.0.1
5. place code from the examples below into `src/App.js`
6. run `npx... | {'url': 'https://api.github.com/repos/facebook/react/issues/18902/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18902/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18901 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18901/labels{/name} | https://api.github.com/repos/facebook/react/issues/18901/comments | https://api.github.com/repos/facebook/react/issues/18901/events | https://github.com/facebook/react/issues/18901 | 617,076,340 | MDU6SXNzdWU2MTcwNzYzNDA= | 18,901 | React.memo: consider keeping old props object reference when props don't change | {'login': 'Hypnosphi', 'id': 6651625, 'node_id': 'MDQ6VXNlcjY2NTE2MjU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6651625?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Hypnosphi', 'html_url': 'https://github.com/Hypnosphi', 'followers_url': 'https://api.github.com/users/Hypnosphi/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"The simplest workaround is to apply `React.memo` twice:\r\nhttps://codesandbox.io/s/nervous-night-h5rpg?file=/src/App.js\r\n\r\n```\r\nconst Child = React.memo(\r\n React.memo(function Child(props) {\r\n ...\r\n })\r\n);\r\n```",
"This issue has been automatically marked as stale. **If this issue is still a... | 2020-05-13 01:42:20 | 2020-08-23 07:46:57 | 2020-08-23 07:46:57 | CONTRIBUTOR | null | null | null | React version: 16.12.0
## Steps To Reproduce
1. Open https://codesandbox.io/s/cranky-germain-zc2cm?file=/src/App.js
2. Open console
3. Click "Update parent", then "Update child"
## The current behavior
Additional "UPDATE PROPS" is logged
## The expected behavior
No additional "UPDATE PROPS" is logged
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18901/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18901/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18900 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18900/labels{/name} | https://api.github.com/repos/facebook/react/issues/18900/comments | https://api.github.com/repos/facebook/react/issues/18900/events | https://github.com/facebook/react/pull/18900 | 617,036,798 | MDExOlB1bGxSZXF1ZXN0NDE3MDMyNjAw | 18,900 | Fix rollup validate script | {'login': 'koba04', 'id': 250407, 'node_id': 'MDQ6VXNlcjI1MDQwNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/250407?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/koba04', 'html_url': 'https://github.com/koba04', 'followers_url': 'https://api.github.com/users/koba04/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18900/builds/26814) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-12 23:47:27 | 2020-05-27 07:17:41 | 2020-05-27 00:19:33 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18900', 'html_url': 'https://github.com/facebook/react/pull/18900', 'diff_url': 'https://github.com/facebook/react/pull/18900.diff', 'patch_url': 'https://github.com/facebook/react/pull/18900.patch', 'merged_at': datetime.datetime(2020, 5, 27, 0, 19, 33)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18900/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18900/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18899 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18899/labels{/name} | https://api.github.com/repos/facebook/react/issues/18899/comments | https://api.github.com/repos/facebook/react/issues/18899/events | https://github.com/facebook/react/pull/18899 | 616,889,629 | MDExOlB1bGxSZXF1ZXN0NDE2OTEzNzkw | 18,899 | Revert "deps: bump ESLint version to v7" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18899/builds/26292) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-12 19:06:07 | 2022-11-29 22:21:50 | 2020-05-12 19:06:15 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18899', 'html_url': 'https://github.com/facebook/react/pull/18899', 'diff_url': 'https://github.com/facebook/react/pull/18899.diff', 'patch_url': 'https://github.com/facebook/react/pull/18899.patch', 'merged_at': datetime.datetime(2020, 5, 12, 19, 6, 15)} | Reverts facebook/react#18897 | {'url': 'https://api.github.com/repos/facebook/react/issues/18899/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18899/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18898 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18898/labels{/name} | https://api.github.com/repos/facebook/react/issues/18898/comments | https://api.github.com/repos/facebook/react/issues/18898/events | https://github.com/facebook/react/pull/18898 | 616,810,914 | MDExOlB1bGxSZXF1ZXN0NDE2ODUwNDE4 | 18,898 | Modern Event System: Add scaffolding for createEventHandle | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18898/builds/26265) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-12 16:55:52 | 2020-05-12 18:01:17 | 2020-05-12 18:01:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18898', 'html_url': 'https://github.com/facebook/react/pull/18898', 'diff_url': 'https://github.com/facebook/react/pull/18898.diff', 'patch_url': 'https://github.com/facebook/react/pull/18898.patch', 'merged_at': datetime.datetime(2020, 5, 12, 18, 1, 13)} | This PR extracts a bunch of the logic out from https://github.com/facebook/react/pull/18756 that implements that basic scaffolding for the `createEventHandle` API. Note this PR does not enable the flag, so it shouldn't affect anything internally. The other changes are just tweaks and nits that the other PR made, not co... | {'url': 'https://api.github.com/repos/facebook/react/issues/18898/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18898/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18897 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18897/labels{/name} | https://api.github.com/repos/facebook/react/issues/18897/comments | https://api.github.com/repos/facebook/react/issues/18897/events | https://github.com/facebook/react/pull/18897 | 616,777,884 | MDExOlB1bGxSZXF1ZXN0NDE2ODIzNTU1 | 18,897 | deps: bump ESLint version to v7 | {'login': 'koba04', 'id': 250407, 'node_id': 'MDQ6VXNlcjI1MDQwNw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/250407?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/koba04', 'html_url': 'https://github.com/koba04', 'followers_url': 'https://api.github.com/users/koba04/followers', 'following_... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18897/builds/26266) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-12 16:05:48 | 2020-05-13 00:04:01 | 2020-05-12 17:41:38 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18897', 'html_url': 'https://github.com/facebook/react/pull/18897', 'diff_url': 'https://github.com/facebook/react/pull/18897.diff', 'patch_url': 'https://github.com/facebook/react/pull/18897.patch', 'merged_at': datetime.datetime(2020, 5, 12, 17, 41, 38)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18897/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18897/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18896 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18896/labels{/name} | https://api.github.com/repos/facebook/react/issues/18896/comments | https://api.github.com/repos/facebook/react/issues/18896/events | https://github.com/facebook/react/issues/18896 | 616,722,649 | MDU6SXNzdWU2MTY3MjI2NDk= | 18,896 | The DOM element that ref refers to is missing | {'login': 'VitaminCtea', 'id': 35827111, 'node_id': 'MDQ6VXNlcjM1ODI3MTEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/35827111?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/VitaminCtea', 'html_url': 'https://github.com/VitaminCtea', 'followers_url': 'https://api.github.com/users/VitaminCtea... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Could you post a minimal, reproducible example?",
"@knyzorg Sorry, since the url obtained by the Audio tag is asynchronous and USES Redux, you may not be able to provide a small example. You can take a look at this GIF, which is an incorrect GIF: https://github.com/VitaminCtea/reactBugImage/blob/master/reactRepo... | 2020-05-12 14:54:27 | 2020-05-12 17:42:25 | 2020-05-12 17:41:52 | NONE | null | null | null | I used useRef in the function component to refer to an audio element. When I clicked the content of the song, I sent some actions to Redux. Then the console reported an error and could not call the play and other methods of audio element. When I tried the ref callback to get audio element, according to the official doc... | {'url': 'https://api.github.com/repos/facebook/react/issues/18896/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18896/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18895 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18895/labels{/name} | https://api.github.com/repos/facebook/react/issues/18895/comments | https://api.github.com/repos/facebook/react/issues/18895/events | https://github.com/facebook/react/issues/18895 | 616,445,977 | MDU6SXNzdWU2MTY0NDU5Nzc= | 18,895 | Bug: Horrifying performance in React experimental | {'login': 'Jack-Works', 'id': 5390719, 'node_id': 'MDQ6VXNlcjUzOTA3MTk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5390719?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Jack-Works', 'html_url': 'https://github.com/Jack-Works', 'followers_url': 'https://api.github.com/users/Jack-Works/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Sounds odd. A repro would be helpful.\r\n\r\nHave you looked at where the time is being spent percent-wise?",
"I can reproduce it in our product but our product is very complicated. I'll try to repro it but I can't guarantee it.",
"Run the command `yarn webpack-dev-server -o index.js` with the following files.... | 2020-05-12 08:00:19 | 2020-10-20 12:35:29 | 2020-10-20 12:34:59 | CONTRIBUTOR | null | null | null | React version: 0.0.0-experimental-33c3af284
Tested: 0.0.0-experimental-e5d06e34b is okay, 0.0.0-experimental-33c3af284 is broken
## Steps To Reproduce
1. It's in a complicated application so not sure how to reproduce
2. If the React team has an interest in it, I will try to provide it.
React-experimental t... | {'url': 'https://api.github.com/repos/facebook/react/issues/18895/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18895/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18894 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18894/labels{/name} | https://api.github.com/repos/facebook/react/issues/18894/comments | https://api.github.com/repos/facebook/react/issues/18894/events | https://github.com/facebook/react/issues/18894 | 616,443,032 | MDU6SXNzdWU2MTY0NDMwMzI= | 18,894 | i lost my account | {'login': 'ohtryy', 'id': 37167144, 'node_id': 'MDQ6VXNlcjM3MTY3MTQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/37167144?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ohtryy', 'html_url': 'https://github.com/ohtryy', 'followers_url': 'https://api.github.com/users/ohtryy/followers', 'follow... | [] | closed | false | null | [] | null | [] | 2020-05-12 07:55:26 | 2020-05-12 11:37:15 | 2020-05-12 11:37:15 | NONE | null | null | null | can i get my lost account? | {'url': 'https://api.github.com/repos/facebook/react/issues/18894/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/18894/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18893 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18893/labels{/name} | https://api.github.com/repos/facebook/react/issues/18893/comments | https://api.github.com/repos/facebook/react/issues/18893/events | https://github.com/facebook/react/issues/18893 | 616,434,102 | MDU6SXNzdWU2MTY0MzQxMDI= | 18,893 | react dev tools | {'login': 'deminsy', 'id': 15141815, 'node_id': 'MDQ6VXNlcjE1MTQxODE1', 'avatar_url': 'https://avatars.githubusercontent.com/u/15141815?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/deminsy', 'html_url': 'https://github.com/deminsy', 'followers_url': 'https://api.github.com/users/deminsy/followers', 'fo... | [] | closed | false | null | [] | null | [] | 2020-05-12 07:40:38 | 2020-05-12 15:57:08 | 2020-05-12 15:57:08 | NONE | null | null | null | 👉 Please follow one of these issue templates:
- https://github.com/facebook/react/issues/new/choose
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18893/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18893/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18892 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18892/labels{/name} | https://api.github.com/repos/facebook/react/issues/18892/comments | https://api.github.com/repos/facebook/react/issues/18892/events | https://github.com/facebook/react/issues/18892 | 616,413,434 | MDU6SXNzdWU2MTY0MTM0MzQ= | 18,892 | I lost my account | {'login': 'ohtryy', 'id': 37167144, 'node_id': 'MDQ6VXNlcjM3MTY3MTQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/37167144?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ohtryy', 'html_url': 'https://github.com/ohtryy', 'followers_url': 'https://api.github.com/users/ohtryy/followers', 'follow... | [] | closed | false | null | [] | null | [] | 2020-05-12 07:03:17 | 2020-05-12 07:03:43 | 2020-05-12 07:03:43 | NONE | null | null | null | Can i solve my forgot password? | {'url': 'https://api.github.com/repos/facebook/react/issues/18892/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18892/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18891 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18891/labels{/name} | https://api.github.com/repos/facebook/react/issues/18891/comments | https://api.github.com/repos/facebook/react/issues/18891/events | https://github.com/facebook/react/pull/18891 | 616,265,949 | MDExOlB1bGxSZXF1ZXN0NDE2NDEyMDIw | 18,891 | Expose LegacyHidden type and disable <div hidden /> API in new fork | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18891/builds/26125) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-12 00:08:57 | 2020-05-12 03:02:09 | 2020-05-12 03:02:09 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18891', 'html_url': 'https://github.com/facebook/react/pull/18891', 'diff_url': 'https://github.com/facebook/react/pull/18891.diff', 'patch_url': 'https://github.com/facebook/react/pull/18891.patch', 'merged_at': datetime.datetime(2020, 5, 12, 3, 2, 9)} | I will use this internally at Facebook to migrate away from `<div hidden />`. The end goal is to migrate to the Offscreen type, but that has different semantics. This is an incremental step.
I disabled `<div hidden />` in the new fork and updated the tests to use an indirection that picks the correct API. I will rem... | {'url': 'https://api.github.com/repos/facebook/react/issues/18891/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18891/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18890 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18890/labels{/name} | https://api.github.com/repos/facebook/react/issues/18890/comments | https://api.github.com/repos/facebook/react/issues/18890/events | https://github.com/facebook/react/pull/18890 | 616,225,746 | MDExOlB1bGxSZXF1ZXN0NDE2Mzc4ODk3 | 18,890 | Revert "Hard code enableComponentStacks in www" | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18890/builds/26061) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-11 22:20:41 | 2022-11-29 22:21:49 | 2020-05-11 22:29:25 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18890', 'html_url': 'https://github.com/facebook/react/pull/18890', 'diff_url': 'https://github.com/facebook/react/pull/18890.diff', 'patch_url': 'https://github.com/facebook/react/pull/18890.patch', 'merged_at': datetime.datetime(2020, 5, 11, 22, 29, 25)} | Reverts facebook/react#18869. This was causing internal tests to fail in our latest www sync. | {'url': 'https://api.github.com/repos/facebook/react/issues/18890/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18890/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18889 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18889/labels{/name} | https://api.github.com/repos/facebook/react/issues/18889/comments | https://api.github.com/repos/facebook/react/issues/18889/events | https://github.com/facebook/react/pull/18889 | 616,065,476 | MDExOlB1bGxSZXF1ZXN0NDE2MjUwNTgw | 18,889 | useMutableSource: "Entangle" instead of expiring | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18889/builds/26582) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-11 17:48:39 | 2020-05-13 18:33:33 | 2020-05-13 18:33:33 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18889', 'html_url': 'https://github.com/facebook/react/pull/18889', 'diff_url': 'https://github.com/facebook/react/pull/18889.diff', 'patch_url': 'https://github.com/facebook/react/pull/18889.patch', 'merged_at': datetime.datetime(2020, 5, 13, 18, 33, 33)} | A lane is said to be entangled with another when it's not allowed to render in a batch that does not also include the other lane.
This commit implements entanglement for `useMutableSource`. If a source is mutated in between when it's read in the render phase, but before it's subscribed to in the commit phase, we mus... | {'url': 'https://api.github.com/repos/facebook/react/issues/18889/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18889/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18888 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18888/labels{/name} | https://api.github.com/repos/facebook/react/issues/18888/comments | https://api.github.com/repos/facebook/react/issues/18888/events | https://github.com/facebook/react/issues/18888 | 615,840,992 | MDU6SXNzdWU2MTU4NDA5OTI= | 18,888 | [eslint-plugin-react-hooks] false positive with useFocusEffect | {'login': 'leethree', 'id': 648142, 'node_id': 'MDQ6VXNlcjY0ODE0Mg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/648142?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/leethree', 'html_url': 'https://github.com/leethree', 'followers_url': 'https://api.github.com/users/leethree/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
">The rules shouldn't check the function because it's not a React useEffect hook.\r\n\r\nSigh. People have been asking for the opposite, so we added this for every function ending with `Effect`.",
"Admittedly, `useFocusEffect` is weird. It could easily work exactly like `useEffect` instead of requiring `useCallb... | 2020-05-11 12:19:04 | 2020-05-26 15:18:26 | 2020-05-12 18:19:39 | NONE | null | null | null | Upgraded `eslint-plugin-react-hooks` to 4.0.0, it's showing errors on React-Navigation's `useFocusEffect` hook.
```js
import { useFocusEffect } from '@react-navigation/native';
useFocusEffect(
React.useCallback(() => {
const unsubscribe = API.subscribe(userId, user => setUser(user));
return ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18888/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18888/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18887 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18887/labels{/name} | https://api.github.com/repos/facebook/react/issues/18887/comments | https://api.github.com/repos/facebook/react/issues/18887/events | https://github.com/facebook/react/issues/18887 | 615,808,942 | MDU6SXNzdWU2MTU4MDg5NDI= | 18,887 | Bug: unexpected warning on custom hook call-site | {'login': 'surgeboris', 'id': 21183294, 'node_id': 'MDQ6VXNlcjIxMTgzMjk0', 'avatar_url': 'https://avatars.githubusercontent.com/u/21183294?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/surgeboris', 'html_url': 'https://github.com/surgeboris', 'followers_url': 'https://api.github.com/users/surgeboris/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Related to #18888, arguably a duplicate",
"I'd say #18888 is a duplicate of this issue, since it was created later (but the time difference is so small that it's certainly possible that we were authoring our issues simultaneously).\r\n\r\nAnyways, #18888 got more attention, so I'm closing this one."
] | 2020-05-11 11:24:48 | 2020-05-12 18:02:21 | 2020-05-12 18:02:21 | CONTRIBUTOR | null | null | null | With `eslint-plugin-react-hooks@4.0.0` I observe an unexpected warning (with a weird behaviour) on custom hook call-site.
## Steps To Reproduce
1. yarn create react-app hooks-bug
2. cd hooks-bug
3. npm run eject
4. npm i eslint-plugin-react-hooks@4.0.0
5. place code from the examples below into `App.js`
6. r... | {'url': 'https://api.github.com/repos/facebook/react/issues/18887/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18887/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18886 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18886/labels{/name} | https://api.github.com/repos/facebook/react/issues/18886/comments | https://api.github.com/repos/facebook/react/issues/18886/events | https://github.com/facebook/react/pull/18886 | 615,777,600 | MDExOlB1bGxSZXF1ZXN0NDE2MDE2Mjc3 | 18,886 | Modern Event System: revise ancestor logic | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18886/builds/26001) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-11 10:32:59 | 2020-05-11 22:22:56 | 2020-05-11 21:09:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18886', 'html_url': 'https://github.com/facebook/react/pull/18886', 'diff_url': 'https://github.com/facebook/react/pull/18886.diff', 'patch_url': 'https://github.com/facebook/react/pull/18886.patch', 'merged_at': datetime.datetime(2020, 5, 11, 21, 9, 52)} | This PR revises the logic for the modern event system and how it handles finding the target ancestor fiber. This is to tackle in internal issue that we found recently.
Specifically, this PR fixes an issue where the ancestor instance fiber was incorrectly let through when we encountered a root container that wasn't a... | {'url': 'https://api.github.com/repos/facebook/react/issues/18886/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18886/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18885 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18885/labels{/name} | https://api.github.com/repos/facebook/react/issues/18885/comments | https://api.github.com/repos/facebook/react/issues/18885/events | https://github.com/facebook/react/issues/18885 | 615,683,801 | MDU6SXNzdWU2MTU2ODM4MDE= | 18,885 | Bug: useMutableSource inside a suspending component doesn't install the subscription | {'login': 'orestis', 'id': 9217, 'node_id': 'MDQ6VXNlcjkyMTc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9217?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/orestis', 'html_url': 'https://github.com/orestis', 'followers_url': 'https://api.github.com/users/orestis/followers', 'following_url'... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"This does not look like a problem with `useMutableSource` to me, but a Suspense bug in your demo app.\r\n\r\nThe `Suspicious` component suspends during the mount render, so it does not get committed to the DOM. Instead, its fallback UI gets committed. This means that **no side effects- including subscribing to sou... | 2020-05-11 08:15:42 | 2020-05-12 18:04:29 | 2020-05-12 17:07:01 | NONE | null | null | null | React version: 0.0.0-experimental-33c3af284
## Description
When using useMutableSource, you have to be careful where your Suspense boundaries are.
```
function Suspicious() {
let payload = useMutableSource(mutableSource, getSnapshot, subscribe);
return (
<div>
<span>Suspicious</span>
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18885/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18885/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18884 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18884/labels{/name} | https://api.github.com/repos/facebook/react/issues/18884/comments | https://api.github.com/repos/facebook/react/issues/18884/events | https://github.com/facebook/react/issues/18884 | 615,576,352 | MDU6SXNzdWU2MTU1NzYzNTI= | 18,884 | Bug:[Jest Timer Mocks] act is diff with react-dom/utils make act warning on async act | {'login': 'yanghoxom', 'id': 10399540, 'node_id': 'MDQ6VXNlcjEwMzk5NTQw', 'avatar_url': 'https://avatars.githubusercontent.com/u/10399540?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yanghoxom', 'html_url': 'https://github.com/yanghoxom', 'followers_url': 'https://api.github.com/users/yanghoxom/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'yanghoxom', 'id': 10399540.0, 'node_id': 'MDQ6VXNlcjEwMzk5NTQw', 'avatar_url': 'https://avatars.githubusercontent.com/u/10399540?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yanghoxom', 'html_url': 'https://github.com/yanghoxom', 'followers_url': 'https://api.github.com/users/yanghoxom/follo... | [{'login': 'yanghoxom', 'id': 10399540, 'node_id': 'MDQ6VXNlcjEwMzk5NTQw', 'avatar_url': 'https://avatars.githubusercontent.com/u/10399540?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/yanghoxom', 'html_url': 'https://github.com/yanghoxom', 'followers_url': 'https://api.github.com/users/yanghoxom/follow... | null | [
"`react-dom` and `react-test-renderer` are different renderers. That's why the error message mentions that they have different `act()`s.\r\n\r\nWhich renderer are you using in your tests?",
"@bvaughn i try with `create` from react-test-rerender and `render` from @testing-library/react\r\nsame issue.\r\nmust use `... | 2020-05-11 04:21:52 | 2020-07-30 17:49:26 | 2020-07-30 17:49:26 | NONE | null | null | null | When i use
`import { act } from 'react-test-rerender';`
When i replace it with
`import { act } from 'react-dom/test-utils';`
this warning is gone :v:
React version:
react-test-renderer: 16.13.... | {'url': 'https://api.github.com/repos/facebook/react/issues/18884/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18884/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18883 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18883/labels{/name} | https://api.github.com/repos/facebook/react/issues/18883/comments | https://api.github.com/repos/facebook/react/issues/18883/events | https://github.com/facebook/react/issues/18883 | 615,439,457 | MDU6SXNzdWU2MTU0Mzk0NTc= | 18,883 | Feature proposal(eslint-react-hooks): Recursive dependencies scanning for exhaustive-deps | {'login': 'Telokis', 'id': 6382729, 'node_id': 'MDQ6VXNlcjYzODI3Mjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6382729?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Telokis', 'html_url': 'https://github.com/Telokis', 'followers_url': 'https://api.github.com/users/Telokis/followers', 'foll... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-05-10 17:37:06 | 2022-05-17 18:10:32 | 2022-05-17 18:10:25 | NONE | null | null | null | ## Context
After reading https://github.com/facebook/react/issues/14920 (not 100% of it, I admit), I decided to refactor my codebase in order to be more resilient against potential mistakes.
During this conversion, I converted a ton of callbacks to `useCallback` and made extensive use of the array dependencies fo... | {'url': 'https://api.github.com/repos/facebook/react/issues/18883/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18883/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18882 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18882/labels{/name} | https://api.github.com/repos/facebook/react/issues/18882/comments | https://api.github.com/repos/facebook/react/issues/18882/events | https://github.com/facebook/react/issues/18882 | 615,351,980 | MDU6SXNzdWU2MTUzNTE5ODA= | 18,882 | Bug: react-hooks/exhaustive-deps lint rule not working as expected | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The warning is correct: useAlert is a custom hook and context is an external value, so it is not a valid dependency",
"@vkurchatkin But how do you explain that the code sample proves the opposite?",
"It doesn't really prove anything. Your code happens to work, but ESLint analyses code in isolation.\r\nOnly \"... | 2020-05-10 09:24:04 | 2020-05-11 15:15:21 | 2020-05-11 07:45:57 | NONE | null | null | null | This issue is related to the `react-hooks/exhaustive-deps` not detecting a reasonable case of warnings regarding missing dependencies.
The App contains two Children (One is the "increment" button where cl... | {'url': 'https://api.github.com/repos/facebook/react/issues/18882/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18882/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18881 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18881/labels{/name} | https://api.github.com/repos/facebook/react/issues/18881/comments | https://api.github.com/repos/facebook/react/issues/18881/events | https://github.com/facebook/react/pull/18881 | 615,287,790 | MDExOlB1bGxSZXF1ZXN0NDE1NjQ5ODc1 | 18,881 | Added clear message for functional component starting with lowercase | {'login': 'roheat', 'id': 22127183, 'node_id': 'MDQ6VXNlcjIyMTI3MTgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/22127183?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/roheat', 'html_url': 'https://github.com/roheat', 'followers_url': 'https://api.github.com/users/roheat/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18881/builds/25516) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-10 00:34:36 | 2020-05-10 00:52:13 | 2020-05-10 00:52:12 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18881', 'html_url': 'https://github.com/facebook/react/pull/18881', 'diff_url': 'https://github.com/facebook/react/pull/18881.diff', 'patch_url': 'https://github.com/facebook/react/pull/18881.patch', 'merged_at': datetime.datetime(2020, 5, 10, 0, 52, 12)} | Closes ssue #17736
PR includes new suggested changes in https://github.com/facebook/react/pull/17744. | {'url': 'https://api.github.com/repos/facebook/react/issues/18881/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 3, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18881/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18880 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18880/labels{/name} | https://api.github.com/repos/facebook/react/issues/18880/comments | https://api.github.com/repos/facebook/react/issues/18880/events | https://github.com/facebook/react/pull/18880 | 615,268,219 | MDExOlB1bGxSZXF1ZXN0NDE1NjM2MTQy | 18,880 | Fix Profiler root change error | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18880/builds/26305) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-09 22:00:33 | 2020-05-13 23:47:51 | 2020-05-12 22:47:24 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18880', 'html_url': 'https://github.com/facebook/react/pull/18880', 'diff_url': 'https://github.com/facebook/react/pull/18880.diff', 'patch_url': 'https://github.com/facebook/react/pull/18880.patch', 'merged_at': datetime.datetime(2020, 5, 12, 22, 47, 24)} | fix #18010 "Could not find commit data for root …"
How to reproduce:
1. Start profiling
1. Switch color (ReactNativeWeb)
1. Press button (Toggle)
1. Select lowest item on the Flamegraph
1. Change root to Toggle
Sidebar not updates fiberID and fiberName, then trying to get commit data which was on previously ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18880/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18880/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18879 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18879/labels{/name} | https://api.github.com/repos/facebook/react/issues/18879/comments | https://api.github.com/repos/facebook/react/issues/18879/events | https://github.com/facebook/react/issues/18879 | 615,244,881 | MDU6SXNzdWU2MTUyNDQ4ODE= | 18,879 | Improve the invalid hydration warning | {'login': 'etienne-martin', 'id': 9700213, 'node_id': 'MDQ6VXNlcjk3MDAyMTM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9700213?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/etienne-martin', 'html_url': 'https://github.com/etienne-martin', 'followers_url': 'https://api.github.com/users/etie... | [] | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-05-09 19:30:18 | 2020-09-19 15:00:30 | 2020-08-08 12:02:22 | NONE | null | null | null | **_Do you want to request a feature or report a bug?_**
feature / improvement
**_What is the current behavior?_**
Debugging hydration problems can be quite challenging because of the lack of information provided in the error message.
Common invalid hydration warning:
```
Warning: Expected server HTML t... | {'url': 'https://api.github.com/repos/facebook/react/issues/18879/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18879/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18878 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18878/labels{/name} | https://api.github.com/repos/facebook/react/issues/18878/comments | https://api.github.com/repos/facebook/react/issues/18878/events | https://github.com/facebook/react/pull/18878 | 615,236,846 | MDExOlB1bGxSZXF1ZXN0NDE1NjE0Mzc4 | 18,878 | feat(eslint-plugin-react-hooks): Support ESLint 7.x | {'login': 'MichaelDeBoey', 'id': 6643991, 'node_id': 'MDQ6VXNlcjY2NDM5OTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6643991?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MichaelDeBoey', 'html_url': 'https://github.com/MichaelDeBoey', 'followers_url': 'https://api.github.com/users/Michael... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18878/builds/25474) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-09 18:41:20 | 2020-05-12 17:04:01 | 2020-05-12 16:01:29 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18878', 'html_url': 'https://github.com/facebook/react/pull/18878', 'diff_url': 'https://github.com/facebook/react/pull/18878.diff', 'patch_url': 'https://github.com/facebook/react/pull/18878.patch', 'merged_at': datetime.datetime(2020, 5, 12, 16, 1, 29)} | Closes #18876 | {'url': 'https://api.github.com/repos/facebook/react/issues/18878/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 3, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18878/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18877 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18877/labels{/name} | https://api.github.com/repos/facebook/react/issues/18877/comments | https://api.github.com/repos/facebook/react/issues/18877/events | https://github.com/facebook/react/issues/18877 | 615,171,322 | MDU6SXNzdWU2MTUxNzEzMjI= | 18,877 | Error: "Commit tree already contains fiber 10819. This is a bug in React DevTools." | {'login': 'ahsan7786', 'id': 24411496, 'node_id': 'MDQ6VXNlcjI0NDExNDk2', 'avatar_url': 'https://avatars.githubusercontent.com/u/24411496?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ahsan7786', 'html_url': 'https://github.com/ahsan7786', 'followers_url': 'https://api.github.com/users/ahsan7786/followe... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | null | [] | null | [
"Looks Similar to this issue: https://github.com/facebook/react/issues/18859",
"Sorry for the inconvenient!\r\n\r\nThis looks like a duplicate of #18859 though. If you're able to provide more info on how to repro- that would be great! Otherwise the duplicate issue doesn't add a lot of value, so I'm going to close... | 2020-05-09 12:57:43 | 2021-04-28 20:30:46 | 2020-05-11 23:31:38 | NONE | null | null | null | Describe what you were doing when the bug occurred:
simple running profiler and popout this error
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.6.0-6cceaeb67
Call stack: at j (chrome-extension://f... | {'url': 'https://api.github.com/repos/facebook/react/issues/18877/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18877/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18876 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18876/labels{/name} | https://api.github.com/repos/facebook/react/issues/18876/comments | https://api.github.com/repos/facebook/react/issues/18876/events | https://github.com/facebook/react/issues/18876 | 615,170,537 | MDU6SXNzdWU2MTUxNzA1Mzc= | 18,876 | eslint-plugin-react-hooks peerDependency warning with eslint@7.0.0 | {'login': 'AviVahl', 'id': 8952081, 'node_id': 'MDQ6VXNlcjg5NTIwODE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8952081?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AviVahl', 'html_url': 'https://github.com/AviVahl', 'followers_url': 'https://api.github.com/users/AviVahl/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Oh I just realized `eslint-plugin-react` is coming from another repo: https://github.com/yannickcr/eslint-plugin-react\r\n\r\nWill open an issue there as well and edit this one."
] | 2020-05-09 12:52:55 | 2020-05-12 16:01:29 | 2020-05-12 16:01:29 | NONE | null | null | null | ## The current behavior
eslint@7.0.0 [has been released](https://github.com/eslint/eslint/releases/tag/v7.0.0) yesterday. `eslint-plugin-react-hooks` gets a peerDependency warning:
```
npm WARN eslint-plugin-react@7.19.0 requires a peer of eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 but none is installed. You must... | {'url': 'https://api.github.com/repos/facebook/react/issues/18876/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18876/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18875 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18875/labels{/name} | https://api.github.com/repos/facebook/react/issues/18875/comments | https://api.github.com/repos/facebook/react/issues/18875/events | https://github.com/facebook/react/issues/18875 | 615,125,430 | MDU6SXNzdWU2MTUxMjU0MzA= | 18,875 | There is no issue. Found a solution | {'login': 'Wellusioner', 'id': 48888501, 'node_id': 'MDQ6VXNlcjQ4ODg4NTAx', 'avatar_url': 'https://avatars.githubusercontent.com/u/48888501?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Wellusioner', 'html_url': 'https://github.com/Wellusioner', 'followers_url': 'https://api.github.com/users/Wellusioner... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2020-05-09 08:40:34 | 2020-05-09 11:19:58 | 2020-05-09 11:19:02 | NONE | null | null | null | I am making a simple tracking app. I am using redux and redux saga with React. The problem is that dispatching action inside useEffect cause an infinite loop request. I have seen many solutions and articles through the Internet. But None of them could solve my problem.
![image](https://user-images.githubusercontent... | {'url': 'https://api.github.com/repos/facebook/react/issues/18875/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18875/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18874 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18874/labels{/name} | https://api.github.com/repos/facebook/react/issues/18874/comments | https://api.github.com/repos/facebook/react/issues/18874/events | https://github.com/facebook/react/issues/18874 | 615,111,144 | MDU6SXNzdWU2MTUxMTExNDQ= | 18,874 | Bug: function component is unmount and mount with old state when hmr | {'login': 'BryceHQ', 'id': 8765362, 'node_id': 'MDQ6VXNlcjg3NjUzNjI=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8765362?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/BryceHQ', 'html_url': 'https://github.com/BryceHQ', 'followers_url': 'https://api.github.com/users/BryceHQ/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"@BryceHQ You forgot to add steps to reproduce and link to code example in the current issue. though if someone follows the link you posted in the question, they can see it with complete details. ",
"Replied here: https://github.com/pmmmwh/react-refresh-webpack-plugin/issues/85#issuecomment-626188070.\r\n"
] | 2020-05-09 07:04:33 | 2020-05-09 19:38:19 | 2020-05-09 19:38:19 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Please see https://github.com/pmmmwh/react-refresh-webpack-plugin/issues/85
I a... | {'url': 'https://api.github.com/repos/facebook/react/issues/18874/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18874/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18873 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18873/labels{/name} | https://api.github.com/repos/facebook/react/issues/18873/comments | https://api.github.com/repos/facebook/react/issues/18873/events | https://github.com/facebook/react/issues/18873 | 615,083,701 | MDU6SXNzdWU2MTUwODM3MDE= | 18,873 | Deprecate SyntheticKeyboardEvent.{charCode,keyCode,which} | {'login': 'japgolly', 'id': 202935, 'node_id': 'MDQ6VXNlcjIwMjkzNQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/202935?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/japgolly', 'html_url': 'https://github.com/japgolly', 'followers_url': 'https://api.github.com/users/japgolly/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-05-09 03:48:45 | 2024-03-07 05:49:44 | null | NONE | null | null | null | The following `KeyboardEvent` properties have been officially deprecated:
* https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/charCode
* https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
* https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/which
React should probabl... | {'url': 'https://api.github.com/repos/facebook/react/issues/18873/reactions', 'total_count': 2, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18873/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18872 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18872/labels{/name} | https://api.github.com/repos/facebook/react/issues/18872/comments | https://api.github.com/repos/facebook/react/issues/18872/events | https://github.com/facebook/react/pull/18872 | 615,073,760 | MDExOlB1bGxSZXF1ZXN0NDE1NTAyMjY0 | 18,872 | Don't cut off effects at end of list if hydrating | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18872/builds/25352) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-09 02:41:53 | 2020-05-09 04:26:53 | 2020-05-09 04:26:52 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18872', 'html_url': 'https://github.com/facebook/react/pull/18872', 'diff_url': 'https://github.com/facebook/react/pull/18872.diff', 'patch_url': 'https://github.com/facebook/react/pull/18872.patch', 'merged_at': datetime.datetime(2020, 5, 9, 4, 26, 52)} | This is a follow up to #18854.
We have a special case that cuts off the effect list. The logic for this case needs to replicate the logic from #18854. So I also bail out from hydration here.
This is another special case that would be nice to get rid of if we get rid of the effect list. | {'url': 'https://api.github.com/repos/facebook/react/issues/18872/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18872/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18871 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18871/labels{/name} | https://api.github.com/repos/facebook/react/issues/18871/comments | https://api.github.com/repos/facebook/react/issues/18871/events | https://github.com/facebook/react/issues/18871 | 615,054,265 | MDU6SXNzdWU2MTUwNTQyNjU= | 18,871 | The pacote dependency should be re-evaluated | {'login': 'SchnWalter', 'id': 2186426, 'node_id': 'MDQ6VXNlcjIxODY0MjY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2186426?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SchnWalter', 'html_url': 'https://github.com/SchnWalter', 'followers_url': 'https://api.github.com/users/SchnWalter/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"What does the number of people \"watching\" that repo have to do with anything?\r\n\r\nSearching this repo, the only place `pacote` is used is for a single script called `downloadReactIsForPrettyFormat.js`, which is [called in the `postInstall` script when you clone and install this repo](https://github.com/facebo... | 2020-05-09 00:44:01 | 2020-05-09 19:12:30 | 2020-05-09 16:26:59 | NONE | null | null | null | The React repository depends on [pacote](https://www.npmjs.com/package/pacote), a JavaScript Package Handler that has ~2M weekly downloads and only 8 peoples watching the [project on GitHub](https://github.com/npm/pacote), now there are 9.
This looks like a recipe for a left-pad scale disaster. I would like to to in... | {'url': 'https://api.github.com/repos/facebook/react/issues/18871/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 1, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18871/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18870 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18870/labels{/name} | https://api.github.com/repos/facebook/react/issues/18870/comments | https://api.github.com/repos/facebook/react/issues/18870/events | https://github.com/facebook/react/issues/18870 | 615,034,572 | MDU6SXNzdWU2MTUwMzQ1NzI= | 18,870 | Bug: ReactDOM.hydrate style prop mismatch with document rendered in JSDOM | {'login': 'dwoznicki', 'id': 13933454, 'node_id': 'MDQ6VXNlcjEzOTMzNDU0', 'avatar_url': 'https://avatars.githubusercontent.com/u/13933454?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dwoznicki', 'html_url': 'https://github.com/dwoznicki', 'followers_url': 'https://api.github.com/users/dwoznicki/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-05-08 23:21:29 | 2020-08-16 07:23:53 | 2020-08-16 07:23:53 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
In my project, I'm using [prerender-loader](https://github.com/GoogleChromeLabs/pr... | {'url': 'https://api.github.com/repos/facebook/react/issues/18870/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18870/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18869 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18869/labels{/name} | https://api.github.com/repos/facebook/react/issues/18869/comments | https://api.github.com/repos/facebook/react/issues/18869/events | https://github.com/facebook/react/pull/18869 | 615,027,868 | MDExOlB1bGxSZXF1ZXN0NDE1NDY2NzYw | 18,869 | Hard code enableComponentStacks in www | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18869/builds/25319) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-08 22:57:42 | 2020-05-09 01:14:55 | 2020-05-09 01:14:55 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18869', 'html_url': 'https://github.com/facebook/react/pull/18869', 'diff_url': 'https://github.com/facebook/react/pull/18869.diff', 'patch_url': 'https://github.com/facebook/react/pull/18869.patch', 'merged_at': datetime.datetime(2020, 5, 9, 1, 14, 55)} | This is now fully rolled out. We still have to do RN. | {'url': 'https://api.github.com/repos/facebook/react/issues/18869/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18869/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18868 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18868/labels{/name} | https://api.github.com/repos/facebook/react/issues/18868/comments | https://api.github.com/repos/facebook/react/issues/18868/events | https://github.com/facebook/react/pull/18868 | 614,957,450 | MDExOlB1bGxSZXF1ZXN0NDE1NDA5NTcz | 18,868 | Out-of-band www sync | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18868/builds/25304) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-08 20:04:29 | 2020-05-08 22:16:50 | 2020-05-08 22:16:50 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18868', 'html_url': 'https://github.com/facebook/react/pull/18868', 'diff_url': 'https://github.com/facebook/react/pull/18868.diff', 'patch_url': 'https://github.com/facebook/react/pull/18868.patch', 'merged_at': None} | Using this PR to run an out-of-band www sync. Not for merge.
Based off edf6eac8a181860fd8a2d076a43806f1237495a1, the currently synced revision.
Includes only https://github.com/facebook/react/pull/18864, which only affects the new fork. So it should be low risk. | {'url': 'https://api.github.com/repos/facebook/react/issues/18868/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18868/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18867 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18867/labels{/name} | https://api.github.com/repos/facebook/react/issues/18867/comments | https://api.github.com/repos/facebook/react/issues/18867/events | https://github.com/facebook/react/issues/18867 | 614,702,464 | MDU6SXNzdWU2MTQ3MDI0NjQ= | 18,867 | Bug (MS Edge): Expected identifier, string or number (White screen) | {'login': 'ishtms', 'id': 30657558, 'node_id': 'MDQ6VXNlcjMwNjU3NTU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/30657558?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ishtms', 'html_url': 'https://github.com/ishtms', 'followers_url': 'https://api.github.com/users/ishtms/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'ishtms', 'id': 30657558.0, 'node_id': 'MDQ6VXNlcjMwNjU3NTU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/30657558?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ishtms', 'html_url': 'https://github.com/ishtms', 'followers_url': 'https://api.github.com/users/ishtms/followers', 'foll... | [{'login': 'ishtms', 'id': 30657558, 'node_id': 'MDQ6VXNlcjMwNjU3NTU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/30657558?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ishtms', 'html_url': 'https://github.com/ishtms', 'followers_url': 'https://api.github.com/users/ishtms/followers', 'follo... | null | [
"What makes you think it is cause by React, not by some other part of your app?",
"I don't think this is an issue with React, @Ishtmeet-Singh. In fact, the line you point to is application code (`...curr.data()`).",
"It doesn't look like this bug report has enough info for one of us to reproduce it.\r\n\r\nPlea... | 2020-05-08 12:07:49 | 2020-05-09 09:46:39 | 2020-05-09 09:46:39 | NONE | null | null | null | We're working on a very large web application, and it has been running fine on Chrome, Mozilla and Safari. We tested it on Edge today, and it showed a blank screen. Not sure what caused it.
The screenshot of the error -
 is not a function | {'login': 'raghav0622', 'id': 29769428, 'node_id': 'MDQ6VXNlcjI5NzY5NDI4', 'avatar_url': 'https://avatars.githubusercontent.com/u/29769428?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/raghav0622', 'html_url': 'https://github.com/raghav0622', 'followers_url': 'https://api.github.com/users/raghav0622/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I think it's related to the recent change to prefix `createRoot` with unstable https://github.com/facebook/react/blob/master/packages/react-dom/index.experimental.js#L22",
"I don't think you shared an actual repro, @raghav0622. The GitHub repo you linked to uses `ReactDOM.render`.\r\n\r\n@nihgwu is right though ... | 2020-05-08 02:52:13 | 2023-09-27 01:19:50 | 2020-05-08 20:50:00 | NONE | null | null | null | ReactDOM.createRoot is not a function
React & ReactDOM version:^0.0.0-experimental-33c3af284
## Steps To Reproduce
1. npx create-react-app my-app --template typescript
2. cd my-app && yarn upgrade react@experimental react-dom@experimental
3. refrence types in react-app-env.d.ts
`/// <reference types="rea... | {'url': 'https://api.github.com/repos/facebook/react/issues/18866/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18866/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18865 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18865/labels{/name} | https://api.github.com/repos/facebook/react/issues/18865/comments | https://api.github.com/repos/facebook/react/issues/18865/events | https://github.com/facebook/react/pull/18865 | 614,417,755 | MDExOlB1bGxSZXF1ZXN0NDE0OTc5MjYz | 18,865 | Add Mounting/Unmounting Effects/Refs to Offscreen Component | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18865/builds/25164) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-08 00:07:21 | 2022-04-03 18:26:07 | 2022-04-03 18:26:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18865', 'html_url': 'https://github.com/facebook/react/pull/18865', 'diff_url': 'https://github.com/facebook/react/pull/18865.diff', 'patch_url': 'https://github.com/facebook/react/pull/18865.patch', 'merged_at': None} | This PR expands on #18729 by introducing an `Offscreen` component. This component will eventually be used to hide or unhide children and mount/unmount all effects in the Offscreen subtree. This PR also changes the behavior of effects and refs in the Offscreen component when components are hidden. Previously, when a com... | {'url': 'https://api.github.com/repos/facebook/react/issues/18865/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18865/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18864 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18864/labels{/name} | https://api.github.com/repos/facebook/react/issues/18864/comments | https://api.github.com/repos/facebook/react/issues/18864/events | https://github.com/facebook/react/pull/18864 | 614,412,388 | MDExOlB1bGxSZXF1ZXN0NDE0OTc0OTA1 | 18,864 | Detect and prevent render starvation, per lane | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18864/builds/25301) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-07 23:50:07 | 2020-05-08 19:47:52 | 2020-05-08 19:47:52 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18864', 'html_url': 'https://github.com/facebook/react/pull/18864', 'diff_url': 'https://github.com/facebook/react/pull/18864.diff', 'patch_url': 'https://github.com/facebook/react/pull/18864.patch', 'merged_at': datetime.datetime(2020, 5, 8, 19, 47, 52)} | If an update is CPU-bound for longer than expected according to its priority, we assume it's being starved by other work on the main thread.
To detect this, we keep track of the elapsed time using a fixed-size array where each slot corresponds to a lane. ~~What we actually store is the event time when the lane first... | {'url': 'https://api.github.com/repos/facebook/react/issues/18864/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18864/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18863 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18863/labels{/name} | https://api.github.com/repos/facebook/react/issues/18863/comments | https://api.github.com/repos/facebook/react/issues/18863/events | https://github.com/facebook/react/pull/18863 | 614,410,717 | MDExOlB1bGxSZXF1ZXN0NDE0OTczNTY1 | 18,863 | [Blocks] Scaffolding react-fetch + first pass at node implementation | {'login': 'maisano', 'id': 689081, 'node_id': 'MDQ6VXNlcjY4OTA4MQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/689081?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/maisano', 'html_url': 'https://github.com/maisano', 'followers_url': 'https://api.github.com/users/maisano/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18863/builds/26254) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-07 23:44:48 | 2020-05-12 16:21:46 | 2020-05-12 16:21:46 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18863', 'html_url': 'https://github.com/facebook/react/pull/18863', 'diff_url': 'https://github.com/facebook/react/pull/18863.diff', 'patch_url': 'https://github.com/facebook/react/pull/18863.patch', 'merged_at': datetime.datetime(2020, 5, 12, 16, 21, 46)} | ## Summary
Categorically, there are two elements to this PR. The first is in moving the `react-data` package over to `react-fetch`, and removing the nested `react-data/fetch` entry point. I took some guesses at some of the more structural changes and names used here.
The second part is a low fidelity, first pass ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18863/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18863/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18862 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18862/labels{/name} | https://api.github.com/repos/facebook/react/issues/18862/comments | https://api.github.com/repos/facebook/react/issues/18862/events | https://github.com/facebook/react/pull/18862 | 614,382,937 | MDExOlB1bGxSZXF1ZXN0NDE0OTUxMDIz | 18,862 | Disable Profiler commit filtering | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"CI failures are transient and unrelated. NPM/Electron download failed.\r\n\r\n<img width=\"1026\" alt=\"Screen Shot 2020-05-07 at 3 29 39 PM\" src=\"https://user-images.githubusercontent.com/29597/81350782-9562a780-9077-11ea-9bff-b2f5664092d6.png\">\r\n",
"This pull request is automatically built and testable in... | 2020-05-07 22:26:50 | 2020-05-08 00:07:30 | 2020-05-08 00:07:21 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18862', 'html_url': 'https://github.com/facebook/react/pull/18862', 'diff_url': 'https://github.com/facebook/react/pull/18862.diff', 'patch_url': 'https://github.com/facebook/react/pull/18862.patch', 'merged_at': datetime.datetime(2020, 5, 8, 0, 7, 21)} | We used to filter "empty" DevTools commits, but it was error prone (see #18798). A commit may appear to be empty (no actual durations) because of component filters, but filtering these empty commits causes interaction commit indices to be off by N. This not only corrupts the resulting data, but also potentially causes ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18862/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18862/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18861 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18861/labels{/name} | https://api.github.com/repos/facebook/react/issues/18861/comments | https://api.github.com/repos/facebook/react/issues/18861/events | https://github.com/facebook/react/pull/18861 | 614,359,855 | MDExOlB1bGxSZXF1ZXN0NDE0OTMyNTM5 | 18,861 | Proposal: react-hooks/exhaustive-deps: a more customizable additionalHooks | {'login': 'dvoytenko', 'id': 726049, 'node_id': 'MDQ6VXNlcjcyNjA0OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/726049?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dvoytenko', 'html_url': 'https://github.com/dvoytenko', 'followers_url': 'https://api.github.com/users/dvoytenko/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @dvoytenko! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on be... | 2020-05-07 21:35:18 | 2022-10-21 14:53:18 | 2022-10-20 20:41:18 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18861', 'html_url': 'https://github.com/facebook/react/pull/18861', 'diff_url': 'https://github.com/facebook/react/pull/18861.diff', 'patch_url': 'https://github.com/facebook/react/pull/18861.patch', 'merged_at': None} | ## Summary
The current `additionalHooks` in the react-hooks/exhaustive-deps eslint plugin accepts a regular expression to match hook names. It always assumes the following format:
```
function useCustomHook(callback, deps) {}
```
However, this format is not always convenient when other arguments are availabl... | {'url': 'https://api.github.com/repos/facebook/react/issues/18861/reactions', 'total_count': 16, '+1': 16, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18861/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18860 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18860/labels{/name} | https://api.github.com/repos/facebook/react/issues/18860/comments | https://api.github.com/repos/facebook/react/issues/18860/events | https://github.com/facebook/react/pull/18860 | 614,276,669 | MDExOlB1bGxSZXF1ZXN0NDE0ODY1MTc4 | 18,860 | Disable Webpack setImmediate polyfill for DevTools | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18860/builds/25090) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-07 19:02:36 | 2020-05-07 21:05:40 | 2020-05-07 20:13:48 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18860', 'html_url': 'https://github.com/facebook/react/pull/18860', 'diff_url': 'https://github.com/facebook/react/pull/18860.diff', 'patch_url': 'https://github.com/facebook/react/pull/18860.patch', 'merged_at': datetime.datetime(2020, 5, 7, 20, 13, 48)} | This pollutes `window`.
I also went ahead and updated Webpack dependencies to the latest versions. | {'url': 'https://api.github.com/repos/facebook/react/issues/18860/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18860/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18859 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18859/labels{/name} | https://api.github.com/repos/facebook/react/issues/18859/comments | https://api.github.com/repos/facebook/react/issues/18859/events | https://github.com/facebook/react/issues/18859 | 614,073,602 | MDU6SXNzdWU2MTQwNzM2MDI= | 18,859 | Error: "Commit tree already contains fiber "19587". This is a bug in React DevTools." | {'login': 'phoenisx', 'id': 11786283, 'node_id': 'MDQ6VXNlcjExNzg2Mjgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/11786283?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/phoenisx', 'html_url': 'https://github.com/phoenisx', 'followers_url': 'https://api.github.com/users/phoenisx/followers',... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"What does this mean?\r\n\r\n> Moving to second capture, the Profiler crashed.\r\n\r\nCan you repro this bug? And if so, could you share steps for repro with us?",
"Sorry for not providing enough details, but even I don't have enough details. This error just popped up when I was profiling my app in React Devtools... | 2020-05-07 13:49:45 | 2021-05-05 15:21:32 | 2021-05-05 02:28:17 | NONE | null | null | null | ### Describe what you were doing when the bug occurred:
1. I did profiling on a list, that gets updated on each pagination api call.
2. Once the profiling was done, I moved around in the Profiler to view the Flamegraph
3. Moving to second capture, the Profiler crashed.
**DevTools version**: 4.6.0-6cceaeb67
`... | {'url': 'https://api.github.com/repos/facebook/react/issues/18859/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18859/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18858 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18858/labels{/name} | https://api.github.com/repos/facebook/react/issues/18858/comments | https://api.github.com/repos/facebook/react/issues/18858/events | https://github.com/facebook/react/issues/18858 | 613,979,299 | MDU6SXNzdWU2MTM5NzkyOTk= | 18,858 | [eslint-plugin-react-hooks] async functions should be allowed for custom effects | {'login': 'vkurchatkin', 'id': 2993861, 'node_id': 'MDQ6VXNlcjI5OTM4NjE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2993861?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vkurchatkin', 'html_url': 'https://github.com/vkurchatkin', 'followers_url': 'https://api.github.com/users/vkurchatkin/f... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js#L104 is where the check happens. \r\n\r\niiuc, this is to allow passing back a cleanup/cancel function, which is much harder with your abstraction. I hope you've considered those ramifications and have your own w... | 2020-05-07 11:23:33 | 2020-05-28 14:18:29 | 2020-05-26 15:13:54 | NONE | null | null | null | Consider the following code:
```js
useAsyncEffect(async () => {
await foo()
}, []);
```
Eslint give the following error:
```js
11:18 error Effect callbacks are synchronous to prevent race conditions. Put the async function inside:
useEffect(() => {
async function fetchData() {
// You can ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18858/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18858/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18857 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18857/labels{/name} | https://api.github.com/repos/facebook/react/issues/18857/comments | https://api.github.com/repos/facebook/react/issues/18857/events | https://github.com/facebook/react/issues/18857 | 613,941,449 | MDU6SXNzdWU2MTM5NDE0NDk= | 18,857 | [eslint-plugin-react-hooks] just mark react's implemented hooks as invalid in classes | {'login': 'DoubleU23', 'id': 5007050, 'node_id': 'MDQ6VXNlcjUwMDcwNTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5007050?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/DoubleU23', 'html_url': 'https://github.com/DoubleU23', 'followers_url': 'https://api.github.com/users/DoubleU23/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Similar issue here. I use a non-redux store library which is based on classes. These classes define custom hooks as methods and they use react hooks internally. These classes aren't inherited from React.Component and they also don't have render() method. I understand why hooks can't be used at class components but... | 2020-05-07 10:19:52 | 2022-03-30 00:42:13 | 2022-03-30 00:42:13 | NONE | null | null | null | ## The current behavior
`react-hooks/rules-of-hooks` marks custom hooks to be invalid in classes
## The expected behavior
imho this rules should only mark react's implemented hooks as invalid in classes
__as the rule states:__
"React Hook "useTranslation" cannot be called in a class component.
React Hooks m... | {'url': 'https://api.github.com/repos/facebook/react/issues/18857/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18857/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18856 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18856/labels{/name} | https://api.github.com/repos/facebook/react/issues/18856/comments | https://api.github.com/repos/facebook/react/issues/18856/events | https://github.com/facebook/react/issues/18856 | 613,895,728 | MDU6SXNzdWU2MTM4OTU3Mjg= | 18,856 | Provide a prop on `<Suspense>` to let children mount/unmount instead of changing style | {'login': 'huozhi', 'id': 4800338, 'node_id': 'MDQ6VXNlcjQ4MDAzMzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4800338?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/huozhi', 'html_url': 'https://github.com/huozhi', 'followers_url': 'https://api.github.com/users/huozhi/followers', 'followin... | [] | closed | false | null | [] | null | [
"Could you explain your specific usecase/issue that makes you desire this behaviour? ",
"@threepointone I came across this behavior when I was doing snapshot for suspense rendering results with jest. I need to filter out the hidden children and find the actual rendered fallback element to detect if it's suspended... | 2020-05-07 09:07:04 | 2020-05-07 11:44:21 | 2020-05-07 11:44:21 | CONTRIBUTOR | null | null | null | ## Feature Request
Currently react render children of Suspense with inline style `display: none !important`, [referenced PR](https://github.com/facebook/react/pull/15861/files). would like to have a prop like `mount` or sth else to remount the children when suspended state changed.
## Example
```jsx
const Chi... | {'url': 'https://api.github.com/repos/facebook/react/issues/18856/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18856/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18855 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18855/labels{/name} | https://api.github.com/repos/facebook/react/issues/18855/comments | https://api.github.com/repos/facebook/react/issues/18855/events | https://github.com/facebook/react/pull/18855 | 613,845,089 | MDExOlB1bGxSZXF1ZXN0NDE0NTE2MTcx | 18,855 | rough implementation of direct context updates | {'login': 'gnoff', 'id': 2716369, 'node_id': 'MDQ6VXNlcjI3MTYzNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2716369?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gnoff', 'html_url': 'https://github.com/gnoff', 'followers_url': 'https://api.github.com/users/gnoff/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"@sebmarkbage this was somewhat extracted from my PR on speculative work. It's not strictly necessary for any of that but seems perhaps a worthy goal to change the context prop perf scaling in a meaningful way. would love to know if I struck the right balance there while keeping mount, unmount, and \"contexts that ... | 2020-05-07 07:43:36 | 2020-10-04 06:19:58 | 2020-10-04 06:19:58 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18855', 'html_url': 'https://github.com/facebook/react/pull/18855', 'diff_url': 'https://github.com/facebook/react/pull/18855.diff', 'patch_url': 'https://github.com/facebook/react/pull/18855.patch', 'merged_at': None} | This is an early implementation of an alternative method of propagating context updates which avoids walking the Provider's sub-tree
Will update description with more detail soon but high level
## Implementation
- when creating a context dependency (a read) if no `reader` yet exists, attach one.
- readers provi... | {'url': 'https://api.github.com/repos/facebook/react/issues/18855/reactions', 'total_count': 2, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 2} | https://api.github.com/repos/facebook/react/issues/18855/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18854 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18854/labels{/name} | https://api.github.com/repos/facebook/react/issues/18854/comments | https://api.github.com/repos/facebook/react/issues/18854/events | https://github.com/facebook/react/pull/18854 | 613,813,209 | MDExOlB1bGxSZXF1ZXN0NDE0NDkxOTYy | 18,854 | Don't cut off the tail of a SuspenseList if hydrating | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18854/builds/24952) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-07 06:43:19 | 2020-05-07 06:51:47 | 2020-05-07 06:51:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18854', 'html_url': 'https://github.com/facebook/react/pull/18854', 'diff_url': 'https://github.com/facebook/react/pull/18854.diff', 'patch_url': 'https://github.com/facebook/react/pull/18854.patch', 'merged_at': datetime.datetime(2020, 5, 7, 6, 51, 47)} | SuspenseList doesn't really support collapsed/hidden on the server atm. It doesn't make sense without streaming rendering.
If we're hydrating, we can't cut off the tail. Because if we do, then we skip hydrating those rows and as result, we leave them in the DOM forever.
This whole thing doesn't quite add up witho... | {'url': 'https://api.github.com/repos/facebook/react/issues/18854/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18854/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18853 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18853/labels{/name} | https://api.github.com/repos/facebook/react/issues/18853/comments | https://api.github.com/repos/facebook/react/issues/18853/events | https://github.com/facebook/react/issues/18853 | 613,750,028 | MDU6SXNzdWU2MTM3NTAwMjg= | 18,853 | Bug: Devtools conceal lack of setImmediate polyfill | {'login': 'matt-tingen', 'id': 8584728, 'node_id': 'MDQ6VXNlcjg1ODQ3Mjg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8584728?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/matt-tingen', 'html_url': 'https://github.com/matt-tingen', 'followers_url': 'https://api.github.com/users/matt-tingen/f... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"DevTools does not do this. It's a Webpack polyfill :frown:\r\n\r\nFunny timing for you to file this, as it was just fixed earlier today: #18860\r\n\r\nFix will roll out with the next week."
] | 2020-05-07 03:38:24 | 2020-05-07 22:36:50 | 2020-05-07 22:36:50 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: N/A; sample app uses 16.13.1
Devtools version: 6cceaeb67 on FF a... | {'url': 'https://api.github.com/repos/facebook/react/issues/18853/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18853/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18852 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18852/labels{/name} | https://api.github.com/repos/facebook/react/issues/18852/comments | https://api.github.com/repos/facebook/react/issues/18852/events | https://github.com/facebook/react/pull/18852 | 613,747,614 | MDExOlB1bGxSZXF1ZXN0NDE0NDM5OTcw | 18,852 | [DevTools] Allow to continue dragging when leaving profiler picker | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18852/builds/25292) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-07 03:29:49 | 2020-05-08 18:53:37 | 2020-05-08 18:19:58 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18852', 'html_url': 'https://github.com/facebook/react/pull/18852', 'diff_url': 'https://github.com/facebook/react/pull/18852.diff', 'patch_url': 'https://github.com/facebook/react/pull/18852.patch', 'merged_at': datetime.datetime(2020, 5, 8, 18, 19, 58)} | Do not stop computing value when leaving profiler picker during dragging, resolve #16492
bvaughn/react-devtools-experimental#141
**Before:**
**After:**
![Peek 2020-05-07 after-dr... | {'url': 'https://api.github.com/repos/facebook/react/issues/18852/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18852/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18851 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18851/labels{/name} | https://api.github.com/repos/facebook/react/issues/18851/comments | https://api.github.com/repos/facebook/react/issues/18851/events | https://github.com/facebook/react/pull/18851 | 613,743,191 | MDExOlB1bGxSZXF1ZXN0NDE0NDM2NzQy | 18,851 | Disable setState before mount warning in legacy mode | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18851/builds/24917) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-07 03:16:35 | 2020-05-07 03:31:01 | 2020-05-07 03:31:00 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18851', 'html_url': 'https://github.com/facebook/react/pull/18851', 'diff_url': 'https://github.com/facebook/react/pull/18851.diff', 'patch_url': 'https://github.com/facebook/react/pull/18851.patch', 'merged_at': datetime.datetime(2020, 5, 7, 3, 31)} | We kind of "support" this pattern in legacy mode. It's only deprecated in Concurrent Mode.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18851/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18851/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18850 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18850/labels{/name} | https://api.github.com/repos/facebook/react/issues/18850/comments | https://api.github.com/repos/facebook/react/issues/18850/events | https://github.com/facebook/react/pull/18850 | 613,720,483 | MDExOlB1bGxSZXF1ZXN0NDE0NDE5NDIz | 18,850 | Put render phase update change behind a flag | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18850/builds/24912) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-07 02:02:18 | 2020-05-07 02:19:15 | 2020-05-07 02:19:15 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18850', 'html_url': 'https://github.com/facebook/react/pull/18850', 'diff_url': 'https://github.com/facebook/react/pull/18850.diff', 'patch_url': 'https://github.com/facebook/react/pull/18850.patch', 'merged_at': datetime.datetime(2020, 5, 7, 2, 19, 15)} | In the new reconciler, I made a change to how render phase updates work. (By render phase updates, I mean when a component updates another component during its render phase. Or when a class component updates itself during the render phase. It does not include when a hook updates its own component during the render phas... | {'url': 'https://api.github.com/repos/facebook/react/issues/18850/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18850/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18849 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18849/labels{/name} | https://api.github.com/repos/facebook/react/issues/18849/comments | https://api.github.com/repos/facebook/react/issues/18849/events | https://github.com/facebook/react/pull/18849 | 613,660,903 | MDExOlB1bGxSZXF1ZXN0NDE0MzcyODAz | 18,849 | Modern Event System: fix bug in EnterLeave | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18849/builds/24890) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-06 22:51:57 | 2020-05-06 23:21:15 | 2020-05-06 23:13:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18849', 'html_url': 'https://github.com/facebook/react/pull/18849', 'diff_url': 'https://github.com/facebook/react/pull/18849.diff', 'patch_url': 'https://github.com/facebook/react/pull/18849.patch', 'merged_at': datetime.datetime(2020, 5, 6, 23, 13, 13)} | This fixes a bug I accidently introduced in https://github.com/facebook/react/pull/18830.
Notably, I hoisted out the `related` const, but only today noticed they were two different related constants. One was `nativeEvent.relatedTarget || nativeEvent.fromElement;` and the other was `nativeEvent.relatedTarget || nativ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18849/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18849/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18848 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18848/labels{/name} | https://api.github.com/repos/facebook/react/issues/18848/comments | https://api.github.com/repos/facebook/react/issues/18848/events | https://github.com/facebook/react/issues/18848 | 613,566,649 | MDU6SXNzdWU2MTM1NjY2NDk= | 18,848 | Bug: useLayoutEffect callback called twice when a dom node is in a dependency array | {'login': 'everdimension', 'id': 5347023, 'node_id': 'MDQ6VXNlcjUzNDcwMjM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5347023?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/everdimension', 'html_url': 'https://github.com/everdimension', 'followers_url': 'https://api.github.com/users/everdim... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"You are not supposed to use `ref.current` as a dependency, since changing it doesn't result in a rerender. \r\n\r\nThere is no bug in React. `ref.current` is `undefined` initially, then your effect is triggered, `setState` is called, which results in a rerender. `ref.current` is not `undefined` anymore, so the eff... | 2020-05-06 19:43:49 | 2020-05-07 11:59:24 | 2020-05-06 20:48:04 | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: v16.3.1
## Steps To Reproduce
1. add `useLayoutEffect`
2. ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18848/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18848/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18847 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18847/labels{/name} | https://api.github.com/repos/facebook/react/issues/18847/comments | https://api.github.com/repos/facebook/react/issues/18847/events | https://github.com/facebook/react/pull/18847 | 613,508,031 | MDExOlB1bGxSZXF1ZXN0NDE0MjQ4NTA5 | 18,847 | Updated DevTools unstable_ API references | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18847/builds/24853) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-06 18:02:35 | 2020-05-06 18:14:34 | 2020-05-06 18:14:31 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18847', 'html_url': 'https://github.com/facebook/react/pull/18847', 'diff_url': 'https://github.com/facebook/react/pull/18847.diff', 'patch_url': 'https://github.com/facebook/react/pull/18847.patch', 'merged_at': datetime.datetime(2020, 5, 6, 18, 14, 31)} | PR #18825 broke the DevTools targets (which all use `createRoot`) and the test shell app (which uses `SuspenseList`). | {'url': 'https://api.github.com/repos/facebook/react/issues/18847/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18847/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18846 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18846/labels{/name} | https://api.github.com/repos/facebook/react/issues/18846/comments | https://api.github.com/repos/facebook/react/issues/18846/events | https://github.com/facebook/react/issues/18846 | 613,500,928 | MDU6SXNzdWU2MTM1MDA5Mjg= | 18,846 | Bug: StrictMode makes Component render repeatedly? | {'login': 'Grewer', 'id': 21995246, 'node_id': 'MDQ6VXNlcjIxOTk1MjQ2', 'avatar_url': 'https://avatars.githubusercontent.com/u/21995246?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Grewer', 'html_url': 'https://github.com/Grewer', 'followers_url': 'https://api.github.com/users/Grewer/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I found same issue, so close it"
] | 2020-05-06 17:50:14 | 2020-05-06 17:54:05 | 2020-05-06 17:53:55 | NONE | null | null | null | React version:
react: 16.13.1
react-dom: 16.13.1
## Steps To Reproduce
1. Observe the value printed in the console
Link to code example:
https://codesandbox.io/s/react-test-usestate-xvuxs?file=/src/App.js
## The current behavior
### normal conditions:
```
function Test() {
const [test] = ['testStr'];... | {'url': 'https://api.github.com/repos/facebook/react/issues/18846/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18846/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18845 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18845/labels{/name} | https://api.github.com/repos/facebook/react/issues/18845/comments | https://api.github.com/repos/facebook/react/issues/18845/events | https://github.com/facebook/react/pull/18845 | 613,454,245 | MDExOlB1bGxSZXF1ZXN0NDE0MjA1MDky | 18,845 | [Release] Follow redirect when downloading tarball | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18845/builds/24846) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-06 16:33:27 | 2020-05-06 17:28:50 | 2020-05-06 17:28:50 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18845', 'html_url': 'https://github.com/facebook/react/pull/18845', 'diff_url': 'https://github.com/facebook/react/pull/18845.diff', 'patch_url': 'https://github.com/facebook/react/pull/18845.patch', 'merged_at': datetime.datetime(2020, 5, 6, 17, 28, 50)} | Adds -L option to `curl` command.
See: https://curl.haxx.se/docs/manpage.html#-L | {'url': 'https://api.github.com/repos/facebook/react/issues/18845/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18845/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18844 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18844/labels{/name} | https://api.github.com/repos/facebook/react/issues/18844/comments | https://api.github.com/repos/facebook/react/issues/18844/events | https://github.com/facebook/react/issues/18844 | 613,452,867 | MDU6SXNzdWU2MTM0NTI4Njc= | 18,844 | Bug: Render after suspense is thrown away leaving DOM unmatched with state | {'login': 'joeljeske', 'id': 5332920, 'node_id': 'MDQ6VXNlcjUzMzI5MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5332920?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/joeljeske', 'html_url': 'https://github.com/joeljeske', 'followers_url': 'https://api.github.com/users/joeljeske/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 739761016, 'node_id': 'MDU6TGFiZWw3Mzk3NjEwMTY=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"We ran into this same problem, the codesandbox seems like a pretty good reproduction case.\r\n\r\nWe're on React 16.9 / React Native 0.61.5.",
"I think this is a duplicate of https://github.com/facebook/react/issues/17356.\r\n\r\n>seems related to memoization but this does not use any memoization\r\n\r\nIt does ... | 2020-05-06 16:31:08 | 2020-06-30 21:06:47 | 2020-06-30 21:06:47 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.12.0
## Steps To Reproduce
A component that suspends as... | {'url': 'https://api.github.com/repos/facebook/react/issues/18844/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18844/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18843 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18843/labels{/name} | https://api.github.com/repos/facebook/react/issues/18843/comments | https://api.github.com/repos/facebook/react/issues/18843/events | https://github.com/facebook/react/issues/18843 | 613,354,386 | MDU6SXNzdWU2MTMzNTQzODY= | 18,843 | "Pause on caught exceptions" enabled always breaks on this line | {'login': 'kylechartio', 'id': 55005058, 'node_id': 'MDQ6VXNlcjU1MDA1MDU4', 'avatar_url': 'https://avatars.githubusercontent.com/u/55005058?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kylechartio', 'html_url': 'https://github.com/kylechartio', 'followers_url': 'https://api.github.com/users/kylechartio... | [{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Developer%20Tools', 'name': 'Component: Developer Tools', 'color': 'fbca04', 'default': False, 'description': None}
{'id': 725156255, 'node_id': 'MDU6TGFiZWw3MjUxNTYyNTU=', 'url': 'https://... | closed | false | {'login': 'sktguha', 'id': 8387608.0, 'node_id': 'MDQ6VXNlcjgzODc2MDg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8387608?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sktguha', 'html_url': 'https://github.com/sktguha', 'followers_url': 'https://api.github.com/users/sktguha/followers', 'fo... | [{'login': 'sktguha', 'id': 8387608, 'node_id': 'MDQ6VXNlcjgzODc2MDg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8387608?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sktguha', 'html_url': 'https://github.com/sktguha', 'followers_url': 'https://api.github.com/users/sktguha/followers', 'fol... | null | [
"Yeah, I can see why this would be a little annoying. This same hook is being used in a couple of different contexts, and in the browser one- we expect things to be a little busted, as the inline comment above mentions:\r\nhttps://github.com/facebook/react/blob/c2d1561c60507189b43ae96c6b89580874367e36/packages/reac... | 2020-05-06 14:14:46 | 2020-10-12 17:07:46 | 2020-10-12 17:07:11 | NONE | null | null | null | In Chrome, when I am using the current stable version of react devtools extenison (4.6.0 (3/26/2020)), if I have "Pause on caught exceptions" enabled, I always hit this breakpoint:
https://github.com/facebook/react/blob/c2d1561c60507189b43ae96c6b89580874367e36/packages/react-devtools-shared/src/hook.js#L185
`Refe... | {'url': 'https://api.github.com/repos/facebook/react/issues/18843/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18843/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.