url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/18741 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18741/labels{/name} | https://api.github.com/repos/facebook/react/issues/18741/comments | https://api.github.com/repos/facebook/react/issues/18741/events | https://github.com/facebook/react/issues/18741 | 606,950,824 | MDU6SXNzdWU2MDY5NTA4MjQ= | 18,741 | useEffect with Suspense transitions | {'login': 'subhero24', 'id': 1171150, 'node_id': 'MDQ6VXNlcjExNzExNTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1171150?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/subhero24', 'html_url': 'https://github.com/subhero24', 'followers_url': 'https://api.github.com/users/subhero24/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"Hi hi! Could you provide and example using https://codesandbox.io/ ? It will help us understand your question more! Thanks!",
"@rachelnabors I made an example at [codesandbox](https://codesandbox.io/s/keen-ride-dxnvy?file=/src/App.js)\r\n\r\nWhile making the example, I realised the problem is not really about us... | 2020-04-26 08:08:56 | 2020-09-29 13:04:28 | 2020-09-29 13:04:28 | NONE | null | null | null | I have a question regarding the expected behaviour of effects in combination with transitions.
When a state transition is wrapped with a useTransition and, before the transition completes, there is some user interaction causing a new state transition (which sets the same state to another value). React executes the eff... | {'url': 'https://api.github.com/repos/facebook/react/issues/18741/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18741/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18740 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18740/labels{/name} | https://api.github.com/repos/facebook/react/issues/18740/comments | https://api.github.com/repos/facebook/react/issues/18740/events | https://github.com/facebook/react/issues/18740 | 606,903,133 | MDU6SXNzdWU2MDY5MDMxMzM= | 18,740 | Bug: 一个问题，不懂，麻烦解释一下，谢谢 | {'login': 'MARIOMARUI', 'id': 48650709, 'node_id': 'MDQ6VXNlcjQ4NjUwNzA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/48650709?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/MARIOMARUI', 'html_url': 'https://github.com/MARIOMARUI', 'followers_url': 'https://api.github.com/users/MARIOMARUI/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"有图让你理解\r\n\r\n",
"\r\n\r\n\r\n1. if you have any problems that you don't understand. please ask at the right place like StackOverflow. \r\n2. ENGLISH Please. do not pollute issues section in Chinese, it's... | 2020-04-26 02:50:18 | 2020-09-05 20:10:10 | 2020-09-05 20:10:10 | NONE | null | null | null | return (
<div>
Hello
{document.title = `You click ${count} times`}
<button onClick={() => { setCount(count + 1) }}>Add</button>
</div>
)
}
为什么这种方式能够修改title 也能在页面中显示You click 0 times 呢 | {'url': 'https://api.github.com/repos/facebook/react/issues/18740/reactions', 'total_count': 4, '+1': 0, '-1': 4, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18740/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18739 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18739/labels{/name} | https://api.github.com/repos/facebook/react/issues/18739/comments | https://api.github.com/repos/facebook/react/issues/18739/events | https://github.com/facebook/react/pull/18739 | 606,884,593 | MDExOlB1bGxSZXF1ZXN0NDA4OTkxNzgx | 18,739 | Removes duplicate if statement | {'login': 'JesuHrz', 'id': 28031187, 'node_id': 'MDQ6VXNlcjI4MDMxMTg3', 'avatar_url': 'https://avatars.githubusercontent.com/u/28031187?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JesuHrz', 'html_url': 'https://github.com/JesuHrz', 'followers_url': 'https://api.github.com/users/JesuHrz/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"Hi @JesuHrz! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beha... | 2020-04-26 00:25:25 | 2020-09-07 09:04:22 | 2020-09-07 09:04:22 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18739', 'html_url': 'https://github.com/facebook/react/pull/18739', 'diff_url': 'https://github.com/facebook/react/pull/18739.diff', 'patch_url': 'https://github.com/facebook/react/pull/18739.patch', 'merged_at': None} | ## Summary
This PR refectories a block of code that is duplicated multiple times in this file, so that it can be used in some other part of the code without adding this block again | {'url': 'https://api.github.com/repos/facebook/react/issues/18739/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18739/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18738 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18738/labels{/name} | https://api.github.com/repos/facebook/react/issues/18738/comments | https://api.github.com/repos/facebook/react/issues/18738/events | https://github.com/facebook/react/pull/18738 | 606,866,547 | MDExOlB1bGxSZXF1ZXN0NDA4OTc4MzUy | 18,738 | SuspenseList: Reschedule continuation at same priority | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18738/builds/22383) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-25 22:16:11 | 2020-04-27 04:39:59 | 2020-04-26 03:27:36 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18738', 'html_url': 'https://github.com/facebook/react/pull/18738', 'diff_url': 'https://github.com/facebook/react/pull/18738.diff', 'patch_url': 'https://github.com/facebook/react/pull/18738.patch', 'merged_at': datetime.datetime(2020, 4, 26, 3, 27, 36)} | SuspenseList progressively renders items even if the list is CPU bound, i.e. it isn't waiting for missing data. It does this by showing a fallback for the remaining items, committing the items in that have already finished, then starting a new render to continue working on the rest.
When it schedules that subsequent... | {'url': 'https://api.github.com/repos/facebook/react/issues/18738/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18738/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18737 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18737/labels{/name} | https://api.github.com/repos/facebook/react/issues/18737/comments | https://api.github.com/repos/facebook/react/issues/18737/events | https://github.com/facebook/react/pull/18737 | 606,807,406 | MDExOlB1bGxSZXF1ZXN0NDA4OTM1NDU5 | 18,737 | Devtools: Show inspectedElement `key` in right pane | {'login': 'karlhorky', 'id': 1935696, 'node_id': 'MDQ6VXNlcjE5MzU2OTY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1935696?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/karlhorky', 'html_url': 'https://github.com/karlhorky', 'followers_url': 'https://api.github.com/users/karlhorky/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"@bvaughn what do you think of this (admittedly naïve) approach? Am I missing something? I didn't see where `inspectedElement` was getting set in the 30 minutes that I put into this, so I'm not sure if the additional `key` in the type is going to cause problems.",
"This pull request is automatically built and tes... | 2020-04-25 16:37:21 | 2020-05-12 15:30:00 | 2020-05-11 20:17:15 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18737', 'html_url': 'https://github.com/facebook/react/pull/18737', 'diff_url': 'https://github.com/facebook/react/pull/18737.diff', 'patch_url': 'https://github.com/facebook/react/pull/18737.patch', 'merged_at': datetime.datetime(2020, 5, 11, 20, 17, 14)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18737/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18737/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18736 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18736/labels{/name} | https://api.github.com/repos/facebook/react/issues/18736/comments | https://api.github.com/repos/facebook/react/issues/18736/events | https://github.com/facebook/react/issues/18736 | 606,800,042 | MDU6SXNzdWU2MDY4MDAwNDI= | 18,736 | Bug: Installation error on npx create-react-app my-app | {'login': 'neupaneanish', 'id': 26538899, 'node_id': 'MDQ6VXNlcjI2NTM4ODk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/26538899?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/neupaneanish', 'html_url': 'https://github.com/neupaneanish', 'followers_url': 'https://api.github.com/users/neupanea... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I'm experiencing the same issue.",
"The issue here is with is-promise a core package on alot of frameworks pushed out a dodgy update in last hour \r\nhttps://github.com/then/is-promise/pull/15 is the PR to fix apparently and here the bug to tack https://github.com/then/is-promise/issues/12\r\n\r\n\r\nthis has al... | 2020-04-25 16:01:08 | 2020-04-25 18:10:48 | 2020-04-25 18:10:48 | NONE | null | null | null | node version : 12.16.2
npm version: 6.14.4
os: Windows 10
while creating new app with this cl npx create-react-app my-app gives this error
PS D:\> npx create-react-app my-app
npx: installed 99 in 16.418s
Must use import to load ES Module: C:\Users\Nexus\AppData\Roaming\npm-cache\_npx\16380\node_modules\crea... | {'url': 'https://api.github.com/repos/facebook/react/issues/18736/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18736/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18735 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18735/labels{/name} | https://api.github.com/repos/facebook/react/issues/18735/comments | https://api.github.com/repos/facebook/react/issues/18735/events | https://github.com/facebook/react/issues/18735 | 606,785,708 | MDU6SXNzdWU2MDY3ODU3MDg= | 18,735 | Bug: Invariant Violation: Should have a queue when mocking same function differently in tests | {'login': 'AvraamMavridis', 'id': 283690, 'node_id': 'MDQ6VXNlcjI4MzY5MA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/283690?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/AvraamMavridis', 'html_url': 'https://github.com/AvraamMavridis', 'followers_url': 'https://api.github.com/users/Avraam... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-04-25 14:53:18 | 2020-08-01 09:10:12 | 2020-08-01 09:10:12 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.9.0
## Steps To Reproduce
1. Mock the same function that... | {'url': 'https://api.github.com/repos/facebook/react/issues/18735/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18735/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18734 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18734/labels{/name} | https://api.github.com/repos/facebook/react/issues/18734/comments | https://api.github.com/repos/facebook/react/issues/18734/events | https://github.com/facebook/react/issues/18734 | 606,736,735 | MDU6SXNzdWU2MDY3MzY3MzU= | 18,734 | Bug: Prints only once: [Warning: Can't perform a React state update on an unmounted component.] | {'login': 'icyJoseph', 'id': 21013447, 'node_id': 'MDQ6VXNlcjIxMDEzNDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/21013447?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/icyJoseph', 'html_url': 'https://github.com/icyJoseph', 'followers_url': 'https://api.github.com/users/icyJoseph/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"I also meet the problem. Do you have the solution?",
"Oh, I found the solution at https://github.com/facebook/react/issues/15006",
"@lizhongzhen11 careful, this issue is **not about the warning, or how to fix it**, but rather, about the warning **only showing once**, even though the error **keeps on happening ... | 2020-04-25 10:08:39 | 2020-05-29 09:14:18 | 2020-05-29 09:14:18 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
It is known that one should clean up either on effect hooks or life cycles, to pre... | {'url': 'https://api.github.com/repos/facebook/react/issues/18734/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18734/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18733 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18733/labels{/name} | https://api.github.com/repos/facebook/react/issues/18733/comments | https://api.github.com/repos/facebook/react/issues/18733/events | https://github.com/facebook/react/pull/18733 | 606,701,581 | MDExOlB1bGxSZXF1ZXN0NDA4ODU4NDMz | 18,733 | Unhide Suspense trees without entanglement | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: ac533fde3dff81023809a92d3f5432df7fc2c418...9ea9c5fc55021dfa3f5445f6d295dfcf7fc0d256</p>\n\n\n \n## react-dom\nFile | Fi... | 2020-04-25 06:19:07 | 2020-05-01 02:38:14 | 2020-05-01 02:38:14 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18733', 'html_url': 'https://github.com/facebook/react/pull/18733', 'diff_url': 'https://github.com/facebook/react/pull/18733.diff', 'patch_url': 'https://github.com/facebook/react/pull/18733.patch', 'merged_at': None} | When a Suspense boundary is in its fallback state, you cannot switch back to the main content without also finishing any updates inside the tree that might have been skipped. That would be a form of tearing.
Before we fixed this in #18411, the way this bug manifested was that a boundary was suspended by an update th... | {'url': 'https://api.github.com/repos/facebook/react/issues/18733/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18733/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18732 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18732/labels{/name} | https://api.github.com/repos/facebook/react/issues/18732/comments | https://api.github.com/repos/facebook/react/issues/18732/events | https://github.com/facebook/react/pull/18732 | 606,657,244 | MDExOlB1bGxSZXF1ZXN0NDA4ODI0Mjgw | 18,732 | Make ExpirationTime an opaque type | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18732/builds/22238) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-25 01:07:46 | 2020-05-03 04:33:35 | 2020-04-25 06:26:05 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18732', 'html_url': 'https://github.com/facebook/react/pull/18732', 'diff_url': 'https://github.com/facebook/react/pull/18732.diff', 'patch_url': 'https://github.com/facebook/react/pull/18732.patch', 'merged_at': datetime.datetime(2020, 4, 25, 6, 26, 5)} | This is a series of commits that turns ExpirationTime into an opaque type.
They don't really deliver much value on their own, but they unblock later steps in an ongoing refactor to our internal concurrency and scheduling architecture. | {'url': 'https://api.github.com/repos/facebook/react/issues/18732/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18732/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18731 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18731/labels{/name} | https://api.github.com/repos/facebook/react/issues/18731/comments | https://api.github.com/repos/facebook/react/issues/18731/events | https://github.com/facebook/react/issues/18731 | 606,639,513 | MDU6SXNzdWU2MDY2Mzk1MTM= | 18,731 | Bug: React Context API is not working from custom NPM library | {'login': 'ayayalar', 'id': 130195, 'node_id': 'MDQ6VXNlcjEzMDE5NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/130195?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ayayalar', 'html_url': 'https://github.com/ayayalar', 'followers_url': 'https://api.github.com/users/ayayalar/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"If you can't reproduce it using a single a file, it is a problem with your build configuration, not React",
"Yes, I thought that might be a problem. However, the build configuration is quite simple. There is nothing special about it. Can you elaborate how did you come to your conclusion? ",
"React works the sa... | 2020-04-24 23:43:31 | 2020-04-25 20:07:21 | 2020-04-25 20:07:21 | NONE | null | null | null |
I have total of three npm packages:
1) Custom Hook: custom hook wraps useContext
2) Provider: uses custom hook to Provide Context
3) Consumer: uses custom hook to Retrieve Context
If I have these components in a single app, everything works as expected. However, if I separate them to their own npm packages, the... | {'url': 'https://api.github.com/repos/facebook/react/issues/18731/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18731/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18730 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18730/labels{/name} | https://api.github.com/repos/facebook/react/issues/18730/comments | https://api.github.com/repos/facebook/react/issues/18730/events | https://github.com/facebook/react/pull/18730 | 606,598,353 | MDExOlB1bGxSZXF1ZXN0NDA4Nzc2NTUy | 18,730 | Root API should clear non-empty roots before mounting | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18730/builds/23087) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-24 21:38:31 | 2020-04-28 20:07:47 | 2020-04-28 20:07:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18730', 'html_url': 'https://github.com/facebook/react/pull/18730', 'diff_url': 'https://github.com/facebook/react/pull/18730.diff', 'patch_url': 'https://github.com/facebook/react/pull/18730.patch', 'merged_at': datetime.datetime(2020, 4, 28, 20, 7, 43)} | Legacy render-into-subtree API removes children from a container before rendering into it:
https://github.com/facebook/react/blob/4b02b6611141255a8e8b6d8a997e87c865f06626/packages/react-dom/src/client/ReactDOMLegacy.js#L113-L138
The `createRoot` API **did not do this**. Instead it left previous children around in t... | {'url': 'https://api.github.com/repos/facebook/react/issues/18730/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18730/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18729 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18729/labels{/name} | https://api.github.com/repos/facebook/react/issues/18729/comments | https://api.github.com/repos/facebook/react/issues/18729/events | https://github.com/facebook/react/pull/18729 | 606,573,982 | MDExOlB1bGxSZXF1ZXN0NDA4NzU3NzA2 | 18,729 | Move hide/unhide logic to new Offscreen fiber type | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18729/builds/22257) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-24 20:46:12 | 2020-04-25 07:25:23 | 2020-04-25 07:25:22 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18729', 'html_url': 'https://github.com/facebook/react/pull/18729', 'diff_url': 'https://github.com/facebook/react/pull/18729.diff', 'patch_url': 'https://github.com/facebook/react/pull/18729.patch', 'merged_at': datetime.datetime(2020, 4, 25, 7, 25, 22)} | This adds a new internal Fiber type, Offscreen, and uses it in the Suspense implementation to hide/unhide children when switching between the primary and fallback trees. Most of the logic for hiding/unhiding already existed, so this PR mostly just moves it to the new type. Eventually, the idea is we'll expose an `<Offs... | {'url': 'https://api.github.com/repos/facebook/react/issues/18729/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18729/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18728 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18728/labels{/name} | https://api.github.com/repos/facebook/react/issues/18728/comments | https://api.github.com/repos/facebook/react/issues/18728/events | https://github.com/facebook/react/issues/18728 | 606,545,674 | MDU6SXNzdWU2MDY1NDU2NzQ= | 18,728 | Bug: DevTools hihlights false positives | {'login': 'Mangatt', 'id': 2706990, 'node_id': 'MDQ6VXNlcjI3MDY5OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2706990?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Mangatt', 'html_url': 'https://github.com/Mangatt', 'followers_url': 'https://api.github.com/users/Mangatt/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Oh! I created a form and with hooks and wrapped all components with a memo and the same error happened. Apparently nothing is highlight when render, and the DOM is changing. 😕 \r\nLet me add my sample here: \r\nCode: https://codesandbox.io/s/solitary-sound-8bptv\r\nDemo: https://8bptv.csb.app/",
"This issue ha... | 2020-04-24 19:51:58 | 2020-09-05 20:10:10 | 2020-09-05 20:10:10 | NONE | null | null | null | DevTools version: 4.6.0
## Steps To Reproduce
1. Create wrapping component without dom node
2. Create memoized component with multiple nodes
3. Turn on "Highlight updates when components render" in React DevTools
4. Trigger re-render on wrapping component
In profiler is everything recorded correctly, even w... | {'url': 'https://api.github.com/repos/facebook/react/issues/18728/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18728/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18727 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18727/labels{/name} | https://api.github.com/repos/facebook/react/issues/18727/comments | https://api.github.com/repos/facebook/react/issues/18727/events | https://github.com/facebook/react/issues/18727 | 606,508,752 | MDU6SXNzdWU2MDY1MDg3NTI= | 18,727 | Image cannot find module | {'login': 'cnfreitax', 'id': 60153670, 'node_id': 'MDQ6VXNlcjYwMTUzNjcw', 'avatar_url': 'https://avatars.githubusercontent.com/u/60153670?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cnfreitax', 'html_url': 'https://github.com/cnfreitax', 'followers_url': 'https://api.github.com/users/cnfreitax/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Wrong repo https://github.com/facebook/create-react-app",
"thanks",
"Hi! We use the issue tracker for bug reports and feature requests. @TrySound has already directed you to the right repo, so I'll close this :)\r\n\r\nIf you have a question, please check our community support resources:\r\nhttps://facebook.gi... | 2020-04-24 18:39:03 | 2020-07-09 12:45:41 | 2020-07-09 12:45:41 | NONE | null | null | null | I'm try import imagem whit 'import logo from '../../assets/logo.svg', but, I get 'cannot find module'. I'm sure the path is correct | {'url': 'https://api.github.com/repos/facebook/react/issues/18727/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18727/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18726 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18726/labels{/name} | https://api.github.com/repos/facebook/react/issues/18726/comments | https://api.github.com/repos/facebook/react/issues/18726/events | https://github.com/facebook/react/issues/18726 | 606,313,712 | MDU6SXNzdWU2MDYzMTM3MTI= | 18,726 | Bug: | {'login': 'francois-pasquier', 'id': 19970734, 'node_id': 'MDQ6VXNlcjE5OTcwNzM0', 'avatar_url': 'https://avatars.githubusercontent.com/u/19970734?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/francois-pasquier', 'html_url': 'https://github.com/francois-pasquier', 'followers_url': 'https://api.github.com... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Could try it without `@testing-library/react` but a custom beforeEach/afterEach cleanup? If it still leaks try without `jest`? \r\n\r\nSince we only render a static component I doubt that this is react leaking but rather `@testing-library/react` or `jest`. Maybe that's expected that jest retains some \"things\" fr... | 2020-04-24 13:27:47 | 2020-04-24 15:58:25 | 2020-04-24 15:58:25 | NONE | null | null | null | There seems to be a memory leak when running jest tests
React version: 16.13.1
## Steps To Reproduce
* Pull repo: https://github.com/MeisterTea/react-memory-leak
* `yarn` or `npm install`
* `yarn test:w1`
I am getting a heap size larger than one gigabyte on a produc... | {'url': 'https://api.github.com/repos/facebook/react/issues/18726/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18726/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18725 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18725/labels{/name} | https://api.github.com/repos/facebook/react/issues/18725/comments | https://api.github.com/repos/facebook/react/issues/18725/events | https://github.com/facebook/react/issues/18725 | 606,036,707 | MDU6SXNzdWU2MDYwMzY3MDc= | 18,725 | React Hooks will render multiple times after await | {'login': 'aeroxy', 'id': 2761307, 'node_id': 'MDQ6VXNlcjI3NjEzMDc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2761307?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aeroxy', 'html_url': 'https://github.com/aeroxy', 'followers_url': 'https://api.github.com/users/aeroxy/followers', 'followin... | [{'id': 40929155, 'node_id': 'MDU6TGFiZWw0MDkyOTE1NQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Question', 'name': 'Type: Question', 'color': 'cc317c', 'default': False, 'description': None}
{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebo... | closed | false | null | [] | null | [
"This is inevitable: when you run your code asynchronously, React has no way of knowing that more synchronous setters could be executed after the current one, so it has to trigger render for each. You can either batch by making a single state object, like you did, or use `unstable_batchedUpdates`:\r\n\r\n```js\r\ni... | 2020-04-24 04:45:53 | 2020-04-24 16:15:41 | 2020-04-24 16:15:35 | NONE | null | null | null | ```
const [ html, setHTML ] = useState('');
const [ script, setScript ] = useState('');
const update = (script, html) => {
setScript(script);
setHTML(html);
};
update('a', 'b');
```
The above code works fine, React Hooks will render ONCE and combine setScript & setHTML;
```
const [ html, setHTM... | {'url': 'https://api.github.com/repos/facebook/react/issues/18725/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18725/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18724 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18724/labels{/name} | https://api.github.com/repos/facebook/react/issues/18724/comments | https://api.github.com/repos/facebook/react/issues/18724/events | https://github.com/facebook/react/issues/18724 | 605,970,303 | MDU6SXNzdWU2MDU5NzAzMDM= | 18,724 | [react-hooks/exhaustive-deps] inconsistant object and object.key | {'login': 'alex-cory', 'id': 5455859, 'node_id': 'MDQ6VXNlcjU0NTU4NTk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5455859?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alex-cory', 'html_url': 'https://github.com/alex-cory', 'followers_url': 'https://api.github.com/users/alex-cory/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> I'm assuming the expected behavior for react is to require `response.ok`, but since it's allowing `response` I'm curious if that is okay too?\r\n\r\nGenerally speaking, the answer would be no. The dependencies array exists to avoid stale values in the callback function you pass to `useEffect`. (You can find stal... | 2020-04-24 01:16:51 | 2020-04-24 17:05:34 | 2020-04-24 16:10:35 | NONE | null | null | null |
React version: 16.13.1
## Steps To Reproduce
1. run the code in this [Codesandbox](https://codesandbox.io/s/usefetch-getter-exhaustive-deps-bug-1zic7?file=/src/index.js)
## The current behavior
I have a `response` object that I am using between various `useCallback` functions. I would like to mention th... | {'url': 'https://api.github.com/repos/facebook/react/issues/18724/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18724/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18723 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18723/labels{/name} | https://api.github.com/repos/facebook/react/issues/18723/comments | https://api.github.com/repos/facebook/react/issues/18723/events | https://github.com/facebook/react/pull/18723 | 605,912,909 | MDExOlB1bGxSZXF1ZXN0NDA4MjMwODUx | 18,723 | Modern Event System: fix fiber ancestor issue with invalid containers | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18723/builds/21997) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 22:23:55 | 2020-04-24 00:57:49 | 2020-04-24 00:57:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18723', 'html_url': 'https://github.com/facebook/react/pull/18723', 'diff_url': 'https://github.com/facebook/react/pull/18723.diff', 'patch_url': 'https://github.com/facebook/react/pull/18723.patch', 'merged_at': None} | This PR addresses an issue that we found internally, where events may not fiber if we do some crazy ordering of containers, so that the parent contains the child container, that is a parent node but the opposite in terms of fiber order. I added a regression test to validate this and can confirm this fixes it internally... | {'url': 'https://api.github.com/repos/facebook/react/issues/18723/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18723/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18722 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18722/labels{/name} | https://api.github.com/repos/facebook/react/issues/18722/comments | https://api.github.com/repos/facebook/react/issues/18722/events | https://github.com/facebook/react/pull/18722 | 605,882,565 | MDExOlB1bGxSZXF1ZXN0NDA4MjA2MDk3 | 18,722 | [ESLint] Extend isHook to recognize those under PascalCase's namespace | {'login': 'cyan33', 'id': 13282699, 'node_id': 'MDQ6VXNlcjEzMjgyNjk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/13282699?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cyan33', 'html_url': 'https://github.com/cyan33', 'followers_url': 'https://api.github.com/users/cyan33/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18722/builds/21984) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 21:21:21 | 2020-04-24 01:50:53 | 2020-04-24 01:50:53 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18722', 'html_url': 'https://github.com/facebook/react/pull/18722', 'diff_url': 'https://github.com/facebook/react/pull/18722.diff', 'patch_url': 'https://github.com/facebook/react/pull/18722.patch', 'merged_at': datetime.datetime(2020, 4, 24, 1, 50, 53)} | ## Summary
Context and discussion: https://fburl.com/ppb00y2s
TLDR: A few teams have the convention to put hooks under a namespace and the current implementation doesn't catch hooks that are written this way.
```
// is hook
useSomething();
// is not hook => doesn't recognize
Foo.useSomething();
```
T... | {'url': 'https://api.github.com/repos/facebook/react/issues/18722/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18722/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18721 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18721/labels{/name} | https://api.github.com/repos/facebook/react/issues/18721/comments | https://api.github.com/repos/facebook/react/issues/18721/events | https://github.com/facebook/react/pull/18721 | 605,862,048 | MDExOlB1bGxSZXF1ZXN0NDA4MTg4NTY1 | 18,721 | Bug/Test: Add fuzzing tests for React.Suspense | {'login': 'dubzzz', 'id': 5300235, 'node_id': 'MDQ6VXNlcjUzMDAyMzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5300235?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dubzzz', 'html_url': 'https://github.com/dubzzz', 'followers_url': 'https://api.github.com/users/dubzzz/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18721/builds/32224) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 20:50:32 | 2022-10-20 20:41:16 | 2022-10-20 20:41:16 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18721', 'html_url': 'https://github.com/facebook/react/pull/18721', 'diff_url': 'https://github.com/facebook/react/pull/18721.diff', 'patch_url': 'https://github.com/facebook/react/pull/18721.patch', 'merged_at': None} |
<!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. For... | {'url': 'https://api.github.com/repos/facebook/react/issues/18721/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18721/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18720 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18720/labels{/name} | https://api.github.com/repos/facebook/react/issues/18720/comments | https://api.github.com/repos/facebook/react/issues/18720/events | https://github.com/facebook/react/pull/18720 | 605,808,672 | MDExOlB1bGxSZXF1ZXN0NDA4MTQzNTc3 | 18,720 | Modern Event System: register onMouseEnter for portals | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18720/builds/21972) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 19:34:41 | 2020-04-23 19:57:56 | 2020-04-23 19:57:52 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18720', 'html_url': 'https://github.com/facebook/react/pull/18720', 'diff_url': 'https://github.com/facebook/react/pull/18720.diff', 'patch_url': 'https://github.com/facebook/react/pull/18720.patch', 'merged_at': datetime.datetime(2020, 4, 23, 19, 57, 52)} | We found an issue internally with the modern event system and `onMouseEnter`/`onMouseLeave`. Specifically, this issue occurs when we have a portal that is outside of the React root. Given we don't listen to events on the document, we need to know when an inner `mouseEnter`/`mouseLeave` traverses up through a portal to ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18720/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18720/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18719 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18719/labels{/name} | https://api.github.com/repos/facebook/react/issues/18719/comments | https://api.github.com/repos/facebook/react/issues/18719/events | https://github.com/facebook/react/issues/18719 | 605,722,656 | MDU6SXNzdWU2MDU3MjI2NTY= | 18,719 | Bug: Unnecessary re-render | {'login': 'behnammodi', 'id': 1549069, 'node_id': 'MDQ6VXNlcjE1NDkwNjk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1549069?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/behnammodi', 'html_url': 'https://github.com/behnammodi', 'followers_url': 'https://api.github.com/users/behnammodi/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Does this happen with the production build as well? I'm asking because it doesn't actually commit when transitioning from 2->2.\r\n\r\nYou can observe this wrapping the (side-effect) in `useEffect`:\r\n```js\r\nReact.useEffect(() => {\r\n console.log(\"render App\", x);\r\n})\r\n```",
"Also: Probably a duplicat... | 2020-04-23 17:38:48 | 2020-04-23 18:43:46 | 2020-04-23 18:43:46 | CONTRIBUTOR | null | null | null |
React version: 16.13.1
## Steps To Reproduce
1- The first render is correct
2- The second re-render is correct because `X` changes from `1` to `2`
3- The third re-render in the wrong
Link to code ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18719/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18719/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18718 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18718/labels{/name} | https://api.github.com/repos/facebook/react/issues/18718/comments | https://api.github.com/repos/facebook/react/issues/18718/events | https://github.com/facebook/react/pull/18718 | 605,716,780 | MDExOlB1bGxSZXF1ZXN0NDA4MDY3NDk4 | 18,718 | [Draft] Hidden API | {'login': 'lunaruan', 'id': 2735514, 'node_id': 'MDQ6VXNlcjI3MzU1MTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2735514?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lunaruan', 'html_url': 'https://github.com/lunaruan', 'followers_url': 'https://api.github.com/users/lunaruan/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18718/builds/25130) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 17:30:22 | 2020-05-07 23:37:23 | 2020-05-07 23:30:49 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18718', 'html_url': 'https://github.com/facebook/react/pull/18718', 'diff_url': 'https://github.com/facebook/react/pull/18718.diff', 'patch_url': 'https://github.com/facebook/react/pull/18718.patch', 'merged_at': None} | null | {'url': 'https://api.github.com/repos/facebook/react/issues/18718/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 3} | https://api.github.com/repos/facebook/react/issues/18718/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18717 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18717/labels{/name} | https://api.github.com/repos/facebook/react/issues/18717/comments | https://api.github.com/repos/facebook/react/issues/18717/events | https://github.com/facebook/react/pull/18717 | 605,649,567 | MDExOlB1bGxSZXF1ZXN0NDA4MDEyNDk0 | 18,717 | DevTools temporarily disable prepareStackTrace before creating custom component stacks | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against df599686b32... | 2020-04-23 15:51:03 | 2020-04-23 16:02:46 | 2020-04-23 16:02:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18717', 'html_url': 'https://github.com/facebook/react/pull/18717', 'diff_url': 'https://github.com/facebook/react/pull/18717.diff', 'patch_url': 'https://github.com/facebook/react/pull/18717.patch', 'merged_at': datetime.datetime(2020, 4, 23, 16, 2, 43)} | Sibling PR to #18708 | {'url': 'https://api.github.com/repos/facebook/react/issues/18717/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18717/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18716 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18716/labels{/name} | https://api.github.com/repos/facebook/react/issues/18716/comments | https://api.github.com/repos/facebook/react/issues/18716/events | https://github.com/facebook/react/issues/18716 | 605,590,922 | MDU6SXNzdWU2MDU1OTA5MjI= | 18,716 | Bug: [eslint-plugin-react-hooks] No missing dependency report for non-inline effect callback | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Thank your for reporting this! This issue is resolved in the most recent version of `eslint-plugin-react-hooks`. It might take dependent repos like Create React App a little while to update their dependencies as well."
] | 2020-04-23 14:34:22 | 2020-07-24 12:36:17 | 2020-07-24 12:36:17 | NONE | null | null | null | React version: 16.13.1
eslint-plugin-react: 7.19.0
eslint-plugin-react-hooks: 3.0.0
eslint: 6.8.0
## Steps To Reproduce
```
const Example = () => {
const [count] = useState(0);
const increment = () => {
console.log(count);
};
// missing dependencies for inline effect callbacks are reporte... | {'url': 'https://api.github.com/repos/facebook/react/issues/18716/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18716/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18715 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18715/labels{/name} | https://api.github.com/repos/facebook/react/issues/18715/comments | https://api.github.com/repos/facebook/react/issues/18715/events | https://github.com/facebook/react/issues/18715 | 605,470,869 | MDU6SXNzdWU2MDU0NzA4Njk= | 18,715 | Bug: when i change the second params of `ReactDOM.createPortal`, the dom destroy and then rebuild. | {'login': 'weird94', 'id': 16274199, 'node_id': 'MDQ6VXNlcjE2Mjc0MTk5', 'avatar_url': 'https://avatars.githubusercontent.com/u/16274199?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/weird94', 'html_url': 'https://github.com/weird94', 'followers_url': 'https://api.github.com/users/weird94/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"React does not (currently) support reparenting nodes. If you render \"the same thing\" (same React elements) but change containers- React will unmount and destroy the first set of elements, then create and mount to the new container. This is the expected behavior.",
"So, why not just reuse the first set of eleme... | 2020-04-23 11:53:29 | 2020-04-30 03:21:09 | 2020-04-30 03:21:09 | NONE | null | null | null | ReactDOM version: 16.13.1
## Steps To Reproduce
1. open the console tab of sandbox
2. click the picture
3. click the scaled picture again
Link to code example: https://codesandbox.io/s/muddy-smoke-j8lfy
## The current behavior
when i change the second params of `ReactDOM.createPortal`, the dom was destor... | {'url': 'https://api.github.com/repos/facebook/react/issues/18715/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18715/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18714 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18714/labels{/name} | https://api.github.com/repos/facebook/react/issues/18714/comments | https://api.github.com/repos/facebook/react/issues/18714/events | https://github.com/facebook/react/issues/18714 | 605,455,437 | MDU6SXNzdWU2MDU0NTU0Mzc= | 18,714 | IE 11 render a blank page. How to make possible that IE11 render the gatsby page? | {'login': 'glueCod', 'id': 45491854, 'node_id': 'MDQ6VXNlcjQ1NDkxODU0', 'avatar_url': 'https://avatars.githubusercontent.com/u/45491854?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/glueCod', 'html_url': 'https://github.com/glueCod', 'followers_url': 'https://api.github.com/users/glueCod/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [] | 2020-04-23 11:26:37 | 2020-04-23 14:21:16 | 2020-04-23 14:19:42 | NONE | null | null | null | null | {'url': 'https://api.github.com/repos/facebook/react/issues/18714/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18714/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18713 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18713/labels{/name} | https://api.github.com/repos/facebook/react/issues/18713/comments | https://api.github.com/repos/facebook/react/issues/18713/events | https://github.com/facebook/react/pull/18713 | 605,447,957 | MDExOlB1bGxSZXF1ZXN0NDA3ODQ3MjM4 | 18,713 | ReactDOMEventListener: clean up module | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18713/builds/21844) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 11:14:08 | 2020-04-24 11:42:28 | 2020-04-23 19:19:28 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18713', 'html_url': 'https://github.com/facebook/react/pull/18713', 'diff_url': 'https://github.com/facebook/react/pull/18713.diff', 'patch_url': 'https://github.com/facebook/react/pull/18713.patch', 'merged_at': datetime.datetime(2020, 4, 23, 19, 19, 28)} | This PR tidies up `ReactDOMEventListener` and moves the different event listener approaches into their respective modules. This makes it easier to remove event systems in the future without breaking something else. Along the way, I noticed that we weren't applying the modern event system flag in the plugin tests proper... | {'url': 'https://api.github.com/repos/facebook/react/issues/18713/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18713/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18712 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18712/labels{/name} | https://api.github.com/repos/facebook/react/issues/18712/comments | https://api.github.com/repos/facebook/react/issues/18712/events | https://github.com/facebook/react/pull/18712 | 605,444,730 | MDExOlB1bGxSZXF1ZXN0NDA3ODQ0NTY2 | 18,712 | Remove hint to post feedback about exhaustive-deps rule | {'login': 'spawnia', 'id': 12158000, 'node_id': 'MDQ6VXNlcjEyMTU4MDAw', 'avatar_url': 'https://avatars.githubusercontent.com/u/12158000?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/spawnia', 'html_url': 'https://github.com/spawnia', 'followers_url': 'https://api.github.com/users/spawnia/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18712/builds/21840) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 11:08:31 | 2020-05-01 18:14:00 | 2020-05-01 18:14:00 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18712', 'html_url': 'https://github.com/facebook/react/pull/18712', 'diff_url': 'https://github.com/facebook/react/pull/18712.diff', 'patch_url': 'https://github.com/facebook/react/pull/18712.patch', 'merged_at': datetime.datetime(2020, 5, 1, 18, 14)} | The thread is closed and locked.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18712/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18712/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18711 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18711/labels{/name} | https://api.github.com/repos/facebook/react/issues/18711/comments | https://api.github.com/repos/facebook/react/issues/18711/events | https://github.com/facebook/react/pull/18711 | 605,234,015 | MDExOlB1bGxSZXF1ZXN0NDA3Njc2NDcx | 18,711 | Always wrap Suspense children | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18711/builds/22255) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 04:42:58 | 2020-04-26 10:04:36 | 2020-04-25 07:09:20 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18711', 'html_url': 'https://github.com/facebook/react/pull/18711', 'diff_url': 'https://github.com/facebook/react/pull/18711.diff', 'patch_url': 'https://github.com/facebook/react/pull/18711.patch', 'merged_at': datetime.datetime(2020, 4, 25, 7, 9, 19)} | This is stacked on top of the work I'm doing in my Lanes refactor branch. I would ideally like to land all of the previous steps, too; however, it's not a hard requirement. I can decouple them if needed. I'm open to discussion on which parts we should land now versus later.
But I would like to land cd7e394 in some f... | {'url': 'https://api.github.com/repos/facebook/react/issues/18711/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18711/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18710 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18710/labels{/name} | https://api.github.com/repos/facebook/react/issues/18710/comments | https://api.github.com/repos/facebook/react/issues/18710/events | https://github.com/facebook/react/pull/18710 | 605,232,234 | MDExOlB1bGxSZXF1ZXN0NDA3Njc0OTk0 | 18,710 | Remove flushDiscreteUpdates, discreteUpdates and syncUpdates | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18710/builds/24463) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 04:37:21 | 2020-05-05 04:39:58 | 2020-05-05 04:39:58 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18710', 'html_url': 'https://github.com/facebook/react/pull/18710', 'diff_url': 'https://github.com/facebook/react/pull/18710.diff', 'patch_url': 'https://github.com/facebook/react/pull/18710.patch', 'merged_at': datetime.datetime(2020, 5, 5, 4, 39, 58)} | We're simplifying discrete by merging it with sync. As such `flushSync()` can be used to flush already pending discrete work. `flushSync(() => ...)` replaces discreteUpdates. syncUpdates could in theory be used to enter the discrete phase in a non-discrete event but might as well use `flushSync(() => ...)` then to simp... | {'url': 'https://api.github.com/repos/facebook/react/issues/18710/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18710/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18709 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18709/labels{/name} | https://api.github.com/repos/facebook/react/issues/18709/comments | https://api.github.com/repos/facebook/react/issues/18709/events | https://github.com/facebook/react/issues/18709 | 605,202,715 | MDU6SXNzdWU2MDUyMDI3MTU= | 18,709 | Bug: Unable to use resolve Context when component and Provider exist on different levels of NPM module. | {'login': 'chopfitzroy', 'id': 2978850, 'node_id': 'MDQ6VXNlcjI5Nzg4NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2978850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/chopfitzroy', 'html_url': 'https://github.com/chopfitzroy', 'followers_url': 'https://api.github.com/users/chopfitzroy/f... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'chopfitzroy', 'id': 2978850.0, 'node_id': 'MDQ6VXNlcjI5Nzg4NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2978850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/chopfitzroy', 'html_url': 'https://github.com/chopfitzroy', 'followers_url': 'https://api.github.com/users/chopfitzroy... | [{'login': 'chopfitzroy', 'id': 2978850, 'node_id': 'MDQ6VXNlcjI5Nzg4NTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2978850?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/chopfitzroy', 'html_url': 'https://github.com/chopfitzroy', 'followers_url': 'https://api.github.com/users/chopfitzroy/... | null | [
"This has nothing to do with React. React is unaware of your directory structure.",
"@vkurchatkin you are absolutely right, I have updated the directory structure in the example to reflect that of the module and as expected it still works... I will replicate the issue with an actual NPM module this weekend to pro... | 2020-04-23 03:01:53 | 2020-04-23 21:50:53 | 2020-04-23 21:40:56 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
Unable to use resolve `Context` when component and `Provider` exist on different... | {'url': 'https://api.github.com/repos/facebook/react/issues/18709/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18709/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18708 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18708/labels{/name} | https://api.github.com/repos/facebook/react/issues/18708/comments | https://api.github.com/repos/facebook/react/issues/18708/events | https://github.com/facebook/react/pull/18708 | 605,192,970 | MDExOlB1bGxSZXF1ZXN0NDA3NjQzODEz | 18,708 | Disable prepareStackTrace while we're generating stacks | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18708/builds/21913) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 02:30:36 | 2020-04-23 16:17:00 | 2020-04-23 16:17:00 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18708', 'html_url': 'https://github.com/facebook/react/pull/18708', 'diff_url': 'https://github.com/facebook/react/pull/18708.diff', 'patch_url': 'https://github.com/facebook/react/pull/18708.patch', 'merged_at': datetime.datetime(2020, 4, 23, 16, 16, 59)} | This could be used to do custom formatting of the stack trace in a way that isn't compatible with how we use it. So we disable it while we use it.
In theory we could call this ourselves with the result of our stack. It would be a lot of extra production code though. My personal opinion is that this should always be ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18708/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18708/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18707 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18707/labels{/name} | https://api.github.com/repos/facebook/react/issues/18707/comments | https://api.github.com/repos/facebook/react/issues/18707/events | https://github.com/facebook/react/pull/18707 | 605,175,082 | MDExOlB1bGxSZXF1ZXN0NDA3NjI5ODM5 | 18,707 | Remove unnecessary stack | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18707/builds/21733) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-23 01:32:41 | 2020-04-23 16:44:39 | 2020-04-23 16:44:38 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18707', 'html_url': 'https://github.com/facebook/react/pull/18707', 'diff_url': 'https://github.com/facebook/react/pull/18707.diff', 'patch_url': 'https://github.com/facebook/react/pull/18707.patch', 'merged_at': datetime.datetime(2020, 4, 23, 16, 44, 38)} | Same rationale as https://github.com/facebook/react/pull/18685/commits/3aca0a08b47a3abc54207b143cddd64021f51fc2
We already append stacks in the "above error" log and to error boundaries so this provide superfluous information. | {'url': 'https://api.github.com/repos/facebook/react/issues/18707/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18707/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18706 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18706/labels{/name} | https://api.github.com/repos/facebook/react/issues/18706/comments | https://api.github.com/repos/facebook/react/issues/18706/events | https://github.com/facebook/react/issues/18706 | 605,101,735 | MDU6SXNzdWU2MDUxMDE3MzU= | 18,706 | Suspense prevents reading valid layout values in `useLayoutEffect` | {'login': 'vkurchatkin', 'id': 2993861, 'node_id': 'MDQ6VXNlcjI5OTM4NjE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2993861?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vkurchatkin', 'html_url': 'https://github.com/vkurchatkin', 'followers_url': 'https://api.github.com/users/vkurchatkin/f... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Documentation clearly states:\r\n\r\n> Use this to read layout from the DOM and synchronously re-render.\r\n\r\nSo I assume this has to be a bug",
"This is a quirk that we can't fix in the legacy mode without making a huge breaking change.\r\n\r\nIt is fixed in Concurrent Mode (https://codesandbox.io/s/priceless... | 2020-04-22 21:59:34 | 2020-04-22 22:13:26 | 2020-04-22 22:13:25 | NONE | null | null | null | `useLayoutEffect` is commonly used to read layout values (such as `getClientBoundingRect`) to adjust positioning of some elements:
```javascript
const ref = React.useRef();
useLayoutEffect(() => {
const width = ref.current.getBoundingClientRect().width;
// do something with width
});
```
This breaks i... | {'url': 'https://api.github.com/repos/facebook/react/issues/18706/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18706/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18705 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18705/labels{/name} | https://api.github.com/repos/facebook/react/issues/18705/comments | https://api.github.com/repos/facebook/react/issues/18705/events | https://github.com/facebook/react/issues/18705 | 605,048,578 | MDU6SXNzdWU2MDUwNDg1Nzg= | 18,705 | Bug: React devtools shows "Unable to find React on the page" Incorrectly | {'login': 'eddiecooro', 'id': 20463083, 'node_id': 'MDQ6VXNlcjIwNDYzMDgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/20463083?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eddiecooro', 'html_url': 'https://github.com/eddiecooro', 'followers_url': 'https://api.github.com/users/eddiecooro/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'eddiecooro', 'id': 20463083.0, 'node_id': 'MDQ6VXNlcjIwNDYzMDgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/20463083?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eddiecooro', 'html_url': 'https://github.com/eddiecooro', 'followers_url': 'https://api.github.com/users/eddiecooro/f... | [{'login': 'eddiecooro', 'id': 20463083, 'node_id': 'MDQ6VXNlcjIwNDYzMDgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/20463083?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eddiecooro', 'html_url': 'https://github.com/eddiecooro', 'followers_url': 'https://api.github.com/users/eddiecooro/fo... | null | [
"Update: everything works without problem on the standalone app",
"Is your project in a public repository?",
"Hey @Nilomiranda \r\nUnfortunately, its not.\r\nIs there any specific part that you want to check?",
"Not sure how to reproduce this. Can't say I've seen it.\r\n\r\nCan you share a minimal repro? Just... | 2020-04-22 20:24:58 | 2023-09-07 16:15:07 | 2020-04-24 23:25:55 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.12.0
Devtools version: 4.6.0
## Steps To Reproduce
Don'... | {'url': 'https://api.github.com/repos/facebook/react/issues/18705/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18705/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18704 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18704/labels{/name} | https://api.github.com/repos/facebook/react/issues/18704/comments | https://api.github.com/repos/facebook/react/issues/18704/events | https://github.com/facebook/react/issues/18704 | 604,927,154 | MDU6SXNzdWU2MDQ5MjcxNTQ= | 18,704 | Bug: discrepancy between `onChange` and `addEventListener('change',...)` in checkboxes | {'login': 'marcellomontemagno', 'id': 10496578, 'node_id': 'MDQ6VXNlcjEwNDk2NTc4', 'avatar_url': 'https://avatars.githubusercontent.com/u/10496578?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/marcellomontemagno', 'html_url': 'https://github.com/marcellomontemagno', 'followers_url': 'https://api.github.... | [{'id': 69105383, 'node_id': 'MDU6TGFiZWw2OTEwNTM4Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Browser:%20IE', 'name': 'Browser: IE', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 1983406161, 'node_id': 'MDU6TGFiZWwxOTgzNDA2MTYx', 'url': 'https://api.github.com/repos/facebook/re... | closed | false | null | [] | null | [
"Try change the 'true' value in line 23 with 'null' ",
"It is'nt discrepancy. React captured the inputchange event, then fire the `onChange` callback, then render the dom. \r\nAfter render, you checkbox is always checked because you set it a true value.\r\n`addEventListener` is registered after the dom is rendere... | 2020-04-22 17:19:04 | 2020-09-16 19:22:28 | 2020-09-16 19:22:28 | NONE | null | null | null | I noticed that for controlled checkboxes there is a discrepancy between the checked value returned within an `onChange` callback and a callback added with `addEventListener` regardless of the `capture` flag set to `true`.
You can reproduce the issue in the following codesandbox by clicking on the checkbox and readin... | {'url': 'https://api.github.com/repos/facebook/react/issues/18704/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18704/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18703 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18703/labels{/name} | https://api.github.com/repos/facebook/react/issues/18703/comments | https://api.github.com/repos/facebook/react/issues/18703/events | https://github.com/facebook/react/pull/18703 | 604,884,036 | MDExOlB1bGxSZXF1ZXN0NDA3MzkzMTM0 | 18,703 | Add fixture to demonstate bug where number input is cleared | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18703/builds/21654) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-22 16:15:33 | 2020-09-07 05:04:23 | 2020-09-07 05:04:23 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18703', 'html_url': 'https://github.com/facebook/react/pull/18703', 'diff_url': 'https://github.com/facebook/react/pull/18703.diff', 'patch_url': 'https://github.com/facebook/react/pull/18703.patch', 'merged_at': None} | [related](https://github.com/facebook/react/issues/17609#issuecomment-607486343) to #17609
| {'url': 'https://api.github.com/repos/facebook/react/issues/18703/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18703/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18702 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18702/labels{/name} | https://api.github.com/repos/facebook/react/issues/18702/comments | https://api.github.com/repos/facebook/react/issues/18702/events | https://github.com/facebook/react/issues/18702 | 604,827,853 | MDU6SXNzdWU2MDQ4Mjc4NTM= | 18,702 | Improve UX of finding full `key` value | {'login': 'karlhorky', 'id': 1935696, 'node_id': 'MDQ6VXNlcjE5MzU2OTY=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1935696?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/karlhorky', 'html_url': 'https://github.com/karlhorky', 'followers_url': 'https://api.github.com/users/karlhorky/followers... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github... | closed | false | null | [] | null | [
"This isn't a bug :smile: It's the intentional design.\r\n\r\nThe key is visible right in the Components tree. :smile: You're hovering over it a lot in the attached video.\r\n\r\nThe key isn't listed as a \"prop\" on the right because- at least for the moment, `key` isn't a prop. It won't be passed through to a com... | 2020-04-22 15:00:02 | 2020-05-12 09:11:27 | 2020-05-11 20:17:14 | CONTRIBUTOR | null | null | null | ## The current behavior
The full value of the `key` is very difficult / impossible to find and use in the interface of the React Devtools.
Only managed to find it by accident :... | {'url': 'https://api.github.com/repos/facebook/react/issues/18702/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18702/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18701 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18701/labels{/name} | https://api.github.com/repos/facebook/react/issues/18701/comments | https://api.github.com/repos/facebook/react/issues/18701/events | https://github.com/facebook/react/issues/18701 | 604,700,926 | MDU6SXNzdWU2MDQ3MDA5MjY= | 18,701 | Error: "Commit tree does not contain fiber 55875. This is a bug in React DevTools." | {'login': 'Lukavyi', 'id': 1013690, 'node_id': 'MDQ6VXNlcjEwMTM2OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1013690?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Lukavyi', 'html_url': 'https://github.com/Lukavyi', 'followers_url': 'https://api.github.com/users/Lukavyi/followers', 'foll... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'Lukavyi', 'id': 1013690.0, 'node_id': 'MDQ6VXNlcjEwMTM2OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1013690?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Lukavyi', 'html_url': 'https://github.com/Lukavyi', 'followers_url': 'https://api.github.com/users/Lukavyi/followers', 'fo... | [{'login': 'Lukavyi', 'id': 1013690, 'node_id': 'MDQ6VXNlcjEwMTM2OTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1013690?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Lukavyi', 'html_url': 'https://github.com/Lukavyi', 'followers_url': 'https://api.github.com/users/Lukavyi/followers', 'fol... | null | [
"Hey @Lukavyi \r\n\r\nAre you able to reproduce this behavior? If so, can you share the app or example code with us to help us repro it?\r\n\r\nI'd be happy to look into it if I have a way of reproducing the problem.",
"Nope, not able to reproduce.\r\nIt was a bug in react dev tools",
"Yes, I realize that :smil... | 2020-04-22 12:00:47 | 2020-04-25 16:34:13 | 2020-04-23 06:10:55 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Profiled my session, then selected to show commits over 10ms
2. Went through commits in profiler
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4... | {'url': 'https://api.github.com/repos/facebook/react/issues/18701/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18701/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18700 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18700/labels{/name} | https://api.github.com/repos/facebook/react/issues/18700/comments | https://api.github.com/repos/facebook/react/issues/18700/events | https://github.com/facebook/react/issues/18700 | 604,604,291 | MDU6SXNzdWU2MDQ2MDQyOTE= | 18,700 | Bug: | {'login': 'racenki26', 'id': 60427374, 'node_id': 'MDQ6VXNlcjYwNDI3Mzc0', 'avatar_url': 'https://avatars.githubusercontent.com/u/60427374?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/racenki26', 'html_url': 'https://github.com/racenki26', 'followers_url': 'https://api.github.com/users/racenki26/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"#18700"
] | 2020-04-22 09:30:06 | 2020-04-22 15:59:30 | 2020-04-22 15:59:30 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/18700/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18700/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18699 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18699/labels{/name} | https://api.github.com/repos/facebook/react/issues/18699/comments | https://api.github.com/repos/facebook/react/issues/18699/events | https://github.com/facebook/react/issues/18699 | 604,462,880 | MDU6SXNzdWU2MDQ0NjI4ODA= | 18,699 | Bug: React App with router not opening on ios 13.4.x | {'login': 'nvnvenki', 'id': 1863449, 'node_id': 'MDQ6VXNlcjE4NjM0NDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1863449?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nvnvenki', 'html_url': 'https://github.com/nvnvenki', 'followers_url': 'https://api.github.com/users/nvnvenki/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 620368407, 'node_id': 'MDU6T... | closed | false | {'login': 'nvnvenki', 'id': 1863449.0, 'node_id': 'MDQ6VXNlcjE4NjM0NDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1863449?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nvnvenki', 'html_url': 'https://github.com/nvnvenki', 'followers_url': 'https://api.github.com/users/nvnvenki/followers',... | [{'login': 'nvnvenki', 'id': 1863449, 'node_id': 'MDQ6VXNlcjE4NjM0NDk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1863449?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/nvnvenki', 'html_url': 'https://github.com/nvnvenki', 'followers_url': 'https://api.github.com/users/nvnvenki/followers', ... | null | [
"facing same issue in currently in **ios 13.4.1**",
"When I took a look myself I saw:\r\n<img width=\"526\" alt=\"Screen Shot 2020-04-22 at 8 58 22 AM\" src=\"https://user-images.githubusercontent.com/29597/80004654-70671580-8477-11ea-8449-26a6e77361eb.png\">\r\n\r\nThis doesn't seem to me like it's a React issu... | 2020-04-22 05:17:21 | 2020-07-22 12:39:18 | 2020-07-21 22:50:04 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.8.4
## Steps To Reproduce
We have app hosted at https://... | {'url': 'https://api.github.com/repos/facebook/react/issues/18699/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18699/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18698 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18698/labels{/name} | https://api.github.com/repos/facebook/react/issues/18698/comments | https://api.github.com/repos/facebook/react/issues/18698/events | https://github.com/facebook/react/issues/18698 | 604,420,693 | MDU6SXNzdWU2MDQ0MjA2OTM= | 18,698 | Bug: | {'login': 'rhysburnie', 'id': 245933, 'node_id': 'MDQ6VXNlcjI0NTkzMw==', 'avatar_url': 'https://avatars.githubusercontent.com/u/245933?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rhysburnie', 'html_url': 'https://github.com/rhysburnie', 'followers_url': 'https://api.github.com/users/rhysburnie/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710573595, 'node_id': 'MDU6T... | closed | false | null | [] | null | [
"No. This is not a known issue for DevTools.",
"What happens if you reload either your RN app or DevTools? Does it always still show two instances?",
"@bvaughn it hapens consistently have tried combos of stopping starting both dev tools and reloading, app, stopping metro and starting again including delete app ... | 2020-04-22 03:14:35 | 2020-05-05 16:07:29 | 2020-05-05 16:07:29 | NONE | null | null | null | On android using react-devtools we are seeing 2 instances of the app appear.
On iOS we see 1.
We would like to know if this is a known issue with the devtools or if we are infact seeing 2 instances which is much more concerning but at least we will know that somehow it renders to copies on android.
At the moment w... | {'url': 'https://api.github.com/repos/facebook/react/issues/18698/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18698/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18697 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18697/labels{/name} | https://api.github.com/repos/facebook/react/issues/18697/comments | https://api.github.com/repos/facebook/react/issues/18697/events | https://github.com/facebook/react/pull/18697 | 604,411,634 | MDExOlB1bGxSZXF1ZXN0NDA3MDExMjQ4 | 18,697 | Temporarily Remove DebugTracing from the New Reconciler | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18697/builds/21486) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-22 02:47:06 | 2020-04-22 15:24:18 | 2020-04-22 03:14:41 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18697', 'html_url': 'https://github.com/facebook/react/pull/18697', 'diff_url': 'https://github.com/facebook/react/pull/18697.diff', 'patch_url': 'https://github.com/facebook/react/pull/18697.patch', 'merged_at': datetime.datetime(2020, 4, 22, 3, 14, 41)} | Sorry @bvaughn and @gaearon. 😢We can add it back.
Some of the concepts are changing. E.g. getting the current priority level isn't as obviously going to be in the same place. Priority field on update isn't useful anymore since the lanes convey more info. This code is also in all the places moving around. It'll be e... | {'url': 'https://api.github.com/repos/facebook/react/issues/18697/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 1, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18697/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18696 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18696/labels{/name} | https://api.github.com/repos/facebook/react/issues/18696/comments | https://api.github.com/repos/facebook/react/issues/18696/events | https://github.com/facebook/react/pull/18696 | 604,383,719 | MDExOlB1bGxSZXF1ZXN0NDA2OTg5MTY5 | 18,696 | Nit: add suffix _TIMEOUT consistently in scheduler | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18696/builds/21470) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-22 01:22:21 | 2020-04-22 02:44:43 | 2020-04-22 02:44:43 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18696', 'html_url': 'https://github.com/facebook/react/pull/18696', 'diff_url': 'https://github.com/facebook/react/pull/18696.diff', 'patch_url': 'https://github.com/facebook/react/pull/18696.patch', 'merged_at': datetime.datetime(2020, 4, 22, 2, 44, 43)} | This is just a naming thing to avoid confusing it with the levels. | {'url': 'https://api.github.com/repos/facebook/react/issues/18696/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18696/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18695 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18695/labels{/name} | https://api.github.com/repos/facebook/react/issues/18695/comments | https://api.github.com/repos/facebook/react/issues/18695/events | https://github.com/facebook/react/issues/18695 | 604,311,470 | MDU6SXNzdWU2MDQzMTE0NzA= | 18,695 | Bug: function component cannot have ref property | {'login': 'vhermecz', 'id': 214635, 'node_id': 'MDQ6VXNlcjIxNDYzNQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/214635?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vhermecz', 'html_url': 'https://github.com/vhermecz', 'followers_url': 'https://api.github.com/users/vhermecz/followers', 'fo... | [{'id': 40929155, 'node_id': 'MDU6TGFiZWw0MDkyOTE1NQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Question', 'name': 'Type: Question', 'color': 'cc317c', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"You need to use `forwardRef` for this: https://reactjs.org/docs/forwarding-refs.html",
"Thx for the link, but that is not a solution I think. I do not have a child\ncomponent to forward to. I am the child component.\n\nOn Wed, Apr 22, 2020, 08:50 Vladimir Kurchatkin <notifications@github.com>\nwrote:\n\n> You ne... | 2020-04-21 21:57:06 | 2020-04-23 11:13:21 | 2020-04-22 16:13:50 | NONE | null | null | null | When passing ref property to a function component, validateFunctionComponentInDev shows a warning about it being a bad thing.
React version: HEAD
While this might have been true for stateless function components (as many places refer to func components), probably since the introduction of hooks, they can have sta... | {'url': 'https://api.github.com/repos/facebook/react/issues/18695/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18695/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18694 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18694/labels{/name} | https://api.github.com/repos/facebook/react/issues/18694/comments | https://api.github.com/repos/facebook/react/issues/18694/events | https://github.com/facebook/react/issues/18694 | 604,244,606 | MDU6SXNzdWU2MDQyNDQ2MDY= | 18,694 | Bug: iOS Compiler | {'login': 'mstepanyan', 'id': 64102909, 'node_id': 'MDQ6VXNlcjY0MTAyOTA5', 'avatar_url': 'https://avatars.githubusercontent.com/u/64102909?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mstepanyan', 'html_url': 'https://github.com/mstepanyan', 'followers_url': 'https://api.github.com/users/mstepanyan/fol... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is not the React Native repo. You'll want to file your issue in that repo:\r\nhttps://github.com/facebook/react-native\r\n\r\nThat being said, Appium is not an official React Native product so I'm not sure if they'll be able to help or not.",
"Thank you for your response.\nBest regards\n\n\nOn Wed, Apr 22, ... | 2020-04-21 19:54:21 | 2020-04-21 20:21:50 | 2020-04-21 20:19:46 | NONE | null | null | null | Dear Support Team .
We have an application(IOS - https://apps.apple.com/us/app/vlume/id1325346984, Android - https://play.google.com/store/apps/details?id=com.vlume.app), which is written in React-Native. We using also an UI Automation Tests (Appium XCUITest).
Could you please help us to understand why XCUITest has... | {'url': 'https://api.github.com/repos/facebook/react/issues/18694/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18694/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18693 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18693/labels{/name} | https://api.github.com/repos/facebook/react/issues/18693/comments | https://api.github.com/repos/facebook/react/issues/18693/events | https://github.com/facebook/react/pull/18693 | 604,208,537 | MDExOlB1bGxSZXF1ZXN0NDA2ODQ1Mzk2 | 18,693 | Don't dedupe using the stack | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18693/builds/21736) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-21 18:54:17 | 2020-04-23 02:02:12 | 2020-04-23 02:02:11 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18693', 'html_url': 'https://github.com/facebook/react/pull/18693', 'diff_url': 'https://github.com/facebook/react/pull/18693.diff', 'patch_url': 'https://github.com/facebook/react/pull/18693.patch', 'merged_at': datetime.datetime(2020, 4, 23, 2, 2, 11)} | We currently use the stack to dedupe warnings in a couple of places. This is a very heavy weight way of computing that a warning doesn't need to be fired.
This uses parent component name as a heuristic for deduping. It's not perfect but as soon as you fix one you'll uncover the next. It might be a little annoying bu... | {'url': 'https://api.github.com/repos/facebook/react/issues/18693/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18693/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18692 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18692/labels{/name} | https://api.github.com/repos/facebook/react/issues/18692/comments | https://api.github.com/repos/facebook/react/issues/18692/events | https://github.com/facebook/react/pull/18692 | 604,197,852 | MDExOlB1bGxSZXF1ZXN0NDA2ODM2NTI0 | 18,692 | Pin RNW to canary | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18692/builds/21394) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-21 18:36:35 | 2020-04-21 18:46:33 | 2020-04-21 18:46:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18692', 'html_url': 'https://github.com/facebook/react/pull/18692', 'diff_url': 'https://github.com/facebook/react/pull/18692.diff', 'patch_url': 'https://github.com/facebook/react/pull/18692.patch', 'merged_at': datetime.datetime(2020, 4, 21, 18, 46, 30)} | This unbreaks DevTools shell with the latest ReactDOM in master. | {'url': 'https://api.github.com/repos/facebook/react/issues/18692/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18692/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18691 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18691/labels{/name} | https://api.github.com/repos/facebook/react/issues/18691/comments | https://api.github.com/repos/facebook/react/issues/18691/events | https://github.com/facebook/react/issues/18691 | 604,170,326 | MDU6SXNzdWU2MDQxNzAzMjY= | 18,691 | Error: "Cannot read property '2' of undefined" | {'login': 'larlew', 'id': 31042542, 'node_id': 'MDQ6VXNlcjMxMDQyNTQy', 'avatar_url': 'https://avatars.githubusercontent.com/u/31042542?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/larlew', 'html_url': 'https://github.com/larlew', 'followers_url': 'https://api.github.com/users/larlew/followers', 'follow... | [{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/facebook/react/labels/Resolution:%20Needs%20More%20Information', 'name': 'Resolution: Needs More Information', 'color': 'fffde7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU='... | closed | false | {'login': 'larlew', 'id': 31042542.0, 'node_id': 'MDQ6VXNlcjMxMDQyNTQy', 'avatar_url': 'https://avatars.githubusercontent.com/u/31042542?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/larlew', 'html_url': 'https://github.com/larlew', 'followers_url': 'https://api.github.com/users/larlew/followers', 'foll... | [{'login': 'larlew', 'id': 31042542, 'node_id': 'MDQ6VXNlcjMxMDQyNTQy', 'avatar_url': 'https://avatars.githubusercontent.com/u/31042542?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/larlew', 'html_url': 'https://github.com/larlew', 'followers_url': 'https://api.github.com/users/larlew/followers', 'follo... | null | [
"It doesn't look like this bug report has enough info for one of us to reproduce it.\r\n\r\nPlease provide a CodeSandbox (https://codesandbox.io/s/new), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem. Screenshots or videos can also be helpful if they help provide con... | 2020-04-21 17:50:19 | 2020-05-19 21:15:40 | 2020-05-19 21:15:40 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. I was stepping thru the profiler to see React renders
2.
3.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.6.0-6cceaeb67
Call stack: at j ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18691/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18691/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18690 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18690/labels{/name} | https://api.github.com/repos/facebook/react/issues/18690/comments | https://api.github.com/repos/facebook/react/issues/18690/events | https://github.com/facebook/react/pull/18690 | 604,119,835 | MDExOlB1bGxSZXF1ZXN0NDA2NzczNjYz | 18,690 | Clear fiber field from host instance on unmount | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18690/builds/21371) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-21 16:37:26 | 2022-10-20 20:41:16 | 2022-10-20 20:41:16 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18690', 'html_url': 'https://github.com/facebook/react/pull/18690', 'diff_url': 'https://github.com/facebook/react/pull/18690.diff', 'patch_url': 'https://github.com/facebook/react/pull/18690.patch', 'merged_at': None} | Given we're still seeing memory leaks internally and that we already traverse each host component when we detach its fiber – let's also clear the fiber field from the host instance. I did some quick checks and didn't notice any performance runtime implications, in fact I noticed that overall memory consumed was lower f... | {'url': 'https://api.github.com/repos/facebook/react/issues/18690/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18690/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18689 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18689/labels{/name} | https://api.github.com/repos/facebook/react/issues/18689/comments | https://api.github.com/repos/facebook/react/issues/18689/events | https://github.com/facebook/react/pull/18689 | 604,026,561 | MDExOlB1bGxSZXF1ZXN0NDA2Njk3NTYw | 18,689 | Remove ReactDOM.useEvent and associated types+tests | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18689/builds/21346) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-21 14:06:13 | 2020-04-21 15:40:46 | 2020-04-21 15:40:46 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18689', 'html_url': 'https://github.com/facebook/react/pull/18689', 'diff_url': 'https://github.com/facebook/react/pull/18689.diff', 'patch_url': 'https://github.com/facebook/react/pull/18689.patch', 'merged_at': datetime.datetime(2020, 4, 21, 15, 40, 46)} | This PR removes the `ReactDOM.unstable_useEvent` API from the codebase. We are close to finding a lower level primitive to creating events in React without needing to couple the API to hooks only and that exploration might bring back some of the logic we had here, but ideally we'd probably revisit things again without ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18689/reactions', 'total_count': 3, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 2, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18689/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18688 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18688/labels{/name} | https://api.github.com/repos/facebook/react/issues/18688/comments | https://api.github.com/repos/facebook/react/issues/18688/events | https://github.com/facebook/react/pull/18688 | 603,869,177 | MDExOlB1bGxSZXF1ZXN0NDA2NTY4OTgx | 18,688 | Revert "Pressable click fix" | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18688/builds/21275) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-21 09:58:51 | 2022-11-29 22:21:47 | 2020-04-21 10:08:31 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18688', 'html_url': 'https://github.com/facebook/react/pull/18688', 'diff_url': 'https://github.com/facebook/react/pull/18688.diff', 'patch_url': 'https://github.com/facebook/react/pull/18688.patch', 'merged_at': datetime.datetime(2020, 4, 21, 10, 8, 30)} | Reverts facebook/react#18625
When clicking on navigation items, we don't seem to be calling `preventDefault`, resulting in full page reloads internally. | {'url': 'https://api.github.com/repos/facebook/react/issues/18688/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18688/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18687 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18687/labels{/name} | https://api.github.com/repos/facebook/react/issues/18687/comments | https://api.github.com/repos/facebook/react/issues/18687/events | https://github.com/facebook/react/pull/18687 | 603,848,002 | MDExOlB1bGxSZXF1ZXN0NDA2NTUxNzY1 | 18,687 | Remove null sibling | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18687/builds/21268) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-21 09:25:31 | 2020-04-21 09:43:56 | 2020-04-21 09:43:51 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18687', 'html_url': 'https://github.com/facebook/react/pull/18687', 'diff_url': 'https://github.com/facebook/react/pull/18687.diff', 'patch_url': 'https://github.com/facebook/react/pull/18687.patch', 'merged_at': datetime.datetime(2020, 4, 21, 9, 43, 51)} | The issue that affected us in https://github.com/facebook/react/pull/16820 is still a problem today it seems. This PR removes the logic where we `null` the `sibling` field, which is unfortunate as this was causing a leak. I added a comment for future reading, in case we forget this again.
I'll look at making a repro... | {'url': 'https://api.github.com/repos/facebook/react/issues/18687/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18687/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18686 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18686/labels{/name} | https://api.github.com/repos/facebook/react/issues/18686/comments | https://api.github.com/repos/facebook/react/issues/18686/events | https://github.com/facebook/react/issues/18686 | 603,693,798 | MDU6SXNzdWU2MDM2OTM3OTg= | 18,686 | Bug: Context value change results in rendering of components that do not consume said context | {'login': 'lee-borsboom', 'id': 6227287, 'node_id': 'MDQ6VXNlcjYyMjcyODc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6227287?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/lee-borsboom', 'html_url': 'https://github.com/lee-borsboom', 'followers_url': 'https://api.github.com/users/lee-borsbo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This is how React works. When you update state the component is rerendered, including all of the descendants, unless there is a React.memo somewhere ",
"I don’t think this has anything to do with context. Remove the context provider and you’ll still see the same behavior. Indeed, if you setState, components bel... | 2020-04-21 04:21:07 | 2020-04-21 13:39:28 | 2020-04-21 13:39:28 | NONE | null | null | null | Given the following structure:
```
<MyContext.Provider value={value}>
<A>
<B>
<C />
</B>
</A>
</MyContext.Provider>
```
A and B will be re-rendered when the context value changes because C is consuming it. This _appears_ to be unnecessary as preventing A (and thus B) from re-rendering still ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18686/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18686/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18685 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18685/labels{/name} | https://api.github.com/repos/facebook/react/issues/18685/comments | https://api.github.com/repos/facebook/react/issues/18685/events | https://github.com/facebook/react/pull/18685 | 603,672,304 | MDExOlB1bGxSZXF1ZXN0NDA2NDExNjc4 | 18,685 | Avoid passing custom stacks to console.error | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18685/builds/21200) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-21 03:13:02 | 2020-04-21 18:43:15 | 2020-04-21 16:22:48 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18685', 'html_url': 'https://github.com/facebook/react/pull/18685', 'diff_url': 'https://github.com/facebook/react/pull/18685.diff', 'patch_url': 'https://github.com/facebook/react/pull/18685.patch', 'merged_at': datetime.datetime(2020, 4, 21, 16, 22, 48)} | The detection if one of the args contains a stack was broken in the new stack format. Unfortunately the toWarnDev helper that was meant to detect that oversight used the same check.
This stops detecting stacks and instead always appends a stack.
Many of the custom stacks were actually unnecessary because they had... | {'url': 'https://api.github.com/repos/facebook/react/issues/18685/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18685/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18684 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18684/labels{/name} | https://api.github.com/repos/facebook/react/issues/18684/comments | https://api.github.com/repos/facebook/react/issues/18684/events | https://github.com/facebook/react/pull/18684 | 603,624,755 | MDExOlB1bGxSZXF1ZXN0NDA2Mzc1ODkw | 18,684 | Upgrade fbjs-scripts | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (experimental)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 3f4bea8ce5b... | 2020-04-21 00:46:03 | 2020-04-21 01:23:02 | 2020-04-21 01:20:04 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18684', 'html_url': 'https://github.com/facebook/react/pull/18684', 'diff_url': 'https://github.com/facebook/react/pull/18684.diff', 'patch_url': 'https://github.com/facebook/react/pull/18684.patch', 'merged_at': datetime.datetime(2020, 4, 21, 1, 20, 4)} | This version takes into account the NODE_ENV as part of jest cache keys. This avoids flaky tests since we depend on different transforms in prod and dev.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18684/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18684/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18683 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18683/labels{/name} | https://api.github.com/repos/facebook/react/issues/18683/comments | https://api.github.com/repos/facebook/react/issues/18683/events | https://github.com/facebook/react/issues/18683 | 603,621,441 | MDU6SXNzdWU2MDM2MjE0NDE= | 18,683 | Bug: Effects never fire if the dependency list changes length and then stabilizes | {'login': 'aweary', 'id': 6886061, 'node_id': 'MDQ6VXNlcjY4ODYwNjE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6886061?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/aweary', 'html_url': 'https://github.com/aweary', 'followers_url': 'https://api.github.com/users/aweary/followers', 'followin... | [{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Needs%20Investigation', 'name': 'Type: Needs Investigation', 'color': '65AA9C', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
">Otherwise I can see an edge case where this warning gets ignored (or doesn't fire) in development and then effects stop firing in production.\r\n\r\nCan you clarify in which case it wouldn't fire in development?\r\n\r\nGenerally saying, we try to minimize checks in hot paths in production. Similar to hydration an... | 2020-04-21 00:35:04 | 2020-04-21 02:23:27 | 2020-04-21 02:23:27 | CONTRIBUTOR | null | null | null | [CodeSandbox reproducing the problem with the latest experimental build](https://codesandbox.io/s/eager-morning-tbfjm?file=/src/App.js:341-342)
This is an edge case with a DEV warning, so not really a priority, but it seems like the wrong behavior. If the length of the dependency array changes, React warns about it ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18683/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18683/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18682 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18682/labels{/name} | https://api.github.com/repos/facebook/react/issues/18682/comments | https://api.github.com/repos/facebook/react/issues/18682/events | https://github.com/facebook/react/issues/18682 | 603,602,176 | MDU6SXNzdWU2MDM2MDIxNzY= | 18,682 | Bug: [eslint-plugin-react-hooks] Custom Hooks are not linted with Namespace Imports | {'login': 'zachhats', 'id': 4756977, 'node_id': 'MDQ6VXNlcjQ3NTY5Nzc=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4756977?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/zachhats', 'html_url': 'https://github.com/zachhats', 'followers_url': 'https://api.github.com/users/zachhats/followers', '... | [{'id': 1249821345, 'node_id': 'MDU6TGFiZWwxMjQ5ODIxMzQ1', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20ESLint%20Rules', 'name': 'Component: ESLint Rules', 'color': 'f7afdb', 'default': False, 'description': ''}] | closed | false | null | [] | null | [
"Thanks for the report. \r\n\r\nWe've changed the heuristic in [`eslint-plugin-react-hooks@4.0.0`](https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md#400) to [consider calls like `Hooks.useHook()`](https://github.com/facebook/react/pull/18722) as Hooks, **but** Create Reac... | 2020-04-20 23:33:53 | 2020-07-17 17:04:54 | 2020-07-17 12:50:51 | NONE | null | null | null | Normally if you use a custom hook from anywhere other than a top-level function component, you get a lint error. However, if the custom hook is imported with a namespace import, you don't see a lint error. It's worth mentioning, I'm using typescript, I'm not sure if this repros with regular JS.
React version: We use... | {'url': 'https://api.github.com/repos/facebook/react/issues/18682/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18682/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18681 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18681/labels{/name} | https://api.github.com/repos/facebook/react/issues/18681/comments | https://api.github.com/repos/facebook/react/issues/18681/events | https://github.com/facebook/react/pull/18681 | 603,535,283 | MDExOlB1bGxSZXF1ZXN0NDA2MzAyNTgz | 18,681 | Warn when textarea switches between controlled and uncontrolled | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18681/builds/21132) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-20 21:06:32 | 2022-01-09 08:42:07 | 2022-01-09 08:42:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18681', 'html_url': 'https://github.com/facebook/react/pull/18681', 'diff_url': 'https://github.com/facebook/react/pull/18681.diff', 'patch_url': 'https://github.com/facebook/react/pull/18681.patch', 'merged_at': None} | resolve #16342 | {'url': 'https://api.github.com/repos/facebook/react/issues/18681/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18681/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18680 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18680/labels{/name} | https://api.github.com/repos/facebook/react/issues/18680/comments | https://api.github.com/repos/facebook/react/issues/18680/events | https://github.com/facebook/react/pull/18680 | 603,434,374 | MDExOlB1bGxSZXF1ZXN0NDA2MjIwMjkw | 18,680 | Modern event system: fix selectionchange bug | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18680/builds/21102) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-20 18:14:09 | 2020-04-20 18:54:17 | 2020-04-20 18:54:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18680', 'html_url': 'https://github.com/facebook/react/pull/18680', 'diff_url': 'https://github.com/facebook/react/pull/18680.diff', 'patch_url': 'https://github.com/facebook/react/pull/18680.patch', 'merged_at': datetime.datetime(2020, 4, 20, 18, 54, 13)} | This fixes the issue found in https://github.com/facebook/react/pull/18678.
Notably, `TOP_SELECTION_CHANGE` or the native event `selectionchange` should always be attached to the `document` when setting up the listener. We cannot attach to the React root – which is why we were seeing issues internally with the `Sele... | {'url': 'https://api.github.com/repos/facebook/react/issues/18680/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18680/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18679 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18679/labels{/name} | https://api.github.com/repos/facebook/react/issues/18679/comments | https://api.github.com/repos/facebook/react/issues/18679/events | https://github.com/facebook/react/pull/18679 | 603,404,617 | MDExOlB1bGxSZXF1ZXN0NDA2MTk2NjM4 | 18,679 | chore: Build react-dom/server in codesandbox CI | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18679/builds/21083) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-20 17:23:18 | 2020-04-20 17:56:37 | 2020-04-20 17:48:08 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18679', 'html_url': 'https://github.com/facebook/react/pull/18679', 'diff_url': 'https://github.com/facebook/react/pull/18679.diff', 'patch_url': 'https://github.com/facebook/react/pull/18679.patch', 'merged_at': datetime.datetime(2020, 4, 20, 17, 48, 8)} | ## Summary
For codesandboxes using PR deploys `react-dom/server` will be unavailable. This would've been helpful for e.g. #18676
## Test Plan
Check if https://codesandbox.io/s/dangerouslysetinnerhtml-undefined-dhs8i?file=/src/index.js works with a build from this PR
Edit: works https://codesandbox.io/s/danger... | {'url': 'https://api.github.com/repos/facebook/react/issues/18679/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18679/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18678 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18678/labels{/name} | https://api.github.com/repos/facebook/react/issues/18678/comments | https://api.github.com/repos/facebook/react/issues/18678/events | https://github.com/facebook/react/pull/18678 | 603,389,170 | MDExOlB1bGxSZXF1ZXN0NDA2MTg0Mjc4 | 18,678 | Add repro for select event inconsistency | {'login': 'philipp-spiess', 'id': 458591, 'node_id': 'MDQ6VXNlcjQ1ODU5MQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/458591?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/philipp-spiess', 'html_url': 'https://github.com/philipp-spiess', 'followers_url': 'https://api.github.com/users/philip... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18678/builds/21080) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-20 16:59:26 | 2020-04-21 09:55:51 | 2020-04-21 09:55:51 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18678', 'html_url': 'https://github.com/facebook/react/pull/18678', 'diff_url': 'https://github.com/facebook/react/pull/18678.diff', 'patch_url': 'https://github.com/facebook/react/pull/18678.patch', 'merged_at': None} | We have an issue in the modern select event plugin that is now no longer emitting `onSelect` when using CMD+a to select text on macOS.
The issue is that the `selectionchange` event is only emitted at the document and targets the document so without document level listeners, the modern event system doesn’t know it ha... | {'url': 'https://api.github.com/repos/facebook/react/issues/18678/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18678/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18677 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18677/labels{/name} | https://api.github.com/repos/facebook/react/issues/18677/comments | https://api.github.com/repos/facebook/react/issues/18677/events | https://github.com/facebook/react/issues/18677 | 603,218,481 | MDU6SXNzdWU2MDMyMTg0ODE= | 18,677 | RFC: interface for writing styles which render to CSSOM | {'login': 'kof', 'id': 52824, 'node_id': 'MDQ6VXNlcjUyODI0', 'avatar_url': 'https://avatars.githubusercontent.com/u/52824?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kof', 'html_url': 'https://github.com/kof', 'followers_url': 'https://api.github.com/users/kof/followers', 'following_url': 'https://api... | [] | closed | false | null | [] | null | [
"Closing in favor of a PR https://github.com/reactjs/rfcs/pull/159 \r\n\r\nI found a bunch of RFCs here as issues and thought this is the right way.",
"Something like the following:\r\n\r\n```js\r\n// library\r\nclass Style {\r\n\thandleStyle(type = 'insert|update|delete', name = 'color', value = 'red') {\r\n\t//... | 2020-04-20 12:58:19 | 2020-04-20 13:58:11 | 2020-04-20 13:47:55 | NONE | null | null | null | I know it's a long-lasting and controversial topic and probably not the highest priority for the team right now, but let me try to create the first **simplified** vision for a CSS implementation we all could agree on.
CSS-in-JS like React is on a dual mission, supporting both complex apps and small(ish) sites. This ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18677/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18677/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18676 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18676/labels{/name} | https://api.github.com/repos/facebook/react/issues/18676/comments | https://api.github.com/repos/facebook/react/issues/18676/events | https://github.com/facebook/react/pull/18676 | 603,142,610 | MDExOlB1bGxSZXF1ZXN0NDA1OTg2NDAx | 18,676 | fix: skip dangerouslySetInnerHtml hydration warning if it's undefined | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18676/builds/20971) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-20 10:53:02 | 2020-04-20 17:57:41 | 2020-04-20 17:46:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18676', 'html_url': 'https://github.com/facebook/react/pull/18676', 'diff_url': 'https://github.com/facebook/react/pull/18676.diff', 'patch_url': 'https://github.com/facebook/react/pull/18676.patch', 'merged_at': datetime.datetime(2020, 4, 20, 17, 46, 56)} | ## Summary
Closes #17170
## Test Plan
Added tests to `ReactServerRenderingHydration-test.js` that make sure that
1. no warning is issued if `dangerouslySetInnerHTML` is `undefined` and the markup matches
2. warnings are issued if `dangerouslySetInnerHTML` is `undefined` and the markup does not match.
Veri... | {'url': 'https://api.github.com/repos/facebook/react/issues/18676/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18676/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18675 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18675/labels{/name} | https://api.github.com/repos/facebook/react/issues/18675/comments | https://api.github.com/repos/facebook/react/issues/18675/events | https://github.com/facebook/react/issues/18675 | 602,786,870 | MDU6SXNzdWU2MDI3ODY4NzA= | 18,675 | DevTools | {'login': 'cbranch101', 'id': 1420404, 'node_id': 'MDQ6VXNlcjE0MjA0MDQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1420404?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/cbranch101', 'html_url': 'https://github.com/cbranch101', 'followers_url': 'https://api.github.com/users/cbranch101/follo... | [] | closed | false | null | [] | null | [] | 2020-04-19 18:25:00 | 2020-04-19 18:25:08 | 2020-04-19 18:25:08 | NONE | null | null | null | 👉 Please follow one of these issue templates:
- https://github.com/facebook/react/issues/new/choose
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18675/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18675/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18674 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18674/labels{/name} | https://api.github.com/repos/facebook/react/issues/18674/comments | https://api.github.com/repos/facebook/react/issues/18674/events | https://github.com/facebook/react/pull/18674 | 602,543,520 | MDExOlB1bGxSZXF1ZXN0NDA1NTU0ODU0 | 18,674 | Repro bug Nested SuspenseList may display fallbacks while the component is loaded on re-render | {'login': 'dubzzz', 'id': 5300235, 'node_id': 'MDQ6VXNlcjUzMDAyMzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5300235?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dubzzz', 'html_url': 'https://github.com/dubzzz', 'followers_url': 'https://api.github.com/users/dubzzz/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18674/builds/20727) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-18 20:20:41 | 2022-10-20 20:41:15 | 2022-10-20 20:41:15 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18674', 'html_url': 'https://github.com/facebook/react/pull/18674', 'diff_url': 'https://github.com/facebook/react/pull/18674.diff', 'patch_url': 'https://github.com/facebook/react/pull/18674.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18674/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18674/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18673 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18673/labels{/name} | https://api.github.com/repos/facebook/react/issues/18673/comments | https://api.github.com/repos/facebook/react/issues/18673/events | https://github.com/facebook/react/pull/18673 | 602,537,646 | MDExOlB1bGxSZXF1ZXN0NDA1NTUwNzc3 | 18,673 | Migrate ReactSuspense fuzz tests to Property Based Tests | {'login': 'dubzzz', 'id': 5300235, 'node_id': 'MDQ6VXNlcjUzMDAyMzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5300235?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dubzzz', 'html_url': 'https://github.com/dubzzz', 'followers_url': 'https://api.github.com/users/dubzzz/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18673/builds/20722) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-18 19:48:41 | 2020-07-25 16:05:48 | 2020-07-25 16:05:48 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18673', 'html_url': 'https://github.com/facebook/react/pull/18673', 'diff_url': 'https://github.com/facebook/react/pull/18673.diff', 'patch_url': 'https://github.com/facebook/react/pull/18673.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18673/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18673/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18672 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18672/labels{/name} | https://api.github.com/repos/facebook/react/issues/18672/comments | https://api.github.com/repos/facebook/react/issues/18672/events | https://github.com/facebook/react/pull/18672 | 602,509,563 | MDExOlB1bGxSZXF1ZXN0NDA1NTMyMzA1 | 18,672 | GitHub issue/pr links in IDEA Git log | {'login': 'turansky', 'id': 9942723, 'node_id': 'MDQ6VXNlcjk5NDI3MjM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9942723?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/turansky', 'html_url': 'https://github.com/turansky', 'followers_url': 'https://api.github.com/users/turansky/followers', '... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @turansky! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beh... | 2020-04-18 17:27:39 | 2020-07-19 17:50:51 | 2020-07-19 17:50:50 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18672', 'html_url': 'https://github.com/facebook/react/pull/18672', 'diff_url': 'https://github.com/facebook/react/pull/18672.diff', 'patch_url': 'https://github.com/facebook/react/pull/18672.patch', 'merged_at': None} | ## Summary
Clickable links in IDEA Git log
Before - `#18669`, `#18670`
After - #18669, #18670
## Test Plan
* Open IDEA Git log
* Check issue & PR links are clickable
<img width="675" alt="Screenshot 2020-04-18 at 20 21 06" src="https://user-images.githubusercontent.com/9942723/79644633-da02cd80-81b2-11ea-9e8... | {'url': 'https://api.github.com/repos/facebook/react/issues/18672/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18672/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18671 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18671/labels{/name} | https://api.github.com/repos/facebook/react/issues/18671/comments | https://api.github.com/repos/facebook/react/issues/18671/events | https://github.com/facebook/react/pull/18671 | 602,503,148 | MDExOlB1bGxSZXF1ZXN0NDA1NTI3NzU3 | 18,671 | Revert "Revert focus event PRs" | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18671/builds/20691) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-18 16:53:58 | 2022-11-29 22:21:47 | 2020-04-20 15:00:34 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18671', 'html_url': 'https://github.com/facebook/react/pull/18671', 'diff_url': 'https://github.com/facebook/react/pull/18671.diff', 'patch_url': 'https://github.com/facebook/react/pull/18671.patch', 'merged_at': datetime.datetime(2020, 4, 20, 15, 0, 34)} | We can revert these revert PRs as these were not the cause of the problems we had recently. | {'url': 'https://api.github.com/repos/facebook/react/issues/18671/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18671/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18670 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18670/labels{/name} | https://api.github.com/repos/facebook/react/issues/18670/comments | https://api.github.com/repos/facebook/react/issues/18670/events | https://github.com/facebook/react/pull/18670 | 602,460,119 | MDExOlB1bGxSZXF1ZXN0NDA1NDk5MTk1 | 18,670 | Repro bug for Google Closure Compiler | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18670/builds/118927) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on comm... | 2020-04-18 13:25:45 | 2022-04-03 18:24:02 | 2022-04-03 18:24:01 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18670', 'html_url': 'https://github.com/facebook/react/pull/18670', 'diff_url': 'https://github.com/facebook/react/pull/18670.diff', 'patch_url': 'https://github.com/facebook/react/pull/18670.patch', 'merged_at': None} | This strange set of changes causes our ReactDOM Prod bundle to have broken JS.
Run these commands to see the error:
`yarn build --type=NODE_PROD`
`yarn test-prod-build ReactDOMServerIntegrationTextarea`
You'll see this error:
`TypeError: Cannot read property 'focusedElem' of null`
It seems to be rela... | {'url': 'https://api.github.com/repos/facebook/react/issues/18670/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18670/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18669 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18669/labels{/name} | https://api.github.com/repos/facebook/react/issues/18669/comments | https://api.github.com/repos/facebook/react/issues/18669/events | https://github.com/facebook/react/issues/18669 | 602,457,323 | MDU6SXNzdWU2MDI0NTczMjM= | 18,669 | Add More Fuzz Tests | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 71502270, 'node_id': 'MDU6TGFiZWw3MTUwMjI3MA==', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20Build%20Infrastructure', 'name': 'Component: Build Infrastructure', 'color': 'f9d0c4', 'default': False, 'description': None}
{'id': 1205087127, 'node_id': 'MDU6TGFiZWwxMjA1MDg3MTI3', 'url':... | closed | false | null | [] | null | [
"Yes, I'll be really interested in helping on this subject.\r\n\r\nFor the moment, I already drafted some fuzz tests based on property based testing for `SuspenseList` ([here](https://github.com/dubzzz/react/blob/e2cb4776ea3634fab2021d83cb8259bde03c0f3a/packages/react-reconciler/src/__tests__/ReactSuspenseList-test... | 2020-04-18 13:11:29 | 2020-08-01 09:10:10 | 2020-08-01 09:10:10 | COLLABORATOR | null | null | null | There’s some things we don’t have a sufficient coverage of. Currently we catch them from production product bugs but this is not sustainable. We’re hoping some refactors will drastically simplify the model — but nevertheless we should invest in better fuzz test coverage. That’s how we caught similar bugs before at an e... | {'url': 'https://api.github.com/repos/facebook/react/issues/18669/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18669/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18668 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18668/labels{/name} | https://api.github.com/repos/facebook/react/issues/18668/comments | https://api.github.com/repos/facebook/react/issues/18668/events | https://github.com/facebook/react/pull/18668 | 602,443,460 | MDExOlB1bGxSZXF1ZXN0NDA1NDg4NzAx | 18,668 | Refine the heuristics around beforeblur/afterblur | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18668/builds/21074) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-18 11:57:45 | 2020-04-20 18:32:27 | 2020-04-20 18:32:23 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18668', 'html_url': 'https://github.com/facebook/react/pull/18668', 'diff_url': 'https://github.com/facebook/react/pull/18668.diff', 'patch_url': 'https://github.com/facebook/react/pull/18668.patch', 'merged_at': datetime.datetime(2020, 4, 20, 18, 32, 23)} | This is a follow up to https://github.com/facebook/react/pull/18662. Notably, that PR was a temporary fix, which turned out to still have issues when testing locally on FB.
I listened to the advice from @sebmarkbage and we now handle the logic for determining if an active element fiber is in a hidden or deleted sub-... | {'url': 'https://api.github.com/repos/facebook/react/issues/18668/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18668/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18667 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18667/labels{/name} | https://api.github.com/repos/facebook/react/issues/18667/comments | https://api.github.com/repos/facebook/react/issues/18667/events | https://github.com/facebook/react/pull/18667 | 602,411,336 | MDExOlB1bGxSZXF1ZXN0NDA1NDY3MjAx | 18,667 | Fixed some typos and removed redundant code | {'login': 'mikaelparsekyan', 'id': 47053264, 'node_id': 'MDQ6VXNlcjQ3MDUzMjY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/47053264?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mikaelparsekyan', 'html_url': 'https://github.com/mikaelparsekyan', 'followers_url': 'https://api.github.com/users... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18667/builds/20630) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-18 08:41:14 | 2020-05-20 18:52:29 | 2020-05-20 18:52:29 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18667', 'html_url': 'https://github.com/facebook/react/pull/18667', 'diff_url': 'https://github.com/facebook/react/pull/18667.diff', 'patch_url': 'https://github.com/facebook/react/pull/18667.patch', 'merged_at': None} | Removed redundant else-s in the code and fixed some petty typos. | {'url': 'https://api.github.com/repos/facebook/react/issues/18667/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18667/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18666 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18666/labels{/name} | https://api.github.com/repos/facebook/react/issues/18666/comments | https://api.github.com/repos/facebook/react/issues/18666/events | https://github.com/facebook/react/issues/18666 | 602,391,376 | MDU6SXNzdWU2MDIzOTEzNzY= | 18,666 | Bug: Uncaught Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object. | {'login': 'baymac', 'id': 23079344, 'node_id': 'MDQ6VXNlcjIzMDc5MzQ0', 'avatar_url': 'https://avatars.githubusercontent.com/u/23079344?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/baymac', 'html_url': 'https://github.com/baymac', 'followers_url': 'https://api.github.com/users/baymac/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Oop! The function call to `renderRoot` should be:\r\n\r\n```javascript\r\nrenderRoot(Home)\r\n```\r\n\r\nMy bad! Closing this issue."
] | 2020-04-18 06:29:16 | 2020-04-18 07:06:57 | 2020-04-18 07:06:57 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: ^16.7.0 && 16.13.1
## Steps To Reproduce
1. Here is the fol... | {'url': 'https://api.github.com/repos/facebook/react/issues/18666/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18666/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18665 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18665/labels{/name} | https://api.github.com/repos/facebook/react/issues/18665/comments | https://api.github.com/repos/facebook/react/issues/18665/events | https://github.com/facebook/react/pull/18665 | 602,368,341 | MDExOlB1bGxSZXF1ZXN0NDA1NDM3NjMx | 18,665 | Remove unused Flow suppression comment | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18665/builds/20624) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-18 03:35:23 | 2020-04-18 03:45:00 | 2020-04-18 03:44:28 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18665', 'html_url': 'https://github.com/facebook/react/pull/18665', 'diff_url': 'https://github.com/facebook/react/pull/18665.diff', 'patch_url': 'https://github.com/facebook/react/pull/18665.patch', 'merged_at': None} | ^ dats what it do | {'url': 'https://api.github.com/repos/facebook/react/issues/18665/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18665/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18664 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18664/labels{/name} | https://api.github.com/repos/facebook/react/issues/18664/comments | https://api.github.com/repos/facebook/react/issues/18664/events | https://github.com/facebook/react/pull/18664 | 602,358,507 | MDExOlB1bGxSZXF1ZXN0NDA1NDMwMzgw | 18,664 | Make Flow work with your editor | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18664/builds/20704) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-18 02:23:08 | 2020-04-18 17:24:47 | 2020-04-18 17:24:47 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18664', 'html_url': 'https://github.com/facebook/react/pull/18664', 'diff_url': 'https://github.com/facebook/react/pull/18664.diff', 'patch_url': 'https://github.com/facebook/react/pull/18664.patch', 'merged_at': datetime.datetime(2020, 4, 18, 17, 24, 47)} | We typecheck the reconciler against each one of our host configs. `yarn flow dom` checks it against the DOM renderer, `yarn flow native` checks it against the native renderer, and so on.
To do this, we generate separate flowconfig files.
Currently, there is no root-level host config, so running Flow directly via ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18664/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18664/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18663 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18663/labels{/name} | https://api.github.com/repos/facebook/react/issues/18663/comments | https://api.github.com/repos/facebook/react/issues/18663/events | https://github.com/facebook/react/pull/18663 | 602,275,038 | MDExOlB1bGxSZXF1ZXN0NDA1MzczOTMy | 18,663 | Fix for #18657 | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18663/builds/20592) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 22:55:20 | 2020-04-17 23:32:56 | 2020-04-17 23:32:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18663', 'html_url': 'https://github.com/facebook/react/pull/18663', 'diff_url': 'https://github.com/facebook/react/pull/18663.diff', 'patch_url': 'https://github.com/facebook/react/pull/18663.patch', 'merged_at': datetime.datetime(2020, 4, 17, 23, 32, 56)} | I think this was just poor factoring on my part in #18411. Honestly it doesn't make much sense to me, but my best guess is that I must have thought that when `baseTime > currentChildExpirationTime`, the function would fall through to the `currentChildExpirationTime < renderExpirationTime` branch below.
Really I thin... | {'url': 'https://api.github.com/repos/facebook/react/issues/18663/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18663/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18662 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18662/labels{/name} | https://api.github.com/repos/facebook/react/issues/18662/comments | https://api.github.com/repos/facebook/react/issues/18662/events | https://github.com/facebook/react/pull/18662 | 602,271,601 | MDExOlB1bGxSZXF1ZXN0NDA1MzcxMjM5 | 18,662 | Revise isFiberInsideHiddenOrRemovedTree | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18662/builds/20591) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 22:43:38 | 2020-04-17 22:58:44 | 2020-04-17 22:58:41 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18662', 'html_url': 'https://github.com/facebook/react/pull/18662', 'diff_url': 'https://github.com/facebook/react/pull/18662.diff', 'patch_url': 'https://github.com/facebook/react/pull/18662.patch', 'merged_at': datetime.datetime(2020, 4, 17, 22, 58, 41)} | We can validate the `child` of the Suspense Component to see what branch the active element is in. Note: this is not a thorough fix, as it doesn't take into account the fact that the active element might be in both branches due to a lower-pri update. | {'url': 'https://api.github.com/repos/facebook/react/issues/18662/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18662/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18661 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18661/labels{/name} | https://api.github.com/repos/facebook/react/issues/18661/comments | https://api.github.com/repos/facebook/react/issues/18661/events | https://github.com/facebook/react/issues/18661 | 602,267,255 | MDU6SXNzdWU2MDIyNjcyNTU= | 18,661 | Bug: Nested SuspenseList may display fallbacks while the component is loaded on re-render | {'login': 'dubzzz', 'id': 5300235, 'node_id': 'MDQ6VXNlcjUzMDAyMzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5300235?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dubzzz', 'html_url': 'https://github.com/dubzzz', 'followers_url': 'https://api.github.com/users/dubzzz/followers', 'followin... | [{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Needs%20Investigation', 'name': 'Type: Needs Investigation', 'color': '65AA9C', 'default': False, 'description': ''}
{'id': 1205087127, 'node_id': 'MDU6TGFiZWwxMjA1MDg3MTI3', 'url': 'https://api... | open | false | null | [] | null | [
"Haven’t looked at the issue yet (and might not for a bit). But we need a lot stronger fuzz coverage for Suspense, SuspenseList, and priority scheduling. See the recent closed bugs with “concurrent mode” label for examples of how things go wrong and what catches them. If you’d like to contribute, coming up with a s... | 2020-04-17 22:29:35 | 2020-05-22 08:47:00 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
**React version:** 0.0.0-experimental-e5d06e34b
Hoping this can be helpful fo... | {'url': 'https://api.github.com/repos/facebook/react/issues/18661/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18661/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18660 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18660/labels{/name} | https://api.github.com/repos/facebook/react/issues/18660/comments | https://api.github.com/repos/facebook/react/issues/18660/events | https://github.com/facebook/react/pull/18660 | 602,265,095 | MDExOlB1bGxSZXF1ZXN0NDA1MzY2MTMx | 18,660 | Fix mistyped script arbitrary code execution vulnerability | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18660/builds/21403) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 22:23:22 | 2020-05-27 16:30:25 | 2020-04-21 19:10:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18660', 'html_url': 'https://github.com/facebook/react/pull/18660', 'diff_url': 'https://github.com/facebook/react/pull/18660.diff', 'patch_url': 'https://github.com/facebook/react/pull/18660.patch', 'merged_at': datetime.datetime(2020, 4, 21, 19, 10, 25)} | fix #15978, #13825
| {'url': 'https://api.github.com/repos/facebook/react/issues/18660/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18660/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18659 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18659/labels{/name} | https://api.github.com/repos/facebook/react/issues/18659/comments | https://api.github.com/repos/facebook/react/issues/18659/events | https://github.com/facebook/react/pull/18659 | 602,215,838 | MDExOlB1bGxSZXF1ZXN0NDA1MzI2MjMw | 18,659 | Support inner component _debugOwner in memo | {'login': 'hanq08', 'id': 11851678, 'node_id': 'MDQ6VXNlcjExODUxNjc4', 'avatar_url': 'https://avatars.githubusercontent.com/u/11851678?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/hanq08', 'html_url': 'https://github.com/hanq08', 'followers_url': 'https://api.github.com/users/hanq08/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Hi @hanq08! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on behal... | 2020-04-17 20:28:30 | 2020-08-07 19:21:27 | 2020-08-07 19:21:27 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18659', 'html_url': 'https://github.com/facebook/react/pull/18659', 'diff_url': 'https://github.com/facebook/react/pull/18659.diff', 'patch_url': 'https://github.com/facebook/react/pull/18659.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18659/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18659/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18658 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18658/labels{/name} | https://api.github.com/repos/facebook/react/issues/18658/comments | https://api.github.com/repos/facebook/react/issues/18658/events | https://github.com/facebook/react/pull/18658 | 602,183,947 | MDExOlB1bGxSZXF1ZXN0NDA1MzAwNTE5 | 18,658 | Fall back to LowPriority rather than Idle | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [] | 2020-04-17 19:23:01 | 2021-02-11 16:33:53 | 2021-02-11 16:33:53 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18658', 'html_url': 'https://github.com/facebook/react/pull/18658', 'diff_url': 'https://github.com/facebook/react/pull/18658.diff', 'patch_url': 'https://github.com/facebook/react/pull/18658.patch', 'merged_at': None} | There wasn't a particular case motivating this, but opening so we don't forget to come back to it. This fails a bunch of tests. I haven't looked at them yet.
I guess this would also need to update the "new" one. | {'url': 'https://api.github.com/repos/facebook/react/issues/18658/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18658/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18657 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18657/labels{/name} | https://api.github.com/repos/facebook/react/issues/18657/comments | https://api.github.com/repos/facebook/react/issues/18657/events | https://github.com/facebook/react/issues/18657 | 602,135,899 | MDU6SXNzdWU2MDIxMzU4OTk= | 18,657 | Bug: Normal update between Idle render and a Ping causes Fallback to get stuck | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 1205087127, 'node_id': 'MDU6TGFiZWwxMjA1MDg3MTI3', 'url': 'https://api.github.com/repos/facebook/react/... | closed | false | null | [] | null | [] | 2020-04-17 17:46:44 | 2020-04-17 23:32:56 | 2020-04-17 23:32:56 | COLLABORATOR | null | null | null | Repro case with a master build: https://codesandbox.io/s/stoic-mcnulty-dhygf?file=/src/App.js:668-703
Expected: we see content after a second.
Actual: fallback never resolves.
This happens in a sequence of:
1. Normal update
- which suspends
2. Idle update
- which also suspends
3. An unrelated normal... | {'url': 'https://api.github.com/repos/facebook/react/issues/18657/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18657/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18656 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18656/labels{/name} | https://api.github.com/repos/facebook/react/issues/18656/comments | https://api.github.com/repos/facebook/react/issues/18656/events | https://github.com/facebook/react/pull/18656 | 602,133,560 | MDExOlB1bGxSZXF1ZXN0NDA1MjU5Nzky | 18,656 | DevTools: Improved "native" component stacks | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18656/builds/21392) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 17:42:10 | 2020-04-21 18:46:15 | 2020-04-21 18:46:11 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18656', 'html_url': 'https://github.com/facebook/react/pull/18656', 'diff_url': 'https://github.com/facebook/react/pull/18656.diff', 'patch_url': 'https://github.com/facebook/react/pull/18656.patch', 'merged_at': datetime.datetime(2020, 4, 21, 18, 46, 11)} | DevTools provides an option to automatically append "component stacks" to third party warnings (`console.warn`) and errors (`console.error`):
This works by...
1. DevTools intercepts calls to `console.warn`... | {'url': 'https://api.github.com/repos/facebook/react/issues/18656/reactions', 'total_count': 3, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18656/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18655 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18655/labels{/name} | https://api.github.com/repos/facebook/react/issues/18655/comments | https://api.github.com/repos/facebook/react/issues/18655/events | https://github.com/facebook/react/pull/18655 | 602,045,612 | MDExOlB1bGxSZXF1ZXN0NDA1MTg5Njk4 | 18,655 | Revert focus event PRs | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18655/builds/20510) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 15:10:38 | 2020-04-17 16:14:09 | 2020-04-17 15:27:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18655', 'html_url': 'https://github.com/facebook/react/pull/18655', 'diff_url': 'https://github.com/facebook/react/pull/18655.diff', 'patch_url': 'https://github.com/facebook/react/pull/18655.patch', 'merged_at': datetime.datetime(2020, 4, 17, 15, 27, 20)} | This PR reverts two revent PRs relating to the Flare focus changes:
https://github.com/facebook/react/commit/e2ccbf0358fafc8eb4470a45f5bca1cb97a4bba2
https://github.com/facebook/react/commit/f24a9e70980c2b1d0eb8309eb751315ff39f96bd
This is because we have an e2e test failing on the www sync relating to `beforebl... | {'url': 'https://api.github.com/repos/facebook/react/issues/18655/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18655/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18654 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18654/labels{/name} | https://api.github.com/repos/facebook/react/issues/18654/comments | https://api.github.com/repos/facebook/react/issues/18654/events | https://github.com/facebook/react/pull/18654 | 602,030,665 | MDExOlB1bGxSZXF1ZXN0NDA1MTc3NDU5 | 18,654 | Fixed minor code issues | {'login': 'mikaelparsekyan', 'id': 47053264, 'node_id': 'MDQ6VXNlcjQ3MDUzMjY0', 'avatar_url': 'https://avatars.githubusercontent.com/u/47053264?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mikaelparsekyan', 'html_url': 'https://github.com/mikaelparsekyan', 'followers_url': 'https://api.github.com/users... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18654/builds/20506) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 14:49:11 | 2020-04-17 14:56:55 | 2020-04-17 14:53:36 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18654', 'html_url': 'https://github.com/facebook/react/pull/18654', 'diff_url': 'https://github.com/facebook/react/pull/18654.diff', 'patch_url': 'https://github.com/facebook/react/pull/18654.patch', 'merged_at': None} | Fixed inlined return statements warnings. | {'url': 'https://api.github.com/repos/facebook/react/issues/18654/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18654/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18653 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18653/labels{/name} | https://api.github.com/repos/facebook/react/issues/18653/comments | https://api.github.com/repos/facebook/react/issues/18653/events | https://github.com/facebook/react/issues/18653 | 601,936,054 | MDU6SXNzdWU2MDE5MzYwNTQ= | 18,653 | Bug: keydown Event - inconsistent behaviour | {'login': 'damianOfKyan', 'id': 47245766, 'node_id': 'MDQ6VXNlcjQ3MjQ1NzY2', 'avatar_url': 'https://avatars.githubusercontent.com/u/47245766?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/damianOfKyan', 'html_url': 'https://github.com/damianOfKyan', 'followers_url': 'https://api.github.com/users/damianOf... | [] | closed | false | null | [] | null | [
"~~To be clear, only one event fires when you press the key (\"keydown\"). The second \"click\" event fires in Firefox on key up, but not in Chrome. This does seem wrong.~~\r\n\r\n~~I think the expected behavior here listed above is wrong though. I think two events should fire: \"keydown\" (on keydown) and \"click\... | 2020-04-17 12:20:13 | 2020-07-17 13:09:31 | 2020-07-17 13:09:30 | NONE | null | null | null | There is inconsistency in Event triggering.
Can be observed by testing in Chrome and Firefox.
In below code example:
In Chrome, On button focus, when "Space" bar keypress, React triggers 1x keydown Event
In Firefox, On button focus, when "Space" bar keypress, React triggers 1x keydown Event and 1x click Event
ht... | {'url': 'https://api.github.com/repos/facebook/react/issues/18653/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18653/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18652 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18652/labels{/name} | https://api.github.com/repos/facebook/react/issues/18652/comments | https://api.github.com/repos/facebook/react/issues/18652/events | https://github.com/facebook/react/issues/18652 | 601,806,594 | MDU6SXNzdWU2MDE4MDY1OTQ= | 18,652 | [Flight] Make react-flight works between UI thread and webworkers | {'login': 'csr632', 'id': 18747423, 'node_id': 'MDQ6VXNlcjE4NzQ3NDIz', 'avatar_url': 'https://avatars.githubusercontent.com/u/18747423?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/csr632', 'html_url': 'https://github.com/csr632', 'followers_url': 'https://api.github.com/users/csr632/followers', 'follow... | [{'id': 710375792, 'node_id': 'MDU6TGFiZWw3MTAzNzU3OTI=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Discussion', 'name': 'Type: Discussion', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 2192194047, 'node_id': 'MDU6TGFiZWwyMTkyMTk0MDQ3', 'url': 'https://api.github.com/repos/... | closed | false | null | [] | null | [
"I found a related project: https://github.com/dai-shi/react-worker-components",
"This is actually one of the first things we tried back in 2014 or so. It wasn't very good in practice. Turns out, the communication overhead is making it not worth it, at least in our experience for the general case.",
"Found anot... | 2020-04-17 08:44:25 | 2022-04-10 14:37:22 | 2021-03-24 18:59:43 | NONE | null | null | null | I am really exited about [react flight](https://github.com/facebook/react/tree/master/packages/react-server) that you are working on right now. But I notice you are focusing on UI cooperation between client and server. How about also make it works **between UI thread and webworkers**?
So, instead of:
- react-server... | {'url': 'https://api.github.com/repos/facebook/react/issues/18652/reactions', 'total_count': 15, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 15} | https://api.github.com/repos/facebook/react/issues/18652/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18651 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18651/labels{/name} | https://api.github.com/repos/facebook/react/issues/18651/comments | https://api.github.com/repos/facebook/react/issues/18651/events | https://github.com/facebook/react/issues/18651 | 601,779,316 | MDU6SXNzdWU2MDE3NzkzMTY= | 18,651 | Bug: react-is isLazy is error | {'login': 'frontlich', 'id': 26480483, 'node_id': 'MDQ6VXNlcjI2NDgwNDgz', 'avatar_url': 'https://avatars.githubusercontent.com/u/26480483?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/frontlich', 'html_url': 'https://github.com/frontlich', 'followers_url': 'https://api.github.com/users/frontlich/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"react-is works on elements not element types. This was deliberately changed for React.lazy in #17278"
] | 2020-04-17 07:57:44 | 2020-04-17 09:47:38 | 2020-04-17 09:47:38 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
react 16.13.1
react-is 16.13.1
## Steps To Reproduce
im... | {'url': 'https://api.github.com/repos/facebook/react/issues/18651/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18651/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18649 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18649/labels{/name} | https://api.github.com/repos/facebook/react/issues/18649/comments | https://api.github.com/repos/facebook/react/issues/18649/events | https://github.com/facebook/react/pull/18649 | 601,648,819 | MDExOlB1bGxSZXF1ZXN0NDA0ODgwMTcw | 18,649 | Further cleanup to before/after blur | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18649/builds/20364) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 02:01:16 | 2020-04-17 10:52:33 | 2020-04-17 10:52:30 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18649', 'html_url': 'https://github.com/facebook/react/pull/18649', 'diff_url': 'https://github.com/facebook/react/pull/18649.diff', 'patch_url': 'https://github.com/facebook/react/pull/18649.patch', 'merged_at': datetime.datetime(2020, 4, 17, 10, 52, 29)} | This is a follow up to https://github.com/facebook/react/pull/18636. This cleans up more code that was not really needed anymore and replaces it with simpler code. Instead of emulating the event through Flare, we pass through a native event that we listen to for both Flare and the modern event system, fixing an issue I... | {'url': 'https://api.github.com/repos/facebook/react/issues/18649/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18649/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18648 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18648/labels{/name} | https://api.github.com/repos/facebook/react/issues/18648/comments | https://api.github.com/repos/facebook/react/issues/18648/events | https://github.com/facebook/react/pull/18648 | 601,609,490 | MDExOlB1bGxSZXF1ZXN0NDA0ODUwNDE1 | 18,648 | Fixed DevTools extension build:dev command | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18648/builds/20348) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 00:02:14 | 2020-04-17 00:39:30 | 2020-04-17 00:39:20 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18648', 'html_url': 'https://github.com/facebook/react/pull/18648', 'diff_url': 'https://github.com/facebook/react/pull/18648.diff', 'patch_url': 'https://github.com/facebook/react/pull/18648.patch', 'merged_at': datetime.datetime(2020, 4, 17, 0, 39, 20)} | Fixes #18512 | {'url': 'https://api.github.com/repos/facebook/react/issues/18648/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18648/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18647 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18647/labels{/name} | https://api.github.com/repos/facebook/react/issues/18647/comments | https://api.github.com/repos/facebook/react/issues/18647/events | https://github.com/facebook/react/pull/18647 | 601,608,459 | MDExOlB1bGxSZXF1ZXN0NDA0ODQ5NTYw | 18,647 | Fix a ping preventing a root with Idle work from being rescheduled | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18647/builds/20350) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-17 00:00:23 | 2020-06-29 18:19:49 | 2020-06-29 18:19:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18647', 'html_url': 'https://github.com/facebook/react/pull/18647', 'diff_url': 'https://github.com/facebook/react/pull/18647.diff', 'patch_url': 'https://github.com/facebook/react/pull/18647.patch', 'merged_at': None} | Fixes https://github.com/facebook/react/issues/18644.
I don't know if this is the correct fix model-wise. But it does fix both the sandbox and the product issue we found, and it doesn't fail any of our tests.
---
Here's the gist of the repro case:
<details>
We schedule a UB and Idle updates together. We ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18647/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18647/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18646 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18646/labels{/name} | https://api.github.com/repos/facebook/react/issues/18646/comments | https://api.github.com/repos/facebook/react/issues/18646/events | https://github.com/facebook/react/pull/18646 | 601,545,426 | MDExOlB1bGxSZXF1ZXN0NDA0Nzk1MDY3 | 18,646 | Attempt to repro #18644 in a test | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ed5567685e390c2311d4574... | 2020-04-16 22:23:38 | 2020-06-29 18:18:45 | 2020-06-29 18:18:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18646', 'html_url': 'https://github.com/facebook/react/pull/18646', 'diff_url': 'https://github.com/facebook/react/pull/18646.diff', 'patch_url': 'https://github.com/facebook/react/pull/18646.patch', 'merged_at': None} | See the bug and the sandbox in https://github.com/facebook/react/issues/18644.
I didn't figure out how to finish this test to trigger exactly this case. Left a few logs. | {'url': 'https://api.github.com/repos/facebook/react/issues/18646/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18646/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18644 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18644/labels{/name} | https://api.github.com/repos/facebook/react/issues/18644/comments | https://api.github.com/repos/facebook/react/issues/18644/events | https://github.com/facebook/react/issues/18644 | 601,281,648 | MDU6SXNzdWU2MDEyODE2NDg= | 18,644 | Bug: Idle updates may cause normal priority updates to get "stuck" | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 1205087127, 'node_id': 'MDU6TGFiZWwxMjA1MDg3MTI3', 'url': 'https://api.github.com/repos/facebook/react/... | closed | false | null | [] | null | [
"This appears to have been fixed — possibly, by Lanes.\r\nhttps://codesandbox.io/s/friendly-browser-3hhh0\r\n\r\nI don't know how to write a test for it so I'll just close."
] | 2020-04-16 17:49:41 | 2020-06-29 18:19:38 | 2020-06-29 18:19:38 | COLLABORATOR | null | null | null | This repro is quite convoluted but it's the best I could extract. It seems like numerous things need to happen to trigger this bug. To reproduce:
1. Open https://codesandbox.io/s/great-wildflower-mv89b and wait a second
3. Observe that there is only one "Hello" (for UB). Normal update got stuck.
4. Also notice how... | {'url': 'https://api.github.com/repos/facebook/react/issues/18644/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18644/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18643 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18643/labels{/name} | https://api.github.com/repos/facebook/react/issues/18643/comments | https://api.github.com/repos/facebook/react/issues/18643/events | https://github.com/facebook/react/pull/18643 | 601,219,755 | MDExOlB1bGxSZXF1ZXN0NDA0NTEyOTk3 | 18,643 | Bump https-proxy-agent from 2.2.2 to 2.2.4 | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18643/builds/20227) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 16:16:48 | 2022-10-10 19:10:54 | 2020-04-16 23:06:07 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18643', 'html_url': 'https://github.com/facebook/react/pull/18643', 'diff_url': 'https://github.com/facebook/react/pull/18643.diff', 'patch_url': 'https://github.com/facebook/react/pull/18643.patch', 'merged_at': datetime.datetime(2020, 4, 16, 23, 6, 7)} | Bumps [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) from 2.2.2 to 2.2.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/TooTallNate/node-https-proxy-agent/releases">https-proxy-agent's releases</a>.</em></p>
<blockquote>
<h2>2.2.4</h2>
<h3>Patches... | {'url': 'https://api.github.com/repos/facebook/react/issues/18643/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18643/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18642 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18642/labels{/name} | https://api.github.com/repos/facebook/react/issues/18642/comments | https://api.github.com/repos/facebook/react/issues/18642/events | https://github.com/facebook/react/pull/18642 | 601,218,196 | MDExOlB1bGxSZXF1ZXN0NDA0NTExNjMw | 18,642 | Bump https-proxy-agent from 2.2.1 to 2.2.4 in /scripts/release | {'login': 'dependabot[bot]', 'id': 49699333, 'node_id': 'MDM6Qm90NDk2OTkzMzM=', 'avatar_url': 'https://avatars.githubusercontent.com/in/29110?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dependabot%5Bbot%5D', 'html_url': 'https://github.com/apps/dependabot', 'followers_url': 'https://api.github.com/use... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1757816973, 'node_id': 'MDU6TGFiZWwxNzU3ODE2OTcz', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18642/builds/20226) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 16:15:17 | 2022-10-10 19:11:03 | 2020-04-16 23:06:13 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18642', 'html_url': 'https://github.com/facebook/react/pull/18642', 'diff_url': 'https://github.com/facebook/react/pull/18642.diff', 'patch_url': 'https://github.com/facebook/react/pull/18642.patch', 'merged_at': datetime.datetime(2020, 4, 16, 23, 6, 13)} | Bumps [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) from 2.2.1 to 2.2.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/TooTallNate/node-https-proxy-agent/releases">https-proxy-agent's releases</a>.</em></p>
<blockquote>
<h2>2.2.4</h2>
<h3>Patches... | {'url': 'https://api.github.com/repos/facebook/react/issues/18642/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18642/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18641 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18641/labels{/name} | https://api.github.com/repos/facebook/react/issues/18641/comments | https://api.github.com/repos/facebook/react/issues/18641/events | https://github.com/facebook/react/pull/18641 | 601,218,074 | MDExOlB1bGxSZXF1ZXN0NDA0NTExNTIy | 18,641 | Statically disable factory components for WWW | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18641/builds/20225) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-16 16:15:10 | 2020-04-16 18:42:31 | 2020-04-16 18:42:31 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18641', 'html_url': 'https://github.com/facebook/react/pull/18641', 'diff_url': 'https://github.com/facebook/react/pull/18641.diff', 'patch_url': 'https://github.com/facebook/react/pull/18641.patch', 'merged_at': datetime.datetime(2020, 4, 16, 18, 42, 31)} | GK out to 100%. | {'url': 'https://api.github.com/repos/facebook/react/issues/18641/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18641/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18640 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18640/labels{/name} | https://api.github.com/repos/facebook/react/issues/18640/comments | https://api.github.com/repos/facebook/react/issues/18640/events | https://github.com/facebook/react/issues/18640 | 601,216,337 | MDU6SXNzdWU2MDEyMTYzMzc= | 18,640 | Allow opting out of invokeGuardedCallbackDev | {'login': 'spectras', 'id': 5879675, 'node_id': 'MDQ6VXNlcjU4Nzk2NzU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/5879675?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/spectras', 'html_url': 'https://github.com/spectras', 'followers_url': 'https://api.github.com/users/spectras/followers', '... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 139734344, 'node_id': 'MDU6TGFiZWwxMzk3MzQzNDQ=', 'url': 'https://api.github... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-04-16 16:13:34 | 2020-12-25 15:06:38 | 2020-12-25 15:06:38 | NONE | null | null | null | At the moment, when in development mode, React uses a special workflow for callbacks, to avoid using `try...catch`.
It works well. So well that several testing frameworks also get their uncaught exception handling triggered.
**Example with mocha:**
```js
import React from 'react';
import { render } from '@test... | {'url': 'https://api.github.com/repos/facebook/react/issues/18640/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18640/timeline | null | completed | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.