url stringlengths 56 56 | repository_url stringclasses 1
value | labels_url stringlengths 70 70 | comments_url stringlengths 65 65 | events_url stringlengths 63 63 | html_url stringlengths 44 46 | id int64 570M 2.28B | node_id stringlengths 18 32 | number int64 18.1k 29k | title stringlengths 1 570 | user stringlengths 854 1.31k | labels stringclasses 293
values | state stringclasses 2
values | locked bool 2
classes | assignee stringclasses 263
values | assignees stringclasses 287
values | milestone float64 | comments listlengths 0 30 | created_at stringlengths 19 19 | updated_at stringlengths 19 19 | closed_at stringlengths 19 19 ⌀ | author_association stringclasses 4
values | active_lock_reason stringclasses 3
values | draft bool 2
classes | pull_request stringlengths 277 316 ⌀ | body stringlengths 1 43.2k ⌀ | reactions stringlengths 189 198 | timeline_url stringlengths 65 65 | performed_via_github_app float64 | state_reason stringclasses 3
values | is_pull_request bool 2
classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react/issues/18842 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18842/labels{/name} | https://api.github.com/repos/facebook/react/issues/18842/comments | https://api.github.com/repos/facebook/react/issues/18842/events | https://github.com/facebook/react/issues/18842 | 613,338,705 | MDU6SXNzdWU2MTMzMzg3MDU= | 18,842 | Bug: Previous and next props in memo equality function are the same | {'login': 'fourstacks', 'id': 6280211, 'node_id': 'MDQ6VXNlcjYyODAyMTE=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6280211?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fourstacks', 'html_url': 'https://github.com/fourstacks', 'followers_url': 'https://api.github.com/users/fourstacks/follo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"That's because you mutate your field objects in `getComputedFormFields`. ` getComputedFormFields` always return a new array, but it always contains original objects.",
"Ahh, ok! So basically I need to return a deep clone of `field` in `getComputedFields` in order for react to detect the change? Seems to work i... | 2020-05-06 13:54:05 | 2020-05-06 21:38:03 | 2020-05-06 16:08:16 | NONE | null | null | null | I have built a config-driven form builder package for the Shopify Polaris UI library. I'm using `memo` to prevent unnecessary updates. This memo call uses an equality check method which checks (among other things) if a `fields` prop has changed. If it has, the whole component should re-render. The fields prop is an... | {'url': 'https://api.github.com/repos/facebook/react/issues/18842/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18842/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18841 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18841/labels{/name} | https://api.github.com/repos/facebook/react/issues/18841/comments | https://api.github.com/repos/facebook/react/issues/18841/events | https://github.com/facebook/react/issues/18841 | 613,294,659 | MDU6SXNzdWU2MTMyOTQ2NTk= | 18,841 | Bug: Error in useEffect is caught in ErrorBoundary, but still logs uncaught error to console in tests | {'login': 'mpeyper', 'id': 23029903, 'node_id': 'MDQ6VXNlcjIzMDI5OTAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/23029903?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mpeyper', 'html_url': 'https://github.com/mpeyper', 'followers_url': 'https://api.github.com/users/mpeyper/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | open | false | null | [] | null | [
"Is there some way to get some eyes on this? I don't want to be that Dev that tags a bunch of people, but this is the second issue I've raised here that has gone unnoticed (or at least unacknowledged) which is frustrating because I've tried my best to give a detailed and thorough report when raising it.",
"Not su... | 2020-05-06 12:50:33 | 2024-04-17 18:16:01 | null | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.1
## Steps To Reproduce
1. Create a component with a ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18841/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18841/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18840 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18840/labels{/name} | https://api.github.com/repos/facebook/react/issues/18840/comments | https://api.github.com/repos/facebook/react/issues/18840/events | https://github.com/facebook/react/pull/18840 | 613,235,858 | MDExOlB1bGxSZXF1ZXN0NDE0MDI4MDE3 | 18,840 | [Blocks Fixture] Remove Remaining Blocks | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18840/builds/24753) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-06 11:07:27 | 2020-05-06 14:53:52 | 2020-05-06 14:53:52 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18840', 'html_url': 'https://github.com/facebook/react/pull/18840', 'diff_url': 'https://github.com/facebook/react/pull/18840.diff', 'patch_url': 'https://github.com/facebook/react/pull/18840.patch', 'merged_at': datetime.datetime(2020, 5, 6, 14, 53, 52)} | Follow-up to https://github.com/facebook/react/pull/18837.
Imports from server code to the client should either be Assets References or, since we don't have them, might as well just be plain imports. Which we would find and replace in the build plugin based on a directory or some filename convention.
This removes... | {'url': 'https://api.github.com/repos/facebook/react/issues/18840/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18840/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18839 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18839/labels{/name} | https://api.github.com/repos/facebook/react/issues/18839/comments | https://api.github.com/repos/facebook/react/issues/18839/events | https://github.com/facebook/react/issues/18839 | 613,097,240 | MDU6SXNzdWU2MTMwOTcyNDA= | 18,839 | Inhancement: Dispatch (returned by useReducer) shuould also be available as third parameter in reducer function. | {'login': 'sumitsj', 'id': 34498432, 'node_id': 'MDQ6VXNlcjM0NDk4NDMy', 'avatar_url': 'https://avatars.githubusercontent.com/u/34498432?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sumitsj', 'html_url': 'https://github.com/sumitsj', 'followers_url': 'https://api.github.com/users/sumitsj/followers', 'fo... | [] | closed | false | null | [] | null | [
"dispatch function generally accepts the action, and invokes the reducer to update the state.\r\n\r\nwhat does it solve? reducers should be kept separate from dispatchers.\r\n\r\ndispatcher(action) -> reducer -> update UI\r\n\r\nthis is an architecture decision I guess. \r\n\r\nflux arch ( i know flux is old, but t... | 2020-05-06 07:05:37 | 2020-05-07 11:56:40 | 2020-05-07 11:56:39 | NONE | null | null | null | React version: @latest
**I am using Context API to manage state of my application, and stuck at below problem.**
## The current behavior
Currently, reducer function takes just **state** and **action** as parameter. I can dispatch actions from components only, due the behavior of hooks (as you know). But what if ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18839/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18839/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18838 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18838/labels{/name} | https://api.github.com/repos/facebook/react/issues/18838/comments | https://api.github.com/repos/facebook/react/issues/18838/events | https://github.com/facebook/react/pull/18838 | 613,079,642 | MDExOlB1bGxSZXF1ZXN0NDEzOTAxNDk2 | 18,838 | Warn if calling setState outside of render but before commit | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18838/builds/24832) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-06 06:25:43 | 2020-05-06 16:45:36 | 2020-05-06 16:45:36 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18838', 'html_url': 'https://github.com/facebook/react/pull/18838', 'diff_url': 'https://github.com/facebook/react/pull/18838.diff', 'patch_url': 'https://github.com/facebook/react/pull/18838.patch', 'merged_at': datetime.datetime(2020, 5, 6, 16, 45, 36)} | This indicates that there's a side-effect spawned during render, that then asynchronously tries to set state when the response comes back. E.g. kick off a request and then setState with the result. It's a common mistake when implementing Suspense.
This should be done in useEffect. | {'url': 'https://api.github.com/repos/facebook/react/issues/18838/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18838/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18837 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18837/labels{/name} | https://api.github.com/repos/facebook/react/issues/18837/comments | https://api.github.com/repos/facebook/react/issues/18837/events | https://github.com/facebook/react/pull/18837 | 613,027,168 | MDExOlB1bGxSZXF1ZXN0NDEzODU4ODU1 | 18,837 | [Blocks Fixture] Drop the Blocks | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18837/builds/24683) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-06 03:32:12 | 2020-05-06 04:17:45 | 2020-05-06 04:17:45 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18837', 'html_url': 'https://github.com/facebook/react/pull/18837', 'diff_url': 'https://github.com/facebook/react/pull/18837.diff', 'patch_url': 'https://github.com/facebook/react/pull/18837.patch', 'merged_at': datetime.datetime(2020, 5, 6, 4, 17, 45)} | Builds on https://github.com/facebook/react/pull/18832, but So. Much. Cleaner. | {'url': 'https://api.github.com/repos/facebook/react/issues/18837/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18837/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18836 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18836/labels{/name} | https://api.github.com/repos/facebook/react/issues/18836/comments | https://api.github.com/repos/facebook/react/issues/18836/events | https://github.com/facebook/react/pull/18836 | 612,959,558 | MDExOlB1bGxSZXF1ZXN0NDEzODA1NjE5 | 18,836 | [WIP] SuspenseList should do a second pass if all children are dehydrated | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18836/builds/24956) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-05 23:40:05 | 2022-10-20 20:41:17 | 2022-10-20 20:41:17 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18836', 'html_url': 'https://github.com/facebook/react/pull/18836', 'diff_url': 'https://github.com/facebook/react/pull/18836.diff', 'patch_url': 'https://github.com/facebook/react/pull/18836.patch', 'merged_at': None} | SuspenseList doesn't trigger the "together" mode when all children are client rendered.
The issue here is that we have an optimization to figure out if the list might be suspended:
https://github.com/facebook/react/blob/master/packages/react-reconciler/src/ReactFiberCompleteWork.old.js#L1033
This doesn't trigger... | {'url': 'https://api.github.com/repos/facebook/react/issues/18836/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18836/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18835 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18835/labels{/name} | https://api.github.com/repos/facebook/react/issues/18835/comments | https://api.github.com/repos/facebook/react/issues/18835/events | https://github.com/facebook/react/issues/18835 | 612,934,072 | MDU6SXNzdWU2MTI5MzQwNzI= | 18,835 | useMutableSource: Release version snapshots once hydration is finished | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/react/labels/React%20Core%20Team', 'name': 'React Core Team', 'color': '9149d1', 'default': False, 'description': 'Opened by a member of the React Core Team'}] | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [] | 2020-05-05 22:28:47 | 2022-03-30 00:40:04 | 2022-03-30 00:40:04 | CONTRIBUTOR | null | null | null | Follow up for #18183 and PR #18771.
Decide when to clear `mutableSourceEagerHydrationData`. We don't currently have a way to detect when all outstanding hydration work is finished. (It may never finish.) This means that in use cases where the version is the entire sore (e.g. an immutable store without a version "num... | {'url': 'https://api.github.com/repos/facebook/react/issues/18835/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18835/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18834 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18834/labels{/name} | https://api.github.com/repos/facebook/react/issues/18834/comments | https://api.github.com/repos/facebook/react/issues/18834/events | https://github.com/facebook/react/issues/18834 | 612,929,873 | MDU6SXNzdWU2MTI5Mjk4NzM= | 18,834 | Bug: different between { | {'login': 'jillesme', 'id': 2955483, 'node_id': 'MDQ6VXNlcjI5NTU0ODM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2955483?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jillesme', 'html_url': 'https://github.com/jillesme', 'followers_url': 'https://api.github.com/users/jillesme/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"the issue seems to be empty? did you make this by accident?"
] | 2020-05-05 22:18:44 | 2020-05-07 23:35:00 | 2020-05-07 23:35:00 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version:
## Steps To Reproduce
1.
2.
<!--
Your bug will get f... | {'url': 'https://api.github.com/repos/facebook/react/issues/18834/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18834/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18833 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18833/labels{/name} | https://api.github.com/repos/facebook/react/issues/18833/comments | https://api.github.com/repos/facebook/react/issues/18833/events | https://github.com/facebook/react/issues/18833 | 612,895,781 | MDU6SXNzdWU2MTI4OTU3ODE= | 18,833 | Bug: [ESLint Hooks Plugin] false positive with useCallback and not inline function body | {'login': 'kilianc', 'id': 385716, 'node_id': 'MDQ6VXNlcjM4NTcxNg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/385716?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/kilianc', 'html_url': 'https://github.com/kilianc', 'followers_url': 'https://api.github.com/users/kilianc/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"The purpose of the linter is to verify that you don't have stale closures. If you pass invisible `selector` and `dependencies` we can't verify that. You can add an ignore there if you're convinced the deps are correct, but the warning itself is right — it says something may be unsafe. E.g. in your example, nothing... | 2020-05-05 21:07:34 | 2020-05-06 13:52:57 | 2020-05-05 21:35:22 | NONE | null | null | null | I just received `eslint-plugin-react-hooks@4.0` through dependabot, and I am a little confused by the error and the explanation in this PR https://github.com/facebook/react/pull/18435. I might be wrong but I don't think I should be getting a lint warning/error.
```ts
const useFoo = <R>(
selector: (state: S) =>... | {'url': 'https://api.github.com/repos/facebook/react/issues/18833/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18833/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18832 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18832/labels{/name} | https://api.github.com/repos/facebook/react/issues/18832/comments | https://api.github.com/repos/facebook/react/issues/18832/events | https://github.com/facebook/react/pull/18832 | 612,875,043 | MDExOlB1bGxSZXF1ZXN0NDEzNzM2ODkx | 18,832 | [Blocks Fixture] Add a tiny router | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against ee623bcbdba618ef30c62d1... | 2020-05-05 20:29:42 | 2020-05-06 04:18:09 | 2020-05-06 04:18:09 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18832', 'html_url': 'https://github.com/facebook/react/pull/18832', 'diff_url': 'https://github.com/facebook/react/pull/18832.diff', 'patch_url': 'https://github.com/facebook/react/pull/18832.patch', 'merged_at': None} | Just a small abstraction for route matching to get a feel for how it composes. The function returns parsed out "params", which include remaining `route`. The nested matches would use that instead of the root `route`. | {'url': 'https://api.github.com/repos/facebook/react/issues/18832/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18832/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18831 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18831/labels{/name} | https://api.github.com/repos/facebook/react/issues/18831/comments | https://api.github.com/repos/facebook/react/issues/18831/events | https://github.com/facebook/react/issues/18831 | 612,790,612 | MDU6SXNzdWU2MTI3OTA2MTI= | 18,831 | Error: "Commit tree does not contain fiber 256. This is a bug in React DevTools." | {'login': 'RickeyWard', 'id': 342468, 'node_id': 'MDQ6VXNlcjM0MjQ2OA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/342468?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/RickeyWard', 'html_url': 'https://github.com/RickeyWard', 'followers_url': 'https://api.github.com/users/RickeyWard/followe... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | {'login': 'bvaughn', 'id': 29597.0, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_... | [{'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_u... | null | [
"Are you able to repro this? If so, can you share a repro case with us?",
"@bvaughn \r\nhi, I received a similar error while working with a very large list that is slow to render\r\nRepo is here: https://github.com/adaschevici/goodreads-v2/tree/05-continuous-integration\r\nFYI: it has submodules so you should clo... | 2020-05-05 18:01:22 | 2020-07-15 17:16:43 | 2020-07-15 16:25:28 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Profiling a slow component
In a component that rendered 5000 pre tags with single lines of text in them, that has an unrelated controlled text box is the same component that was typed into while profiling. App hung a while and, when it rendered again the error wa... | {'url': 'https://api.github.com/repos/facebook/react/issues/18831/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18831/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18830 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18830/labels{/name} | https://api.github.com/repos/facebook/react/issues/18830/comments | https://api.github.com/repos/facebook/react/issues/18830/events | https://github.com/facebook/react/pull/18830 | 612,781,468 | MDExOlB1bGxSZXF1ZXN0NDEzNjYxMjU2 | 18,830 | Modern Event System: fix EnterLeave plugin logic | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18830/builds/24625) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-05 17:45:41 | 2020-05-05 21:10:12 | 2020-05-05 21:10:08 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18830', 'html_url': 'https://github.com/facebook/react/pull/18830', 'diff_url': 'https://github.com/facebook/react/pull/18830.diff', 'patch_url': 'https://github.com/facebook/react/pull/18830.patch', 'merged_at': datetime.datetime(2020, 5, 5, 21, 10, 8)} | Today we found an internal issue with the modern event system and the EnterLeave plugin. Specifically, we didn't track `mouseout` on the container, only in the portal. That's because the portal had a child contained `onMouseEnter`. This bug is actually very similar to that of the recent fix to https://github.com/facebo... | {'url': 'https://api.github.com/repos/facebook/react/issues/18830/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18830/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18829 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18829/labels{/name} | https://api.github.com/repos/facebook/react/issues/18829/comments | https://api.github.com/repos/facebook/react/issues/18829/events | https://github.com/facebook/react/issues/18829 | 612,742,555 | MDU6SXNzdWU2MTI3NDI1NTU= | 18,829 | Feature suggestion: possibility to intercept props for the components | {'login': 'misaeldossantos', 'id': 47726159, 'node_id': 'MDQ6VXNlcjQ3NzI2MTU5', 'avatar_url': 'https://avatars.githubusercontent.com/u/47726159?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/misaeldossantos', 'html_url': 'https://github.com/misaeldossantos', 'followers_url': 'https://api.github.com/users... | [] | closed | false | null | [] | null | [
"Directives were made for templated systems because you couldn't write regular javascript in them. React instead lets you use regular js idioms for functionality like this. \r\n```jsx \r\n{someCondition && <div> <span> Something </span> </div>}\r\n```\r\nBut if you do want 'directives', there's nothing stopping you... | 2020-05-05 16:42:09 | 2020-07-22 15:11:41 | 2020-05-07 23:40:40 | NONE | null | null | null | Intercept a component's props, transforming them.
Thus, it would be possible to implement directives as in vue and angular:
example:
```jsx
<div
@showIf = "visible"
>
<span> Something </span>
</div>
function renderIf (condition, oldProps) {
return merge (oldProps, {style: {visible: condition}})
}
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18829/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18829/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18828 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18828/labels{/name} | https://api.github.com/repos/facebook/react/issues/18828/comments | https://api.github.com/repos/facebook/react/issues/18828/events | https://github.com/facebook/react/issues/18828 | 612,606,483 | MDU6SXNzdWU2MTI2MDY0ODM= | 18,828 | Bug [ESLint Hooks Plugin]: When using a `typeof` type guard it requires the value as a dependency | {'login': 'egonm12', 'id': 20042349, 'node_id': 'MDQ6VXNlcjIwMDQyMzQ5', 'avatar_url': 'https://avatars.githubusercontent.com/u/20042349?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/egonm12', 'html_url': 'https://github.com/egonm12', 'followers_url': 'https://api.github.com/users/egonm12/followers', 'fo... | [{'id': 40929153, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mw==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Enhancement', 'name': 'Type: Enhancement', 'color': '84b6eb', 'default': False, 'description': None}
{'id': 1249821345, 'node_id': 'MDU6TGFiZWwxMjQ5ODIxMzQ1', 'url': 'https://api.github.com/repos... | closed | false | null | [] | null | [
"Wanna send a fix? Seems TS specific.",
"Gonna look into it, will keep you posted",
"Hi! Could I maybe give this a shot? @egonm12 are you still working on it?",
"@delca85 Please go ahead, it's been a while!",
"@delca85 fixed this in #19316. If you find other similar issues, please report them too! Thanks.\r... | 2020-05-05 13:33:32 | 2020-07-13 17:02:58 | 2020-07-13 16:57:01 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
**Version:** eslint-plugin-react-hooks@1.7.0
## Steps To Reproduce
1. Crea... | {'url': 'https://api.github.com/repos/facebook/react/issues/18828/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18828/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18827 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18827/labels{/name} | https://api.github.com/repos/facebook/react/issues/18827/comments | https://api.github.com/repos/facebook/react/issues/18827/events | https://github.com/facebook/react/pull/18827 | 612,547,588 | MDExOlB1bGxSZXF1ZXN0NDEzNDcxNTY1 | 18,827 | Modern Event System: ensure target ancestors are only host nodes | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18827/builds/24538) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-05 11:59:05 | 2020-05-05 12:10:06 | 2020-05-05 12:10:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18827', 'html_url': 'https://github.com/facebook/react/pull/18827', 'diff_url': 'https://github.com/facebook/react/pull/18827.diff', 'patch_url': 'https://github.com/facebook/react/pull/18827.patch', 'merged_at': datetime.datetime(2020, 5, 5, 12, 10, 6)} | With the modern event system, we previously didn't guard against the ancestor being a fiber that was a non-host component, as `getClosestInstanceFromNode` can return a `HostRoot` or `SuspenseComponent`. In the legacy event system we had this check, so we should incorporate it here too. I wasn't able to make a repro tes... | {'url': 'https://api.github.com/repos/facebook/react/issues/18827/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18827/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18826 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18826/labels{/name} | https://api.github.com/repos/facebook/react/issues/18826/comments | https://api.github.com/repos/facebook/react/issues/18826/events | https://github.com/facebook/react/issues/18826 | 612,442,974 | MDU6SXNzdWU2MTI0NDI5NzQ= | 18,826 | Bug [eslint hooks plugin]: Allow conditional hooks based on static constants | {'login': 'adrianhelvik', 'id': 7836058, 'node_id': 'MDQ6VXNlcjc4MzYwNTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7836058?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/adrianhelvik', 'html_url': 'https://github.com/adrianhelvik', 'followers_url': 'https://api.github.com/users/adrianhelv... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-05-05 08:50:42 | 2020-08-16 07:23:54 | 2020-08-16 07:23:54 | NONE | null | null | null | This scenario should not trigger a warning as it follows the rules of hooks.
```javascript
import React from 'react'
const SOME_STATIC_CONDITION = process.env.SOME_STATIC_CONDITION === 'true'
function App() {
if (SOME_STATIC_CONDITION) {
React.useEffect(() => {
console.log('This should only run... | {'url': 'https://api.github.com/repos/facebook/react/issues/18826/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18826/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18825 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18825/labels{/name} | https://api.github.com/repos/facebook/react/issues/18825/comments | https://api.github.com/repos/facebook/react/issues/18825/events | https://github.com/facebook/react/pull/18825 | 612,338,643 | MDExOlB1bGxSZXF1ZXN0NDEzMzA2NjY5 | 18,825 | Add unstable prefix to experimental APIs | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18825/builds/24475) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-05 05:00:23 | 2020-05-08 04:50:28 | 2020-05-05 05:25:42 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18825', 'html_url': 'https://github.com/facebook/react/pull/18825', 'diff_url': 'https://github.com/facebook/react/pull/18825.diff', 'patch_url': 'https://github.com/facebook/react/pull/18825.patch', 'merged_at': datetime.datetime(2020, 5, 5, 5, 25, 42)} | We've been shipping unprefixed experimental APIs (like `createRoot` and `useTransition`) to the Experimental release channel, with the rationale that because these APIs do not appear in any stable release, we're free to change or remove them later without breaking any downstream projects.
What we didn't consider is ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18825/reactions', 'total_count': 6, '+1': 3, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 3} | https://api.github.com/repos/facebook/react/issues/18825/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18824 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18824/labels{/name} | https://api.github.com/repos/facebook/react/issues/18824/comments | https://api.github.com/repos/facebook/react/issues/18824/events | https://github.com/facebook/react/issues/18824 | 612,293,691 | MDU6SXNzdWU2MTIyOTM2OTE= | 18,824 | Error: "Could not find commit data for root "98" and commit 8" | {'login': 'WaSheep', 'id': 17945318, 'node_id': 'MDQ6VXNlcjE3OTQ1MzE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/17945318?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/WaSheep', 'html_url': 'https://github.com/WaSheep', 'followers_url': 'https://api.github.com/users/WaSheep/followers', 'fo... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | {'login': 'WaSheep', 'id': 17945318.0, 'node_id': 'MDQ6VXNlcjE3OTQ1MzE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/17945318?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/WaSheep', 'html_url': 'https://github.com/WaSheep', 'followers_url': 'https://api.github.com/users/WaSheep/followers', '... | [{'login': 'WaSheep', 'id': 17945318, 'node_id': 'MDQ6VXNlcjE3OTQ1MzE4', 'avatar_url': 'https://avatars.githubusercontent.com/u/17945318?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/WaSheep', 'html_url': 'https://github.com/WaSheep', 'followers_url': 'https://api.github.com/users/WaSheep/followers', 'f... | null | [
"Hi @WaSheep!\r\n\r\nSorry about the inconvenience!\r\n\r\nThis looks like a duplicate of #18010 so I'm going to close it.\r\n\r\nIt's possible that PR #18862 fixes this issue, but that remains to be seen. If you can reproduce this issue, we would greatly appreciate if you left a comment with repro instructions so ... | 2020-05-05 03:09:21 | 2020-05-07 23:43:09 | 2020-05-07 23:41:44 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1.
2.
3.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.6.0-6cceaeb67
Call stack: at n.value (chrome-extension://fmkadmapgofadopljbjfkapdkoi... | {'url': 'https://api.github.com/repos/facebook/react/issues/18824/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18824/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18823 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18823/labels{/name} | https://api.github.com/repos/facebook/react/issues/18823/comments | https://api.github.com/repos/facebook/react/issues/18823/events | https://github.com/facebook/react/issues/18823 | 612,235,697 | MDU6SXNzdWU2MTIyMzU2OTc= | 18,823 | useMutableSource: allow getSnapshot to return a function | {'login': 'dai-shi', 'id': 490574, 'node_id': 'MDQ6VXNlcjQ5MDU3NA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/490574?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/dai-shi', 'html_url': 'https://github.com/dai-shi', 'followers_url': 'https://api.github.com/users/dai-shi/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Thanks. Understood. I'd try not-100%-safe workaround in my lib, or let the lib users do a workaround.",
"Thanks for understanding!",
"(For those who might come here later,) here's my workaround: https://github.com/dai-shi/use-context-selector/pull/12/commits/2fcf1a2bfb9552daedca11ecff030914e3089aa3#diff-f41e9d... | 2020-05-04 23:34:25 | 2020-05-22 12:52:30 | 2020-05-21 23:14:30 | CONTRIBUTOR | null | null | null | Ref: https://github.com/reactjs/rfcs/pull/147#issuecomment-623740218
React version: 0.0.0-experimental-e5d06e34b
## Steps To Reproduce
1. createMutableSource that contains functions
2. getSnapshot returns one of the functions
Link to code example:
https://codesandbox.io/s/jovial-dew-1eg4t?file=/src/App.... | {'url': 'https://api.github.com/repos/facebook/react/issues/18823/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18823/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18822 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18822/labels{/name} | https://api.github.com/repos/facebook/react/issues/18822/comments | https://api.github.com/repos/facebook/react/issues/18822/events | https://github.com/facebook/react/issues/18822 | 612,218,315 | MDU6SXNzdWU2MTIyMTgzMTU= | 18,822 | Add devtools "Inspect React component" to right-click menu | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 121709921, 'node_id': 'MDU6TGFiZWwxMjE3MDk5MjE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Feature%20Request', 'name': 'Type: Feature Request', 'color': 'c7def8', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github... | open | false | null | [] | null | [
"I'd like to have a go at this if its OK?",
"@sophiebits please review. https://github.com/facebook/react/pull/18939",
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we have... | 2020-05-04 22:50:47 | 2021-02-18 17:09:26 | null | COLLABORATOR | null | null | null | Noticed today that Vue's devtools have an awesome "Inspect Vue component" option when right-clicking on a webpage (added in https://github.com/vuejs/vue-devtools/pull/479).
The React devtools should have the same feature! It would be useful when debugging for sure.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18822/reactions', 'total_count': 19, '+1': 19, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18822/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18821 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18821/labels{/name} | https://api.github.com/repos/facebook/react/issues/18821/comments | https://api.github.com/repos/facebook/react/issues/18821/events | https://github.com/facebook/react/issues/18821 | 612,155,859 | MDU6SXNzdWU2MTIxNTU4NTk= | 18,821 | Bug: ARIA Attribute Reflection | {'login': 'jonathantneal', 'id': 188426, 'node_id': 'MDQ6VXNlcjE4ODQyNg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/188426?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jonathantneal', 'html_url': 'https://github.com/jonathantneal', 'followers_url': 'https://api.github.com/users/jonathant... | [{'id': 127893911, 'node_id': 'MDU6TGFiZWwxMjc4OTM5MTE=', 'url': 'https://api.github.com/repos/facebook/react/labels/Component:%20DOM', 'name': 'Component: DOM', 'color': 'fef2c0', 'default': False, 'description': None}
{'id': 620368407, 'node_id': 'MDU6TGFiZWw2MjAzNjg0MDc=', 'url': 'https://api.github.com/repos/faceb... | closed | false | null | [] | null | [
"All is correct. Aria attributes should use only kebab case.\r\nhttps://reactjs.org/docs/accessibility.html#wai-aria",
"Hey, @TrySound! First — off topic — I’m always happy to catch you on GitHub. I hope you’re doing awesome. Okay, back on topic:\r\n\r\nCheck out some of the links in my PR. In ARIA 1.2, there are... | 2020-05-04 20:43:38 | 2020-08-10 01:29:56 | 2020-08-10 01:29:56 | NONE | null | null | null | React version: 16.13.1
## Steps To Reproduce
1. Implement the [gov.uk "breadcrumbs" component](https://design-system.service.gov.uk/components/breadcrumbs/) in React.
2. Use the [ARIA 1.2](https://www.w3.org/TR/wai-aria-1.2/#idl-interface) `ariaCurrent` property, as available in Edge 81, Chrome 81, and Safari 13... | {'url': 'https://api.github.com/repos/facebook/react/issues/18821/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18821/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18820 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18820/labels{/name} | https://api.github.com/repos/facebook/react/issues/18820/comments | https://api.github.com/repos/facebook/react/issues/18820/events | https://github.com/facebook/react/pull/18820 | 612,145,359 | MDExOlB1bGxSZXF1ZXN0NDEzMTY2MjU1 | 18,820 | eslint-plugin-react-hooks: allow OptionalMemberExpression in deps (#18819) | {'login': 'coolkev', 'id': 319334, 'node_id': 'MDQ6VXNlcjMxOTMzNA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/319334?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/coolkev', 'html_url': 'https://github.com/coolkev', 'followers_url': 'https://api.github.com/users/coolkev/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18820/builds/24429) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-04 20:25:18 | 2020-05-14 19:32:24 | 2020-05-05 12:53:43 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18820', 'html_url': 'https://github.com/facebook/react/pull/18820', 'diff_url': 'https://github.com/facebook/react/pull/18820.diff', 'patch_url': 'https://github.com/facebook/react/pull/18820.patch', 'merged_at': datetime.datetime(2020, 5, 5, 12, 53, 43)} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18820/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18820/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18819 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18819/labels{/name} | https://api.github.com/repos/facebook/react/issues/18819/comments | https://api.github.com/repos/facebook/react/issues/18819/events | https://github.com/facebook/react/issues/18819 | 612,135,706 | MDU6SXNzdWU2MTIxMzU3MDY= | 18,819 | Bug: eslint-plugin-react-hooks cannot use optional chaining in deps | {'login': 'coolkev', 'id': 319334, 'node_id': 'MDQ6VXNlcjMxOTMzNA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/319334?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/coolkev', 'html_url': 'https://github.com/coolkev', 'followers_url': 'https://api.github.com/users/coolkev/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hey one, Idea is inside of x you can make it look more like this \r\nconst x = Date.now() % 2 === 0 ? { test: true } : { test: undefined };\r\nthat should get the result you want I think.\r\n\r\nAlso, if you're on Firefox and you did not set privacy.reduceTimerPrecision you will not get the right reduced time... | 2020-05-04 20:08:59 | 2020-10-04 15:42:02 | 2020-07-07 21:42:48 | CONTRIBUTOR | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.3.1
eslint-plugin-react-hooks version: 4.0.0
## Steps To R... | {'url': 'https://api.github.com/repos/facebook/react/issues/18819/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18819/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18818 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18818/labels{/name} | https://api.github.com/repos/facebook/react/issues/18818/comments | https://api.github.com/repos/facebook/react/issues/18818/events | https://github.com/facebook/react/issues/18818 | 612,059,866 | MDU6SXNzdWU2MTIwNTk4NjY= | 18,818 | Bug: devtools "rendered at" for child components uses value of top component | {'login': 'eps1lon', 'id': 12292047, 'node_id': 'MDQ6VXNlcjEyMjkyMDQ3', 'avatar_url': 'https://avatars.githubusercontent.com/u/12292047?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/eps1lon', 'html_url': 'https://github.com/eps1lon', 'followers_url': 'https://api.github.com/users/eps1lon/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 710573595, 'node_id': 'MDU6T... | open | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-05-04 17:58:37 | 2024-04-11 20:24:32 | null | COLLABORATOR | null | null | null | React version: 17.0.2
devtools version: 4.18.0-f58bbcf9a
## Steps To Reproduce
1. Record profiling session
2. Goto flamegraph
3. Click on a "bar" that's not the top-most
Link to code example: https://codesandbox.io/s/vibrant-thunder-bm3so
## The current behavior
"rendered at" uses the value from the r... | {'url': 'https://api.github.com/repos/facebook/react/issues/18818/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18818/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18817 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18817/labels{/name} | https://api.github.com/repos/facebook/react/issues/18817/comments | https://api.github.com/repos/facebook/react/issues/18817/events | https://github.com/facebook/react/issues/18817 | 612,047,625 | MDU6SXNzdWU2MTIwNDc2MjU= | 18,817 | Bug: Weird behavior when using react hooks inside of a React.StrictMode wrapper | {'login': 'acharb', 'id': 30449853, 'node_id': 'MDQ6VXNlcjMwNDQ5ODUz', 'avatar_url': 'https://avatars.githubusercontent.com/u/30449853?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acharb', 'html_url': 'https://github.com/acharb', 'followers_url': 'https://api.github.com/users/acharb/followers', 'follow... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Your reducer isn't pure which leads to the double increment due to React's [StrictMode](https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects).\r\n\r\nYou'd want something like \r\n\r\n```diff\r\n-state.test += 1;\r\n-return state\r\n+ return { test: state.test + 1 }\r\n```",
"@eps1lon than... | 2020-05-04 17:37:54 | 2020-05-05 01:53:34 | 2020-05-04 23:05:08 | NONE | null | null | null |
React version:
16.13
## Steps To Reproduce
1. setting state from the useRender hook immediately followed by a state sending function from useState, causes the useRender function to be called twice.
- this happens under the following occasion only (that I've noticed)
1. if we bail out of rendering in our u... | {'url': 'https://api.github.com/repos/facebook/react/issues/18817/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18817/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18816 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18816/labels{/name} | https://api.github.com/repos/facebook/react/issues/18816/comments | https://api.github.com/repos/facebook/react/issues/18816/events | https://github.com/facebook/react/pull/18816 | 612,044,228 | MDExOlB1bGxSZXF1ZXN0NDEzMDg0OTIy | 18,816 | chore: upgrade to Jest 26 | {'login': 'SimenB', 'id': 1404810, 'node_id': 'MDQ6VXNlcjE0MDQ4MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1404810?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SimenB', 'html_url': 'https://github.com/SimenB', 'followers_url': 'https://api.github.com/users/SimenB/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18816/builds/24409) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-04 17:32:15 | 2020-10-02 06:49:03 | 2020-10-02 06:48:58 | CONTRIBUTOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18816', 'html_url': 'https://github.com/facebook/react/pull/18816', 'diff_url': 'https://github.com/facebook/react/pull/18816.diff', 'patch_url': 'https://github.com/facebook/react/pull/18816.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18816/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18816/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18815 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18815/labels{/name} | https://api.github.com/repos/facebook/react/issues/18815/comments | https://api.github.com/repos/facebook/react/issues/18815/events | https://github.com/facebook/react/pull/18815 | 612,037,522 | MDExOlB1bGxSZXF1ZXN0NDEzMDc5NTMz | 18,815 | chore: remove usage of deprecated Jest functions | {'login': 'SimenB', 'id': 1404810, 'node_id': 'MDQ6VXNlcjE0MDQ4MTA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1404810?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/SimenB', 'html_url': 'https://github.com/SimenB', 'followers_url': 'https://api.github.com/users/SimenB/followers', 'followin... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18815/builds/24408) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-04 17:21:11 | 2020-10-02 06:48:43 | 2020-10-02 06:48:39 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18815', 'html_url': 'https://github.com/facebook/react/pull/18815', 'diff_url': 'https://github.com/facebook/react/pull/18815.diff', 'patch_url': 'https://github.com/facebook/react/pull/18815.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18815/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18815/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18814 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18814/labels{/name} | https://api.github.com/repos/facebook/react/issues/18814/comments | https://api.github.com/repos/facebook/react/issues/18814/events | https://github.com/facebook/react/pull/18814 | 611,930,398 | MDExOlB1bGxSZXF1ZXN0NDEyOTk1MjY3 | 18,814 | [Memory Leaks] Detach Fibers from nodes with refs | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18814/builds/24369) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-04 14:43:37 | 2021-02-11 18:23:07 | 2021-02-11 16:33:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18814', 'html_url': 'https://github.com/facebook/react/pull/18814', 'diff_url': 'https://github.com/facebook/react/pull/18814.diff', 'patch_url': 'https://github.com/facebook/react/pull/18814.patch', 'merged_at': None} | A more restrained alternative to https://github.com/facebook/react/pull/18690.
Addresses @sebmarkbage's proposal in https://github.com/facebook/react/issues/16087:
> If a handle on a DOM node is leaked, it takes the React tree with it. This is a fairly easy mistake to make and the effect is pretty high. What we wou... | {'url': 'https://api.github.com/repos/facebook/react/issues/18814/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18814/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18813 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18813/labels{/name} | https://api.github.com/repos/facebook/react/issues/18813/comments | https://api.github.com/repos/facebook/react/issues/18813/events | https://github.com/facebook/react/pull/18813 | 611,891,623 | MDExOlB1bGxSZXF1ZXN0NDEyOTY1MDE0 | 18,813 | [RN] Remove debugging invariant | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18813/builds/24352) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-04 13:51:56 | 2020-05-04 14:48:35 | 2020-05-04 14:48:35 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18813', 'html_url': 'https://github.com/facebook/react/pull/18813', 'diff_url': 'https://github.com/facebook/react/pull/18813.diff', 'patch_url': 'https://github.com/facebook/react/pull/18813.patch', 'merged_at': datetime.datetime(2020, 5, 4, 14, 48, 35)} | We didn't end up gathering anything useful from it, except confirming there might be a very rare Hermes issue. See T62461245. | {'url': 'https://api.github.com/repos/facebook/react/issues/18813/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18813/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18812 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18812/labels{/name} | https://api.github.com/repos/facebook/react/issues/18812/comments | https://api.github.com/repos/facebook/react/issues/18812/events | https://github.com/facebook/react/issues/18812 | 611,867,274 | MDU6SXNzdWU2MTE4NjcyNzQ= | 18,812 | Bug: Multiple `useState()` calls to `set` override each other | {'login': 'tms1337', 'id': 8905560, 'node_id': 'MDQ6VXNlcjg5MDU1NjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8905560?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/tms1337', 'html_url': 'https://github.com/tms1337', 'followers_url': 'https://api.github.com/users/tms1337/followers', 'foll... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Common react setState pitfall where `state` in the second action still is the original `state`.\r\n\r\nhow it should be done:\r\n```js\r\n{\r\n setA: value => {\r\n setState(prevState=>({ ...prevState, a: value }));\r\n },\r\n setB: value => {\r\n setState(prevState=>({ ...prevState, b: value }));\r\n },... | 2020-05-04 13:16:20 | 2020-05-04 13:50:48 | 2020-05-04 13:50:47 | NONE | null | null | null | When I call two methods to set state, only one ends up getting called. I know this could be fixed by using `useReducer`, but shouldn't this work as well.
React version:
```
"react-dom": "^16.13.0",
```
## Steps To Reproduce
I create a simple custom hook as below. Since on click calls `heperA()` **and*... | {'url': 'https://api.github.com/repos/facebook/react/issues/18812/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18812/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18811 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18811/labels{/name} | https://api.github.com/repos/facebook/react/issues/18811/comments | https://api.github.com/repos/facebook/react/issues/18811/events | https://github.com/facebook/react/pull/18811 | 611,555,881 | MDExOlB1bGxSZXF1ZXN0NDEyNzAxMTM3 | 18,811 | [Blocks Fixture] Misc updates | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18811/builds/24453) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-04 01:25:22 | 2020-05-05 10:53:05 | 2020-05-05 10:53:04 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18811', 'html_url': 'https://github.com/facebook/react/pull/18811', 'diff_url': 'https://github.com/facebook/react/pull/18811.diff', 'patch_url': 'https://github.com/facebook/react/pull/18811.patch', 'merged_at': datetime.datetime(2020, 5, 5, 10, 53, 4)} | * First commit makes the navbar respond to navigations immediately, before the next screen is ready. I think this is the idiomatic solution?
* Second commit adds more links so we can start playing with caching strategies. | {'url': 'https://api.github.com/repos/facebook/react/issues/18811/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18811/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18810 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18810/labels{/name} | https://api.github.com/repos/facebook/react/issues/18810/comments | https://api.github.com/repos/facebook/react/issues/18810/events | https://github.com/facebook/react/pull/18810 | 611,545,262 | MDExOlB1bGxSZXF1ZXN0NDEyNjkzMjYx | 18,810 | [Blocks] Fix stale data on updates | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18810/builds/24239) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-04 00:35:21 | 2020-05-04 00:43:56 | 2020-05-04 00:43:52 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18810', 'html_url': 'https://github.com/facebook/react/pull/18810', 'diff_url': 'https://github.com/facebook/react/pull/18810.diff', 'patch_url': 'https://github.com/facebook/react/pull/18810.patch', 'merged_at': datetime.datetime(2020, 5, 4, 0, 43, 52)} | Includes tests from https://github.com/facebook/react/pull/18809.
The last commit is the fix.
Blocks store data on type, so we need to copy it over when cloning WIP. That's the fix.
Verified https://github.com/facebook/react/pull/18803 works with it too. | {'url': 'https://api.github.com/repos/facebook/react/issues/18810/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18810/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18809 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18809/labels{/name} | https://api.github.com/repos/facebook/react/issues/18809/comments | https://api.github.com/repos/facebook/react/issues/18809/events | https://github.com/facebook/react/pull/18809 | 611,505,683 | MDExOlB1bGxSZXF1ZXN0NDEyNjY1Mzk5 | 18,809 | [Blocks] Failing test for nested load | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18809/builds/24236) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-03 20:55:42 | 2020-05-04 13:58:22 | 2020-05-04 13:58:22 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18809', 'html_url': 'https://github.com/facebook/react/pull/18809', 'diff_url': 'https://github.com/facebook/react/pull/18809.diff', 'patch_url': 'https://github.com/facebook/react/pull/18809.patch', 'merged_at': None} | Extracted from https://github.com/facebook/react/pull/18803. I think this is a bug.
The symptom is that we keep seeing the old screen after it unsuspends.
Hosting `<Suspense>` from `Parent` into `App` "fixes" it. | {'url': 'https://api.github.com/repos/facebook/react/issues/18809/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18809/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18808 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18808/labels{/name} | https://api.github.com/repos/facebook/react/issues/18808/comments | https://api.github.com/repos/facebook/react/issues/18808/events | https://github.com/facebook/react/pull/18808 | 611,470,158 | MDExOlB1bGxSZXF1ZXN0NDEyNjQxMDE0 | 18,808 | Rename Flight to Transport | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 93e078ddf274636b0a40bd5501ce3549aec700fa...914c377ee9efe834fcaa6c55806e9fdd542a3042</p>\n\n\n \n## react-transport-dom-... | 2020-05-03 17:58:56 | 2020-05-03 18:33:49 | 2020-05-03 18:33:49 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18808', 'html_url': 'https://github.com/facebook/react/pull/18808', 'diff_url': 'https://github.com/facebook/react/pull/18808.diff', 'patch_url': 'https://github.com/facebook/react/pull/18808.patch', 'merged_at': datetime.datetime(2020, 5, 3, 18, 33, 49)} | Flight is still the codename for the implementation details (like Fiber).
However, now the public package is react-transport-... which is only intended to be used directly by integrators into meta-frameworks.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18808/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18808/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18807 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18807/labels{/name} | https://api.github.com/repos/facebook/react/issues/18807/comments | https://api.github.com/repos/facebook/react/issues/18807/events | https://github.com/facebook/react/pull/18807 | 611,469,996 | MDExOlB1bGxSZXF1ZXN0NDEyNjQwOTEx | 18,807 | [Not to be landed] Allow stack to be prepared manually | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18807/builds/24200) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-03 17:58:07 | 2022-10-20 20:41:17 | 2022-10-20 20:41:17 | COLLABORATOR | null | true | {'url': 'https://api.github.com/repos/facebook/react/pulls/18807', 'html_url': 'https://github.com/facebook/react/pull/18807', 'diff_url': 'https://github.com/facebook/react/pull/18807.diff', 'patch_url': 'https://github.com/facebook/react/pull/18807.patch', 'merged_at': None} | I experimented with making it so that custom prepareStackTrace could be used with our stacks.
It didn't really pan out all that well because they need an Error object and sometimes prepend the error message etc. where as our stacks don't do that.
I'm also not sure it's worth the code because this is not cross-bro... | {'url': 'https://api.github.com/repos/facebook/react/issues/18807/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18807/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18806 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18806/labels{/name} | https://api.github.com/repos/facebook/react/issues/18806/comments | https://api.github.com/repos/facebook/react/issues/18806/events | https://github.com/facebook/react/pull/18806 | 611,312,599 | MDExOlB1bGxSZXF1ZXN0NDEyNTM0Nzk2 | 18,806 | fix: Error: Cannot read property 'duration' of undefined | {'login': 'Amine-H', 'id': 6276978, 'node_id': 'MDQ6VXNlcjYyNzY5Nzg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6276978?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Amine-H', 'html_url': 'https://github.com/Amine-H', 'followers_url': 'https://api.github.com/users/Amine-H/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18806/builds/24126) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-03 01:53:05 | 2020-05-07 22:31:55 | 2020-05-07 22:27:06 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18806', 'html_url': 'https://github.com/facebook/react/pull/18806', 'diff_url': 'https://github.com/facebook/react/pull/18806.diff', 'patch_url': 'https://github.com/facebook/react/pull/18806.patch', 'merged_at': None} | ## Summary
Fix for #18786 and #18798
Just a few things I should mention first, I am really new to the code base, ~not sure what was the intention to use the indexes from `commits` instead of `commitData`.
In other words if `commitData` has more commit than `commits` (interaction commits) then this PR would be sh... | {'url': 'https://api.github.com/repos/facebook/react/issues/18806/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18806/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18805 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18805/labels{/name} | https://api.github.com/repos/facebook/react/issues/18805/comments | https://api.github.com/repos/facebook/react/issues/18805/events | https://github.com/facebook/react/pull/18805 | 611,261,273 | MDExOlB1bGxSZXF1ZXN0NDEyNDk5NTI5 | 18,805 | Scheduler does not wait for resolving dehydrated pending boundaries | {'login': 'ferlores', 'id': 972699, 'node_id': 'MDQ6VXNlcjk3MjY5OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/972699?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ferlores', 'html_url': 'https://github.com/ferlores', 'followers_url': 'https://api.github.com/users/ferlores/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @ferlores! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beh... | 2020-05-02 19:48:12 | 2020-05-05 19:47:50 | 2020-05-05 19:47:50 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18805', 'html_url': 'https://github.com/facebook/react/pull/18805', 'diff_url': 'https://github.com/facebook/react/pull/18805.diff', 'patch_url': 'https://github.com/facebook/react/pull/18805.patch', 'merged_at': datetime.datetime(2020, 5, 5, 19, 47, 50)} | ## Summary
When hydrating if we [find](https://github.com/facebook/react/blob/914b57be27a8697d8ed83266466b30378af379f0/packages/react-reconciler/src/ReactFiberBeginWork.new.js#L2482) a dehydrated node in [pending state](https://github.com/facebook/react/blob/master/packages/react-dom/src/client/ReactDOMHostConfig.js... | {'url': 'https://api.github.com/repos/facebook/react/issues/18805/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18805/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18804 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18804/labels{/name} | https://api.github.com/repos/facebook/react/issues/18804/comments | https://api.github.com/repos/facebook/react/issues/18804/events | https://github.com/facebook/react/issues/18804 | 611,233,947 | MDU6SXNzdWU2MTEyMzM5NDc= | 18,804 | Error: "Could not find commit data for root "957" and commit 2" | {'login': 'rohanvachheta', 'id': 38291892, 'node_id': 'MDQ6VXNlcjM4MjkxODky', 'avatar_url': 'https://avatars.githubusercontent.com/u/38291892?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rohanvachheta', 'html_url': 'https://github.com/rohanvachheta', 'followers_url': 'https://api.github.com/users/rohan... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | {'login': 'rohanvachheta', 'id': 38291892.0, 'node_id': 'MDQ6VXNlcjM4MjkxODky', 'avatar_url': 'https://avatars.githubusercontent.com/u/38291892?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rohanvachheta', 'html_url': 'https://github.com/rohanvachheta', 'followers_url': 'https://api.github.com/users/roh... | [{'login': 'rohanvachheta', 'id': 38291892, 'node_id': 'MDQ6VXNlcjM4MjkxODky', 'avatar_url': 'https://avatars.githubusercontent.com/u/38291892?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rohanvachheta', 'html_url': 'https://github.com/rohanvachheta', 'followers_url': 'https://api.github.com/users/roha... | null | [
"It would be better if you provide more details on the question.",
"Hi @rohanvachheta!\r\n\r\nSorry about the inconvenience!\r\n\r\nThis looks like a duplicate of #18010 so I'm going to close it.\r\n\r\nIt's possible that PR #18862 fixes this issue, but that remains to be seen. If you can reproduce this issue, we... | 2020-05-02 17:13:34 | 2020-05-07 23:42:57 | 2020-05-07 23:41:47 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1.
2.
3.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.6.0-6cceaeb67
Call stack: at n.value (chrome-extension://fmkadmapgofadopljbjfkapdkoi... | {'url': 'https://api.github.com/repos/facebook/react/issues/18804/reactions', 'total_count': 2, '+1': 0, '-1': 2, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18804/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18803 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18803/labels{/name} | https://api.github.com/repos/facebook/react/issues/18803/comments | https://api.github.com/repos/facebook/react/issues/18803/events | https://github.com/facebook/react/pull/18803 | 611,087,673 | MDExOlB1bGxSZXF1ZXN0NDEyMzg1Mzk2 | 18,803 | [Blocks] Add Shell to Fixture | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18803/builds/24243) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-02 02:12:57 | 2020-05-04 00:59:56 | 2020-05-04 00:59:56 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18803', 'html_url': 'https://github.com/facebook/react/pull/18803', 'diff_url': 'https://github.com/facebook/react/pull/18803.diff', 'patch_url': 'https://github.com/facebook/react/pull/18803.patch', 'merged_at': datetime.datetime(2020, 5, 4, 0, 59, 56)} | This extends the fixture app a bit. Now it has two routes:
- Home (http://localhost:3000/)
- Profile (http://localhost:3000/profile)
On Home, we show Feed. A Feed consists of Posts with Comments.
On Profile, we show user name and Timeline. It also consists of Posts with Comments.
I started with this mostly... | {'url': 'https://api.github.com/repos/facebook/react/issues/18803/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18803/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18802 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18802/labels{/name} | https://api.github.com/repos/facebook/react/issues/18802/comments | https://api.github.com/repos/facebook/react/issues/18802/events | https://github.com/facebook/react/pull/18802 | 611,011,778 | MDExOlB1bGxSZXF1ZXN0NDEyMzI4NzYz | 18,802 | [DevTools] Improve HOC search UX | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18802/builds/23951) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-01 22:46:50 | 2020-05-15 17:37:35 | 2020-05-15 17:37:35 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18802', 'html_url': 'https://github.com/facebook/react/pull/18802', 'diff_url': 'https://github.com/facebook/react/pull/18802.diff', 'patch_url': 'https://github.com/facebook/react/pull/18802.patch', 'merged_at': datetime.datetime(2020, 5, 15, 17, 37, 35)} | close #16467
| {'url': 'https://api.github.com/repos/facebook/react/issues/18802/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18802/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18801 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18801/labels{/name} | https://api.github.com/repos/facebook/react/issues/18801/comments | https://api.github.com/repos/facebook/react/issues/18801/events | https://github.com/facebook/react/pull/18801 | 610,832,000 | MDExOlB1bGxSZXF1ZXN0NDEyMTkyOTk1 | 18,801 | Add changelog for eslint-plugin-react-hooks | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18801/builds/23884) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-01 16:12:21 | 2022-11-29 22:21:48 | 2020-05-01 16:12:33 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18801', 'html_url': 'https://github.com/facebook/react/pull/18801', 'diff_url': 'https://github.com/facebook/react/pull/18801.diff', 'patch_url': 'https://github.com/facebook/react/pull/18801.patch', 'merged_at': datetime.datetime(2020, 5, 1, 16, 12, 32)} | Fixes https://github.com/facebook/react/issues/18494 https://github.com/reactjs/reactjs.org/issues/2352 https://github.com/reactjs/reactjs.org/issues/2878
I'll cut 4.0 now. | {'url': 'https://api.github.com/repos/facebook/react/issues/18801/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18801/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18800 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18800/labels{/name} | https://api.github.com/repos/facebook/react/issues/18800/comments | https://api.github.com/repos/facebook/react/issues/18800/events | https://github.com/facebook/react/pull/18800 | 610,792,459 | MDExOlB1bGxSZXF1ZXN0NDEyMTYyNjE2 | 18,800 | Update bundle configs to not build some packages | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-stable;\n-->\n\n\n\nNo significant bundle size changes to report.\n\n## Size changes (stable)\n<p align=\"right\">\n Generated by :no_entry_sign: <a href=\"https://danger.systems/js\">dangerJS</a> against 0e00a842234f423bb881da1... | 2020-05-01 14:55:25 | 2020-05-27 20:50:43 | 2020-05-01 15:07:37 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18800', 'html_url': 'https://github.com/facebook/react/pull/18800', 'diff_url': 'https://github.com/facebook/react/pull/18800.diff', 'patch_url': 'https://github.com/facebook/react/pull/18800.patch', 'merged_at': datetime.datetime(2020, 5, 1, 15, 7, 37)} | Removes old ReactCache from FB builds. (D21349384 checks in a frozen copy.)
Also removes all bundles that are currently unused on WWW (including new cache) so we stop getting automatic codemod diffs trying to remove them. Let's add them back when we need them. | {'url': 'https://api.github.com/repos/facebook/react/issues/18800/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18800/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18799 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18799/labels{/name} | https://api.github.com/repos/facebook/react/issues/18799/comments | https://api.github.com/repos/facebook/react/issues/18799/events | https://github.com/facebook/react/pull/18799 | 610,782,702 | MDExOlB1bGxSZXF1ZXN0NDEyMTU1MTE4 | 18,799 | Modern Event System: improve dispatching queue | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18799/builds/24321) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-01 14:36:09 | 2020-05-04 15:55:49 | 2020-05-04 15:55:45 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18799', 'html_url': 'https://github.com/facebook/react/pull/18799', 'diff_url': 'https://github.com/facebook/react/pull/18799.diff', 'patch_url': 'https://github.com/facebook/react/pull/18799.patch', 'merged_at': datetime.datetime(2020, 5, 4, 15, 55, 45)} | One of the major pain points with how we deal with `SyntheticEvent` listener dispatching is how we allocate and store the three things we care about:
- the listener
- the instance
- the current target
We revised this a bit with the modern event system, but we still stuck each of these in an array on the event o... | {'url': 'https://api.github.com/repos/facebook/react/issues/18799/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18799/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18798 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18798/labels{/name} | https://api.github.com/repos/facebook/react/issues/18798/comments | https://api.github.com/repos/facebook/react/issues/18798/events | https://github.com/facebook/react/issues/18798 | 610,732,010 | MDU6SXNzdWU2MTA3MzIwMTA= | 18,798 | Error: "Cannot read property 'duration' of undefined" | {'login': 'shiftyp', 'id': 131928, 'node_id': 'MDQ6VXNlcjEzMTkyOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/131928?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shiftyp', 'html_url': 'https://github.com/shiftyp', 'followers_url': 'https://api.github.com/users/shiftyp/followers', 'follow... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Looks like duplicate of https://github.com/facebook/react/issues/18786 🤔 ",
"Here is a deployed repro case: https://react-example1.s3.amazonaws.com/index.html\r\n\r\nSteps:\r\n\r\n1. Load above URL\r\n2. Open React Profiler\r\n3. Start recording\r\n1. Hit the \"Fetch\" button a few times\r\n4. Stop Recording\r\... | 2020-05-01 12:41:08 | 2020-05-08 00:07:21 | 2020-05-08 00:07:21 | NONE | null | null | null | Describe what you were doing when the bug occurred:
1. Add interaction tracing with unstable_trace
2. Record a profile, navigate to Profiler > Profiled Interactions
3. Error appears when scrolling view or immediately
![Kapture 2020-05-01 at 8 37 44](https://user-images.githubusercontent.com/131928/80805899-3688c4... | {'url': 'https://api.github.com/repos/facebook/react/issues/18798/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18798/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18797 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18797/labels{/name} | https://api.github.com/repos/facebook/react/issues/18797/comments | https://api.github.com/repos/facebook/react/issues/18797/events | https://github.com/facebook/react/pull/18797 | 610,558,148 | MDExOlB1bGxSZXF1ZXN0NDExOTc2MDIw | 18,797 | Don't "schedule" discrete work if we're scheduling sync work | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18797/builds/23804) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-01 04:41:00 | 2020-05-01 15:43:16 | 2020-05-01 15:43:16 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18797', 'html_url': 'https://github.com/facebook/react/pull/18797', 'diff_url': 'https://github.com/facebook/react/pull/18797.diff', 'patch_url': 'https://github.com/facebook/react/pull/18797.patch', 'merged_at': datetime.datetime(2020, 5, 1, 15, 43, 16)} | _This is an alternative fix to #18792. This is a convoluted bug. Settle in._
The problem is that we're adding discrete work during an unmount:
https://github.com/facebook/react/blob/master/packages/react-reconciler/src/ReactFiberWorkLoop.old.js#L463-L480
Normally this is fine because once we complete the unmou... | {'url': 'https://api.github.com/repos/facebook/react/issues/18797/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18797/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18796 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18796/labels{/name} | https://api.github.com/repos/facebook/react/issues/18796/comments | https://api.github.com/repos/facebook/react/issues/18796/events | https://github.com/facebook/react/pull/18796 | 610,522,845 | MDExOlB1bGxSZXF1ZXN0NDExOTQ3Njk3 | 18,796 | Initial Lanes implementation | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18796/builds/24119) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-05-01 02:42:19 | 2021-07-20 02:18:33 | 2020-05-03 00:09:32 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18796', 'html_url': 'https://github.com/facebook/react/pull/18796', 'diff_url': 'https://github.com/facebook/react/pull/18796.diff', 'patch_url': 'https://github.com/facebook/react/pull/18796.patch', 'merged_at': datetime.datetime(2020, 5, 3, 0, 9, 32)} | *This is ready for review. I'm going to do another pass to add comments and look for anything unusual I may have missed, but overall I'm happy with its current state*.
All of the changes I've made in this PR are behind the `enableNewReconciler` flag. Merging this to master will not affect the open source builds or t... | {'url': 'https://api.github.com/repos/facebook/react/issues/18796/reactions', 'total_count': 123, '+1': 35, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 31, 'rocket': 29, 'eyes': 28} | https://api.github.com/repos/facebook/react/issues/18796/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18795 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18795/labels{/name} | https://api.github.com/repos/facebook/react/issues/18795/comments | https://api.github.com/repos/facebook/react/issues/18795/events | https://github.com/facebook/react/issues/18795 | 610,457,906 | MDU6SXNzdWU2MTA0NTc5MDY= | 18,795 | Bug: Fetch API not working correctly when using ReadableStream | {'login': 'DonHaul', 'id': 13081142, 'node_id': 'MDQ6VXNlcjEzMDgxMTQy', 'avatar_url': 'https://avatars.githubusercontent.com/u/13081142?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/DonHaul', 'html_url': 'https://github.com/DonHaul', 'followers_url': 'https://api.github.com/users/DonHaul/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This has nothing to do with React",
"@vkurchatkin Why do you say that?",
"Can you help me figure out why you think React is related to this problem? Have you tried removing React from the equation?",
"The problematic code is within `useEffect`. React just runs it and doesn't affect in any other way. You don'... | 2020-04-30 23:34:01 | 2020-05-01 14:29:00 | 2020-05-01 14:29:00 | NONE | null | null | null | While building a react app, where the front-end must constantly receive streaming data, I noticed that each stream chunk, is only technically received, after the whole stream data is transmitted, although I can chrome network tab that is being received in several chunks. This issue occurs during development, but after ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18795/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18795/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18794 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18794/labels{/name} | https://api.github.com/repos/facebook/react/issues/18794/comments | https://api.github.com/repos/facebook/react/issues/18794/events | https://github.com/facebook/react/pull/18794 | 610,454,545 | MDExOlB1bGxSZXF1ZXN0NDExODkyMjk2 | 18,794 | [react-refresh/babel] Always insert registrations after var | {'login': 'sophiebits', 'id': 6820, 'node_id': 'MDQ6VXNlcjY4MjA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6820?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sophiebits', 'html_url': 'https://github.com/sophiebits', 'followers_url': 'https://api.github.com/users/sophiebits/followers', 'fo... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18794/builds/23792) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-30 23:25:53 | 2020-05-01 15:01:12 | 2020-05-01 15:01:12 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18794', 'html_url': 'https://github.com/facebook/react/pull/18794', 'diff_url': 'https://github.com/facebook/react/pull/18794.diff', 'patch_url': 'https://github.com/facebook/react/pull/18794.patch', 'merged_at': datetime.datetime(2020, 5, 1, 15, 1, 12)} | Previously, we transformed
```
let Foo = styled.div``;
```
to
```
let Foo = _c1 = styled.div``;
```
and then babel-plugin-styled-components would infer `_c1` as the display name. Widen the existing case that applies to function expressions to apply to any type of variable declaration.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18794/reactions', 'total_count': 1, '+1': 1, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18794/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18793 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18793/labels{/name} | https://api.github.com/repos/facebook/react/issues/18793/comments | https://api.github.com/repos/facebook/react/issues/18793/events | https://github.com/facebook/react/issues/18793 | 610,300,161 | MDU6SXNzdWU2MTAzMDAxNjE= | 18,793 | Bug: Unable to run command npm start | {'login': 'ghost', 'id': 10137, 'node_id': 'MDQ6VXNlcjEwMTM3', 'avatar_url': 'https://avatars.githubusercontent.com/u/10137?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ghost', 'html_url': 'https://github.com/ghost', 'followers_url': 'https://api.github.com/users/ghost/followers', 'following_url': 'htt... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Here's something that may help: https://github.com/guard/listen/wiki/Increasing-the-amount-of-inotify-watchers",
"> Here's something that may help: https://github.com/guard/listen/wiki/Increasing-the-amount-of-inotify-watchers\r\n\r\nyeah it works, thanks a lot dude "
] | 2020-04-30 18:37:51 | 2020-05-01 18:28:28 | 2020-05-01 18:28:28 | NONE | null | null | null | <!--
i'm using the `npx create-react-app` to start my project, the problem comes up when i get into the folder and try to run the npm start command
-->
## Steps To Reproduce
1.run `npx create-react-app`
2.cd `project-folder`
3.npm start
## The current behavior
`Starting the development server...
events... | {'url': 'https://api.github.com/repos/facebook/react/issues/18793/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18793/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18792 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18792/labels{/name} | https://api.github.com/repos/facebook/react/issues/18792/comments | https://api.github.com/repos/facebook/react/issues/18792/events | https://github.com/facebook/react/pull/18792 | 610,283,870 | MDExOlB1bGxSZXF1ZXN0NDExNzUzODA3 | 18,792 | Prevent stale legacy root from clearing a container (DRAFT) | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18792/builds/23764) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-30 18:10:16 | 2020-05-01 00:35:40 | 2020-04-30 22:56:22 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18792', 'html_url': 'https://github.com/facebook/react/pull/18792', 'diff_url': 'https://github.com/facebook/react/pull/18792.diff', 'patch_url': 'https://github.com/facebook/react/pull/18792.patch', 'merged_at': datetime.datetime(2020, 4, 30, 22, 56, 22)} | Fixes the legacy root bug we observed after the recent sync (caused by #18730).
Alternate fix to #18781. | {'url': 'https://api.github.com/repos/facebook/react/issues/18792/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18792/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18791 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18791/labels{/name} | https://api.github.com/repos/facebook/react/issues/18791/comments | https://api.github.com/repos/facebook/react/issues/18791/events | https://github.com/facebook/react/issues/18791 | 610,261,474 | MDU6SXNzdWU2MTAyNjE0NzQ= | 18,791 | Bug: render multiple portals to same element additive behavior | {'login': 'idoros', 'id': 574751, 'node_id': 'MDQ6VXNlcjU3NDc1MQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/574751?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/idoros', 'html_url': 'https://github.com/idoros', 'followers_url': 'https://api.github.com/users/idoros/followers', 'following_... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-04-30 17:34:30 | 2024-04-07 18:53:10 | 2020-08-08 07:41:39 | NONE | null | null | null | For every use of `ReactDOM.createPortal()` in a unique VDOM position the content is rendered adding to the portal element without clearing it.
React version: 16.12.0
## Steps To Reproduce
1. create a dom element to render a portal into
2. use `ReactDOM.createPortal` more then once from different positions (or... | {'url': 'https://api.github.com/repos/facebook/react/issues/18791/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18791/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18790 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18790/labels{/name} | https://api.github.com/repos/facebook/react/issues/18790/comments | https://api.github.com/repos/facebook/react/issues/18790/events | https://github.com/facebook/react/issues/18790 | 610,206,261 | MDU6SXNzdWU2MTAyMDYyNjE= | 18,790 | Memory Leak - React DOM keeps references to stale child components when using the Container/Pure component pattern | {'login': 'jzworkman', 'id': 7489458, 'node_id': 'MDQ6VXNlcjc0ODk0NTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7489458?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jzworkman', 'html_url': 'https://github.com/jzworkman', 'followers_url': 'https://api.github.com/users/jzworkman/followers... | [] | closed | false | null | [] | null | [
"I’m seeing similar issue but using Hooks / useState and functional components. We have an infinite scroll and a buffer window. After the buffer is full, old components are removed and new ones added, with the size of the buffer being all that should exist in memory at any one time. But memory just keeps rising. Th... | 2020-04-30 16:16:52 | 2022-03-30 00:39:55 | 2022-03-30 00:39:55 | NONE | null | null | null | **Do you want to request a feature or report a bug?**
Report a bug.
**What is the current behavior?**
ReactDOM keeps references to previous states/props/children when component gets updated. All in all consuming three times as much memory as it really needed.
We are seeing this as a significant issue when using... | {'url': 'https://api.github.com/repos/facebook/react/issues/18790/reactions', 'total_count': 25, '+1': 24, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18790/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18789 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18789/labels{/name} | https://api.github.com/repos/facebook/react/issues/18789/comments | https://api.github.com/repos/facebook/react/issues/18789/events | https://github.com/facebook/react/pull/18789 | 610,128,735 | MDExOlB1bGxSZXF1ZXN0NDExNjE5NzQ1 | 18,789 | [Blocks] Cancellation | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18789/builds/23704) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-30 15:15:38 | 2021-02-11 16:33:54 | 2021-02-11 16:33:54 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18789', 'html_url': 'https://github.com/facebook/react/pull/18789', 'diff_url': 'https://github.com/facebook/react/pull/18789.diff', 'patch_url': 'https://github.com/facebook/react/pull/18789.patch', 'merged_at': None} | This is just the initial wiring. I don't know if it actually makes sense yet. I don't understand *where* and *when* we should cancel. My first naïve approach was to cancel in the reducer, but that doesn't work because I can't read from the same cache anymore. So I think I'm missing something in how this relates to Here... | {'url': 'https://api.github.com/repos/facebook/react/issues/18789/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18789/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18788 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18788/labels{/name} | https://api.github.com/repos/facebook/react/issues/18788/comments | https://api.github.com/repos/facebook/react/issues/18788/events | https://github.com/facebook/react/issues/18788 | 609,824,122 | MDU6SXNzdWU2MDk4MjQxMjI= | 18,788 | React developers tools extension icon | {'login': 'ackvf', 'id': 2313018, 'node_id': 'MDQ6VXNlcjIzMTMwMTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/2313018?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ackvf', 'html_url': 'https://github.com/ackvf', 'followers_url': 'https://api.github.com/users/ackvf/followers', 'following_ur... | [] | closed | false | null | [] | null | [
"The icon's contrast is important. Light blue on dark gray looks good, so your screenshot looks good. But if the operating system (or browser) weren't in dark mode, it would be light blue on light gray, which would not look good.\r\n\r\nThis icon needs to look good across Chrome+Firefox+Edge on Windows and Mac, wit... | 2020-04-30 10:59:05 | 2020-05-19 23:29:09 | 2020-05-01 22:09:09 | NONE | null | null | null | Can you change the boxed logo for a transparent icon? It would look better in the Extension bar
left React Developer Tools, right react-detector
| {'url': 'https://api.github.com/repos/facebook/react/issues/18788/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18788/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18787 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18787/labels{/name} | https://api.github.com/repos/facebook/react/issues/18787/comments | https://api.github.com/repos/facebook/react/issues/18787/events | https://github.com/facebook/react/issues/18787 | 609,653,239 | MDU6SXNzdWU2MDk2NTMyMzk= | 18,787 | not able to get react tab at the inspect option | {'login': 'shrushtivjagtap', 'id': 58544603, 'node_id': 'MDQ6VXNlcjU4NTQ0NjAz', 'avatar_url': 'https://avatars.githubusercontent.com/u/58544603?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/shrushtivjagtap', 'html_url': 'https://github.com/shrushtivjagtap', 'followers_url': 'https://api.github.com/users... | [] | closed | false | null | [] | null | [
"This issue doesn't have any of the required info, so I'm closing it. If you'd like to fill in the missing info we can reopen it!"
] | 2020-04-30 07:09:48 | 2020-05-01 22:07:06 | 2020-05-01 22:06:41 | NONE | null | null | null | 👉 Please follow one of these issue templates:
- https://github.com/facebook/react/issues/new/choose
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18787/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18787/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18786 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18786/labels{/name} | https://api.github.com/repos/facebook/react/issues/18786/comments | https://api.github.com/repos/facebook/react/issues/18786/events | https://github.com/facebook/react/issues/18786 | 609,476,681 | MDU6SXNzdWU2MDk0NzY2ODE= | 18,786 | Error: "Cannot read property 'duration' of undefined" | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/react/l... | closed | false | null | [] | null | [
"Possible duplicate of #18798.",
"I can work on this issue.",
"Fixed via #18862 "
] | 2020-04-30 00:58:44 | 2020-05-19 21:14:11 | 2020-05-19 21:14:11 | COLLABORATOR | null | null | null | Describe what you were doing when the bug occurred:
Profiled the new FB. Scrolled down to tail loads.
---------------------------------------------
Please do not remove the text below this line
---------------------------------------------
DevTools version: 4.6.0-a2fb84beb
Call stack: at chrome-extension:... | {'url': 'https://api.github.com/repos/facebook/react/issues/18786/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18786/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18785 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18785/labels{/name} | https://api.github.com/repos/facebook/react/issues/18785/comments | https://api.github.com/repos/facebook/react/issues/18785/events | https://github.com/facebook/react/pull/18785 | 609,474,564 | MDExOlB1bGxSZXF1ZXN0NDExMDQ3Nzc1 | 18,785 | [Blocks] Add preload to fetch | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18785/builds/23529) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-30 00:54:00 | 2020-04-30 01:49:23 | 2020-04-30 01:23:19 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18785', 'html_url': 'https://github.com/facebook/react/pull/18785', 'diff_url': 'https://github.com/facebook/react/pull/18785.diff', 'patch_url': 'https://github.com/facebook/react/pull/18785.patch', 'merged_at': datetime.datetime(2020, 4, 30, 1, 23, 19)} | Like fetch, but doesn't suspend. | {'url': 'https://api.github.com/repos/facebook/react/issues/18785/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18785/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18784 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18784/labels{/name} | https://api.github.com/repos/facebook/react/issues/18784/comments | https://api.github.com/repos/facebook/react/issues/18784/events | https://github.com/facebook/react/pull/18784 | 609,386,751 | MDExOlB1bGxSZXF1ZXN0NDEwOTc1MTM5 | 18,784 | [Blocks] Use native fetch | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"\n<!--\n 0 failure: \n 0 warning: \n \n 2 markdown notices\n DangerID: danger-id-experimental;\n-->\n\n\n\n\n <details>\n <summary>Details of bundled changes.</summary>\n\n <p>Comparing: 515326753b15eb247493b1b5c657eee1bc515337...d9db3a5c1a3794bee47c09e03d6e14cccacd54e8</p>\n\n\n \n## react-data\nFile | F... | 2020-04-29 21:57:23 | 2020-04-30 00:24:13 | 2020-04-30 00:24:05 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18784', 'html_url': 'https://github.com/facebook/react/pull/18784', 'diff_url': 'https://github.com/facebook/react/pull/18784.diff', 'patch_url': 'https://github.com/facebook/react/pull/18784.patch', 'merged_at': datetime.datetime(2020, 4, 30, 0, 24, 5)} | Follow-up to https://github.com/facebook/react/pull/18774.
Rewrites from XHR to just using native fetch.
- Fetch now returns a Response object, a thin wrapper over native Response.
- New Response methods: `arrayBuffer()`, `blob()`, `text()`, `json()`.
- I didn't add `formData()` because I'm not sure why it's us... | {'url': 'https://api.github.com/repos/facebook/react/issues/18784/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18784/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18783 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18783/labels{/name} | https://api.github.com/repos/facebook/react/issues/18783/comments | https://api.github.com/repos/facebook/react/issues/18783/events | https://github.com/facebook/react/pull/18783 | 609,348,241 | MDExOlB1bGxSZXF1ZXN0NDEwOTQ0NDUy | 18,783 | Consistent useCallback implementation in ReactDOMServer | {'login': 'alexmckenley', 'id': 3639670, 'node_id': 'MDQ6VXNlcjM2Mzk2NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3639670?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/alexmckenley', 'html_url': 'https://github.com/alexmckenley', 'followers_url': 'https://api.github.com/users/alexmckenl... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18783/builds/23468) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-29 20:46:16 | 2020-04-29 23:22:11 | 2020-04-29 23:22:11 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18783', 'html_url': 'https://github.com/facebook/react/pull/18783', 'diff_url': 'https://github.com/facebook/react/pull/18783.diff', 'patch_url': 'https://github.com/facebook/react/pull/18783.patch', 'merged_at': datetime.datetime(2020, 4, 29, 23, 22, 11)} | ## Summary
In ReactDOMServer we implement both useMemo and useCallback. The React docs mention that `useCallback(fn, deps)` is equivalent to `useMemo(() => fn, deps)`, however this is not true today as useCallback completely ignores the deps argument.
Although the docs also mention that there are not semantic guara... | {'url': 'https://api.github.com/repos/facebook/react/issues/18783/reactions', 'total_count': 3, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 3, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18783/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18782 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18782/labels{/name} | https://api.github.com/repos/facebook/react/issues/18782/comments | https://api.github.com/repos/facebook/react/issues/18782/events | https://github.com/facebook/react/pull/18782 | 609,332,011 | MDExOlB1bGxSZXF1ZXN0NDEwOTMxNTYy | 18,782 | Move legacy hidden API to new internal Fiber type | {'login': 'acdlite', 'id': 3624098, 'node_id': 'MDQ6VXNlcjM2MjQwOTg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/3624098?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/acdlite', 'html_url': 'https://github.com/acdlite', 'followers_url': 'https://api.github.com/users/acdlite/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18782/builds/23784) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-29 20:19:43 | 2020-05-01 02:37:29 | 2020-05-01 02:37:28 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18782', 'html_url': 'https://github.com/facebook/react/pull/18782', 'diff_url': 'https://github.com/facebook/react/pull/18782.diff', 'patch_url': 'https://github.com/facebook/react/pull/18782.patch', 'merged_at': datetime.datetime(2020, 5, 1, 2, 37, 28)} | ## Based on #18733
[**Diff compared to previous PR in stack**](https://github.com/acdlite/react/compare/unhide-suspense-trees-without...legacy-hidden)
Adds a new LegacyHidden fiber type.
This only exists so we can clean up the internal implementation of `<div hidden={isHidden} />`, which is not a stable featu... | {'url': 'https://api.github.com/repos/facebook/react/issues/18782/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18782/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18781 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18781/labels{/name} | https://api.github.com/repos/facebook/react/issues/18781/comments | https://api.github.com/repos/facebook/react/issues/18781/events | https://github.com/facebook/react/pull/18781 | 609,283,326 | MDExOlB1bGxSZXF1ZXN0NDEwODkyODE2 | 18,781 | Handle legacy root contains in clearContainer | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18781/builds/23508) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-29 18:57:07 | 2020-04-30 22:22:57 | 2020-04-30 22:22:57 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18781', 'html_url': 'https://github.com/facebook/react/pull/18781', 'diff_url': 'https://github.com/facebook/react/pull/18781.diff', 'patch_url': 'https://github.com/facebook/react/pull/18781.patch', 'merged_at': None} | When debugging an internal issue, I noticed that we have an issue where we clear down a root that has existing content. This particular fix checks in `clearContainer` if the container we're trying to clear has a legacy container and if it does, checks to see if it matches the root we expected. | {'url': 'https://api.github.com/repos/facebook/react/issues/18781/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18781/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18780 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18780/labels{/name} | https://api.github.com/repos/facebook/react/issues/18780/comments | https://api.github.com/repos/facebook/react/issues/18780/events | https://github.com/facebook/react/issues/18780 | 609,225,712 | MDU6SXNzdWU2MDkyMjU3MTI= | 18,780 | Saving an unrendered functional component to state throws "Error: Should have a queue" or "Rendered more hooks than during the previous render." | {'login': 'rexthefex', 'id': 6279203, 'node_id': 'MDQ6VXNlcjYyNzkyMDM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/6279203?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/rexthefex', 'html_url': 'https://github.com/rexthefex', 'followers_url': 'https://api.github.com/users/rexthefex/followers... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"If you put a function into state, you need to add `() =>` both in `useState` and `setState` calls because otherwise React thinks you're using a lazy state initializer. This is an unfortunate consequence of function overloading.\r\n\r\nYour code example is empty but I assume you need something like\r\n\r\n```js\r\n... | 2020-04-29 17:22:44 | 2020-04-29 17:31:12 | 2020-04-29 17:31:11 | NONE | null | null | null | React version: 16.13.1
## Steps To Reproduce
1. Create a component with hooks. Let's call it `Component` for brevity.
2. Save it to the state on the main functional component without creating it: `setState(Component)`.
Note that it is not `setState(<Component />)`
3. App crashes with either "Error: Should have... | {'url': 'https://api.github.com/repos/facebook/react/issues/18780/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18780/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18779 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18779/labels{/name} | https://api.github.com/repos/facebook/react/issues/18779/comments | https://api.github.com/repos/facebook/react/issues/18779/events | https://github.com/facebook/react/issues/18779 | 609,215,096 | MDU6SXNzdWU2MDkyMTUwOTY= | 18,779 | Bug: Radio buttons do not get checked with an array of inputs | {'login': 'vamcs', 'id': 18034802, 'node_id': 'MDQ6VXNlcjE4MDM0ODAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/18034802?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vamcs', 'html_url': 'https://github.com/vamcs', 'followers_url': 'https://api.github.com/users/vamcs/followers', 'following_... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hello. The problem is not with React. Your current method returns \"on\"\r\n\r\n\r\nYou are passing a method from the main component which you are overriding after that with ano... | 2020-04-29 17:05:15 | 2020-04-30 04:06:59 | 2020-04-30 04:06:15 | NONE | null | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
React version: 16.13.0
## Steps To Reproduce
1. Example below illustrates ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18779/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18779/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18778 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18778/labels{/name} | https://api.github.com/repos/facebook/react/issues/18778/comments | https://api.github.com/repos/facebook/react/issues/18778/events | https://github.com/facebook/react/pull/18778 | 609,064,045 | MDExOlB1bGxSZXF1ZXN0NDEwNzE4Mzk5 | 18,778 | Refine experimental Scopes API | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18778/builds/23716) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-29 13:36:11 | 2020-05-01 18:01:44 | 2020-05-01 18:01:44 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18778', 'html_url': 'https://github.com/facebook/react/pull/18778', 'diff_url': 'https://github.com/facebook/react/pull/18778.diff', 'patch_url': 'https://github.com/facebook/react/pull/18778.patch', 'merged_at': datetime.datetime(2020, 5, 1, 18, 1, 44)} | This PR cleans up some of the types around the experimental Scopes API and simplies the data structure around how they're created. The main goal here is to cleanup the API for integration with `createEventHandle`.
With this PR, rather than create a `ScopeMethods` object, we create only a `ScopeInstance` object, whic... | {'url': 'https://api.github.com/repos/facebook/react/issues/18778/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18778/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18777 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18777/labels{/name} | https://api.github.com/repos/facebook/react/issues/18777/comments | https://api.github.com/repos/facebook/react/issues/18777/events | https://github.com/facebook/react/issues/18777 | 608,964,695 | MDU6SXNzdWU2MDg5NjQ2OTU= | 18,777 | Bug: Stop browser hanging on Maximum update depth exceeded | {'login': 'laclance', 'id': 10835285, 'node_id': 'MDQ6VXNlcjEwODM1Mjg1', 'avatar_url': 'https://avatars.githubusercontent.com/u/10835285?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/laclance', 'html_url': 'https://github.com/laclance', 'followers_url': 'https://api.github.com/users/laclance/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"This issue has been automatically marked as stale. **If this issue is still affecting you, please leave any comment** (for example, \"bump\"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!\n",
... | 2020-04-29 11:01:30 | 2022-03-30 00:40:17 | 2022-03-30 00:40:17 | NONE | null | null | null | React version: 16.13.1
OS: Windows 10
Browser: Google chrome 81.0.4044.122
Whenever I incorrectly use useEffect hook and get the Maximum update depth exceeded error the chrome tab hangs and I have to force close using task manager and reopen chrome again in order to close the tab. This makes debugging the cause ve... | {'url': 'https://api.github.com/repos/facebook/react/issues/18777/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18777/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18776 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18776/labels{/name} | https://api.github.com/repos/facebook/react/issues/18776/comments | https://api.github.com/repos/facebook/react/issues/18776/events | https://github.com/facebook/react/pull/18776 | 608,774,511 | MDExOlB1bGxSZXF1ZXN0NDEwNDg2Mzk4 | 18,776 | Create README-TAMIL.md | {'login': 'Katheesh', 'id': 33308414, 'node_id': 'MDQ6VXNlcjMzMzA4NDE0', 'avatar_url': 'https://avatars.githubusercontent.com/u/33308414?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Katheesh', 'html_url': 'https://github.com/Katheesh', 'followers_url': 'https://api.github.com/users/Katheesh/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"Hi @Katheesh! \n\nThank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.\n\nIn order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on beh... | 2020-04-29 04:46:43 | 2020-05-01 00:38:10 | 2020-05-01 00:38:09 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18776', 'html_url': 'https://github.com/facebook/react/pull/18776', 'diff_url': 'https://github.com/facebook/react/pull/18776.diff', 'patch_url': 'https://github.com/facebook/react/pull/18776.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18776/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18776/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18775 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18775/labels{/name} | https://api.github.com/repos/facebook/react/issues/18775/comments | https://api.github.com/repos/facebook/react/issues/18775/events | https://github.com/facebook/react/issues/18775 | 608,741,211 | MDU6SXNzdWU2MDg3NDEyMTE= | 18,775 | Bug: list component when key exists, there will be cache item component | {'login': 'beilo', 'id': 19225489, 'node_id': 'MDQ6VXNlcjE5MjI1NDg5', 'avatar_url': 'https://avatars.githubusercontent.com/u/19225489?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/beilo', 'html_url': 'https://github.com/beilo', 'followers_url': 'https://api.github.com/users/beilo/followers', 'following_... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"1. init\r\n\r\n2. show serData\r\n\r\n3. check serData in wqre111 return myData\r\n![image](htt... | 2020-04-29 02:51:15 | 2020-08-08 07:41:40 | 2020-08-08 07:41:40 | NONE | null | null | null | React version:
```
"react": "^16.5.2",
"react-dom": "^16.5.2",
"mobx": "^5.9.0",
"mobx-react": "^5.4.3",
```
## Steps To Reproduce
The premise is as follows:
I use 'mobx' as state control.
I have 2 states, ` mydata = [] `, `serData = [{XXX}]`, serData.length = 20.
I have a `mode; / / local or disp... | {'url': 'https://api.github.com/repos/facebook/react/issues/18775/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18775/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18774 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18774/labels{/name} | https://api.github.com/repos/facebook/react/issues/18774/comments | https://api.github.com/repos/facebook/react/issues/18774/events | https://github.com/facebook/react/pull/18774 | 608,740,721 | MDExOlB1bGxSZXF1ZXN0NDEwNDU5Nzc0 | 18,774 | [Blocks] Initial implementation of cache and data/fetch | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18774/builds/23426) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-29 02:49:21 | 2020-07-07 04:24:04 | 2020-04-29 18:14:16 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18774', 'html_url': 'https://github.com/facebook/react/pull/18774', 'diff_url': 'https://github.com/facebook/react/pull/18774.diff', 'patch_url': 'https://github.com/facebook/react/pull/18774.patch', 'merged_at': datetime.datetime(2020, 4, 29, 18, 14, 16)} | This adds a few entry points (names might change):
- `react/unstable-cache` (isomorphic context for coordination)
- `react-data` (`createResource` will live here, not used yet)
- `react-data/fetch` (a rudimentary data provider for `fetch`)
The APIs will likely change a lot, this is just initial wiring.
I haven... | {'url': 'https://api.github.com/repos/facebook/react/issues/18774/reactions', 'total_count': 4, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 4} | https://api.github.com/repos/facebook/react/issues/18774/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18773 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18773/labels{/name} | https://api.github.com/repos/facebook/react/issues/18773/comments | https://api.github.com/repos/facebook/react/issues/18773/events | https://github.com/facebook/react/pull/18773 | 608,709,546 | MDExOlB1bGxSZXF1ZXN0NDEwNDM1ODEy | 18,773 | [Blocks] Add Client Fixture | {'login': 'gaearon', 'id': 810438, 'node_id': 'MDQ6VXNlcjgxMDQzOA==', 'avatar_url': 'https://avatars.githubusercontent.com/u/810438?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/gaearon', 'html_url': 'https://github.com/gaearon', 'followers_url': 'https://api.github.com/users/gaearon/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18773/builds/23169) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-29 01:06:44 | 2020-05-01 22:36:39 | 2020-04-29 01:23:10 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18773', 'html_url': 'https://github.com/facebook/react/pull/18773', 'diff_url': 'https://github.com/facebook/react/pull/18773.diff', 'patch_url': 'https://github.com/facebook/react/pull/18773.patch', 'merged_at': datetime.datetime(2020, 4, 29, 1, 23, 10)} | This is not very interesting by itself.
Just adds a client-only fixture that we can play with to start extracting the pieces that need to be librarified, like `react/cache` or `react-data/fetch` (all names temporary).
| {'url': 'https://api.github.com/repos/facebook/react/issues/18773/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18773/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18772 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18772/labels{/name} | https://api.github.com/repos/facebook/react/issues/18772/comments | https://api.github.com/repos/facebook/react/issues/18772/events | https://github.com/facebook/react/pull/18772 | 608,652,212 | MDExOlB1bGxSZXF1ZXN0NDEwMzkwODI5 | 18,772 | [DevTools] enable Electron interactions on Linux & auto copy script tags | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18772/builds/27370) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-28 22:19:34 | 2020-05-18 17:27:41 | 2020-05-18 17:27:40 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18772', 'html_url': 'https://github.com/facebook/react/pull/18772', 'diff_url': 'https://github.com/facebook/react/pull/18772.diff', 'patch_url': 'https://github.com/facebook/react/pull/18772.patch', 'merged_at': datetime.datetime(2020, 5, 18, 17, 27, 40)} | When `react-devtools` is runned on Linux, the user cannot interact with Electron window. Also it may be convenient to have button to copy script tag immediately instead of manually copying it.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18772/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18772/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18771 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18771/labels{/name} | https://api.github.com/repos/facebook/react/issues/18771/comments | https://api.github.com/repos/facebook/react/issues/18771/events | https://github.com/facebook/react/pull/18771 | 608,590,037 | MDExOlB1bGxSZXF1ZXN0NDEwMzQwMzc1 | 18,771 | useMutableSource hydration support | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18771/builds/27442) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-28 20:21:23 | 2020-05-21 23:00:51 | 2020-05-21 23:00:47 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18771', 'html_url': 'https://github.com/facebook/react/pull/18771', 'diff_url': 'https://github.com/facebook/react/pull/18771.diff', 'patch_url': 'https://github.com/facebook/react/pull/18771.patch', 'merged_at': datetime.datetime(2020, 5, 21, 23, 0, 47)} | Add hydration support for `useMutableSource` (resolves #18183)
### [View diff without white space.](https://github.com/facebook/react/pull/18771/files?w=1)
## Usage example
```js
// 1. Render app on the server...
// 2. Create root for hydration. and pre-register all mutable sources.
// This eagerly records ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18771/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18771/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18770 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18770/labels{/name} | https://api.github.com/repos/facebook/react/issues/18770/comments | https://api.github.com/repos/facebook/react/issues/18770/events | https://github.com/facebook/react/pull/18770 | 608,496,654 | MDExOlB1bGxSZXF1ZXN0NDEwMjY0NDA1 | 18,770 | Refine ReactDOM "Container" type | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18770/builds/23083) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-28 17:41:34 | 2020-04-28 17:56:06 | 2020-04-28 17:56:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18770', 'html_url': 'https://github.com/facebook/react/pull/18770', 'diff_url': 'https://github.com/facebook/react/pull/18770.diff', 'patch_url': 'https://github.com/facebook/react/pull/18770.patch', 'merged_at': None} | The `Container` is never a `document` (anymore at least), so let's refine the type better. | {'url': 'https://api.github.com/repos/facebook/react/issues/18770/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18770/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18769 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18769/labels{/name} | https://api.github.com/repos/facebook/react/issues/18769/comments | https://api.github.com/repos/facebook/react/issues/18769/events | https://github.com/facebook/react/issues/18769 | 608,454,207 | MDU6SXNzdWU2MDg0NTQyMDc= | 18,769 | Bug: rules-of-hooks should support hooks inside top-level IIFEs | {'login': 'fabiospampinato', 'id': 1812093, 'node_id': 'MDQ6VXNlcjE4MTIwOTM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1812093?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/fabiospampinato', 'html_url': 'https://github.com/fabiospampinato', 'followers_url': 'https://api.github.com/users/f... | [] | closed | false | null | [] | null | [
"This pattern seems rather pointless. Why would you do that?",
"@vkramskikh Correctness-wise I don't think it matters why I do it, and I'd argue one should strive for correctness.\r\n\r\nIn my specific case I did that because I was wrapping all props and state in refs to be passed to an object that could mutate t... | 2020-04-28 16:32:06 | 2021-07-29 10:37:43 | 2020-07-27 14:53:43 | NONE | null | null | null | React version: **v16.13.1**
eslint-plugin-react-hooks version: **v3.0.0**
## Steps To Reproduce
1. Write something like this:
```js
const Component = () => {
(() => {
useState ();
})()
};
```
2. Run the `rules-of-hooks` linter rules on it.
## The current behavior
Those linter rules will... | {'url': 'https://api.github.com/repos/facebook/react/issues/18769/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18769/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18768 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18768/labels{/name} | https://api.github.com/repos/facebook/react/issues/18768/comments | https://api.github.com/repos/facebook/react/issues/18768/events | https://github.com/facebook/react/issues/18768 | 608,397,761 | MDU6SXNzdWU2MDgzOTc3NjE= | 18,768 | Bug: `React.lazy` throws undefined instead of an `Error` object | {'login': 'mischnic', 'id': 4586894, 'node_id': 'MDQ6VXNlcjQ1ODY4OTQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/4586894?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mischnic', 'html_url': 'https://github.com/mischnic', 'followers_url': 'https://api.github.com/users/mischnic/followers', '... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"~I did some refactoring for lazy in master. Looking at one of the more recent builds, this looks like it's fixed: https://codesandbox.io/s/infallible-shaw-o3iv4?file=/src/App.js~ \r\n\r\nEdit: Err. It's not fixed in that version.",
"I'll take on this.",
"I sent a pull request.\r\nLook at [#18928](https://githu... | 2020-04-28 15:13:02 | 2021-06-07 21:47:18 | 2021-06-07 21:47:18 | NONE | null | null | null | React version: 16.13.1
## Steps To Reproduce
```js
import React, { Suspense, lazy } from "react";
const Async = lazy(() => {}); // <------
let App = () => {
return (
<Suspense fallback={"Loading"}>
<Async />
</Suspense>
);
};
export default App;
```
Link to code example: https://codes... | {'url': 'https://api.github.com/repos/facebook/react/issues/18768/reactions', 'total_count': 4, '+1': 4, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18768/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18767 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18767/labels{/name} | https://api.github.com/repos/facebook/react/issues/18767/comments | https://api.github.com/repos/facebook/react/issues/18767/events | https://github.com/facebook/react/issues/18767 | 608,338,445 | MDU6SXNzdWU2MDgzMzg0NDU= | 18,767 | React hydrate mismatch with Suspense component | {'login': 'liximomo', 'id': 9816225, 'node_id': 'MDQ6VXNlcjk4MTYyMjU=', 'avatar_url': 'https://avatars.githubusercontent.com/u/9816225?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/liximomo', 'html_url': 'https://github.com/liximomo', 'followers_url': 'https://api.github.com/users/liximomo/followers', '... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"I guess hydrate() should warn if it encounters features that aren't supported for server-side rendering. \r\n\r\nIf you pass the same component to `renderToString` react-dom will throw `ReactDOMServer does not yet support Suspense.`. The docs for `hydrate()` specifically mention that it can only hydrate containers... | 2020-04-28 13:54:24 | 2020-07-27 19:00:11 | 2020-07-27 19:00:11 | NONE | null | null | null | It appears you will have a mismatch warning when hydrating in conjunction with a client-side `<Suspense>` component which has a fallback element.
CodeSandbox: https://codesandbox.io/s/zealous-burnell-i79n... | {'url': 'https://api.github.com/repos/facebook/react/issues/18767/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18767/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18766 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18766/labels{/name} | https://api.github.com/repos/facebook/react/issues/18766/comments | https://api.github.com/repos/facebook/react/issues/18766/events | https://github.com/facebook/react/pull/18766 | 608,229,179 | MDExOlB1bGxSZXF1ZXN0NDEwMDQ2MTEx | 18,766 | Refactor ElementListenerMap to use expando properties | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18766/builds/23106) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-28 11:05:57 | 2020-04-28 21:02:15 | 2020-04-28 20:53:54 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18766', 'html_url': 'https://github.com/facebook/react/pull/18766', 'diff_url': 'https://github.com/facebook/react/pull/18766.diff', 'patch_url': 'https://github.com/facebook/react/pull/18766.patch', 'merged_at': datetime.datetime(2020, 4, 28, 20, 53, 54)} | Note: Last year, I originally made the change that moved this code to use WeakMaps in https://github.com/facebook/react/pull/15036.
I recently did some profiling and noticed that we are spending quite a bit of time accessing and setting Maps on `DOMEventListenerMap`'s WeakMap for each element when using the Modern ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18766/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18766/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18765 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18765/labels{/name} | https://api.github.com/repos/facebook/react/issues/18765/comments | https://api.github.com/repos/facebook/react/issues/18765/events | https://github.com/facebook/react/pull/18765 | 608,208,543 | MDExOlB1bGxSZXF1ZXN0NDEwMDI5NzQ3 | 18,765 | Add react-window as devDependency and drop embedded copy | {'login': 'pravi', 'id': 708222, 'node_id': 'MDQ6VXNlcjcwODIyMg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/708222?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pravi', 'html_url': 'https://github.com/pravi', 'followers_url': 'https://api.github.com/users/pravi/followers', 'following_url'... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18765/builds/22998) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-28 10:33:11 | 2020-08-08 07:41:24 | 2020-08-08 07:41:24 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18765', 'html_url': 'https://github.com/facebook/react/pull/18765', 'diff_url': 'https://github.com/facebook/react/pull/18765.diff', 'patch_url': 'https://github.com/facebook/react/pull/18765.patch', 'merged_at': None} | ## Summary
Fixes #18762
## Test Plan
<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->
| {'url': 'https://api.github.com/repos/facebook/react/issues/18765/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18765/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18764 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18764/labels{/name} | https://api.github.com/repos/facebook/react/issues/18764/comments | https://api.github.com/repos/facebook/react/issues/18764/events | https://github.com/facebook/react/issues/18764 | 608,175,493 | MDU6SXNzdWU2MDgxNzU0OTM= | 18,764 | Bug: npm run build error | {'login': 'meghanar121', 'id': 52892025, 'node_id': 'MDQ6VXNlcjUyODkyMDI1', 'avatar_url': 'https://avatars.githubusercontent.com/u/52892025?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/meghanar121', 'html_url': 'https://github.com/meghanar121', 'followers_url': 'https://api.github.com/users/meghanar121... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Please report this bug in the Create React App repo:\r\nhttps://github.com/facebook/create-react-app\r\n\r\nThis is the React repo. Different teams maintain each of these projects.\r\n\r\nYou'll probably also need to include more information than what you listed above in order for someone to be able to help you th... | 2020-04-28 09:44:02 | 2020-04-28 23:21:46 | 2020-04-28 23:21:46 | NONE | null | null | null | **i am not able run build command, it shows compileerror in css selector undefined**
PS C:\Users\megha\OneDrive\Desktop\Weather\weatherapp> npm run build
> weatherapp@0.1.0 build C:\Users\megha\OneDrive\Desktop\Weather\weatherapp
> react-scripts build
Creating an optimized production build...
Failed to c... | {'url': 'https://api.github.com/repos/facebook/react/issues/18764/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18764/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18763 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18763/labels{/name} | https://api.github.com/repos/facebook/react/issues/18763/comments | https://api.github.com/repos/facebook/react/issues/18763/events | https://github.com/facebook/react/pull/18763 | 608,145,733 | MDExOlB1bGxSZXF1ZXN0NDA5OTgwNDk5 | 18,763 | Drop generated files (dist) from source tree (src is enough to build) | {'login': 'pravi', 'id': 708222, 'node_id': 'MDQ6VXNlcjcwODIyMg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/708222?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pravi', 'html_url': 'https://github.com/pravi', 'followers_url': 'https://api.github.com/users/pravi/followers', 'following_url'... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18763/builds/22990) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-28 08:59:51 | 2020-04-28 10:56:11 | 2020-04-28 10:56:11 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18763', 'html_url': 'https://github.com/facebook/react/pull/18763', 'diff_url': 'https://github.com/facebook/react/pull/18763.diff', 'patch_url': 'https://github.com/facebook/react/pull/18763.patch', 'merged_at': None} | ## Summary
Fixes: #18762
## Test Plan
Build was passing with dist removed.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18763/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18763/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18762 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18762/labels{/name} | https://api.github.com/repos/facebook/react/issues/18762/comments | https://api.github.com/repos/facebook/react/issues/18762/events | https://github.com/facebook/react/issues/18762 | 608,134,791 | MDU6SXNzdWU2MDgxMzQ3OTE= | 18,762 | Bug: generated files in source tree for react-window node module | {'login': 'pravi', 'id': 708222, 'node_id': 'MDQ6VXNlcjcwODIyMg==', 'avatar_url': 'https://avatars.githubusercontent.com/u/708222?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/pravi', 'html_url': 'https://github.com/pravi', 'followers_url': 'https://api.github.com/users/pravi/followers', 'following_url'... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"Build is passing if dist directory (packages/react-devtools-shared/src/node_modules/react-window/dist) is dropped.",
"It is an intentional fork with a couple of small concurrent mode specific tweaks added. Eventually I will port those changes to the main react-window (probably). For now the fork is intentional t... | 2020-04-28 08:43:30 | 2020-08-08 07:41:41 | 2020-08-08 07:41:41 | NONE | null | null | null | react-devetools-shared module has a coy of react-window node module ->
https://github.com/facebook/react/tree/master/packages/react-devtools-shared/src/node_modules/react-window
Can this be added to devDependencies in package.json instead? Or if that is not possible, can it be replaced with its source from github r... | {'url': 'https://api.github.com/repos/facebook/react/issues/18762/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18762/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18761 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18761/labels{/name} | https://api.github.com/repos/facebook/react/issues/18761/comments | https://api.github.com/repos/facebook/react/issues/18761/events | https://github.com/facebook/react/issues/18761 | 608,077,672 | MDU6SXNzdWU2MDgwNzc2NzI= | 18,761 | Bug: using useState without changing the state generate a useless rerender | {'login': 'Sharcoux', 'id': 797545, 'node_id': 'MDQ6VXNlcjc5NzU0NQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/797545?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/Sharcoux', 'html_url': 'https://github.com/Sharcoux', 'followers_url': 'https://api.github.com/users/Sharcoux/followers', 'fo... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | true | null | [] | null | [
"Same problem. When removing React.StrictMode it solves the problem",
"> Same problem. When removing React.StrictMode it solves the problem\r\n\r\nWhen removing useState and useEffect it solves the problem,too.",
"> > Same problem. When removing React.StrictMode it solves the problem\r\n> \r\n> When removing us... | 2020-04-28 07:05:50 | 2022-03-30 18:08:49 | 2020-07-09 12:41:09 | NONE | resolved | null | null | <!--
Please provide a clear and concise description of what the bug is. Include
screenshots if needed. Please test using the latest version of the relevant
React packages to make sure your issue has not already been fixed.
-->
When using useState in a component, this component will rerender twice, whereas ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18761/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18761/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18760 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18760/labels{/name} | https://api.github.com/repos/facebook/react/issues/18760/comments | https://api.github.com/repos/facebook/react/issues/18760/events | https://github.com/facebook/react/pull/18760 | 608,056,285 | MDExOlB1bGxSZXF1ZXN0NDA5OTA3ODgz | 18,760 | Lint rule: prefer-lazy-initialization | {'login': 'vikr01', 'id': 28772991, 'node_id': 'MDQ6VXNlcjI4NzcyOTkx', 'avatar_url': 'https://avatars.githubusercontent.com/u/28772991?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/vikr01', 'html_url': 'https://github.com/vikr01', 'followers_url': 'https://api.github.com/users/vikr01/followers', 'follow... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775957182, 'node_id': 'MDU6TGFiZWwxNzc1OTU3MTgy', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18760/builds/22926) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-28 06:20:38 | 2020-08-08 07:41:25 | 2020-08-08 07:41:25 | NONE | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18760', 'html_url': 'https://github.com/facebook/react/pull/18760', 'diff_url': 'https://github.com/facebook/react/pull/18760.diff', 'patch_url': 'https://github.com/facebook/react/pull/18760.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18760/reactions', 'total_count': 4, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 1, 'confused': 0, 'heart': 1, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18760/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18759 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18759/labels{/name} | https://api.github.com/repos/facebook/react/issues/18759/comments | https://api.github.com/repos/facebook/react/issues/18759/events | https://github.com/facebook/react/pull/18759 | 607,956,240 | MDExOlB1bGxSZXF1ZXN0NDA5ODI5OTE1 | 18,759 | Allow flushSync to noop in life cycles but with a warning | {'login': 'sebmarkbage', 'id': 63648, 'node_id': 'MDQ6VXNlcjYzNjQ4', 'avatar_url': 'https://avatars.githubusercontent.com/u/63648?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/sebmarkbage', 'html_url': 'https://github.com/sebmarkbage', 'followers_url': 'https://api.github.com/users/sebmarkbage/followers... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18759/builds/22894) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-28 01:25:27 | 2020-04-28 03:07:40 | 2020-04-28 03:07:40 | COLLABORATOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18759', 'html_url': 'https://github.com/facebook/react/pull/18759', 'diff_url': 'https://github.com/facebook/react/pull/18759.diff', 'patch_url': 'https://github.com/facebook/react/pull/18759.patch', 'merged_at': datetime.datetime(2020, 4, 28, 3, 7, 40)} | We already did this for flushControlled before.
It doesn't make sense to flush in a life-cycle or render because React can't do the work right then. Even if we did, it would make all other life-cycles more confusing.
There might be some opportunity by flushing right at the end of a React batch to do a second one.... | {'url': 'https://api.github.com/repos/facebook/react/issues/18759/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18759/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18758 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18758/labels{/name} | https://api.github.com/repos/facebook/react/issues/18758/comments | https://api.github.com/repos/facebook/react/issues/18758/events | https://github.com/facebook/react/issues/18758 | 607,852,922 | MDU6SXNzdWU2MDc4NTI5MjI= | 18,758 | Jest: Cannot assign to read only property '...' of object '...' | {'login': 'bvaughn', 'id': 29597, 'node_id': 'MDQ6VXNlcjI5NTk3', 'avatar_url': 'https://avatars.githubusercontent.com/u/29597?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bvaughn', 'html_url': 'https://github.com/bvaughn', 'followers_url': 'https://api.github.com/users/bvaughn/followers', 'following_ur... | [] | closed | true | null | [] | null | [
"I'm having this as well. For me it is happening at this line:\r\n```js\r\nexpect(getByLabelText('YYYY')).toBe(document.activeElement);\r\n```",
"Same here, for me in:\r\n\r\n```js\r\nexpect(fn.mock.calls).toEqual([[element]]);\r\n```\r\nThe assertion had failed because the expectation was incorrect. After the ex... | 2020-04-27 21:05:31 | 2021-03-24 19:00:06 | 2021-03-24 19:00:06 | CONTRIBUTOR | off-topic | null | null | Right now in the React repo this test...
```js
fit('blah', () => {
expect(document.createElement('div')).toBe(document.createElement('div'));
});
```
...fails with the following meaningless error message:
> TypeError: Cannot assign to read only property 'Symbol(impl)' of object '[object DOMImplementation]'
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18758/reactions', 'total_count': 9, '+1': 8, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18758/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18757 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18757/labels{/name} | https://api.github.com/repos/facebook/react/issues/18757/comments | https://api.github.com/repos/facebook/react/issues/18757/events | https://github.com/facebook/react/issues/18757 | 607,803,745 | MDU6SXNzdWU2MDc4MDM3NDU= | 18,757 | chrome | {'login': 'bomkee', 'id': 7354684, 'node_id': 'MDQ6VXNlcjczNTQ2ODQ=', 'avatar_url': 'https://avatars.githubusercontent.com/u/7354684?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bomkee', 'html_url': 'https://github.com/bomkee', 'followers_url': 'https://api.github.com/users/bomkee/followers', 'followin... | [] | closed | false | null | [] | null | [] | 2020-04-27 19:41:44 | 2020-04-27 19:42:03 | 2020-04-27 19:42:03 | NONE | null | null | null | 👉 Please follow one of these issue templates:
- https://github.com/facebook/react/issues/new/choose
Note: to keep the backlog clean and actionable, issues may be immediately closed if they do not follow one of the above issue templates.
| {'url': 'https://api.github.com/repos/facebook/react/issues/18757/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18757/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18756 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18756/labels{/name} | https://api.github.com/repos/facebook/react/issues/18756/comments | https://api.github.com/repos/facebook/react/issues/18756/events | https://github.com/facebook/react/pull/18756 | 607,735,386 | MDExOlB1bGxSZXF1ZXN0NDA5NjUwODI3 | 18,756 | Add experimental ReactDOM.createEventHandle | {'login': 'trueadm', 'id': 1519870, 'node_id': 'MDQ6VXNlcjE1MTk4NzA=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1519870?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/trueadm', 'html_url': 'https://github.com/trueadm', 'followers_url': 'https://api.github.com/users/trueadm/followers', 'foll... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 1775958285, 'node_id': 'MDU6TGFiZWwxNzc1OTU4Mjg1', 'url': 'https://api.github.com/repos/facebook/rea... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18756/builds/26297) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-27 17:50:27 | 2020-05-12 19:24:29 | 2020-05-12 19:24:26 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18756', 'html_url': 'https://github.com/facebook/react/pull/18756', 'diff_url': 'https://github.com/facebook/react/pull/18756.diff', 'patch_url': 'https://github.com/facebook/react/pull/18756.patch', 'merged_at': datetime.datetime(2020, 5, 12, 19, 24, 26)} | This PR adds the experimental `ReactDOM.createEventHandle` API. This works similar to how the recently removed `ReactDOM.useEvent` works, and provides an event handle object that can be use to set and clear listeners.
```jsx
const clickHandle = ReactDOM.createEventHandle('click')
function Component() {
const ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18756/reactions', 'total_count': 6, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 5, 'rocket': 0, 'eyes': 1} | https://api.github.com/repos/facebook/react/issues/18756/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18755 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18755/labels{/name} | https://api.github.com/repos/facebook/react/issues/18755/comments | https://api.github.com/repos/facebook/react/issues/18755/events | https://github.com/facebook/react/pull/18755 | 607,715,560 | MDExOlB1bGxSZXF1ZXN0NDA5NjM1MDA2 | 18,755 | Allow Node 14.x | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18755/builds/22822) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-27 17:17:59 | 2020-04-28 14:57:45 | 2020-04-28 14:57:45 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18755', 'html_url': 'https://github.com/facebook/react/pull/18755', 'diff_url': 'https://github.com/facebook/react/pull/18755.diff', 'patch_url': 'https://github.com/facebook/react/pull/18755.patch', 'merged_at': datetime.datetime(2020, 4, 28, 14, 57, 45)} | {'url': 'https://api.github.com/repos/facebook/react/issues/18755/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18755/timeline | null | null | true | |
https://api.github.com/repos/facebook/react/issues/18754 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18754/labels{/name} | https://api.github.com/repos/facebook/react/issues/18754/comments | https://api.github.com/repos/facebook/react/issues/18754/events | https://github.com/facebook/react/issues/18754 | 607,621,092 | MDU6SXNzdWU2MDc2MjEwOTI= | 18,754 | Error: "Commit tree does not contain fiber 3204. This is a bug in React DevTools." | {'login': 'jucian0', 'id': 8399579, 'node_id': 'MDQ6VXNlcjgzOTk1Nzk=', 'avatar_url': 'https://avatars.githubusercontent.com/u/8399579?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/jucian0', 'html_url': 'https://github.com/jucian0', 'followers_url': 'https://api.github.com/users/jucian0/followers', 'foll... | [{'id': 40929151, 'node_id': 'MDU6TGFiZWw0MDkyOTE1MQ==', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Bug', 'name': 'Type: Bug', 'color': 'b60205', 'default': False, 'description': None}
{'id': 40929152, 'node_id': 'MDU6TGFiZWw0MDkyOTE1Mg==', 'url': 'https://api.github.com/repos/facebook/react/la... | closed | false | null | [] | null | [
"Can you reproduce this behavior?\r\n\r\nIf so, can you please share the repro steps with us?",
"Closing due to lack of a response. Maybe we'll get repro information from the duplicate #18831"
] | 2020-04-27 15:01:21 | 2020-05-07 23:36:13 | 2020-05-07 23:36:05 | NONE | null | null | null | When I try to navigate in commits React Dev Tools Profiler I get this error:
"Commit tree does not contain fiber 8562."
DevTools version: 4.6.0-6cceaeb67
Component stack: in... | {'url': 'https://api.github.com/repos/facebook/react/issues/18754/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18754/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18753 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18753/labels{/name} | https://api.github.com/repos/facebook/react/issues/18753/comments | https://api.github.com/repos/facebook/react/issues/18753/events | https://github.com/facebook/react/issues/18753 | 607,471,819 | MDU6SXNzdWU2MDc0NzE4MTk= | 18,753 | Bug: onMouseLeave does not trigger on disabled button | {'login': 'raunofreiberg', 'id': 23662329, 'node_id': 'MDQ6VXNlcjIzNjYyMzI5', 'avatar_url': 'https://avatars.githubusercontent.com/u/23662329?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/raunofreiberg', 'html_url': 'https://github.com/raunofreiberg', 'followers_url': 'https://api.github.com/users/rauno... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"If you put the button inside a div, event works fine! But I don't know the reason:\r\n\r\n```\r\n <div onMouseEnter={show} onMouseLeave={hide} style={{ border: \"1px solid red\"}} >\r\n <button disabled>\r\n Hover me!\r\n </button>\r\n </div>\r\n```\r\n",
"has been resolved by `o... | 2020-04-27 11:32:02 | 2020-07-15 16:11:50 | 2020-05-19 11:57:41 | CONTRIBUTOR | null | null | null | Derived from https://github.com/facebook/react/issues/4251#issuecomment-591644826
<hr />
React version: 16.13.1
## Steps To Reproduce
1. Hover over the disabled button
2. See tooltip appear
3. Hover away from the disabled button
4. Tooltip does not disappear
Link to code example: https://codesandbox.i... | {'url': 'https://api.github.com/repos/facebook/react/issues/18753/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18753/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18752 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18752/labels{/name} | https://api.github.com/repos/facebook/react/issues/18752/comments | https://api.github.com/repos/facebook/react/issues/18752/events | https://github.com/facebook/react/issues/18752 | 607,468,212 | MDU6SXNzdWU2MDc0NjgyMTI= | 18,752 | Bug: <iframe /> onLoad is not getting triggered after the reload triggered by moving the DOM Node | {'login': 'adamziel', 'id': 205419, 'node_id': 'MDQ6VXNlcjIwNTQxOQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/205419?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/adamziel', 'html_url': 'https://github.com/adamziel', 'followers_url': 'https://api.github.com/users/adamziel/followers', 'fo... | [{'id': 710722093, 'node_id': 'MDU6TGFiZWw3MTA3MjIwOTM=', 'url': 'https://api.github.com/repos/facebook/react/labels/Type:%20Needs%20Investigation', 'name': 'Type: Needs Investigation', 'color': '65AA9C', 'default': False, 'description': ''}] | open | false | null | [] | null | [
"Potentially related? https://github.com/facebook/react/blob/4e3545fd6fc62842d7dbf772923214474f59871a/packages/react-dom/src/events/ReactDOMEventListener.js#L318-L324",
"> The iframe should say \"Initialized\".\r\n\r\nCan only reproduce this in the actual codesandbox browser preview in firefox 75. It's working fi... | 2020-04-27 11:26:46 | 2022-12-09 15:12:30 | null | NONE | null | null | null | When an `<iframe />` DOM Node is moved to a different place in the tree, Chrome triggers a reload. That reload does not notify event handlers registered via `onLoad=`. In other words:
* If there is an event handler registered via `onLoad={myCallback}`, it **will not** be fired.
* If there is an event handler regist... | {'url': 'https://api.github.com/repos/facebook/react/issues/18752/reactions', 'total_count': 2, '+1': 2, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18752/timeline | null | null | false |
https://api.github.com/repos/facebook/react/issues/18751 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18751/labels{/name} | https://api.github.com/repos/facebook/react/issues/18751/comments | https://api.github.com/repos/facebook/react/issues/18751/events | https://github.com/facebook/react/issues/18751 | 607,324,109 | MDU6SXNzdWU2MDczMjQxMDk= | 18,751 | How re-trigger a dialog model that opened on a clicked event? | {'login': 'mohit-llp', 'id': 44094302, 'node_id': 'MDQ6VXNlcjQ0MDk0MzAy', 'avatar_url': 'https://avatars.githubusercontent.com/u/44094302?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/mohit-llp', 'html_url': 'https://github.com/mohit-llp', 'followers_url': 'https://api.github.com/users/mohit-llp/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"Hey!\r\nI don't understand your issue, could you please describe it more details ?\r\nSince asking question here may be slow to get response, you should ask as clearly as possible.\r\nThank you!",
"I Fixed it.\r\nthanks"
] | 2020-04-27 07:56:26 | 2020-04-30 15:38:38 | 2020-04-30 15:38:38 | NONE | null | null | null | 
| {'url': 'https://api.github.com/repos/facebook/react/issues/18751/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18751/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18749 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18749/labels{/name} | https://api.github.com/repos/facebook/react/issues/18749/comments | https://api.github.com/repos/facebook/react/issues/18749/events | https://github.com/facebook/react/issues/18749 | 607,045,722 | MDU6SXNzdWU2MDcwNDU3MjI= | 18,749 | useEffect is never invoked in suspended component | {'login': 'JoseExposito', 'id': 1335948, 'node_id': 'MDQ6VXNlcjEzMzU5NDg=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1335948?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/JoseExposito', 'html_url': 'https://github.com/JoseExposito', 'followers_url': 'https://api.github.com/users/JoseExposi... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"> I'm not sure is this is the expected behaviour or a bug.\r\n\r\nThis is expected. `useEffect` is triggered after a component is rendered and committed. If it is suspended, it's not going to happen",
"With fetch-on-render, you have to have the *read itself* kick off the fetch. (Which is why fetch-on-render isn’... | 2020-04-26 15:59:07 | 2021-04-10 08:07:33 | 2020-04-26 16:16:03 | NONE | null | null | null | I'm trying to Fetch-On-Render (inside a `useEffect` hook) some data that depends on my component's props.
My component tree is wrapped in a `Suspense` component and the component that fetches data is a couple of levels down the tree.
Because the `useEffect` hook is in a suspended component it never gets invoked.
... | {'url': 'https://api.github.com/repos/facebook/react/issues/18749/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18749/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18748 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18748/labels{/name} | https://api.github.com/repos/facebook/react/issues/18748/comments | https://api.github.com/repos/facebook/react/issues/18748/events | https://github.com/facebook/react/issues/18748 | 607,036,106 | MDU6SXNzdWU2MDcwMzYxMDY= | 18,748 | useEffect hook not working in production due to minified react-dom.production.min.js | {'login': 'prav2508', 'id': 27601632, 'node_id': 'MDQ6VXNlcjI3NjAxNjMy', 'avatar_url': 'https://avatars.githubusercontent.com/u/27601632?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/prav2508', 'html_url': 'https://github.com/prav2508', 'followers_url': 'https://api.github.com/users/prav2508/followers',... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"@prav2508 Could you create a reproduce case on the online playgrounds?\r\nhttps://reactjs.org/docs/getting-started.html#online-playgrounds",
"issue is fixed, i had difference in react dom and react..\r\nthanks :)"
] | 2020-04-26 15:15:08 | 2020-04-29 17:16:38 | 2020-04-29 17:16:37 | NONE | null | null | null | TypeError: Cannot read property 'map' of undefined
at S (insights.js:265)
at qa (react-dom.production.min.js:153)
at Lo (react-dom.production.min.js:175)
at ml (react-dom.production.min.js:263)
at us (react-dom.production.min.js:246)
at ls (react-dom.production.min.js:246)
at Jl (reac... | {'url': 'https://api.github.com/repos/facebook/react/issues/18748/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18748/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18747 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18747/labels{/name} | https://api.github.com/repos/facebook/react/issues/18747/comments | https://api.github.com/repos/facebook/react/issues/18747/events | https://github.com/facebook/react/issues/18747 | 607,028,019 | MDU6SXNzdWU2MDcwMjgwMTk= | 18,747 | Using the tsconfig file to configure the alias does not take effect | {'login': 'VitaminCtea', 'id': 35827111, 'node_id': 'MDQ6VXNlcjM1ODI3MTEx', 'avatar_url': 'https://avatars.githubusercontent.com/u/35827111?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/VitaminCtea', 'html_url': 'https://github.com/VitaminCtea', 'followers_url': 'https://api.github.com/users/VitaminCtea... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}
{'id': 1775957182, 'node_id': 'MDU6... | closed | false | null | [] | null | [
"@VitaminCtea This is not an issue of React itself, so you should issue this to https://github.com/facebook/create-react-app",
"@koba04 ok, thank you!",
"@VitaminCtea Could you close this issue?",
"@koba04 Yes! Thanks for reminding",
"This issue has been automatically marked as stale. **If this issue is sti... | 2020-04-26 14:38:10 | 2020-08-16 07:23:52 | 2020-08-16 07:23:52 | NONE | null | null | null | The project was generated using the create-react-app scaffolding, and the paths option was removed when I used the tsconfig.json file to configure the path alias! Then I tried to use the extends property in the tsconfig.json file to connect to the external path configuration file, but it didn't work either! Using the c... | {'url': 'https://api.github.com/repos/facebook/react/issues/18747/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18747/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18746 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18746/labels{/name} | https://api.github.com/repos/facebook/react/issues/18746/comments | https://api.github.com/repos/facebook/react/issues/18746/events | https://github.com/facebook/react/pull/18746 | 607,026,219 | MDExOlB1bGxSZXF1ZXN0NDA5MDkzMzUw | 18,746 | DevTools: Keyboard arrow-key navigation for the flamegraph view | {'login': 'ChrisDobby', 'id': 434389, 'node_id': 'MDQ6VXNlcjQzNDM4OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/434389?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ChrisDobby', 'html_url': 'https://github.com/ChrisDobby', 'followers_url': 'https://api.github.com/users/ChrisDobby/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}
{'id': 710573595, 'node_id': 'MDU6TGFiZWw3MTA1NzM1OTU=', 'url': 'https://api.github.com/repos/facebook/reac... | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18746/builds/46575) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-26 14:30:21 | 2021-07-24 08:46:33 | 2021-07-14 23:52:06 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18746', 'html_url': 'https://github.com/facebook/react/pull/18746', 'diff_url': 'https://github.com/facebook/react/pull/18746.diff', 'patch_url': 'https://github.com/facebook/react/pull/18746.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18746/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18746/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18745 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18745/labels{/name} | https://api.github.com/repos/facebook/react/issues/18745/comments | https://api.github.com/repos/facebook/react/issues/18745/events | https://github.com/facebook/react/pull/18745 | 606,999,480 | MDExOlB1bGxSZXF1ZXN0NDA5MDc0MzYy | 18,745 | [DevTools] Add Component Highlighting to Profiler | {'login': 'bl00mber', 'id': 16987322, 'node_id': 'MDQ6VXNlcjE2OTg3MzIy', 'avatar_url': 'https://avatars.githubusercontent.com/u/16987322?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/bl00mber', 'html_url': 'https://github.com/bl00mber', 'followers_url': 'https://api.github.com/users/bl00mber/followers',... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18745/builds/27388) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-26 12:22:16 | 2020-05-18 18:13:17 | 2020-05-18 18:13:17 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18745', 'html_url': 'https://github.com/facebook/react/pull/18745', 'diff_url': 'https://github.com/facebook/react/pull/18745.diff', 'patch_url': 'https://github.com/facebook/react/pull/18745.patch', 'merged_at': datetime.datetime(2020, 5, 18, 18, 13, 17)} | close #17928
This is the update of #17934 if @M-Izadmehr don't mind!
- useNativeElementHighlighter → useHighlightNativeElement
- highlightNativeElement → highlightNativeElement
- clearNativeElementHighlight → clearHighlightNativeElement
- Add missing dependencies | {'url': 'https://api.github.com/repos/facebook/react/issues/18745/reactions', 'total_count': 1, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 1, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18745/timeline | null | null | true |
https://api.github.com/repos/facebook/react/issues/18744 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18744/labels{/name} | https://api.github.com/repos/facebook/react/issues/18744/comments | https://api.github.com/repos/facebook/react/issues/18744/events | https://github.com/facebook/react/issues/18744 | 606,994,835 | MDU6SXNzdWU2MDY5OTQ4MzU= | 18,744 | Bug: I am not able to change the css 'height' property dynamically. | {'login': 'amandhaka', 'id': 46739076, 'node_id': 'MDQ6VXNlcjQ2NzM5MDc2', 'avatar_url': 'https://avatars.githubusercontent.com/u/46739076?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/amandhaka', 'html_url': 'https://github.com/amandhaka', 'followers_url': 'https://api.github.com/users/amandhaka/followe... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"@amandhaka if you're attempting to use [template literals](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals) when you're doing `barOneStyle.height='${newHeight}px'`, you need to use the **\\`** (backtick) character; you're trying to use a `'` (single quote) character at the momen... | 2020-04-26 11:58:20 | 2020-05-06 13:05:01 | 2020-05-06 13:05:01 | NONE | null | null | null | I am trying to change the height of elements whenever an event occur. But that's not working with the following code. The code `${newHeight}px` is not working.
```
array.map((value,idx) => (
<div
className="array-bar"
key={idx}
style={{height: value,backgroundColor:'turquoise'}}></div>
))
const[barOne,newHei... | {'url': 'https://api.github.com/repos/facebook/react/issues/18744/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18744/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18743 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18743/labels{/name} | https://api.github.com/repos/facebook/react/issues/18743/comments | https://api.github.com/repos/facebook/react/issues/18743/events | https://github.com/facebook/react/issues/18743 | 606,977,794 | MDU6SXNzdWU2MDY5Nzc3OTQ= | 18,743 | Feature request: a function for conditional rendering | {'login': 'finom', 'id': 1082083, 'node_id': 'MDQ6VXNlcjEwODIwODM=', 'avatar_url': 'https://avatars.githubusercontent.com/u/1082083?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/finom', 'html_url': 'https://github.com/finom', 'followers_url': 'https://api.github.com/users/finom/followers', 'following_ur... | [{'id': 155984160, 'node_id': 'MDU6TGFiZWwxNTU5ODQxNjA=', 'url': 'https://api.github.com/repos/facebook/react/labels/Status:%20Unconfirmed', 'name': 'Status: Unconfirmed', 'color': 'd4c5f9', 'default': False, 'description': "A potential issue that we haven't yet confirmed as a bug"}] | closed | false | null | [] | null | [
"@finom As a developer, I would prefer to use : \r\n```jsx\r\n...\r\n<div>\r\n { ifSomething && <MyComponent prop=\"foo\" /> }\r\n</div>\r\n...\r\n```\r\nWhy? \r\n- I see your feature request as the introduction of unnecessary abstraction used for the cases which are easy to solve with native support of the JS/JS... | 2020-04-26 10:30:13 | 2020-05-04 15:51:28 | 2020-05-04 15:51:28 | NONE | null | null | null | Sorry, I didn't find any issue template for feature requests, but I hope it's fine.
The problem I'm trying to solve is to nicely develop components which usually require usage of ternary expressions.
```js
{ifSomething ? (
<A prop="foo">children</A>
) : null}
```
It looks not nice and I have to use a thi... | {'url': 'https://api.github.com/repos/facebook/react/issues/18743/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18743/timeline | null | completed | false |
https://api.github.com/repos/facebook/react/issues/18742 | https://api.github.com/repos/facebook/react | https://api.github.com/repos/facebook/react/issues/18742/labels{/name} | https://api.github.com/repos/facebook/react/issues/18742/comments | https://api.github.com/repos/facebook/react/issues/18742/events | https://github.com/facebook/react/pull/18742 | 606,970,809 | MDExOlB1bGxSZXF1ZXN0NDA5MDUzNzU3 | 18,742 | DevTools: Keyboard arrow-key navigation for the flamegraph view | {'login': 'ChrisDobby', 'id': 434389, 'node_id': 'MDQ6VXNlcjQzNDM4OQ==', 'avatar_url': 'https://avatars.githubusercontent.com/u/434389?v=4', 'gravatar_id': '', 'url': 'https://api.github.com/users/ChrisDobby', 'html_url': 'https://github.com/ChrisDobby', 'followers_url': 'https://api.github.com/users/ChrisDobby/followe... | [{'id': 196858374, 'node_id': 'MDU6TGFiZWwxOTY4NTgzNzQ=', 'url': 'https://api.github.com/repos/facebook/react/labels/CLA%20Signed', 'name': 'CLA Signed', 'color': 'e7e7e7', 'default': False, 'description': None}] | closed | false | null | [] | null | [
"This pull request is automatically built and testable in [CodeSandbox](https://codesandbox.io).\n\n To see build info of the built libraries, click [here](https://ci.codesandbox.io/status/facebook/react/pr/18742/builds/22491) or the icon next to each commit SHA.\n\nLatest deployment of this branch, based on commi... | 2020-04-26 09:54:43 | 2020-04-26 14:05:58 | 2020-04-26 14:05:58 | CONTRIBUTOR | null | false | {'url': 'https://api.github.com/repos/facebook/react/pulls/18742', 'html_url': 'https://github.com/facebook/react/pull/18742', 'diff_url': 'https://github.com/facebook/react/pull/18742.diff', 'patch_url': 'https://github.com/facebook/react/pull/18742.patch', 'merged_at': None} | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork ... | {'url': 'https://api.github.com/repos/facebook/react/issues/18742/reactions', 'total_count': 0, '+1': 0, '-1': 0, 'laugh': 0, 'hooray': 0, 'confused': 0, 'heart': 0, 'rocket': 0, 'eyes': 0} | https://api.github.com/repos/facebook/react/issues/18742/timeline | null | null | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.